Imported Upstream version 14.30.0
[platform/upstream/libzypp.git] / zypp / solver / detail / SATResolver.cc
index 8e70f4a..f1e1753 100644 (file)
@@ -52,10 +52,30 @@ extern "C"
 #include "zypp/solver/detail/SolverQueueItemDelete.h"
 #include "zypp/solver/detail/SystemCheck.h"
 #include "zypp/sat/Transaction.h"
+#include "zypp/sat/Queue.h"
 
 /////////////////////////////////////////////////////////////////////////
 namespace zypp
 { ///////////////////////////////////////////////////////////////////////
+
+  /////////////////////////////////////////////////////////////////////////
+  namespace env
+  {
+    inline bool HACKENV( const char * var_r, bool default_r )
+    {
+      bool ret = default_r;
+      const char * val = ::getenv( var_r );
+      if ( val )
+      {
+       ret = str::strToBool( val, default_r );
+       if ( ret != default_r )
+         INT << "HACKENV " << var_r << " = " << ret << endl;
+      }
+      return ret;
+    }
+  } // namespace env
+  /////////////////////////////////////////////////////////////////////////
+
   ///////////////////////////////////////////////////////////////////////
   namespace solver
   { /////////////////////////////////////////////////////////////////////
@@ -111,20 +131,34 @@ SATResolver::dumpOn( std::ostream & os ) const
 {
     os << "<resolver>" << endl;
     if (_solv) {
-       // os << "  fixsystem = " << _solv->fixsystem << endl;
-       // os << "  updatesystem = " << _solv->updatesystem << endl;
-       os << "  allowdowngrade = " << solver_get_flag(_solv, SOLVER_FLAG_ALLOW_DOWNGRADE) << endl;
-       os << "  allowarchchange = " << solver_get_flag(_solv, SOLVER_FLAG_ALLOW_ARCHCHANGE) << endl;
-       os << "  allowvendorchange = " <<  solver_get_flag(_solv, SOLVER_FLAG_ALLOW_VENDORCHANGE) << endl;
-       os << "  allowuninstall = " << solver_get_flag(_solv, SOLVER_FLAG_ALLOW_UNINSTALL) << endl;
-       os << "  noupdateprovide = " << solver_get_flag(_solv, SOLVER_FLAG_NO_UPDATEPROVIDE) << endl;
-       os << "  dosplitprovides = " << solver_get_flag(_solv, SOLVER_FLAG_SPLITPROVIDES) << endl;
-       os << "  onlyRequires = " << solver_get_flag(_solv, SOLVER_FLAG_IGNORE_RECOMMENDED) << endl;
-       os << "  ignorealreadyrecommended = " << !solver_get_flag(_solv, SOLVER_FLAG_ADD_ALREADY_RECOMMENDED) << endl;
-       os << "  distupgrade = " << _distupgrade << endl;
-        os << "  distupgrade_removeunsupported = " << _distupgrade_removeunsupported << endl;
-       os << "  solveSrcPackages = " << _solveSrcPackages << endl;
-       os << "  cleandepsOnRemove = " << _cleandepsOnRemove << endl;
+#define OUTS(X) os << "  " << #X << "\t= " << solver_get_flag(_solv, SOLVER_FLAG_##X) << endl
+       OUTS( ALLOW_DOWNGRADE );
+       OUTS( ALLOW_ARCHCHANGE );
+       OUTS( ALLOW_VENDORCHANGE );
+       OUTS( ALLOW_UNINSTALL );
+       OUTS( NO_UPDATEPROVIDE );
+       OUTS( SPLITPROVIDES );
+       OUTS( IGNORE_RECOMMENDED );
+       OUTS( ADD_ALREADY_RECOMMENDED );
+       OUTS( NO_INFARCHCHECK );
+       OUTS( ALLOW_NAMECHANGE );
+       OUTS( KEEP_EXPLICIT_OBSOLETES );
+       OUTS( BEST_OBEY_POLICY );
+       OUTS( NO_AUTOTARGET );
+       OUTS( DUP_ALLOW_DOWNGRADE );
+       OUTS( DUP_ALLOW_ARCHCHANGE );
+       OUTS( DUP_ALLOW_VENDORCHANGE );
+       OUTS( DUP_ALLOW_NAMECHANGE );
+       OUTS( KEEP_ORPHANS );
+       OUTS( BREAK_ORPHANS );
+       OUTS( FOCUS_INSTALLED );
+       OUTS( YUM_OBSOLETES );
+#undef OUTS
+       os << "  distupgrade    = "     << _distupgrade << endl;
+        os << "  distupgrade_removeunsupported = " << _distupgrade_removeunsupported << endl;
+       os << "  solveSrcPackages       = "     << _solveSrcPackages << endl;
+       os << "  cleandepsOnRemove      = "     << _cleandepsOnRemove << endl;
+        os << "  fixsystem             = "     << _fixsystem << endl;
     } else {
        os << "<NULL>";
     }
@@ -146,7 +180,7 @@ SATResolver::SATResolver (const ResPool & pool, Pool *SATPool)
     , _noupdateprovide(false)
     , _dosplitprovides(false)
     , _onlyRequires(ZConfig::instance().solver_onlyRequires())
-    , _ignorealreadyrecommended(false)
+    , _ignorealreadyrecommended(true)
     , _distupgrade(false)
     , _distupgrade_removeunsupported(false)
     , _solveSrcPackages(false)
@@ -421,7 +455,7 @@ SATResolver::solving(const CapabilitySet & requires_caps,
                     const CapabilitySet & conflict_caps)
 {
     _solv = solver_create( _SATPool );
-    _solv->vendorCheckCb = &vendorCheck;
+    ::pool_set_custom_vendorcheck( _SATPool, &vendorCheck );
     if (_fixsystem) {
        queue_push( &(_jobQueue), SOLVER_VERIFY|SOLVER_SOLVABLE_ALL);
        queue_push( &(_jobQueue), 0 );
@@ -447,6 +481,13 @@ SATResolver::solving(const CapabilitySet & requires_caps,
     solver_set_flag(_solv, SOLVER_FLAG_NO_UPDATEPROVIDE, _noupdateprovide);
     solver_set_flag(_solv, SOLVER_FLAG_IGNORE_RECOMMENDED, _onlyRequires);
 
+#define HACKENV(X,D) solver_set_flag(_solv, X, env::HACKENV( #X, D ) );
+    HACKENV( SOLVER_FLAG_DUP_ALLOW_DOWNGRADE,  true );
+    HACKENV( SOLVER_FLAG_DUP_ALLOW_ARCHCHANGE, true );
+    HACKENV( SOLVER_FLAG_DUP_ALLOW_VENDORCHANGE,true );
+    HACKENV( SOLVER_FLAG_DUP_ALLOW_NAMECHANGE, true );
+#undef HACKENV
+
     sat::Pool::instance().prepareForSolving();
 
     // Solve !
@@ -519,11 +560,14 @@ SATResolver::solving(const CapabilitySet & requires_caps,
     Queue recommendations;
     Queue suggestions;
     Queue orphaned;
+    Queue unneeded;
     queue_init(&recommendations);
     queue_init(&suggestions);
     queue_init(&orphaned);
+    queue_init(&unneeded);
     solver_get_recommendations(_solv, &recommendations, &suggestions, 0);
     solver_get_orphaned(_solv, &orphaned);
+    solver_get_unneeded(_solv, &unneeded, 1);
     /*  solvables which are recommended */
     for ( int i = 0; i < recommendations.count; ++i )
     {
@@ -546,9 +590,18 @@ SATResolver::solving(const CapabilitySet & requires_caps,
       poolItem.status().setOrphaned( true );
       _problem_items.push_back( poolItem );
     }
+
+    /*  solvables which are unneeded */
+    for ( int i = 0; i < unneeded.count; ++i )
+    {
+      PoolItem poolItem( getPoolItem( unneeded.elements[i] ) );
+      poolItem.status().setUnneeded( true );
+    }
+
     queue_free(&recommendations);
     queue_free(&suggestions);
     queue_free(&orphaned);
+    queue_free(&unneeded);
 
     /* Write validation state back to pool */
     Queue flags, solvableQueue;
@@ -650,15 +703,7 @@ SATResolver::solverInit(const PoolItemList & weakItems)
       queue_push( &(_jobQueue), it->id() );
     }
 
-    if ( cleandepsOnRemove() )
-    {
-      // Add all items known to be installed by user request (not solver selected).
-      for_( it, sat::Pool::instance().onSystemByUserBegin(), sat::Pool::instance().onSystemByUserEnd() )
-      {
-       queue_push( &(_jobQueue), SOLVER_USERINSTALLED | SOLVER_SOLVABLE_NAME );
-       queue_push( &(_jobQueue), it->id() );
-      }
-    }
+    ::pool_add_userinstalled_jobs(_SATPool, sat::Pool::instance().autoInstalled(), &(_jobQueue), GET_USERINSTALLED_NAMES|GET_USERINSTALLED_INVERTED);
 
     if ( _distupgrade )
     {
@@ -673,8 +718,8 @@ SATResolver::solverInit(const PoolItemList & weakItems)
           if ( (*it)->onSystem() ) // (to install) or (not to delete)
           {
             Product::constPtr prodCand( (*it)->candidateAsKind<Product>() );
-            if ( ! prodCand || (*it)->identicalInstalledCandidate() )
-              continue; // product no longer available or unchanged
+            if ( ! prodCand )
+              continue; // product no longer available
 
             CapabilitySet droplist( prodCand->droplist() );
             dumpRangeLine( MIL << "Droplist for " << (*it)->candidateObj() << ": " << droplist.size() << " ", droplist.begin(), droplist.end() ) << endl;
@@ -832,7 +877,7 @@ void SATResolver::doUpdate()
     setLocks();
 
     _solv = solver_create( _SATPool );
-    _solv->vendorCheckCb = &vendorCheck;
+    ::pool_set_custom_vendorcheck( _SATPool, &vendorCheck );
     if (_fixsystem) {
        queue_push( &(_jobQueue), SOLVER_VERIFY|SOLVER_SOLVABLE_ALL);
        queue_push( &(_jobQueue), 0 );
@@ -984,6 +1029,9 @@ string SATResolver::SATprobleminfoString(Id problem, string &detail, Id &ignoreI
   sat::Solvable s, s2;
 
   ignoreId = 0;
+
+  // FIXME: solver_findallproblemrules to get all rules for this problem
+  // (the 'most relevabt' one returned by solver_findproblemrule is embedded
   probr = solver_findproblemrule(_solv, problem);
   switch (solver_ruleinfo(_solv, probr, &source, &target, &dep))
   {
@@ -1009,6 +1057,16 @@ string SATResolver::SATprobleminfoString(Id problem, string &detail, Id &ignoreI
          ret = str::form (_("nothing provides requested %s"), pool_dep2str(pool, dep));
          detail += _("Have you enabled all requested repositories?");
          break;
+      case SOLVER_RULE_JOB_UNKNOWN_PACKAGE:
+         ret = str::form (_("package %s does not exist"), pool_dep2str(pool, dep));
+         detail += _("Have you enabled all requested repositories?");
+         break;
+      case SOLVER_RULE_JOB_UNSUPPORTED:
+         ret = _("unsupported request");
+         break;
+      case SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM:
+         ret = str::form (_("%s is provided by the system and cannot be erased"), pool_dep2str(pool, dep));
+         break;
       case SOLVER_RULE_RPM_NOT_INSTALLABLE:
          s = mapSolvable (source);
          ret = str::form (_("%s is not installable"), s.asString().c_str());
@@ -1413,21 +1471,22 @@ void SATResolver::setLocks()
        }
     }
 
+    ///////////////////////////////////////////////////////////////////
+    // Weak locks: Ignore if an item with this name is already installed.
+    // If it's not installed try to keep it this way using a weak delete
+    ///////////////////////////////////////////////////////////////////
     std::set<IdString> unifiedByName;
     for (PoolItemList::const_iterator iter = _items_to_keep.begin(); iter != _items_to_keep.end(); ++iter) {
-       if (iter->status().isInstalled()) {
-           MIL << "Keep installed item " << *iter << endl;
-           queue_push( &(_jobQueue), SOLVER_INSTALL | SOLVER_SOLVABLE | SOLVER_WEAK );
-           queue_push( &(_jobQueue), (*iter)->satSolvable().id() );
-       } else {
-           IdString ident( (*iter)->satSolvable().ident() );
-           MIL << "Keep NOT installed name " << ident << " (" << *iter << ")" << endl;
-           if ( unifiedByName.insert( ident ).second )
-           {
-             queue_push( &(_jobQueue), SOLVER_ERASE | SOLVER_SOLVABLE_NAME | SOLVER_WEAK | MAYBE_CLEANDEPS );
-             queue_push( &(_jobQueue), ident.id() );
-           }
+      IdString ident( (*iter)->satSolvable().ident() );
+      if ( unifiedByName.insert( ident ).second )
+      {
+       if ( ! ui::Selectable::get( *iter )->hasInstalledObj() )
+       {
+         MIL << "Keep NOT installed name " << ident << " (" << *iter << ")" << endl;
+         queue_push( &(_jobQueue), SOLVER_ERASE | SOLVER_SOLVABLE_NAME | SOLVER_WEAK | MAYBE_CLEANDEPS );
+         queue_push( &(_jobQueue), ident.id() );
        }
+      }
     }
 }
 
@@ -1467,6 +1526,22 @@ void SATResolver::setSystemRequirements()
     }
 }
 
+sat::StringQueue SATResolver::autoInstalled() const
+{
+  sat::StringQueue ret;
+  if ( _solv )
+    ::solver_get_userinstalled( _solv, ret, GET_USERINSTALLED_NAMES|GET_USERINSTALLED_INVERTED );
+  return ret;
+}
+
+sat::StringQueue SATResolver::userInstalled() const
+{
+  sat::StringQueue ret;
+  if ( _solv )
+    ::solver_get_userinstalled( _solv, ret, GET_USERINSTALLED_NAMES );
+  return ret;
+}
+
 
 ///////////////////////////////////////////////////////////////////
 };// namespace detail