vpn-provider: Do not save or load provisioned VPN connections
[platform/upstream/connman.git] / vpn / vpn-provider.c
index c80027d..bb89ccf 100644 (file)
 #include "vpn-provider.h"
 #include "vpn.h"
 
-enum {
-       USER_ROUTES_CHANGED = 0x01,
-       SERVER_ROUTES_CHANGED = 0x02,
-};
-
 static DBusConnection *connection;
 static GHashTable *provider_hash;
 static GSList *driver_list;
@@ -56,6 +51,12 @@ struct vpn_route {
        char *gateway;
 };
 
+struct vpn_setting {
+       gboolean hide_value;
+       gboolean immutable;
+       char *value;
+};
+
 struct vpn_provider {
        int refcount;
        int index;
@@ -79,10 +80,15 @@ struct vpn_provider {
        struct vpn_ipconfig *ipconfig_ipv4;
        struct vpn_ipconfig *ipconfig_ipv6;
        char **nameservers;
-       int what_changed;
        guint notify_id;
+       char *config_file;
+       char *config_entry;
+       connman_bool_t immutable;
 };
 
+static void append_properties(DBusMessageIter *iter,
+                               struct vpn_provider *provider);
+
 static void free_route(gpointer data)
 {
        struct vpn_route *route = data;
@@ -94,6 +100,14 @@ static void free_route(gpointer data)
        g_free(route);
 }
 
+static void free_setting(gpointer data)
+{
+       struct vpn_setting *setting = data;
+
+       g_free(setting->value);
+       g_free(setting);
+}
+
 static void append_route(DBusMessageIter *iter, void *user_data)
 {
        struct vpn_route *route = user_data;
@@ -164,15 +178,11 @@ static void send_routes(struct vpn_provider *provider, GHashTable *routes,
                                        routes);
 }
 
-static int provider_property_changed(struct vpn_provider *provider,
-                               const char *name)
+static int provider_routes_changed(struct vpn_provider *provider)
 {
-       DBG("provider %p name %s", provider, name);
+       DBG("provider %p", provider);
 
-       if (g_str_equal(name, "UserRoutes") == TRUE)
-               send_routes(provider, provider->user_routes, name);
-       else if (g_str_equal(name, "ServerRoutes") == TRUE)
-               send_routes(provider, provider->routes, name);
+       send_routes(provider, provider->routes, "ServerRoutes");
 
        return 0;
 }
@@ -235,13 +245,9 @@ static GSList *read_route_dict(GSList *routes, DBusMessageIter *dicts)
                if (family < 0) {
                        DBG("Cannot get address family of %s (%d/%s)", network,
                                family, gai_strerror(family));
-                       if (strstr(network, ":") != NULL) {
-                               DBG("Guessing it is IPv6");
-                               family = AF_INET6;
-                       } else {
-                               DBG("Guessing it is IPv4");
-                               family = AF_INET;
-                       }
+
+                       g_free(route);
+                       return routes;
                }
        } else {
                switch (family) {
@@ -302,11 +308,11 @@ static void set_user_networks(struct vpn_provider *provider, GSList *networks)
        GSList *list;
 
        for (list = networks; list != NULL; list = g_slist_next(list)) {
-               struct vpn_route *route= list->data;
+               struct vpn_route *route = list->data;
 
                if (__vpn_provider_append_user_route(provider,
                                        route->family, route->network,
-                                       route->netmask) != 0)
+                                       route->netmask, route->gateway) != 0)
                        break;
        }
 }
@@ -335,33 +341,63 @@ static void del_routes(struct vpn_provider *provider)
        provider->user_networks = NULL;
 }
 
+static void send_value(const char *path, const char *key, const char *value)
+{
+       const char *empty = "";
+       const char *str;
+
+       if (value != NULL)
+               str = value;
+       else
+               str = empty;
+
+       connman_dbus_property_changed_basic(path,
+                                       VPN_CONNECTION_INTERFACE,
+                                       key,
+                                       DBUS_TYPE_STRING,
+                                       &str);
+}
+
 static gboolean provider_send_changed(gpointer data)
 {
        struct vpn_provider *provider = data;
 
-       if (provider->what_changed & USER_ROUTES_CHANGED)
-               provider_property_changed(provider, "UserRoutes");
+       provider_routes_changed(provider);
 
-       if (provider->what_changed & SERVER_ROUTES_CHANGED)
-               provider_property_changed(provider, "ServerRoutes");
-
-       provider->what_changed = 0;
        provider->notify_id = 0;
 
        return FALSE;
 }
 
-static void provider_schedule_changed(struct vpn_provider *provider, int flag)
+static void provider_schedule_changed(struct vpn_provider *provider)
 {
        if (provider->notify_id != 0)
                g_source_remove(provider->notify_id);
 
-       provider->what_changed |= flag;
-
        provider->notify_id = g_timeout_add(100, provider_send_changed,
                                                                provider);
 }
 
+static DBusMessage *get_properties(DBusConnection *conn,
+                                       DBusMessage *msg, void *data)
+{
+       struct vpn_provider *provider = data;
+       DBusMessage *reply;
+       DBusMessageIter array;
+
+       DBG("provider %p", provider);
+
+       reply = dbus_message_new_method_return(msg);
+       if (reply == NULL)
+               return NULL;
+
+       dbus_message_iter_init_append(reply, &array);
+
+       append_properties(&array, provider);
+
+       return reply;
+}
+
 static DBusMessage *set_property(DBusConnection *conn, DBusMessage *msg,
                                                                void *data)
 {
@@ -372,6 +408,9 @@ static DBusMessage *set_property(DBusConnection *conn, DBusMessage *msg,
 
        DBG("conn %p", conn);
 
+       if (provider->immutable == TRUE)
+               return __connman_error_not_supported(msg);
+
        if (dbus_message_iter_init(msg, &iter) == FALSE)
                return __connman_error_invalid_arguments(msg);
 
@@ -401,11 +440,15 @@ static DBusMessage *set_property(DBusConnection *conn, DBusMessage *msg,
                        set_user_networks(provider, provider->user_networks);
 
                        if (handle_routes == FALSE)
-                               provider_schedule_changed(provider,
-                                                       USER_ROUTES_CHANGED);
+                               send_routes(provider, provider->user_routes,
+                                                               "UserRoutes");
                }
-       } else
-               return __connman_error_invalid_property(msg);
+       } else {
+               const char *str;
+
+               dbus_message_iter_get_basic(&value, &str);
+               vpn_provider_set_string(provider, name, str);
+       }
 
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
@@ -418,6 +461,9 @@ static DBusMessage *clear_property(DBusConnection *conn, DBusMessage *msg,
 
        DBG("conn %p", conn);
 
+       if (provider->immutable == TRUE)
+               return __connman_error_not_supported(msg);
+
        dbus_message_get_args(msg, NULL, DBUS_TYPE_STRING, &name,
                                                        DBUS_TYPE_INVALID);
 
@@ -425,7 +471,9 @@ static DBusMessage *clear_property(DBusConnection *conn, DBusMessage *msg,
                del_routes(provider);
 
                if (handle_routes == FALSE)
-                       provider_property_changed(provider, name);
+                       send_routes(provider, provider->user_routes, name);
+       } else if (vpn_provider_get_string(provider, name) != NULL) {
+               vpn_provider_set_string(provider, name, NULL);
        } else {
                return __connman_error_invalid_property(msg);
        }
@@ -464,6 +512,9 @@ static DBusMessage *do_disconnect(DBusConnection *conn, DBusMessage *msg,
 }
 
 static const GDBusMethodTable connection_methods[] = {
+       { GDBUS_METHOD("GetProperties",
+                       NULL, GDBUS_ARGS({ "properties", "a{sv}" }),
+                       get_properties) },
        { GDBUS_METHOD("SetProperty",
                        GDBUS_ARGS({ "name", "s" }, { "value", "v" }),
                        NULL, set_property) },
@@ -543,12 +594,15 @@ void __vpn_provider_append_properties(struct vpn_provider *provider,
 }
 
 int __vpn_provider_append_user_route(struct vpn_provider *provider,
-                       int family, const char *network, const char *netmask)
+                               int family, const char *network,
+                               const char *netmask, const char *gateway)
 {
        struct vpn_route *route;
-       char *key = g_strdup_printf("%d/%s/%s", family, network, netmask);
+       char *key = g_strdup_printf("%d/%s/%s/%s", family, network,
+                               netmask, gateway != NULL ? gateway : "");
 
-       DBG("family %d network %s netmask %s", family, network, netmask);
+       DBG("family %d network %s netmask %s gw %s", family, network,
+                                                       netmask, gateway);
 
        route = g_hash_table_lookup(provider->user_routes, key);
        if (route == NULL) {
@@ -561,6 +615,7 @@ int __vpn_provider_append_user_route(struct vpn_provider *provider,
                route->family = family;
                route->network = g_strdup(network);
                route->netmask = g_strdup(netmask);
+               route->gateway = g_strdup(gateway);
 
                g_hash_table_replace(provider->user_routes, key, route);
        } else
@@ -779,7 +834,16 @@ static int vpn_provider_save(struct vpn_provider *provider)
 {
        GKeyFile *keyfile;
 
-       DBG("provider %p", provider);
+       DBG("provider %p immutable %s", provider,
+                                       provider->immutable ? "yes" : "no");
+
+       if (provider->immutable == TRUE) {
+               /*
+                * Do not save providers that are provisioned via .config
+                * file.
+                */
+               return -EPERM;
+       }
 
        keyfile = g_key_file_new();
        if (keyfile == NULL)
@@ -809,6 +873,15 @@ static int vpn_provider_save(struct vpn_provider *provider)
                }
        }
 
+       if (provider->config_file != NULL && strlen(provider->config_file) > 0)
+               g_key_file_set_string(keyfile, provider->identifier,
+                               "Config.file", provider->config_file);
+
+       if (provider->config_entry != NULL &&
+                                       strlen(provider->config_entry) > 0)
+               g_key_file_set_string(keyfile, provider->identifier,
+                               "Config.ident", provider->config_entry);
+
        if (provider->driver != NULL && provider->driver->save != NULL)
                provider->driver->save(provider, keyfile);
 
@@ -922,6 +995,8 @@ static void provider_destruct(struct vpn_provider *provider)
        __vpn_ipconfig_unref(provider->ipconfig_ipv6);
 
        g_strfreev(provider->host_ip);
+       g_free(provider->config_file);
+       g_free(provider->config_entry);
        g_free(provider);
 }
 
@@ -952,8 +1027,6 @@ static void configuration_count_del(void)
 
        if (__sync_fetch_and_sub(&configuration_count, 1) != 1)
                return;
-
-       raise(SIGTERM);
 }
 
 int __vpn_provider_disconnect(struct vpn_provider *provider)
@@ -1165,13 +1238,14 @@ static int provider_indicate_state(struct vpn_provider *provider,
                                enum vpn_provider_state state)
 {
        const char *str;
-
-       DBG("provider %p state %d", provider, state);
+       enum vpn_provider_state old_state;
 
        str = state2string(state);
+       DBG("provider %p state %s/%d", provider, str, state);
        if (str == NULL)
                return -EINVAL;
 
+       old_state = provider->state;
        provider->state = state;
 
        if (state == VPN_PROVIDER_STATE_READY) {
@@ -1189,9 +1263,18 @@ static int provider_indicate_state(struct vpn_provider *provider,
                                        append_ipv6, provider);
        }
 
-       connman_dbus_property_changed_basic(provider->path,
+       if (old_state != state)
+               connman_dbus_property_changed_basic(provider->path,
                                        VPN_CONNECTION_INTERFACE, "State",
                                        DBUS_TYPE_STRING, &str);
+
+       /*
+        * We do not stay in failure state as clients like connmand can
+        * get confused about our current state.
+        */
+       if (provider->state == VPN_PROVIDER_STATE_FAILURE)
+               provider->state = VPN_PROVIDER_STATE_IDLE;
+
        return 0;
 }
 
@@ -1248,6 +1331,8 @@ static void append_properties(DBusMessageIter *iter,
                                        struct vpn_provider *provider)
 {
        DBusMessageIter dict;
+       GHashTableIter hash;
+       gpointer value, key;
 
        connman_dbus_dict_open(iter, &dict);
 
@@ -1271,6 +1356,9 @@ static void append_properties(DBusMessageIter *iter,
                connman_dbus_dict_append_basic(&dict, "Domain",
                                        DBUS_TYPE_STRING, &provider->domain);
 
+       connman_dbus_dict_append_basic(&dict, "Immutable", DBUS_TYPE_BOOLEAN,
+                                       &provider->immutable);
+
        if (provider->family == AF_INET)
                connman_dbus_dict_append_dict(&dict, "IPv4", append_ipv4,
                                                provider);
@@ -1289,6 +1377,20 @@ static void append_properties(DBusMessageIter *iter,
                                DBUS_TYPE_DICT_ENTRY, append_routes,
                                provider->routes);
 
+       if (provider->setting_strings != NULL) {
+               g_hash_table_iter_init(&hash, provider->setting_strings);
+
+               while (g_hash_table_iter_next(&hash, &key, &value) == TRUE) {
+                       struct vpn_setting *setting = value;
+
+                       if (setting->hide_value == FALSE &&
+                                                       setting->value != NULL)
+                               connman_dbus_dict_append_basic(&dict, key,
+                                                       DBUS_TYPE_STRING,
+                                                       &setting->value);
+               }
+       }
+
        connman_dbus_dict_close(iter, &dict);
 }
 
@@ -1432,6 +1534,7 @@ int vpn_provider_indicate_error(struct vpn_provider *provider,
        case VPN_PROVIDER_ERROR_LOGIN_FAILED:
                break;
        case VPN_PROVIDER_ERROR_AUTH_FAILED:
+               vpn_provider_set_state(provider, VPN_PROVIDER_STATE_FAILURE);
                break;
        case VPN_PROVIDER_ERROR_CONNECT_FAILED:
                break;
@@ -1497,13 +1600,14 @@ static void provider_initialize(struct vpn_provider *provider)
        provider->type = NULL;
        provider->domain = NULL;
        provider->identifier = NULL;
+       provider->immutable = FALSE;
        provider->user_networks = NULL;
        provider->routes = g_hash_table_new_full(g_direct_hash, g_direct_equal,
                                        NULL, free_route);
        provider->user_routes = g_hash_table_new_full(g_str_hash, g_str_equal,
                                        g_free, free_route);
        provider->setting_strings = g_hash_table_new_full(g_str_hash,
-                                               g_str_equal, g_free, g_free);
+                                       g_str_equal, g_free, free_setting);
 }
 
 static struct vpn_provider *vpn_provider_new(void)
@@ -1679,7 +1783,8 @@ int __vpn_provider_create(DBusMessage *msg)
                                dbus_message_iter_get_basic(&value, &name);
                        else if (g_str_equal(key, "Host") == TRUE)
                                dbus_message_iter_get_basic(&value, &host);
-                       else if (g_str_equal(key, "VPN.Domain") == TRUE)
+                       else if (g_str_equal(key, "VPN.Domain") == TRUE ||
+                                       g_str_equal(key, "Domain") == TRUE)
                                dbus_message_iter_get_basic(&value, &domain);
                        break;
                case DBUS_TYPE_ARRAY:
@@ -1782,7 +1887,79 @@ static const char *get_string(GHashTable *settings, const char *key)
 
 static GSList *parse_user_networks(const char *network_str)
 {
-       return NULL;
+       GSList *networks = NULL;
+       char **elems;
+       int i = 0;
+
+       if (network_str == NULL)
+               return NULL;
+
+       elems = g_strsplit(network_str, ",", 0);
+       if (elems == NULL)
+               return NULL;
+
+       while (elems[i] != NULL) {
+               struct vpn_route *vpn_route;
+               char *network, *netmask, *gateway;
+               int family;
+               char **route;
+
+               route = g_strsplit(elems[i], "/", 0);
+               if (route == NULL)
+                       goto next;
+
+               network = route[0];
+               if (network == NULL || network[0] == '\0')
+                       goto next;
+
+               family = connman_inet_check_ipaddress(network);
+               if (family < 0) {
+                       DBG("Cannot get address family of %s (%d/%s)", network,
+                               family, gai_strerror(family));
+
+                       goto next;
+               }
+
+               switch (family) {
+               case AF_INET:
+                       break;
+               case AF_INET6:
+                       break;
+               default:
+                       DBG("Unsupported address family %d", family);
+                       goto next;
+               }
+
+               netmask = route[1];
+               if (netmask == NULL || netmask[0] == '\0')
+                       goto next;
+
+               gateway = route[2];
+
+               vpn_route = g_try_new0(struct vpn_route, 1);
+               if (vpn_route == NULL) {
+                       g_strfreev(route);
+                       break;
+               }
+
+               vpn_route->family = family;
+               vpn_route->network = g_strdup(network);
+               vpn_route->netmask = g_strdup(netmask);
+               vpn_route->gateway = g_strdup(gateway);
+
+               DBG("route %s/%s%s%s", network, netmask,
+                       gateway ? " via " : "", gateway ? gateway : "");
+
+               networks = g_slist_prepend(networks, vpn_route);
+
+       next:
+               g_strfreev(route);
+               i++;
+       }
+
+       g_strfreev(elems);
+
+       return g_slist_reverse(networks);
 }
 
 int __vpn_provider_create_from_config(GHashTable *settings,
@@ -1833,8 +2010,10 @@ int __vpn_provider_create_from_config(GHashTable *settings,
                provider->name = g_strdup(name);
                provider->type = g_ascii_strdown(type, -1);
 
-               if (provider_register(provider) == 0)
-                       vpn_provider_load(provider);
+               provider->config_file = g_strdup(config_ident);
+               provider->config_entry = g_strdup(config_entry);
+
+               provider_register(provider);
 
                provider_resolv_host_addr(provider);
        }
@@ -1848,7 +2027,9 @@ int __vpn_provider_create_from_config(GHashTable *settings,
        g_hash_table_iter_init(&hash, settings);
 
        while (g_hash_table_iter_next(&hash, &key, &value) == TRUE)
-               vpn_provider_set_string(provider, key, value);
+               __vpn_provider_set_string_immutable(provider, key, value);
+
+       provider->immutable = TRUE;
 
        vpn_provider_save(provider);
 
@@ -1863,12 +2044,13 @@ int __vpn_provider_create_from_config(GHashTable *settings,
 
        connection_added_signal(provider);
 
-       err = 0;
+       g_free(ident);
+
+       return 0;
 
 fail:
        g_free(ident);
-       if (networks != NULL)
-               g_slist_free_full(networks, free_route);
+       g_slist_free_full(networks, free_route);
 
        return err;
 }
@@ -1922,32 +2104,84 @@ const char * __vpn_provider_get_ident(struct vpn_provider *provider)
        return provider->identifier;
 }
 
-int vpn_provider_set_string(struct vpn_provider *provider,
-                                       const char *key, const char *value)
+static int set_string(struct vpn_provider *provider,
+                       const char *key, const char *value,
+                       gboolean hide_value, gboolean immutable)
 {
-       DBG("provider %p key %s value %s", provider, key, value);
+       DBG("provider %p key %s immutable %s value %s", provider, key,
+               immutable ? "yes" : "no",
+               hide_value ? "<not printed>" : value);
 
        if (g_str_equal(key, "Type") == TRUE) {
                g_free(provider->type);
                provider->type = g_ascii_strdown(value, -1);
+               send_value(provider->path, "Type", provider->type);
        } else if (g_str_equal(key, "Name") == TRUE) {
                g_free(provider->name);
                provider->name = g_strdup(value);
+               send_value(provider->path, "Name", provider->name);
        } else if (g_str_equal(key, "Host") == TRUE) {
                g_free(provider->host);
                provider->host = g_strdup(value);
-       } else if (g_str_equal(key, "VPN.Domain") == TRUE) {
+               send_value(provider->path, "Host", provider->host);
+       } else if (g_str_equal(key, "VPN.Domain") == TRUE ||
+                       g_str_equal(key, "Domain") == TRUE) {
                g_free(provider->domain);
                provider->domain = g_strdup(value);
-       } else
+               send_value(provider->path, "Domain", provider->domain);
+       } else {
+               struct vpn_setting *setting;
+
+               setting = g_hash_table_lookup(provider->setting_strings, key);
+               if (setting != NULL && immutable == FALSE &&
+                                               setting->immutable == TRUE) {
+                       DBG("Trying to set immutable variable %s", key);
+                       return -EPERM;
+               }
+
+               setting = g_try_new(struct vpn_setting, 1);
+               if (setting == NULL)
+                       return -ENOMEM;
+
+               setting->value = g_strdup(value);
+               setting->hide_value = hide_value;
+
+               if (immutable == TRUE)
+                       setting->immutable = TRUE;
+
+               if (hide_value == FALSE)
+                       send_value(provider->path, key, setting->value);
+
                g_hash_table_replace(provider->setting_strings,
-                               g_strdup(key), g_strdup(value));
+                               g_strdup(key), setting);
+       }
+
        return 0;
 }
 
+int vpn_provider_set_string(struct vpn_provider *provider,
+                                       const char *key, const char *value)
+{
+       return set_string(provider, key, value, FALSE, FALSE);
+}
+
+int vpn_provider_set_string_hide_value(struct vpn_provider *provider,
+                                       const char *key, const char *value)
+{
+       return set_string(provider, key, value, TRUE, FALSE);
+}
+
+int __vpn_provider_set_string_immutable(struct vpn_provider *provider,
+                                       const char *key, const char *value)
+{
+       return set_string(provider, key, value, FALSE, TRUE);
+}
+
 const char *vpn_provider_get_string(struct vpn_provider *provider,
                                                        const char *key)
 {
+       struct vpn_setting *setting;
+
        DBG("provider %p key %s", provider, key);
 
        if (g_str_equal(key, "Type") == TRUE)
@@ -1962,10 +2196,15 @@ const char *vpn_provider_get_string(struct vpn_provider *provider,
                        return provider->host;
                else
                        return provider->host_ip[0];
-       } else if (g_str_equal(key, "VPN.Domain") == TRUE)
+       } else if (g_str_equal(key, "VPN.Domain") == TRUE ||
+                       g_str_equal(key, "Domain") == TRUE)
                return provider->domain;
 
-       return g_hash_table_lookup(provider->setting_strings, key);
+       setting = g_hash_table_lookup(provider->setting_strings, key);
+       if (setting == NULL)
+               return NULL;
+
+       return setting->value;
 }
 
 connman_bool_t __vpn_provider_check_routes(struct vpn_provider *provider)
@@ -2204,8 +2443,7 @@ int vpn_provider_append_route(struct vpn_provider *provider,
        if (handle_routes == FALSE) {
                if (route->netmask != NULL && route->gateway != NULL &&
                                                        route->network != NULL)
-                       provider_schedule_changed(provider,
-                                               SERVER_ROUTES_CHANGED);
+                       provider_schedule_changed(provider);
        }
 
        return 0;
@@ -2271,28 +2509,6 @@ void vpn_provider_driver_unregister(struct vpn_provider_driver *driver)
        }
 }
 
-static gboolean check_vpn_count(gpointer data)
-{
-       if (configuration_count == 0) {
-               connman_info("No VPN configurations found, quitting.");
-               raise(SIGTERM);
-       }
-
-       return FALSE;
-}
-
-void __vpn_provider_check_connections(void)
-{
-       /*
-        * If we were started when there is no providers configured,
-        * then just quit. This happens when connman starts and its
-        * vpn plugin asks connman-vpnd if it has any connections
-        * configured. If there are none, then we can stop the vpn
-        * daemon.
-        */
-       g_timeout_add(1000, check_vpn_count, NULL);
-}
-
 const char *vpn_provider_get_name(struct vpn_provider *provider)
 {
        return provider->name;
@@ -2326,6 +2542,67 @@ static struct connman_agent_driver agent_driver = {
        .remove         = agent_remove,
 };
 
+static void remove_unprovisioned_providers()
+{
+       gchar **providers;
+       GKeyFile *keyfile, *configkeyfile;
+       char *file, *section;
+       int i = 0;
+
+       providers = __connman_storage_get_providers();
+       if (providers == NULL)
+               return;
+
+       for (; providers[i] != NULL; i++) {
+               char *group = providers[i] + sizeof("provider_") - 1;
+               file = section = NULL;
+               keyfile = configkeyfile = NULL;
+
+               keyfile = __connman_storage_load_provider(group);
+               if (keyfile == NULL)
+                       continue;
+
+               file = g_key_file_get_string(keyfile, group,
+                                       "Config.file", NULL);
+               if (file == NULL)
+                       goto next;
+
+               section = g_key_file_get_string(keyfile, group,
+                                       "Config.ident", NULL);
+               if (section == NULL)
+                       goto next;
+
+               configkeyfile = __connman_storage_load_provider_config(file);
+               if (configkeyfile == NULL) {
+                       /*
+                        * Config file is missing, remove the provisioned
+                        * service.
+                        */
+                       __connman_storage_remove_provider(group);
+                       goto next;
+               }
+
+               if (g_key_file_has_group(configkeyfile, section) == FALSE)
+                       /*
+                        * Config section is missing, remove the provisioned
+                        * service.
+                        */
+                       __connman_storage_remove_provider(group);
+
+       next:
+               if (keyfile != NULL)
+                       g_key_file_free(keyfile);
+
+               if (configkeyfile != NULL)
+                       g_key_file_free(configkeyfile);
+
+               g_free(section);
+               g_free(file);
+       }
+
+       g_strfreev(providers);
+}
+
 int __vpn_provider_init(gboolean do_routes)
 {
        int err;
@@ -2343,9 +2620,10 @@ int __vpn_provider_init(gboolean do_routes)
 
        connection = connman_dbus_get_connection();
 
+       remove_unprovisioned_providers();
+
        provider_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
                                                NULL, unregister_provider);
-
        return 0;
 }