perf parse-events: Populate error column for BPF/tracepoint events
[platform/kernel/linux-starfive.git] / tools / perf / util / parse-events.y
index 9f28d4b..50f5b81 100644 (file)
@@ -28,6 +28,13 @@ do { \
                YYABORT; \
 } while (0)
 
+#define PE_ABORT(val) \
+do { \
+       if (val == -ENOMEM) \
+               YYNOMEM; \
+       YYABORT; \
+} while (0)
+
 static struct list_head* alloc_list(void)
 {
        struct list_head *list;
@@ -61,9 +68,8 @@ static void free_list_evsel(struct list_head* list_evsel)
 %token PE_BPF_OBJECT PE_BPF_SOURCE
 %token PE_MODIFIER_EVENT PE_MODIFIER_BP PE_BP_COLON PE_BP_SLASH
 %token PE_LEGACY_CACHE
-%token PE_PREFIX_MEM PE_PREFIX_RAW PE_PREFIX_GROUP
+%token PE_PREFIX_MEM
 %token PE_ERROR
-%token PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE
 %token PE_ARRAY_ALL PE_ARRAY_RANGE
 %token PE_DRV_CFG_TERM
 %token PE_TERM_HW
@@ -81,7 +87,6 @@ static void free_list_evsel(struct list_head* list_evsel)
 %type <str> PE_MODIFIER_EVENT
 %type <str> PE_MODIFIER_BP
 %type <str> PE_EVENT_NAME
-%type <str> PE_KERNEL_PMU_EVENT PE_PMU_EVENT_FAKE
 %type <str> PE_DRV_CFG_TERM
 %type <str> name_or_raw name_or_legacy
 %destructor { free ($$); } <str>
@@ -265,7 +270,7 @@ PE_EVENT_NAME event_def
        free($1);
        if (err) {
                free_list_evsel($2);
-               YYABORT;
+               YYNOMEM;
        }
        $$ = $2;
 }
@@ -285,37 +290,38 @@ event_pmu:
 PE_NAME opt_pmu_config
 {
        struct parse_events_state *parse_state = _parse_state;
-       struct parse_events_error *error = parse_state->error;
        struct list_head *list = NULL, *orig_terms = NULL, *terms= NULL;
        char *pattern = NULL;
 
-#define CLEANUP_YYABORT                                        \
+#define CLEANUP                                                \
        do {                                            \
                parse_events_terms__delete($2);         \
                parse_events_terms__delete(orig_terms); \
                free(list);                             \
                free($1);                               \
                free(pattern);                          \
-               YYABORT;                                \
        } while(0)
 
-       if (parse_events_copy_term_list($2, &orig_terms))
-               CLEANUP_YYABORT;
-
-       if (error)
-               error->idx = @1.first_column;
+       if (parse_events_copy_term_list($2, &orig_terms)) {
+               CLEANUP;
+               YYNOMEM;
+       }
 
        list = alloc_list();
-       if (!list)
-               CLEANUP_YYABORT;
+       if (!list) {
+               CLEANUP;
+               YYNOMEM;
+       }
        /* Attempt to add to list assuming $1 is a PMU name. */
        if (parse_events_add_pmu(parse_state, list, $1, $2, /*auto_merge_stats=*/false)) {
                struct perf_pmu *pmu = NULL;
                int ok = 0;
 
                /* Failure to add, try wildcard expansion of $1 as a PMU name. */
-               if (asprintf(&pattern, "%s*", $1) < 0)
-                       CLEANUP_YYABORT;
+               if (asprintf(&pattern, "%s*", $1) < 0) {
+                       CLEANUP;
+                       YYNOMEM;
+               }
 
                while ((pmu = perf_pmus__scan(pmu)) != NULL) {
                        char *name = pmu->name;
@@ -330,8 +336,10 @@ PE_NAME opt_pmu_config
                            !perf_pmu__match(pattern, pmu->alias_name, $1)) {
                                bool auto_merge_stats = perf_pmu__auto_merge_stats(pmu);
 
-                               if (parse_events_copy_term_list(orig_terms, &terms))
-                                       CLEANUP_YYABORT;
+                               if (parse_events_copy_term_list(orig_terms, &terms)) {
+                                       CLEANUP;
+                                       YYNOMEM;
+                               }
                                if (!parse_events_add_pmu(parse_state, list, pmu->name, terms,
                                                          auto_merge_stats)) {
                                        ok++;
@@ -347,27 +355,23 @@ PE_NAME opt_pmu_config
                        ok = !parse_events_multi_pmu_add(parse_state, $1, $2, &list);
                        $2 = NULL;
                }
-               if (!ok)
-                       CLEANUP_YYABORT;
+               if (!ok) {
+                       struct parse_events_error *error = parse_state->error;
+                       char *help;
+
+                       if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
+                               help = NULL;
+                       parse_events_error__handle(error, @1.first_column,
+                                                  strdup("Bad event or PMU"),
+                                                  help);
+                       CLEANUP;
+                       YYABORT;
+               }
        }
-       parse_events_terms__delete($2);
-       parse_events_terms__delete(orig_terms);
-       free(pattern);
-       free($1);
-       $$ = list;
-#undef CLEANUP_YYABORT
-}
-|
-PE_KERNEL_PMU_EVENT sep_dc
-{
-       struct list_head *list;
-       int err;
-
-       err = parse_events_multi_pmu_add(_parse_state, $1, NULL, &list);
-       free($1);
-       if (err < 0)
-               YYABORT;
        $$ = list;
+       list = NULL;
+       CLEANUP;
+#undef CLEANUP
 }
 |
 PE_NAME sep_dc
@@ -376,60 +380,18 @@ PE_NAME sep_dc
        int err;
 
        err = parse_events_multi_pmu_add(_parse_state, $1, NULL, &list);
-       free($1);
-       if (err < 0)
-               YYABORT;
-       $$ = list;
-}
-|
-PE_KERNEL_PMU_EVENT opt_pmu_config
-{
-       struct list_head *list;
-       int err;
-
-       /* frees $2 */
-       err = parse_events_multi_pmu_add(_parse_state, $1, $2, &list);
-       free($1);
-       if (err < 0)
-               YYABORT;
-       $$ = list;
-}
-|
-PE_PMU_EVENT_FAKE sep_dc
-{
-       struct list_head *list;
-       int err;
-
-       list = alloc_list();
-       if (!list)
-               YYABORT;
-
-       err = parse_events_add_pmu(_parse_state, list, $1, /*head_config=*/NULL,
-                                  /*auto_merge_stats=*/false);
-       free($1);
        if (err < 0) {
-               free(list);
-               YYABORT;
-       }
-       $$ = list;
-}
-|
-PE_PMU_EVENT_FAKE opt_pmu_config
-{
-       struct list_head *list;
-       int err;
-
-       list = alloc_list();
-       if (!list)
-               YYABORT;
+               struct parse_events_state *parse_state = _parse_state;
+               struct parse_events_error *error = parse_state->error;
+               char *help;
 
-       err = parse_events_add_pmu(_parse_state, list, $1, $2, /*auto_merge_stats=*/false);
-       free($1);
-       parse_events_terms__delete($2);
-       if (err < 0) {
-               free(list);
-               YYABORT;
+               if (asprintf(&help, "Unabled to find PMU or event on a PMU of '%s'", $1) < 0)
+                       help = NULL;
+               parse_events_error__handle(error, @1.first_column, strdup("Bad event name"), help);
+               free($1);
+               PE_ABORT(err);
        }
+       free($1);
        $$ = list;
 }
 
@@ -448,12 +410,13 @@ value_sym '/' event_config '/'
        bool wildcard = (type == PERF_TYPE_HARDWARE || type == PERF_TYPE_HW_CACHE);
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
        err = parse_events_add_numeric(_parse_state, list, type, config, $3, wildcard);
        parse_events_terms__delete($3);
        if (err) {
                free_list_evsel(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -464,21 +427,28 @@ value_sym sep_slash_slash_dc
        int type = $1 >> 16;
        int config = $1 & 255;
        bool wildcard = (type == PERF_TYPE_HARDWARE || type == PERF_TYPE_HW_CACHE);
+       int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
-       ABORT_ON(parse_events_add_numeric(_parse_state, list, type, config,
-                                         /*head_config=*/NULL, wildcard));
+       if (!list)
+               YYNOMEM;
+       err = parse_events_add_numeric(_parse_state, list, type, config, /*head_config=*/NULL, wildcard);
+       if (err)
+               PE_ABORT(err);
        $$ = list;
 }
 |
 PE_VALUE_SYM_TOOL sep_slash_slash_dc
 {
        struct list_head *list;
+       int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
-       ABORT_ON(parse_events_add_tool(_parse_state, list, $1));
+       if (!list)
+               YYNOMEM;
+       err = parse_events_add_tool(_parse_state, list, $1);
+       if (err)
+               YYNOMEM;
        $$ = list;
 }
 
@@ -490,14 +460,16 @@ PE_LEGACY_CACHE opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
+
        err = parse_events_add_cache(list, &parse_state->idx, $1, parse_state, $2);
 
        parse_events_terms__delete($2);
        free($1);
        if (err) {
                free_list_evsel(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -509,14 +481,16 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
+
        err = parse_events_add_breakpoint(_parse_state, list,
                                          $2, $6, $4, $7);
        parse_events_terms__delete($7);
        free($6);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -527,13 +501,15 @@ PE_PREFIX_MEM PE_VALUE PE_BP_SLASH PE_VALUE opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
+
        err = parse_events_add_breakpoint(_parse_state, list,
                                          $2, NULL, $4, $5);
        parse_events_terms__delete($5);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -544,14 +520,16 @@ PE_PREFIX_MEM PE_VALUE PE_BP_COLON PE_MODIFIER_BP opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
+
        err = parse_events_add_breakpoint(_parse_state, list,
                                          $2, $4, 0, $5);
        parse_events_terms__delete($5);
        free($4);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -562,13 +540,14 @@ PE_PREFIX_MEM PE_VALUE opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
        err = parse_events_add_breakpoint(_parse_state, list,
                                          $2, NULL, 0, $3);
        parse_events_terms__delete($3);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -582,19 +561,20 @@ tracepoint_name opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
        if (error)
                error->idx = @1.first_column;
 
        err = parse_events_add_tracepoint(list, &parse_state->idx, $1.sys, $1.event,
-                                       error, $2);
+                                       error, $2, &@1);
 
        parse_events_terms__delete($2);
        free($1.sys);
        free($1.event);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -614,13 +594,14 @@ PE_VALUE ':' PE_VALUE opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
        err = parse_events_add_numeric(_parse_state, list, (u32)$1, $3, $4,
                                       /*wildcard=*/false);
        parse_events_terms__delete($4);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -633,7 +614,8 @@ PE_RAW opt_event_config
        u64 num;
 
        list = alloc_list();
-       ABORT_ON(!list);
+       if (!list)
+               YYNOMEM;
        errno = 0;
        num = strtoull($1 + 1, NULL, 16);
        ABORT_ON(errno);
@@ -643,7 +625,7 @@ PE_RAW opt_event_config
        parse_events_terms__delete($2);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -656,13 +638,14 @@ PE_BPF_OBJECT opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
-       err = parse_events_load_bpf(parse_state, list, $1, false, $2);
+       if (!list)
+               YYNOMEM;
+       err = parse_events_load_bpf(parse_state, list, $1, false, $2, &@1);
        parse_events_terms__delete($2);
        free($1);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -673,12 +656,13 @@ PE_BPF_SOURCE opt_event_config
        int err;
 
        list = alloc_list();
-       ABORT_ON(!list);
-       err = parse_events_load_bpf(_parse_state, list, $1, true, $2);
+       if (!list)
+               YYNOMEM;
+       err = parse_events_load_bpf(_parse_state, list, $1, true, $2, &@1);
        parse_events_terms__delete($2);
        if (err) {
                free(list);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = list;
 }
@@ -738,7 +722,8 @@ event_term
        struct list_head *head = malloc(sizeof(*head));
        struct parse_events_term *term = $1;
 
-       ABORT_ON(!head);
+       if (!head)
+               YYNOMEM;
        INIT_LIST_HEAD(head);
        list_add_tail(&term->list, head);
        $$ = head;
@@ -752,11 +737,12 @@ event_term:
 PE_RAW
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_RAW,
+                                        strdup("raw"), $1, &@1, &@1);
 
-       if (parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_RAW,
-                                       strdup("raw"), $1, &@1, &@1)) {
+       if (err) {
                free($1);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -764,12 +750,12 @@ PE_RAW
 name_or_raw '=' name_or_legacy
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER, $1, $3, &@1, &@3);
 
-       if (parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, $3, &@1, &@3)) {
+       if (err) {
                free($1);
                free($3);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -777,11 +763,12 @@ name_or_raw '=' name_or_legacy
 name_or_raw '=' PE_VALUE
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
+                                        $1, $3, false, &@1, &@3);
 
-       if (parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, $3, false, &@1, &@3)) {
+       if (err) {
                free($1);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -789,12 +776,13 @@ name_or_raw '=' PE_VALUE
 name_or_raw '=' PE_TERM_HW
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER,
+                                        $1, $3.str, &@1, &@3);
 
-       if (parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, $3.str, &@1, &@3)) {
+       if (err) {
                free($1);
                free($3.str);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -802,11 +790,12 @@ name_or_raw '=' PE_TERM_HW
 PE_LEGACY_CACHE
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_LEGACY_CACHE,
+                                        $1, 1, true, &@1, NULL);
 
-       if (parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_LEGACY_CACHE,
-                                       $1, 1, true, &@1, NULL)) {
+       if (err) {
                free($1);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -814,11 +803,12 @@ PE_LEGACY_CACHE
 PE_NAME
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
+                                        $1, 1, true, &@1, NULL);
 
-       if (parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, 1, true, &@1, NULL)) {
+       if (err) {
                free($1);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -826,11 +816,12 @@ PE_NAME
 PE_TERM_HW
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_HARDWARE,
+                                        $1.str, $1.num & 255, false, &@1, NULL);
 
-       if (parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_HARDWARE,
-                                  $1.str, $1.num & 255, false, &@1, NULL)) {
+       if (err) {
                free($1.str);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -838,10 +829,11 @@ PE_TERM_HW
 PE_TERM '=' name_or_legacy
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, (int)$1, NULL, $3, &@1, &@3);
 
-       if (parse_events_term__str(&term, (int)$1, NULL, $3, &@1, &@3)) {
+       if (err) {
                free($3);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -849,10 +841,11 @@ PE_TERM '=' name_or_legacy
 PE_TERM '=' PE_TERM_HW
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, (int)$1, NULL, $3.str, &@1, &@3);
 
-       if (parse_events_term__str(&term, (int)$1, NULL, $3.str, &@1, &@3)) {
+       if (err) {
                free($3.str);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -860,37 +853,46 @@ PE_TERM '=' PE_TERM_HW
 PE_TERM '=' PE_TERM
 {
        struct parse_events_term *term;
+       int err = parse_events_term__term(&term, (int)$1, (int)$3, &@1, &@3);
+
+       if (err)
+               PE_ABORT(err);
 
-       ABORT_ON(parse_events_term__term(&term, (int)$1, (int)$3, &@1, &@3));
        $$ = term;
 }
 |
 PE_TERM '=' PE_VALUE
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, (int)$1, NULL, $3, false, &@1, &@3);
+
+       if (err)
+               PE_ABORT(err);
 
-       ABORT_ON(parse_events_term__num(&term, (int)$1, NULL, $3, false, &@1, &@3));
        $$ = term;
 }
 |
 PE_TERM
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, (int)$1, NULL, 1, true, &@1, NULL);
+
+       if (err)
+               PE_ABORT(err);
 
-       ABORT_ON(parse_events_term__num(&term, (int)$1, NULL, 1, true, &@1, NULL));
        $$ = term;
 }
 |
 name_or_raw array '=' name_or_legacy
 {
        struct parse_events_term *term;
+       int err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER, $1, $4, &@1, &@4);
 
-       if (parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, $4, &@1, &@4)) {
+       if (err) {
                free($1);
                free($4);
                free($2.ranges);
-               YYABORT;
+               PE_ABORT(err);
        }
        term->array = $2;
        $$ = term;
@@ -899,12 +901,12 @@ name_or_raw array '=' name_or_legacy
 name_or_raw array '=' PE_VALUE
 {
        struct parse_events_term *term;
+       int err = parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER, $1, $4, false, &@1, &@4);
 
-       if (parse_events_term__num(&term, PARSE_EVENTS__TERM_TYPE_USER,
-                                       $1, $4, false, &@1, &@4)) {
+       if (err) {
                free($1);
                free($2.ranges);
-               YYABORT;
+               PE_ABORT(err);
        }
        term->array = $2;
        $$ = term;
@@ -914,13 +916,15 @@ PE_DRV_CFG_TERM
 {
        struct parse_events_term *term;
        char *config = strdup($1);
+       int err;
 
-       ABORT_ON(!config);
-       if (parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_DRV_CFG,
-                                       config, $1, &@1, NULL)) {
+       if (!config)
+               YYNOMEM;
+       err = parse_events_term__str(&term, PARSE_EVENTS__TERM_TYPE_DRV_CFG, config, $1, &@1, NULL);
+       if (err) {
                free($1);
                free(config);
-               YYABORT;
+               PE_ABORT(err);
        }
        $$ = term;
 }
@@ -946,7 +950,8 @@ array_terms ',' array_term
        new_array.ranges = realloc($1.ranges,
                                sizeof(new_array.ranges[0]) *
                                new_array.nr_ranges);
-       ABORT_ON(!new_array.ranges);
+       if (!new_array.ranges)
+               YYNOMEM;
        memcpy(&new_array.ranges[$1.nr_ranges], $3.ranges,
               $3.nr_ranges * sizeof(new_array.ranges[0]));
        free($3.ranges);
@@ -962,7 +967,8 @@ PE_VALUE
 
        array.nr_ranges = 1;
        array.ranges = malloc(sizeof(array.ranges[0]));
-       ABORT_ON(!array.ranges);
+       if (!array.ranges)
+               YYNOMEM;
        array.ranges[0].start = $1;
        array.ranges[0].length = 1;
        $$ = array;
@@ -975,7 +981,8 @@ PE_VALUE PE_ARRAY_RANGE PE_VALUE
        ABORT_ON($3 < $1);
        array.nr_ranges = 1;
        array.ranges = malloc(sizeof(array.ranges[0]));
-       ABORT_ON(!array.ranges);
+       if (!array.ranges)
+               YYNOMEM;
        array.ranges[0].start = $1;
        array.ranges[0].length = $3 - $1 + 1;
        $$ = array;