* @brief Test cases for security-server-client-smack.
*/
+#include <unistd.h>
+#include <stdlib.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/smack.h>
#include <sys/wait.h>
#include <sys/un.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <errno.h>
+
+#include <memory>
+#include <functional>
#include <dpl/log/log.h>
#include <dpl/test/test_runner.h>
#include <dpl/test/test_runner_child.h>
+#include <dpl/test/test_runner_multiprocess.h>
#include "security_server_mockup.h"
#include <security-server.h>
+#include <access_provider.h>
+#include "tests_common.h"
+#include <summary_collector.h>
-#define ENVIRONMENT \
-do { \
- const char *subject_label = "mylabel"; \
- RUNNER_ASSERT_MSG(-1 != system("touch /opt/home/root/pid_cycle"),\
- "Cannot prepare environment for test."); \
- RUNNER_ASSERT_MSG(0 == smack_set_label_for_self(subject_label), \
- "Cannot prepare environment for test."); \
- RUNNER_ASSERT_MSG(-1 != setgid(1), \
- "Cannot prepare environment for test."); \
- RUNNER_ASSERT_MSG(-1 != setuid(1), \
- "Cannot prepare environment for test"); \
-}while(0)
-RUNNER_TEST_GROUP_INIT(SECURITY_SERVER_TESTS_CLIENT_SMACK)
+#define PROPER_COOKIE_SIZE 20
-/*
- * test: Check cookie size returned by security_server_get_cookie_size.
- * description: Cookie used by security-server is 20 bytes long.
- * Any other size of cookies should be treated as error.
- * expected: Function security_server_get_cookie_size returns 20.
+/**
+ * Unique_ptr typedef for NOSMACK version of tc06 test
*/
-RUNNER_CHILD_TEST(tc01_security_server_get_cookie_size)
+void closesockfdptr(int* sockfd_ptr)
{
- ENVIRONMENT;
-
- int ret = security_server_get_cookie_size();
- RUNNER_ASSERT_MSG(20 == ret, "ret = " << ret);
+ close(*sockfd_ptr);
}
+typedef std::unique_ptr<int, std::function<void(int*)> > SockFDUniquePtr;
-/*
- * test: security_server_request_cookie
- * description: Function security_server_request_cookie will return
- * 20 bytes long cookie.
- * expected: function will set up cookie in the array and return
- * SECURITY_SERVER_API_SUCCESS.
- */
-RUNNER_CHILD_TEST(tc02_security_server_request_cookie_normal_case)
-{
- ENVIRONMENT;
-
- char cookie[20];
- int ret = security_server_request_cookie(cookie, 20);
- LogDebug("ret = " << ret);
- RUNNER_ASSERT(SECURITY_SERVER_API_SUCCESS == ret);
-}
+RUNNER_TEST_GROUP_INIT(SECURITY_SERVER_TESTS_CLIENT_SMACK)
/*
- * test: security_server_request_cookie
- * description: Function security_server_request_cookie will return
- * 20 bytes long cookie.
- * expected: function will set up cookie in the array and return
- * SECURITY_SERVER_API_SUCCESS.
+ * test: tc04_security_server_get_gid
+ * description: Checking for security_server_get_gid
+ * with nonexisting gid and existing one
+ * expected: security_server_get_gid should return
+ * SECURITY_SERVER_ERROR_NO_SUCH_OBJECT with first call
+ * and group id with second call
*/
-RUNNER_CHILD_TEST(tc03_security_server_request_cookie_too_small_buffer_size)
+RUNNER_CHILD_TEST_SMACK(tc04_security_server_get_gid)
{
- ENVIRONMENT;
+ SecurityServer::AccessProvider provider("tc04mylabel");
+ provider.allowFunction("security_server_get_gid");
+ provider.applyAndSwithToUser(APP_UID, APP_GID);
- char cookie[20];
- int ret = security_server_request_cookie(cookie, 10);
+ int ret = security_server_get_gid("abc123xyz_pysiaczek");
LogDebug("ret = " << ret);
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_BUFFER_TOO_SMALL == ret);
-}
-
-/*
- * test: tc04_security_server_get_gid_client_is_not_allowed
- * description: ??
- * expected: security_server_get_gid should return AUTHENTICATION_FAILED
- */
-RUNNER_CHILD_TEST(tc04_security_server_get_gid_client_is_not_allowed)
-{
- ENVIRONMENT;
-
- int ret = security_server_get_gid("telephony");
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_ERROR_NO_SUCH_OBJECT == ret, "Ret: " << ret);
+ ret = security_server_get_gid("root");
LogDebug("ret = " << ret);
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_AUTHENTICATION_FAILED == ret);
+ RUNNER_ASSERT_MSG_BT(0 == ret, "Ret: " << ret);
}
/*
* expected: Function call with access rights set to "r" should return SUCCESS,
* with "rw" should return ACCESS DENIED.
*/
-RUNNER_CHILD_TEST(tc05_check_privilege_by_cookie)
+RUNNER_CHILD_TEST_SMACK(tc05_check_privilege_by_cookie)
{
char cookie[20];
const char *object_label = "tc05objectlabel";
const char *access_rights_ext = "rw";
const char *subject_label = "tc05subjectlabel";
- smack_accesses *handle;
-
- RUNNER_ASSERT(0 == smack_accesses_new(&handle));
-
- RUNNER_ASSERT(0 == smack_accesses_add(handle,
- subject_label,
- object_label,
- access_rights));
+ SmackAccess access;
+ access.add(subject_label, object_label, access_rights);
+ access.add(subject_label, "security-server::api-cookie-check", "w");
+ access.apply();
- RUNNER_ASSERT(0 == smack_accesses_apply(handle));
+ RUNNER_ASSERT_BT(0 == smack_set_label_for_self(subject_label));
- smack_accesses_free(handle);
-
- RUNNER_ASSERT(0 == smack_set_label_for_self(subject_label));
-
- RUNNER_ASSERT(SECURITY_SERVER_API_SUCCESS ==
+ RUNNER_ASSERT_BT(SECURITY_SERVER_API_SUCCESS ==
security_server_request_cookie(cookie,20));
- RUNNER_ASSERT(SECURITY_SERVER_API_SUCCESS ==
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ RUNNER_ASSERT_BT(SECURITY_SERVER_API_SUCCESS ==
security_server_check_privilege_by_cookie(
cookie,
object_label,
access_rights));
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED ==
+ RUNNER_ASSERT_BT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED ==
security_server_check_privilege_by_cookie(
cookie,
object_label,
access_rights_ext));
-
}
/*
* expected: Function call with access rights set to "r" should return SUCCESS,
* with "rw" should return ACCESS DENIED.
*/
-RUNNER_TEST(tc06_check_privilege_by_sockfd)
+RUNNER_MULTIPROCESS_TEST_SMACK(tc06_check_privilege_by_sockfd)
{
-
const char *object_label = "tc06objectlabel";
const char *access_rights = "r";
const char *access_rights_ext = "rw";
int result2 = -1;
smack_accesses *handle;
- RUNNER_ASSERT(0 == smack_accesses_new(&handle));
- RUNNER_ASSERT(0 == smack_accesses_add(handle,
- subject_label,
- object_label,
- access_rights));
- RUNNER_ASSERT(0 == smack_accesses_apply(handle));
+ RUNNER_ASSERT_BT(0 == smack_accesses_new(&handle));
+ RUNNER_ASSERT_BT(0 == smack_accesses_add(handle,
+ subject_label,
+ object_label,
+ access_rights));
+ RUNNER_ASSERT_BT(0 == smack_accesses_apply(handle));
smack_accesses_free(handle);
int pid = fork();
char *label;
- RUNNER_ASSERT(-1 != pid);
+ RUNNER_ASSERT_BT(-1 != pid);
if (0 == pid) {
// child
- if (0 != smack_set_label_for_self(subject_label)) {
- LogDebug("child, failed");
- exit(1);
- }
+ RUNNER_ASSERT_MSG_BT(0 == smack_set_label_for_self(subject_label), "child label " << subject_label << " not set");
- LogDebug("child, create_new_socket");
int sockfd = create_new_socket();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "create_new_socket() failed");
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
label = security_server_get_smacklabel_sockfd(sockfd);
- RUNNER_ASSERT_MSG(label != NULL, "security_server_get_smacklabel_sockfd failed");
- RUNNER_ASSERT_MSG(strcmp(label,"")==0, "label is \""<< label<<"\"");
+ RUNNER_ASSERT_MSG_BT(label != NULL, "security_server_get_smacklabel_sockfd failed");
+ RUNNER_ASSERT_MSG_BT(strcmp(label,"") == 0, "label is \"" << label << "\"");
free(label);
- LogDebug("child, listen");
- if (listen(sockfd, 5) < 0) {
- LogDebug("child, exit");
- exit(1);
- }
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ RUNNER_ASSERT_MSG_BT(listen(sockfd, 5) >= 0, "child listen failed");
label = security_server_get_smacklabel_sockfd(sockfd);
- RUNNER_ASSERT_MSG(label != NULL, "security_server_get_smacklabel_sockfd failed");
- RUNNER_ASSERT_MSG(strcmp(label,"")==0, "label is \""<< label<<"\"");
+ RUNNER_ASSERT_MSG_BT(label != NULL, "security_server_get_smacklabel_sockfd failed");
+ RUNNER_ASSERT_MSG_BT(strcmp(label,"") == 0, "label is \"" << label << "\"");
free(label);
-
- LogDebug("child, accept");
struct sockaddr_un client_addr;
socklen_t client_len = sizeof(client_addr);
int csockfd;
- while(0 <= (csockfd = accept(sockfd,(struct sockaddr*)&client_addr, &client_len))) {
- LogDebug("child, loop");
- close(csockfd);
- }
+ RUNNER_ASSERT_MSG_BT((csockfd = accept(sockfd,(struct sockaddr*)&client_addr, &client_len)) > 0, "child accept failed");
+ usleep(500);
- label = security_server_get_smacklabel_sockfd(sockfd);
- RUNNER_ASSERT_MSG(label != NULL, "security_server_get_smacklabel_sockfd failed");
- RUNNER_ASSERT_MSG(strcmp(label,subject_label)==0, "label is \""<< label<<"\"" << "subject_label is \""<< subject_label<<"\"" );
- free(label);
-
- LogDebug("Exit!");
- exit(1);
+ close(csockfd);
+ exit(0);
} else {
// parent
- LogDebug("Parent, sleep 2");
sleep(1);
int sockfd = connect_to_testserver();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "connect_to_testserver() failed");
+
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
label = security_server_get_smacklabel_sockfd(sockfd);
- RUNNER_ASSERT_MSG(label != NULL, "security_server_get_smacklabel_sockfd failed");
- RUNNER_ASSERT_MSG(strcmp(label,subject_label)==0, "label is \""<< label<<"\"" << "subject_label is \""<< subject_label<<"\"" );
+ RUNNER_ASSERT_MSG_BT(label != NULL, "security_server_get_smacklabel_sockfd failed");
+ RUNNER_ASSERT_MSG_BT(strcmp(label,subject_label) == 0, "label is \"" << label << "\"" << ", subject_label is \"" << subject_label << "\"" );
free(label);
- LogDebug("Parent: sockfd: " << sockfd);
- if (sockfd >= 0) {
- result1 = security_server_check_privilege_by_sockfd(
- sockfd,
- object_label,
- access_rights);
- result2 = security_server_check_privilege_by_sockfd(
- sockfd,
- object_label,
- access_rights_ext);
- }
- LogDebug("Parent: Close desc");
- close(sockfd);
- LogDebug("Parent: killing child");
- kill(pid, SIGKILL);
+ result1 = security_server_check_privilege_by_sockfd(
+ sockfd,
+ object_label,
+ access_rights);
+ result2 = security_server_check_privilege_by_sockfd(
+ sockfd,
+ object_label,
+ access_rights_ext);
}
- int status;
- waitpid(pid, &status, 0);
-
- RUNNER_ASSERT(SECURITY_SERVER_API_SUCCESS == result1);
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED == result2);
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_SUCCESS == result1, "result = " << result1);
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED == result2, "result = " << result2);
}
/*
* test: security_server_check_privilege_by_sockfd
* description: This test will create dummy server that will accept connection
* and die. The client will try to check access rights using connection descriptor.
- * Unfortunatelly in this cases smack_set_label_for_self will not change label
- * connected with unix socket. Thats why this test will fail.
+ * Because we read a smack label not from socket directly, but from from pid of process
+ * on the other end of socket - that's why smack label will be updated.
+ * In this test client is running under root and server is not - to test the extreme case.
* expected: Function call with access rights set to "r" should return SUCCESS,
* with "rw" should return ACCESS DENIED.
*/
-RUNNER_TEST(tc07_check_privilege_by_sockfd)
+RUNNER_MULTIPROCESS_TEST_SMACK(tc07_check_privilege_by_sockfd)
{
-
const char *object_label = "tc07objectlabel";
const char *access_rights = "r";
const char *access_rights_ext = "rw";
int result1 = -1;
int result2 = -1;
- smack_accesses *handle;
- RUNNER_ASSERT(0 == smack_accesses_new(&handle));
- RUNNER_ASSERT(0 == smack_accesses_add(handle,
- subject_label,
- object_label,
- access_rights));
- RUNNER_ASSERT(0 == smack_accesses_apply(handle));
- smack_accesses_free(handle);
+ SmackAccess access;
+ access.add(subject_label, object_label, access_rights);
+ access.apply();
int pid = fork();
- RUNNER_ASSERT(-1 != pid);
+ RUNNER_ASSERT_BT(-1 != pid);
if (0 == pid) {
- // child
- LogDebug("child, create_new_socket");
- int sockfd = create_new_socket();
- if (0 != smack_set_label_for_self(subject_label)) {
- LogDebug("child, failed");
- exit(1);
- }
+ pid = fork();
+ RUNNER_ASSERT_BT(-1 != pid);
- LogDebug("child, listen");
- if (listen(sockfd, 5) < 0) {
- LogDebug("child, exit");
- exit(1);
- }
- LogDebug("child, accept");
+ if (0 == pid) {
+ // child
+ int sockfd = create_new_socket();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "create_new_socket() failed");
+
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
+
+ RUNNER_ASSERT_MSG_BT(0 == smack_set_label_for_self(subject_label), "child label " << subject_label << " not set");
+
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ RUNNER_ASSERT_MSG_BT(listen(sockfd, 5) >= 0, "child listen failed");
+
+ struct sockaddr_un client_addr;
+ socklen_t client_len = sizeof(client_addr);
+ int csockfd = TEMP_FAILURE_RETRY(accept(sockfd,(struct sockaddr*)&client_addr, &client_len));
+ if (csockfd >= 0)
+ close(csockfd);
+ LogDebug("Exit!");
+ exit(0);
+ } else {
+ // parent
+ sleep(1);
+ int sockfd = connect_to_testserver();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "connect_to_testserver() failed");
- struct sockaddr_un client_addr;
- socklen_t client_len = sizeof(client_addr);
- int csockfd;
- while(0 <= (csockfd = accept(sockfd,(struct sockaddr*)&client_addr, &client_len))) {
- LogDebug("child, loop");
- close(csockfd);
- }
- LogDebug("Exit!");
- exit(1);
- } else {
- // parent
- LogDebug("Parent, sleep 2");
- sleep(2);
- int sockfd = connect_to_testserver();
- LogDebug("Parent: sockfd: " << sockfd);
- if (sockfd >= 0) {
result1 = security_server_check_privilege_by_sockfd(
sockfd,
object_label,
sockfd,
object_label,
access_rights_ext);
+
+ close(sockfd);
+
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_SUCCESS == result1, "result1 = " << result1);
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED == result2, " result2 = " << result2);
+ }
+ }
+}
+
+///////////////////////////
+/////NOSMACK ENV TESTS/////
+///////////////////////////
+
+RUNNER_CHILD_TEST_NOSMACK(tc04_security_server_get_gid_nosmack)
+{
+ int ret;
+
+ ret = drop_root_privileges();
+ RUNNER_ASSERT_MSG_BT(ret == 0,
+ "Failed to drop root privileges. Result: " << ret << "uid = " << getuid());
+
+ ret = security_server_get_gid("definitely_not_existing_object");
+ RUNNER_ASSERT_MSG_BT(ret == SECURITY_SERVER_API_ERROR_NO_SUCH_OBJECT, "ret = " << ret);
+ ret = security_server_get_gid("root");
+ RUNNER_ASSERT_MSG_BT(ret == 0, "ret = " << ret);
+}
+
+/*
+ * NOSMACK version of tc05 test.
+ *
+ * Correct behaviour of smack_accesses_apply and smack_set_label_for_self was checked by libsmack
+ * tests. We assume, that those tests pass. Additionally security_server_check_privilege_by_cookie
+ * should return SUCCESS no matter what access_rights we give to this function.
+ */
+RUNNER_CHILD_TEST_NOSMACK(tc05_check_privilege_by_cookie_nosmack)
+{
+ char cookie[20];
+ const char* object_label = "tc05objectlabel";
+
+ RUNNER_ASSERT_BT(security_server_request_cookie(cookie,20) == SECURITY_SERVER_API_SUCCESS);
+
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ RUNNER_ASSERT_BT(SECURITY_SERVER_API_SUCCESS ==
+ security_server_check_privilege_by_cookie(cookie, object_label, "r"));
+
+ //On NOSMACK env security server should return success on any accesses, even those that are
+ //incorrect.
+ RUNNER_ASSERT_BT(SECURITY_SERVER_API_SUCCESS ==
+ security_server_check_privilege_by_cookie(cookie, object_label, "rw"));
+}
+
+/**
+ * NOSMACK version of tc06 test.
+ *
+ * Differences between this and SMACK version (server):
+ * - Skipped setting access_rights
+ * - Skipped setting label for server
+ * - get_smacklabel_sockfd is called only once for server, almost right after fork and creation
+ * of socket (because it should do nothing when SMACK is off)
+ * - After get_smacklabel_sockfd privileges are dropped and server is prepared to accept connections
+ * from client
+ *
+ * For client the only difference are expected results from check_privilege_by_sockfd - both should
+ * return SUCCESS.
+ */
+RUNNER_MULTIPROCESS_TEST_NOSMACK(tc06_check_privilege_by_sockfd_nosmack)
+{
+ const char* object_label = "tc06objectlabel";
+
+ int result1 = -1;
+ int result2 = -1;
+
+ int pid = fork();
+ char* label;
+ RUNNER_ASSERT_BT(pid >= 0);
+
+ int ret;
+
+ if (pid == 0) { //child process - server
+ //create new socket
+ int sockfd = create_new_socket();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "create_new_socket() failed");
+
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
+
+ //check if get_smacklabel_sockfd works correctly
+ label = security_server_get_smacklabel_sockfd(sockfd);
+ RUNNER_ASSERT_MSG_BT(label != NULL, "security_server_get_smacklabel_sockfd failed");
+ ret = strcmp(label, "");
+ free(label);
+ RUNNER_ASSERT_MSG_BT(ret == 0, "label is \"" << label << "\"");
+
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ RUNNER_ASSERT_MSG_BT(listen(sockfd, 5) >= 0, "child listen failed");
+
+ struct sockaddr_un client_addr;
+ socklen_t client_len = sizeof(client_addr);
+
+ int csockfd;
+ RUNNER_ASSERT_MSG_BT((csockfd = accept(sockfd,(struct sockaddr*)&client_addr, &client_len)) > 0, "child accept failed");
+
+ //wait a little bit for parent to do it's job
+ usleep(200);
+
+ //if everything works, cleanup and return 0
+ close(csockfd);
+ exit(0);
+ } else {
+ //parent
+ sleep(1);
+ int sockfd = connect_to_testserver();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "Failed to connect to server.");
+
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
+
+ label = security_server_get_smacklabel_sockfd(sockfd);
+ RUNNER_ASSERT_MSG_BT(label != NULL, "get_smacklabel_sockfd failed.");
+ ret = strcmp(label, "");
+ free(label);
+ RUNNER_ASSERT_MSG_BT(ret == 0, "label is \"" << label << "\"");
+
+ result1 = security_server_check_privilege_by_sockfd(sockfd, object_label, "r");
+ result2 = security_server_check_privilege_by_sockfd(sockfd, object_label, "rw");
+ }
+
+ RUNNER_ASSERT_MSG_BT(result1 == SECURITY_SERVER_API_SUCCESS, "result = " << result1);
+ RUNNER_ASSERT_MSG_BT(result2 == SECURITY_SERVER_API_SUCCESS, "result = " << result2);
+}
+
+/**
+ * NOSMACK version of tc07 test.
+ */
+RUNNER_MULTIPROCESS_TEST_NOSMACK(tc07_check_privilege_by_sockfd_nosmack)
+{
+ const char* object_label = "tc07objectlabel";
+
+ int result1 = -1;
+ int result2 = -1;
+
+ int pid = fork();
+ RUNNER_ASSERT_BT(-1 != pid);
+
+ if (pid == 0) {
+
+ pid = fork();
+ RUNNER_ASSERT_BT(-1 != pid);
+
+ if (pid == 0) { //child process
+ //Create socket
+ int sockfd = create_new_socket();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "create_new_socket() failed");
+
+ SockFDUniquePtr sockfd_ptr(&sockfd, closesockfdptr);
+
+ //Drop privileges
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ //Prepare for accepting
+ RUNNER_ASSERT_MSG_BT(listen(sockfd, 5) >= 0, "child listen failed");
+
+ struct sockaddr_un client_addr;
+ socklen_t client_len = sizeof(client_addr);
+
+ //Accept connections
+ int csockfd;
+ RUNNER_ASSERT_MSG_BT((csockfd = accept(sockfd,(struct sockaddr*)&client_addr, &client_len)) > 0, "child accept failed");
+
+ //wait a little bit for parent to do it's job
+ usleep(200);
+
+ //cleanup and kill child
+ close(csockfd);
+ exit(0);
+ } else { //parent process
+ //Drop root privileges
+ RUNNER_ASSERT_MSG_BT(drop_root_privileges() == 0, "uid = " << getuid());
+
+ //Wait for server to set up
+ sleep(1);
+
+ //Connect and check privileges
+ int sockfd = connect_to_testserver();
+ RUNNER_ASSERT_MSG_BT(sockfd >= 0, "Failed to create socket fd.");
+
+ result1 = security_server_check_privilege_by_sockfd(sockfd, object_label, "r");
+ result2 = security_server_check_privilege_by_sockfd(sockfd, object_label, "rw");
+
+ close(sockfd);
+
+ //Both results (just like in the previous test case) should return success.
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_SUCCESS == result1, "result1 = " << result1);
+ RUNNER_ASSERT_MSG_BT(SECURITY_SERVER_API_SUCCESS == result2, "result2 = " << result2);
}
- LogDebug("Parent: Close desc");
- close(sockfd);
- LogDebug("Parent: killing child");
- kill(pid, SIGKILL);
}
+}
+
+RUNNER_TEST_SMACK(tc18_security_server_get_smacklabel_cookie) {
+ int res;
+
+ char *label_smack = NULL;
+ char *label_ss = NULL;
+ char *cookie = NULL;
+
+ int cookie_size = security_server_get_cookie_size();
+ RUNNER_ASSERT_MSG_BT(PROPER_COOKIE_SIZE == cookie_size, "Wrong cookie size from security-server");
+
+ cookie = (char*) calloc(cookie_size, 1);
+ RUNNER_ASSERT_MSG_BT(NULL != cookie, "Memory allocation error");
+
+ res = security_server_request_cookie(cookie, cookie_size);
+ if (res != SECURITY_SERVER_API_SUCCESS) {
+ free(cookie);
+ RUNNER_ASSERT_MSG_BT(res == SECURITY_SERVER_API_SUCCESS, "Error in requesting cookie from security-server");
+ }
+
+ label_ss = security_server_get_smacklabel_cookie(cookie);
+ free(cookie);
+ RUNNER_ASSERT_MSG_BT(label_ss != NULL, "Error in getting label by cookie");
+
+
+ std::string label_cookie(label_ss);
+ free(label_ss);
+
+ res = smack_new_label_from_self(&label_smack);
+ if (res < 0) {
+ free(label_smack);
+ RUNNER_ASSERT_MSG_BT(res == 0, "Error in getting self SMACK label");
+ }
+ std::string label_self(label_smack ? label_smack : "");
+ free(label_smack);
+
+ RUNNER_ASSERT_MSG_BT(label_self == label_cookie, "No match in SMACK labels");
- int status;
- waitpid(pid, &status, 0);
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED == result1);
- RUNNER_ASSERT(SECURITY_SERVER_API_ERROR_ACCESS_DENIED == result2);
+ //TODO: here could be label change using SMACK API and checking if it
+ //is changed using security-server API function based on the same cookie
}
+/**
+ * NOSMACK version of tc_security_server_get_smacklabel_cookie test.
+ *
+ * Most of this test goes exactly as the original one. The only difference are the labels:
+ * - We assume that libsmack tests passed and smack_new_label_from_self will return -1 and NULL
+ * label - there is no need to re-check it.
+ * - Label acquired from security_server_get_smacklabel_cookie should be an empty string.
+ */
+RUNNER_TEST_NOSMACK(tc18_security_server_get_smacklabel_cookie_nosmack) {
+ int res;
+
+ char* label_ss = NULL;
+ char* cookie = NULL;
+
+ int cookie_size = security_server_get_cookie_size();
+ RUNNER_ASSERT_MSG_BT(PROPER_COOKIE_SIZE == cookie_size,
+ "Wrong cookie size from security-server. Size: " << cookie_size);
+
+ cookie = (char*) calloc(cookie_size, sizeof(char));
+ RUNNER_ASSERT_MSG_BT(NULL != cookie, "Memory allocation error");
+
+ //Request cookie from SS
+ res = security_server_request_cookie(cookie, cookie_size);
+ std::unique_ptr<char, std::function<void(char*)> > cookie_ptr(cookie, free);
+ cookie = NULL;
+ RUNNER_ASSERT_MSG_BT(res == SECURITY_SERVER_API_SUCCESS,
+ "Error in requesting cookie from security-server. Result: " << res);
+
+ label_ss = security_server_get_smacklabel_cookie(cookie_ptr.get());
+ RUNNER_ASSERT_MSG_BT(label_ss != NULL, "Error in getting label by cookie");
+
+ std::string label(label_ss);
+ free(label_ss);
+ RUNNER_ASSERT_MSG_BT(label.empty(), "label_ss is not an empty string.");
+
+}
+
+////////////////////
+/////MAIN///////////
+////////////////////
+
int main(int argc, char *argv[])
{
- return
- DPL::Test::TestRunnerSingleton::Instance().ExecTestRunner(argc, argv);
+ SummaryCollector::Register();
+ return DPL::Test::TestRunnerSingleton::Instance().ExecTestRunner(argc, argv);
}