btrfs-progs: tests: add shell quotes to misc test scripts

[platform/upstream/btrfs-progs.git] / tests / misc-tests / 011-delete-missing-device / test.sh

diff --git a/tests/misc-tests/011-delete-missing-device/test.sh b/tests/misc-tests/011-delete-missing-device/test.sh
index 26645f1..4c97642 100755 (executable)
--- a/tests/misc-tests/011-delete-missing-device/test.sh
+++ b/tests/misc-tests/011-delete-missing-device/test.sh
@@ -1,67 +1,40 @@
 #!/bin/bash
 # make sure that 'missing' is accepted for device deletion
 
-source $TOP/tests/common
+source "$TEST_TOP/common"
 
-check_prereq btrfs-show-super
 check_prereq mkfs.btrfs
 check_prereq btrfs
 
-ndevs=4
-declare -a devs
-dev1=
-devtodel=
-
 setup_root_helper
 
-prepare_devices()
-{
-       for i in `seq $ndevs`; do
-               touch img$i
-               chmod a+rw img$i
-               truncate -s0 img$i
-               truncate -s2g img$i
-               devs[$i]=`run_check_stdout $SUDO_HELPER losetup --find --show img$i`
-       done
-}
-
-cleanup_devices()
-{
-       for dev in ${devs[@]}; do
-               run_mayfail $SUDO_HELPER losetup -d $dev
-       done
-       for i in `seq $ndevs`; do
-               truncate -s0 img$i
-       done
-       run_check $SUDO_HELPER losetup --list
-}
-
 test_do_mkfs()
 {
-       run_check $SUDO_HELPER $TOP/mkfs.btrfs -f $@ ${devs[@]}
-       run_check $TOP/btrfs-show-super $dev1
-       run_check $SUDO_HELPER $TOP/btrfs check $dev1
-       run_check $TOP/btrfs filesystem show
+       run_check $SUDO_HELPER "$TOP/mkfs.btrfs" -f "$@" ${loopdevs[@]}
+       run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$dev1"
+       run_check $SUDO_HELPER "$TOP/btrfs" check "$dev1"
+       run_check $SUDO_HELPER "$TOP/btrfs" filesystem show
 }
 
 test_wipefs()
 {
-       run_check wipefs -a $devtodel
-       run_check $SUDO_HELPER losetup -d $devtodel
-       run_check losetup -a
-       run_check $TOP/btrfs filesystem show
+       run_check $SUDO_HELPER wipefs -a "$devtodel"
+       run_check $SUDO_HELPER losetup -d "$devtodel"
+       unset loopdevs[3]
+       run_check $SUDO_HELPER losetup --all
+       run_check "$TOP/btrfs" filesystem show
 }
 test_delete_missing()
 {
        run_check_mount_test_dev -o degraded
-       run_check $SUDO_HELPER $TOP/btrfs filesystem show $TEST_MNT
-       run_check $SUDO_HELPER $TOP/btrfs device delete missing $TEST_MNT
-       run_check $SUDO_HELPER $TOP/btrfs filesystem show $TEST_MNT
+       run_check $SUDO_HELPER "$TOP/btrfs" filesystem show "$TEST_MNT"
+       run_check $SUDO_HELPER "$TOP/btrfs" device delete missing "$TEST_MNT"
+       run_check $SUDO_HELPER "$TOP/btrfs" filesystem show "$TEST_MNT"
        run_check_umount_test_dev
 
        run_check_mount_test_dev
        local out
-       out="$(run_check_stdout $SUDO_HELPER $TOP/btrfs filesystem show $TEST_MNT)"
+       out=$(run_check_stdout $SUDO_HELPER "$TOP/btrfs" filesystem show "$TEST_MNT")
        if echo "$out" | grep -q -- "$devtodel"; then
                _fail "device $devtodel not deleted"
        fi
@@ -71,13 +44,14 @@ test_delete_missing()
        run_check_umount_test_dev
 }
 
-prepare_devices
-dev1=${devs[1]}
-devtodel=${devs[3]}
+setup_loopdevs 4
+prepare_loopdevs
+dev1=${loopdevs[1]}
+devtodel=${loopdevs[3]}
 TEST_DEV=$dev1
 
-test_do_mkfs
+test_do_mkfs -m raid1 -d raid1
 test_wipefs
 test_delete_missing
 
-cleanup_devices
+cleanup_loopdevs