test: Update tests to use the skip feature
[platform/kernel/u-boot.git] / test / dm / ofnode.c
index be5e315..8077aff 100644 (file)
@@ -100,7 +100,21 @@ static int dm_test_ofnode_compatible(struct unit_test_state *uts)
 
        return 0;
 }
-DM_TEST(dm_test_ofnode_compatible, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+DM_TEST(dm_test_ofnode_compatible,
+       UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
+
+/* check ofnode_device_is_compatible() with the 'other' FDT */
+static int dm_test_ofnode_compatible_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode oroot = oftree_root(otree);
+
+       ut_assert(ofnode_valid(oroot));
+       ut_assert(ofnode_device_is_compatible(oroot, "sandbox-other"));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_compatible_ot, UT_TESTF_OTHER_FDT);
 
 static int dm_test_ofnode_get_by_phandle(struct unit_test_state *uts)
 {
@@ -134,33 +148,56 @@ static int dm_test_ofnode_get_by_phandle_ot(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_get_by_phandle_ot, UT_TESTF_OTHER_FDT);
 
-static int dm_test_ofnode_by_prop_value(struct unit_test_state *uts)
+static int check_prop_values(struct unit_test_state *uts, ofnode start,
+                            const char *propname, const char *propval,
+                            int expect_count)
 {
-       const char propname[] = "compatible";
-       const char propval[] = "denx,u-boot-fdt-test";
+       int proplen = strlen(propval) + 1;
        const char *str;
-       ofnode node = ofnode_null();
+       ofnode node;
+       int count;
 
        /* Find first matching node, there should be at least one */
-       node = ofnode_by_prop_value(node, propname, propval, sizeof(propval));
+       node = ofnode_by_prop_value(start, propname, propval, proplen);
        ut_assert(ofnode_valid(node));
        str = ofnode_read_string(node, propname);
        ut_assert(str && !strcmp(str, propval));
 
        /* Find the rest of the matching nodes */
+       count = 1;
        while (true) {
-               node = ofnode_by_prop_value(node, propname, propval,
-                                           sizeof(propval));
+               node = ofnode_by_prop_value(node, propname, propval, proplen);
                if (!ofnode_valid(node))
                        break;
                str = ofnode_read_string(node, propname);
-               ut_assert(str && !strcmp(str, propval));
+               ut_asserteq_str(propval, str);
+               count++;
        }
+       ut_asserteq(expect_count, count);
+
+       return 0;
+}
+
+static int dm_test_ofnode_by_prop_value(struct unit_test_state *uts)
+{
+       ut_assertok(check_prop_values(uts, ofnode_null(), "compatible",
+                                     "denx,u-boot-fdt-test", 11));
 
        return 0;
 }
 DM_TEST(dm_test_ofnode_by_prop_value, UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_by_prop_value_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+
+       ut_assertok(check_prop_values(uts, oftree_root(otree), "str-prop",
+                                     "other", 2));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_by_prop_value_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_fmap(struct unit_test_state *uts)
 {
        struct fmap_entry entry;
@@ -202,6 +239,25 @@ static int dm_test_ofnode_read(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_read, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_read_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       const char *val;
+       ofnode node;
+       int size;
+
+       node = oftree_path(otree, "/node/subnode");
+       ut_assert(ofnode_valid(node));
+
+       val = ofnode_read_prop(node, "str-prop", &size);
+       ut_assertnonnull(val);
+       ut_asserteq_str("other", val);
+       ut_asserteq(6, size);
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_read_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_phandle(struct unit_test_state *uts)
 {
        struct ofnode_phandle_args args;
@@ -377,6 +433,27 @@ static int dm_test_ofnode_get_child_count(struct unit_test_state *uts)
 DM_TEST(dm_test_ofnode_get_child_count,
        UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_get_child_count_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode node, child_node;
+       u32 val;
+
+       node = oftree_path(otree, "/node");
+       ut_assert(ofnode_valid(node));
+
+       val = ofnode_get_child_count(node);
+       ut_asserteq(2, val);
+
+       child_node = ofnode_first_subnode(node);
+       ut_assert(ofnode_valid(child_node));
+       val = ofnode_get_child_count(child_node);
+       ut_asserteq(0, val);
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_get_child_count_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_is_enabled(struct unit_test_state *uts)
 {
        ofnode root_node = ofnode_path("/");
@@ -389,6 +466,19 @@ static int dm_test_ofnode_is_enabled(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_is_enabled, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_is_enabled_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode root_node = oftree_root(otree);
+       ofnode node = oftree_path(otree, "/target");
+
+       ut_assert(ofnode_is_enabled(root_node));
+       ut_assert(!ofnode_is_enabled(node));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_is_enabled_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_get_reg(struct unit_test_state *uts)
 {
        ofnode node;
@@ -425,30 +515,59 @@ static int dm_test_ofnode_get_reg(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_get_reg, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_get_reg_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode node = oftree_path(otree, "/target");
+       fdt_addr_t addr;
+
+       addr = ofnode_get_addr(node);
+       ut_asserteq(0x8000, addr);
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_get_reg_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_get_path(struct unit_test_state *uts)
 {
        const char *path = "/translation-test@8000/noxlatebus@3,300/dev@42";
        char buf[64];
        ofnode node;
-       int res;
 
        node = ofnode_path(path);
        ut_assert(ofnode_valid(node));
 
-       res = ofnode_get_path(node, buf, 64);
-       ut_asserteq(0, res);
+       ut_assertok(ofnode_get_path(node, buf, sizeof(buf)));
        ut_asserteq_str(path, buf);
 
-       res = ofnode_get_path(node, buf, 32);
-       ut_asserteq(-ENOSPC, res);
+       ut_asserteq(-ENOSPC, ofnode_get_path(node, buf, 32));
 
-       res = ofnode_get_path(ofnode_root(), buf, 32);
+       ut_assertok(ofnode_get_path(ofnode_root(), buf, 32));
        ut_asserteq_str("/", buf);
 
        return 0;
 }
 DM_TEST(dm_test_ofnode_get_path, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_get_path_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       const char *path = "/node/subnode";
+       ofnode node = oftree_path(otree, path);
+       char buf[64];
+
+       ut_assert(ofnode_valid(node));
+
+       ut_assertok(ofnode_get_path(node, buf, sizeof(buf)));
+       ut_asserteq_str(path, buf);
+
+       ut_assertok(ofnode_get_path(oftree_root(otree), buf, 32));
+       ut_asserteq_str("/", buf);
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_get_path_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_conf(struct unit_test_state *uts)
 {
        ut_assert(!ofnode_conf_read_bool("missing"));
@@ -608,13 +727,17 @@ DM_TEST(dm_test_ofnode_get_phy, 0);
  * @uts: Test state
  * @fdt: Place to write FDT
  * @size: Maximum size of space for fdt
+ * @id: id value to add to the tree ('id' property in root node)
  */
-static int make_ofnode_fdt(struct unit_test_state *uts, void *fdt, int size)
+static int make_ofnode_fdt(struct unit_test_state *uts, void *fdt, int size,
+                          int id)
 {
        ut_assertok(fdt_create(fdt, size));
        ut_assertok(fdt_finish_reservemap(fdt));
        ut_assert(fdt_begin_node(fdt, "") >= 0);
 
+       ut_assertok(fdt_property_u32(fdt, "id", id));
+
        ut_assert(fdt_begin_node(fdt, "aliases") >= 0);
        ut_assertok(fdt_property_string(fdt, "mmc0", "/new-mmc"));
        ut_assertok(fdt_end_node(fdt));
@@ -630,10 +753,7 @@ static int make_ofnode_fdt(struct unit_test_state *uts, void *fdt, int size)
 
 static int dm_test_ofnode_root(struct unit_test_state *uts)
 {
-       char fdt[256];
-       oftree tree;
        ofnode node;
-       int ret;
 
        /* Check that aliases work on the control FDT */
        node = ofnode_get_aliases_node("ethernet3");
@@ -642,14 +762,22 @@ static int dm_test_ofnode_root(struct unit_test_state *uts)
 
        ut_assert(!oftree_valid(oftree_null()));
 
-       ut_assertok(make_ofnode_fdt(uts, fdt, sizeof(fdt)));
-       ret = get_oftree(uts, fdt, &tree);
+       return 0;
+}
+DM_TEST(dm_test_ofnode_root, UT_TESTF_SCAN_FDT);
+
+static int dm_test_ofnode_root_mult(struct unit_test_state *uts)
+{
+       char fdt[256];
+       oftree tree;
+       ofnode node;
 
-       /* skip the rest of this test if multiple FDTs are not supported */
-       if (ret == -EOVERFLOW)
-               return 0;
+       /* skip this test if multiple FDTs are not supported */
+       if (!IS_ENABLED(CONFIG_OFNODE_MULTI_TREE))
+               return -EAGAIN;
 
-       ut_assertok(ret);
+       ut_assertok(make_ofnode_fdt(uts, fdt, sizeof(fdt), 0));
+       ut_assertok(get_oftree(uts, fdt, &tree));
        ut_assert(oftree_valid(tree));
 
        /* Make sure they don't work on this new tree */
@@ -668,7 +796,7 @@ static int dm_test_ofnode_root(struct unit_test_state *uts)
 
        return 0;
 }
-DM_TEST(dm_test_ofnode_root, UT_TESTF_SCAN_FDT);
+DM_TEST(dm_test_ofnode_root_mult, UT_TESTF_SCAN_FDT);
 
 static int dm_test_ofnode_livetree_writing(struct unit_test_state *uts)
 {
@@ -699,7 +827,8 @@ static int dm_test_ofnode_livetree_writing(struct unit_test_state *uts)
        ut_asserteq_64(FDT_ADDR_T_NONE, dev_read_addr(dev));
        /* reg = 0x42, size = 0x100 */
        ut_assertok(ofnode_write_prop(node, "reg",
-                                     "\x00\x00\x00\x42\x00\x00\x01\x00", 8));
+                                     "\x00\x00\x00\x42\x00\x00\x01\x00", 8,
+                                     false));
        ut_asserteq(0x42, dev_read_addr(dev));
 
        /* Test disabling devices */
@@ -715,6 +844,65 @@ static int dm_test_ofnode_livetree_writing(struct unit_test_state *uts)
 DM_TEST(dm_test_ofnode_livetree_writing,
        UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT);
 
+static int check_write_prop(struct unit_test_state *uts, ofnode node)
+{
+       char prop[] = "middle-name";
+       char name[10];
+       int len;
+
+       strcpy(name, "cecil");
+       len = strlen(name) + 1;
+       ut_assertok(ofnode_write_prop(node, prop, name, len, false));
+       ut_asserteq_str(name, ofnode_read_string(node, prop));
+
+       /* change the underlying value, this should mess up the live tree */
+       strcpy(name, "tony");
+       if (of_live_active()) {
+               ut_asserteq_str(name, ofnode_read_string(node, prop));
+       } else {
+               ut_asserteq_str("cecil", ofnode_read_string(node, prop));
+       }
+
+       /* try again, this time copying the property */
+       strcpy(name, "mary");
+       ut_assertok(ofnode_write_prop(node, prop, name, len, true));
+       ut_asserteq_str(name, ofnode_read_string(node, prop));
+       strcpy(name, "leah");
+
+       /* both flattree and livetree behave the same */
+       ut_asserteq_str("mary", ofnode_read_string(node, prop));
+
+       return 0;
+}
+
+/* writing the tree with and without copying the property */
+static int dm_test_ofnode_write_copy(struct unit_test_state *uts)
+{
+       ofnode node;
+
+       node = ofnode_path("/a-test");
+       ut_assertok(check_write_prop(uts, node));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_write_copy, UT_TESTF_SCAN_FDT);
+
+static int dm_test_ofnode_write_copy_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode node, check_node;
+
+       node = oftree_path(otree, "/node");
+       ut_assertok(check_write_prop(uts, node));
+
+       /* make sure the control FDT is not touched */
+       check_node = ofnode_path("/node");
+       ut_assertnull(ofnode_read_string(check_node, "middle-name"));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_write_copy_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_u32(struct unit_test_state *uts)
 {
        ofnode node;
@@ -892,6 +1080,23 @@ static int dm_test_ofnode_by_compatible(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_by_compatible, UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_by_compatible_ot(struct unit_test_state *uts)
+{
+       const char *compat = "sandbox-other2";
+       oftree otree = get_other_oftree(uts);
+       ofnode node;
+       int count;
+
+       count = 0;
+       for (node = oftree_root(otree);
+            node = ofnode_by_compatible(node, compat), ofnode_valid(node);)
+               count++;
+       ut_asserteq(2, count);
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_by_compatible_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_find_subnode(struct unit_test_state *uts)
 {
        ofnode node, subnode;
@@ -909,6 +1114,24 @@ static int dm_test_ofnode_find_subnode(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_ofnode_find_subnode, UT_TESTF_SCAN_FDT);
 
+static int dm_test_ofnode_find_subnode_ot(struct unit_test_state *uts)
+{
+       oftree otree = get_other_oftree(uts);
+       ofnode node, subnode;
+
+       node = oftree_path(otree, "/node");
+
+       subnode = ofnode_find_subnode(node, "subnode");
+       ut_assert(ofnode_valid(subnode));
+       ut_asserteq_str("subnode", ofnode_get_name(subnode));
+
+       subnode = ofnode_find_subnode(node, "btn");
+       ut_assert(!ofnode_valid(subnode));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_find_subnode_ot, UT_TESTF_OTHER_FDT);
+
 static int dm_test_ofnode_get_name(struct unit_test_state *uts)
 {
        ofnode node;
@@ -921,3 +1144,99 @@ static int dm_test_ofnode_get_name(struct unit_test_state *uts)
        return 0;
 }
 DM_TEST(dm_test_ofnode_get_name, UT_TESTF_SCAN_FDT);
+
+/* try to access more FDTs than is supported */
+static int dm_test_ofnode_too_many(struct unit_test_state *uts)
+{
+       const int max_trees = CONFIG_IS_ENABLED(OFNODE_MULTI_TREE,
+                                       (CONFIG_OFNODE_MULTI_TREE_MAX), (1));
+       const int fdt_size = 256;
+       const int num_trees = max_trees + 1;
+       char fdt[num_trees][fdt_size];
+       int i;
+
+       for (i = 0; i < num_trees; i++) {
+               oftree tree;
+               int ret;
+
+               ut_assertok(make_ofnode_fdt(uts, fdt[i], fdt_size, i));
+               ret = get_oftree(uts, fdt[i], &tree);
+
+               /*
+                * With flat tree we have the control FDT using one slot. Live
+                * tree has no limit since it uses pointers, not integer tree
+                * IDs
+                */
+               if (of_live_active() || i < max_trees - 1) {
+                       ut_assertok(ret);
+               } else {
+                       /*
+                        * tree should be invalid when we try to register too
+                        * many trees
+                        */
+                       ut_asserteq(-EOVERFLOW, ret);
+               }
+       }
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_too_many, UT_TESTF_SCAN_FDT);
+
+static int check_copy_props(struct unit_test_state *uts, ofnode src,
+                           ofnode dst)
+{
+       u32 reg[2], val;
+
+       ut_assertok(ofnode_copy_props(src, dst));
+
+       ut_assertok(ofnode_read_u32(dst, "ping-expect", &val));
+       ut_asserteq(3, val);
+
+       ut_asserteq_str("denx,u-boot-fdt-test",
+                       ofnode_read_string(dst, "compatible"));
+
+       /* check that a property with the same name is overwritten */
+       ut_assertok(ofnode_read_u32_array(dst, "reg", reg, ARRAY_SIZE(reg)));
+       ut_asserteq(3, reg[0]);
+       ut_asserteq(1, reg[1]);
+
+       /* reset the compatible so the live tree does not change */
+       ut_assertok(ofnode_write_string(dst, "compatible", "nothing"));
+
+       return 0;
+}
+
+static int dm_test_ofnode_copy_props(struct unit_test_state *uts)
+{
+       ofnode src, dst;
+
+       /*
+        * These nodes are chosen so that the src node is before the destination
+        * node in the tree. This doesn't matter with livetree, but with
+        * flattree any attempt to insert a property earlier in the tree will
+        * mess up the offsets after it.
+        */
+       src = ofnode_path("/b-test");
+       dst = ofnode_path("/some-bus");
+
+       ut_assertok(check_copy_props(uts, src, dst));
+
+       /* check a property that is in the destination already */
+       ut_asserteq_str("mux0", ofnode_read_string(dst, "mux-control-names"));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_copy_props, UT_TESTF_SCAN_FDT);
+
+static int dm_test_ofnode_copy_props_ot(struct unit_test_state *uts)
+{
+       ofnode src, dst;
+       oftree otree = get_other_oftree(uts);
+
+       src = ofnode_path("/b-test");
+       dst = oftree_path(otree, "/node/subnode2");
+       ut_assertok(check_copy_props(uts, src, dst));
+
+       return 0;
+}
+DM_TEST(dm_test_ofnode_copy_props_ot, UT_TESTF_SCAN_FDT | UT_TESTF_OTHER_FDT);