Add user configurable mask generation
[contrib/qtwebsockets.git] / src / websockets / qwebsocket_p.cpp
index 9537f2a..bff060f 100644 (file)
 #include "qwebsocketprotocol_p.h"
 #include "qwebsockethandshakerequest_p.h"
 #include "qwebsockethandshakeresponse_p.h"
+#include "qdefaultmaskgenerator_p.h"
 
 #include <QtCore/QUrl>
+#include <QtNetwork/QAuthenticator>
 #include <QtNetwork/QTcpSocket>
 #include <QtCore/QByteArray>
 #include <QtCore/QtEndian>
@@ -85,11 +87,12 @@ QWebSocketConfiguration::QWebSocketConfiguration() :
 /*!
     \internal
 */
-QWebSocketPrivate::QWebSocketPrivate(const QString &origin, QWebSocketProtocol::Version version, QWebSocket *pWebSocket, QObject *parent) :
-    QObject(parent),
+QWebSocketPrivate::QWebSocketPrivate(const QString &origin, QWebSocketProtocol::Version version,
+                                     QWebSocket *pWebSocket) :
+    QObjectPrivate(),
     q_ptr(pWebSocket),
     m_pSocket(),
-    m_errorString(),
+    m_errorString(QWebSocket::tr("Unknown error")),
     m_version(version),
     m_resourceName(),
     m_requestUrl(),
@@ -97,25 +100,28 @@ QWebSocketPrivate::QWebSocketPrivate(const QString &origin, QWebSocketProtocol::
     m_protocol(),
     m_extension(),
     m_socketState(QAbstractSocket::UnconnectedState),
+    m_pauseMode(QAbstractSocket::PauseNever),
+    m_readBufferSize(0),
     m_key(),
     m_mustMask(true),
     m_isClosingHandshakeSent(false),
     m_isClosingHandshakeReceived(false),
-    m_closeCode(QWebSocketProtocol::CC_NORMAL),
+    m_closeCode(QWebSocketProtocol::CloseCodeNormal),
     m_closeReason(),
     m_pingTimer(),
     m_dataProcessor(),
-    m_configuration()
+    m_configuration(),
+    m_pMaskGenerator(&m_defaultMaskGenerator),
+    m_defaultMaskGenerator()
 {
-    Q_ASSERT(pWebSocket);
-    qsrand(static_cast<uint>(QDateTime::currentMSecsSinceEpoch()));
 }
 
 /*!
     \internal
 */
-QWebSocketPrivate::QWebSocketPrivate(QTcpSocket *pTcpSocket, QWebSocketProtocol::Version version, QWebSocket *pWebSocket, QObject *parent) :
-    QObject(parent),
+QWebSocketPrivate::QWebSocketPrivate(QTcpSocket *pTcpSocket, QWebSocketProtocol::Version version,
+                                     QWebSocket *pWebSocket) :
+    QObjectPrivate(),
     q_ptr(pWebSocket),
     m_pSocket(pTcpSocket),
     m_errorString(pTcpSocket->errorString()),
@@ -126,46 +132,56 @@ QWebSocketPrivate::QWebSocketPrivate(QTcpSocket *pTcpSocket, QWebSocketProtocol:
     m_protocol(),
     m_extension(),
     m_socketState(pTcpSocket->state()),
+    m_pauseMode(pTcpSocket->pauseMode()),
+    m_readBufferSize(pTcpSocket->readBufferSize()),
     m_key(),
     m_mustMask(true),
     m_isClosingHandshakeSent(false),
     m_isClosingHandshakeReceived(false),
-    m_closeCode(QWebSocketProtocol::CC_NORMAL),
+    m_closeCode(QWebSocketProtocol::CloseCodeNormal),
     m_closeReason(),
     m_pingTimer(),
     m_dataProcessor(),
-    m_configuration()
+    m_configuration(),
+    m_pMaskGenerator(&m_defaultMaskGenerator),
+    m_defaultMaskGenerator()
 {
-    Q_ASSERT(pWebSocket);
-    makeConnections(m_pSocket.data());
 }
 
 /*!
     \internal
 */
-QWebSocketPrivate::~QWebSocketPrivate()
+void QWebSocketPrivate::init()
 {
-    if (m_pSocket)
-    {
-        if (state() == QAbstractSocket::ConnectedState)
-        {
-            close(QWebSocketProtocol::CC_GOING_AWAY, tr("Connection closed"));
-        }
-        releaseConnections(m_pSocket.data());
-//        m_pSocket->deleteLater();
-//        m_pSocket = Q_NULLPTR;
+    Q_ASSERT(q_ptr);
+    Q_ASSERT(m_pMaskGenerator);
+
+    m_pMaskGenerator->seed();
+
+    if (m_pSocket) {
+        makeConnections(m_pSocket.data());
     }
 }
 
 /*!
     \internal
+*/
+QWebSocketPrivate::~QWebSocketPrivate()
+{
+    if (!m_pSocket)
+        return;
+    if (state() == QAbstractSocket::ConnectedState)
+        close(QWebSocketProtocol::CloseCodeGoingAway, QWebSocket::tr("Connection closed"));
+    releaseConnections(m_pSocket.data());
+}
+
+/*!
+    \internal
  */
 void QWebSocketPrivate::abort()
 {
     if (m_pSocket)
-    {
         m_pSocket->abort();
-    }
 }
 
 /*!
@@ -173,11 +189,9 @@ void QWebSocketPrivate::abort()
  */
 QAbstractSocket::SocketError QWebSocketPrivate::error() const
 {
-    QAbstractSocket::SocketError err = QAbstractSocket::OperationError;
-    if (m_pSocket)
-    {
+    QAbstractSocket::SocketError err = QAbstractSocket::UnknownSocketError;
+    if (Q_LIKELY(m_pSocket))
         err = m_pSocket->error();
-    }
     return err;
 }
 
@@ -188,13 +202,9 @@ QString QWebSocketPrivate::errorString() const
 {
     QString errMsg;
     if (!m_errorString.isEmpty())
-    {
         errMsg = m_errorString;
-    }
     else if (m_pSocket)
-    {
         errMsg = m_pSocket->errorString();
-    }
     return errMsg;
 }
 
@@ -204,47 +214,25 @@ QString QWebSocketPrivate::errorString() const
 bool QWebSocketPrivate::flush()
 {
     bool result = true;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         result = m_pSocket->flush();
-    }
     return result;
 }
 
 /*!
     \internal
  */
-qint64 QWebSocketPrivate::write(const char *message)
-{
-    //TODO: create a QByteArray from message, and directly call doWriteData
-    //now the data is converted to a string, and then converted back to a bytearray
-    return write(QString::fromUtf8(message));
-}
-
-/*!
-    \internal
- */
-qint64 QWebSocketPrivate::write(const char *message, qint64 maxSize)
+qint64 QWebSocketPrivate::sendTextMessage(const QString &message)
 {
-    //TODO: create a QByteArray from message, and directly call doWriteData
-    //now the data is converted to a string, and then converted back to a bytearray
-    return write(QString::fromUtf8(message, static_cast<int>(maxSize)));
+    return doWriteFrames(message.toUtf8(), false);
 }
 
 /*!
     \internal
  */
-qint64 QWebSocketPrivate::write(const QString &message)
+qint64 QWebSocketPrivate::sendBinaryMessage(const QByteArray &data)
 {
-    return doWriteData(message.toUtf8(), false);
-}
-
-/*!
-    \internal
- */
-qint64 QWebSocketPrivate::write(const QByteArray &data)
-{
-    return doWriteData(data, true);
+    return doWriteFrames(data, true);
 }
 
 #ifndef QT_NO_SSL
@@ -278,13 +266,10 @@ void QWebSocketPrivate::ignoreSslErrors(const QList<QSslError> &errors)
 void QWebSocketPrivate::ignoreSslErrors()
 {
     m_configuration.m_ignoreSslErrors = true;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket)) {
         QSslSocket *pSslSocket = qobject_cast<QSslSocket *>(m_pSocket.data());
-        if (pSslSocket)
-        {
+        if (Q_LIKELY(pSslSocket))
             pSslSocket->ignoreSslErrors();
-        }
     }
 }
 
@@ -300,13 +285,15 @@ QWebSocket *QWebSocketPrivate::upgradeFrom(QTcpSocket *pTcpSocket,
                                            QObject *parent)
 {
     QWebSocket *pWebSocket = new QWebSocket(pTcpSocket, response.acceptedVersion(), parent);
-    pWebSocket->d_func()->setExtension(response.acceptedExtension());
-    pWebSocket->d_func()->setOrigin(request.origin());
-    pWebSocket->d_func()->setRequestUrl(request.requestUrl());
-    pWebSocket->d_func()->setProtocol(response.acceptedProtocol());
-    pWebSocket->d_func()->setResourceName(request.requestUrl().toString(QUrl::RemoveUserInfo));
-    //a server should not send masked frames
-    pWebSocket->d_func()->enableMasking(false);
+    if (Q_LIKELY(pWebSocket)) {
+        pWebSocket->d_func()->setExtension(response.acceptedExtension());
+        pWebSocket->d_func()->setOrigin(request.origin());
+        pWebSocket->d_func()->setRequestUrl(request.requestUrl());
+        pWebSocket->d_func()->setProtocol(response.acceptedProtocol());
+        pWebSocket->d_func()->setResourceName(request.requestUrl().toString(QUrl::RemoveUserInfo));
+        //a server should not send masked frames
+        pWebSocket->d_func()->enableMasking(false);
+    }
 
     return pWebSocket;
 }
@@ -316,38 +303,31 @@ QWebSocket *QWebSocketPrivate::upgradeFrom(QTcpSocket *pTcpSocket,
  */
 void QWebSocketPrivate::close(QWebSocketProtocol::CloseCode closeCode, QString reason)
 {
-    if (m_pSocket)
-    {
-        if (!m_isClosingHandshakeSent)
-        {
-            Q_Q(QWebSocket);
-            quint32 maskingKey = 0;
-            if (m_mustMask)
-            {
-                maskingKey = generateMaskingKey();
-            }
-            const quint16 code = qToBigEndian<quint16>(closeCode);
-            QByteArray payload;
-            payload.append(static_cast<const char *>(static_cast<const void *>(&code)), 2);
-            if (!reason.isEmpty())
-            {
-                payload.append(reason.toUtf8());
-            }
-            if (m_mustMask)
-            {
-                QWebSocketProtocol::mask(payload.data(), payload.size(), maskingKey);
-            }
-            QByteArray frame = getFrameHeader(QWebSocketProtocol::OC_CLOSE, payload.size(), maskingKey, true);
-            frame.append(payload);
-            m_pSocket->write(frame);
-            m_pSocket->flush();
+    if (Q_UNLIKELY(!m_pSocket))
+        return;
+    if (!m_isClosingHandshakeSent) {
+        Q_Q(QWebSocket);
+        const quint16 code = qToBigEndian<quint16>(closeCode);
+        QByteArray payload;
+        payload.append(static_cast<const char *>(static_cast<const void *>(&code)), 2);
+        if (!reason.isEmpty())
+            payload.append(reason.toUtf8());
+        quint32 maskingKey = 0;
+        if (m_mustMask) {
+            maskingKey = generateMaskingKey();
+            QWebSocketProtocol::mask(payload.data(), payload.size(), maskingKey);
+        }
+        QByteArray frame = getFrameHeader(QWebSocketProtocol::OpCodeClose,
+                                          payload.size(), maskingKey, true);
+        frame.append(payload);
+        m_pSocket->write(frame);
+        m_pSocket->flush();
 
-            m_isClosingHandshakeSent = true;
+        m_isClosingHandshakeSent = true;
 
-            Q_EMIT q->aboutToClose();
-        }
-        m_pSocket->close();
+        Q_EMIT q->aboutToClose();
     }
+    m_pSocket->close();
 }
 
 /*!
@@ -355,93 +335,113 @@ void QWebSocketPrivate::close(QWebSocketProtocol::CloseCode closeCode, QString r
  */
 void QWebSocketPrivate::open(const QUrl &url, bool mask)
 {
-    //m_pSocket.reset();  //just delete the old socket for the moment; later, we can add more 'intelligent' handling by looking at the url
+    //just delete the old socket for the moment;
+    //later, we can add more 'intelligent' handling by looking at the URL
+    //m_pSocket.reset();
+    Q_Q(QWebSocket);
+    if (!url.isValid() || url.toString().contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("Invalid URL."));
+        Q_EMIT q->error(QAbstractSocket::ConnectionRefusedError);
+        return;
+    }
     QTcpSocket *pTcpSocket = m_pSocket.take();
-    if (pTcpSocket)
-    {
+    if (pTcpSocket) {
         releaseConnections(pTcpSocket);
         pTcpSocket->deleteLater();
     }
     //if (m_url != url)
-    if (!m_pSocket)
-    {
-        Q_Q(QWebSocket);
-
+    if (Q_LIKELY(!m_pSocket)) {
         m_dataProcessor.clear();
         m_isClosingHandshakeReceived = false;
         m_isClosingHandshakeSent = false;
 
         setRequestUrl(url);
         QString resourceName = url.path();
-        if (!url.query().isEmpty())
-        {
-            if (!resourceName.endsWith(QChar::fromLatin1('?')))
-            {
+        if (resourceName.contains(QStringLiteral("\r\n"))) {
+            setRequestUrl(QUrl());  //clear requestUrl
+            setErrorString(QWebSocket::tr("Invalid resource name."));
+            Q_EMIT q->error(QAbstractSocket::ConnectionRefusedError);
+            return;
+        }
+        if (!url.query().isEmpty()) {
+            if (!resourceName.endsWith(QChar::fromLatin1('?'))) {
                 resourceName.append(QChar::fromLatin1('?'));
             }
             resourceName.append(url.query());
         }
         if (resourceName.isEmpty())
-        {
             resourceName = QStringLiteral("/");
-        }
         setResourceName(resourceName);
         enableMasking(mask);
 
     #ifndef QT_NO_SSL
-        if (url.scheme() == QStringLiteral("wss"))
-        {
-            if (!QSslSocket::supportsSsl())
-            {
-                const QString message = tr("SSL Sockets are not supported on this platform.");
-                qWarning() << message;
+        if (url.scheme() == QStringLiteral("wss")) {
+            if (!QSslSocket::supportsSsl()) {
+                const QString message =
+                        QWebSocket::tr("SSL Sockets are not supported on this platform.");
                 setErrorString(message);
-                emit q->error(QAbstractSocket::UnsupportedSocketOperationError);
-            }
-            else
-            {
-                QSslSocket *sslSocket = new QSslSocket(this);
+                Q_EMIT q->error(QAbstractSocket::UnsupportedSocketOperationError);
+            } else {
+                QSslSocket *sslSocket = new QSslSocket;
                 m_pSocket.reset(sslSocket);
-
-                makeConnections(m_pSocket.data());
-                connect(sslSocket, SIGNAL(encryptedBytesWritten(qint64)), q, SIGNAL(bytesWritten(qint64)));
-                setSocketState(QAbstractSocket::ConnectingState);
-
-                sslSocket->setSslConfiguration(m_configuration.m_sslConfiguration);
-                if (m_configuration.m_ignoreSslErrors)
-                {
-                    sslSocket->ignoreSslErrors();
-                }
-                else
-                {
-                    sslSocket->ignoreSslErrors(m_configuration.m_ignoredSslErrors);
+                if (Q_LIKELY(m_pSocket)) {
+                    m_pSocket->setSocketOption(QAbstractSocket::LowDelayOption, 1);
+                    m_pSocket->setSocketOption(QAbstractSocket::KeepAliveOption, 1);
+                    m_pSocket->setReadBufferSize(m_readBufferSize);
+                    m_pSocket->setPauseMode(m_pauseMode);
+
+                    makeConnections(m_pSocket.data());
+                    QObject::connect(sslSocket, &QSslSocket::encryptedBytesWritten, q,
+                                     &QWebSocket::bytesWritten);
+                    typedef void (QSslSocket:: *sslErrorSignalType)(const QList<QSslError> &);
+                    QObject::connect(sslSocket,
+                                     static_cast<sslErrorSignalType>(&QSslSocket::sslErrors),
+                                     q, &QWebSocket::sslErrors);
+                    setSocketState(QAbstractSocket::ConnectingState);
+
+                    sslSocket->setSslConfiguration(m_configuration.m_sslConfiguration);
+                    if (Q_UNLIKELY(m_configuration.m_ignoreSslErrors))
+                        sslSocket->ignoreSslErrors();
+                    else
+                        sslSocket->ignoreSslErrors(m_configuration.m_ignoredSslErrors);
+    #ifndef QT_NO_NETWORKPROXY
+                    sslSocket->setProxy(m_configuration.m_proxy);
+    #endif
+                    sslSocket->connectToHostEncrypted(url.host(), url.port(443));
+                } else {
+                    const QString message = QWebSocket::tr("Out of memory.");
+                    setErrorString(message);
+                    Q_EMIT q->error(QAbstractSocket::SocketResourceError);
                 }
-#ifndef QT_NO_NETWORKPROXY
-                sslSocket->setProxy(m_configuration.m_proxy);
-#endif
-                sslSocket->connectToHostEncrypted(url.host(), url.port(443));
             }
-        }
-        else
+        } else
     #endif
-        if (url.scheme() == QStringLiteral("ws"))
-        {
-            m_pSocket.reset(new QTcpSocket(this));
+        if (url.scheme() == QStringLiteral("ws")) {
+            m_pSocket.reset(new QTcpSocket);
+            if (Q_LIKELY(m_pSocket)) {
+                m_pSocket->setSocketOption(QAbstractSocket::LowDelayOption, 1);
+                m_pSocket->setSocketOption(QAbstractSocket::KeepAliveOption, 1);
+                m_pSocket->setReadBufferSize(m_readBufferSize);
+                m_pSocket->setPauseMode(m_pauseMode);
 
-            makeConnections(m_pSocket.data());
-            connect(m_pSocket.data(), SIGNAL(bytesWritten(qint64)), q, SIGNAL(bytesWritten(qint64)));
-            setSocketState(QAbstractSocket::ConnectingState);
-#ifndef QT_NO_NETWORKPROXY
-            m_pSocket->setProxy(m_configuration.m_proxy);
-#endif
-            m_pSocket->connectToHost(url.host(), url.port(80));
-        }
-        else
-        {
-            const QString message = tr("Unsupported websockets scheme: %1").arg(url.scheme());
-            qWarning() << message;
+                makeConnections(m_pSocket.data());
+                QObject::connect(m_pSocket.data(), &QAbstractSocket::bytesWritten, q,
+                                 &QWebSocket::bytesWritten);
+                setSocketState(QAbstractSocket::ConnectingState);
+    #ifndef QT_NO_NETWORKPROXY
+                m_pSocket->setProxy(m_configuration.m_proxy);
+    #endif
+                m_pSocket->connectToHost(url.host(), url.port(80));
+            } else {
+                const QString message = QWebSocket::tr("Out of memory.");
+                setErrorString(message);
+                Q_EMIT q->error(QAbstractSocket::SocketResourceError);
+            }
+        } else {
+            const QString message =
+                    QWebSocket::tr("Unsupported websockets scheme: %1").arg(url.scheme());
             setErrorString(message);
-            emit q->error(QAbstractSocket::UnsupportedSocketOperationError);
+            Q_EMIT q->error(QAbstractSocket::UnsupportedSocketOperationError);
         }
     }
 }
@@ -451,20 +451,24 @@ void QWebSocketPrivate::open(const QUrl &url, bool mask)
  */
 void QWebSocketPrivate::ping(const QByteArray &payload)
 {
-    Q_ASSERT(payload.length() < 126);
+    QByteArray payloadTruncated = payload.left(125);
     m_pingTimer.restart();
-    QByteArray pingFrame = getFrameHeader(QWebSocketProtocol::OC_PING, payload.size(), 0 /*do not mask*/, true);
-    pingFrame.append(payload);
-    writeFrame(pingFrame);
+    QByteArray pingFrame = getFrameHeader(QWebSocketProtocol::OpCodePing, payloadTruncated.size(),
+                                          0 /*do not mask*/, true);
+    pingFrame.append(payloadTruncated);
+    qint64 ret = writeFrame(pingFrame);
+    Q_UNUSED(ret);
 }
 
 /*!
   \internal
-    Sets the version to use for the websocket protocol; this must be set before the socket is opened.
+    Sets the version to use for the websocket protocol;
+    this must be set before the socket is opened.
 */
 void QWebSocketPrivate::setVersion(QWebSocketProtocol::Version version)
 {
-    m_version = version;
+    if (m_version != version)
+        m_version = version;
 }
 
 /*!
@@ -473,7 +477,8 @@ void QWebSocketPrivate::setVersion(QWebSocketProtocol::Version version)
 */
 void QWebSocketPrivate::setResourceName(const QString &resourceName)
 {
-    m_resourceName = resourceName;
+    if (m_resourceName != resourceName)
+        m_resourceName = resourceName;
 }
 
 /*!
@@ -481,7 +486,8 @@ void QWebSocketPrivate::setResourceName(const QString &resourceName)
  */
 void QWebSocketPrivate::setRequestUrl(const QUrl &requestUrl)
 {
-    m_requestUrl = requestUrl;
+    if (m_requestUrl != requestUrl)
+        m_requestUrl = requestUrl;
 }
 
 /*!
@@ -489,7 +495,8 @@ void QWebSocketPrivate::setRequestUrl(const QUrl &requestUrl)
  */
 void QWebSocketPrivate::setOrigin(const QString &origin)
 {
-    m_origin = origin;
+    if (m_origin != origin)
+        m_origin = origin;
 }
 
 /*!
@@ -497,7 +504,8 @@ void QWebSocketPrivate::setOrigin(const QString &origin)
  */
 void QWebSocketPrivate::setProtocol(const QString &protocol)
 {
-    m_protocol = protocol;
+    if (m_protocol != protocol)
+        m_protocol = protocol;
 }
 
 /*!
@@ -505,7 +513,8 @@ void QWebSocketPrivate::setProtocol(const QString &protocol)
  */
 void QWebSocketPrivate::setExtension(const QString &extension)
 {
-    m_extension = extension;
+    if (m_extension != extension)
+        m_extension = extension;
 }
 
 /*!
@@ -513,15 +522,8 @@ void QWebSocketPrivate::setExtension(const QString &extension)
  */
 void QWebSocketPrivate::enableMasking(bool enable)
 {
-    m_mustMask = enable;
-}
-
-/*!
- * \internal
- */
-qint64 QWebSocketPrivate::doWriteData(const QByteArray &data, bool isBinary)
-{
-    return doWriteFrames(data, isBinary);
+    if (m_mustMask != enable)
+        m_mustMask = enable;
 }
 
 /*!
@@ -532,26 +534,44 @@ void QWebSocketPrivate::makeConnections(const QTcpSocket *pTcpSocket)
     Q_ASSERT(pTcpSocket);
     Q_Q(QWebSocket);
 
-    //pass through signals
-    connect(pTcpSocket, SIGNAL(error(QAbstractSocket::SocketError)), q, SIGNAL(error(QAbstractSocket::SocketError)));
-    connect(pTcpSocket, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy &, QAuthenticator *)), q, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy &, QAuthenticator *)));
-    connect(pTcpSocket, SIGNAL(readChannelFinished()), q, SIGNAL(readChannelFinished()));
-    connect(pTcpSocket, SIGNAL(aboutToClose()), q, SIGNAL(aboutToClose()));
-    //connect(pTcpSocket, SIGNAL(bytesWritten(qint64)), q, SIGNAL(bytesWritten(qint64)));
-
-    //catch signals
-    connect(pTcpSocket, SIGNAL(stateChanged(QAbstractSocket::SocketState)), this, SLOT(processStateChanged(QAbstractSocket::SocketState)));
-    //!!!important to use a QueuedConnection here; with QTcpSocket there is no problem, but with QSslSocket the processing hangs
-    connect(pTcpSocket, SIGNAL(readyRead()), this, SLOT(processData()), Qt::QueuedConnection);
+    if (Q_LIKELY(pTcpSocket)) {
+        //pass through signals
+        typedef void (QAbstractSocket:: *ASErrorSignal)(QAbstractSocket::SocketError);
+        typedef void (QWebSocket:: *WSErrorSignal)(QAbstractSocket::SocketError);
+        QObject::connect(pTcpSocket,
+                         static_cast<ASErrorSignal>(&QAbstractSocket::error),
+                         q, static_cast<WSErrorSignal>(&QWebSocket::error));
+        QObject::connect(pTcpSocket, &QAbstractSocket::proxyAuthenticationRequired, q,
+                         &QWebSocket::proxyAuthenticationRequired);
+        QObject::connect(pTcpSocket, &QAbstractSocket::readChannelFinished, q,
+                         &QWebSocket::readChannelFinished);
+        QObject::connect(pTcpSocket, &QAbstractSocket::aboutToClose, q, &QWebSocket::aboutToClose);
+
+        //catch signals
+        QObjectPrivate::connect(pTcpSocket, &QAbstractSocket::stateChanged, this,
+                                &QWebSocketPrivate::processStateChanged);
+        //!!!important to use a QueuedConnection here;
+        //with QTcpSocket there is no problem, but with QSslSocket the processing hangs
+        QObjectPrivate::connect(pTcpSocket, &QAbstractSocket::readyRead, this,
+                                &QWebSocketPrivate::processData, Qt::QueuedConnection);
+    }
 
-    connect(&m_dataProcessor, SIGNAL(textFrameReceived(QString,bool)), q, SIGNAL(textFrameReceived(QString,bool)));
-    connect(&m_dataProcessor, SIGNAL(binaryFrameReceived(QByteArray,bool)), q, SIGNAL(binaryFrameReceived(QByteArray,bool)));
-    connect(&m_dataProcessor, SIGNAL(binaryMessageReceived(QByteArray)), q, SIGNAL(binaryMessageReceived(QByteArray)));
-    connect(&m_dataProcessor, SIGNAL(textMessageReceived(QString)), q, SIGNAL(textMessageReceived(QString)));
-    connect(&m_dataProcessor, SIGNAL(errorEncountered(QWebSocketProtocol::CloseCode,QString)), this, SLOT(close(QWebSocketProtocol::CloseCode,QString)));
-    connect(&m_dataProcessor, SIGNAL(pingReceived(QByteArray)), this, SLOT(processPing(QByteArray)));
-    connect(&m_dataProcessor, SIGNAL(pongReceived(QByteArray)), this, SLOT(processPong(QByteArray)));
-    connect(&m_dataProcessor, SIGNAL(closeReceived(QWebSocketProtocol::CloseCode,QString)), this, SLOT(processClose(QWebSocketProtocol::CloseCode,QString)));
+    QObject::connect(&m_dataProcessor, &QWebSocketDataProcessor::textFrameReceived, q,
+                     &QWebSocket::textFrameReceived);
+    QObject::connect(&m_dataProcessor, &QWebSocketDataProcessor::binaryFrameReceived, q,
+                     &QWebSocket::binaryFrameReceived);
+    QObject::connect(&m_dataProcessor, &QWebSocketDataProcessor::binaryMessageReceived, q,
+                     &QWebSocket::binaryMessageReceived);
+    QObject::connect(&m_dataProcessor, &QWebSocketDataProcessor::textMessageReceived, q,
+                     &QWebSocket::textMessageReceived);
+    QObjectPrivate::connect(&m_dataProcessor, &QWebSocketDataProcessor::errorEncountered, this,
+                            &QWebSocketPrivate::close);
+    QObjectPrivate::connect(&m_dataProcessor, &QWebSocketDataProcessor::pingReceived, this,
+                            &QWebSocketPrivate::processPing);
+    QObjectPrivate::connect(&m_dataProcessor, &QWebSocketDataProcessor::pongReceived, this,
+                            &QWebSocketPrivate::processPong);
+    QObjectPrivate::connect(&m_dataProcessor, &QWebSocketDataProcessor::closeReceived, this,
+                            &QWebSocketPrivate::processClose);
 }
 
 /*!
@@ -559,28 +579,9 @@ void QWebSocketPrivate::makeConnections(const QTcpSocket *pTcpSocket)
  */
 void QWebSocketPrivate::releaseConnections(const QTcpSocket *pTcpSocket)
 {
-    Q_Q(QWebSocket);
-    if (pTcpSocket)
-    {
-        //pass through signals
-        disconnect(pTcpSocket, SIGNAL(error(QAbstractSocket::SocketError)), q, SIGNAL(error(QAbstractSocket::SocketError)));
-        disconnect(pTcpSocket, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy &, QAuthenticator *)), q, SIGNAL(proxyAuthenticationRequired(const QNetworkProxy &, QAuthenticator *)));
-        disconnect(pTcpSocket, SIGNAL(readChannelFinished()), q, SIGNAL(readChannelFinished()));
-        disconnect(pTcpSocket, SIGNAL(aboutToClose()), q, SIGNAL(aboutToClose()));
-        //disconnect(pTcpSocket, SIGNAL(bytesWritten(qint64)), q, SIGNAL(bytesWritten(qint64)));
-
-        //catched signals
-        disconnect(pTcpSocket, SIGNAL(stateChanged(QAbstractSocket::SocketState)), this, SLOT(processStateChanged(QAbstractSocket::SocketState)));
-        disconnect(pTcpSocket, SIGNAL(readyRead()), this, SLOT(processData()));
-    }
-    disconnect(&m_dataProcessor, SIGNAL(pingReceived(QByteArray)), this, SLOT(processPing(QByteArray)));
-    disconnect(&m_dataProcessor, SIGNAL(pongReceived(QByteArray)), this, SLOT(processPong(QByteArray)));
-    disconnect(&m_dataProcessor, SIGNAL(closeReceived(QWebSocketProtocol::CloseCode,QString)), this, SLOT(processClose(QWebSocketProtocol::CloseCode,QString)));
-    disconnect(&m_dataProcessor, SIGNAL(textFrameReceived(QString,bool)), q, SIGNAL(textFrameReceived(QString,bool)));
-    disconnect(&m_dataProcessor, SIGNAL(binaryFrameReceived(QByteArray,bool)), q, SIGNAL(binaryFrameReceived(QByteArray,bool)));
-    disconnect(&m_dataProcessor, SIGNAL(binaryMessageReceived(QByteArray)), q, SIGNAL(binaryMessageReceived(QByteArray)));
-    disconnect(&m_dataProcessor, SIGNAL(textMessageReceived(QString)), q, SIGNAL(textMessageReceived(QString)));
-    disconnect(&m_dataProcessor, SIGNAL(errorEncountered(QWebSocketProtocol::CloseCode,QString)), this, SLOT(close(QWebSocketProtocol::CloseCode,QString)));
+    if (Q_LIKELY(pTcpSocket))
+        pTcpSocket->disconnect(pTcpSocket);
+    m_dataProcessor.disconnect();
 }
 
 /*!
@@ -650,58 +651,45 @@ QString QWebSocketPrivate::closeReason() const
 /*!
  * \internal
  */
-QByteArray QWebSocketPrivate::getFrameHeader(QWebSocketProtocol::OpCode opCode, quint64 payloadLength, quint32 maskingKey, bool lastFrame) const
+QByteArray QWebSocketPrivate::getFrameHeader(QWebSocketProtocol::OpCode opCode,
+                                             quint64 payloadLength, quint32 maskingKey,
+                                             bool lastFrame)
 {
     QByteArray header;
     quint8 byte = 0x00;
     bool ok = payloadLength <= 0x7FFFFFFFFFFFFFFFULL;
 
-    if (ok)
-    {
-        //FIN, RSV1-3, opcode
-        byte = static_cast<quint8>((opCode & 0x0F) | (lastFrame ? 0x80 : 0x00));       //FIN, opcode
-        //RSV-1, RSV-2 and RSV-3 are zero
+    if (Q_LIKELY(ok)) {
+        //FIN, RSV1-3, opcode (RSV-1, RSV-2 and RSV-3 are zero)
+        byte = static_cast<quint8>((opCode & 0x0F) | (lastFrame ? 0x80 : 0x00));
         header.append(static_cast<char>(byte));
 
-        //Now write the masking bit and the payload length byte
         byte = 0x00;
         if (maskingKey != 0)
-        {
             byte |= 0x80;
-        }
-        if (payloadLength <= 125)
-        {
+        if (payloadLength <= 125) {
             byte |= static_cast<quint8>(payloadLength);
             header.append(static_cast<char>(byte));
-        }
-        else if (payloadLength <= 0xFFFFU)
-        {
+        } else if (payloadLength <= 0xFFFFU) {
             byte |= 126;
             header.append(static_cast<char>(byte));
             quint16 swapped = qToBigEndian<quint16>(static_cast<quint16>(payloadLength));
             header.append(static_cast<const char *>(static_cast<const void *>(&swapped)), 2);
-        }
-        else if (payloadLength <= 0x7FFFFFFFFFFFFFFFULL)
-        {
+        } else if (payloadLength <= 0x7FFFFFFFFFFFFFFFULL) {
             byte |= 127;
             header.append(static_cast<char>(byte));
             quint64 swapped = qToBigEndian<quint64>(payloadLength);
             header.append(static_cast<const char *>(static_cast<const void *>(&swapped)), 8);
         }
 
-        //Write mask
-        if (maskingKey != 0)
-        {
-            //TODO: to big endian?
+        if (maskingKey != 0) {
             const quint32 mask = qToBigEndian<quint32>(maskingKey);
-            header.append(static_cast<const char *>(static_cast<const void *>(&mask)), sizeof(quint32));
+            header.append(static_cast<const char *>(static_cast<const void *>(&mask)),
+                          sizeof(quint32));
         }
-    }
-    else
-    {
-        //setErrorString("WebSocket::getHeader: payload too big!");
-        //Q_EMIT q_ptr->error(QAbstractSocket::DatagramTooLargeError);
-        qDebug() << "WebSocket::getHeader: payload too big!";
+    } else {
+        setErrorString(QStringLiteral("WebSocket::getHeader: payload too big!"));
+        Q_EMIT q_ptr->error(QAbstractSocket::DatagramTooLargeError);
     }
 
     return header;
@@ -713,95 +701,78 @@ QByteArray QWebSocketPrivate::getFrameHeader(QWebSocketProtocol::OpCode opCode,
 qint64 QWebSocketPrivate::doWriteFrames(const QByteArray &data, bool isBinary)
 {
     qint64 payloadWritten = 0;
-    if (m_pSocket)
-    {
-        Q_Q(QWebSocket);
-        const QWebSocketProtocol::OpCode firstOpCode = isBinary ? QWebSocketProtocol::OC_BINARY : QWebSocketProtocol::OC_TEXT;
-
-        int numFrames = data.size() / FRAME_SIZE_IN_BYTES;
-        QByteArray tmpData(data);
-        tmpData.detach();
-        char *payload = tmpData.data();
-        quint64 sizeLeft = static_cast<quint64>(data.size()) % FRAME_SIZE_IN_BYTES;
-        if (sizeLeft)
-        {
-            ++numFrames;
-        }
-        if (numFrames == 0)     //catch the case where the payload is zero bytes; in that case, we still need to send a frame
-        {
-            numFrames = 1;
-        }
-        quint64 currentPosition = 0;
-        qint64 bytesWritten = 0;
-        quint64 bytesLeft = data.size();
+    if (Q_UNLIKELY(!m_pSocket) || (state() != QAbstractSocket::ConnectedState))
+        return payloadWritten;
 
-        for (int i = 0; i < numFrames; ++i)
-        {
-            quint32 maskingKey = 0;
-            if (m_mustMask)
-            {
-                maskingKey = generateMaskingKey();
-            }
+    Q_Q(QWebSocket);
+    const QWebSocketProtocol::OpCode firstOpCode = isBinary ?
+                QWebSocketProtocol::OpCodeBinary : QWebSocketProtocol::OpCodeText;
+
+    int numFrames = data.size() / FRAME_SIZE_IN_BYTES;
+    QByteArray tmpData(data);
+    tmpData.detach();
+    char *payload = tmpData.data();
+    quint64 sizeLeft = quint64(data.size()) % FRAME_SIZE_IN_BYTES;
+    if (Q_LIKELY(sizeLeft))
+        ++numFrames;
+
+    //catch the case where the payload is zero bytes;
+    //in this case, we still need to send a frame
+    if (Q_UNLIKELY(numFrames == 0))
+        numFrames = 1;
+    quint64 currentPosition = 0;
+    qint64 bytesWritten = 0;
+    quint64 bytesLeft = data.size();
+
+    for (int i = 0; i < numFrames; ++i) {
+        quint32 maskingKey = 0;
+        if (m_mustMask)
+            maskingKey = generateMaskingKey();
 
-            const bool isLastFrame = (i == (numFrames - 1));
-            const bool isFirstFrame = (i == 0);
+        const bool isLastFrame = (i == (numFrames - 1));
+        const bool isFirstFrame = (i == 0);
 
-            const quint64 size = qMin(bytesLeft, FRAME_SIZE_IN_BYTES);
-            const QWebSocketProtocol::OpCode opcode = isFirstFrame ? firstOpCode : QWebSocketProtocol::OC_CONTINUE;
+        const quint64 size = qMin(bytesLeft, FRAME_SIZE_IN_BYTES);
+        const QWebSocketProtocol::OpCode opcode = isFirstFrame ? firstOpCode
+                                                               : QWebSocketProtocol::OpCodeContinue;
 
-            //write header
-            bytesWritten += m_pSocket->write(getFrameHeader(opcode, size, maskingKey, isLastFrame));
+        //write header
+        bytesWritten += m_pSocket->write(getFrameHeader(opcode, size, maskingKey, isLastFrame));
 
-            //write payload
-            if (size > 0)
-            {
-                char *currentData = payload + currentPosition;
-                if (m_mustMask)
-                {
-                    QWebSocketProtocol::mask(currentData, size, maskingKey);
-                }
-                qint64 written = m_pSocket->write(currentData, static_cast<qint64>(size));
-                if (written > 0)
-                {
-                    bytesWritten += written;
-                    payloadWritten += written;
-                }
-                else
-                {
-                    setErrorString(tr("Error writing bytes to socket: %1.").arg(m_pSocket->errorString()));
-                    qDebug() << errorString();
-                    m_pSocket->flush();
-                    Q_EMIT q->error(QAbstractSocket::NetworkError);
-                    break;
-                }
+        //write payload
+        if (Q_LIKELY(size > 0)) {
+            char *currentData = payload + currentPosition;
+            if (m_mustMask)
+                QWebSocketProtocol::mask(currentData, size, maskingKey);
+            qint64 written = m_pSocket->write(currentData, static_cast<qint64>(size));
+            if (Q_LIKELY(written > 0)) {
+                bytesWritten += written;
+                payloadWritten += written;
+            } else {
+                m_pSocket->flush();
+                setErrorString(QWebSocket::tr("Error writing bytes to socket: %1.")
+                               .arg(m_pSocket->errorString()));
+                Q_EMIT q->error(QAbstractSocket::NetworkError);
+                break;
             }
-            currentPosition += size;
-            bytesLeft -= size;
-        }
-        if (payloadWritten != data.size())
-        {
-            setErrorString(tr("Bytes written %1 != %2.").arg(payloadWritten).arg(data.size()));
-            qDebug() << errorString();
-            Q_EMIT q->error(QAbstractSocket::NetworkError);
         }
+        currentPosition += size;
+        bytesLeft -= size;
+    }
+    if (Q_UNLIKELY(payloadWritten != data.size())) {
+        setErrorString(QWebSocket::tr("Bytes written %1 != %2.")
+                       .arg(payloadWritten).arg(data.size()));
+        Q_EMIT q->error(QAbstractSocket::NetworkError);
     }
     return payloadWritten;
 }
 
 /*!
- * \internal
- */
-quint32 QWebSocketPrivate::generateRandomNumber() const
-{
-    return static_cast<quint32>((static_cast<double>(qrand()) / RAND_MAX) * std::numeric_limits<quint32>::max());
-}
-
-/*!
     \internal
  */
 quint32 QWebSocketPrivate::generateMaskingKey() const
 {
-    return generateRandomNumber();
+    return m_pMaskGenerator->nextMask();
 }
 
 /*!
@@ -811,9 +782,8 @@ QByteArray QWebSocketPrivate::generateKey() const
 {
     QByteArray key;
 
-    for (int i = 0; i < 4; ++i)
-    {
-        quint32 tmp = generateRandomNumber();
+    for (int i = 0; i < 4; ++i) {
+        const quint32 tmp = m_pMaskGenerator->nextMask();
         key.append(static_cast<const char *>(static_cast<const void *>(&tmp)), sizeof(quint32));
     }
 
@@ -824,11 +794,11 @@ QByteArray QWebSocketPrivate::generateKey() const
 /*!
     \internal
  */
-QString QWebSocketPrivate::calculateAcceptKey(const QString &key) const
+QString QWebSocketPrivate::calculateAcceptKey(const QByteArray &key) const
 {
-    const QString tmpKey = key % QStringLiteral("258EAFA5-E914-47DA-95CA-C5AB0DC85B11");
-    const QByteArray hash = QCryptographicHash::hash(tmpKey.toLatin1(), QCryptographicHash::Sha1);
-    return QString::fromLatin1(hash.toBase64());
+    const QByteArray tmpKey = key + QByteArrayLiteral("258EAFA5-E914-47DA-95CA-C5AB0DC85B11");
+    const QByteArray hash = QCryptographicHash::hash(tmpKey, QCryptographicHash::Sha1).toBase64();
+    return QString::fromLatin1(hash);
 }
 
 /*!
@@ -837,12 +807,10 @@ QString QWebSocketPrivate::calculateAcceptKey(const QString &key) const
 qint64 QWebSocketPrivate::writeFrames(const QList<QByteArray> &frames)
 {
     qint64 written = 0;
-    if (m_pSocket)
-    {
-        for (int i = 0; i < frames.size(); ++i)
-        {
-            written += writeFrame(frames[i]);
-        }
+    if (Q_LIKELY(m_pSocket)) {
+        QList<QByteArray>::const_iterator it;
+        for (it = frames.cbegin(); it < frames.cend(); ++it)
+            written += writeFrame(*it);
     }
     return written;
 }
@@ -853,10 +821,8 @@ qint64 QWebSocketPrivate::writeFrames(const QList<QByteArray> &frames)
 qint64 QWebSocketPrivate::writeFrame(const QByteArray &frame)
 {
     qint64 written = 0;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         written = m_pSocket->write(frame);
-    }
     return written;
 }
 
@@ -867,20 +833,13 @@ QString readLine(QTcpSocket *pSocket)
 {
     Q_ASSERT(pSocket);
     QString line;
-    if (pSocket)
-    {
-        char c;
-        while (pSocket->getChar(&c))
-        {
-            if (c == '\r')
-            {
-                pSocket->getChar(&c);
-                break;
-            }
-            else
-            {
-                line.append(QChar::fromLatin1(c));
-            }
+    char c;
+    while (pSocket->getChar(&c)) {
+        if (c == char('\r')) {
+            pSocket->getChar(&c);
+            break;
+        } else {
+            line.append(QChar::fromLatin1(c));
         }
     }
     return line;
@@ -893,10 +852,8 @@ QString readLine(QTcpSocket *pSocket)
 void QWebSocketPrivate::processHandshake(QTcpSocket *pSocket)
 {
     Q_Q(QWebSocket);
-    if (!pSocket)
-    {
+    if (Q_UNLIKELY(!pSocket))
         return;
-    }
 
     bool ok = false;
     QString errorDescription;
@@ -908,43 +865,44 @@ void QWebSocketPrivate::processHandshake(QTcpSocket *pSocket)
     int httpStatusCode;
     QString httpStatusMessage;
     const QRegularExpressionMatch match = regExp.match(statusLine);
-    if (match.hasMatch())
-    {
+    if (Q_LIKELY(match.hasMatch())) {
         QStringList tokens = match.capturedTexts();
         tokens.removeFirst();  //remove the search string
-        if (tokens.length() == 3)
-        {
+        if (tokens.length() == 3) {
             httpProtocol = tokens[0];
             httpStatusCode = tokens[1].toInt();
             httpStatusMessage = tokens[2].trimmed();
             ok = true;
         }
     }
-    if (!ok)
-    {
-        errorDescription = tr("Invalid statusline in response: %1.").arg(statusLine);
-    }
-    else
-    {
+    if (Q_UNLIKELY(!ok)) {
+        errorDescription = QWebSocket::tr("Invalid statusline in response: %1.").arg(statusLine);
+    } else {
         QString headerLine = readLine(pSocket);
         QMap<QString, QString> headers;
-        while (!headerLine.isEmpty())
-        {
-            const QStringList headerField = headerLine.split(QStringLiteral(": "), QString::SkipEmptyParts);
-            headers.insertMulti(headerField[0], headerField[1]);
+        while (!headerLine.isEmpty()) {
+            const QStringList headerField = headerLine.split(QStringLiteral(": "),
+                                                             QString::SkipEmptyParts);
+            if (headerField.size() == 2) {
+                headers.insertMulti(headerField[0], headerField[1]);
+            }
             headerLine = readLine(pSocket);
         }
 
-        const QString acceptKey = headers.value(QStringLiteral("Sec-WebSocket-Accept"), QStringLiteral(""));
-        const QString upgrade = headers.value(QStringLiteral("Upgrade"), QStringLiteral(""));
-        const QString connection = headers.value(QStringLiteral("Connection"), QStringLiteral(""));
-        //unused for the moment
-        //const QString extensions = headers.value(QStringLiteral("Sec-WebSocket-Extensions"), QStringLiteral(""));
-        //const QString protocol = headers.value(QStringLiteral("Sec-WebSocket-Protocol"), QStringLiteral(""));
-        const QString version = headers.value(QStringLiteral("Sec-WebSocket-Version"), QStringLiteral(""));
-
-        if (httpStatusCode == 101)     //HTTP/x.y 101 Switching Protocols
-        {
+        const QString acceptKey = headers.value(QStringLiteral("Sec-WebSocket-Accept"),
+                                                QString());
+        const QString upgrade = headers.value(QStringLiteral("Upgrade"), QString());
+        const QString connection = headers.value(QStringLiteral("Connection"), QString());
+//        unused for the moment
+//        const QString extensions = headers.value(QStringLiteral("Sec-WebSocket-Extensions"),
+//                                                 QString());
+//        const QString protocol = headers.value(QStringLiteral("Sec-WebSocket-Protocol"),
+//                                               QString());
+        const QString version = headers.value(QStringLiteral("Sec-WebSocket-Version"),
+                                              QString());
+
+        if (Q_LIKELY(httpStatusCode == 101)) {
+            //HTTP/x.y 101 Switching Protocols
             bool conversionOk = false;
             const float version = httpProtocol.midRef(5).toFloat(&conversionOk);
             //TODO: do not check the httpStatusText right now
@@ -952,54 +910,48 @@ void QWebSocketPrivate::processHandshake(QTcpSocket *pSocket)
                    (!conversionOk || (version < 1.1f)) ||
                    (upgrade.toLower() != QStringLiteral("websocket")) ||
                    (connection.toLower() != QStringLiteral("upgrade")));
-            if (ok)
-            {
-                const QString accept = calculateAcceptKey(QString::fromLatin1(m_key));
+            if (ok) {
+                const QString accept = calculateAcceptKey(m_key);
                 ok = (accept == acceptKey);
                 if (!ok)
-                {
-                    errorDescription = tr("Accept-Key received from server %1 does not match the client key %2.").arg(acceptKey).arg(accept);
-                }
-            }
-            else
-            {
-                errorDescription = tr("QWebSocketPrivate::processHandshake: Invalid statusline in response: %1.").arg(statusLine);
+                    errorDescription =
+                      QWebSocket::tr("Accept-Key received from server %1 does not match the client key %2.")
+                            .arg(acceptKey).arg(accept);
+            } else {
+                errorDescription =
+                    QWebSocket::tr("QWebSocketPrivate::processHandshake: Invalid statusline in response: %1.")
+                        .arg(statusLine);
             }
-        }
-        else if (httpStatusCode == 400)        //HTTP/1.1 400 Bad Request
-        {
-            if (!version.isEmpty())
-            {
-                const QStringList versions = version.split(QStringLiteral(", "), QString::SkipEmptyParts);
-                if (!versions.contains(QString::number(QWebSocketProtocol::currentVersion())))
-                {
+        } else if (httpStatusCode == 400) {
+            //HTTP/1.1 400 Bad Request
+            if (!version.isEmpty()) {
+                const QStringList versions = version.split(QStringLiteral(", "),
+                                                           QString::SkipEmptyParts);
+                if (!versions.contains(QString::number(QWebSocketProtocol::currentVersion()))) {
                     //if needed to switch protocol version, then we are finished here
                     //because we cannot handle other protocols than the RFC one (v13)
-                    errorDescription = tr("Handshake: Server requests a version that we don't support: %1.").arg(versions.join(QStringLiteral(", ")));
+                    errorDescription =
+                            QWebSocket::tr("Handshake: Server requests a version that we don't support: %1.")
+                            .arg(versions.join(QStringLiteral(", ")));
                     ok = false;
-                }
-                else
-                {
+                } else {
                     //we tried v13, but something different went wrong
-                    errorDescription = tr("QWebSocketPrivate::processHandshake: Unknown error condition encountered. Aborting connection.");
+                    errorDescription =
+                        QWebSocket::tr("QWebSocketPrivate::processHandshake: Unknown error condition encountered. Aborting connection.");
                     ok = false;
                 }
             }
-        }
-        else
-        {
-            errorDescription = tr("QWebSocketPrivate::processHandshake: Unhandled http status code: %1 (%2).").arg(httpStatusCode).arg(httpStatusMessage);
+        } else {
+            errorDescription =
+                    QWebSocket::tr("QWebSocketPrivate::processHandshake: Unhandled http status code: %1 (%2).")
+                        .arg(httpStatusCode).arg(httpStatusMessage);
             ok = false;
         }
 
-        if (!ok)
-        {
-            qDebug() << errorDescription;
+        if (!ok) {
             setErrorString(errorDescription);
             Q_EMIT q->error(QAbstractSocket::ConnectionRefusedError);
-        }
-        else
-        {
+        } else {
             //handshake succeeded
             setSocketState(QAbstractSocket::ConnectedState);
             Q_EMIT q->connected();
@@ -1015,105 +967,88 @@ void QWebSocketPrivate::processStateChanged(QAbstractSocket::SocketState socketS
     Q_ASSERT(m_pSocket);
     Q_Q(QWebSocket);
     QAbstractSocket::SocketState webSocketState = this->state();
-    switch (socketState)
-    {
+    switch (socketState) {
     case QAbstractSocket::ConnectedState:
-    {
-        if (webSocketState == QAbstractSocket::ConnectingState)
-        {
+        if (webSocketState == QAbstractSocket::ConnectingState) {
             m_key = generateKey();
-            QString handshake = createHandShakeRequest(m_resourceName, m_requestUrl.host() % QStringLiteral(":") % QString::number(m_requestUrl.port(80)), origin(), QStringLiteral(""), QStringLiteral(""), m_key);
+            const QString handshake =
+                    createHandShakeRequest(m_resourceName,
+                                           m_requestUrl.host()
+                                                % QStringLiteral(":")
+                                                % QString::number(m_requestUrl.port(80)),
+                                           origin(),
+                                           QString(),
+                                           QString(),
+                                           m_key);
+            if (handshake.isEmpty()) {
+                m_pSocket->abort();
+                Q_EMIT q->error(QAbstractSocket::ConnectionRefusedError);
+                return;
+            }
             m_pSocket->write(handshake.toLatin1());
         }
         break;
-    }
+
     case QAbstractSocket::ClosingState:
-    {
         if (webSocketState == QAbstractSocket::ConnectedState)
-        {
             setSocketState(QAbstractSocket::ClosingState);
-        }
         break;
-    }
+
     case QAbstractSocket::UnconnectedState:
-    {
-        if (webSocketState != QAbstractSocket::UnconnectedState)
-        {
+        if (webSocketState != QAbstractSocket::UnconnectedState) {
             setSocketState(QAbstractSocket::UnconnectedState);
             Q_EMIT q->disconnected();
         }
         break;
-    }
+
     case QAbstractSocket::HostLookupState:
     case QAbstractSocket::ConnectingState:
     case QAbstractSocket::BoundState:
     case QAbstractSocket::ListeningState:
-    {
         //do nothing
         //to make C++ compiler happy;
         break;
-    }
     default:
-    {
         break;
     }
-    }
 }
 
-//order of events:
-//connectToHost is called
-//our socket state is set to "connecting", and tcpSocket->connectToHost is called
-//the tcpsocket is opened, a handshake message is sent; a readyRead signal is thrown
-//this signal is catched by processData
-//when OUR socket state is in the "connecting state", this means that
-//we have received data from the server (response to handshake), and that we
-//should "upgrade" our socket to a websocket (connected state)
-//if our socket was already upgraded, then we need to process websocket data
 /*!
  \internal
  */
 void QWebSocketPrivate::processData()
 {
     Q_ASSERT(m_pSocket);
-    while (m_pSocket->bytesAvailable())
-    {
+    while (m_pSocket->bytesAvailable()) {
         if (state() == QAbstractSocket::ConnectingState)
-        {
             processHandshake(m_pSocket.data());
-        }
         else
-        {
             m_dataProcessor.process(m_pSocket.data());
-        }
     }
 }
 
 /*!
  \internal
  */
-void QWebSocketPrivate::processPing(QByteArray data)
+void QWebSocketPrivate::processPing(const QByteArray &data)
 {
     Q_ASSERT(m_pSocket);
     quint32 maskingKey = 0;
     if (m_mustMask)
-    {
         maskingKey = generateMaskingKey();
-    }
-    m_pSocket->write(getFrameHeader(QWebSocketProtocol::OC_PONG, data.size(), maskingKey, true));
-    if (data.size() > 0)
-    {
+    m_pSocket->write(getFrameHeader(QWebSocketProtocol::OpCodePong, data.size(), maskingKey, true));
+    if (data.size() > 0) {
+        QByteArray maskedData = data;
         if (m_mustMask)
-        {
-            QWebSocketProtocol::mask(&data, maskingKey);
-        }
-        m_pSocket->write(data);
+            QWebSocketProtocol::mask(&maskedData, maskingKey);
+        m_pSocket->write(maskedData);
     }
 }
 
 /*!
  \internal
  */
-void QWebSocketPrivate::processPong(QByteArray data)
+void QWebSocketPrivate::processPong(const QByteArray &data)
 {
     Q_Q(QWebSocket);
     Q_EMIT q->pong(static_cast<quint64>(m_pingTimer.elapsed()), data);
@@ -1139,6 +1074,31 @@ QString QWebSocketPrivate::createHandShakeRequest(QString resourceName,
                                                   QByteArray key)
 {
     QStringList handshakeRequest;
+    if (resourceName.contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("The resource name contains newlines. " \
+                                      "Possible attack detected."));
+        return QString();
+    }
+    if (host.contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("The hostname contains newlines. " \
+                                      "Possible attack detected."));
+        return QString();
+    }
+    if (origin.contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("The origin contains newlines. " \
+                                      "Possible attack detected."));
+        return QString();
+    }
+    if (extensions.contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("The extensions attribute contains newlines. " \
+                                      "Possible attack detected."));
+        return QString();
+    }
+    if (protocols.contains(QStringLiteral("\r\n"))) {
+        setErrorString(QWebSocket::tr("The protocols attribute contains newlines. " \
+                                      "Possible attack detected."));
+        return QString();
+    }
 
     handshakeRequest << QStringLiteral("GET ") % resourceName % QStringLiteral(" HTTP/1.1") <<
                         QStringLiteral("Host: ") % host <<
@@ -1146,18 +1106,13 @@ QString QWebSocketPrivate::createHandShakeRequest(QString resourceName,
                         QStringLiteral("Connection: Upgrade") <<
                         QStringLiteral("Sec-WebSocket-Key: ") % QString::fromLatin1(key);
     if (!origin.isEmpty())
-    {
         handshakeRequest << QStringLiteral("Origin: ") % origin;
-    }
-    handshakeRequest << QStringLiteral("Sec-WebSocket-Version: ") % QString::number(QWebSocketProtocol::currentVersion());
+    handshakeRequest << QStringLiteral("Sec-WebSocket-Version: ")
+                            % QString::number(QWebSocketProtocol::currentVersion());
     if (extensions.length() > 0)
-    {
         handshakeRequest << QStringLiteral("Sec-WebSocket-Extensions: ") % extensions;
-    }
     if (protocols.length() > 0)
-    {
         handshakeRequest << QStringLiteral("Sec-WebSocket-Protocol: ") % protocols;
-    }
     handshakeRequest << QStringLiteral("\r\n");
 
     return handshakeRequest.join(QStringLiteral("\r\n"));
@@ -1174,37 +1129,10 @@ QAbstractSocket::SocketState QWebSocketPrivate::state() const
 /*!
     \internal
  */
-bool QWebSocketPrivate::waitForConnected(int msecs)
-{
-    bool result = false;
-    if (m_pSocket)
-    {
-        result = m_pSocket->waitForConnected(msecs);
-    }
-    return result;
-}
-
-/*!
-    \internal
- */
-bool QWebSocketPrivate::waitForDisconnected(int msecs)
-{
-    bool result = false;
-    if (m_pSocket)
-    {
-        result = m_pSocket->waitForDisconnected(msecs);
-    }
-    return result;
-}
-
-/*!
-    \internal
- */
 void QWebSocketPrivate::setSocketState(QAbstractSocket::SocketState state)
 {
     Q_Q(QWebSocket);
-    if (m_socketState != state)
-    {
+    if (m_socketState != state) {
         m_socketState = state;
         Q_EMIT q->stateChanged(m_socketState);
     }
@@ -1215,7 +1143,8 @@ void QWebSocketPrivate::setSocketState(QAbstractSocket::SocketState state)
  */
 void QWebSocketPrivate::setErrorString(const QString &errorString)
 {
-    m_errorString = errorString;
+    if (m_errorString != errorString)
+        m_errorString = errorString;
 }
 
 /*!
@@ -1224,10 +1153,8 @@ void QWebSocketPrivate::setErrorString(const QString &errorString)
 QHostAddress QWebSocketPrivate::localAddress() const
 {
     QHostAddress address;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         address = m_pSocket->localAddress();
-    }
     return address;
 }
 
@@ -1237,10 +1164,8 @@ QHostAddress QWebSocketPrivate::localAddress() const
 quint16 QWebSocketPrivate::localPort() const
 {
     quint16 port = 0;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         port = m_pSocket->localPort();
-    }
     return port;
 }
 
@@ -1249,12 +1174,7 @@ quint16 QWebSocketPrivate::localPort() const
  */
 QAbstractSocket::PauseModes QWebSocketPrivate::pauseMode() const
 {
-    QAbstractSocket::PauseModes mode = QAbstractSocket::PauseNever;
-    if (m_pSocket)
-    {
-        mode = m_pSocket->pauseMode();
-    }
-    return mode;
+    return m_pauseMode;
 }
 
 /*!
@@ -1263,10 +1183,8 @@ QAbstractSocket::PauseModes QWebSocketPrivate::pauseMode() const
 QHostAddress QWebSocketPrivate::peerAddress() const
 {
     QHostAddress address;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         address = m_pSocket->peerAddress();
-    }
     return address;
 }
 
@@ -1276,10 +1194,8 @@ QHostAddress QWebSocketPrivate::peerAddress() const
 QString QWebSocketPrivate::peerName() const
 {
     QString name;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         name = m_pSocket->peerName();
-    }
     return name;
 }
 
@@ -1289,10 +1205,8 @@ QString QWebSocketPrivate::peerName() const
 quint16 QWebSocketPrivate::peerPort() const
 {
     quint16 port = 0;
-    if (m_pSocket)
-    {
+    if (Q_LIKELY(m_pSocket))
         port = m_pSocket->peerPort();
-    }
     return port;
 }
 
@@ -1310,78 +1224,66 @@ QNetworkProxy QWebSocketPrivate::proxy() const
  */
 void QWebSocketPrivate::setProxy(const QNetworkProxy &networkProxy)
 {
-    m_configuration.m_proxy = networkProxy;
+    if (networkProxy != networkProxy)
+        m_configuration.m_proxy = networkProxy;
 }
 #endif  //QT_NO_NETWORKPROXY
 
 /*!
     \internal
  */
-qint64 QWebSocketPrivate::readBufferSize() const
+void QWebSocketPrivate::setMaskGenerator(const QMaskGenerator *maskGenerator)
 {
-    qint64 size = 0;
-    if (m_pSocket)
-    {
-        size = m_pSocket->readBufferSize();
-    }
-    return size;
+    if (!maskGenerator)
+        m_pMaskGenerator = &m_defaultMaskGenerator;
+    else if (maskGenerator != m_pMaskGenerator)
+        m_pMaskGenerator = const_cast<QMaskGenerator *>(maskGenerator);
 }
 
 /*!
     \internal
  */
-void QWebSocketPrivate::resume()
+const QMaskGenerator *QWebSocketPrivate::maskGenerator() const
 {
-    if (m_pSocket)
-    {
-        m_pSocket->resume();
-    }
+    Q_ASSERT(m_pMaskGenerator);
+    return m_pMaskGenerator;
 }
 
 /*!
-  \internal
+    \internal
  */
-void QWebSocketPrivate::setPauseMode(QAbstractSocket::PauseModes pauseMode)
+qint64 QWebSocketPrivate::readBufferSize() const
 {
-    if (m_pSocket)
-    {
-        m_pSocket->setPauseMode(pauseMode);
-    }
+    return m_readBufferSize;
 }
 
 /*!
     \internal
  */
-void QWebSocketPrivate::setReadBufferSize(qint64 size)
+void QWebSocketPrivate::resume()
 {
-    if (m_pSocket)
-    {
-        m_pSocket->setReadBufferSize(size);
-    }
+    if (Q_LIKELY(m_pSocket))
+        m_pSocket->resume();
 }
 
 /*!
-    \internal
+  \internal
  */
-void QWebSocketPrivate::setSocketOption(QAbstractSocket::SocketOption option, const QVariant &value)
+void QWebSocketPrivate::setPauseMode(QAbstractSocket::PauseModes pauseMode)
 {
-    if (m_pSocket)
-    {
-        m_pSocket->setSocketOption(option, value);
-    }
+    m_pauseMode = pauseMode;
+    if (Q_LIKELY(m_pSocket))
+        m_pSocket->setPauseMode(m_pauseMode);
 }
 
 /*!
     \internal
  */
-QVariant QWebSocketPrivate::socketOption(QAbstractSocket::SocketOption option)
+void QWebSocketPrivate::setReadBufferSize(qint64 size)
 {
-    QVariant val;
-    if (m_pSocket)
-    {
-        val = m_pSocket->socketOption(option);
-    }
-    return val;
+    m_readBufferSize = size;
+    if (Q_LIKELY(m_pSocket))
+        m_pSocket->setReadBufferSize(m_readBufferSize);
 }
 
 /*!
@@ -1389,7 +1291,8 @@ QVariant QWebSocketPrivate::socketOption(QAbstractSocket::SocketOption option)
  */
 bool QWebSocketPrivate::isValid() const
 {
-    return (m_pSocket && m_pSocket->isValid());
+    return (m_pSocket && m_pSocket->isValid() &&
+            (m_socketState == QAbstractSocket::ConnectedState));
 }
 
 QT_END_NAMESPACE