Update To 11.40.268.0

[platform/framework/web/crosswalk.git] / src / tools / android / checkstyle / chromium-style-5.0.xml

diff --git a/src/tools/android/checkstyle/chromium-style-5.0.xml b/src/tools/android/checkstyle/chromium-style-5.0.xml
index dda0772..46b19e9 100644 (file)
--- a/src/tools/android/checkstyle/chromium-style-5.0.xml
+++ b/src/tools/android/checkstyle/chromium-style-5.0.xml
@@ -12,25 +12,27 @@
       <property name="severity" value="error"/>
     </module>
     <module name="IllegalCatch">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="info"/>
     </module>
     <module name="RedundantImport">
       <message key="import.redundant" value="Redundant import: {0}. Use :JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
-      <property name="severity" value="error"/>
+      <!-- This check is set to a warning because JNI generator sometimes requires to leave an unused import -->
+      <property name="severity" value="warning"/>
     </module>
     <module name="UnusedImports">
-      <property name="severity" value="error"/>
-      <property name="processJavadoc" value="true"/>
       <message key="import.unused" value="Unused import: {0}. Use :JavaImportOrganize (ECLIM) or Ctrl+Shift+O (Eclipse) to sort imports"/>
+      <!-- This check is set to a warning because JNI generator sometimes requires to leave an unused import -->
+      <property name="severity" value="warning"/>
+      <property name="processJavadoc" value="true"/>
     </module>
     <module name="JavadocType">
-      <property name="severity" value="error"/>
+      <property name="severity" value="warning"/>
       <property name="tokens" value="INTERFACE_DEF, CLASS_DEF"/>
       <property name="scope" value="public"/>
       <message key="javadoc.missing" value="Public classes and interfaces require JavaDoc comments."/>
     </module>
     <module name="JavadocMethod">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="info"/>
       <property name="scope" value="public"/>
       <property name="allowMissingParamTags" value="true"/>
       <property name="allowMissingPropertyJavadoc" value="true"/>
@@ -38,38 +40,54 @@
       <property name="allowMissingThrowsTags" value="true"/>
     </module>
     <module name="PackageName">
-      <property name="severity" value="warning"/>
-      <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
+      <property name="severity" value="error"/>
+      <property name="format" value="^[a-z]+(\.[a-z][a-z0-9_]{1,})*$"/>
+    </module>
+    <module name="SimplifyBooleanExpression">
+      <property name="severity" value="error"/>
+    </module>
+    <module name="SimplifyBooleanReturn">
+      <property name="severity" value="error"/>
     </module>
     <module name="TypeName">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
     </module>
     <module name="ConstantName">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
       <property name="format" value="^([A-Z][A-Z0-9]*(_[A-Z0-9]+)*)|(s[A-Z][a-zA-Z0-9]*)$"/>
       <message key="name.invalidPattern" value="Static final field names must either be all caps (e.g. int HEIGHT_PX) for 'true' constants, or start with s (e.g. AtomicInteger sNextId or Runnable sSuspendTask) for fields with mutable state or that don't 'feel' like constants."/>
     </module>
     <!-- Non-public, non-static field names start with m. -->
     <module name="MemberName">
+        <property name="severity" value="error"/>
         <property name="format" value="^m[A-Z][a-zA-Z0-9]*$"/>
         <property name="applyToPublic" value="false"/>
         <message key="name.invalidPattern" value="Non-public, non-static field names start with m."/>
     </module>
     <!-- Static field names start with s. -->
     <module name="StaticVariableName">
+        <property name="severity" value="error"/>
         <property name="format" value="^s[A-Z][a-zA-Z0-9]*$"/>
         <property name="applyToPublic" value="false"/>
         <message key="name.invalidPattern" value="Static field names start with s."/>
     </module>
-    <module name="MethodName" />
+    <module name="MethodName">
+        <property name="severity" value="error"/>
+        <property name="format" value="^[a-z][a-zA-Z0-9_]*$"/>
+        <message key="name.invalidPattern" value="Method names should start with a lower case letter (e.g. getWidth())"/>
+    </module>
     <module name="ParameterName">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
     </module>
     <module name="LocalFinalVariableName">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
+      <property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z0-9]*)$"/>
+      <message key="name.invalidPattern" value="Local variables should be camel-cased (e.g. int minWidth = 4)."/>
     </module>
     <module name="LocalVariableName">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
+      <property name="format" value="^m|s|((([ms][a-z0-9])|([a-ln-rt-z]))[a-zA-Z0-9]*)$"/>
+      <message key="name.invalidPattern" value="Local variables should be camel-cased (e.g. int minWidth = 4)."/>
     </module>
     <module name="LineLength">
       <property name="severity" value="error"/>
@@ -77,13 +95,13 @@
       <property name="max" value="100"/>
     </module>
     <module name="LeftCurly">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
     </module>
     <module name="RightCurly">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
     </module>
     <module name="NeedBraces">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="info"/>
       <property name="tokens" value="LITERAL_FOR, LITERAL_WHILE, LITERAL_DO"/>
     </module>
     <module name="EmptyBlock">
@@ -108,6 +126,7 @@
       <property name="allowEmptyMethods" value="true"/>
    </module>
     <module name="WhitespaceAfter">
+      <property name="severity" value="error"/>
       <property name="tokens" value="COMMA, SEMI, TYPECAST"/>
     </module>
     <module name="NoWhitespaceAfter">
@@ -119,11 +138,17 @@
       <property name="allowLineBreaks" value="true"/>
       <property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
     </module>
+    <module name="EmptyStatement">
+      <property name="severity" value="error"/>
+    </module>
     <module name="NoFinalizer">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="info"/>
     </module>
     <module name="ParenPad">
-      <property name="severity" value="warning"/>
+      <property name="severity" value="error"/>
+    </module>
+    <module name="MethodParamPad">
+      <property name="severity" value="error"/>
     </module>
     <module name="ImportOrder">
       <property name="severity" value="error"/>
@@ -134,17 +159,35 @@
       <property name="separated" value="true"/>
     </module>
     <module name="Indentation">
+      <property name="severity" value="error"/>
       <property name="basicOffset" value="4"/>
+      <property name="throwsIndent" value="8"/>
+      <property name="lineWrappingIndentation" value="8"/>
+    </module>
+    <!-- TODO(aurimas): make OperatorWrap into an error once all the warnings are fixed. -->
+    <module name="OperatorWrap">
+      <property name="severity" value="warning"/>
+      <property name="option" value="NL" />
+      <property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR " />
+    </module>
+    <module name="OperatorWrap">
+     <property name="severity" value="warning"/>
+     <property name="option" value="eol"/>
+     <property name="tokens" value="ASSIGN"/>
+    </module>
+    <module name="SeparatorWrap">
+      <property name="severity" value="warning"/>
+      <property name="tokens" value="DOT"/>
+      <property name="option" value="nl"/>
+    </module>
+    <module name="SeparatorWrap">
+      <property name="severity" value="warning"/>
+      <property name="tokens" value="COMMA"/>
+      <property name="option" value="EOL"/>
     </module>
   </module>
-  <module name="FileTabCharacter"/>
-  <module name="RegexpSingleline">
-    <property name="format" value="((//.*)|(\*.*))FIXME"/>
-    <property name="message" value="TODO is preferred to FIXME.  e.g. &quot;TODO(johndoe):"/>
-  </module>
-  <module name="RegexpSingleline">
-    <property name="format" value="((//.*)|(\*.*))(?&lt;!TODO\(.{0,100})(TODO[^(])|(TODO\([^)]*$)"/>
-    <property name="message" value="All TODOs should be named.  e.g. &quot;TODO(johndoe):"/>
+  <module name="FileTabCharacter">
+    <property name="severity" value="error"/>
   </module>
   <module name="RegexpSingleline">
     <property name="severity" value="error"/>