Merge "Fix derefrencing of NULL pointer" into tizen
[platform/upstream/connman.git] / src / timeserver.c
old mode 100644 (file)
new mode 100755 (executable)
index 8622431..ac99f76
@@ -2,7 +2,7 @@
  *
  *  Connection Manager
  *
- *  Copyright (C) 2007-2010  Intel Corporation. All rights reserved.
+ *  Copyright (C) 2007-2013  Intel Corporation. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
 #include <glib.h>
 #include <stdlib.h>
 #include <gweb/gresolv.h>
+#include <netdb.h>
 
 #include "connman.h"
 
-static char **system_timeservers = NULL;
-static char **timeservers = NULL;
+#define TS_RECHECK_INTERVAL     7200
+
+static struct connman_service *ts_service;
+static GSList *timeservers_list = NULL;
+static GSList *ts_list = NULL;
+static char *ts_current = NULL;
+static int ts_recheck_id = 0;
+static int ts_backoff_id = 0;
 
 static GResolv *resolv = NULL;
 static int resolv_id = 0;
-static volatile int count;
+
+static void sync_next(void);
 
 static void resolv_debug(const char *str, void *data)
 {
        connman_info("%s: %s\n", (const char *) data, str);
 }
+
+static void ntp_callback(bool success, void *user_data)
+{
+       DBG("success %d", success);
+
+       if (!success)
+               sync_next();
+}
+
 static void save_timeservers(char **servers)
 {
        GKeyFile *keyfile;
        int cnt;
 
        keyfile = __connman_storage_load_global();
-       if (keyfile == NULL)
+       if (!keyfile)
                keyfile = g_key_file_new();
 
-       for (cnt = 0; servers != NULL && servers[cnt] != NULL; cnt++);
+       for (cnt = 0; servers && servers[cnt]; cnt++);
 
        g_key_file_set_string_list(keyfile, "global", "Timeservers",
                           (const gchar **)servers, cnt);
@@ -59,186 +76,411 @@ static void save_timeservers(char **servers)
        __connman_storage_save_global(keyfile);
 
        g_key_file_free(keyfile);
-
-       return;
 }
 
-static char **load_timeservers()
+static char **load_timeservers(void)
 {
        GKeyFile *keyfile;
-       GError *error = NULL;
        char **servers = NULL;
 
        keyfile = __connman_storage_load_global();
-       if (keyfile == NULL)
+       if (!keyfile)
                return NULL;
 
        servers = g_key_file_get_string_list(keyfile, "global",
-                                               "Timeservers", NULL, &error);
-       if (error) {
-               DBG("Error loading timeservers: %s", error->message);
-               g_error_free(error);
-       }
+                                               "Timeservers", NULL, NULL);
 
        g_key_file_free(keyfile);
 
        return servers;
 }
 
-/* Restart NTP procedure */
-static void connman_timeserver_restart()
+static void resolv_result(GResolvResultStatus status, char **results,
+                               gpointer user_data)
 {
-       /* If service timeservers are in use, dont restart ntp */
-       if (timeservers != NULL)
-               return;
+       int i;
 
-       if (resolv == NULL) {
-               DBG("No online service.");
-               return;
-       }
+#if defined TIZEN_EXT
+       gchar *server = NULL;
 
-       /* Cancel current lookup */
-       if(resolv_id > 0)
-               g_resolv_cancel_lookup(resolv, resolv_id);
+       server = g_strdup((gchar *)user_data);
+       ts_list = g_slist_append(ts_list, server);
+
+       if (!simplified_log)
+               DBG("added server %s", server);
 
-       /* Reload system timeserver list */
-       if (system_timeservers != NULL) {
-               g_strfreev(system_timeservers);
-               system_timeservers = NULL;
+       if (!simplified_log)
+#endif
+       DBG("status %d", status);
+
+       if (status == G_RESOLV_RESULT_STATUS_SUCCESS) {
+               if (results) {
+                       /* prepend the results in reverse order */
+
+                       for (i = 0; results[i]; i++)
+                               /* count */;
+                       i--;
+
+                       for (; i >= 0; i--) {
+                               DBG("result[%d]: %s", i, results[i]);
+
+                               ts_list = __connman_timeserver_add_list(
+                                       ts_list, results[i]);
+                       }
+               }
        }
 
-       system_timeservers = load_timeservers();
+       sync_next();
+}
 
-       if (system_timeservers == NULL)
-               return;
+/*
+ * Once the timeserver list (timeserver_list) is created, we start
+ * querying the servers one by one. If resolving fails on one of them,
+ * we move to the next one. The user can enter either an IP address or
+ * a URL for the timeserver. We only resolve the URLs. Once we have an
+ * IP for the NTP server, we start querying it for time corrections.
+ */
+static void timeserver_sync_start(void)
+{
+       GSList *list;
 
-       __connman_ntp_stop();
+       for (list = timeservers_list; list; list = list->next) {
+               char *timeserver = list->data;
 
-       count = 0;
+               ts_list = g_slist_prepend(ts_list, g_strdup(timeserver));
+       }
+       ts_list = g_slist_reverse(ts_list);
 
-       __connman_timeserver_sync_next();
+       sync_next();
 }
 
-static void resolv_result(GResolvResultStatus status, char **results, gpointer user_data)
+static gboolean timeserver_sync_restart(gpointer user_data)
 {
-       int i;
+       timeserver_sync_start();
+       ts_backoff_id = 0;
 
-       DBG("status %d", status);
+       return FALSE;
+}
 
-       __sync_fetch_and_add(&count, 1);
+/*
+ * Select the next time server from the working list (ts_list) because
+ * for some reason the first time server in the list didn't work. If
+ * none of the server did work we start over with the first server
+ * with a backoff.
+ */
+static void sync_next(void)
+{
+       if (ts_current) {
+               g_free(ts_current);
+               ts_current = NULL;
+       }
 
-       if (status == G_RESOLV_RESULT_STATUS_SUCCESS) {
-               if (results != NULL) {
-                       for (i = 0; results[i]; i++)
-                               DBG("result: %s", results[i]);
+       __connman_ntp_stop();
 
-                       __connman_ntp_start(results[0]);
+       while (ts_list) {
+               ts_current = ts_list->data;
+               ts_list = g_slist_delete_link(ts_list, ts_list);
 
+               /* if it's an IP, directly query it. */
+               if (connman_inet_check_ipaddress(ts_current) > 0) {
+                       DBG("Using timeserver %s", ts_current);
+                       __connman_ntp_start(ts_current, ntp_callback, NULL);
                        return;
                }
+#if defined TIZEN_EXT
+       if (!simplified_log)
+#endif
+               DBG("Resolving timeserver %s", ts_current);
+#if defined TIZEN_EXT
+               resolv_id = g_resolv_lookup_hostname(resolv, ts_current,
+                                               resolv_result, ts_current);
+#else
+               resolv_id = g_resolv_lookup_hostname(resolv, ts_current,
+                                               resolv_result, NULL);
+#endif
+               return;
+       }
+
+       DBG("No timeserver could be used, restart probing in 5 seconds");
+       ts_backoff_id = g_timeout_add_seconds(5, timeserver_sync_restart, NULL);
+}
+
+GSList *__connman_timeserver_add_list(GSList *server_list,
+               const char *timeserver)
+{
+       GSList *list = server_list;
+
+       if (!timeserver)
+               return server_list;
+
+       while (list) {
+               char *existing_server = list->data;
+               if (strcmp(timeserver, existing_server) == 0)
+                       return server_list;
+               list = g_slist_next(list);
+       }
+       return g_slist_prepend(server_list, g_strdup(timeserver));
+}
+
+/*
+ * __connman_timeserver_get_all function creates the timeserver
+ * list which will be used to determine NTP server for time corrections.
+ * The service settings take priority over the global timeservers.
+ */
+GSList *__connman_timeserver_get_all(struct connman_service *service)
+{
+       GSList *list = NULL;
+       struct connman_network *network;
+       char **timeservers;
+       char **service_ts;
+       char **service_ts_config;
+       const char *service_gw;
+       char **fallback_ts;
+       int index, i;
+
+       if (__connman_clock_timeupdates() == TIME_UPDATES_MANUAL)
+               return NULL;
+
+       service_ts_config = connman_service_get_timeservers_config(service);
+
+       /* First add Service Timeservers.Configuration to the list */
+       for (i = 0; service_ts_config && service_ts_config[i];
+                       i++)
+               list = __connman_timeserver_add_list(list,
+                               service_ts_config[i]);
+
+       service_ts = connman_service_get_timeservers(service);
+
+       /* Then add Service Timeservers via DHCP to the list */
+       for (i = 0; service_ts && service_ts[i]; i++)
+               list = __connman_timeserver_add_list(list, service_ts[i]);
+
+       /*
+        * Then add Service Gateway to the list, if UseGatewaysAsTimeservers
+        * configuration option is set to true.
+        */
+       if (connman_setting_get_bool("UseGatewaysAsTimeservers")) {
+               network = __connman_service_get_network(service);
+               if (network) {
+                       index = connman_network_get_index(network);
+                       service_gw = __connman_ipconfig_get_gateway_from_index(index,
+                               CONNMAN_IPCONFIG_TYPE_ALL);
+
+                       if (service_gw)
+                               list = __connman_timeserver_add_list(list, service_gw);
+               }
+       }
+
+       /* Then add Global Timeservers to the list */
+       timeservers = load_timeservers();
+
+       for (i = 0; timeservers && timeservers[i]; i++)
+               list = __connman_timeserver_add_list(list, timeservers[i]);
+
+       g_strfreev(timeservers);
+
+       fallback_ts = connman_setting_get_string_list("FallbackTimeservers");
+
+       /* Lastly add the fallback servers */
+       for (i = 0; fallback_ts && fallback_ts[i]; i++)
+               list = __connman_timeserver_add_list(list, fallback_ts[i]);
+
+       return g_slist_reverse(list);
+}
+
+static gboolean ts_recheck(gpointer user_data)
+{
+       GSList *ts;
+
+       ts = __connman_timeserver_get_all(connman_service_get_default());
+
+       if (!ts) {
+               DBG("timeservers disabled");
+
+               return TRUE;
        }
 
-       __connman_timeserver_sync_next();
+       if (g_strcmp0(ts_current, ts->data) != 0) {
+               DBG("current %s preferred %s", ts_current, (char *)ts->data);
+
+               g_slist_free_full(ts, g_free);
+
+               __connman_timeserver_sync(NULL);
+
+               return FALSE;
+       }
+
+       DBG("");
+
+       g_slist_free_full(ts, g_free);
+
+       return TRUE;
 }
 
-void __connman_timeserver_sync_next()
+static void ts_recheck_disable(void)
 {
-       if (system_timeservers == NULL ||
-       system_timeservers[count] == NULL)
+       if (ts_recheck_id == 0)
                return;
 
-       DBG("Trying timeserver %s", system_timeservers[count]);
+       g_source_remove(ts_recheck_id);
+       ts_recheck_id = 0;
+
+       if (ts_backoff_id) {
+               g_source_remove(ts_backoff_id);
+               ts_backoff_id = 0;
+       }
 
-       if (resolv)
-               resolv_id = g_resolv_lookup_hostname(resolv,
-                       system_timeservers[count], resolv_result,
-                                               NULL);
+       if (ts_current) {
+               g_free(ts_current);
+               ts_current = NULL;
+       }
 }
 
+static void ts_recheck_enable(void)
+{
+       if (ts_recheck_id > 0)
+               return;
+
+       ts_recheck_id = g_timeout_add_seconds(TS_RECHECK_INTERVAL, ts_recheck,
+                       NULL);
+}
+
+/*
+ * This function must be called everytime the default service changes, the
+ * service timeserver(s) or gateway changes or the global timeserver(s) changes.
+ */
 int __connman_timeserver_sync(struct connman_service *default_service)
 {
        struct connman_service *service;
        char **nameservers;
        int i;
 
-       if (default_service != NULL)
+       if (default_service)
                service = default_service;
        else
-               service = __connman_service_get_default();
+               service = connman_service_get_default();
 
-       if (service == NULL)
+       if (!service)
                return -EINVAL;
 
-       DBG("service %p", service);
+#if !defined TIZEN_EXT
+       if (service == ts_service)
+               return -EALREADY;
+#endif
 
-       i = __connman_service_get_index(service);
-       if (i < 0)
-               return -EINVAL;
+       if (!resolv)
+               return 0;
+       /*
+        * Before we start creating the new timeserver list we must stop
+        * any ongoing ntp query and server resolution.
+        */
 
-       nameservers = connman_service_get_nameservers(service);
-       if (nameservers == NULL)
-               return -EINVAL;
+       __connman_ntp_stop();
 
-       resolv = g_resolv_new(i);
-       if (resolv == NULL)
-               return -ENOMEM;
+       ts_recheck_disable();
 
-       if (getenv("CONNMAN_RESOLV_DEBUG"))
-               g_resolv_set_debug(resolv, resolv_debug, "RESOLV");
+       if (resolv_id > 0)
+               g_resolv_cancel_lookup(resolv, resolv_id);
+
+       g_resolv_flush_nameservers(resolv);
 
-       for (i = 0; nameservers[i] != NULL; i++)
+       nameservers = connman_service_get_nameservers(service);
+       if (!nameservers)
+               return -EINVAL;
+
+       for (i = 0; nameservers[i]; i++)
                g_resolv_add_nameserver(resolv, nameservers[i], 53, 0);
 
-       count = 0;
+       g_strfreev(nameservers);
 
-       system_timeservers = load_timeservers();
+       g_slist_free_full(timeservers_list, g_free);
 
-       timeservers = connman_service_get_timeservers(service);
+       timeservers_list = __connman_timeserver_get_all(service);
 
-       if (timeservers != NULL && timeservers[0] != NULL) {
-               DBG("Using service tiemservers");
-               __connman_ntp_start(timeservers[0]);
-               return 0;
-       }
+       __connman_service_timeserver_changed(service, timeservers_list);
 
-       if (system_timeservers == NULL || system_timeservers[count] == NULL) {
+       if (!timeservers_list) {
                DBG("No timeservers set.");
                return 0;
        }
 
-       DBG("Trying server %s", system_timeservers[count]);
+       ts_recheck_enable();
+
+       ts_service = service;
+       timeserver_sync_start();
 
-       resolv_id = g_resolv_lookup_hostname(resolv, system_timeservers[count],
-                                               resolv_result, NULL);
        return 0;
 }
 
-void __connman_timeserver_stop()
+static int timeserver_start(struct connman_service *service)
 {
-       DBG(" ");
+       char **nameservers;
+       int i;
+
+       DBG("service %p", service);
 
-       if (resolv != NULL) {
+       i = __connman_service_get_index(service);
+       if (i < 0)
+               return -EINVAL;
+
+       nameservers = connman_service_get_nameservers(service);
+
+       /* Stop an already ongoing resolution, if there is one */
+       if (resolv && resolv_id > 0)
+               g_resolv_cancel_lookup(resolv, resolv_id);
+
+       /* get rid of the old resolver */
+       if (resolv) {
                g_resolv_unref(resolv);
                resolv = NULL;
        }
 
-       if (system_timeservers != NULL) {
-               g_strfreev(system_timeservers);
-               system_timeservers = NULL;
+       resolv = g_resolv_new(i);
+       if (!resolv) {
+               g_strfreev(nameservers);
+               return -ENOMEM;
        }
 
-       timeservers = NULL;
+       if (getenv("CONNMAN_RESOLV_DEBUG"))
+               g_resolv_set_debug(resolv, resolv_debug, "RESOLV");
+
+       if (nameservers) {
+               for (i = 0; nameservers[i]; i++)
+                       g_resolv_add_nameserver(resolv, nameservers[i], 53, 0);
+
+               g_strfreev(nameservers);
+       }
+
+       return __connman_timeserver_sync(service);
+}
+
+static void timeserver_stop(void)
+{
+       DBG(" ");
 
-       count = 0;
+       ts_service = NULL;
+
+       if (resolv) {
+               g_resolv_unref(resolv);
+               resolv = NULL;
+       }
+
+       g_slist_free_full(timeservers_list, g_free);
+       timeservers_list = NULL;
+
+       g_slist_free_full(ts_list, g_free);
+       ts_list = NULL;
 
        __connman_ntp_stop();
+
+       ts_recheck_disable();
 }
 
 int __connman_timeserver_system_set(char **servers)
 {
        save_timeservers(servers);
 
-       connman_timeserver_restart();
+       __connman_timeserver_sync(NULL);
 
        return 0;
 }
@@ -253,15 +495,13 @@ char **__connman_timeserver_system_get()
 
 static void default_changed(struct connman_service *default_service)
 {
-       DBG("");
-
-       if (default_service != NULL)
-               __connman_timeserver_sync(default_service);
+       if (default_service)
+               timeserver_start(default_service);
        else
-               __connman_timeserver_stop();
+               timeserver_stop();
 }
 
-static struct connman_notifier timeserver_notifier = {
+static const struct connman_notifier timeserver_notifier = {
        .name                   = "timeserver",
        .default_changed        = default_changed,
 };