Fix resource leak
[platform/upstream/connman.git] / src / timeserver.c
index 8b9afb1..a9a73a2 100755 (executable)
 
 #define TS_RECHECK_INTERVAL     7200
 
+static struct connman_service *ts_service;
+static GSList *timeservers_list = NULL;
 static GSList *ts_list = NULL;
 static char *ts_current = NULL;
 static int ts_recheck_id = 0;
+static int ts_backoff_id = 0;
 
 static GResolv *resolv = NULL;
 static int resolv_id = 0;
 
+static void sync_next(void);
+
 static void resolv_debug(const char *str, void *data)
 {
        connman_info("%s: %s\n", (const char *) data, str);
 }
+
+static void ntp_callback(bool success, void *user_data)
+{
+       DBG("success %d", success);
+
+       if (!success)
+               sync_next();
+}
+
 static void save_timeservers(char **servers)
 {
        GKeyFile *keyfile;
@@ -62,8 +76,6 @@ static void save_timeservers(char **servers)
        __connman_storage_save_global(keyfile);
 
        g_key_file_free(keyfile);
-
-       return;
 }
 
 static char **load_timeservers(void)
@@ -88,39 +100,75 @@ static void resolv_result(GResolvResultStatus status, char **results,
 {
        int i;
 
+#if defined TIZEN_EXT
+       gchar *server = NULL;
+
+       server = g_strdup((gchar *)user_data);
+       ts_list = g_slist_append(ts_list, server);
+
+       if (!simplified_log)
+               DBG("added server %s", server);
+
+       if (!simplified_log)
+#endif
        DBG("status %d", status);
 
        if (status == G_RESOLV_RESULT_STATUS_SUCCESS) {
                if (results) {
-                       for (i = 0; results[i]; i++) {
+                       /* prepend the results in reverse order */
+
+                       for (i = 0; results[i]; i++)
+                               /* count */;
+                       i--;
+
+                       for (; i >= 0; i--) {
                                DBG("result[%d]: %s", i, results[i]);
-                               if (i == 0)
-                                       continue;
 
                                ts_list = __connman_timeserver_add_list(
-                                                       ts_list, results[i]);
+                                       ts_list, results[i]);
                        }
+               }
+       }
 
-                       DBG("Using timeserver %s", results[0]);
+       sync_next();
+}
 
-                       __connman_ntp_start(results[0]);
+/*
+ * Once the timeserver list (timeserver_list) is created, we start
+ * querying the servers one by one. If resolving fails on one of them,
+ * we move to the next one. The user can enter either an IP address or
+ * a URL for the timeserver. We only resolve the URLs. Once we have an
+ * IP for the NTP server, we start querying it for time corrections.
+ */
+static void timeserver_sync_start(void)
+{
+       GSList *list;
 
-                       return;
-               }
+       for (list = timeservers_list; list; list = list->next) {
+               char *timeserver = list->data;
+
+               ts_list = g_slist_prepend(ts_list, g_strdup(timeserver));
        }
+       ts_list = g_slist_reverse(ts_list);
 
-       /* If resolving fails, move to the next server */
-       __connman_timeserver_sync_next();
+       sync_next();
+}
+
+static gboolean timeserver_sync_restart(gpointer user_data)
+{
+       timeserver_sync_start();
+       ts_backoff_id = 0;
+
+       return FALSE;
 }
 
 /*
- * Once the timeserver list (ts_list) is created, we start querying the
- * servers one by one. If resolving fails on one of them, we move to the
- * next one. The user can enter either an IP address or a URL for the
- * timeserver. We only resolve the URLs. Once we have an IP for the NTP
- * server, we start querying it for time corrections.
+ * Select the next time server from the working list (ts_list) because
+ * for some reason the first time server in the list didn't work. If
+ * none of the server did work we start over with the first server
+ * with a backoff.
  */
-void __connman_timeserver_sync_next()
+static void sync_next(void)
 {
        if (ts_current) {
                g_free(ts_current);
@@ -129,29 +177,32 @@ void __connman_timeserver_sync_next()
 
        __connman_ntp_stop();
 
-       /* Get the 1st server in the list */
-       if (!ts_list)
-               return;
-
-       ts_current = ts_list->data;
-
-       ts_list = g_slist_delete_link(ts_list, ts_list);
-
-       /* if it's an IP, directly query it. */
-       if (connman_inet_check_ipaddress(ts_current) > 0) {
-               DBG("Using timeserver %s", ts_current);
-
-               __connman_ntp_start(ts_current);
+       while (ts_list) {
+               ts_current = ts_list->data;
+               ts_list = g_slist_delete_link(ts_list, ts_list);
 
+               /* if it's an IP, directly query it. */
+               if (connman_inet_check_ipaddress(ts_current) > 0) {
+                       DBG("Using timeserver %s", ts_current);
+                       __connman_ntp_start(ts_current, ntp_callback, NULL);
+                       return;
+               }
+#if defined TIZEN_EXT
+       if (!simplified_log)
+#endif
+               DBG("Resolving timeserver %s", ts_current);
+#if defined TIZEN_EXT
+               resolv_id = g_resolv_lookup_hostname(resolv, ts_current,
+                                               resolv_result, ts_current);
+#else
+               resolv_id = g_resolv_lookup_hostname(resolv, ts_current,
+                                               resolv_result, NULL);
+#endif
                return;
        }
 
-       DBG("Resolving timeserver %s", ts_current);
-
-       resolv_id = g_resolv_lookup_hostname(resolv, ts_current,
-                                               resolv_result, NULL);
-
-       return;
+       DBG("No timeserver could be used, restart probing in 5 seconds");
+       ts_backoff_id = g_timeout_add_seconds(5, timeserver_sync_restart, NULL);
 }
 
 GSList *__connman_timeserver_add_list(GSList *server_list,
@@ -204,15 +255,20 @@ GSList *__connman_timeserver_get_all(struct connman_service *service)
        for (i = 0; service_ts && service_ts[i]; i++)
                list = __connman_timeserver_add_list(list, service_ts[i]);
 
-       network = __connman_service_get_network(service);
-       if (network) {
-               index = connman_network_get_index(network);
-               service_gw = __connman_ipconfig_get_gateway_from_index(index,
-                       CONNMAN_IPCONFIG_TYPE_ALL);
-
-               /* Then add Service Gateway to the list */
-               if (service_gw)
-                       list = __connman_timeserver_add_list(list, service_gw);
+       /*
+        * Then add Service Gateway to the list, if UseGatewaysAsTimeservers
+        * configuration option is set to true.
+        */
+       if (connman_setting_get_bool("UseGatewaysAsTimeservers")) {
+               network = __connman_service_get_network(service);
+               if (network) {
+                       index = connman_network_get_index(network);
+                       service_gw = __connman_ipconfig_get_gateway_from_index(index,
+                               CONNMAN_IPCONFIG_TYPE_ALL);
+
+                       if (service_gw)
+                               list = __connman_timeserver_add_list(list, service_gw);
+               }
        }
 
        /* Then add Global Timeservers to the list */
@@ -236,7 +292,7 @@ static gboolean ts_recheck(gpointer user_data)
 {
        GSList *ts;
 
-       ts = __connman_timeserver_get_all(__connman_service_get_default());
+       ts = __connman_timeserver_get_all(connman_service_get_default());
 
        if (!ts) {
                DBG("timeservers disabled");
@@ -269,6 +325,11 @@ static void ts_recheck_disable(void)
        g_source_remove(ts_recheck_id);
        ts_recheck_id = 0;
 
+       if (ts_backoff_id) {
+               g_source_remove(ts_backoff_id);
+               ts_backoff_id = 0;
+       }
+
        if (ts_current) {
                g_free(ts_current);
                ts_current = NULL;
@@ -285,26 +346,28 @@ static void ts_recheck_enable(void)
 }
 
 /*
- * This function must be called everytime the default service changes, the
+ * This function must be called every time the default service changes, the
  * service timeserver(s) or gateway changes or the global timeserver(s) changes.
  */
 int __connman_timeserver_sync(struct connman_service *default_service)
 {
-#if defined TIZEN_EXT && !defined TIZEN_CONNMAN_NTP
-       /* Tizen updates time (ntp) by system service */
-
-       return 0;
-#endif
        struct connman_service *service;
+       char **nameservers;
+       int i;
 
        if (default_service)
                service = default_service;
        else
-               service = __connman_service_get_default();
+               service = connman_service_get_default();
 
        if (!service)
                return -EINVAL;
 
+#if !defined TIZEN_EXT
+       if (service == ts_service)
+               return -EALREADY;
+#endif
+
        if (!resolv)
                return 0;
        /*
@@ -319,20 +382,32 @@ int __connman_timeserver_sync(struct connman_service *default_service)
        if (resolv_id > 0)
                g_resolv_cancel_lookup(resolv, resolv_id);
 
-       g_slist_free_full(ts_list, g_free);
+       g_resolv_flush_nameservers(resolv);
+
+       nameservers = connman_service_get_nameservers(service);
+       if (!nameservers)
+               return -EINVAL;
 
-       ts_list = __connman_timeserver_get_all(service);
+       for (i = 0; nameservers[i]; i++)
+               g_resolv_add_nameserver(resolv, nameservers[i], 53, 0);
 
-       __connman_service_timeserver_changed(service, ts_list);
+       g_strfreev(nameservers);
 
-       if (!ts_list) {
+       g_slist_free_full(timeservers_list, g_free);
+
+       timeservers_list = __connman_timeserver_get_all(service);
+
+       __connman_service_timeserver_changed(service, timeservers_list);
+
+       if (!timeservers_list) {
                DBG("No timeservers set.");
                return 0;
        }
 
        ts_recheck_enable();
 
-       __connman_timeserver_sync_next();
+       ts_service = service;
+       timeserver_sync_start();
 
        return 0;
 }
@@ -349,8 +424,6 @@ static int timeserver_start(struct connman_service *service)
                return -EINVAL;
 
        nameservers = connman_service_get_nameservers(service);
-       if (!nameservers)
-               return -EINVAL;
 
        /* Stop an already ongoing resolution, if there is one */
        if (resolv && resolv_id > 0)
@@ -371,10 +444,12 @@ static int timeserver_start(struct connman_service *service)
        if (getenv("CONNMAN_RESOLV_DEBUG"))
                g_resolv_set_debug(resolv, resolv_debug, "RESOLV");
 
-       for (i = 0; nameservers[i]; i++)
-               g_resolv_add_nameserver(resolv, nameservers[i], 53, 0);
+       if (nameservers) {
+               for (i = 0; nameservers[i]; i++)
+                       g_resolv_add_nameserver(resolv, nameservers[i], 53, 0);
 
-       g_strfreev(nameservers);
+               g_strfreev(nameservers);
+       }
 
        return __connman_timeserver_sync(service);
 }
@@ -383,13 +458,17 @@ static void timeserver_stop(void)
 {
        DBG(" ");
 
+       ts_service = NULL;
+
        if (resolv) {
                g_resolv_unref(resolv);
                resolv = NULL;
        }
 
-       g_slist_free_full(ts_list, g_free);
+       g_slist_free_full(timeservers_list, g_free);
+       timeservers_list = NULL;
 
+       g_slist_free_full(ts_list, g_free);
        ts_list = NULL;
 
        __connman_ntp_stop();
@@ -422,7 +501,7 @@ static void default_changed(struct connman_service *default_service)
                timeserver_stop();
 }
 
-static struct connman_notifier timeserver_notifier = {
+static const struct connman_notifier timeserver_notifier = {
        .name                   = "timeserver",
        .default_changed        = default_changed,
 };