Imported Upstream version 1.38
[platform/upstream/connman.git] / src / tethering.c
index f7732c9..e2687b6 100644 (file)
@@ -2,7 +2,7 @@
  *
  *  Connection Manager
  *
- *  Copyright (C) 2007-2010  Intel Corporation. All rights reserved.
+ *  Copyright (C) 2007-2013  Intel Corporation. All rights reserved.
  *  Copyright (C) 2011 ProFUSION embedded systems
  *
  *  This program is free software; you can redistribute it and/or modify
 #include <config.h>
 #endif
 
+#include <errno.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <sys/ioctl.h>
 #include <net/if.h>
-#include <linux/sockios.h>
 #include <string.h>
 #include <fcntl.h>
+#include <netinet/in.h>
+#include <linux/sockios.h>
 #include <linux/if_tun.h>
+#include <linux/if_bridge.h>
 
 #include "connman.h"
 
 
 #include <gdbus.h>
 
-#define BRIDGE_PROC_DIR "/proc/sys/net/bridge"
+#ifndef DBUS_TYPE_UNIX_FD
+#define DBUS_TYPE_UNIX_FD -1
+#endif
 
 #define BRIDGE_NAME "tether"
-#define BRIDGE_IP "192.168.218.1"
-#define BRIDGE_BCAST "192.168.218.255"
-#define BRIDGE_SUBNET "255.255.255.0"
-#define BRIDGE_IP_START "192.168.218.100"
-#define BRIDGE_IP_END "192.168.218.200"
-#define BRIDGE_DNS "8.8.8.8"
 
 #define DEFAULT_MTU    1500
 
-#define PRIVATE_NETWORK_IP "192.168.219.1"
-#define PRIVATE_NETWORK_PEER_IP "192.168.219.2"
-#define PRIVATE_NETWORK_NETMASK "255.255.255.0"
-#define PRIVATE_NETWORK_PRIMARY_DNS BRIDGE_DNS
-#define PRIVATE_NETWORK_SECONDARY_DNS "8.8.4.4"
+static char *private_network_primary_dns = NULL;
+static char *private_network_secondary_dns = NULL;
 
-static char *default_interface = NULL;
-static volatile gint tethering_enabled;
+static volatile int tethering_enabled;
 static GDHCPServer *tethering_dhcp_server = NULL;
+static struct connman_ippool *dhcp_ippool = NULL;
 static DBusConnection *connection;
 static GHashTable *pn_hash;
 
+static GHashTable *clients_table;
+
+struct _clients_notify {
+       int id;
+       GHashTable *remove;
+} *clients_notify;
+
 struct connman_private_network {
        char *owner;
+       char *path;
        guint watch;
        DBusMessage *msg;
        DBusMessage *reply;
@@ -74,17 +78,25 @@ struct connman_private_network {
        char *interface;
        int index;
        guint iface_watch;
-       const char *server_ip;
-       const char *peer_ip;
-       const char *primary_dns;
-       const char *secondary_dns;
+       struct connman_ippool *pool;
+       char *primary_dns;
+       char *secondary_dns;
 };
 
 const char *__connman_tethering_get_bridge(void)
 {
-       struct stat st;
+       int sk, err;
+       unsigned long args[3];
+
+       sk = socket(AF_INET, SOCK_STREAM, 0);
+       if (sk < 0)
+               return NULL;
 
-       if (stat(BRIDGE_PROC_DIR, &st) < 0) {
+       args[0] = BRCTL_GET_VERSION;
+       args[1] = args[2] = 0;
+       err = ioctl(sk, SIOCGIFBR, &args);
+       close(sk);
+       if (err == -1) {
                connman_error("Missing support for 802.1d ethernet bridging");
                return NULL;
        }
@@ -128,7 +140,7 @@ static void dhcp_server_error(GDHCPServerError error)
 }
 
 static GDHCPServer *dhcp_server_start(const char *bridge,
-                               const char *router, const charsubnet,
+                               const char *router, const char *subnet,
                                const char *start_ip, const char *end_ip,
                                unsigned int lease_time, const char *dns)
 {
@@ -143,7 +155,7 @@ static GDHCPServer *dhcp_server_start(const char *bridge,
                return NULL;
 
        dhcp_server = g_dhcp_server_new(G_DHCP_IPV4, index, &error);
-       if (dhcp_server == NULL) {
+       if (!dhcp_server) {
                dhcp_server_error(error);
                return NULL;
        }
@@ -163,246 +175,192 @@ static GDHCPServer *dhcp_server_start(const char *bridge,
 
 static void dhcp_server_stop(GDHCPServer *server)
 {
-       if (server == NULL)
+       if (!server)
                return;
 
        g_dhcp_server_unref(server);
 }
 
-static int set_forward_delay(const char *name, unsigned int delay)
+static void tethering_restart(struct connman_ippool *pool, void *user_data)
 {
-       FILE *f;
-       char *forward_delay_path;
-
-       forward_delay_path =
-               g_strdup_printf("/sys/class/net/%s/bridge/forward_delay", name);
-
-       if (forward_delay_path == NULL)
-               return -ENOMEM;
-
-       f = fopen(forward_delay_path, "r+");
-
-       g_free(forward_delay_path);
-
-       if (f == NULL)
-               return -errno;
-
-       fprintf(f, "%d", delay);
-
-       fclose(f);
-
-       return 0;
+       DBG("pool %p", pool);
+       __connman_tethering_set_disabled();
+       __connman_tethering_set_enabled();
 }
 
-static int create_bridge(const char *name)
+static void unregister_client(gpointer key,
+                                       gpointer value, gpointer user_data)
 {
-       int sk, err;
-
-       DBG("name %s", name);
-
-       sk = socket(AF_INET, SOCK_STREAM, 0);
-       if (sk < 0)
-               return -EOPNOTSUPP;
-
-       err = ioctl(sk, SIOCBRADDBR, name);
-
-       if (err < 0)
-               return -EOPNOTSUPP;
-
-       err = set_forward_delay(name, 0);
-
-       if (err < 0)
-               ioctl(sk, SIOCBRDELBR, name);
-
-       close(sk);
-
-       return err;
+       const char *addr = key;
+       __connman_tethering_client_unregister(addr);
 }
 
-static int remove_bridge(const char *name)
+static void unregister_all_clients(void)
 {
-       int sk, err;
-
-       DBG("name %s", name);
-
-       sk = socket(AF_INET, SOCK_STREAM, 0);
-       if (sk < 0)
-               return -EOPNOTSUPP;
-
-       err = ioctl(sk, SIOCBRDELBR, name);
-
-       close(sk);
-
-       if (err < 0)
-               return -EOPNOTSUPP;
-
-       return 0;
-}
-
-static int enable_bridge(const char *name)
-{
-       int err, index;
-
-       index = connman_inet_ifindex(name);
-       if (index < 0)
-               return index;
-
-       err = __connman_inet_modify_address(RTM_NEWADDR,
-                       NLM_F_REPLACE | NLM_F_ACK, index, AF_INET,
-                                       BRIDGE_IP, NULL, 24, BRIDGE_BCAST);
-       if (err < 0)
-               return err;
-
-       return connman_inet_ifup(index);
+       g_hash_table_foreach(clients_table, unregister_client, NULL);
 }
 
-static int disable_bridge(const char *name)
+int __connman_tethering_set_enabled(void)
 {
        int index;
+       int err;
+       const char *gateway;
+       const char *broadcast;
+       const char *subnet_mask;
+       const char *start_ip;
+       const char *end_ip;
+       const char *dns;
+       unsigned char prefixlen;
+       char **ns;
 
-       index = connman_inet_ifindex(name);
-       if (index < 0)
-               return index;
-
-       return connman_inet_ifdown(index);
-}
+       DBG("enabled %d", tethering_enabled + 1);
 
-static int enable_ip_forward(connman_bool_t enable)
-{
+       if (__sync_fetch_and_add(&tethering_enabled, 1) != 0)
+               return 0;
 
-       FILE *f;
+       err = __connman_bridge_create(BRIDGE_NAME);
+       if (err < 0) {
+               __sync_fetch_and_sub(&tethering_enabled, 1);
+               return -EOPNOTSUPP;
+       }
 
-       f = fopen("/proc/sys/net/ipv4/ip_forward", "r+");
-       if (f == NULL)
-               return -errno;
+       index = connman_inet_ifindex(BRIDGE_NAME);
+       dhcp_ippool = __connman_ippool_create(index, 2, 252,
+                                               tethering_restart, NULL);
+       if (!dhcp_ippool) {
+               connman_error("Fail to create IP pool");
+               __connman_bridge_remove(BRIDGE_NAME);
+               __sync_fetch_and_sub(&tethering_enabled, 1);
+               return -EADDRNOTAVAIL;
+       }
 
-       if (enable == TRUE)
-               fprintf(f, "1");
-       else
-               fprintf(f, "0");
+       gateway = __connman_ippool_get_gateway(dhcp_ippool);
+       broadcast = __connman_ippool_get_broadcast(dhcp_ippool);
+       subnet_mask = __connman_ippool_get_subnet_mask(dhcp_ippool);
+       start_ip = __connman_ippool_get_start_ip(dhcp_ippool);
+       end_ip = __connman_ippool_get_end_ip(dhcp_ippool);
+
+       err = __connman_bridge_enable(BRIDGE_NAME, gateway,
+                       connman_ipaddress_calc_netmask_len(subnet_mask),
+                       broadcast);
+       if (err < 0 && err != -EALREADY) {
+               __connman_ippool_free(dhcp_ippool);
+               dhcp_ippool = NULL;
+               __connman_bridge_remove(BRIDGE_NAME);
+               __sync_fetch_and_sub(&tethering_enabled, 1);
+               return -EADDRNOTAVAIL;
+       }
 
-       fclose(f);
+       ns = connman_setting_get_string_list("FallbackNameservers");
+       if (ns) {
+               if (ns[0]) {
+                       g_free(private_network_primary_dns);
+                       private_network_primary_dns = g_strdup(ns[0]);
+               }
+               if (ns[1]) {
+                       g_free(private_network_secondary_dns);
+                       private_network_secondary_dns = g_strdup(ns[1]);
+               }
 
-       return 0;
-}
+               DBG("Fallback ns primary %s secondary %s",
+                       private_network_primary_dns,
+                       private_network_secondary_dns);
+       }
 
-static int enable_nat(const char *interface)
-{
-       int err;
+       dns = gateway;
+       if (__connman_dnsproxy_add_listener(index) < 0) {
+               connman_error("Can't add listener %s to DNS proxy",
+                                                               BRIDGE_NAME);
+               dns = private_network_primary_dns;
+               DBG("Serving %s nameserver to clients", dns);
+       }
 
-       if (interface == NULL)
-               return 0;
+       tethering_dhcp_server = dhcp_server_start(BRIDGE_NAME,
+                                               gateway, subnet_mask,
+                                               start_ip, end_ip,
+                                               24 * 3600, dns);
+       if (!tethering_dhcp_server) {
+               __connman_bridge_disable(BRIDGE_NAME);
+               __connman_ippool_free(dhcp_ippool);
+               dhcp_ippool = NULL;
+               __connman_bridge_remove(BRIDGE_NAME);
+               __sync_fetch_and_sub(&tethering_enabled, 1);
+               return -EOPNOTSUPP;
+       }
 
-       /* Enable IPv4 forwarding */
-       err = enable_ip_forward(TRUE);
-       if (err < 0)
-               return err;
+       prefixlen = connman_ipaddress_calc_netmask_len(subnet_mask);
+       err = __connman_nat_enable(BRIDGE_NAME, start_ip, prefixlen);
+       if (err < 0) {
+               connman_error("Cannot enable NAT %d/%s", err, strerror(-err));
+               dhcp_server_stop(tethering_dhcp_server);
+               __connman_bridge_disable(BRIDGE_NAME);
+               __connman_ippool_free(dhcp_ippool);
+               dhcp_ippool = NULL;
+               __connman_bridge_remove(BRIDGE_NAME);
+               __sync_fetch_and_sub(&tethering_enabled, 1);
+               return -EOPNOTSUPP;
+       }
 
-       /* POSTROUTING flush */
-       err = __connman_iptables_command("-t nat -F POSTROUTING");
-       if (err < 0)
-               return err;
+       err = __connman_ipv6pd_setup(BRIDGE_NAME);
+       if (err < 0 && err != -EINPROGRESS)
+               DBG("Cannot setup IPv6 prefix delegation %d/%s", err,
+                       strerror(-err));
 
-       /* Enable masquerading */
-       err = __connman_iptables_command("-t nat -A POSTROUTING "
-                                       "-o %s -j MASQUERADE", interface);
-       if (err < 0)
-               return err;
+       DBG("tethering started");
 
-       return __connman_iptables_commit("nat");
+       return 0;
 }
 
-static void disable_nat(const char *interface)
+void __connman_tethering_set_disabled(void)
 {
-       int err;
+       int index;
 
-       /* Disable IPv4 forwarding */
-       enable_ip_forward(FALSE);
+       DBG("enabled %d", tethering_enabled - 1);
 
-       /* POSTROUTING flush */
-       err = __connman_iptables_command("-t nat -F POSTROUTING");
-       if (err < 0)
+       if (__sync_fetch_and_sub(&tethering_enabled, 1) != 1)
                return;
 
-       __connman_iptables_commit("nat");
-}
+       unregister_all_clients();
 
-void __connman_tethering_set_enabled(void)
-{
-       int err;
+       __connman_ipv6pd_cleanup();
 
-       DBG("enabled %d", tethering_enabled + 1);
+       index = connman_inet_ifindex(BRIDGE_NAME);
+       __connman_dnsproxy_remove_listener(index);
 
-       if (g_atomic_int_exchange_and_add(&tethering_enabled, 1) == 0) {
-               err = create_bridge(BRIDGE_NAME);
-               if (err < 0)
-                       return;
+       __connman_nat_disable(BRIDGE_NAME);
 
-               err = enable_bridge(BRIDGE_NAME);
-               if (err < 0) {
-                       remove_bridge(BRIDGE_NAME);
-                       return;
-               }
+       dhcp_server_stop(tethering_dhcp_server);
 
-               if (__connman_dnsproxy_add_listener(BRIDGE_NAME) < 0)
-                       connman_error("Can't add listener %s to DNS proxy",
-                                                               BRIDGE_NAME);
+       tethering_dhcp_server = NULL;
 
-               tethering_dhcp_server =
-                       dhcp_server_start(BRIDGE_NAME,
-                                               BRIDGE_IP, BRIDGE_SUBNET,
-                                               BRIDGE_IP_START, BRIDGE_IP_END,
-                                                       24 * 3600, BRIDGE_IP);
-               if (tethering_dhcp_server == NULL) {
-                       disable_bridge(BRIDGE_NAME);
-                       remove_bridge(BRIDGE_NAME);
-                       return;
-               }
-
-               enable_nat(default_interface);
-
-               DBG("tethering started");
-       }
-}
-
-void __connman_tethering_set_disabled(void)
-{
-       DBG("enabled %d", tethering_enabled - 1);
+       __connman_bridge_disable(BRIDGE_NAME);
 
-       __connman_dnsproxy_remove_listener(BRIDGE_NAME);
-
-       if (g_atomic_int_dec_and_test(&tethering_enabled) == TRUE) {
-               disable_nat(default_interface);
-
-               dhcp_server_stop(tethering_dhcp_server);
+       __connman_ippool_free(dhcp_ippool);
+       dhcp_ippool = NULL;
 
-               disable_bridge(BRIDGE_NAME);
+       __connman_bridge_remove(BRIDGE_NAME);
 
-               remove_bridge(BRIDGE_NAME);
+       g_free(private_network_primary_dns);
+       private_network_primary_dns = NULL;
+       g_free(private_network_secondary_dns);
+       private_network_secondary_dns = NULL;
 
-               DBG("tethering stopped");
-       }
+       DBG("tethering stopped");
 }
 
-void __connman_tethering_update_interface(const char *interface)
+static void append_client(gpointer key, gpointer value,
+                                               gpointer user_data)
 {
-       DBG("interface %s", interface);
-
-       g_free(default_interface);
-
-       if (interface == NULL) {
-               disable_nat(interface);
-               default_interface = NULL;
-
-               return;
-       }
+       const char *addr = key;
+       DBusMessageIter *array = user_data;
 
-       default_interface = g_strdup(interface);
-
-       if (!g_atomic_int_get(&tethering_enabled))
-               return;
+       dbus_message_iter_append_basic(array, DBUS_TYPE_STRING,
+                                                       &addr);
+}
 
-       enable_nat(interface);
+void __connman_tethering_list_clients(DBusMessageIter *array)
+{
+       g_hash_table_foreach(clients_table, append_client, array);
 }
 
 static void setup_tun_interface(unsigned int flags, unsigned change,
@@ -410,8 +368,10 @@ static void setup_tun_interface(unsigned int flags, unsigned change,
 {
        struct connman_private_network *pn = data;
        unsigned char prefixlen;
-       DBusMessage *reply;
        DBusMessageIter array, dict;
+       const char *server_ip;
+       const char *peer_ip;
+       const char *subnet_mask;
        int err;
 
        DBG("index %d flags %d change %d", pn->index,  flags, change);
@@ -419,79 +379,84 @@ static void setup_tun_interface(unsigned int flags, unsigned change,
        if (flags & IFF_UP)
                return;
 
-       prefixlen =
-               __connman_ipconfig_netmask_prefix_len(PRIVATE_NETWORK_NETMASK);
+       subnet_mask = __connman_ippool_get_subnet_mask(pn->pool);
+       server_ip = __connman_ippool_get_start_ip(pn->pool);
+       peer_ip = __connman_ippool_get_end_ip(pn->pool);
+       prefixlen = connman_ipaddress_calc_netmask_len(subnet_mask);
 
        if ((__connman_inet_modify_address(RTM_NEWADDR,
                                NLM_F_REPLACE | NLM_F_ACK, pn->index, AF_INET,
-                               pn->server_ip, pn->peer_ip,
-                               prefixlen, NULL)) < 0) {
+                               server_ip, peer_ip, prefixlen, NULL)) < 0) {
                DBG("address setting failed");
                return;
        }
 
        connman_inet_ifup(pn->index);
 
-       err = enable_nat(default_interface);
+       err = __connman_nat_enable(BRIDGE_NAME, server_ip, prefixlen);
        if (err < 0) {
-               connman_error("failed to enable NAT on %s", default_interface);
+               connman_error("failed to enable NAT");
                goto error;
        }
 
-       reply = dbus_message_new_method_return(pn->msg);
-
-       if (reply == NULL)
-               goto error;
-
-       dbus_message_iter_init_append(reply, &array);
+       dbus_message_iter_init_append(pn->reply, &array);
 
-       dbus_message_iter_append_basic(&array, DBUS_TYPE_UNIX_FD, &pn->fd);
+       dbus_message_iter_append_basic(&array, DBUS_TYPE_OBJECT_PATH,
+                                               &pn->path);
 
        connman_dbus_dict_open(&array, &dict);
 
        connman_dbus_dict_append_basic(&dict, "ServerIPv4",
-                                               DBUS_TYPE_STRING, &pn->server_ip);
+                                       DBUS_TYPE_STRING, &server_ip);
        connman_dbus_dict_append_basic(&dict, "PeerIPv4",
-                                               DBUS_TYPE_STRING, &pn->peer_ip);
-       connman_dbus_dict_append_basic(&dict, "PrimaryDNS",
-                                               DBUS_TYPE_STRING, &pn->primary_dns);
-       connman_dbus_dict_append_basic(&dict, "SecondaryDNS",
-                                               DBUS_TYPE_STRING, &pn->secondary_dns);
+                                       DBUS_TYPE_STRING, &peer_ip);
+       if (pn->primary_dns)
+               connman_dbus_dict_append_basic(&dict, "PrimaryDNS",
+                                       DBUS_TYPE_STRING, &pn->primary_dns);
+
+       if (pn->secondary_dns)
+               connman_dbus_dict_append_basic(&dict, "SecondaryDNS",
+                                       DBUS_TYPE_STRING, &pn->secondary_dns);
 
        connman_dbus_dict_close(&array, &dict);
 
-       g_dbus_send_message(connection, reply);
+       dbus_message_iter_append_basic(&array, DBUS_TYPE_UNIX_FD, &pn->fd);
+
+       g_dbus_send_message(connection, pn->reply);
 
        return;
 
 error:
-       reply = __connman_error_failed(pn->msg, -err);
-       g_dbus_send_message(connection, reply);
+       pn->reply = __connman_error_failed(pn->msg, -err);
+       g_dbus_send_message(connection, pn->reply);
 
-       g_hash_table_remove(pn_hash, pn->owner);
+       g_hash_table_remove(pn_hash, pn->path);
 }
 
 static void remove_private_network(gpointer user_data)
 {
        struct connman_private_network *pn = user_data;
 
-       close(pn->fd);
-
+       __connman_nat_disable(BRIDGE_NAME);
        connman_rtnl_remove_watch(pn->iface_watch);
-
-       disable_nat(default_interface);
+       __connman_ippool_free(pn->pool);
 
        if (pn->watch > 0) {
                g_dbus_remove_watch(connection, pn->watch);
                pn->watch = 0;
        }
 
+       close(pn->fd);
+
        g_free(pn->interface);
        g_free(pn->owner);
+       g_free(pn->path);
+       g_free(pn->primary_dns);
+       g_free(pn->secondary_dns);
        g_free(pn);
 }
 
-static void owner_disconnect(DBusConnection *connection, void *user_data)
+static void owner_disconnect(DBusConnection *conn, void *user_data)
 {
        struct connman_private_network *pn = user_data;
 
@@ -499,75 +464,183 @@ static void owner_disconnect(DBusConnection *connection, void *user_data)
 
        pn->watch = 0;
 
-       g_hash_table_remove(pn_hash, pn->owner);
+       g_hash_table_remove(pn_hash, pn->path);
+}
+
+static void ippool_disconnect(struct connman_ippool *pool, void *user_data)
+{
+       struct connman_private_network *pn = user_data;
+
+       DBG("block used externally");
+
+       g_hash_table_remove(pn_hash, pn->path);
+}
+
+static gboolean client_send_changed(gpointer data)
+{
+       DBusMessage *signal;
+       DBusMessageIter iter, array;
+
+       DBG("");
+
+       clients_notify->id = 0;
+
+       signal = dbus_message_new_signal(CONNMAN_MANAGER_PATH,
+                               CONNMAN_MANAGER_INTERFACE, "TetheringClientsChanged");
+       if (!signal)
+               return FALSE;
+
+       dbus_message_iter_init_append(signal, &iter);
+       dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
+                               DBUS_TYPE_STRING_AS_STRING, &array);
+
+       g_hash_table_foreach(clients_table, append_client, &array);
+
+       dbus_message_iter_close_container(&iter, &array);
+
+       dbus_message_iter_init_append(signal, &iter);
+       dbus_message_iter_open_container(&iter, DBUS_TYPE_ARRAY,
+                               DBUS_TYPE_STRING_AS_STRING, &array);
+
+       g_hash_table_foreach(clients_notify->remove, append_client, &array);
+
+       dbus_message_iter_close_container(&iter, &array);
+
+       dbus_connection_send(connection, signal, NULL);
+       dbus_message_unref(signal);
+
+       g_hash_table_remove_all(clients_notify->remove);
+
+       return FALSE;
+}
+
+static void client_schedule_changed(void)
+{
+       if (clients_notify->id != 0)
+               return;
+
+       clients_notify->id = g_timeout_add(100, client_send_changed, NULL);
+}
+
+static void client_added(const char *addr)
+{
+       DBG("client %s", addr);
+
+       g_hash_table_remove(clients_notify->remove, addr);
+
+       client_schedule_changed();
+}
+
+static void client_removed(const char *addr)
+{
+       DBG("client %s", addr);
+
+       g_hash_table_replace(clients_notify->remove, g_strdup(addr), NULL);
+
+       client_schedule_changed();
 }
 
 int __connman_private_network_request(DBusMessage *msg, const char *owner)
 {
        struct connman_private_network *pn;
        char *iface = NULL;
+       char *path = NULL;
        int index, fd, err;
 
-       pn = g_hash_table_lookup(pn_hash, owner);
-       if (pn != NULL)
-               return -EEXIST;
+       if (DBUS_TYPE_UNIX_FD < 0)
+               return -EINVAL;
 
        fd = connman_inet_create_tunnel(&iface);
        if (fd < 0)
                return fd;
 
+       path = g_strdup_printf("/tethering/%s", iface);
+
+       pn = g_hash_table_lookup(pn_hash, path);
+       if (pn) {
+               g_free(path);
+               g_free(iface);
+               close(fd);
+               return -EEXIST;
+       }
+
        index = connman_inet_ifindex(iface);
        if (index < 0) {
                err = -ENODEV;
                goto error;
        }
-       DBG("inteface %s", iface);
+       DBG("interface %s", iface);
 
        err = connman_inet_set_mtu(index, DEFAULT_MTU);
 
        pn = g_try_new0(struct connman_private_network, 1);
-       if (pn == NULL) {
+       if (!pn) {
                err = -ENOMEM;
                goto error;
        }
 
        pn->owner = g_strdup(owner);
+       pn->path = path;
        pn->watch = g_dbus_add_disconnect_watch(connection, pn->owner,
                                        owner_disconnect, pn, NULL);
        pn->msg = msg;
+       pn->reply = dbus_message_new_method_return(pn->msg);
+       if (!pn->reply)
+               goto error;
+
        pn->fd = fd;
        pn->interface = iface;
        pn->index = index;
-       pn->server_ip = PRIVATE_NETWORK_IP;
-       pn->peer_ip = PRIVATE_NETWORK_PEER_IP;
-       pn->primary_dns = PRIVATE_NETWORK_PRIMARY_DNS;
-       pn->secondary_dns = PRIVATE_NETWORK_SECONDARY_DNS;
+       pn->pool = __connman_ippool_create(pn->index, 1, 1, ippool_disconnect, pn);
+       if (!pn->pool) {
+               errno = -ENOMEM;
+               goto error;
+       }
+
+       pn->primary_dns = g_strdup(private_network_primary_dns);
+       pn->secondary_dns = g_strdup(private_network_secondary_dns);
 
        pn->iface_watch = connman_rtnl_add_newlink_watch(index,
                                                setup_tun_interface, pn);
 
-       g_hash_table_insert(pn_hash, pn->owner, pn);
+       g_hash_table_insert(pn_hash, pn->path, pn);
 
        return 0;
 
 error:
        close(fd);
        g_free(iface);
+       g_free(path);
+       if (pn)
+               g_free(pn->owner);
+       g_free(pn);
        return err;
 }
 
-int __connman_private_network_release(const char *owner)
+int __connman_private_network_release(const char *path)
 {
        struct connman_private_network *pn;
 
-       pn = g_hash_table_lookup(pn_hash, owner);
-       if (pn == NULL)
+       pn = g_hash_table_lookup(pn_hash, path);
+       if (!pn)
                return -EACCES;
 
-       g_hash_table_remove(pn_hash, owner);
+       g_hash_table_remove(pn_hash, path);
        return 0;
 }
 
+void __connman_tethering_client_register(const char *addr)
+{
+       g_hash_table_insert(clients_table, g_strdup(addr), NULL);
+       client_added(addr);
+}
+
+void __connman_tethering_client_unregister(const char *addr)
+{
+       client_removed(addr);
+       g_hash_table_remove(clients_table, addr);
+}
+
 int __connman_tethering_init(void)
 {
        DBG("");
@@ -575,29 +648,45 @@ int __connman_tethering_init(void)
        tethering_enabled = 0;
 
        connection = connman_dbus_get_connection();
-       if (connection == NULL)
+       if (!connection)
                return -EFAULT;
 
        pn_hash = g_hash_table_new_full(g_str_hash, g_str_equal,
                                                NULL, remove_private_network);
 
+       clients_table = g_hash_table_new_full(g_str_hash, g_str_equal,
+                                                       g_free, NULL);
+
+       clients_notify = g_new0(struct _clients_notify, 1);
+       clients_notify->remove = g_hash_table_new_full(g_str_hash, g_str_equal,
+                                                       g_free, NULL);
        return 0;
 }
 
 void __connman_tethering_cleanup(void)
 {
-       DBG("");
+       DBG("enabled %d", tethering_enabled);
 
-       if (g_atomic_int_get(&tethering_enabled)) {
+       __sync_synchronize();
+       if (tethering_enabled > 0) {
                if (tethering_dhcp_server)
                        dhcp_server_stop(tethering_dhcp_server);
-               disable_bridge(BRIDGE_NAME);
-               remove_bridge(BRIDGE_NAME);
+               __connman_bridge_disable(BRIDGE_NAME);
+               __connman_bridge_remove(BRIDGE_NAME);
+               __connman_nat_disable(BRIDGE_NAME);
        }
 
-       if (connection == NULL)
+       if (!connection)
                return;
 
        g_hash_table_destroy(pn_hash);
+
+       g_hash_table_destroy(clients_notify->remove);
+       g_free(clients_notify);
+       clients_notify = NULL;
+
+       g_hash_table_destroy(clients_table);
+       clients_table = NULL;
+
        dbus_connection_unref(connection);
 }