common: remove unuseful functions

[platform/core/uifw/libtdm.git] / src / tdm_output.c

diff --git a/src/tdm_output.c b/src/tdm_output.c
index bb2710c..b66c27b 100644 (file)
--- a/src/tdm_output.c
+++ b/src/tdm_output.c
@@ -9,7 +9,7 @@
  *          Taeheon Kim <th908.kim@samsung.com>,
  *          YoungJun Cho <yj44.cho@samsung.com>,
  *          SooChan Lim <sc1.lim@samsung.com>,
- *          Boram Park <sc1.lim@samsung.com>
+ *          Boram Park <boram1288.park@samsung.com>
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
  * copy of this software and associated documentation files (the
@@ -45,7 +45,7 @@
        tdm_private_display *private_display; \
        tdm_private_output *private_output; \
        tdm_error ret = TDM_ERROR_NONE; /* default TDM_ERROR_NONE */\
-       TDM_RETURN_VAL_IF_FAIL(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER); \
+       TDM_RETURN_VAL_IF_FAIL(output != NULL, TDM_ERROR_INVALID_PARAMETER); \
        private_output = (tdm_private_output*)output; \
        private_display = private_output->private_display
 
@@ -53,7 +53,7 @@
        tdm_private_display *private_display; \
        tdm_private_output *private_output; \
        tdm_error ret = TDM_ERROR_NONE; /* default TDM_ERROR_NONE */\
-       TDM_RETURN_VAL_IF_FAIL_WITH_ERROR(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER, NULL); \
+       TDM_RETURN_VAL_IF_FAIL_WITH_ERROR(output != NULL, TDM_ERROR_INVALID_PARAMETER, NULL); \
        private_output = (tdm_private_output*)output; \
        private_display = private_output->private_display
 
@@ -404,7 +404,7 @@ tdm_output_remove_change_handler(tdm_output *output,
        tdm_private_output *private_output;
        tdm_private_output_change_handler *change_handler = NULL, *hh = NULL;
 
-       TDM_RETURN_IF_FAIL(tdm_output_is_valid(output));
+       TDM_RETURN_IF_FAIL(output != NULL);
        TDM_RETURN_IF_FAIL(func != NULL);
 
        private_output = (tdm_private_output*)output;
@@ -1112,7 +1112,7 @@ tdm_output_commit_internal(tdm_output *output, int sync, tdm_output_commit_handl
        tdm_output_dpms dpms_value = TDM_OUTPUT_DPMS_ON;
        tdm_error ret = TDM_ERROR_NONE;
 
-       TDM_RETURN_VAL_IF_FAIL(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER);
+       TDM_RETURN_VAL_IF_FAIL(output != NULL, TDM_ERROR_INVALID_PARAMETER);
 
        private_output = (tdm_private_output*)output;
        private_module = private_output->private_module;
@@ -1160,6 +1160,16 @@ tdm_output_commit_internal(tdm_output *output, int sync, tdm_output_commit_handl
                                output_commit_handler);
                TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, commit_failed);
 
+               if (ret == TDM_ERROR_NONE) {
+                       if (private_output->current_mode &&
+                               private_output->caps.status != TDM_OUTPUT_CONN_STATUS_MODE_SETTED) {
+                               TDM_WRN("backend doesn't change the output connection status");
+                               tdm_output_cb_status(private_output->output_backend,
+                                                                        TDM_OUTPUT_CONN_STATUS_MODE_SETTED,
+                                                                        private_output);
+                       }
+               }
+
                if (tdm_debug_module & TDM_DEBUG_COMMIT)
                        TDM_INFO("output(%d) backend commit: handle(%p) func(%p) user_data(%p)",
                                        private_output->pipe, output_commit_handler, func, user_data);
@@ -1352,8 +1362,8 @@ done:
                if (private_output->current_dpms_value != dpms_value) {
                        private_output->current_dpms_value = dpms_value;
                        _tdm_output_call_thread_cb_dpms(private_output, dpms_value);
-                       TDM_INFO("output(%d) dpms '%s' done", private_output->pipe, tdm_dpms_str(dpms_value));
                }
+               TDM_INFO("output(%d) dpms '%s' done", private_output->pipe, tdm_dpms_str(dpms_value));
        } else {
                tdm_output_dpms temp = TDM_OUTPUT_DPMS_OFF;
 
@@ -1457,7 +1467,7 @@ tdm_output_get_dpms_internal(tdm_output *output, tdm_output_dpms *dpms_value)
        tdm_func_output *func_output;
        tdm_error ret = TDM_ERROR_NONE;
 
-       TDM_RETURN_VAL_IF_FAIL(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER);
+       TDM_RETURN_VAL_IF_FAIL(output != NULL, TDM_ERROR_INVALID_PARAMETER);
 
        private_output = (tdm_private_output*)output;