update caps.status
[platform/core/uifw/libtdm.git] / src / tdm_output.c
index 7449637..63fe459 100644 (file)
 #include "config.h"
 #endif
 
-#include "tdm.h"
-#include "tdm_backend.h"
 #include "tdm_private.h"
-#include "tdm_helper.h"
 
 #define COUNT_MAX   10
 
@@ -48,7 +45,7 @@
        tdm_private_display *private_display; \
        tdm_private_output *private_output; \
        tdm_error ret = TDM_ERROR_NONE; /* default TDM_ERROR_NONE */\
-       TDM_RETURN_VAL_IF_FAIL(output != NULL, TDM_ERROR_INVALID_PARAMETER); \
+       TDM_RETURN_VAL_IF_FAIL(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER); \
        private_output = (tdm_private_output*)output; \
        private_display = private_output->private_display
 
        tdm_private_display *private_display; \
        tdm_private_output *private_output; \
        tdm_error ret = TDM_ERROR_NONE; /* default TDM_ERROR_NONE */\
-       TDM_RETURN_VAL_IF_FAIL_WITH_ERROR(output != NULL, TDM_ERROR_INVALID_PARAMETER, NULL); \
+       TDM_RETURN_VAL_IF_FAIL_WITH_ERROR(tdm_output_is_valid(output), TDM_ERROR_INVALID_PARAMETER, NULL); \
        private_output = (tdm_private_output*)output; \
        private_display = private_output->private_display
 
+static void
+_tdm_output_vblank_timeout_update(tdm_private_output *private_output, int ms_delay);
+
+static tdm_error
+_tdm_output_vblank_timeout_cb(void *user_data)
+{
+       tdm_private_output *private_output = user_data;
+       tdm_private_vblank_handler *v = NULL;
+
+       TDM_RETURN_VAL_IF_FAIL(private_output != NULL, TDM_ERROR_OPERATION_FAILED);
+
+       TDM_ERR("TDM output(%d) vblank TIMEOUT!!", private_output->pipe);
+
+       LIST_FOR_EACH_ENTRY(v, &private_output->vblank_handler_list, link) {
+               TDM_ERR("vblank_handler(%p) interval(%d) sync(%d) sent_to_frontend(%u) owner_tid(%d)",
+                               v, v->interval, v->sync, v->sent_to_frontend, v->owner_tid);
+       }
+
+       return TDM_ERROR_NONE;
+}
+
+INTERN void
+tdm_output_vblank_print_wait_information(tdm_private_output *private_output, void *user_data)
+{
+       tdm_private_vblank_handler *v = NULL;
+
+       TDM_RETURN_IF_FAIL(private_output != NULL);
+       TDM_RETURN_IF_FAIL(user_data != NULL);
+
+       TDM_ERR("TDM output(%d) vblank user_data(%p) info!!", private_output->pipe, user_data);
+
+       LIST_FOR_EACH_ENTRY(v, &private_output->vblank_handler_list, link) {
+               if (v->user_data != user_data)
+                       continue;
+               TDM_ERR("vblank_handler(%p) interval(%d) sync(%d) sent_to_frontend(%u) owner_tid(%d)",
+                               v, v->interval, v->sync, v->sent_to_frontend, v->owner_tid);
+       }
+}
+
+static void
+_tdm_output_vblank_timeout_update(tdm_private_output *private_output, int ms_delay)
+{
+       tdm_error ret;
+
+       if (!private_output->vblank_timeout_timer) {
+               private_output->vblank_timeout_timer =
+                       tdm_event_loop_add_timer_handler(private_output->private_display,
+                                                                                        _tdm_output_vblank_timeout_cb,
+                                                                                        private_output,
+                                                                                        &ret);
+               if (!private_output->vblank_timeout_timer) {
+                       TDM_ERR("output(%d) couldn't add timer", private_output->pipe);
+                       return;
+               }
+               TDM_INFO("output(%d) create vblank timeout timer", private_output->pipe);
+       }
+
+       ret = tdm_event_loop_source_timer_update(private_output->vblank_timeout_timer, ms_delay);
+       if (ret != TDM_ERROR_NONE) {
+               TDM_ERR("output(%d) couldn't update timer", private_output->pipe);
+               return;
+       }
+}
 
 static tdm_private_hwc_window *
 _tdm_output_find_private_hwc_window(tdm_private_output *private_output,
@@ -163,6 +223,7 @@ tdm_output_cb_status(tdm_output *output_backend, tdm_output_conn_status status,
                TDM_INFO("output(%d) %s", private_output->pipe, tdm_status_str(status));
 
                _tdm_output_update(output_backend, user_data);
+               private_output->caps.status = status;
 
                output_status.base.type = TDM_THREAD_CB_OUTPUT_STATUS;
                output_status.base.length = sizeof output_status;
@@ -186,6 +247,7 @@ tdm_output_cb_status(tdm_output *output_backend, tdm_output_conn_status status,
 
        if (!tdm_thread_is_running())
                _tdm_output_update(output_backend, user_data);
+       private_output->caps.status = status;
 
        value.u32 = status;
        tdm_output_call_change_handler_internal(private_output,
@@ -205,7 +267,7 @@ tdm_output_add_change_handler(tdm_output *output,
 
        TDM_RETURN_VAL_IF_FAIL(func != NULL, TDM_ERROR_INVALID_PARAMETER);
 
-       pthread_mutex_lock(&private_display->lock);
+       _pthread_mutex_lock(&private_display->lock);
 
        change_handler = calloc(1, sizeof(tdm_private_change_handler));
        if (!change_handler) {
@@ -240,7 +302,7 @@ tdm_output_remove_change_handler(tdm_output *output,
        tdm_private_output *private_output;
        tdm_private_change_handler *h = NULL, *hh = NULL;
 
-       TDM_RETURN_IF_FAIL(output != NULL);
+       TDM_RETURN_IF_FAIL(tdm_output_is_valid(output));
        TDM_RETURN_IF_FAIL(func != NULL);
 
        private_output = (tdm_private_output*)output;
@@ -605,6 +667,8 @@ tdm_output_cb_vblank(tdm_output *output_backend, unsigned int sequence,
                tdm_thread_cb_output_vblank output_vblank;
                tdm_error ret;
 
+               vblank_handler->sent_to_frontend = 1;
+
                output_vblank.base.type = TDM_THREAD_CB_OUTPUT_VBLANK;
                output_vblank.base.length = sizeof output_vblank;
                output_vblank.output_stamp = vblank_handler->private_output->stamp;
@@ -619,6 +683,10 @@ tdm_output_cb_vblank(tdm_output *output_backend, unsigned int sequence,
                return;
        }
 
+       vblank_handler->sent_to_frontend = 0;
+
+       _tdm_output_vblank_timeout_update(private_output, 0);
+
        if (vblank_handler->owner_tid != tid)
                TDM_NEVER_GET_HERE();
 
@@ -790,6 +858,8 @@ _tdm_output_wait_vblank(tdm_output *output, int interval, int sync,
                                                                                          sync, vblank_handler);
                TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, wait_failed);
 
+               _tdm_output_vblank_timeout_update(private_output, 1000);
+
                if (tdm_debug_module & TDM_DEBUG_COMMIT)
                        TDM_INFO("output(%d) backend wait_vblank", private_output->pipe);
        }
@@ -814,7 +884,7 @@ tdm_output_wait_vblank(tdm_output *output, int interval, int sync,
 
        _pthread_mutex_lock(&private_display->lock);
 
-       if (private_output->current_dpms_value > TDM_OUTPUT_DPMS_ON) {
+       if (TDM_OUTPUT_DPMS_VSYNC_IS_OFF(private_output->current_dpms_value)) {
                TDM_WRN("output(%d) dpms: %s", private_output->pipe,
                                tdm_dpms_str(private_output->current_dpms_value));
                _pthread_mutex_unlock(&private_display->lock);
@@ -837,7 +907,7 @@ tdm_output_wait_vblank_add_front(tdm_output *output, int interval, int sync,
 
        _pthread_mutex_lock(&private_display->lock);
 
-       if (private_output->current_dpms_value > TDM_OUTPUT_DPMS_ON) {
+       if (TDM_OUTPUT_DPMS_VSYNC_IS_OFF(private_output->current_dpms_value)) {
                TDM_WRN("output(%d) dpms: %s", private_output->pipe,
                                tdm_dpms_str(private_output->current_dpms_value));
                _pthread_mutex_unlock(&private_display->lock);
@@ -940,7 +1010,7 @@ tdm_output_commit_internal(tdm_output *output, int sync, tdm_output_commit_handl
        ret = tdm_output_get_dpms_internal(output, &dpms_value);
        TDM_RETURN_VAL_IF_FAIL(ret == TDM_ERROR_NONE, ret);
 
-       if (dpms_value == TDM_OUTPUT_DPMS_ON) {
+       if (!TDM_OUTPUT_DPMS_VSYNC_IS_OFF(dpms_value)) {
                if (func) {
                        if (!private_output->regist_commit_cb) {
                                private_output->regist_commit_cb = 1;
@@ -988,8 +1058,8 @@ tdm_output_commit_internal(tdm_output *output, int sync, tdm_output_commit_handl
                                         private_layer->committed_buffer->buffer);
        }
 
-       if (dpms_value != TDM_OUTPUT_DPMS_ON) {
-               TDM_WRN("TDM_OUTPUT_DPMS_OFF. Directly call commit handler instead of commit.");
+       if (TDM_OUTPUT_DPMS_VSYNC_IS_OFF(dpms_value)) {
+               TDM_WRN("dpms %s. Directly call commit handler instead of commit.", tdm_dpms_str(dpms_value));
                if (func)
                        func(output, 0, 0, 0, user_data);
        }
@@ -1030,7 +1100,7 @@ tdm_output_commit(tdm_output *output, int sync, tdm_output_commit_handler func,
                return TDM_ERROR_BAD_REQUEST;
        }
 
-       if (private_output->current_dpms_value > TDM_OUTPUT_DPMS_ON) {
+       if (TDM_OUTPUT_DPMS_VSYNC_IS_OFF(private_output->current_dpms_value)) {
                TDM_ERR("output(%d) dpms: %s", private_output->pipe,
                                tdm_dpms_str(private_output->current_dpms_value));
                _pthread_mutex_unlock(&private_display->lock);
@@ -1114,6 +1184,45 @@ _tdm_output_dpms_changed_timeout(void *user_data)
        return TDM_ERROR_NONE;
 }
 
+static tdm_error
+tdm_output_call_dpms_change_handler(tdm_output *output)
+{
+       tdm_private_output *private_output = (tdm_private_output*)output;
+       tdm_value value;
+
+       /** Use timer to call the output change callback of the sub-thread.
+        * The output change callback of tdm_server and tdm_vblank was called
+        * in the main thread. And it made the multi thread issue. If we use
+        * the timer, we can call the sub-thread's output change callback in
+        * sub-thread.
+        */
+       if (!private_output->dpms_changed_timer) {
+               private_output->dpms_changed_timer =
+                       tdm_event_loop_add_timer_handler(private_output->private_display,
+                                                                                        _tdm_output_dpms_changed_timeout, private_output, NULL);
+               if (!private_output->dpms_changed_timer) {
+                       /* LCOV_EXCL_START */
+                       TDM_ERR("can't create dpms timer!!");
+                       return TDM_ERROR_OUT_OF_MEMORY;
+                       /* LCOV_EXCL_STOP */
+               }
+       }
+
+       value.u32 = private_output->current_dpms_value;
+       tdm_output_call_change_handler_internal(private_output,
+                                                                                       &private_output->change_handler_list_main,
+                                                                                       TDM_OUTPUT_CHANGE_DPMS,
+                                                                                       value, 0);
+
+       if (!LIST_IS_EMPTY(&private_output->change_handler_list_sub)) {
+               tdm_error ret = tdm_event_loop_source_timer_update(private_output->dpms_changed_timer, 1);
+               if (ret != TDM_ERROR_NONE)
+                       TDM_NEVER_GET_HERE();
+       }
+
+       return TDM_ERROR_NONE;
+}
+
 /* LCOV_EXCL_START */
 INTERN void
 tdm_output_cb_dpms(tdm_output *output_backend, tdm_output_dpms dpms, void *user_data)
@@ -1170,8 +1279,18 @@ tdm_output_set_dpms(tdm_output *output, tdm_output_dpms dpms_value)
        tdm_func_output *func_output;
        OUTPUT_FUNC_ENTRY();
 
-       if (dpms_value > TDM_OUTPUT_DPMS_OFF)
-               dpms_value = TDM_OUTPUT_DPMS_OFF;
+       if (dpms_value > TDM_OUTPUT_DPMS_OFF) {
+               if (dpms_value & TDM_OUTPUT_DPMS_DEFAULT_MASK) {
+                       TDM_ERR("Don't use the low-4bit for an extended DPMS mode: dpms_value(%x)", dpms_value);
+                       return TDM_ERROR_BAD_REQUEST;
+               }
+
+               if (!(private_output->caps.capabilities & TDM_OUTPUT_CAPABILITY_EXTENDED_DPMS)) {
+                       TDM_ERR("output(%d) doesn't support the extended DPMS control: '%s'",
+                                       private_output->pipe, tdm_dpms_str(dpms_value));
+                       return TDM_ERROR_BAD_REQUEST;
+               }
+       }
 
        _pthread_mutex_lock(&private_display->lock);
 
@@ -1181,30 +1300,6 @@ tdm_output_set_dpms(tdm_output *output, tdm_output_dpms dpms_value)
                return TDM_ERROR_BAD_REQUEST;
        }
 
-       if (private_output->current_dpms_value == dpms_value) {
-               _pthread_mutex_unlock(&private_display->lock);
-               return TDM_ERROR_NONE;
-       }
-
-       /** Use timer to call the output change callback of the sub-thread.
-        * The output change callback of tdm_server and tdm_vblank was called
-        * in the main thread. And it made the multi thread issue. If we use
-        * the timer, we can call the sub-thread's output change callback in
-        * sub-thread.
-        */
-       if (!private_output->dpms_changed_timer) {
-               private_output->dpms_changed_timer =
-                       tdm_event_loop_add_timer_handler(private_output->private_display,
-                                                                                        _tdm_output_dpms_changed_timeout, private_output, NULL);
-               if (!private_output->dpms_changed_timer) {
-                       /* LCOV_EXCL_START */
-                       TDM_ERR("can't create dpms timer!!");
-                       _pthread_mutex_unlock(&private_display->lock);
-                       return TDM_ERROR_OUT_OF_MEMORY;
-                       /* LCOV_EXCL_STOP */
-               }
-       }
-
        func_output = &private_display->func_output;
 
        TDM_INFO("output(%d) dpms '%s'", private_output->pipe, tdm_dpms_str(dpms_value));
@@ -1221,22 +1316,18 @@ tdm_output_set_dpms(tdm_output *output, tdm_output_dpms dpms_value)
 
 done:
        if (ret == TDM_ERROR_NONE) {
-               tdm_value value;
+               if (private_output->current_dpms_value != dpms_value) {
+                       private_output->current_dpms_value = dpms_value;
+                       TDM_INFO("output(%d) dpms '%s' done", private_output->pipe, tdm_dpms_str(dpms_value));
+                       tdm_output_call_dpms_change_handler(output);
+               }
+       } else {
+               tdm_output_dpms temp = TDM_OUTPUT_DPMS_OFF;
 
-               private_output->current_dpms_value = dpms_value;
-               TDM_INFO("output(%d) dpms '%s' done", private_output->pipe, tdm_dpms_str(dpms_value));
+               /* update current_dpms_value forcely */
+               tdm_output_get_dpms_internal(output, &temp);
 
-               value.u32 = dpms_value;
-               tdm_output_call_change_handler_internal(private_output,
-                                                                                               &private_output->change_handler_list_main,
-                                                                                               TDM_OUTPUT_CHANGE_DPMS,
-                                                                                               value, 0);
-
-               if (!LIST_IS_EMPTY(&private_output->change_handler_list_sub)) {
-                       ret = tdm_event_loop_source_timer_update(private_output->dpms_changed_timer, 1);
-                       if (ret != TDM_ERROR_NONE)
-                               TDM_NEVER_GET_HERE();
-               }
+               TDM_ERR("output(%d) set_dpms failed: dpms '%s'", private_output->pipe, tdm_dpms_str(temp));
        }
 
        _pthread_mutex_unlock(&private_display->lock);
@@ -1256,8 +1347,18 @@ tdm_output_set_dpms_async(tdm_output *output, tdm_output_dpms dpms_value)
                return TDM_ERROR_BAD_REQUEST;
        }
 
-       if (dpms_value > TDM_OUTPUT_DPMS_OFF)
-               dpms_value = TDM_OUTPUT_DPMS_OFF;
+       if (dpms_value > TDM_OUTPUT_DPMS_OFF) {
+               if (dpms_value & TDM_OUTPUT_DPMS_DEFAULT_MASK) {
+                       TDM_ERR("Don't use the low-4bit for an extended DPMS mode: dpms_value(%x)", dpms_value);
+                       return TDM_ERROR_BAD_REQUEST;
+               }
+
+               if (!(private_output->caps.capabilities & TDM_OUTPUT_CAPABILITY_EXTENDED_DPMS)) {
+                       TDM_ERR("output(%d) doesn't support the extended DPMS control: '%s'",
+                                       private_output->pipe, tdm_dpms_str(dpms_value));
+                       return TDM_ERROR_BAD_REQUEST;
+               }
+       }
 
        _pthread_mutex_lock(&private_display->lock);
 
@@ -1267,11 +1368,6 @@ tdm_output_set_dpms_async(tdm_output *output, tdm_output_dpms dpms_value)
                return TDM_ERROR_BAD_REQUEST;
        }
 
-       if (private_output->current_dpms_value == dpms_value) {
-               _pthread_mutex_unlock(&private_display->lock);
-               return TDM_ERROR_NONE;
-       }
-
        func_output = &private_display->func_output;
        if (!func_output->output_set_dpms_handler) {
                TDM_ERR("not implemented: output_set_dpms_handler");
@@ -1303,6 +1399,13 @@ tdm_output_set_dpms_async(tdm_output *output, tdm_output_dpms dpms_value)
        if (ret == TDM_ERROR_NONE) {
                private_output->waiting_dpms_change = 1;
                TDM_INFO("output(%d) dpms async '%s' waiting", private_output->pipe, tdm_dpms_str(dpms_value));
+       } else {
+               tdm_output_dpms temp = TDM_OUTPUT_DPMS_OFF;
+
+               /* update current_dpms_value forcely */
+               tdm_output_get_dpms_internal(output, &temp);
+
+               TDM_ERR("output(%d) set_dpms_async failed: dpms '%s'", private_output->pipe, tdm_dpms_str(temp));
        }
 
        _pthread_mutex_unlock(&private_display->lock);
@@ -1347,13 +1450,14 @@ tdm_output_get_dpms_internal(tdm_output *output, tdm_output_dpms *dpms_value)
                /* LCOV_EXCL_STOP */
        }
 
-       /* TODO: this is ugly. But we have to check if all backends's DPMS operation has no problem. */
-       if (private_output->commit_per_vblank)
-               if (*dpms_value != private_output->current_dpms_value) {
-                       private_output->current_dpms_value = *dpms_value;
-                       TDM_ERR("output(%d) dpms changed suddenly: %s",
-                                       private_output->pipe, tdm_dpms_str(*dpms_value));
-               }
+       /* checking with backend's value */
+       if (*dpms_value != private_output->current_dpms_value) {
+               TDM_ERR("output(%d) dpms changed suddenly: %s -> %s",
+                               private_output->pipe, private_output->current_dpms_value,
+                               tdm_dpms_str(*dpms_value));
+               private_output->current_dpms_value = *dpms_value;
+               tdm_output_call_dpms_change_handler(output);
+       }
 
        return ret;
 }
@@ -1400,7 +1504,31 @@ tdm_output_hwc_create_window(tdm_output *output, tdm_error *error)
        _pthread_mutex_lock(&private_display->lock);
 
        if (private_output->caps.capabilities & TDM_OUTPUT_CAPABILITY_HWC)
-               hwc_window = (tdm_hwc_window *)tdm_hwc_window_create_internal(private_output, error);
+               hwc_window = (tdm_hwc_window *)tdm_hwc_window_create_internal(private_output, 0, error);
+       else {
+               /* LCOV_EXCL_START */
+               TDM_ERR("output(%p) not support HWC", private_output);
+               if (error)
+                       *error = TDM_ERROR_BAD_REQUEST;
+               /* LCOV_EXCL_STOP */
+       }
+
+       _pthread_mutex_unlock(&private_display->lock);
+
+       return hwc_window;
+}
+
+EXTERN tdm_hwc_window *
+tdm_output_hwc_create_video_window(tdm_output *output, tdm_error *error)
+{
+       tdm_hwc_window *hwc_window = NULL;
+
+       OUTPUT_FUNC_ENTRY_ERROR();
+
+       _pthread_mutex_lock(&private_display->lock);
+
+       if (private_output->caps.capabilities & TDM_OUTPUT_CAPABILITY_HWC)
+               hwc_window = (tdm_hwc_window *)tdm_hwc_window_create_internal(private_output, 1, error);
        else {
                /* LCOV_EXCL_START */
                TDM_ERR("output(%p) not support HWC", private_output);
@@ -1431,9 +1559,13 @@ tdm_output_hwc_destroy_window(tdm_output *output, tdm_hwc_window *hwc_window)
 }
 
 EXTERN tdm_error
-tdm_output_hwc_validate(tdm_output *output, uint32_t *num_types)
+tdm_output_hwc_validate(tdm_output *output, tdm_hwc_window **composited_wnds,
+                                                                       uint32_t num_wnds, uint32_t *num_types)
 {
        tdm_func_output *func_output = NULL;
+       tdm_private_hwc_window **composited_wnds_frontend = NULL;
+       tdm_hwc_window **composited_wnds_backend = NULL;
+       int i;
 
        OUTPUT_FUNC_ENTRY();
 
@@ -1457,7 +1589,30 @@ tdm_output_hwc_validate(tdm_output *output, uint32_t *num_types)
                /* LCOV_EXCL_STOP */
        }
 
-       ret = func_output->output_hwc_validate(private_output->output_backend, num_types);
+       if (num_wnds == 0) {
+               ret = func_output->output_hwc_validate(private_output->output_backend, NULL, 0, num_types);
+
+               _pthread_mutex_unlock(&private_display->lock);
+
+               return ret;
+       }
+
+       composited_wnds_backend = calloc(num_wnds, sizeof(tdm_hwc_window *));
+       if (!composited_wnds_backend) {
+               /* LCOV_EXCL_START */
+               _pthread_mutex_unlock(&private_display->lock);
+               return TDM_ERROR_OUT_OF_MEMORY;
+               /* LCOV_EXCL_STOP */
+       }
+
+       composited_wnds_frontend = (tdm_private_hwc_window **)composited_wnds;
+
+       for (i = 0; i < num_wnds; i++)
+               composited_wnds_backend[i] = composited_wnds_frontend[i]->hwc_window_backend;
+
+       ret = func_output->output_hwc_validate(private_output->output_backend, composited_wnds_backend, num_wnds, num_types);
+
+       free(composited_wnds_backend);
 
        _pthread_mutex_unlock(&private_display->lock);
 
@@ -1629,27 +1784,8 @@ tdm_output_hwc_get_target_buffer_queue(tdm_output *output, tdm_error *error)
        return queue;
 }
 
-/* LCOV_EXCL_START */
-static void
-_tdm_target_window_dump_buffer(tdm_private_output *private_output, tbm_surface_h buffer)
-{
-       unsigned int pipe;
-       char fname[PATH_MAX];
-
-       pipe = private_output->pipe;
-
-       snprintf(fname, sizeof(fname), "tdm_%d_target_win", pipe);
-
-       tbm_surface_internal_dump_buffer(buffer, fname);
-       TDM_DBG("%s dump excute", fname);
-
-       return;
-}
-/* LCOV_EXCL_STOP */
-
 EXTERN tdm_error
-tdm_output_hwc_set_client_target_buffer(tdm_output *output, tbm_surface_h target_buffer,
-                                                                       tdm_hwc_region damage)
+tdm_output_hwc_set_client_target_buffer(tdm_output *output, tbm_surface_h target_buffer, tdm_hwc_region damage)
 {
        tdm_func_output *func_output = NULL;
 
@@ -1683,12 +1819,6 @@ tdm_output_hwc_set_client_target_buffer(tdm_output *output, tbm_surface_h target
                /* LCOV_EXCL_STOP */
        }
 
-       /* dump buffer */
-       if (tdm_dump_enable)
-       /* LCOV_EXCL_START */
-               _tdm_target_window_dump_buffer((tdm_private_output *)output, target_buffer);
-       /* LCOV_EXCL_STOP */
-
        ret = func_output->output_hwc_set_client_target_buffer(private_output->output_backend, target_buffer, damage);
 
        _pthread_mutex_unlock(&private_display->lock);
@@ -1696,6 +1826,36 @@ tdm_output_hwc_set_client_target_buffer(tdm_output *output, tbm_surface_h target
        return ret;
 }
 
+tdm_error
+tdm_output_hwc_get_video_supported_formats(tdm_output *output, const tbm_format **formats,
+                                                               int *count)
+{
+       tdm_func_output *func_output;
+       OUTPUT_FUNC_ENTRY();
+
+       TDM_RETURN_VAL_IF_FAIL(formats != NULL, TDM_ERROR_INVALID_PARAMETER);
+       TDM_RETURN_VAL_IF_FAIL(count != NULL, TDM_ERROR_INVALID_PARAMETER);
+
+       _pthread_mutex_lock(&private_display->lock);
+
+       func_output = &private_display->func_output;
+
+       if (!func_output->output_hwc_get_video_supported_formats) {
+               /* LCOV_EXCL_START */
+               _pthread_mutex_unlock(&private_display->lock);
+               TDM_ERR("not implemented!!");
+               return TDM_ERROR_NOT_IMPLEMENTED;
+               /* LCOV_EXCL_STOP */
+       }
+
+       ret = func_output->output_hwc_get_video_supported_formats(
+                                                               private_output->output_backend, formats, count);
+
+       _pthread_mutex_unlock(&private_display->lock);
+
+       return ret;
+}
+
 INTERN void
 tdm_output_call_change_handler_internal(tdm_private_output *private_output,
                                                                                struct list_head *change_handler_list,
@@ -1733,6 +1893,30 @@ tdm_output_call_change_handler_internal(tdm_private_output *private_output,
        }
 }
 
+static int
+_is_hwc_output_still_existed(tdm_private_output *private_output)
+{
+       tdm_private_display *dpy;
+       tdm_private_output *o = NULL;
+
+       dpy = tdm_display_init(NULL);
+       TDM_RETURN_VAL_IF_FAIL(dpy != NULL, TDM_ERROR_OPERATION_FAILED);
+
+       LIST_FOR_EACH_ENTRY(o, &dpy->output_list, link) {
+               if (!(o->caps.capabilities & TDM_OUTPUT_CAPABILITY_HWC))
+                       continue;
+
+               if (o == private_output)
+                       goto exist;
+       }
+
+       tdm_display_deinit(dpy);
+       return 0;
+
+exist:
+       tdm_display_deinit(dpy);
+       return 1;
+}
 
 /* gets called on behalf of the ecore-main-loop thread */
 INTERN tdm_error
@@ -1740,6 +1924,11 @@ tdm_output_cb_need_validate(tdm_private_output *private_output)
 {
        TDM_RETURN_VAL_IF_FAIL(private_output != NULL, TDM_ERROR_INVALID_PARAMETER);
 
+       /* as we get 'private_output' within an event, an output this 'private_output'
+        * points to can be destroyed already */
+       if (!_is_hwc_output_still_existed(private_output))
+               return TDM_ERROR_NONE;
+
        TDM_INFO("tdm-backend asks for revalidation for the output:%p.", private_output);
 
        if (private_output->need_validate.hndl)
@@ -1755,9 +1944,15 @@ _need_validate_handler(int fd, tdm_event_loop_mask mask, void *user_data)
        tdm_thread_cb_need_validate ev;
        tdm_private_output *private_output;
        tdm_error ret;
+       uint64_t value;
 
        private_output = (tdm_private_output *)user_data;
 
+       if (read(private_output->need_validate.event_fd, &value, sizeof(value)) < 0) {
+               TDM_ERR("error while trying to read from a need_validate.event_fd fd.");
+               return TDM_ERROR_OPERATION_FAILED;
+       }
+
        ev.base.type = TDM_THREAD_CB_NEED_VALIDATE;
        ev.base.length = sizeof ev;
        ev.o = private_output;
@@ -1789,8 +1984,8 @@ tdm_output_need_validate_event_init(tdm_output *output)
        fd = eventfd(0, 0);
        TDM_WARNING_IF_FAIL(fd >= 0);
 
-       tdm_event_loop_add_fd_handler(private_display, fd,      TDM_EVENT_LOOP_READABLE,
-                       _need_validate_handler, private_output, &ret);
+       private_output->need_validate.event_source = tdm_event_loop_add_fd_handler(private_display,
+                       fd,     TDM_EVENT_LOOP_READABLE, _need_validate_handler, private_output, &ret);
        TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE);
 
        private_output->need_validate.event_fd = fd;