tdm: execute memset before getting pp capability

[platform/core/uifw/libtdm.git] / src / tdm.c

diff --git a/src/tdm.c b/src/tdm.c
index 6208859..ad98191 100644 (file)
--- a/src/tdm.c
+++ b/src/tdm.c
@@ -262,6 +262,7 @@ tdm_display_destroy_private_output(tdm_private_output *private_output)
        tdm_private_output_change_handler *h = NULL, *hh = NULL;
        tdm_private_output_destroy_handler *dh = NULL, *dhh = NULL;
        tdm_error ret;
+       int mutex_locked = 0;
 
        ret = tdm_output_call_thread_cb_destroy(private_output);
        TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE);
@@ -312,18 +313,19 @@ tdm_display_destroy_private_output(tdm_private_output *private_output)
                free(dh);
        }
 
+       if (tdm_thread_is_running() && TDM_MUTEX_IS_LOCKED()) mutex_locked = 1;
        if (private_output->vblank) {
                /* tdm_vblank APIs is for server. it should be called in unlock status*/
-               _pthread_mutex_unlock(&private_display->lock);
+               if (mutex_locked) _pthread_mutex_unlock(&private_display->lock);
                tdm_vblank_destroy(private_output->vblank);
-               _pthread_mutex_lock(&private_display->lock);
+               if (mutex_locked) _pthread_mutex_lock(&private_display->lock);
        }
 
        if (private_output->ttrace_vblank) {
                /* tdm_vblank APIs is for server. it should be called in unlock status*/
-               _pthread_mutex_unlock(&private_display->lock);
+               if (mutex_locked) _pthread_mutex_unlock(&private_display->lock);
                tdm_vblank_destroy(private_output->ttrace_vblank);
-               _pthread_mutex_lock(&private_display->lock);
+               if (mutex_locked) _pthread_mutex_lock(&private_display->lock);
        }
 
        LIST_FOR_EACH_ENTRY_SAFE(c, cc, &private_output->capture_list, link)
@@ -333,6 +335,8 @@ tdm_display_destroy_private_output(tdm_private_output *private_output)
                private_hwc = private_output->private_hwc;
                LIST_FOR_EACH_ENTRY_SAFE(hw, hww, &private_hwc->hwc_window_list, link)
                        tdm_hwc_window_destroy_internal(hw);
+               if (private_hwc->display_target_buffer)
+                       tbm_surface_internal_unref(private_hwc->display_target_buffer);
                free(private_hwc);
        } else {
                LIST_FOR_EACH_ENTRY_SAFE(l, ll, &private_output->layer_list, link)
@@ -400,6 +404,8 @@ _tdm_display_update_caps_pp(tdm_private_module *private_module, tdm_caps_pp *cap
                return TDM_ERROR_BAD_MODULE;
        }
 
+       memset(caps, 0, sizeof(tdm_caps_pp));
+
        ret = func_display->display_get_pp_capability(private_module->bdata, caps);
        if (ret != TDM_ERROR_NONE) {
                TDM_ERR("backend(%s) display_get_pp_capability() failed", private_module->module_data->name);
@@ -801,7 +807,7 @@ _tdm_display_setup(tdm_private_display *private_display)
                tdm_output **outputs;
                int i, count = 0;
 
-               TDM_INFO("loading a %s backend", TDM_DUMMY_MODULE);
+               TDM_INIT_INFO("loading a %s backend", TDM_DUMMY_MODULE);
                ret = _tdm_display_load_module_with_file(private_display, TDM_DUMMY_MODULE);
                TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, failed_update);
                TDM_GOTO_IF_FAIL(private_display->dummy_module != NULL, failed_update);
@@ -821,7 +827,7 @@ _tdm_display_setup(tdm_private_display *private_display)
 
        virtual = tdm_config_get_int(TDM_CONFIG_KEY_GENERAL_VIRTUAL_OUTPUT, 0);
        if (virtual) {
-               TDM_INFO("loading a %s backend", TDM_VIRTUAL_MODULE);
+               TDM_INIT_INFO("loading a %s backend", TDM_VIRTUAL_MODULE);
                ret = _tdm_display_load_module_with_file(private_display, TDM_VIRTUAL_MODULE);
                TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, failed_update);
                TDM_GOTO_IF_FAIL(private_display->virtual_module != NULL, failed_update);
@@ -1000,7 +1006,7 @@ _tdm_display_load_module_with_file(tdm_private_display *private_display,
        if (!module) {
                TDM_ERR("%s", dlerror());
                TDM_TRACE_END();
-               ret = TDM_ERROR_BAD_MODULE;
+               ret = TDM_ERROR_NO_MODULE;
                goto failed_load;
        }
 
@@ -1031,7 +1037,9 @@ _tdm_display_load_module_with_file(tdm_private_display *private_display,
        /* We don't care if backend_data is NULL or not. It's up to backend. */
        TDM_TRACE_BEGIN("TDM_Init_Backend");
        stamp = tdm_helper_get_time();
+       TDM_INIT_INFO("init backend");
        bdata = module_data->init((tdm_display *)private_display, &ret);
+       TDM_INIT_INFO("init backend done");
        TDM_DBG("backend init() time: %.3f ms", (tdm_helper_get_time() - stamp) * 1000.0);
        TDM_TRACE_END();
 
@@ -1063,7 +1071,7 @@ _tdm_display_load_module_with_file(tdm_private_display *private_display,
 
        LIST_ADDTAIL(&private_module->link, &private_display->module_list);
 
-       TDM_INFO("Success to load '%s' module", module_data->name);
+       TDM_INIT_INFO("Success to load '%s' module", module_data->name);
 
        return TDM_ERROR_NONE;
 failed_load:
@@ -1093,12 +1101,12 @@ _tdm_display_load_modules(tdm_private_display *private_display)
 
        arg = strtok_r(temp, TDM_CONFIG_DELIM, &end);
        while (arg) {
-               TDM_INFO("loading a %s backend", arg);
+               TDM_INIT_INFO("loading a %s backend", arg);
                ret = _tdm_display_load_module_with_file(private_display, arg);
                if (ret == TDM_ERROR_NONE)
-                       TDM_INFO("%s backend loading success", arg);
+                       TDM_INIT_INFO("%s backend loading success", arg);
                else
-                       TDM_INFO("%s backend loading failed", arg);
+                       TDM_INIT_INFO("%s backend loading failed", arg);
                arg = strtok_r(NULL, TDM_CONFIG_DELIM, &end);
        }
 
@@ -1190,7 +1198,7 @@ tdm_display_init(tdm_error *error)
                goto failed_event;
 
        stamp2 = tdm_helper_get_time();
-       TDM_INFO("event loop init time: %.3f ms", (stamp2 - stamp1) * 1000.0);
+       TDM_INIT_INFO("event loop init time: %.3f ms", (stamp2 - stamp1) * 1000.0);
        stamp1 = stamp2;
 
        ret = tdm_vblank_init(private_display);
@@ -1214,11 +1222,11 @@ tdm_display_init(tdm_error *error)
                goto failed_load;
 
        ret = _tdm_display_load_modules(private_display);
-       if (ret != TDM_ERROR_NONE)
+       if (!(ret == TDM_ERROR_NONE || ret == TDM_ERROR_NO_MODULE))
                goto failed_load;
 
        stamp2 = tdm_helper_get_time();
-       TDM_INFO("loading backend time: %.3f ms", (stamp2 - stamp1) * 1000.0);
+       TDM_INIT_INFO("loading backend time: %.3f ms", (stamp2 - stamp1) * 1000.0);
        stamp1 = stamp2;
 
 #ifdef INIT_BUFMGR
@@ -1241,6 +1249,7 @@ tdm_display_init(tdm_error *error)
 
        TDM_TRACE_BEGIN("TDM_Update_Display");
        ret = _tdm_display_setup(private_display);
+       TDM_INIT_INFO("updating display");
        TDM_TRACE_END();
        if (ret != TDM_ERROR_NONE)
                goto failed_update;
@@ -1280,7 +1289,7 @@ tdm_display_init(tdm_error *error)
        _pthread_mutex_unlock(&private_display->lock);
        pthread_mutex_unlock(&gLock);
 
-       TDM_INFO("init time: %.3f ms", (tdm_helper_get_time() - start) * 1000.0);
+       TDM_INIT_INFO("init time: %.3f ms", (tdm_helper_get_time() - start) * 1000.0);
 
        return (tdm_display *)private_display;