avoid dereference null, fix memory leak
[platform/core/uifw/libtdm.git] / src / tdm.c
index 5597bca..3f6388c 100644 (file)
--- a/src/tdm.c
+++ b/src/tdm.c
@@ -222,11 +222,6 @@ _tdm_display_update_caps_pp(tdm_private_display *private_display,
                                                        tdm_caps_pp *caps)
 {
        tdm_func_display *func_display = &private_display->func_display;
-       char buf[1024];
-       int bufsize = sizeof(buf);
-       char *str_buf = buf;
-       int *len_buf = &bufsize;
-       int i;
        tdm_error ret;
 
        if (!(private_display->capabilities & TDM_DISPLAY_CAPABILITY_PP))
@@ -243,15 +238,6 @@ _tdm_display_update_caps_pp(tdm_private_display *private_display,
                return TDM_ERROR_BAD_MODULE;
        }
 
-       TDM_DBG("pp capabilities: %x", caps->capabilities);
-       buf[0] = '\0';
-       for (i = 0; i < caps->format_count; i++)
-               TDM_SNPRINTF(str_buf, len_buf, "%c%c%c%c ", FOURCC_STR(caps->formats[i]));
-       TDM_DBG("pp formats: %s", buf);
-       TDM_DBG("pp min  : %dx%d", caps->min_w, caps->min_h);
-       TDM_DBG("pp max  : %dx%d", caps->max_w, caps->max_h);
-       TDM_DBG("pp align: %d", caps->preferred_align);
-
        return TDM_ERROR_NONE;
 }
 
@@ -260,11 +246,6 @@ _tdm_display_update_caps_capture(tdm_private_display *private_display,
                                                                 tdm_caps_capture *caps)
 {
        tdm_func_display *func_display = &private_display->func_display;
-       char buf[1024];
-       int bufsize = sizeof(buf);
-       char *str_buf = buf;
-       int *len_buf = &bufsize;
-       int i;
        tdm_error ret;
 
        if (!(private_display->capabilities & TDM_DISPLAY_CAPABILITY_CAPTURE))
@@ -281,11 +262,6 @@ _tdm_display_update_caps_capture(tdm_private_display *private_display,
                return TDM_ERROR_BAD_MODULE;
        }
 
-       buf[0] = '\0';
-       for (i = 0; i < caps->format_count; i++)
-               TDM_SNPRINTF(str_buf, len_buf, "%c%c%c%c ", FOURCC_STR(caps->formats[i]));
-       TDM_DBG("capture formats: %s", buf);
-
        return TDM_ERROR_NONE;
 }
 
@@ -294,11 +270,6 @@ _tdm_display_update_caps_layer(tdm_private_display *private_display,
                                                           tdm_layer *layer_backend, tdm_caps_layer *caps)
 {
        tdm_func_layer *func_layer = &private_display->func_layer;
-       char buf[1024];
-       int bufsize = sizeof(buf);
-       char *str_buf = buf;
-       int *len_buf = &bufsize;
-       int i;
        tdm_error ret;
 
        if (!func_layer->layer_get_capability) {
@@ -312,15 +283,6 @@ _tdm_display_update_caps_layer(tdm_private_display *private_display,
                return TDM_ERROR_BAD_MODULE;
        }
 
-       TDM_DBG("layer capabilities: %x", caps->capabilities);
-       TDM_DBG("layer zpos : %d", caps->zpos);
-       buf[0] = '\0';
-       for (i = 0; i < caps->format_count; i++)
-               TDM_SNPRINTF(str_buf, len_buf, "%c%c%c%c ", FOURCC_STR(caps->formats[i]));
-       TDM_DBG("layer formats: %s", buf);
-       for (i = 0; i < caps->prop_count; i++)
-               TDM_DBG("layer props: %d, %s", caps->props[i].id, caps->props[i].name);
-
        return TDM_ERROR_NONE;
 }
 
@@ -330,7 +292,6 @@ _tdm_display_update_caps_output(tdm_private_display *private_display, int pipe,
 {
        tdm_func_output *func_output = &private_display->func_output;
        char temp[TDM_NAME_LEN];
-       int i;
        tdm_error ret;
 
        if (!func_output->output_get_capability) {
@@ -348,35 +309,13 @@ _tdm_display_update_caps_output(tdm_private_display *private_display, int pipe,
        snprintf(temp, TDM_NAME_LEN, "%s-%d", caps->model, pipe);
        snprintf(caps->model, TDM_NAME_LEN, "%s", temp);
 
-       TDM_DBG("output maker: %s", caps->maker);
-       TDM_DBG("output model: %s", caps->model);
-       TDM_DBG("output name: %s", caps->name);
-       TDM_DBG("output status: %d", caps->status);
-       TDM_DBG("output type : %d", caps->type);
-       for (i = 0; i < caps->prop_count; i++)
-               TDM_DBG("output props: %d, %s", caps->props[i].id, caps->props[i].name);
-       for (i = 0; i < caps->mode_count; i++) {
-               TDM_DBG("output modes: name(%s), clock(%d) vrefresh(%d), flags(%x), type(%d)",
-                               caps->modes[i].name, caps->modes[i].clock, caps->modes[i].vrefresh,
-                               caps->modes[i].flags, caps->modes[i].type);
-               TDM_DBG("\t\t %d, %d, %d, %d, %d",
-                               caps->modes[i].hdisplay, caps->modes[i].hsync_start, caps->modes[i].hsync_end,
-                               caps->modes[i].htotal, caps->modes[i].hskew);
-               TDM_DBG("\t\t %d, %d, %d, %d, %d",
-                               caps->modes[i].vdisplay, caps->modes[i].vsync_start, caps->modes[i].vsync_end,
-                               caps->modes[i].vtotal, caps->modes[i].vscan);
-       }
-       TDM_DBG("output min  : %dx%d", caps->min_w, caps->min_h);
-       TDM_DBG("output max  : %dx%d", caps->max_w, caps->max_h);
-       TDM_DBG("output align: %d", caps->preferred_align);
-
        return TDM_ERROR_NONE;
 }
 
 static tdm_error
 _tdm_display_update_layer(tdm_private_display *private_display,
                                                  tdm_private_output *private_output,
-                                                 tdm_layer *layer_backend)
+                                                 tdm_layer *layer_backend, int index)
 {
        tdm_private_layer *private_layer;
        tdm_error ret;
@@ -387,6 +326,7 @@ _tdm_display_update_layer(tdm_private_display *private_display,
                TDM_RETURN_VAL_IF_FAIL(private_layer != NULL, TDM_ERROR_OUT_OF_MEMORY);
 
                LIST_ADDTAIL(&private_layer->link, &private_output->layer_list);
+               private_layer->index = index;
                private_layer->private_display = private_display;
                private_layer->private_output = private_output;
                private_layer->layer_backend = layer_backend;
@@ -433,6 +373,7 @@ tdm_display_update_output(tdm_private_display *private_display,
                private_output->current_dpms_value = TDM_OUTPUT_DPMS_OFF;
                private_output->output_backend = output_backend;
                private_output->pipe = pipe;
+               private_output->index = pipe;
 
                LIST_INITHEAD(&private_output->layer_list);
                LIST_INITHEAD(&private_output->capture_list);
@@ -461,7 +402,7 @@ tdm_display_update_output(tdm_private_display *private_display,
                goto failed_update;
 
        for (i = 0; i < layer_count; i++) {
-               ret = _tdm_display_update_layer(private_display, private_output, layers[i]);
+               ret = _tdm_display_update_layer(private_display, private_output, layers[i], i);
                if (ret != TDM_ERROR_NONE)
                        goto failed_update;
        }
@@ -735,15 +676,18 @@ _tdm_display_check_backend_functions(tdm_private_display *private_display)
        /* below functions should be implemented in backend side */
 
        TDM_RETURN_VAL_IF_FAIL(func_display != NULL, TDM_ERROR_BAD_MODULE);
-       TDM_RETURN_VAL_IF_FAIL(func_display->display_get_capabilitiy, TDM_ERROR_BAD_MODULE);
+//     TDM_RETURN_VAL_IF_FAIL(func_display->display_get_capabilitiy, TDM_ERROR_BAD_MODULE);
        TDM_RETURN_VAL_IF_FAIL(func_display->display_get_outputs, TDM_ERROR_BAD_MODULE);
        TDM_RETURN_VAL_IF_FAIL(func_output->output_get_capability, TDM_ERROR_BAD_MODULE);
        TDM_RETURN_VAL_IF_FAIL(func_output->output_get_layers, TDM_ERROR_BAD_MODULE);
        TDM_RETURN_VAL_IF_FAIL(func_layer->layer_get_capability, TDM_ERROR_BAD_MODULE);
 
-       ret = func_display->display_get_capabilitiy(private_display->bdata, &private_display->caps_display);
+       if (func_display->display_get_capability)
+               ret = func_display->display_get_capability(private_display->bdata, &private_display->caps_display);
+       else
+               ret = func_display->display_get_capabilitiy(private_display->bdata, &private_display->caps_display);
        if (ret != TDM_ERROR_NONE) {
-               TDM_ERR("display_get_capabilitiy() failed");
+               TDM_ERR("display_get_capability() failed");
                return TDM_ERROR_BAD_MODULE;
        }
 
@@ -812,7 +756,7 @@ _tdm_display_load_module_with_file(tdm_private_display *private_display,
        private_display->bdata = module_data->init((tdm_display *)private_display, &ret);
        TDM_TRACE_END();
        if (ret != TDM_ERROR_NONE) {
-               TDM_ERR("'%s' init failed", file);
+               TDM_ERR("failed to init '%s' module", module_data->name);
                goto failed_load;
        }
 
@@ -823,7 +767,7 @@ _tdm_display_load_module_with_file(tdm_private_display *private_display,
                goto failed_load;
        }
 
-       TDM_INFO("Success to load module(%s)", file);
+       TDM_INFO("Success to load '%s' module", module_data->name);
 
        return TDM_ERROR_NONE;
 failed_load:
@@ -899,25 +843,25 @@ tdm_display_init(tdm_error *error)
                return g_private_display;
        }
 
+       private_display = calloc(1, sizeof(tdm_private_display));
+       if (!private_display) {
+               ret = TDM_ERROR_OUT_OF_MEMORY;
+               TDM_ERR("'private_display != NULL' failed");
+               goto failed_alloc;
+       }
+
        debug = getenv("TDM_DEBUG_MODULE");
        if (debug)
                tdm_display_enable_debug_module(debug);
 
        debug = getenv("TDM_DEBUG_DUMP");
        if (debug)
-               tdm_display_enable_dump(debug);
+               tdm_display_enable_dump(private_display, debug, NULL, NULL);
 
        debug = getenv("TDM_DEBUG_PATH");
        if (debug)
                tdm_display_enable_path(debug);
 
-       private_display = calloc(1, sizeof(tdm_private_display));
-       if (!private_display) {
-               ret = TDM_ERROR_OUT_OF_MEMORY;
-               TDM_ERR("'private_display != NULL' failed");
-               goto failed_alloc;
-       }
-
        if (pthread_mutex_init(&private_display->lock, NULL)) {
                ret = TDM_ERROR_OPERATION_FAILED;
                TDM_ERR("mutex init failed: %m");
@@ -1022,6 +966,11 @@ tdm_display_deinit(tdm_display *dpy)
        free(private_display);
        g_private_display = NULL;
 
+       if (tdm_debug_dump_dir) {
+               free(tdm_debug_dump_dir);
+               tdm_debug_dump_dir = NULL;
+       }
+
        _pthread_mutex_unlock(&gLock);
 
        TDM_INFO("done");
@@ -1082,39 +1031,88 @@ tdm_display_enable_debug_module(const char*modules)
 }
 
 INTERN tdm_error
-tdm_display_enable_dump(const char *dump_str)
+tdm_display_enable_dump(tdm_private_display *private_display, const char *dump_str, char *reply, int *len)
 {
-       char temp[1024];
+       char temp[TDM_PATH_LEN] = {0,}, temp2[TDM_PATH_LEN] = {0,};
+       char *path, *path2;
        char *arg;
        char *end;
 
+       snprintf(temp2, TDM_PATH_LEN, "%s", dump_str);
+       path2 = strtostr(temp, TDM_PATH_LEN, temp2, "@");
+       if (!path2 || path2[0] == '\0')
+               path2 = TDM_DUMP_DIR;
+       else
+               path2++;
+
+       path = tdm_helper_dump_make_directory(path2, reply, len);
+       TDM_GOTO_IF_FAIL(path != NULL, done);
+
        tdm_debug_dump = 0;
 
        snprintf(temp, sizeof(temp), "%s", dump_str);
        arg = strtok_r(temp, ",", &end);
-       while (arg) {
-               if (!strncmp(arg, "none", 4)) {
-                       tdm_debug_dump = 0;
-                       return TDM_ERROR_NONE;
+       TDM_GOTO_IF_FAIL(arg != NULL, done);
+
+       if (!strncmp(arg, "none", 4)) {
+               tdm_debug_dump = 0;
+               if (tdm_debug_dump_dir) {
+                       free(tdm_debug_dump_dir);
+                       tdm_debug_dump_dir = NULL;
+               }
+               TDM_SNPRINTF(reply, len, "path: %s\n", path);
+               goto done;
+       }
+
+       if (!strncmp(arg, "current", 7)) {
+               tdm_private_output *o = NULL;
+               if (!private_display) {
+                       TDM_WRN("no private_display");
+                       goto done;
+               }
+
+               LIST_FOR_EACH_ENTRY(o, &private_display->output_list, link) {
+                       tdm_private_layer *l = NULL;
+                       LIST_FOR_EACH_ENTRY(l, &o->layer_list, link) {
+                               char str[TDM_PATH_LEN];
+                               if (l->usable)
+                                       continue;
+                               snprintf(str, TDM_PATH_LEN, "layer_%d_%d", o->index, l->index);
+                               tdm_helper_dump_buffer_str(l->showing_buffer, path, str);
+                       }
                }
+
+               TDM_SNPRINTF(reply, len, "path: %s\n", path);
+               goto done;
+       }
+
+       TDM_SNPRINTF(reply, len, "dump: %s\n", arg);
+
+       while (arg) {
                if (!strncmp(arg, "all", 3)) {
                        tdm_debug_dump = 0xFFFFFFFF;
-                       return TDM_ERROR_NONE;
-               }
-               if (!strncmp(arg, "layer", 5))
+                       goto done;
+               } else if (!strncmp(arg, "layer", 5)) {
                        tdm_debug_dump |= TDM_DUMP_FLAG_LAYER;
-               else if (!strncmp(arg, "pp", 2))
+               } else if (!strncmp(arg, "pp", 2)) {
                        tdm_debug_dump |= TDM_DUMP_FLAG_PP;
-               else if (!strncmp(arg, "capture", 7))
+               } else if (!strncmp(arg, "capture", 7)) {
                        tdm_debug_dump |= TDM_DUMP_FLAG_CAPTURE;
-               else
-                       return TDM_ERROR_BAD_REQUEST;
+               else
+                       goto done;
 
                arg = strtok_r(NULL, ",", &end);
        }
 
+       if (tdm_debug_dump_dir)
+               free(tdm_debug_dump_dir);
+
+       tdm_debug_dump_dir = strndup(path, TDM_PATH_LEN);
+
        TDM_INFO("dump... '%s'", dump_str);
 
+done:
+       free(path);
        return TDM_ERROR_NONE;
 }