common: fix syntax error

[platform/core/uifw/libtdm.git] / src / tdm.c

diff --git a/src/tdm.c b/src/tdm.c
index 15840f4..08a9136 100644 (file)
--- a/src/tdm.c
+++ b/src/tdm.c
@@ -477,19 +477,17 @@ tdm_display_update_output(tdm_private_module *private_module,
        return TDM_ERROR_NONE;
 }
 
-static tdm_output **
+static void
 _tdm_display_set_main_first(tdm_output **outputs, int index)
 {
        tdm_output *output_tmp = NULL;
 
        if (index == 0)
-               return outputs;
+               return;
 
        output_tmp = outputs[0];
        outputs[0] = outputs[index];
        outputs[index] = output_tmp;
-
-       return outputs;
 }
 
 static tdm_output **
@@ -497,7 +495,6 @@ _tdm_display_get_ordered_outputs(tdm_private_module *private_module, int *count)
 {
        tdm_func_display *func_display = &private_module->func_display;
        tdm_output **outputs = NULL;
-       tdm_output **new_outputs = NULL;
        tdm_output *output_dsi = NULL;
        tdm_output *output_lvds = NULL;
        tdm_output *output_hdmia = NULL;
@@ -580,32 +577,28 @@ _tdm_display_get_ordered_outputs(tdm_private_module *private_module, int *count)
        if (output_connected_count == 0) {
                /* hdmi > dsi > lvds > else */
                if (output_hdmia != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_hdmia);
+                       _tdm_display_set_main_first(outputs, index_hdmia);
                else if (output_hdmib != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_hdmib);
+                       _tdm_display_set_main_first(outputs, index_hdmib);
                else if (output_dsi != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_dsi);
+                       _tdm_display_set_main_first(outputs, index_dsi);
                else if (output_lvds != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_lvds);
-               else
-                       new_outputs = outputs;
+                       _tdm_display_set_main_first(outputs, index_lvds);
        } else { /* (output_connected_count > 1) */
                /* dsi > lvds > hdmi > else */
                if (output_dsi != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_dsi);
+                       _tdm_display_set_main_first(outputs, index_dsi);
                else if (output_lvds != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_lvds);
+                       _tdm_display_set_main_first(outputs, index_lvds);
                else if (output_hdmia != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_hdmia);
+                       _tdm_display_set_main_first(outputs, index_hdmia);
                else if (output_hdmib != NULL)
-                       new_outputs = _tdm_display_set_main_first(outputs, index_hdmib);
-               else
-                       new_outputs = outputs;
+                       _tdm_display_set_main_first(outputs, index_hdmib);
        }
 
-       private_module->outputs = new_outputs;
+       private_module->outputs = outputs;
 
-       return new_outputs;
+       return outputs;
 
 failed_get_outputs:
        free(outputs);
@@ -890,7 +883,7 @@ static tdm_error
 _tdm_display_load_modules(tdm_private_display *private_display)
 {
        const char *module_names;
-       tdm_error ret = 0;
+       tdm_error ret = TDM_ERROR_NONE;
        char temp[TDM_PATH_LEN];
        char *arg;
        char *end;