Increase line coverage using LCOV_EXCL
[platform/core/system/libstorage.git] / src / storage-external-dbus.c
index 2d86e3c..5a23bc6 100755 (executable)
 #include <stdbool.h>
 #include <errno.h>
 #include <gio/gio.h>
-#include <glib.h>
+#include <assert.h>
 #include <limits.h>
+#include <glib.h>
+#include <sys/statvfs.h>
+#include <tzplatform_config.h>
+#include <libsyscommon/libgdbus.h>
+#include <libsyscommon/list.h>
 
 #include "log.h"
 #include "storage-external-dbus.h"
 
 #define CHECK_STR(a) (a ? a : "")
 
-#define STORAGE_EXT_GET_LIST       "GetDeviceList"
+#define STORAGE_EXT_GET_LIST               "GetDeviceList"
+#define STORAGE_EXT_GET_STATVFS            "GetStatvfs"
+#define STORAGE_EXT_GET_STORAGE_LEVEL      "GetStorageLevel"
 
-#define STORAGE_EXT_OBJECT_ADDED   "ObjectAdded"
-#define STORAGE_EXT_OBJECT_REMOVED "ObjectRemoved"
-#define STORAGE_EXT_DEVICE_CHANGED "DeviceChanged"
+#define STORAGE_EXT_DEVICE_CHANGED         "DeviceChanged"
+#define STORAGE_EXT_DEVICE_ADDED           "DeviceAdded"
+#define STORAGE_EXT_DEVICE_REMOVED         "DeviceRemoved"
+#define STORAGE_EXT_DEVICE_BLOCKED         "DeviceBlocked"
 
 #define DBUS_REPLY_TIMEOUT (-1)
 
-#define DEV_PREFIX           "/dev/"
+#define GET_DBUS_CONN_OR_EXIT() \
+       ({ \
+               dbus_handle_h dbus_handle = gdbus_get_connection(G_BUS_TYPE_SYSTEM, true); \
+               if (dbus_handle == NULL) { \
+                       _E("Failed to get dbus connection"); \
+                       return -EIO; \
+               } \
+               dbus_handle; \
+       })
+
 
 struct storage_ext_callback {
        storage_ext_changed_cb func;
        void *data;
        guint block_id;
-       guint blockmanager_id;
 };
 
-static dd_list *changed_list;
+static GList *changed_list;
 
 static void storage_ext_release_internal(storage_ext_device *dev)
 {
@@ -72,15 +88,15 @@ void storage_ext_release_device(storage_ext_device **dev)
        *dev = NULL;
 }
 
-void storage_ext_release_list(dd_list **list)
+void storage_ext_release_list(GList **list)
 {
        storage_ext_device *dev;
-       dd_list *elem;
+       GList *elem;
 
        if (*list == NULL)
                return;
 
-       DD_LIST_FOREACH(*list, elem, dev) {
+       SYS_G_LIST_FOREACH(*list, elem, dev) {
                storage_ext_release_internal(dev);
                free(dev);
        }
@@ -89,83 +105,40 @@ void storage_ext_release_list(dd_list **list)
        *list = NULL;
 }
 
-static GDBusConnection *get_dbus_connection(void)
-{
-       GError *err = NULL;
-       static GDBusConnection *conn;
-
-       if (conn)
-               return conn;
-
-#if !GLIB_CHECK_VERSION(2, 35, 0)
-       g_type_init();
-#endif
-
-       conn = g_bus_get_sync(G_BUS_TYPE_SYSTEM, NULL, &err);
-       if (!conn) {
-               if (err) {
-                       _E("fail to get dbus connection : %s", err->message);
-                       g_clear_error(&err);
-               } else
-                       _E("fail to get dbus connection");
-               return NULL;
-       }
-       return conn;
-}
-
-static GVariant *dbus_method_call_sync(const gchar *dest, const gchar *path,
-                               const gchar *iface, const gchar *method, GVariant *param)
+int storage_ext_get_list(GList **list)
 {
-       GDBusConnection *conn;
-       GError *err = NULL;
-       GVariant *ret;
-
-       if (!dest || !path || !iface || !method || !param)
-               return NULL;
-
-       conn = get_dbus_connection();
-       if (!conn) {
-               _E("fail to get dbus connection");
-               return NULL;
-       }
-
-       ret = g_dbus_connection_call_sync(conn,
-                       dest, path, iface, method,
-                       param, NULL, G_DBUS_CALL_FLAGS_NONE,
-                       -1, NULL, &err);
-       if (!ret) {
-               if (err) {
-                       _E("dbus method sync call failed(%s)", err->message);
-                       g_clear_error(&err);
-               } else
-                       _E("g_dbus_connection_call_sync() failed");
-               return NULL;
-       }
-
-       return ret;
-}
-
-int storage_ext_get_list(dd_list **list)
-{
-       GVariant *result;
+       GVariant *reply;
        GVariantIter *iter;
        storage_ext_device *elem, info;
-       int ret;
+       int ret, ret_dbus;
 
        if (!list)
                return -EINVAL;
 
-       result = dbus_method_call_sync(STORAGE_EXT_BUS_NAME,
+       dbus_handle_h dbus_handle = GET_DBUS_CONN_OR_EXIT();
+
+       ret_dbus = gdbus_priv_call_sync_with_reply(dbus_handle,
+                       STORAGE_EXT_BUS_NAME,
                        STORAGE_EXT_PATH_MANAGER,
                        STORAGE_EXT_IFACE_MANAGER,
                        STORAGE_EXT_GET_LIST,
-                       g_variant_new("(s)", "all"));
-       if (!result) {
-               _E("Failed to get storage_ext device info");
-               return -EIO;
+                       g_variant_new("(s)", "all"),
+                       &reply);
+
+       gdbus_free_connection(dbus_handle);
+
+       if (ret_dbus < 0) {
+               _E("Failed to get storage_ext device info"); //LCOV_EXCL_LINE
+               return -EIO; //LCOV_EXCL_LINE
        }
 
-       g_variant_get(result, "(a(issssssisibii))", &iter);
+       if (!g_variant_get_safe(reply, "(a(issssssisibii))", &iter)) {
+               //LCOV_EXCL_START Dbus type error
+               _E("Failed to get params from gvariant.");
+               g_variant_unref(reply);
+               return -EIO;
+               //LCOV_EXCL_STOP
+       }
 
        while (g_variant_iter_loop(iter, "(issssssisibii)",
                                &info.type, &info.devnode, &info.syspath,
@@ -177,9 +150,11 @@ int storage_ext_get_list(dd_list **list)
 
                elem = (storage_ext_device *)malloc(sizeof(storage_ext_device));
                if (!elem) {
+                       //LCOV_EXCL_START System error
                        _E("malloc() failed");
                        ret = -ENOMEM;
                        goto out;
+                       //LCOV_EXCL_STOP
                }
 
                elem->type = info.type;
@@ -196,88 +171,180 @@ int storage_ext_get_list(dd_list **list)
                elem->flags = info.flags;
                elem->storage_id = info.storage_id;
 
-               DD_LIST_APPEND(*list, elem);
+               SYS_G_LIST_APPEND(*list, elem);
        }
 
-       ret = g_list_length(*list);
+       ret = SYS_G_LIST_LENGTH(*list);
 
 out:
        if (ret < 0)
-               storage_ext_release_list(list);
+               storage_ext_release_list(list); //LCOV_EXCL_LINE System Error
        g_variant_iter_free(iter);
-       g_variant_unref(result);
+       g_variant_unref(reply);
        return ret;
 }
 
-static char *get_devnode_from_path(char *path)
+int storage_ext_get_statvfs(char *path, struct statvfs_32 *buf)
 {
-       if (!path)
-               return NULL;
-       /* 1 means '/' */
-       return path + strlen(STORAGE_EXT_PATH_DEVICES) + 1;
+       GVariant *reply;
+       int ret_dbus;
+       guint64 bsize, frsize, blocks, bfree, bavail, files, ffree, favail, fsid, flag, namemax;
+
+       assert(buf);
+
+       memset(buf, 0, sizeof(struct statvfs_32));
+
+       dbus_handle_h dbus_handle = GET_DBUS_CONN_OR_EXIT();
+
+       ret_dbus = gdbus_priv_call_sync_with_reply(dbus_handle,
+                       STORAGE_EXT_BUS_NAME,
+                       STORAGE_EXT_PATH_STORAGE,
+                       STORAGE_EXT_IFACE_STORAGE,
+                       STORAGE_EXT_GET_STATVFS,
+                       g_variant_new("(s)", path),
+                       &reply);
+
+       gdbus_free_connection(dbus_handle);
+
+       if (ret_dbus < 0) {
+               _E("Failed to get storage_ext device info"); //LCOV_EXCL_LINE
+               return -EIO; //LCOV_EXCL_LINE
+       }
+
+       if (!g_variant_get_safe(reply, "(ttttttttttt)",
+                       &bsize, &frsize, &blocks,
+                       &bfree, &bavail, &files,
+                       &ffree, &favail, &fsid,
+                       &flag, &namemax)) {
+               _E("Failed to get params from gvariant.");
+               g_variant_unref(reply);
+               return -EIO;
+       }
+//     %llu bsize, frsize, blocks, bfree, bavail, files, ffree, favail, fsid, flag, namemax
+
+       buf->f_bsize  = (unsigned long)bsize;
+       buf->f_frsize = (unsigned long)frsize;
+       buf->f_blocks = (unsigned long)blocks;
+       buf->f_bfree  = (unsigned long)bfree;
+       buf->f_bavail = (unsigned long)bavail;
+       buf->f_files  = (unsigned long)files;
+       buf->f_ffree  = (unsigned long)ffree;
+       buf->f_favail = (unsigned long)favail;
+       buf->f_fsid = (unsigned long)fsid;
+       buf->f_flag = (unsigned long)flag;
+       buf->f_namemax = (unsigned long)namemax;
+
+//     %lu buf->f_bsize, buf->f_frsize, buf->f_blocks, buf->f_bfree, buf->f_bavail, buf->f_files, buf->f_ffree, buf->f_favail, buf->f_fsid, buf->f_flag, buf->f_namemax
+       return 0;
 }
 
-static void storage_ext_object_path_changed(enum storage_ext_state state,
-               GVariant *params, gpointer user_data)
+int storage_ext_get_statvfs_size64(char *path, struct statvfs *buf)
 {
-       storage_ext_device *dev = NULL;
-       dd_list *elem;
-       struct storage_ext_callback *callback;
-       char *path = NULL;
-       char *devnode;
-       int ret;
+       GVariant *reply;
+       int ret_dbus;
 
-       if (!params)
-               return;
+       assert(buf);
 
-       g_variant_get(params, "(s)", &path);
+       memset(buf, 0, sizeof(struct statvfs));
 
-       devnode = get_devnode_from_path(path);
-       if (!devnode)
-               goto out;
+       dbus_handle_h dbus_handle = GET_DBUS_CONN_OR_EXIT();
 
-       dev = calloc(1, sizeof(storage_ext_device));
-       if (!dev)
-               goto out;
+       ret_dbus = gdbus_priv_call_sync_with_reply(dbus_handle,
+                       STORAGE_EXT_BUS_NAME,
+                       STORAGE_EXT_PATH_STORAGE,
+                       STORAGE_EXT_IFACE_STORAGE,
+                       STORAGE_EXT_GET_STATVFS,
+                       g_variant_new("(s)", path),
+                       &reply);
 
-       dev->devnode = strdup(devnode);
-       if (dev->devnode == NULL) {
-               _E("strdup() failed");
-               goto out;
-       }
+       gdbus_free_connection(dbus_handle);
 
-       DD_LIST_FOREACH(changed_list, elem, callback) {
-               if (!callback->func)
-                       continue;
-               ret = callback->func(dev, state, callback->data);
-               if (ret < 0)
-                       _E("Failed to call callback for devnode(%s, %d)", devnode, ret);
+       if (ret_dbus < 0) {
+               _E("Failed to get storage_ext device info"); //LCOV_EXCL_LINE
+               return -EIO; //LCOV_EXCL_LINE
        }
 
-out:
-       if (dev) {
-               free(dev->devnode);
-               free(dev);
+       if (!g_variant_get_safe(reply, "(ttttttttttt)",
+                       &(buf->f_bsize), &(buf->f_frsize), &(buf->f_blocks),
+                       &(buf->f_bfree), &(buf->f_bavail), &(buf->f_files),
+                       &(buf->f_ffree), &(buf->f_favail), &(buf->f_fsid),
+                       &(buf->f_flag), &(buf->f_namemax))) {
+               //LCOV_EXCL_START Dbus type error
+               _E("Failed to get params from gvariant.");
+               g_variant_unref(reply);
+               return -EIO;
+               //LCOV_EXCL_STOP
        }
-       free(path);
-}
 
-static void storage_ext_device_added(GVariant *params, gpointer user_data)
-{
-       storage_ext_object_path_changed(STORAGE_EXT_ADDED, params, user_data);
+//     %lu buf->f_bsize, buf->f_frsize, buf->f_fsid, buf->f_flag, buf->f_namemax
+//     %llu buf->f_blocks, buf->f_bfree, buf->f_bavail, buf->f_files, buf->f_ffree, buf->f_favail
+
+       return 0;
 }
 
-static void storage_ext_device_removed(GVariant *params, gpointer user_data)
+int storage_ext_get_storage_level(const char *path, char **level)
 {
-       storage_ext_object_path_changed(STORAGE_EXT_REMOVED, params, user_data);
+       GVariant *reply;
+       int ret_dbus;
+       char *reply_val;
+       enum tzplatform_variable id;
+
+       if (!strcmp(path, tzplatform_getenv(TZ_SYS_USER)))
+               id = TZ_SYS_USER;
+       else if (!strcmp(path, tzplatform_getenv(TZ_SYS_TMP)))
+               id = TZ_SYS_TMP;
+       else if (!strcmp(path, tzplatform_getenv(TZ_SYS_OPT)))
+               id = TZ_SYS_OPT;
+       else {
+               _E("Invalid path");
+               return -EINVAL;
+       }
+
+       dbus_handle_h dbus_handle = GET_DBUS_CONN_OR_EXIT();
+
+       ret_dbus = gdbus_priv_call_sync_with_reply(
+                       dbus_handle,
+                       STORAGE_EXT_BUS_NAME,
+                       STORAGE_EXT_PATH_STORAGE,
+                       STORAGE_EXT_IFACE_STORAGE,
+                       STORAGE_EXT_GET_STORAGE_LEVEL,
+                       g_variant_new("(i)", id),
+                       &reply);
+
+       gdbus_free_connection(dbus_handle);
+
+       if (ret_dbus < 0) {
+               //LCOV_EXCL_START Dbus error
+               _E("Failed to get %d level", id);
+               return -EIO;
+               //LCOV_EXCL_STOP
+       }
+
+       if (!g_variant_get_safe(reply, "(s)", &reply_val)) {
+               //LCOV_EXCL_START Dbus type error
+               _E("Failed to get params from gvariant.");
+               g_variant_unref(reply);
+               return -EIO;
+               //LCOV_EXCL_STOP
+       }
+
+       *level = strdup(reply_val);
+       g_free(reply_val);
+       g_variant_unref(reply);
+
+       if (*level == NULL)
+               return -ENOMEM; //LCOV_EXCL_LINE
+
+       return 0;
 }
 
-static void storage_ext_device_changed(GVariant *params, gpointer user_data)
+//LCOV_EXCL_START Not called Callback
+static void storage_ext_device_changed(GVariant *params, enum storage_ext_state state, gpointer user_data)
 {
        storage_ext_device *dev;
-       dd_list *elem;
+       GList *elem;
        struct storage_ext_callback *callback;
-       int ret;
+       int ret_val;
 
        if (!params)
                return;
@@ -286,7 +353,7 @@ static void storage_ext_device_changed(GVariant *params, gpointer user_data)
        if (!dev)
                return;
 
-       g_variant_get(params, "(issssssisibii)",
+       if (!g_variant_get_safe(params, "(issssssisibii)",
                        &dev->type,
                        &dev->devnode,
                        &dev->syspath,
@@ -299,19 +366,28 @@ static void storage_ext_device_changed(GVariant *params, gpointer user_data)
                        &dev->state,
                        &dev->primary,
                        &dev->flags,
-                       &dev->storage_id);
+                       &dev->storage_id))
+               return;
 
-       DD_LIST_FOREACH(changed_list, elem, callback) {
+       /* Callback is called when unmount is started(DeviceBlocked signal) */
+       if (state == STORAGE_EXT_CHANGED && dev->state == STORAGE_EXT_UNMOUNTED) {
+               storage_ext_release_device(&dev);
+               return;
+       }
+
+       SYS_G_LIST_FOREACH(changed_list, elem, callback) {
                if (!callback->func)
                        continue;
-               ret = callback->func(dev, STORAGE_EXT_CHANGED, callback->data);
-               if (ret < 0)
-                       _E("Failed to call callback for devnode(%s, %d)", dev->devnode, ret);
+               ret_val = callback->func(dev, state, callback->data);
+               if (ret_val < 0)
+                       _E("Failed to call callback for devnode(%s, %d)", dev->devnode, ret_val);
        }
 
        storage_ext_release_device(&dev);
 }
+//LCOV_EXCL_STOP
 
+//LCOV_EXCL_START Not called Callback
 static void storage_ext_changed(GDBusConnection *conn,
                const gchar *sender,
                const gchar *path,
@@ -321,6 +397,7 @@ static void storage_ext_changed(GDBusConnection *conn,
                gpointer user_data)
 {
        size_t iface_len, signal_len;
+       enum storage_ext_state state;
 
        if (!params || !sender || !path || !iface || !signal)
                return;
@@ -328,35 +405,41 @@ static void storage_ext_changed(GDBusConnection *conn,
        iface_len = strlen(iface) + 1;
        signal_len = strlen(signal) + 1;
 
-       if (!strncmp(iface, STORAGE_EXT_IFACE_MANAGER, iface_len)) {
-               if (!strncmp(signal, STORAGE_EXT_OBJECT_ADDED, signal_len))
-                       storage_ext_device_added(params, user_data);
-               else if (!strncmp(signal, STORAGE_EXT_OBJECT_REMOVED, signal_len))
-                       storage_ext_device_removed(params, user_data);
+       if (strncmp(iface, STORAGE_EXT_IFACE_MANAGER, iface_len))
                return;
-       }
 
-       if (!strncmp(iface, STORAGE_EXT_IFACE, iface_len) &&
-               !strncmp(signal, STORAGE_EXT_DEVICE_CHANGED, signal_len)) {
-               storage_ext_device_changed(params, user_data);
+       if (!strncmp(signal, STORAGE_EXT_DEVICE_CHANGED, signal_len))
+               state = STORAGE_EXT_CHANGED;
+
+       else if (!strncmp(signal, STORAGE_EXT_DEVICE_ADDED, signal_len))
+               state = STORAGE_EXT_ADDED;
+
+       else if (!strncmp(signal, STORAGE_EXT_DEVICE_REMOVED, signal_len))
+               state = STORAGE_EXT_REMOVED;
+
+       else if (!strncmp(signal, STORAGE_EXT_DEVICE_BLOCKED, signal_len))
+               state = STORAGE_EXT_BLOCKED;
+
+       else
                return;
-       }
+
+       storage_ext_device_changed(params, state, user_data);
 }
+//LCOV_EXCL_STOP
 
 int storage_ext_register_device_change(storage_ext_changed_cb func, void *data)
 {
-       GDBusConnection *conn;
-       guint block_id = NULL, blockmanager_id = NULL;
+       guint block_id = 0;
        struct storage_ext_callback *callback;
-       dd_list *elem;
+       GList *elem;
 
        if (!func)
                return -EINVAL;
 
-       DD_LIST_FOREACH(changed_list, elem, callback) {
+       SYS_G_LIST_FOREACH(changed_list, elem, callback) {
                if (callback->func != func)
                        continue;
-               if (callback->block_id == 0 || callback->blockmanager_id == 0)
+               if (callback->block_id == 0)
                        continue;
 
                return -EEXIST;
@@ -364,110 +447,100 @@ int storage_ext_register_device_change(storage_ext_changed_cb func, void *data)
 
        callback = (struct storage_ext_callback *)malloc(sizeof(struct storage_ext_callback));
        if (!callback) {
+               //LCOV_EXCL_START System Error
                _E("malloc() failed");
                return -ENOMEM;
+               //LCOV_EXCL_STOP
        }
 
-       conn = get_dbus_connection();
-       if (!conn) {
-               free(callback);
-               _E("Failed to get dbus connection");
-               return -EPERM;
-       }
-
-       block_id = g_dbus_connection_signal_subscribe(conn,
-                       STORAGE_EXT_BUS_NAME,
-                       STORAGE_EXT_IFACE,
-                       STORAGE_EXT_DEVICE_CHANGED,
-                       NULL,
-                       NULL,
-                       G_DBUS_SIGNAL_FLAGS_NONE,
-                       storage_ext_changed,
-                       NULL,
-                       NULL);
-       if (block_id == 0) {
-               free(callback);
-               _E("Failed to subscrive bus signal");
-               return -EPERM;
-       }
-
-       blockmanager_id = g_dbus_connection_signal_subscribe(conn,
-                       STORAGE_EXT_BUS_NAME,
+       block_id = gdbus_signal_subscribe(NULL, NULL,
                        STORAGE_EXT_IFACE_MANAGER,
                        NULL,
-                       STORAGE_EXT_PATH_MANAGER,
-                       NULL,
-                       G_DBUS_SIGNAL_FLAGS_NONE,
                        storage_ext_changed,
                        NULL,
                        NULL);
-       if (blockmanager_id == 0) {
+       if (block_id == 0) {
+               //LCOV_EXCL_START System Error
                free(callback);
                _E("Failed to subscrive bus signal");
                return -EPERM;
+               //LCOV_EXCL_STOP
        }
 
        callback->func = func;
        callback->data = data;
        callback->block_id = block_id;
-       callback->blockmanager_id = blockmanager_id;
 
-       DD_LIST_APPEND(changed_list, callback);
+       SYS_G_LIST_APPEND(changed_list, callback);
 
        return 0;
 }
 
 void storage_ext_unregister_device_change(storage_ext_changed_cb func)
 {
-       GDBusConnection *conn;
        struct storage_ext_callback *callback;
-       dd_list *elem;
+       GList *elem;
+       GList *elem_n;
 
        if (!func)
                return;
 
-       conn = get_dbus_connection();
-       if (!conn) {
-               _E("fail to get dbus connection");
-               return;
-       }
-
-       DD_LIST_FOREACH(changed_list, elem, callback) {
+       SYS_G_LIST_FOREACH_SAFE(changed_list, elem, elem_n, callback) {
                if (callback->func != func)
                        continue;
                if (callback->block_id > 0)
-                       g_dbus_connection_signal_unsubscribe(conn, callback->block_id);
-               if (callback->blockmanager_id > 0)
-                       g_dbus_connection_signal_unsubscribe(conn, callback->blockmanager_id);
+                       gdbus_signal_unsubscribe(NULL, callback->block_id);
 
-               DD_LIST_REMOVE(changed_list, callback);
+               SYS_G_LIST_REMOVE(changed_list, callback);
                free(callback);
        }
 }
 
 int storage_ext_get_device_info(int storage_id, storage_ext_device *info)
 {
-       GVariant *result;
+       GVariant *reply;
+       int ret_dbus;
+
+       dbus_handle_h dbus_handle = GET_DBUS_CONN_OR_EXIT();
 
-       result = dbus_method_call_sync(STORAGE_EXT_BUS_NAME,
+       ret_dbus = gdbus_priv_call_sync_with_reply(dbus_handle,
+                       STORAGE_EXT_BUS_NAME,
                        STORAGE_EXT_PATH_MANAGER,
                        STORAGE_EXT_IFACE_MANAGER,
-                       "GetDeviceInfoByID",
-                       g_variant_new("(i)", storage_id));
-       if (!result) {
-               _E("There is no storage with the storage id (%d)", storage_id);
-               return -ENODEV;
+                       "GetDeviceInfo",
+                       g_variant_new("(i)", storage_id),
+                       &reply);
+
+       gdbus_free_connection(dbus_handle);
+
+       if (ret_dbus < 0) {
+               _E("There is no storage with the storage id (%d)", storage_id); //LCOV_EXCL_LINE
+               return -ENODEV; //LCOV_EXCL_LINE
        }
 
-       g_variant_get(result, "(issssssisibii)",
-                       &info->type, &info->devnode, &info->syspath,
-                       &info->fs_usage, &info->fs_type,
-                       &info->fs_version, &info->fs_uuid,
-                       &info->readonly, &info->mount_point,
-                       &info->state, &info->primary,
-                       &info->flags, &info->storage_id);
+       if (!g_variant_get_safe(reply, "(issssssisibii)",
+                               &info->type, &info->devnode, &info->syspath,
+                               &info->fs_usage, &info->fs_type,
+                               &info->fs_version, &info->fs_uuid,
+                               &info->readonly, &info->mount_point,
+                               &info->state, &info->primary,
+                               &info->flags, &info->storage_id)) {
+               //LCOV_EXCL_START Dbus error
+               _E("No storage with the storage id (%d)", storage_id);
+               ret_dbus = -ENODEV;
+               goto out;
+               //LCOV_EXCL_STOP
+       }
 
-       g_variant_unref(result);
+       if (info->storage_id < 0) {
+               //LCOV_EXCL_START Dbus error
+               _E("No storage with the storage id (%d)", storage_id);
+               ret_dbus = -ENODEV;
+               goto out;
+               //LCOV_EXCL_STOP
+       }
 
+out:
+       g_variant_unref(reply);
        return 0;
 }