agent: Added Username/Password request input logic
[platform/upstream/connman.git] / src / service.c
index d768bdd..6bfcc19 100644 (file)
@@ -99,7 +99,6 @@ struct connman_service {
        char *phase2;
        DBusMessage *pending;
        guint timeout;
-       struct connman_location *location;
        struct connman_stats stats;
        struct connman_stats stats_roaming;
        GHashTable *counter_table;
@@ -299,10 +298,8 @@ static enum connman_service_proxy_method string2proxymethod(const char *method)
 
 static int service_load(struct connman_service *service)
 {
-       const char *ident = "default";
        GKeyFile *keyfile;
        GError *error = NULL;
-       gchar *pathname, *data = NULL;
        gsize length;
        gchar *str;
        connman_bool_t autoconnect;
@@ -311,29 +308,9 @@ static int service_load(struct connman_service *service)
 
        DBG("service %p", service);
 
-       if (ident == NULL)
-               return -EINVAL;
-
-       pathname = g_strdup_printf("%s/%s.profile", STORAGEDIR, ident);
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE) {
-               g_free(pathname);
-               return -ENOENT;
-       }
-
-       g_free(pathname);
-
-       if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE) {
-               g_free(data);
-               return -EILSEQ;
-       }
-
-       g_free(data);
+       keyfile = __connman_storage_load_service(service->identifier);
+       if (keyfile == NULL)
+               return -EIO;
 
        switch (service->type) {
        case CONNMAN_SERVICE_TYPE_UNKNOWN:
@@ -488,37 +465,17 @@ done:
 
 static int service_save(struct connman_service *service)
 {
-       const char *ident = "default";
        GKeyFile *keyfile;
-       gchar *pathname, *data = NULL;
-       gsize length;
        gchar *str;
        const char *cst_str = NULL;
        int err = 0;
 
        DBG("service %p", service);
 
-       if (ident == NULL)
-               return -EINVAL;
-
-       pathname = g_strdup_printf("%s/%s.profile", STORAGEDIR, ident);
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE)
-               goto update;
-
-       if (length > 0) {
-               if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE)
-                       goto done;
-       }
-
-       g_free(data);
+       keyfile = __connman_storage_open_service(service->identifier);
+       if (keyfile == NULL)
+               return -EIO;
 
-update:
        if (service->name != NULL)
                g_key_file_set_string(keyfile, service->identifier,
                                                "Name", service->name);
@@ -660,18 +617,11 @@ update:
                g_key_file_remove_key(keyfile, service->identifier,
                                                        "Proxy.URL", NULL);
 
-       data = g_key_file_to_data(keyfile, &length, NULL);
-
-       if (g_file_set_contents(pathname, data, length, NULL) == FALSE)
-               connman_error("Failed to store service information");
-
 done:
-       g_free(data);
+       __connman_storage_save_service(keyfile, service->identifier);
 
        g_key_file_free(keyfile);
 
-       g_free(pathname);
-
        return err;
 }
 
@@ -1359,10 +1309,27 @@ static void append_security(DBusMessageIter *iter, void *user_data)
                dbus_message_iter_append_basic(iter,
                                DBUS_TYPE_STRING, &str);
 
-       str = "wps";
-       if (service->wps == TRUE)
-               dbus_message_iter_append_basic(iter,
-                               DBUS_TYPE_STRING, &str);
+       /*
+        * Some access points incorrectly advertise WPS even when they
+        * are configured as open or no security, so filter
+        * appropriately.
+        */
+       if (service->wps == TRUE) {
+               switch (service->security) {
+               case CONNMAN_SERVICE_SECURITY_PSK:
+               case CONNMAN_SERVICE_SECURITY_WPA:
+               case CONNMAN_SERVICE_SECURITY_RSN:
+                       str = "wps";
+                       dbus_message_iter_append_basic(iter,
+                               DBUS_TYPE_STRING, &str);
+                       break;
+               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
+               case CONNMAN_SERVICE_SECURITY_NONE:
+               case CONNMAN_SERVICE_SECURITY_WEP:
+               case CONNMAN_SERVICE_SECURITY_8021X:
+                       break;
+               }
+       }
 }
 
 static void append_ethernet(DBusMessageIter *iter, void *user_data)
@@ -3148,45 +3115,6 @@ static connman_bool_t get_reconnect_state(struct connman_service *service)
        return __connman_device_get_reconnect(device);
 }
 
-static void request_input_cb (struct connman_service *service,
-                       const char *identity, const char *passphrase,
-                       void *user_data)
-{
-       DBG ("RequestInput return, %p", service);
-
-       if (identity == NULL && passphrase == NULL && service->wps == FALSE)
-               return;
-
-       if (identity != NULL)
-               __connman_service_set_agent_identity(service, identity);
-
-       if (passphrase != NULL) {
-               switch (service->security) {
-               case CONNMAN_SERVICE_SECURITY_WEP:
-               case CONNMAN_SERVICE_SECURITY_PSK:
-                       __connman_service_set_passphrase(service, passphrase);
-                       break;
-               case CONNMAN_SERVICE_SECURITY_8021X:
-                       __connman_service_set_agent_passphrase(service,
-                                                       passphrase);
-                       break;
-               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
-               case CONNMAN_SERVICE_SECURITY_NONE:
-               case CONNMAN_SERVICE_SECURITY_WPA:
-               case CONNMAN_SERVICE_SECURITY_RSN:
-                       DBG("service security '%s' not handled",
-                               security2string(service->security));
-                       break;
-               }
-       }
-
-       __connman_service_connect(service);
-
-       /* Never cache agent provided credentials */
-       __connman_service_set_agent_identity(service, NULL);
-       __connman_service_set_agent_passphrase(service, NULL);
-}
-
 static DBusMessage *connect_service(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -3333,7 +3261,8 @@ static DBusMessage *move_service(DBusConnection *conn,
                return __connman_error_not_supported(msg);
 
        target = find_service(path);
-       if (target == NULL || target->favorite == FALSE || target == service)
+       if (target == NULL || target->favorite == FALSE || target == service ||
+                               target->type == CONNMAN_SERVICE_TYPE_VPN)
                return __connman_error_invalid_service(msg);
 
        target4 = __connman_ipconfig_get_method(target->ipconfig_ipv4);
@@ -3453,7 +3382,6 @@ static void service_free(gpointer user_data)
        __connman_notifier_service_remove(service);
 
        stats_stop(service);
-       service_save(service);
 
        service->path = NULL;
 
@@ -3489,9 +3417,6 @@ static void service_free(gpointer user_data)
                service->ipconfig_ipv6 = NULL;
        }
 
-       if (service->location != NULL)
-               connman_location_unref(service->location);
-
        g_strfreev(service->nameservers);
        g_strfreev(service->nameservers_config);
        g_strfreev(service->domains);
@@ -3634,16 +3559,9 @@ struct connman_service *connman_service_create(void)
 
        service_initialize(service);
 
-       service->location = __connman_location_create(service);
-
        return service;
 }
 
-struct connman_location *__connman_service_get_location(struct connman_service *service)
-{
-       return service->location;
-}
-
 /**
  * connman_service_ref:
  * @service: service structure
@@ -3947,6 +3865,49 @@ static void report_error_cb(struct connman_service *service,
        }
 }
 
+static void request_input_cb (struct connman_service *service,
+                       const char *identity, const char *passphrase,
+                       void *user_data)
+{
+       DBG ("RequestInput return, %p", service);
+
+       if (identity == NULL && passphrase == NULL && service->wps == FALSE) {
+               service_complete(service);
+               services_changed(FALSE);
+               __connman_device_request_scan(CONNMAN_DEVICE_TYPE_UNKNOWN);
+               return;
+       }
+
+       if (identity != NULL)
+               __connman_service_set_agent_identity(service, identity);
+
+       if (passphrase != NULL) {
+               switch (service->security) {
+               case CONNMAN_SERVICE_SECURITY_WEP:
+               case CONNMAN_SERVICE_SECURITY_PSK:
+                       __connman_service_set_passphrase(service, passphrase);
+                       break;
+               case CONNMAN_SERVICE_SECURITY_8021X:
+                       __connman_service_set_agent_passphrase(service,
+                                                       passphrase);
+                       break;
+               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
+               case CONNMAN_SERVICE_SECURITY_NONE:
+               case CONNMAN_SERVICE_SECURITY_WPA:
+               case CONNMAN_SERVICE_SECURITY_RSN:
+                       DBG("service security '%s' not handled",
+                               security2string(service->security));
+                       break;
+               }
+       }
+
+       __connman_service_connect(service);
+
+       /* Never cache agent provided credentials */
+       __connman_service_set_agent_identity(service, NULL);
+       __connman_service_set_agent_passphrase(service, NULL);
+}
+
 static int service_indicate_state(struct connman_service *service)
 {
        enum connman_service_state old_state, new_state;
@@ -4055,10 +4016,10 @@ static int service_indicate_state(struct connman_service *service)
                                def_service->provider != NULL)
                        __connman_provider_disconnect(def_service->provider);
 
-               __connman_location_finish(service);
-
                default_changed();
 
+               __connman_wispr_stop(service);
+
                __connman_wpad_stop(service);
 
                update_nameservers(service);
@@ -4154,8 +4115,6 @@ int __connman_service_indicate_default(struct connman_service *service)
 
        default_changed();
 
-       __connman_location_detect(service);
-
        return 0;
 }
 
@@ -4181,17 +4140,22 @@ static void check_proxy_setup(struct connman_service *service)
         */
 
        if (service->proxy != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN)
-               return;
+               goto done;
 
        if (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN &&
                (service->proxy_config != CONNMAN_SERVICE_PROXY_METHOD_AUTO ||
                        service->pac != NULL))
-               return;
+               goto done;
 
        if (__connman_wpad_start(service) < 0) {
                service->proxy = CONNMAN_SERVICE_PROXY_METHOD_DIRECT;
                __connman_notifier_proxy_changed(service);
        }
+
+       return;
+
+done:
+       __connman_wispr_start(service, CONNMAN_IPCONFIG_TYPE_IPV4);
 }
 
 int __connman_service_ipconfig_indicate_state(struct connman_service *service,
@@ -4241,6 +4205,8 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
 
                if (type == CONNMAN_IPCONFIG_TYPE_IPV4)
                        check_proxy_setup(service);
+               else
+                       __connman_wispr_start(service, type);
                break;
        case CONNMAN_SERVICE_STATE_ONLINE:
                break;
@@ -4523,7 +4489,7 @@ int __connman_service_connect(struct connman_service *service)
 
        if (service->userconnect == TRUE) {
                if (err == -ENOKEY) {
-                       if (__connman_agent_request_input(service,
+                       if (__connman_agent_request_passphrase_input(service,
                                                        request_input_cb,
                                                        NULL) == -EIO)
                                return -EINPROGRESS;
@@ -5124,7 +5090,7 @@ void __connman_service_read_ip4config(struct connman_service *service)
        if (service->ipconfig_ipv4 == NULL)
                return;
 
-       keyfile = __connman_storage_open_profile("default");
+       keyfile = __connman_storage_load_global();
        if (keyfile == NULL)
                return;
 
@@ -5153,7 +5119,7 @@ void __connman_service_read_ip6config(struct connman_service *service)
        if (service->ipconfig_ipv6 == NULL)
                return;
 
-       keyfile = __connman_storage_open_profile("default");
+       keyfile = __connman_storage_load_service(service->identifier);
        if (keyfile == NULL)
                return;
 
@@ -5172,6 +5138,7 @@ void __connman_service_create_ip6config(struct connman_service *service,
                return;
 
        setup_ip6config(service, index);
+
        __connman_service_read_ip6config(service);
 }
 
@@ -5189,6 +5156,9 @@ struct connman_service *__connman_service_lookup_from_network(struct connman_net
 
        DBG("network %p", network);
 
+       if (network == NULL)
+               return NULL;
+
        ident = __connman_network_get_ident(network);
        if (ident == NULL)
                return NULL;
@@ -5382,6 +5352,9 @@ struct connman_service * __connman_service_create_from_network(struct connman_ne
 
        DBG("network %p", network);
 
+       if (network == NULL)
+               return NULL;
+
        ident = __connman_network_get_ident(network);
        if (ident == NULL)
                return NULL;