storage: Remove obsolete functions that nobody calls
[framework/connectivity/connman.git] / src / service.c
index 018f12f..4ad75e8 100644 (file)
@@ -117,6 +117,7 @@ struct connman_service {
        int online_check_count;
        connman_bool_t do_split_routing;
        connman_bool_t new_service;
+       connman_bool_t hidden_service;
 };
 
 struct find_data {
@@ -486,6 +487,9 @@ static int service_load(struct connman_service *service)
                service->pac = str;
        }
 
+       service->hidden_service = g_key_file_get_boolean(keyfile,
+                                       service->identifier, "Hidden", NULL);
+
 done:
        g_key_file_free(keyfile);
 
@@ -668,6 +672,10 @@ static int service_save(struct connman_service *service)
                g_key_file_remove_key(keyfile, service->identifier,
                                                        "Proxy.URL", NULL);
 
+       if (service->hidden_service == TRUE)
+               g_key_file_set_boolean(keyfile, service->identifier, "Hidden",
+                                                                       TRUE);
+
 done:
        __connman_storage_save_service(keyfile, service->identifier);
 
@@ -1507,32 +1515,32 @@ static void append_tsconfig(DBusMessageIter *iter, void *user_data)
        }
 }
 
-static void append_domain(DBusMessageIter *iter, void *user_data)
+static void append_domainconfig(DBusMessageIter *iter, void *user_data)
 {
        struct connman_service *service = user_data;
+       int i;
 
-       if (is_connected(service) == FALSE &&
-                               is_connecting(service) == FALSE)
-               return;
-
-       if (service->domainname == NULL)
+       if (service->domains == NULL)
                return;
 
-       dbus_message_iter_append_basic(iter,
-                               DBUS_TYPE_STRING, &service->domainname);
+       for (i = 0; service->domains[i]; i++)
+               dbus_message_iter_append_basic(iter,
+                               DBUS_TYPE_STRING, &service->domains[i]);
 }
 
-static void append_domainconfig(DBusMessageIter *iter, void *user_data)
+static void append_domain(DBusMessageIter *iter, void *user_data)
 {
        struct connman_service *service = user_data;
-       int i;
 
-       if (service->domains == NULL)
+       if (is_connected(service) == FALSE &&
+                               is_connecting(service) == FALSE)
                return;
 
-       for (i = 0; service->domains[i]; i++)
+       if (service->domains != NULL)
+               append_domainconfig(iter, user_data);
+       else if (service->domainname != NULL)
                dbus_message_iter_append_basic(iter,
-                               DBUS_TYPE_STRING, &service->domains[i]);
+                               DBUS_TYPE_STRING, &service->domainname);
 }
 
 static void append_proxies(DBusMessageIter *iter, void *user_data)
@@ -2232,6 +2240,14 @@ int __connman_service_get_index(struct connman_service *service)
        return -1;
 }
 
+void __connman_service_set_hidden(struct connman_service *service)
+{
+       if (service == NULL || service->hidden == TRUE)
+               return;
+
+       service->hidden_service = TRUE;
+}
+
 void __connman_service_set_domainname(struct connman_service *service,
                                                const char *domainname)
 {
@@ -3795,22 +3811,34 @@ static void service_schedule_removed(struct connman_service *service)
        service_schedule_changed();
 }
 
-static GDBusMethodTable service_methods[] = {
-       { "GetProperties", "",   "a{sv}", get_properties     },
-       { "SetProperty",   "sv", "",      set_property       },
-       { "ClearProperty", "s",  "",      clear_property     },
-       { "Connect",       "",   "",      connect_service,
-                                               G_DBUS_METHOD_FLAG_ASYNC },
-       { "Disconnect",    "",   "",      disconnect_service },
-       { "Remove",        "",   "",      remove_service     },
-       { "MoveBefore",    "o",  "",      move_before        },
-       { "MoveAfter",     "o",  "",      move_after         },
-       { "ResetCounters", "",   "",      reset_counters     },
+static const GDBusMethodTable service_methods[] = {
+       { GDBUS_DEPRECATED_METHOD("GetProperties",
+                       NULL, GDBUS_ARGS({ "properties", "a{sv}" }),
+                       get_properties) },
+       { GDBUS_METHOD("SetProperty",
+                       GDBUS_ARGS({ "name", "s" }, { "value", "v" }),
+                       NULL, set_property) },
+       { GDBUS_METHOD("ClearProperty",
+                       GDBUS_ARGS({ "name", "s" }), NULL,
+                       clear_property) },
+       { GDBUS_ASYNC_METHOD("Connect", NULL, NULL,
+                             connect_service) },
+       { GDBUS_METHOD("Disconnect", NULL, NULL,
+                       disconnect_service) },
+       { GDBUS_METHOD("Remove", NULL, NULL, remove_service) },
+       { GDBUS_METHOD("MoveBefore",
+                       GDBUS_ARGS({ "service", "o" }), NULL,
+                       move_before) },
+       { GDBUS_METHOD("MoveAfter",
+                       GDBUS_ARGS({ "service", "o" }), NULL,
+                       move_after) },
+       { GDBUS_METHOD("ResetCounters", NULL, NULL, reset_counters) },
        { },
 };
 
-static GDBusSignalTable service_signals[] = {
-       { "PropertyChanged", "sv" },
+static const GDBusSignalTable service_signals[] = {
+       { GDBUS_SIGNAL("PropertyChanged",
+                       GDBUS_ARGS({ "name", "s" }, { "value", "v" })) },
        { },
 };
 
@@ -4315,6 +4343,13 @@ void __connman_service_set_string(struct connman_service *service,
        }
 }
 
+void __connman_service_set_userconnect(struct connman_service *service,
+                                               connman_bool_t userconnect)
+{
+       if (service != NULL)
+               service->userconnect = userconnect;
+}
+
 static void service_complete(struct connman_service *service)
 {
        reply_pending(service, EIO);
@@ -4332,9 +4367,12 @@ static void report_error_cb(struct connman_service *service,
        if (retry == TRUE)
                __connman_service_connect(service);
        else {
+               /* It is not relevant to stay on Failure state
+                * when failing is due to wrong user input */
+               service->state = CONNMAN_SERVICE_STATE_IDLE;
+
                service_complete(service);
                __connman_connection_update_gateway();
-               __connman_device_request_scan(CONNMAN_DEVICE_TYPE_UNKNOWN);
        }
 }
 
@@ -4402,13 +4440,23 @@ static void request_input_cb (struct connman_service *service,
                        const char *name, int name_len,
                        const char *identity, const char *passphrase,
                        gboolean wps, const char *wpspin,
-                       void *user_data)
+                       const char *error, void *user_data)
 {
        struct connman_device *device;
        int err = 0;
 
        DBG ("RequestInput return, %p", service);
 
+       if (error != NULL) {
+               DBG("error: %s", error);
+
+               if (g_strcmp0(error,
+                               "net.connman.Agent.Error.Canceled") == 0) {
+                       err = -EINVAL;
+                       goto done;
+               }
+       }
+
        if (service->hidden == TRUE && name_len > 0 && name_len <= 32) {
                device = connman_network_get_device(service->network);
                __connman_device_request_hidden_scan(device,
@@ -4417,10 +4465,8 @@ static void request_input_cb (struct connman_service *service,
        }
 
        if (values_received == FALSE || service->hidden == TRUE) {
-               service_complete(service);
-               __connman_connection_update_gateway();
-               __connman_device_request_scan(CONNMAN_DEVICE_TYPE_UNKNOWN);
-               return;
+               err = -EINVAL;
+               goto done;
        }
 
        if (wps == TRUE && service->network != NULL) {
@@ -4450,6 +4496,13 @@ static void request_input_cb (struct connman_service *service,
                __connman_agent_report_error(service,
                                        error2string(service->error),
                                        report_error_cb, NULL);
+       } else {
+               /* It is not relevant to stay on Failure state
+                * when failing is due to wrong user input */
+               service->state = CONNMAN_SERVICE_STATE_IDLE;
+
+               service_complete(service);
+               __connman_connection_update_gateway();
        }
 }
 
@@ -4573,8 +4626,6 @@ static int service_indicate_state(struct connman_service *service)
                reconnect = get_reconnect_state(service);
                if (reconnect == TRUE)
                        __connman_service_auto_connect();
-
-               __connman_device_request_scan(CONNMAN_DEVICE_TYPE_UNKNOWN);
        }
 
        if (new_state == CONNMAN_SERVICE_STATE_READY) {
@@ -4667,11 +4718,9 @@ static int service_indicate_state(struct connman_service *service)
                if (service->userconnect == TRUE &&
                        __connman_agent_report_error(service,
                                        error2string(service->error),
-                                       report_error_cb, NULL) == -EIO)
+                                       report_error_cb, NULL) == -EINPROGRESS)
                        return 0;
                service_complete(service);
-
-               __connman_device_request_scan(CONNMAN_DEVICE_TYPE_UNKNOWN);
        } else
                service->error = CONNMAN_SERVICE_ERROR_UNKNOWN;
 
@@ -5203,13 +5252,6 @@ int __connman_service_connect(struct connman_service *service)
                return -EINPROGRESS;
        }
 
-       __connman_service_ipconfig_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_FAILURE,
-                                       CONNMAN_IPCONFIG_TYPE_IPV4);
-       __connman_service_ipconfig_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_FAILURE,
-                                       CONNMAN_IPCONFIG_TYPE_IPV6);
-
        if (service->network != NULL)
                __connman_network_disconnect(service->network);
        else if (service->type == CONNMAN_SERVICE_TYPE_VPN &&
@@ -5218,10 +5260,8 @@ int __connman_service_connect(struct connman_service *service)
 
        if (service->userconnect == TRUE) {
                if (err == -ENOKEY || err == -EPERM) {
-                       if (__connman_agent_request_passphrase_input(service,
-                                                       request_input_cb,
-                                                       NULL) == -EIO)
-                               return -EINPROGRESS;
+                       return __connman_agent_request_passphrase_input(service,
+                                       request_input_cb, NULL);
                }
                reply_pending(service, -err);
        }
@@ -5887,7 +5927,7 @@ struct connman_service * __connman_service_create_from_network(struct connman_ne
 
        if (service->favorite == TRUE) {
                device = connman_network_get_device(service->network);
-               if (device && __connman_device_scanning(device) == FALSE)
+               if (device && connman_device_get_scanning(device) == FALSE)
                        __connman_service_auto_connect();
        }