[SPIN] Enable state changed even if service changed scheduled.
[platform/upstream/connman.git] / src / service.c
old mode 100644 (file)
new mode 100755 (executable)
index 7cf4904..4931216
@@ -77,6 +77,14 @@ struct connman_service_user {
        uid_t current_user;
 };
 
+#if defined TIZEN_TV_EXT
+enum connman_dnsconfig_method {
+       CONNMAN_DNSCONFIG_METHOD_UNKNOWN = 0,
+       CONNMAN_DNSCONFIG_METHOD_MANUAL  = 1,
+       CONNMAN_DNSCONFIG_METHOD_DHCP    = 2,
+};
+#endif
+
 struct connman_service {
        int refcount;
        char *identifier;
@@ -419,6 +427,33 @@ static enum connman_service_proxy_method string2proxymethod(const char *method)
                return CONNMAN_SERVICE_PROXY_METHOD_UNKNOWN;
 }
 
+#if defined TIZEN_TV_EXT
+static const char *__connman_dnsconfig_method2string(enum connman_dnsconfig_method method)
+{
+       switch (method) {
+       case CONNMAN_DNSCONFIG_METHOD_UNKNOWN:
+               return "unknown";
+       case CONNMAN_DNSCONFIG_METHOD_MANUAL:
+               return "manual";
+       case CONNMAN_DNSCONFIG_METHOD_DHCP:
+               return "dhcp";
+       }
+
+       return NULL;
+}
+
+static enum connman_dnsconfig_method __connman_dnsconfig_string2method(
+               const char *method)
+{
+       if (g_strcmp0(method, "manual") == 0)
+               return CONNMAN_DNSCONFIG_METHOD_MANUAL;
+       else if (g_strcmp0(method, "dhcp") == 0)
+               return CONNMAN_DNSCONFIG_METHOD_DHCP;
+       else
+               return CONNMAN_DNSCONFIG_METHOD_UNKNOWN;
+}
+#endif
+
 static bool
 connman_service_is_user_allowed(struct connman_service *service, uid_t uid)
 {
@@ -437,6 +472,7 @@ connman_service_is_user_allowed(struct connman_service *service, uid_t uid)
        return true;
 }
 
+#if !defined TIZEN_EXT
 static GList *connman_service_get_login_users()
 {
        struct utmpx *utmp;
@@ -462,9 +498,13 @@ static GList *connman_service_get_login_users()
 
        return user_list;
 }
+#endif
 
 static bool is_service_owner_user_login(struct connman_service *service)
 {
+#if defined TIZEN_EXT
+       return true;
+#else
        GList *list, *user_list;
        bool ret = false;
 
@@ -494,6 +534,7 @@ static bool is_service_owner_user_login(struct connman_service *service)
        g_list_free(user_list);
 
        return ret;
+#endif
 }
 
 int __connman_service_load_modifiable(struct connman_service *service)
@@ -639,6 +680,8 @@ static int service_load(struct connman_service *service)
 
                                connman_network_set_blob(service->network,
                                        "WiFi.SSID", ssid, hex_ssid_len / 2);
+
+                               g_free(ssid);
                        }
 
                        g_free(hex_ssid);
@@ -691,6 +734,13 @@ static int service_load(struct connman_service *service)
                service->nameservers_config = NULL;
        }
 
+#if defined TIZEN_TV_EXT
+       char *dns_method;
+       dns_method = g_key_file_get_string(keyfile, service->identifier,
+                       "Nameservers.method", NULL);
+       service->dns_config_method = __connman_dnsconfig_string2method(dns_method);
+#endif
+
        service->timeservers_config = g_key_file_get_string_list(keyfile,
                        service->identifier, "Timeservers", &length, NULL);
        if (service->timeservers_config && length == 0) {
@@ -736,6 +786,60 @@ static int service_load(struct connman_service *service)
        service->hidden_service = g_key_file_get_boolean(keyfile,
                                        service->identifier, "Hidden", NULL);
 
+#if defined TIZEN_EXT
+       if (service->type == CONNMAN_SERVICE_TYPE_WIFI &&
+                       service->security == CONNMAN_SERVICE_SECURITY_8021X) {
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "EAP", NULL);
+               if (str != NULL) {
+                       g_free(service->eap);
+                       service->eap = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "Phase2", NULL);
+               if (str != NULL) {
+                       g_free(service->phase2);
+                       service->phase2 = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "Identity", NULL);
+               if (str != NULL) {
+                       g_free(service->identity);
+                       service->identity = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "CACertFile", NULL);
+               if (str != NULL) {
+                       g_free(service->ca_cert_file);
+                       service->ca_cert_file = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "ClientCertFile", NULL);
+               if (str != NULL) {
+                       g_free(service->client_cert_file);
+                       service->client_cert_file = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "PrivateKeyFile", NULL);
+               if (str != NULL) {
+                       g_free(service->private_key_file);
+                       service->private_key_file = str;
+               }
+
+               str = g_key_file_get_string(keyfile,
+                               service->identifier, "PrivateKeyPassphrase", NULL);
+               if (str != NULL) {
+                       g_free(service->private_key_passphrase);
+                       service->private_key_passphrase = str;
+               }
+       }
+#endif
+
        if (g_key_file_has_key(keyfile, service->identifier, "UID", NULL))
                service->user.favorite_user = g_key_file_get_integer(keyfile,
                                        service->identifier, "UID", NULL);
@@ -873,6 +977,18 @@ static int service_save(struct connman_service *service)
        g_key_file_remove_key(keyfile, service->identifier,
                                                        "Nameservers", NULL);
 
+#if defined TIZEN_TV_EXT
+       if(service->dns_config_method != 0) {
+               const char *method;
+               method = __connman_dnsconfig_method2string(
+                               service->dns_config_method);
+               g_key_file_set_string(keyfile, service->identifier,
+                               "Nameservers.method", method);
+       } else
+       g_key_file_remove_key(keyfile, service->identifier,
+                                               "Nameservers.method", NULL);
+#endif
+
        if (service->timeservers_config) {
                guint len = g_strv_length(service->timeservers_config);
 
@@ -938,6 +1054,60 @@ static int service_save(struct connman_service *service)
                g_key_file_set_string(keyfile, service->identifier,
                                "Config.ident", service->config_entry);
 
+#if defined TIZEN_EXT
+       if (service->type == CONNMAN_SERVICE_TYPE_WIFI &&
+                       service->security == CONNMAN_SERVICE_SECURITY_8021X) {
+               if (service->eap != NULL && strlen(service->eap) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "EAP", service->eap);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "EAP", NULL);
+
+               if (service->phase2 != NULL && strlen(service->phase2) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "Phase2", service->phase2);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "Phase2", NULL);
+
+               if (service->identity != NULL && strlen(service->identity) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "Identity", service->identity);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "Identity", NULL);
+
+               if (service->ca_cert_file != NULL && strlen(service->ca_cert_file) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "CACertFile", service->ca_cert_file);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "CACertFile", NULL);
+
+               if (service->client_cert_file != NULL && strlen(service->client_cert_file) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "ClientCertFile", service->client_cert_file);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "ClientCertFile", NULL);
+
+               if (service->private_key_file != NULL && strlen(service->private_key_file) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "PrivateKeyFile", service->private_key_file);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "PrivateKeyFile", NULL);
+
+               if (service->private_key_passphrase != NULL && strlen(service->private_key_passphrase) > 0)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                       "PrivateKeyPassphrase", service->private_key_passphrase);
+               else
+                       g_key_file_remove_key(keyfile, service->identifier,
+                                       "PrivateKeyPassphrase", NULL);
+       }
+#endif
+
 done:
        __connman_storage_save_service(keyfile, service->identifier);
 
@@ -1110,146 +1280,155 @@ static bool is_connected(struct connman_service *service)
        return is_connected_state(service, service->state);
 }
 
-static int nameserver_get_index(struct connman_service *service)
+static bool nameserver_available(struct connman_service *service,
+                               const char *ns)
 {
-       switch (combine_state(service->state_ipv4, service->state_ipv6)) {
-       case CONNMAN_SERVICE_STATE_UNKNOWN:
-       case CONNMAN_SERVICE_STATE_IDLE:
-       case CONNMAN_SERVICE_STATE_ASSOCIATION:
-       case CONNMAN_SERVICE_STATE_CONFIGURATION:
-       case CONNMAN_SERVICE_STATE_FAILURE:
-       case CONNMAN_SERVICE_STATE_DISCONNECT:
-               return -1;
-       case CONNMAN_SERVICE_STATE_READY:
-       case CONNMAN_SERVICE_STATE_ONLINE:
-               break;
-       }
+       int family;
 
-       return __connman_service_get_index(service);
+       family = connman_inet_check_ipaddress(ns);
+
+       if (family == AF_INET)
+               return is_connected_state(service, service->state_ipv4);
+
+       if (family == AF_INET6)
+               return is_connected_state(service, service->state_ipv6);
+
+       return false;
 }
 
-static void remove_nameservers(struct connman_service *service,
-               int index, char **ns)
+static int nameserver_add(struct connman_service *service,
+                       const char *nameserver)
 {
-       int i;
-
-       if (!ns)
-               return;
+       int index;
 
-       if (index < 0)
-               index = nameserver_get_index(service);
+       if (!nameserver_available(service, nameserver))
+               return 0;
 
+       index = __connman_service_get_index(service);
        if (index < 0)
-                       return;
+               return -ENXIO;
 
-       for (i = 0; ns[i]; i++)
-               connman_resolver_remove(index, NULL, ns[i]);
+       return connman_resolver_append(index, NULL, nameserver);
 }
 
-static void remove_searchdomains(struct connman_service *service,
-               int index, char **sd)
+static int nameserver_add_all(struct connman_service *service)
 {
-       int i;
+       int i = 0;
 
-       if (!sd)
-               return;
+       if (service->nameservers_config) {
+               while (service->nameservers_config[i]) {
+                       nameserver_add(service, service->nameservers_config[i]);
+                       i++;
+               }
 
-       if (index < 0)
-               index = nameserver_get_index(service);
+               return 0;
+       }
 
-       if (index < 0)
-               return;
+       if (service->nameservers) {
+               while (service->nameservers[i]) {
+                       nameserver_add(service, service->nameservers[i]);
+                       i++;
+               }
+       }
 
-       for (i = 0; sd[i]; i++)
-               connman_resolver_remove(index, sd[i], NULL);
+       return 0;
 }
 
-static bool nameserver_available(struct connman_service *service, char *ns)
+static int nameserver_remove(struct connman_service *service,
+                       const char *nameserver)
 {
-       int family;
-
-       family = connman_inet_check_ipaddress(ns);
+       int index;
 
-       if (family == AF_INET)
-               return is_connected_state(service, service->state_ipv4);
+       if (!nameserver_available(service, nameserver))
+               return 0;
 
-       if (family == AF_INET6)
-               return is_connected_state(service, service->state_ipv6);
+       index = __connman_service_get_index(service);
+       if (index < 0)
+               return -ENXIO;
 
-       return false;
+       return connman_resolver_remove(index, NULL, nameserver);
 }
 
-static void update_nameservers(struct connman_service *service)
+static int nameserver_remove_all(struct connman_service *service)
 {
-       int index;
-       char *ns;
+#if defined TIZEN_EXT
+       /**
+         * Skip this function if there is any connected profiles
+         * that use same interface
+         */
+       if (service->type == CONNMAN_SERVICE_TYPE_CELLULAR &&
+                       __connman_service_get_connected_count_of_iface(service) > 0)
+               return 0;
+#endif
+       int index, i = 0;
 
        index = __connman_service_get_index(service);
        if (index < 0)
-               return;
+               return -ENXIO;
 
-       switch (combine_state(service->state_ipv4, service->state_ipv6)) {
-       case CONNMAN_SERVICE_STATE_UNKNOWN:
-       case CONNMAN_SERVICE_STATE_IDLE:
-       case CONNMAN_SERVICE_STATE_ASSOCIATION:
-       case CONNMAN_SERVICE_STATE_CONFIGURATION:
-               return;
-       case CONNMAN_SERVICE_STATE_FAILURE:
-       case CONNMAN_SERVICE_STATE_DISCONNECT:
-               connman_resolver_remove_all(index);
-               return;
-       case CONNMAN_SERVICE_STATE_READY:
-       case CONNMAN_SERVICE_STATE_ONLINE:
-               break;
+       while (service->nameservers_config && service->nameservers_config[i]) {
+
+               nameserver_remove(service, service->nameservers_config[i]);
+               i++;
        }
 
-       if (service->nameservers_config) {
-               int i;
+       i = 0;
+       while (service->nameservers && service->nameservers[i]) {
+               nameserver_remove(service, service->nameservers[i]);
+               i++;
+       }
 
-               remove_nameservers(service, index, service->nameservers);
+       return 0;
+}
 
-               i = g_strv_length(service->nameservers_config);
-               while (i != 0) {
-                       i--;
+static int searchdomain_add_all(struct connman_service *service)
+{
+       int index, i = 0;
 
-                       ns = service->nameservers_config[i];
+       if (!is_connected(service))
+               return -ENOTCONN;
 
-                       if (nameserver_available(service, ns))
-                               connman_resolver_append(index, NULL, ns);
+       index = __connman_service_get_index(service);
+       if (index < 0)
+               return -ENXIO;
+
+       if (service->domains) {
+               while (service->domains[i]) {
+                       connman_resolver_append(index, service->domains[i],
+                                               NULL);
+                       i++;
                }
-       } else if (service->nameservers) {
-               int i;
 
-               remove_nameservers(service, index, service->nameservers);
+               return 0;
+       }
 
-               i = g_strv_length(service->nameservers);
-               while (i != 0) {
-                       i--;
+       if (service->domainname)
+               connman_resolver_append(index, service->domainname, NULL);
 
-                       ns = service->nameservers[i];
+       return 0;
 
-                       if (nameserver_available(service, ns))
-                               connman_resolver_append(index, NULL, ns);
-               }
-       }
+}
 
-       if (service->domains) {
-               char *searchdomains[2] = {NULL, NULL};
-               int i;
+static int searchdomain_remove_all(struct connman_service *service)
+{
+       int index, i = 0;
 
-               searchdomains[0] = service->domainname;
-               remove_searchdomains(service, index, searchdomains);
+       if (!is_connected(service))
+               return -ENOTCONN;
 
-               i = g_strv_length(service->domains);
-               while (i != 0) {
-                       i--;
-                       connman_resolver_append(index, service->domains[i],
-                                               NULL);
-               }
-       } else if (service->domainname)
-               connman_resolver_append(index, service->domainname, NULL);
+       index = __connman_service_get_index(service);
+       if (index < 0)
+               return -ENXIO;
+
+       while (service->domains && service->domains[i]) {
+               connman_resolver_remove(index, service->domains[i], NULL);
+               i++;
+       }
 
-       connman_resolver_flush();
+       if (service->domainname)
+               connman_resolver_remove(index, service->domainname, NULL);
+
+       return 0;
 }
 
 /*
@@ -1294,11 +1473,16 @@ int __connman_service_nameserver_append(struct connman_service *service,
 
        nameservers[len + 1] = NULL;
 
+#if defined TIZEN_TV_EXT
+       if(service->dns_config_method == CONNMAN_DNSCONFIG_METHOD_UNKNOWN)
+               service->dns_config_method = CONNMAN_DNSCONFIG_METHOD_DHCP;
+#endif
+
        if (is_auto) {
                service->nameservers_auto = nameservers;
        } else {
                service->nameservers = nameservers;
-               update_nameservers(service);
+               nameserver_add(service, nameserver);
        }
 
        return 0;
@@ -1336,13 +1520,8 @@ int __connman_service_nameserver_remove(struct connman_service *service,
        len = g_strv_length(nameservers);
 
        if (len == 1) {
-               g_strfreev(nameservers);
-               if (is_auto)
-                       service->nameservers_auto = NULL;
-               else
-                       service->nameservers = NULL;
-
-               return 0;
+               servers = NULL;
+               goto set_servers;
        }
 
        servers = g_try_new0(char *, len);
@@ -1350,15 +1529,17 @@ int __connman_service_nameserver_remove(struct connman_service *service,
                return -ENOMEM;
 
        for (i = 0, j = 0; i < len; i++) {
-               if (g_strcmp0(nameservers[i], nameserver) != 0) {
-                       servers[j] = g_strdup(nameservers[i]);
-                       if (!servers[j])
-                               return -ENOMEM;
+               if (g_strcmp0(nameservers[i], nameserver)) {
+                       servers[j] = nameservers[i];
                        j++;
-               }
+               } else
+                       g_free(nameservers[i]);
+
+               nameservers[i] = NULL;
        }
        servers[len - 1] = NULL;
 
+set_servers:
        g_strfreev(nameservers);
        nameservers = servers;
 
@@ -1366,7 +1547,7 @@ int __connman_service_nameserver_remove(struct connman_service *service,
                service->nameservers_auto = nameservers;
        } else {
                service->nameservers = nameservers;
-               update_nameservers(service);
+               nameserver_remove(service, nameserver);
        }
 
        return 0;
@@ -1374,10 +1555,12 @@ int __connman_service_nameserver_remove(struct connman_service *service,
 
 void __connman_service_nameserver_clear(struct connman_service *service)
 {
+       nameserver_remove_all(service);
+
        g_strfreev(service->nameservers);
        service->nameservers = NULL;
 
-       update_nameservers(service);
+       nameserver_add_all(service);
 }
 
 static void add_nameserver_route(int family, int index, char *nameserver,
@@ -1405,14 +1588,18 @@ static void add_nameserver_route(int family, int index, char *nameserver,
 static void nameserver_add_routes(int index, char **nameservers,
                                        const char *gw)
 {
-       int i, family;
+       int i, ns_family, gw_family;
+
+       gw_family = connman_inet_check_ipaddress(gw);
+       if (gw_family < 0)
+               return;
 
        for (i = 0; nameservers[i]; i++) {
-               family = connman_inet_check_ipaddress(nameservers[i]);
-               if (family < 0)
+               ns_family = connman_inet_check_ipaddress(nameservers[i]);
+               if (ns_family < 0 || ns_family != gw_family)
                        continue;
 
-               add_nameserver_route(family, index, nameservers[i], gw);
+               add_nameserver_route(ns_family, index, nameservers[i], gw);
        }
 }
 
@@ -1677,9 +1864,15 @@ static void default_changed(void)
                current_default ? current_default->identifier : "");
        DBG("new default %p %s", service, service ? service->identifier : "");
 
+#if defined TIZEN_EXT
+       current_default = service;
+
+       __connman_service_timeserver_changed(service, NULL);
+#else
        __connman_service_timeserver_changed(current_default, NULL);
 
        current_default = service;
+#endif
 
        if (service) {
                if (service->hostname &&
@@ -1703,8 +1896,10 @@ static void state_changed(struct connman_service *service)
        if (!str)
                return;
 
+#if !defined TIZEN_EXT
        if (!allow_property_changed(service))
                return;
+#endif
 
        connman_dbus_property_changed_basic(service->path,
                                CONNMAN_SERVICE_INTERFACE, "State",
@@ -1899,6 +2094,15 @@ static void append_dns(DBusMessageIter *iter, void *user_data)
        if (!is_connected(service))
                return;
 
+#if defined TIZEN_TV_EXT
+       /* Append DNS Config Type */
+       const char *str;
+       str = __connman_dnsconfig_method2string(service->dns_config_method);
+       if(str != NULL)
+               dbus_message_iter_append_basic(iter,
+                       DBUS_TYPE_STRING, &str);
+#endif
+
        if (service->nameservers_config) {
                append_nameservers(iter, service, service->nameservers_config);
                return;
@@ -1927,6 +2131,15 @@ static void append_dnsconfig(DBusMessageIter *iter, void *user_data)
 {
        struct connman_service *service = user_data;
 
+#if defined TIZEN_TV_EXT
+       /* Append DNS Config Type */
+       const char *str;
+       str = __connman_dnsconfig_method2string(service->dns_config_method);
+       if(str != NULL)
+               dbus_message_iter_append_basic(iter,
+                       DBUS_TYPE_STRING, &str);
+#endif
+
        if (!service->nameservers_config)
                return;
 
@@ -2546,6 +2759,13 @@ static void append_properties(DBusMessageIter *dict, dbus_bool_t limited,
                connman_dbus_dict_append_basic(dict, "State",
                                                DBUS_TYPE_STRING, &str);
 
+#if defined TIZEN_TV_EXT
+       str = state2string(service->state_ipv6);
+       if (str != NULL)
+               connman_dbus_dict_append_basic(dict, "StateIPv6",
+                                               DBUS_TYPE_STRING, &str);
+#endif
+
        str = error2string(service->error);
        if (str)
                connman_dbus_dict_append_basic(dict, "Error",
@@ -3216,7 +3436,6 @@ int __connman_service_set_passphrase(struct connman_service *service,
        if (service->network)
                connman_network_set_string(service->network, "WiFi.Passphrase",
                                service->passphrase);
-       service_save(service);
 
        return 0;
 }
@@ -3229,16 +3448,6 @@ const char *__connman_service_get_passphrase(struct connman_service *service)
        return service->passphrase;
 }
 
-static void clear_passphrase(struct connman_service *service)
-{
-       g_free(service->passphrase);
-       service->passphrase = NULL;
-
-       if (service->network)
-               connman_network_set_string(service->network, "WiFi.Passphrase",
-                               service->passphrase);
-}
-
 static DBusMessage *get_properties(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -3601,6 +3810,18 @@ static DBusMessage *set_property(DBusConnection *conn,
                        const char *val;
                        dbus_message_iter_get_basic(&entry, &val);
                        dbus_message_iter_next(&entry);
+#if defined TIZEN_TV_EXT
+                       /* First unpack the DNS Config Method */
+                       if(g_strcmp0(val, "manual") == 0) {
+                               service->dns_config_method =
+                                       CONNMAN_DNSCONFIG_METHOD_MANUAL;
+                               continue;
+                       } else if(g_strcmp0(val, "dhcp") == 0) {
+                               service->dns_config_method =
+                                       CONNMAN_DNSCONFIG_METHOD_DHCP;
+                               continue;
+                       }
+#endif
                        if (connman_inet_check_ipaddress(val) > 0) {
                                if (str->len > 0)
                                        g_string_append_printf(str, " %s", val);
@@ -3609,7 +3830,7 @@ static DBusMessage *set_property(DBusConnection *conn,
                        }
                }
 
-               remove_nameservers(service, -1, service->nameservers_config);
+               nameserver_remove_all(service);
                g_strfreev(service->nameservers_config);
 
                if (str->len > 0) {
@@ -3624,7 +3845,7 @@ static DBusMessage *set_property(DBusConnection *conn,
                if (gw && strlen(gw))
                        __connman_service_nameserver_add_routes(service, gw);
 
-               update_nameservers(service);
+               nameserver_add_all(service);
                dns_configuration_changed(service);
 
                if (__connman_service_is_connected_state(service,
@@ -3711,7 +3932,7 @@ static DBusMessage *set_property(DBusConnection *conn,
                                g_string_append(str, val);
                }
 
-               remove_searchdomains(service, -1, service->domains);
+               searchdomain_remove_all(service);
                g_strfreev(service->domains);
 
                if (str->len > 0)
@@ -3721,7 +3942,7 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                g_string_free(str, TRUE);
 
-               update_nameservers(service);
+               searchdomain_add_all(service);
                domain_configuration_changed(service);
                domain_changed(service);
 
@@ -3774,10 +3995,13 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                if (err < 0) {
                        if (is_connected_state(service, state) ||
-                                       is_connecting_state(service, state))
-                               __connman_network_set_ipconfig(service->network,
-                                               service->ipconfig_ipv4,
-                                               service->ipconfig_ipv6);
+                                       is_connecting_state(service, state)) {
+                               __connman_network_enable_ipconfig(service->network,
+                                                       service->ipconfig_ipv4);
+                               __connman_network_enable_ipconfig(service->network,
+                                                       service->ipconfig_ipv6);
+                       }
+
                        return __connman_error_failed(msg, -err);
                }
 
@@ -3786,10 +4010,12 @@ static DBusMessage *set_property(DBusConnection *conn,
                else
                        ipv6_configuration_changed(service);
 
-               if (is_connecting(service) || is_connected(service))
-                       __connman_network_set_ipconfig(service->network,
-                                       service->ipconfig_ipv4,
-                                       service->ipconfig_ipv6);
+               if (is_connecting(service) || is_connected(service)) {
+                       __connman_network_enable_ipconfig(service->network,
+                                                       service->ipconfig_ipv4);
+                       __connman_network_enable_ipconfig(service->network,
+                                                       service->ipconfig_ipv6);
+               }
 
                service_save(service);
        } else
@@ -3811,19 +4037,27 @@ static void set_error(struct connman_service *service,
        if (!service->path)
                return;
 
+       if (!allow_property_changed(service))
+               return;
+
        str = error2string(service->error);
 
        if (!str)
                str = "";
 
-       if (!allow_property_changed(service))
-               return;
-
        connman_dbus_property_changed_basic(service->path,
                                CONNMAN_SERVICE_INTERFACE, "Error",
                                DBUS_TYPE_STRING, &str);
 }
 
+static void set_idle(struct connman_service *service)
+{
+       service->state = service->state_ipv4 = service->state_ipv6 =
+                                               CONNMAN_SERVICE_STATE_IDLE;
+       set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
+       state_changed(service);
+}
+
 static DBusMessage *clear_property(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
@@ -4030,6 +4264,20 @@ static bool auto_connect_service(GList *services,
                        continue;
                }
 
+#if defined TIZEN_EXT
+               DBG("service %p %s %s %s, favorite(%d), ignore(%d), hidden(%d, %d)",
+                               service, service->name,
+                               state2string(service->state),
+                               __connman_service_type2string(service->type),
+                               service->favorite, is_ignore(service),
+                               service->hidden, service->hidden_service);
+
+               /* Tizen takes Wi-Fi as the highest priority into consideration. */
+               if (service->type != CONNMAN_SERVICE_TYPE_WIFI)
+                       if (is_connecting(service) == TRUE || is_connected(service) == TRUE)
+                               continue;
+#endif
+
                if (service->pending ||
                                is_connecting(service) ||
                                is_connected(service)) {
@@ -4114,7 +4362,23 @@ void __connman_service_auto_connect(enum connman_service_connect_reason reason)
        if (!__connman_session_policy_autoconnect(reason))
                return;
 
+#if defined TIZEN_EXT
+       /* Adding Timeout of 500ms before trying to auto connect.
+        * This is done because of below scenario
+        * 1. Device is connected to AP1
+        * 2. WPS Connection request is initiated for AP2
+        * 3. Immediately WPS Connection is Cancelled
+        * When WPS Connection Connection is initiated for AP2 then
+        * sometimes there is a scenario where connman gets in ASSOCIATED
+        * state with AP1 due to autoconnect and subsequently the connection
+        * initiated by AP1 fails and connman service for AP1 comes in
+        * FAILURE state due to this when connection with AP2 is cancelled
+        * then autoconnect with AP1 doesn't works because its autoconnection
+        * is ignored as its last state was FAILURE rather than IDLE */
+       autoconnect_timeout = g_timeout_add(500, run_auto_connect,
+#else
        autoconnect_timeout = g_timeout_add_seconds(0, run_auto_connect,
+#endif
                                                GUINT_TO_POINTER(reason));
 }
 
@@ -4466,6 +4730,38 @@ bool __connman_service_remove(struct connman_service *service)
        g_free(service->eap);
        service->eap = NULL;
 
+#if defined TIZEN_EXT
+       g_free(service->ca_cert_file);
+       service->ca_cert_file = NULL;
+
+       g_free(service->client_cert_file);
+       service->client_cert_file = NULL;
+
+       g_free(service->private_key_file);
+       service->private_key_file = NULL;
+
+       g_free(service->private_key_passphrase);
+       service->private_key_passphrase = NULL;
+
+       g_free(service->phase2);
+       service->phase2 = NULL;
+
+       __connman_ipconfig_set_method(service->ipconfig_ipv4, CONNMAN_IPCONFIG_METHOD_DHCP);
+       __connman_ipconfig_set_method(service->ipconfig_ipv6, CONNMAN_IPCONFIG_METHOD_AUTO);
+       connman_service_set_proxy(service, NULL, false);
+
+       __connman_service_nameserver_clear(service);
+
+       g_strfreev(service->nameservers_config);
+       service->nameservers_config = NULL;
+
+#endif
+
+#if defined TIZEN_EXT
+       if (service->security != CONNMAN_SERVICE_SECURITY_8021X)
+#endif
+       set_idle(service);
+
        service->error = CONNMAN_SERVICE_ERROR_UNKNOWN;
 
        service->user.favorite_user = USER_NONE;
@@ -4474,7 +4770,11 @@ bool __connman_service_remove(struct connman_service *service)
 
        __connman_ipconfig_ipv6_reset_privacy(service->ipconfig_ipv6);
 
+#if defined TIZEN_EXT
+       __connman_storage_remove_service(service->identifier);
+#else
        service_save(service);
+#endif
 
        return true;
 }
@@ -4495,10 +4795,12 @@ static DBusMessage *remove_service(DBusConnection *conn,
                        return __connman_error_permission_denied(msg);
                }
 
+#if !defined TIZEN_EXT
                if (!connman_service_is_user_allowed(service, uid)) {
                        DBG("Not allow this user to remove this wifi service now!");
                        return __connman_error_permission_denied(msg);
                }
+#endif
        }
 
        if (!__connman_service_remove(service))
@@ -5337,6 +5639,11 @@ bool __connman_service_is_connected_state(struct connman_service *service,
                return is_connected_state(service, service->state_ipv4);
        case CONNMAN_IPCONFIG_TYPE_IPV6:
                return is_connected_state(service, service->state_ipv6);
+       case CONNMAN_IPCONFIG_TYPE_ALL:
+               return is_connected_state(service,
+                                       CONNMAN_IPCONFIG_TYPE_IPV4) &&
+                       is_connected_state(service,
+                                       CONNMAN_IPCONFIG_TYPE_IPV6);
        }
 
        return false;
@@ -5534,32 +5841,14 @@ void __connman_service_set_string(struct connman_service *service,
 void __connman_service_set_search_domains(struct connman_service *service,
                                        char **domains)
 {
-       int index;
-
-       index = __connman_service_get_index(service);
-       if (index < 0)
-               return;
+       searchdomain_remove_all(service);
 
-       if (service->domains) {
-               remove_searchdomains(service, index, service->domains);
+       if (service->domains)
                g_strfreev(service->domains);
 
-               service->domains = g_strdupv(domains);
-
-               update_nameservers(service);
-       }
-}
-
-/*
- * This variant is used when domain search list is updated via
- * dhcp and in that case the service is not yet fully connected so
- * we cannot do same things as what the set() variant is doing.
- */
-void __connman_service_update_search_domains(struct connman_service *service,
-                                       char **domains)
-{
-       g_strfreev(service->domains);
        service->domains = g_strdupv(domains);
+
+       searchdomain_add_all(service);
 }
 
 #if defined TIZEN_EXT
@@ -5638,6 +5927,34 @@ static int check_wpspin(struct connman_service *service, const char *wpspin)
        return 0;
 }
 
+#if defined TIZEN_EXT
+static int __connman_service_connect_hidden(struct connman_service *service,
+                       const char *name, int name_len,
+                       const char *identity, const char *passphrase, void *user_data)
+{
+       GList *list;
+
+       for (list = service_list; list; list = list->next) {
+               struct connman_service *target = list->data;
+               const char *target_ssid = NULL;
+               unsigned int target_ssid_len = 0;
+
+               if (service->network != NULL &&
+                                       service->security == target->security) {
+                       target_ssid = connman_network_get_blob(service->network,
+                                                       "WiFi.SSID", &target_ssid_len);
+                       if (target_ssid_len == name_len &&
+                                                       memcmp(target_ssid, name, name_len) == 0) {
+                               return connman_network_connect_hidden(service->network,
+                                                       (char *)identity, (char *)passphrase, user_data);
+                       }
+               }
+       }
+
+       return -ENOENT;
+}
+#endif
+
 static void request_input_cb(struct connman_service *service,
                        bool values_received,
                        const char *name, int name_len,
@@ -5670,6 +5987,14 @@ static void request_input_cb(struct connman_service *service,
        }
 
        if (service->hidden && name_len > 0 && name_len <= 32) {
+#if defined TIZEN_EXT
+               /* TIZEN already has Wi-Fi hidden scan before this hidden connection */
+               err = __connman_service_connect_hidden(service, name, name_len,
+                                               identity, passphrase, user_data);
+               if (err == 0 || err == -EALREADY || err == -EINPROGRESS)
+                       return;
+#endif
+
                device = connman_network_get_device(service->network);
                security = connman_network_get_string(service->network,
                                                        "WiFi.Security");
@@ -5909,6 +6234,11 @@ static void single_connected_tech(struct connman_service *allowed)
 
        DBG("keeping %p %s", allowed, allowed->path);
 
+#if defined TIZEN_EXT
+       if (!allowed || allowed->type == CONNMAN_SERVICE_TYPE_CELLULAR)
+               return;
+#endif
+
        for (iter = service_list; iter; iter = iter->next) {
                service = iter->data;
 
@@ -5981,6 +6311,10 @@ static int service_indicate_state(struct connman_service *service)
        if (old_state == CONNMAN_SERVICE_STATE_ONLINE)
                __connman_notifier_leave_online(service->type);
 
+       if (is_connected_state(service, old_state) &&
+                       !is_connected_state(service, new_state))
+               searchdomain_remove_all(service);
+
        service->state = new_state;
        state_changed(service);
 
@@ -6015,6 +6349,8 @@ static int service_indicate_state(struct connman_service *service)
                break;
 
        case CONNMAN_SERVICE_STATE_READY:
+               set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
+
                if (service->new_service &&
                                __connman_stats_service_register(service) == 0) {
                        /*
@@ -6043,6 +6379,7 @@ static int service_indicate_state(struct connman_service *service)
                g_get_current_time(&service->modified);
                service_save(service);
 
+               searchdomain_add_all(service);
                dns_changed(service);
                domain_changed(service);
                proxy_changed(service);
@@ -6081,6 +6418,7 @@ static int service_indicate_state(struct connman_service *service)
                break;
 
        case CONNMAN_SERVICE_STATE_DISCONNECT:
+               set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
 
                reply_pending(service, ECONNABORTED);
 
@@ -6137,9 +6475,6 @@ static int service_indicate_state(struct connman_service *service)
                break;
        }
 
-       if (new_state != CONNMAN_SERVICE_STATE_FAILURE)
-               set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
-
        service_list_sort();
 
 #if defined TIZEN_EXT
@@ -6185,17 +6520,10 @@ int __connman_service_indicate_error(struct connman_service *service,
        if (!service)
                return -EINVAL;
 
-       set_error(service, error);
-
-       /*
-        * Supplicant does not always return invalid key error for
-        * WPA-EAP so clear the credentials always.
-        */
-       if (service->error == CONNMAN_SERVICE_ERROR_INVALID_KEY ||
-                       service->security == CONNMAN_SERVICE_SECURITY_8021X)
-               clear_passphrase(service);
+       if (service->state == CONNMAN_SERVICE_STATE_FAILURE)
+               return -EALREADY;
 
-       __connman_service_set_agent_identity(service, NULL);
+       set_error(service, error);
 
        __connman_service_ipconfig_indicate_state(service,
                                                CONNMAN_SERVICE_STATE_FAILURE,
@@ -6399,7 +6727,7 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
                                        enum connman_ipconfig_type type)
 {
        struct connman_ipconfig *ipconfig = NULL;
-       enum connman_service_state *old_state;
+       enum connman_service_state old_state;
        enum connman_ipconfig_method method;
 
        if (!service)
@@ -6407,16 +6735,17 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
 
        switch (type) {
        case CONNMAN_IPCONFIG_TYPE_UNKNOWN:
+       case CONNMAN_IPCONFIG_TYPE_ALL:
                return -EINVAL;
 
        case CONNMAN_IPCONFIG_TYPE_IPV4:
-               old_state = &service->state_ipv4;
+               old_state = service->state_ipv4;
                ipconfig = service->ipconfig_ipv4;
 
                break;
 
        case CONNMAN_IPCONFIG_TYPE_IPV6:
-               old_state = &service->state_ipv6;
+               old_state = service->state_ipv6;
                ipconfig = service->ipconfig_ipv6;
 
                break;
@@ -6426,7 +6755,7 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
                return -EINVAL;
 
        /* Any change? */
-       if (*old_state == new_state)
+       if (old_state == new_state)
                return -EALREADY;
 
 #if defined TIZEN_EXT
@@ -6443,7 +6772,7 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
 
        DBG("service %p (%s) old state %d (%s) new state %d (%s) type %d (%s)",
                service, service ? service->identifier : NULL,
-               *old_state, state2string(*old_state),
+               old_state, state2string(old_state),
                new_state, state2string(new_state),
                type, __connman_ipconfig_type2string(type));
 
@@ -6499,17 +6828,39 @@ int __connman_service_ipconfig_indicate_state(struct connman_service *service,
                break;
 
        case CONNMAN_IPCONFIG_METHOD_FIXED:
-        case CONNMAN_IPCONFIG_METHOD_MANUAL:
-        case CONNMAN_IPCONFIG_METHOD_DHCP:
-        case CONNMAN_IPCONFIG_METHOD_AUTO:
+       case CONNMAN_IPCONFIG_METHOD_MANUAL:
+       case CONNMAN_IPCONFIG_METHOD_DHCP:
+       case CONNMAN_IPCONFIG_METHOD_AUTO:
                break;
 
        }
 
-       *old_state = new_state;
+       if (is_connected_state(service, old_state) &&
+                       !is_connected_state(service, new_state))
+               nameserver_remove_all(service);
+
+       if (type == CONNMAN_IPCONFIG_TYPE_IPV4)
+               service->state_ipv4 = new_state;
+       else
+               service->state_ipv6 = new_state;
+
+       if (!is_connected_state(service, old_state) &&
+                       is_connected_state(service, new_state))
+               nameserver_add_all(service);
 
-       update_nameservers(service);
+#if defined TIZEN_EXT
+       int ret = service_indicate_state(service);
+       /*Sent the Ready changed signal again in case IPv4 IP set
+         after IPv6 IP set*/
+
+       if(ret == -EALREADY && type == CONNMAN_IPCONFIG_TYPE_IPV4
+                       && new_state == CONNMAN_SERVICE_STATE_READY) {
+               DBG("Notify IPv4 state new/old %d/%d", new_state,old_state);
+               state_changed(service);
+       }
 
+       return ret;
+#endif
        return service_indicate_state(service);
 }
 
@@ -6606,6 +6957,9 @@ static int service_connect(struct connman_service *service)
                case CONNMAN_SERVICE_SECURITY_PSK:
                case CONNMAN_SERVICE_SECURITY_WPA:
                case CONNMAN_SERVICE_SECURITY_RSN:
+                       if (service->error == CONNMAN_SERVICE_ERROR_INVALID_KEY)
+                               return -ENOKEY;
+
                        if (service->request_passphrase_input) {
                                DBG("Now try to connect other user's favorite service");
                                service->request_passphrase_input = false;
@@ -6647,9 +7001,10 @@ static int service_connect(struct connman_service *service)
                         * missing. Agent provided credentials can be used as
                         * fallback if needed.
                         */
-                       if ((!service->identity &&
+                       if (((!service->identity &&
                                        !service->agent_identity) ||
-                                       !service->passphrase)
+                                       !service->passphrase) ||
+                                       service->error == CONNMAN_SERVICE_ERROR_INVALID_KEY)
                                return -ENOKEY;
 
                        break;
@@ -6744,16 +7099,14 @@ int __connman_service_connect(struct connman_service *service,
        err = service_connect(service);
 
        service->connect_reason = reason;
-       if (err >= 0) {
-               set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
+       if (err >= 0)
                return 0;
-       }
 
        if (err == -EINPROGRESS) {
                if (service->timeout == 0)
                        service->timeout = g_timeout_add_seconds(
                                CONNECT_TIMEOUT, connect_timeout, service);
-               set_error(service, CONNMAN_SERVICE_ERROR_UNKNOWN);
+
                return -EINPROGRESS;
        }
 
@@ -7544,8 +7897,45 @@ struct connman_service * __connman_service_create_from_network(struct connman_ne
 
        if (service->favorite) {
                device = connman_network_get_device(service->network);
-               if (device && !connman_device_get_scanning(device))
-                       __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+               if (device && !connman_device_get_scanning(device)) {
+
+                       switch (service->type) {
+                       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+                       case CONNMAN_SERVICE_TYPE_SYSTEM:
+                       case CONNMAN_SERVICE_TYPE_P2P:
+                               break;
+
+                       case CONNMAN_SERVICE_TYPE_GADGET:
+                       case CONNMAN_SERVICE_TYPE_ETHERNET:
+                               if (service->autoconnect) {
+                                       __connman_service_connect(service,
+                                               CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+                                       break;
+                               }
+
+                               /* fall through */
+                       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+                       case CONNMAN_SERVICE_TYPE_GPS:
+                       case CONNMAN_SERVICE_TYPE_VPN:
+                       case CONNMAN_SERVICE_TYPE_WIFI:
+                       case CONNMAN_SERVICE_TYPE_CELLULAR:
+                               __connman_service_auto_connect(CONNMAN_SERVICE_CONNECT_REASON_AUTO);
+                               break;
+                       }
+               }
+
+#if defined TIZEN_EXT
+               /* TIZEN synchronizes below information when the service creates */
+               if (service->eap != NULL)
+                       connman_network_set_string(service->network, "WiFi.EAP",
+                                                               service->eap);
+               if (service->identity != NULL)
+                       connman_network_set_string(service->network, "WiFi.Identity",
+                                                               service->identity);
+               if (service->phase2 != NULL)
+                       connman_network_set_string(service->network, "WiFi.Phase2",
+                                                               service->phase2);
+#endif
        }
 
        __connman_notifier_service_add(service, service->name);