Fix update of Ethernet address and MTU values
[framework/connectivity/connman.git] / src / service.c
index 4d1ebaa..21aaba4 100644 (file)
@@ -29,6 +29,8 @@
 
 #include "connman.h"
 
+#define CONNECT_TIMEOUT                120
+
 static DBusConnection *connection = NULL;
 
 static GSequence *service_list = NULL;
@@ -47,13 +49,20 @@ struct connman_service {
        connman_bool_t favorite;
        connman_bool_t hidden;
        connman_bool_t ignore;
+       connman_bool_t autoconnect;
+       connman_bool_t userconnect;
        GTimeVal modified;
        unsigned int order;
        char *name;
        char *passphrase;
        char *profile;
+       char *apn;
+       char *username;
+       char *password;
+       char *mcc;
+       char *mnc;
+       connman_bool_t roaming;
        struct connman_ipconfig *ipconfig;
-       struct connman_device *device;
        struct connman_network *network;
        DBusMessage *pending;
        guint timeout;
@@ -64,17 +73,15 @@ static void append_path(gpointer value, gpointer user_data)
        struct connman_service *service = value;
        DBusMessageIter *iter = user_data;
 
-       if (service->path == NULL)
+       if (service->path == NULL || service->hidden == TRUE)
                return;
 
        dbus_message_iter_append_basic(iter, DBUS_TYPE_OBJECT_PATH,
                                                        &service->path);
 }
 
-void __connman_service_list(DBusMessageIter *iter)
+void __connman_service_list(DBusMessageIter *iter, void *user_data)
 {
-       DBG("");
-
        g_sequence_foreach(service_list, append_path, iter);
 }
 
@@ -106,11 +113,13 @@ static struct connman_service *find_service(const char *path)
        return data.service;
 }
 
-static const char *type2string(enum connman_service_type type)
+const char *__connman_service_type2string(enum connman_service_type type)
 {
        switch (type) {
        case CONNMAN_SERVICE_TYPE_UNKNOWN:
                break;
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+               return "system";
        case CONNMAN_SERVICE_TYPE_ETHERNET:
                return "ethernet";
        case CONNMAN_SERVICE_TYPE_WIFI:
@@ -121,6 +130,8 @@ static const char *type2string(enum connman_service_type type)
                return "bluetooth";
        case CONNMAN_SERVICE_TYPE_CELLULAR:
                return "cellular";
+       case CONNMAN_SERVICE_TYPE_VPN:
+               return "vpn";
        }
 
        return NULL;
@@ -135,6 +146,12 @@ static const char *mode2string(enum connman_service_mode mode)
                return "managed";
        case CONNMAN_SERVICE_MODE_ADHOC:
                return "adhoc";
+       case CONNMAN_SERVICE_MODE_GPRS:
+               return "gprs";
+       case CONNMAN_SERVICE_MODE_EDGE:
+               return "edge";
+       case CONNMAN_SERVICE_MODE_UMTS:
+               return "umts";
        }
 
        return NULL;
@@ -149,6 +166,10 @@ static const char *security2string(enum connman_service_security security)
                return "none";
        case CONNMAN_SERVICE_SECURITY_WEP:
                return "wep";
+       case CONNMAN_SERVICE_SECURITY_PSK:
+               return "psk";
+       case CONNMAN_SERVICE_SECURITY_8021X:
+               return "ieee8021x";
        case CONNMAN_SERVICE_SECURITY_WPA:
                return "wpa";
        case CONNMAN_SERVICE_SECURITY_RSN:
@@ -165,8 +186,6 @@ static const char *state2string(enum connman_service_state state)
                break;
        case CONNMAN_SERVICE_STATE_IDLE:
                return "idle";
-       case CONNMAN_SERVICE_STATE_CARRIER:
-               return "carrier";
        case CONNMAN_SERVICE_STATE_ASSOCIATION:
                return "association";
        case CONNMAN_SERVICE_STATE_CONFIGURATION:
@@ -210,64 +229,205 @@ static enum connman_service_error string2error(const char *error)
        return CONNMAN_SERVICE_ERROR_UNKNOWN;
 }
 
-static void state_changed(struct connman_service *service)
+static struct connman_service *get_default(void)
+{
+       struct connman_service *service;
+       GSequenceIter *iter;
+
+       iter = g_sequence_get_begin_iter(service_list);
+
+       if (g_sequence_iter_is_end(iter) == TRUE)
+               return NULL;
+
+       service = g_sequence_get(iter);
+
+       if (service->state != CONNMAN_SERVICE_STATE_READY)
+               return NULL;
+
+       return service;
+}
+
+static void default_changed(void)
 {
-       DBusMessage *signal;
-       DBusMessageIter entry, value;
-       const char *str, *key = "State";
+       struct connman_service *service = get_default();
 
-       if (service->path == NULL)
+       __connman_notifier_default_changed(service);
+}
+
+const char *__connman_service_default(void)
+{
+       struct connman_service *service;
+
+       service = get_default();
+       if (service == NULL)
+               return "";
+
+       return __connman_service_type2string(service->type);
+}
+
+static void mode_changed(struct connman_service *service)
+{
+       const char *str;
+
+       str = mode2string(service->mode);
+       if (str == NULL)
                return;
 
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "Mode",
+                                               DBUS_TYPE_STRING, &str);
+}
+
+static void state_changed(struct connman_service *service)
+{
+       const char *str;
+
        str = state2string(service->state);
        if (str == NULL)
                return;
 
-       signal = dbus_message_new_signal(service->path,
-                               CONNMAN_SERVICE_INTERFACE, "PropertyChanged");
-       if (signal == NULL)
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "State",
+                                               DBUS_TYPE_STRING, &str);
+}
+
+static void strength_changed(struct connman_service *service)
+{
+       if (service->strength == 0)
                return;
 
-       dbus_message_iter_init_append(signal, &entry);
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "Strength",
+                                       DBUS_TYPE_BYTE, &service->strength);
+}
 
-       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key);
+static void favorite_changed(struct connman_service *service)
+{
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "Favorite",
+                                       DBUS_TYPE_BOOLEAN, &service->favorite);
+}
 
-       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
-                                       DBUS_TYPE_STRING_AS_STRING, &value);
-       dbus_message_iter_append_basic(&value, DBUS_TYPE_STRING, &str);
-       dbus_message_iter_close_container(&entry, &value);
+static void roaming_changed(struct connman_service *service)
+{
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "Roaming",
+                                       DBUS_TYPE_BOOLEAN, &service->roaming);
+}
 
-       g_dbus_send_message(connection, signal);
+static void autoconnect_changed(struct connman_service *service)
+{
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "AutoConnect",
+                               DBUS_TYPE_BOOLEAN, &service->autoconnect);
 }
 
-static void strength_changed(struct connman_service *service)
+static void passphrase_changed(struct connman_service *service)
 {
-       DBusMessage *signal;
-       DBusMessageIter entry, value;
-       const char *key = "Strength";
+       dbus_bool_t required;
 
-       if (service->path == NULL)
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+       case CONNMAN_SERVICE_TYPE_VPN:
                return;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+               required = FALSE;
 
-       if (service->strength == 0)
+               switch (service->security) {
+               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
+               case CONNMAN_SERVICE_SECURITY_NONE:
+               case CONNMAN_SERVICE_SECURITY_8021X:
+                       break;
+               case CONNMAN_SERVICE_SECURITY_WEP:
+               case CONNMAN_SERVICE_SECURITY_PSK:
+               case CONNMAN_SERVICE_SECURITY_WPA:
+               case CONNMAN_SERVICE_SECURITY_RSN:
+                       if (service->passphrase == NULL)
+                               required = TRUE;
+                       break;
+               }
+               break;
+       }
+
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "PassphraseRequired",
+                                               DBUS_TYPE_BOOLEAN, &required);
+}
+
+static void apn_changed(struct connman_service *service)
+{
+       dbus_bool_t required;
+
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+       case CONNMAN_SERVICE_TYPE_WIFI:
+       case CONNMAN_SERVICE_TYPE_VPN:
                return;
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+               break;
+       }
 
-       signal = dbus_message_new_signal(service->path,
-                               CONNMAN_SERVICE_INTERFACE, "PropertyChanged");
-       if (signal == NULL)
+       required = (service->apn == NULL) ? TRUE : FALSE;
+
+       connman_dbus_property_changed_basic(service->path,
+                               CONNMAN_SERVICE_INTERFACE, "SetupRequired",
+                                               DBUS_TYPE_BOOLEAN, &required);
+}
+
+static void append_ethernet(DBusMessageIter *iter, void *user_data)
+{
+       struct connman_service *service = user_data;
+
+       switch (service->state) {
+       case CONNMAN_SERVICE_STATE_UNKNOWN:
+       case CONNMAN_SERVICE_STATE_IDLE:
+       case CONNMAN_SERVICE_STATE_FAILURE:
+       case CONNMAN_SERVICE_STATE_DISCONNECT:
                return;
+       case CONNMAN_SERVICE_STATE_ASSOCIATION:
+       case CONNMAN_SERVICE_STATE_CONFIGURATION:
+       case CONNMAN_SERVICE_STATE_READY:
+               break;
+       }
 
-       dbus_message_iter_init_append(signal, &entry);
+       if (service->ipconfig != NULL)
+               __connman_ipconfig_append_ethernet(service->ipconfig, iter);
+}
 
-       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key);
+static void append_ipv4(DBusMessageIter *iter, void *user_data)
+{
+       struct connman_service *service = user_data;
 
-       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
-                                       DBUS_TYPE_BYTE_AS_STRING, &value);
-       dbus_message_iter_append_basic(&value, DBUS_TYPE_BYTE,
-                                                       &service->strength);
-       dbus_message_iter_close_container(&entry, &value);
+       switch (service->state) {
+       case CONNMAN_SERVICE_STATE_UNKNOWN:
+       case CONNMAN_SERVICE_STATE_IDLE:
+       case CONNMAN_SERVICE_STATE_FAILURE:
+       case CONNMAN_SERVICE_STATE_DISCONNECT:
+       case CONNMAN_SERVICE_STATE_ASSOCIATION:
+       case CONNMAN_SERVICE_STATE_CONFIGURATION:
+               return;
+       case CONNMAN_SERVICE_STATE_READY:
+               break;
+       }
+
+       if (service->ipconfig != NULL)
+               __connman_ipconfig_append_ipv4(service->ipconfig, iter);
+}
 
-       g_dbus_send_message(connection, signal);
+static void settings_changed(struct connman_service *service)
+{
+       connman_dbus_property_changed_dict(service->path,
+                                       CONNMAN_SERVICE_INTERFACE, "IPv4",
+                                                       append_ipv4, service);
 }
 
 static DBusMessage *get_properties(DBusConnection *conn,
@@ -276,6 +436,7 @@ static DBusMessage *get_properties(DBusConnection *conn,
        struct connman_service *service = user_data;
        DBusMessage *reply;
        DBusMessageIter array, dict;
+       dbus_bool_t required;
        const char *str;
 
        DBG("service %p", service);
@@ -286,56 +447,125 @@ static DBusMessage *get_properties(DBusConnection *conn,
 
        dbus_message_iter_init_append(reply, &array);
 
-       dbus_message_iter_open_container(&array, DBUS_TYPE_ARRAY,
-                       DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING
-                       DBUS_TYPE_STRING_AS_STRING DBUS_TYPE_VARIANT_AS_STRING
-                       DBUS_DICT_ENTRY_END_CHAR_AS_STRING, &dict);
+       connman_dbus_dict_open(&array, &dict);
 
-       str = type2string(service->type);
+       str = __connman_service_type2string(service->type);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Type",
+               connman_dbus_dict_append_basic(&dict, "Type",
                                                DBUS_TYPE_STRING, &str);
 
        str = mode2string(service->mode);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Mode",
+               connman_dbus_dict_append_basic(&dict, "Mode",
                                                DBUS_TYPE_STRING, &str);
 
        str = security2string(service->security);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Security",
+               connman_dbus_dict_append_basic(&dict, "Security",
                                                DBUS_TYPE_STRING, &str);
 
        str = state2string(service->state);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "State",
+               connman_dbus_dict_append_basic(&dict, "State",
                                                DBUS_TYPE_STRING, &str);
 
        str = error2string(service->error);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Error",
+               connman_dbus_dict_append_basic(&dict, "Error",
                                                DBUS_TYPE_STRING, &str);
 
        if (service->strength > 0)
-               connman_dbus_dict_append_variant(&dict, "Strength",
+               connman_dbus_dict_append_basic(&dict, "Strength",
                                        DBUS_TYPE_BYTE, &service->strength);
 
-       connman_dbus_dict_append_variant(&dict, "Favorite",
+       connman_dbus_dict_append_basic(&dict, "Favorite",
+                                       DBUS_TYPE_BOOLEAN, &service->favorite);
+
+       if (service->favorite == TRUE)
+               connman_dbus_dict_append_basic(&dict, "AutoConnect",
+                               DBUS_TYPE_BOOLEAN, &service->autoconnect);
+       else
+               connman_dbus_dict_append_basic(&dict, "AutoConnect",
                                        DBUS_TYPE_BOOLEAN, &service->favorite);
 
        if (service->name != NULL)
-               connman_dbus_dict_append_variant(&dict, "Name",
+               connman_dbus_dict_append_basic(&dict, "Name",
                                        DBUS_TYPE_STRING, &service->name);
 
-       if (service->passphrase != NULL &&
-                       __connman_security_check_privilege(msg,
-                               CONNMAN_SECURITY_PRIVILEGE_SECRET) == 0)
-               connman_dbus_dict_append_variant(&dict, "Passphrase",
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+       case CONNMAN_SERVICE_TYPE_VPN:
+               break;
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+               connman_dbus_dict_append_basic(&dict, "Roaming",
+                                       DBUS_TYPE_BOOLEAN, &service->roaming);
+
+               if (service->mcc != NULL && service->mnc != NULL) {
+                       connman_dbus_dict_append_basic(&dict, "MCC",
+                                       DBUS_TYPE_STRING, &service->mcc);
+                       connman_dbus_dict_append_basic(&dict, "MNC",
+                                       DBUS_TYPE_STRING, &service->mnc);
+               }
+
+               if (service->apn != NULL) {
+                       connman_dbus_dict_append_basic(&dict, "APN",
+                                       DBUS_TYPE_STRING, &service->apn);
+
+                       if (service->username != NULL)
+                               connman_dbus_dict_append_basic(&dict,
+                                       "Username", DBUS_TYPE_STRING,
+                                                       &service->username);
+
+                       if (service->password != NULL)
+                               connman_dbus_dict_append_basic(&dict,
+                                       "Password", DBUS_TYPE_STRING,
+                                                       &service->password);
+
+                       required = FALSE;
+               } else
+                       required = TRUE;
+
+               connman_dbus_dict_append_basic(&dict, "SetupRequired",
+                                               DBUS_TYPE_BOOLEAN, &required);
+               break;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+               if (service->passphrase != NULL &&
+                               __connman_security_check_privilege(msg,
+                                       CONNMAN_SECURITY_PRIVILEGE_SECRET) == 0)
+                       connman_dbus_dict_append_basic(&dict, "Passphrase",
                                DBUS_TYPE_STRING, &service->passphrase);
 
-       __connman_ipconfig_append_ipv4(service->ipconfig, &dict, "IPv4.");
+               required = FALSE;
 
-       dbus_message_iter_close_container(&array, &dict);
+               switch (service->security) {
+               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
+               case CONNMAN_SERVICE_SECURITY_NONE:
+               case CONNMAN_SERVICE_SECURITY_8021X:
+                       break;
+               case CONNMAN_SERVICE_SECURITY_WEP:
+               case CONNMAN_SERVICE_SECURITY_PSK:
+               case CONNMAN_SERVICE_SECURITY_WPA:
+               case CONNMAN_SERVICE_SECURITY_RSN:
+                       if (service->passphrase == NULL)
+                               required = TRUE;
+                       break;
+               }
+
+               connman_dbus_dict_append_basic(&dict, "PassphraseRequired",
+                                               DBUS_TYPE_BOOLEAN, &required);
+               /* fall through */
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+               connman_dbus_dict_append_dict(&dict, "Ethernet",
+                                               append_ethernet, service);
+               break;
+       }
+
+       connman_dbus_dict_append_dict(&dict, "IPv4", append_ipv4, service);
+
+       connman_dbus_dict_close(&array, &dict);
 
        return reply;
 }
@@ -363,7 +593,26 @@ static DBusMessage *set_property(DBusConnection *conn,
 
        type = dbus_message_iter_get_arg_type(&value);
 
-       if (g_str_equal(name, "Passphrase") == TRUE) {
+       if (g_str_has_prefix(name, "AutoConnect") == TRUE) {
+               connman_bool_t autoconnect;
+
+               if (type != DBUS_TYPE_BOOLEAN)
+                       return __connman_error_invalid_arguments(msg);
+
+               if (service->favorite == FALSE)
+                       return __connman_error_invalid_service(msg);
+
+               dbus_message_iter_get_basic(&value, &autoconnect);
+
+               if (service->autoconnect == autoconnect)
+                       return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
+
+               service->autoconnect = autoconnect;
+
+               autoconnect_changed(service);
+
+               __connman_storage_save_service(service);
+       } else if (g_str_equal(name, "Passphrase") == TRUE) {
                const char *passphrase;
 
                if (type != DBUS_TYPE_STRING)
@@ -378,18 +627,72 @@ static DBusMessage *set_property(DBusConnection *conn,
                g_free(service->passphrase);
                service->passphrase = g_strdup(passphrase);
 
+               passphrase_changed(service);
+
                if (service->network != NULL)
                        connman_network_set_string(service->network,
                                "WiFi.Passphrase", service->passphrase);
 
                __connman_storage_save_service(service);
-       } else if (g_str_has_prefix(name, "IPv4.") == TRUE) {
-               int err;
+       } else if (g_str_equal(name, "APN") == TRUE) {
+               const char *apn;
 
-               err = __connman_ipconfig_set_ipv4(service->ipconfig,
-                                                       name + 5, &value);
-               if (err < 0)
-                       return __connman_error_failed(msg, -err);
+               if (type != DBUS_TYPE_STRING)
+                       return __connman_error_invalid_arguments(msg);
+
+               if (service->type != CONNMAN_SERVICE_TYPE_CELLULAR)
+                       return __connman_error_invalid_service(msg);
+
+               dbus_message_iter_get_basic(&value, &apn);
+
+               g_free(service->apn);
+               service->apn = g_strdup(apn);
+
+               apn_changed(service);
+
+               if (service->network != NULL)
+                       connman_network_set_string(service->network,
+                                               "Cellular.APN", service->apn);
+
+               __connman_storage_save_service(service);
+       } else if (g_str_equal(name, "Username") == TRUE) {
+               const char *username;
+
+               if (type != DBUS_TYPE_STRING)
+                       return __connman_error_invalid_arguments(msg);
+
+               if (service->type != CONNMAN_SERVICE_TYPE_CELLULAR)
+                       return __connman_error_invalid_service(msg);
+
+               dbus_message_iter_get_basic(&value, &username);
+
+               g_free(service->username);
+               service->username = g_strdup(username);
+
+               if (service->network != NULL)
+                       connman_network_set_string(service->network,
+                                       "Cellular.Username", service->username);
+
+               __connman_storage_save_service(service);
+       } else if (g_str_equal(name, "Password") == TRUE) {
+               const char *password;
+
+               if (type != DBUS_TYPE_STRING)
+                       return __connman_error_invalid_arguments(msg);
+
+               if (service->type != CONNMAN_SERVICE_TYPE_CELLULAR)
+                       return __connman_error_invalid_service(msg);
+
+               dbus_message_iter_get_basic(&value, &password);
+
+               g_free(service->password);
+               service->password = g_strdup(password);
+
+               if (service->network != NULL)
+                       connman_network_set_string(service->network,
+                                       "Cellular.Password", service->password);
+
+               __connman_storage_save_service(service);
        } else
                return __connman_error_invalid_property(msg);
 
@@ -423,6 +726,13 @@ static DBusMessage *clear_property(DBusConnection *conn,
 
                g_get_current_time(&service->modified);
                __connman_storage_save_service(service);
+       } else if (g_str_equal(name, "Passphrase") == TRUE) {
+               g_free(service->passphrase);
+               service->passphrase = NULL;
+
+               passphrase_changed(service);
+
+               __connman_storage_save_service(service);
        } else
                return __connman_error_invalid_property(msg);
 
@@ -434,7 +744,6 @@ static connman_bool_t is_connecting(struct connman_service *service)
        switch (service->state) {
        case CONNMAN_SERVICE_STATE_UNKNOWN:
        case CONNMAN_SERVICE_STATE_IDLE:
-       case CONNMAN_SERVICE_STATE_CARRIER:
        case CONNMAN_SERVICE_STATE_FAILURE:
        case CONNMAN_SERVICE_STATE_DISCONNECT:
        case CONNMAN_SERVICE_STATE_READY:
@@ -449,6 +758,12 @@ static connman_bool_t is_connecting(struct connman_service *service)
 
 static connman_bool_t is_ignore(struct connman_service *service)
 {
+       if (service->autoconnect == FALSE)
+               return TRUE;
+
+       if (service->roaming == TRUE)
+               return TRUE;
+
        if (service->ignore == TRUE)
                return TRUE;
 
@@ -491,42 +806,54 @@ void __connman_service_auto_connect(void)
                iter = g_sequence_iter_next(iter);
        }
 
-       if (service != NULL)
+       if (service != NULL) {
+               service->userconnect = FALSE;
                __connman_service_connect(service);
+       }
+}
+
+static void remove_timeout(struct connman_service *service)
+{
+       if (service->timeout > 0) {
+               g_source_remove(service->timeout);
+               service->timeout = 0;
+       }
+}
+
+static void reply_pending(struct connman_service *service, int error)
+{
+       remove_timeout(service);
+
+       if (service->pending != NULL) {
+               if (error > 0) {
+                       DBusMessage *reply;
+
+                       reply = __connman_error_failed(service->pending,
+                                                               error);
+                       if (reply != NULL)
+                               g_dbus_send_message(connection, reply);
+               } else
+                       g_dbus_send_reply(connection, service->pending,
+                                                       DBUS_TYPE_INVALID);
+
+               dbus_message_unref(service->pending);
+               service->pending = NULL;
+       }
 }
 
 static gboolean connect_timeout(gpointer user_data)
 {
        struct connman_service *service = user_data;
-       connman_bool_t auto_connect = FALSE;
+       connman_bool_t autoconnect = FALSE;
 
        DBG("service %p", service);
 
        service->timeout = 0;
 
-       if (service->network != NULL) {
-               connman_bool_t connected;
-
-               connected = connman_network_get_connected(service->network);
-               if (connected == TRUE) {
-                       __connman_service_indicate_state(service,
-                                               CONNMAN_SERVICE_STATE_READY);
-                       return FALSE;
-               }
-
+       if (service->network != NULL)
                __connman_network_disconnect(service->network);
-       } else if (service->device != NULL) {
-               connman_bool_t disconnected;
-
-               disconnected = connman_device_get_disconnected(service->device);
-               if (disconnected == FALSE) {
-                       __connman_service_indicate_state(service,
-                                               CONNMAN_SERVICE_STATE_READY);
-                       return FALSE;
-               }
 
-               __connman_device_disconnect(service->device);
-       }
+       __connman_ipconfig_disable(service->ipconfig);
 
        if (service->pending != NULL) {
                DBusMessage *reply;
@@ -538,21 +865,51 @@ static gboolean connect_timeout(gpointer user_data)
                dbus_message_unref(service->pending);
                service->pending = NULL;
        } else
-               auto_connect = TRUE;
+               autoconnect = TRUE;
 
        __connman_service_indicate_state(service,
                                        CONNMAN_SERVICE_STATE_FAILURE);
 
-       if (auto_connect == TRUE)
+       if (autoconnect == TRUE && service->userconnect == FALSE)
                __connman_service_auto_connect();
 
        return FALSE;
 }
 
+static void set_reconnect_state(struct connman_service *service,
+                                               connman_bool_t reconnect)
+{
+       struct connman_device *device;
+
+       if (service->network == NULL)
+               return;
+
+       device = connman_network_get_device(service->network);
+       if (device == NULL)
+               return;
+
+       __connman_device_set_reconnect(device, reconnect);
+}
+
+static connman_bool_t get_reconnect_state(struct connman_service *service)
+{
+       struct connman_device *device;
+
+       if (service->network == NULL)
+               return FALSE;
+
+       device = connman_network_get_device(service->network);
+       if (device == NULL)
+               return FALSE;
+
+       return __connman_device_get_reconnect(device);
+}
+
 static DBusMessage *connect_service(DBusConnection *conn,
                                        DBusMessage *msg, void *user_data)
 {
        struct connman_service *service = user_data;
+       GSequenceIter *iter;
        int err;
 
        DBG("service %p", service);
@@ -560,12 +917,34 @@ static DBusMessage *connect_service(DBusConnection *conn,
        if (service->pending != NULL)
                return __connman_error_in_progress(msg);
 
+       iter = g_sequence_get_begin_iter(service_list);
+
+       while (g_sequence_iter_is_end(iter) == FALSE) {
+               struct connman_service *temp = g_sequence_get(iter);
+
+               if (service->type == temp->type &&
+                                       is_connecting(temp) == TRUE)
+                       return __connman_error_in_progress(msg);
+
+               iter = g_sequence_iter_next(iter);
+       }
+
        service->ignore = FALSE;
 
+       service->userconnect = TRUE;
+
        service->pending = dbus_message_ref(msg);
 
+       set_reconnect_state(service, FALSE);
+
        err = __connman_service_connect(service);
        if (err < 0) {
+               if (err == -ENOKEY) {
+                       if (__connman_agent_request_passphrase(service,
+                                                       NULL, NULL) == 0)
+                               return NULL;
+               }
+
                if (err != -EINPROGRESS) {
                        dbus_message_unref(service->pending);
                        service->pending = NULL;
@@ -590,21 +969,12 @@ static DBusMessage *disconnect_service(DBusConnection *conn,
 
        DBG("service %p", service);
 
-       if (service->pending != NULL) {
-               DBusMessage *reply;
-
-               reply = __connman_error_operation_aborted(service->pending);
-               if (reply != NULL)
-                       g_dbus_send_message(conn, reply);
-
-               dbus_message_unref(service->pending);
-               service->pending = NULL;
-
-               return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
-       }
+       reply_pending(service, ECONNABORTED);
 
        service->ignore = TRUE;
 
+       set_reconnect_state(service, FALSE);
+
        err = __connman_service_disconnect(service);
        if (err < 0) {
                if (err != -EINPROGRESS)
@@ -626,15 +996,34 @@ static DBusMessage *remove_service(DBusConnection *conn,
        if (service->type == CONNMAN_SERVICE_TYPE_ETHERNET)
                return __connman_error_not_supported(msg);
 
-       if (service->favorite == FALSE)
+       if (service->favorite == FALSE &&
+                       service->state != CONNMAN_SERVICE_STATE_FAILURE)
                return __connman_error_not_supported(msg);
 
-       if (service->network != NULL)
+       if (service->network != NULL) {
+               set_reconnect_state(service, FALSE);
+
                __connman_network_disconnect(service->network);
+       }
 
        g_free(service->passphrase);
        service->passphrase = NULL;
 
+       passphrase_changed(service);
+
+       g_free(service->apn);
+       service->apn = NULL;
+
+       g_free(service->username);
+       service->username = NULL;
+
+       g_free(service->password);
+       service->password = NULL;
+
+       apn_changed(service);
+
+       set_idle(service);
+
        connman_service_set_favorite(service, FALSE);
        __connman_storage_save_service(service);
 
@@ -663,6 +1052,9 @@ static DBusMessage *move_before(DBusConnection *conn,
 
        DBG("target %s", target->identifier);
 
+       if (target->state != service->state)
+               return __connman_error_invalid_service(msg);
+
        g_get_current_time(&service->modified);
        __connman_storage_save_service(service);
 
@@ -697,6 +1089,9 @@ static DBusMessage *move_after(DBusConnection *conn,
 
        DBG("target %s", target->identifier);
 
+       if (target->state != service->state)
+               return __connman_error_invalid_service(msg);
+
        g_get_current_time(&service->modified);
        __connman_storage_save_service(service);
 
@@ -728,22 +1123,14 @@ static void service_free(gpointer user_data)
 
        DBG("service %p", service);
 
-       g_hash_table_remove(service_hash, service->identifier);
-
-       if (service->timeout > 0) {
-               g_source_remove(service->timeout);
-               service->timeout = 0;
-       }
+       reply_pending(service, ENOENT);
 
-       if (service->pending != NULL) {
-               dbus_message_unref(service->pending);
-               service->pending = NULL;
-       }
+       g_hash_table_remove(service_hash, service->identifier);
 
        service->path = NULL;
 
        if (path != NULL) {
-               __connman_profile_changed(TRUE);
+               __connman_profile_changed(FALSE);
 
                g_dbus_unregister_interface(connection, path,
                                                CONNMAN_SERVICE_INTERFACE);
@@ -753,8 +1140,16 @@ static void service_free(gpointer user_data)
        if (service->network != NULL)
                connman_network_unref(service->network);
 
-       connman_ipconfig_unref(service->ipconfig);
+       if (service->ipconfig != NULL) {
+               connman_ipconfig_unref(service->ipconfig);
+               service->ipconfig = NULL;
+       }
 
+       g_free(service->mcc);
+       g_free(service->mnc);
+       g_free(service->apn);
+       g_free(service->username);
+       g_free(service->password);
        g_free(service->profile);
        g_free(service->name);
        g_free(service->passphrase);
@@ -762,39 +1157,6 @@ static void service_free(gpointer user_data)
        g_free(service);
 }
 
-static void reply_pending(struct connman_service *service, int error)
-{
-       if (service->timeout > 0) {
-               g_source_remove(service->timeout);
-               service->timeout = 0;
-       }
-
-       if (service->pending != NULL) {
-               if (error > 0) {
-                       DBusMessage *reply;
-
-                       reply = __connman_error_failed(service->pending,
-                                                               error);
-                       if (reply != NULL)
-                               g_dbus_send_message(connection, reply);
-               } else
-                       g_dbus_send_reply(connection, service->pending,
-                                                       DBUS_TYPE_INVALID);
-
-               dbus_message_unref(service->pending);
-               service->pending = NULL;
-       }
-}
-
-static gboolean remove_timeout(gpointer user_data)
-{
-       GSequenceIter *iter = user_data;
-
-       g_sequence_remove(iter);
-
-       return FALSE;
-}
-
 /**
  * __connman_service_put:
  * @service: service structure
@@ -810,22 +1172,11 @@ void __connman_service_put(struct connman_service *service)
 
                iter = g_hash_table_lookup(service_hash, service->identifier);
                if (iter != NULL) {
-                       guint interval = 1;
-
-                       reply_pending(service, EIO);
+                       reply_pending(service, ECONNABORTED);
 
-                       if (service->network != NULL) {
-                               connman_network_unref(service->network);
-                               service->network = NULL;
+                       __connman_service_disconnect(service);
 
-                               interval = 5;
-                       }
-
-                       service->state = CONNMAN_SERVICE_STATE_FAILURE;
-                       service->error = CONNMAN_SERVICE_ERROR_OUT_OF_RANGE;
-
-                       service->timeout = g_timeout_add_seconds(interval,
-                                                       remove_timeout, iter);
+                       g_sequence_remove(iter);
                } else
                        service_free(service);
        }
@@ -847,6 +1198,8 @@ static void __connman_service_initialize(struct connman_service *service)
 
        service->ignore = FALSE;
 
+       service->userconnect = FALSE;
+
        service->order = 0;
 }
 
@@ -869,15 +1222,6 @@ struct connman_service *connman_service_create(void)
 
        __connman_service_initialize(service);
 
-       service->ipconfig = connman_ipconfig_create();
-       if (service->ipconfig == NULL) {
-               g_free(service);
-               return NULL;
-       }
-
-       connman_ipconfig_set_method(service->ipconfig,
-                                       CONNMAN_IPCONFIG_METHOD_DHCP);
-
        return service;
 }
 
@@ -930,10 +1274,61 @@ static gint service_compare(gconstpointer a, gconstpointer b,
        if (service_a->favorite == FALSE && service_b->favorite == TRUE)
                return 1;
 
+       if (service_a->type != service_b->type) {
+               switch (service_a->type) {
+               case CONNMAN_SERVICE_TYPE_UNKNOWN:
+               case CONNMAN_SERVICE_TYPE_SYSTEM:
+               case CONNMAN_SERVICE_TYPE_ETHERNET:
+               case CONNMAN_SERVICE_TYPE_VPN:
+                       break;
+               case CONNMAN_SERVICE_TYPE_WIFI:
+                       return 1;
+               case CONNMAN_SERVICE_TYPE_WIMAX:
+               case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+               case CONNMAN_SERVICE_TYPE_CELLULAR:
+                       return -1;
+               }
+       }
+
        return (gint) service_b->strength - (gint) service_a->strength;
 }
 
 /**
+ * connman_service_get_type:
+ * @service: service structure
+ *
+ * Get the type of service
+ */
+enum connman_service_type connman_service_get_type(struct connman_service *service)
+{
+       if (service == NULL)
+               return CONNMAN_SERVICE_TYPE_UNKNOWN;
+
+       return service->type;
+}
+
+/**
+ * connman_service_get_interface:
+ * @service: service structure
+ *
+ * Get network interface of service
+ */
+char *connman_service_get_interface(struct connman_service *service)
+{
+       int index;
+
+       if (service == NULL)
+               return NULL;
+
+       if (service->network == NULL)
+               return NULL;
+
+       index = connman_network_get_index(service->network);
+
+       return connman_inet_ifname(index);
+}
+
+/**
  * connman_service_set_favorite:
  * @service: service structure
  * @favorite: favorite value
@@ -954,6 +1349,8 @@ int connman_service_set_favorite(struct connman_service *service,
 
        service->favorite = favorite;
 
+       favorite_changed(service);
+
        g_sequence_sort_changed(iter, service_compare, NULL);
 
        __connman_profile_changed(FALSE);
@@ -961,39 +1358,6 @@ int connman_service_set_favorite(struct connman_service *service,
        return 0;
 }
 
-int __connman_service_set_carrier(struct connman_service *service,
-                                               connman_bool_t carrier)
-{
-       DBG("service %p carrier %d", service, carrier);
-
-       if (service == NULL)
-               return -EINVAL;
-
-       switch (service->type) {
-       case CONNMAN_SERVICE_TYPE_UNKNOWN:
-       case CONNMAN_SERVICE_TYPE_WIFI:
-       case CONNMAN_SERVICE_TYPE_WIMAX:
-       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
-       case CONNMAN_SERVICE_TYPE_CELLULAR:
-               return -EINVAL;
-       case CONNMAN_SERVICE_TYPE_ETHERNET:
-               break;
-       }
-
-       if (carrier == FALSE) {
-               service->state = CONNMAN_SERVICE_STATE_DISCONNECT;
-               state_changed(service);
-
-               service->state = CONNMAN_SERVICE_STATE_IDLE;
-               state_changed(service);
-       } else {
-               service->state = CONNMAN_SERVICE_STATE_CARRIER;
-               state_changed(service);
-       }
-
-       return connman_service_set_favorite(service, carrier);
-}
-
 int __connman_service_indicate_state(struct connman_service *service,
                                        enum connman_service_state state)
 {
@@ -1004,9 +1368,6 @@ int __connman_service_indicate_state(struct connman_service *service,
        if (service == NULL)
                return -EINVAL;
 
-       if (state == CONNMAN_SERVICE_STATE_CARRIER)
-               return __connman_service_set_carrier(service, TRUE);
-
        if (service->state == state)
                return -EALREADY;
 
@@ -1023,24 +1384,51 @@ int __connman_service_indicate_state(struct connman_service *service,
                service->state = CONNMAN_SERVICE_STATE_DISCONNECT;
                state_changed(service);
 
+               reply_pending(service, ECONNABORTED);
+
                __connman_service_disconnect(service);
        }
 
        service->state = state;
        state_changed(service);
 
+       if (state == CONNMAN_SERVICE_STATE_IDLE) {
+               connman_bool_t reconnect;
+
+               reconnect = get_reconnect_state(service);
+               if (reconnect == TRUE)
+                       __connman_service_auto_connect();
+       }
+
        if (state == CONNMAN_SERVICE_STATE_READY) {
+               set_reconnect_state(service, TRUE);
+
                connman_service_set_favorite(service, TRUE);
 
                reply_pending(service, 0);
 
+               service->userconnect = FALSE;
+
                g_get_current_time(&service->modified);
                __connman_storage_save_service(service);
+
+               settings_changed(service);
+
+               __connman_notifier_connect(service->type);
+
+               default_changed();
+       } else if (state == CONNMAN_SERVICE_STATE_DISCONNECT) {
+               default_changed();
+
+               __connman_notifier_disconnect(service->type);
        }
 
        if (state == CONNMAN_SERVICE_STATE_FAILURE) {
                reply_pending(service, EIO);
 
+               if (service->userconnect == FALSE)
+                       __connman_service_auto_connect();
+
                g_get_current_time(&service->modified);
                __connman_storage_save_service(service);
        } else
@@ -1077,9 +1465,51 @@ int __connman_service_indicate_default(struct connman_service *service)
 {
        DBG("service %p", service);
 
+       default_changed();
+
        return 0;
 }
 
+static connman_bool_t prepare_network(struct connman_service *service)
+{
+       enum connman_network_type type;
+       unsigned int ssid_len;
+
+       type = connman_network_get_type(service->network);
+
+       switch (type) {
+       case CONNMAN_NETWORK_TYPE_UNKNOWN:
+       case CONNMAN_NETWORK_TYPE_VENDOR:
+               return FALSE;
+       case CONNMAN_NETWORK_TYPE_WIFI:
+               if (connman_network_get_blob(service->network, "WiFi.SSID",
+                                                       &ssid_len) == NULL)
+                       return FALSE;
+
+               connman_network_set_string(service->network,
+                               "WiFi.Passphrase", service->passphrase);
+               break;
+       case CONNMAN_NETWORK_TYPE_ETHERNET:
+       case CONNMAN_NETWORK_TYPE_WIMAX:
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_PAN:
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_DUN:
+       case CONNMAN_NETWORK_TYPE_CELLULAR:
+               break;
+       case CONNMAN_NETWORK_TYPE_MBM:
+       case CONNMAN_NETWORK_TYPE_HSO:
+               connman_network_set_string(service->network,
+                                               "Cellular.APN", service->apn);
+
+               connman_network_set_string(service->network,
+                                       "Cellular.Username", service->username);
+               connman_network_set_string(service->network,
+                                       "Cellular.Password", service->password);
+               break;
+       }
+
+       return TRUE;
+}
+
 int __connman_service_connect(struct connman_service *service)
 {
        int err;
@@ -1092,30 +1522,53 @@ int __connman_service_connect(struct connman_service *service)
        if (is_connecting(service) == TRUE)
                return -EALREADY;
 
-       if (service->network != NULL) {
-               unsigned int ssid_len;
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_VPN:
+               return -EINVAL;
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+               break;
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+               if (service->apn == NULL)
+                       return -EINVAL;
+               break;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+               switch (service->security) {
+               case CONNMAN_SERVICE_SECURITY_UNKNOWN:
+               case CONNMAN_SERVICE_SECURITY_NONE:
+               case CONNMAN_SERVICE_SECURITY_8021X:
+                       break;
+               case CONNMAN_SERVICE_SECURITY_WEP:
+               case CONNMAN_SERVICE_SECURITY_PSK:
+               case CONNMAN_SERVICE_SECURITY_WPA:
+               case CONNMAN_SERVICE_SECURITY_RSN:
+                       if (service->passphrase == NULL)
+                               return -ENOKEY;
+                       break;
+               }
+               break;
+       }
 
-               if (connman_network_get_blob(service->network, "WiFi.SSID",
-                                                    &ssid_len) == NULL)
+       if (service->network != NULL) {
+               if (prepare_network(service) == FALSE)
                        return -EINVAL;
 
-               connman_network_set_string(service->network,
-                               "WiFi.Passphrase", service->passphrase);
+               __connman_ipconfig_enable(service->ipconfig);
 
                err = __connman_network_connect(service->network);
-       } else if (service->device != NULL) {
-               if (service->favorite == FALSE)
-                       return -ENOLINK;
-
-               err = __connman_device_connect(service->device);
        } else
                return -EOPNOTSUPP;
 
        if (err < 0) {
-               if (err != -EINPROGRESS)
+               if (err != -EINPROGRESS) {
+                       __connman_ipconfig_disable(service->ipconfig);
                        return err;
+               }
 
-               service->timeout = g_timeout_add_seconds(45,
+               service->timeout = g_timeout_add_seconds(CONNECT_TIMEOUT,
                                                connect_timeout, service);
 
                return -EINPROGRESS;
@@ -1132,13 +1585,11 @@ int __connman_service_disconnect(struct connman_service *service)
 
        if (service->network != NULL) {
                err = __connman_network_disconnect(service->network);
-       } else if (service->device != NULL) {
-               if (service->favorite == FALSE)
-                       return -ENOLINK;
-               err = __connman_device_disconnect(service->device);
        } else
                return -EOPNOTSUPP;
 
+       __connman_ipconfig_disable(service->ipconfig);
+
        if (err < 0) {
                if (err != -EINPROGRESS)
                        return err;
@@ -1166,15 +1617,72 @@ static struct connman_service *__connman_service_lookup(const char *identifier)
        return NULL;
 }
 
+static struct connman_network *create_hidden_wifi(struct connman_device *device,
+               const char *ssid, const char *mode, const char *security)
+{
+       struct connman_network *network;
+       char *name;
+       int index;
+       unsigned int i, ssid_len;
+
+       ssid_len = strlen(ssid);
+       if (ssid_len < 1)
+               return NULL;
+
+       network = connman_network_create(NULL, CONNMAN_NETWORK_TYPE_WIFI);
+       if (network == NULL)
+               return NULL;
+
+       connman_network_set_blob(network, "WiFi.SSID",
+                                       (unsigned char *) ssid, ssid_len);
+
+       connman_network_set_string(network, "WiFi.Mode", mode);
+       connman_network_set_string(network, "WiFi.Security", security);
+
+       name = g_try_malloc0(ssid_len + 1);
+       if (name == NULL) {
+               connman_network_unref(network);
+               return NULL;
+       }
+
+       for (i = 0; i < ssid_len; i++) {
+               if (g_ascii_isprint(ssid[i]))
+                       name[i] = ssid[i];
+               else
+                       name[i] = ' ';
+       }
+
+       connman_network_set_name(network, name);
+
+       g_free(name);
+
+       index = connman_device_get_index(device);
+       connman_network_set_index(network, index);
+
+       connman_network_set_protocol(network, CONNMAN_NETWORK_PROTOCOL_IP);
+
+       if (connman_device_add_network(device, network) < 0) {
+               connman_network_unref(network);
+               return NULL;
+       }
+
+       connman_network_set_available(network, TRUE);
+
+       return network;
+}
+
 int __connman_service_create_and_connect(DBusMessage *msg)
 {
        struct connman_service *service;
+       struct connman_network *network;
        struct connman_device *device;
        DBusMessageIter iter, array;
        const char *mode = "managed", *security = "none";
        const char *type = NULL, *ssid = NULL, *passphrase = NULL;
+       unsigned int ssid_len = 0;
        const char *ident;
        char *name, *group;
+       gboolean created = FALSE;
        int err;
 
        dbus_message_iter_init(msg, &iter);
@@ -1220,6 +1728,17 @@ int __connman_service_create_and_connect(DBusMessage *msg)
        if (ssid == NULL)
                return -EINVAL;
 
+       ssid_len = strlen(ssid);
+       if (ssid_len < 1)
+               return -EINVAL;
+
+       if (g_strcmp0(security, "none") != 0 &&
+                               g_strcmp0(security, "wep") != 0 &&
+                               g_strcmp0(security, "psk") != 0 &&
+                               g_strcmp0(security, "wpa") != 0 &&
+                               g_strcmp0(security, "rsn") != 0)
+               return -EINVAL;
+
        device = __connman_element_find_device(CONNMAN_DEVICE_TYPE_WIFI);
        if (device == NULL)
                return -EOPNOTSUPP;
@@ -1229,36 +1748,68 @@ int __connman_service_create_and_connect(DBusMessage *msg)
                return -EOPNOTSUPP;
 
        group = connman_wifi_build_group_name((unsigned char *) ssid,
-                                               strlen(ssid), mode, security);
+                                               ssid_len, mode, security);
        if (group == NULL)
                return -EINVAL;
 
        name = g_strdup_printf("%s_%s_%s", type, ident, group);
 
-       g_free(group);
+       service = __connman_service_lookup(name);
+
+       if (service != NULL)
+               goto done;
+
+       network = create_hidden_wifi(device, ssid, mode, security);
+       if (network != NULL) {
+               connman_network_set_group(network, group);
+               created = TRUE;
+       }
 
        service = __connman_service_lookup(name);
 
+done:
        g_free(name);
+       g_free(group);
 
-       if (service != NULL) {
-               if (passphrase != NULL) {
-                       g_free(service->passphrase);
-                       service->passphrase = g_strdup(passphrase);
-               }
+       if (service == NULL) {
+               err = -EOPNOTSUPP;
+               goto failed;
+       }
 
-               err = __connman_service_connect(service);
-               if (err < 0 && err != -EINPROGRESS)
-                       return err;
+       set_reconnect_state(service, FALSE);
+
+       __connman_device_disconnect(device);
+
+       if (passphrase != NULL) {
+               g_free(service->passphrase);
+               service->passphrase = g_strdup(passphrase);
+       }
+
+       service->userconnect = TRUE;
+
+       err = __connman_service_connect(service);
+       if (err < 0 && err != -EINPROGRESS)
+               goto failed;
 
-               g_dbus_send_reply(connection, msg,
-                                       DBUS_TYPE_OBJECT_PATH, &service->path,
+       g_dbus_send_reply(connection, msg,
+                               DBUS_TYPE_OBJECT_PATH, &service->path,
                                                        DBUS_TYPE_INVALID);
 
-               return 0;
+       return 0;
+
+failed:
+       if (service != NULL && created == TRUE) {
+               struct connman_network *network = service->network;
+
+               if (network != NULL) {
+                       connman_network_set_available(network, FALSE);
+                       __connman_device_cleanup_networks(device);
+               }
+
+               __connman_service_put(service);
        }
 
-       return -EOPNOTSUPP;
+       return err;
 }
 
 /**
@@ -1330,102 +1881,67 @@ static int service_register(struct connman_service *service)
        return 0;
 }
 
-/**
- * connman_service_lookup_from_device:
- * @device: device structure
- *
- * Look up a service by device (reference count will not be increased)
- */
-struct connman_service *__connman_service_lookup_from_device(struct connman_device *device)
+static void service_up(struct connman_ipconfig *ipconfig)
 {
-       struct connman_service *service;
-       const char *ident;
-       char *name;
-
-       ident = __connman_device_get_ident(device);
-       if (ident == NULL)
-               return NULL;
-
-       name = g_strdup_printf("%s_%s",
-                               __connman_device_get_type(device), ident);
-
-       service = __connman_service_lookup(name);
-
-       g_free(name);
-
-       return service;
+       connman_info("%s up", connman_ipconfig_get_ifname(ipconfig));
 }
 
-static enum connman_service_type convert_device_type(struct connman_device *device)
+static void service_down(struct connman_ipconfig *ipconfig)
 {
-       enum connman_device_type type = connman_device_get_type(device);
-
-       switch (type) {
-       case CONNMAN_DEVICE_TYPE_UNKNOWN:
-       case CONNMAN_DEVICE_TYPE_VENDOR:
-       case CONNMAN_DEVICE_TYPE_WIFI:
-       case CONNMAN_DEVICE_TYPE_WIMAX:
-       case CONNMAN_DEVICE_TYPE_BLUETOOTH:
-       case CONNMAN_DEVICE_TYPE_GPS:
-       case CONNMAN_DEVICE_TYPE_MBM:
-       case CONNMAN_DEVICE_TYPE_HSO:
-       case CONNMAN_DEVICE_TYPE_NOZOMI:
-       case CONNMAN_DEVICE_TYPE_HUAWEI:
-       case CONNMAN_DEVICE_TYPE_NOVATEL:
-               break;
-       case CONNMAN_DEVICE_TYPE_ETHERNET:
-               return CONNMAN_SERVICE_TYPE_ETHERNET;
-       }
-
-       return CONNMAN_SERVICE_TYPE_UNKNOWN;
+       connman_info("%s down", connman_ipconfig_get_ifname(ipconfig));
 }
 
-/**
- * connman_service_create_from_device:
- * @device: device structure
- *
- * Look up service by device and if not found, create one
- */
-struct connman_service *__connman_service_create_from_device(struct connman_device *device)
+static void service_lower_up(struct connman_ipconfig *ipconfig)
 {
-       struct connman_service *service;
-       const char *ident;
-       char *name;
+       connman_info("%s lower up", connman_ipconfig_get_ifname(ipconfig));
+}
 
-       ident = __connman_device_get_ident(device);
-       if (ident == NULL)
-               return NULL;
+static void service_lower_down(struct connman_ipconfig *ipconfig)
+{
+       connman_info("%s lower down", connman_ipconfig_get_ifname(ipconfig));
+}
 
-       name = g_strdup_printf("%s_%s",
-                               __connman_device_get_type(device), ident);
+static void service_ip_bound(struct connman_ipconfig *ipconfig)
+{
+       connman_info("%s ip bound", connman_ipconfig_get_ifname(ipconfig));
+}
 
-       service = __connman_service_get(name);
-       if (service == NULL)
-               goto done;
+static void service_ip_release(struct connman_ipconfig *ipconfig)
+{
+       connman_info("%s ip release", connman_ipconfig_get_ifname(ipconfig));
+}
 
-       if (service->path != NULL) {
-               __connman_service_put(service);
-               service = NULL;
-               goto done;
-       }
+static const struct connman_ipconfig_ops service_ops = {
+       .up             = service_up,
+       .down           = service_down,
+       .lower_up       = service_lower_up,
+       .lower_down     = service_lower_down,
+       .ip_bound       = service_ip_bound,
+       .ip_release     = service_ip_release,
+};
 
-       service->type = convert_device_type(device);
+static void setup_ipconfig(struct connman_service *service, int index)
+{
+       if (index < 0)
+               return;
 
-       service->device = device;
+       service->ipconfig = connman_ipconfig_create(index);
+       if (service->ipconfig == NULL)
+               return;
 
-       service_register(service);
+       connman_ipconfig_set_method(service->ipconfig,
+                                       CONNMAN_IPCONFIG_METHOD_DHCP);
 
-       if (service->favorite == TRUE)
-               __connman_service_auto_connect();
+       __connman_storage_load_service(service);
 
-done:
-       g_free(name);
+       connman_ipconfig_set_data(service->ipconfig, service);
 
-       return service;
+       connman_ipconfig_set_ops(service->ipconfig, &service_ops);
+       connman_ipconfig_set_ops(service->ipconfig, NULL);
 }
 
 /**
- * connman_service_lookup_from_network:
+ * __connman_service_lookup_from_network:
  * @network: network structure
  *
  * Look up a service by network (reference count will not be increased)
@@ -1436,6 +1952,8 @@ struct connman_service *__connman_service_lookup_from_network(struct connman_net
        const char *ident, *group;
        char *name;
 
+       DBG("network %p", network);
+
        ident = __connman_network_get_ident(network);
        if (ident == NULL)
                return NULL;
@@ -1446,14 +1964,17 @@ struct connman_service *__connman_service_lookup_from_network(struct connman_net
 
        name = g_strdup_printf("%s_%s_%s",
                        __connman_network_get_type(network), ident, group);
-
        service = __connman_service_lookup(name);
-
        g_free(name);
 
        return service;
 }
 
+const char *__connman_service_get_path(struct connman_service *service)
+{
+       return service->path;
+}
+
 unsigned int __connman_service_get_order(struct connman_service *service)
 {
        GSequenceIter *iter;
@@ -1485,16 +2006,20 @@ static enum connman_service_type convert_network_type(struct connman_network *ne
        switch (type) {
        case CONNMAN_NETWORK_TYPE_UNKNOWN:
        case CONNMAN_NETWORK_TYPE_VENDOR:
-       case CONNMAN_NETWORK_TYPE_BLUETOOTH_PAN:
-       case CONNMAN_NETWORK_TYPE_BLUETOOTH_DUN:
                break;
-       case CONNMAN_NETWORK_TYPE_MBM:
-       case CONNMAN_NETWORK_TYPE_HSO:
-               return CONNMAN_SERVICE_TYPE_CELLULAR;
+       case CONNMAN_NETWORK_TYPE_ETHERNET:
+               return CONNMAN_SERVICE_TYPE_ETHERNET;
        case CONNMAN_NETWORK_TYPE_WIFI:
                return CONNMAN_SERVICE_TYPE_WIFI;
        case CONNMAN_NETWORK_TYPE_WIMAX:
                return CONNMAN_SERVICE_TYPE_WIMAX;
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_PAN:
+       case CONNMAN_NETWORK_TYPE_BLUETOOTH_DUN:
+               return CONNMAN_SERVICE_TYPE_BLUETOOTH;
+       case CONNMAN_NETWORK_TYPE_CELLULAR:
+       case CONNMAN_NETWORK_TYPE_MBM:
+       case CONNMAN_NETWORK_TYPE_HSO:
+               return CONNMAN_SERVICE_TYPE_CELLULAR;
        }
 
        return CONNMAN_SERVICE_TYPE_UNKNOWN;
@@ -1512,7 +2037,7 @@ static enum connman_service_mode convert_wifi_mode(const char *mode)
                return CONNMAN_SERVICE_MODE_UNKNOWN;
 }
 
-static enum connman_service_mode convert_wifi_security(const char *security)
+static enum connman_service_security convert_wifi_security(const char *security)
 {
        if (security == NULL)
                return CONNMAN_SERVICE_SECURITY_UNKNOWN;
@@ -1520,6 +2045,10 @@ static enum connman_service_mode convert_wifi_security(const char *security)
                return CONNMAN_SERVICE_SECURITY_NONE;
        else if (g_str_equal(security, "wep") == TRUE)
                return CONNMAN_SERVICE_SECURITY_WEP;
+       else if (g_str_equal(security, "wep") == TRUE)
+               return CONNMAN_SERVICE_SECURITY_PSK;
+       else if (g_str_equal(security, "ieee8021x") == TRUE)
+               return CONNMAN_SERVICE_SECURITY_8021X;
        else if (g_str_equal(security, "wpa") == TRUE)
                return CONNMAN_SERVICE_SECURITY_WPA;
        else if (g_str_equal(security, "rsn") == TRUE)
@@ -1528,6 +2057,24 @@ static enum connman_service_mode convert_wifi_security(const char *security)
                return CONNMAN_SERVICE_SECURITY_UNKNOWN;
 }
 
+static enum connman_service_mode convert_cellular_mode(connman_uint8_t mode)
+{
+       switch (mode) {
+       case 0:
+       case 1:
+               return CONNMAN_SERVICE_MODE_GPRS;
+       case 3:
+               return CONNMAN_SERVICE_MODE_EDGE;
+       case 2:
+       case 4:
+       case 5:
+       case 6:
+               return CONNMAN_SERVICE_MODE_UMTS;
+       }
+
+       return CONNMAN_SERVICE_MODE_UNKNOWN;
+}
+
 static void update_from_network(struct connman_service *service,
                                        struct connman_network *network)
 {
@@ -1535,6 +2082,8 @@ static void update_from_network(struct connman_service *service,
        GSequenceIter *iter;
        const char *str;
 
+       DBG("service %p network %p", service, network);
+
        if (service->state == CONNMAN_SERVICE_STATE_READY)
                return;
 
@@ -1553,6 +2102,15 @@ static void update_from_network(struct connman_service *service,
        }
 
        service->strength = connman_network_get_uint8(network, "Strength");
+       service->roaming = connman_network_get_bool(network, "Roaming");
+
+       if (service->strength == 0) {
+               /*
+                * Filter out 0-values; it's unclear what they mean
+                * and they cause anomalous sorting of the priority list.
+                */
+               service->strength = strength;
+       }
 
        str = connman_network_get_string(network, "WiFi.Mode");
        service->mode = convert_wifi_mode(str);
@@ -1560,6 +2118,21 @@ static void update_from_network(struct connman_service *service,
        str = connman_network_get_string(network, "WiFi.Security");
        service->security = convert_wifi_security(str);
 
+       str = connman_network_get_string(network, "Cellular.MCC");
+       g_free(service->mcc);
+       service->mcc = g_strdup(str);
+
+       str = connman_network_get_string(network, "Cellular.MNC");
+       g_free(service->mnc);
+       service->mnc = g_strdup(str);
+
+       if (service->type == CONNMAN_SERVICE_TYPE_CELLULAR) {
+               connman_uint8_t value = connman_network_get_uint8(network,
+                                                       "Cellular.Mode");
+
+               service->mode = convert_cellular_mode(value);
+       }
+
        if (service->strength > strength && service->network != NULL) {
                connman_network_unref(service->network);
                service->network = connman_network_ref(network);
@@ -1576,7 +2149,7 @@ static void update_from_network(struct connman_service *service,
 }
 
 /**
- * connman_service_create_from_network:
+ * __connman_service_create_from_network:
  * @network: network structure
  *
  * Look up service by network and if not found, create one
@@ -1587,22 +2160,7 @@ struct connman_service *__connman_service_create_from_network(struct connman_net
        const char *ident, *group;
        char *name;
 
-       service = __connman_service_lookup_from_network(network);
-       if (service != NULL) {
-               if (g_atomic_int_get(&service->refcount) == 0) {
-                       if (service->timeout > 0) {
-                               g_source_remove(service->timeout);
-                               service->timeout = 0;
-                       }
-
-                       connman_service_ref(service);
-
-                       set_idle(service);
-               }
-
-               update_from_network(service, network);
-               return service;
-       }
+       DBG("network %p", network);
 
        ident = __connman_network_get_ident(network);
        if (ident == NULL)
@@ -1612,58 +2170,140 @@ struct connman_service *__connman_service_create_from_network(struct connman_net
        if (group == NULL)
                return NULL;
 
-       if (__connman_network_get_weakness(network) == TRUE)
-               return NULL;
-
        name = g_strdup_printf("%s_%s_%s",
                        __connman_network_get_type(network), ident, group);
-
        service = __connman_service_get(name);
+       g_free(name);
+
        if (service == NULL)
-               goto done;
+               return NULL;
+
+       if (__connman_network_get_weakness(network) == TRUE)
+               return service;
 
        if (service->path != NULL) {
                update_from_network(service, network);
-
                __connman_profile_changed(TRUE);
-
-               __connman_service_put(service);
-               service = NULL;
-               goto done;
+               return service;
        }
 
        service->type = convert_network_type(network);
 
+       switch (service->type) {
+       case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
+       case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_WIMAX:
+       case CONNMAN_SERVICE_TYPE_BLUETOOTH:
+       case CONNMAN_SERVICE_TYPE_VPN:
+               service->autoconnect = FALSE;
+               break;
+       case CONNMAN_SERVICE_TYPE_WIFI:
+       case CONNMAN_SERVICE_TYPE_CELLULAR:
+               service->autoconnect = TRUE;
+               break;
+       }
+
        service->state = CONNMAN_SERVICE_STATE_IDLE;
 
        update_from_network(service, network);
 
+       setup_ipconfig(service, connman_network_get_index(network));
+
        service_register(service);
 
+       __connman_profile_changed(TRUE);
+
        if (service->favorite == TRUE)
                __connman_service_auto_connect();
 
+       return service;
+}
+
+void __connman_service_update_from_network(struct connman_network *network)
+{
+       struct connman_service *service;
+       enum connman_service_mode mode;
+       connman_uint8_t strength, value;
+       connman_bool_t roaming;
+       GSequenceIter *iter;
+
+       DBG("network %p", network);
+
+       service = __connman_service_lookup_from_network(network);
+       if (service == NULL)
+               return;
+
+       if (service->network == NULL)
+               return;
+
+       strength = connman_network_get_uint8(service->network, "Strength");
+       if (strength == service->strength)
+               goto roaming;
+
+       service->strength = strength;
+
+       strength_changed(service);
+
+roaming:
+       roaming = connman_network_get_bool(service->network, "Roaming");
+       if (roaming == service->roaming)
+               goto done;
+
+       service->roaming = roaming;
+
+       roaming_changed(service);
+
+       iter = g_hash_table_lookup(service_hash, service->identifier);
+       if (iter != NULL)
+               g_sequence_sort_changed(iter, service_compare, NULL);
+
 done:
-       g_free(name);
+       if (service->type != CONNMAN_SERVICE_TYPE_CELLULAR)
+               return;
 
-       return service;
+       value = connman_network_get_uint8(service->network, "Cellular.Mode");
+       mode = convert_cellular_mode(value);
+
+       if (mode == service->mode)
+               return;
+
+       service->mode = mode;
+
+       mode_changed(service);
+}
+
+void __connman_service_remove_from_network(struct connman_network *network)
+{
+       struct connman_service *service;
+
+       DBG("network %p", network);
+
+       service = __connman_service_lookup_from_network(network);
+       if (service == NULL)
+               return;
+
+       __connman_service_put(service);
 }
 
 static int service_load(struct connman_service *service)
 {
+       const char *ident = service->profile;
        GKeyFile *keyfile;
+       GError *error = NULL;
        gchar *pathname, *data = NULL;
        gsize length;
        gchar *str;
+       connman_bool_t autoconnect;
        unsigned int ssid_len;
        int err = 0;
 
        DBG("service %p", service);
 
-       if (service->profile == NULL)
+       if (ident == NULL)
                return -EINVAL;
 
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, service->profile);
+       pathname = g_strdup_printf("%s/%s.profile", STORAGEDIR, ident);
        if (pathname == NULL)
                return -ENOMEM;
 
@@ -1686,7 +2326,9 @@ static int service_load(struct connman_service *service)
 
        switch (service->type) {
        case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
        case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_VPN:
                break;
        case CONNMAN_SERVICE_TYPE_WIFI:
                if (service->name == NULL) {
@@ -1741,9 +2383,24 @@ static int service_load(struct connman_service *service)
        case CONNMAN_SERVICE_TYPE_WIMAX:
        case CONNMAN_SERVICE_TYPE_BLUETOOTH:
        case CONNMAN_SERVICE_TYPE_CELLULAR:
+               service->apn = g_key_file_get_string(keyfile,
+                                       service->identifier, "APN", NULL);
+
+               service->username = g_key_file_get_string(keyfile,
+                                       service->identifier, "Username", NULL);
+
+               service->username = g_key_file_get_string(keyfile,
+                                       service->identifier, "Password", NULL);
+
                service->favorite = g_key_file_get_boolean(keyfile,
                                service->identifier, "Favorite", NULL);
 
+               autoconnect = g_key_file_get_boolean(keyfile,
+                               service->identifier, "AutoConnect", &error);
+               if (error == NULL)
+                       service->autoconnect = autoconnect;
+               g_clear_error(&error);
+
                str = g_key_file_get_string(keyfile,
                                service->identifier, "Failure", NULL);
                if (str != NULL) {
@@ -1767,7 +2424,8 @@ static int service_load(struct connman_service *service)
                service->passphrase = str;
        }
 
-       __connman_ipconfig_load(service->ipconfig, keyfile,
+       if (service->ipconfig != NULL)
+               __connman_ipconfig_load(service->ipconfig, keyfile,
                                        service->identifier, "IPv4.");
 
 done:
@@ -1778,6 +2436,7 @@ done:
 
 static int service_save(struct connman_service *service)
 {
+       const char *ident = service->profile;
        GKeyFile *keyfile;
        gchar *pathname, *data = NULL;
        gsize length;
@@ -1786,10 +2445,10 @@ static int service_save(struct connman_service *service)
 
        DBG("service %p", service);
 
-       if (service->profile == NULL)
+       if (ident == NULL)
                return -EINVAL;
 
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR, service->profile);
+       pathname = g_strdup_printf("%s/%s.profile", STORAGEDIR, ident);
        if (pathname == NULL)
                return -ENOMEM;
 
@@ -1813,7 +2472,9 @@ update:
 
        switch (service->type) {
        case CONNMAN_SERVICE_TYPE_UNKNOWN:
+       case CONNMAN_SERVICE_TYPE_SYSTEM:
        case CONNMAN_SERVICE_TYPE_ETHERNET:
+       case CONNMAN_SERVICE_TYPE_VPN:
                break;
        case CONNMAN_SERVICE_TYPE_WIFI:
                if (service->network) {
@@ -1849,9 +2510,25 @@ update:
        case CONNMAN_SERVICE_TYPE_WIMAX:
        case CONNMAN_SERVICE_TYPE_BLUETOOTH:
        case CONNMAN_SERVICE_TYPE_CELLULAR:
+               if (service->apn != NULL)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                                       "APN", service->apn);
+
+               if (service->username != NULL)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                               "Username", service->username);
+
+               if (service->password != NULL)
+                       g_key_file_set_string(keyfile, service->identifier,
+                                               "Password", service->password);
+
                g_key_file_set_boolean(keyfile, service->identifier,
                                        "Favorite", service->favorite);
 
+               if (service->favorite == TRUE)
+                       g_key_file_set_boolean(keyfile, service->identifier,
+                                       "AutoConnect", service->autoconnect);
+
                if (service->state == CONNMAN_SERVICE_STATE_FAILURE) {
                        const char *failure = error2string(service->error);
                        if (failure != NULL)
@@ -1872,14 +2549,15 @@ update:
                g_free(str);
        }
 
-       if (service->passphrase != NULL)
+       if (service->passphrase != NULL && strlen(service->passphrase) > 0)
                g_key_file_set_string(keyfile, service->identifier,
                                        "Passphrase", service->passphrase);
        else
                g_key_file_remove_key(keyfile, service->identifier,
                                                        "Passphrase", NULL);
 
-       __connman_ipconfig_save(service->ipconfig, keyfile,
+       if (service->ipconfig != NULL)
+               __connman_ipconfig_save(service->ipconfig, keyfile,
                                        service->identifier, "IPv4.");
 
        data = g_key_file_to_data(keyfile, &length, NULL);