Add unit(in variable) & fix bugs
[platform/core/system/resourced.git] / src / resource-limiter / memory / lowmem-dbus.c
index a834d9d..6c696ff 100644 (file)
 
 static void lowmem_dbus_oom_set_threshold(GVariant *params)
 {
-       int level = -1, thres = -1;
+       int level = -1, thres_mb = -1;
        const char *const gtype = "(ii)";
 
        ret_if_gvariant_type_mismatch(params, gtype);
-       g_variant_get(params, gtype, &level, &thres);
+       g_variant_get(params, gtype, &level, &thres_mb);
        ret_unless(level >= 0);
-       ret_unless(thres >= 0);
+       ret_unless(thres_mb >= 0);
 
-       memcg_set_threshold(CGROUP_ROOT, level, thres);
+       memcg_set_threshold(CGROUP_ROOT, level, thres_mb);
 }
 
 static void lowmem_dbus_oom_set_leave_threshold(GVariant *params)
 {
-       int thres = -1;
+       int thres_mb = -1;
        const char *const gtype = "(i)";
 
        ret_if_gvariant_type_mismatch(params, gtype);
-       g_variant_get(params, gtype, &thres);
-       ret_unless(thres >= 0);
+       g_variant_get(params, gtype, &thres_mb);
+       ret_unless(thres_mb >= 0);
 
-       memcg_set_leave_threshold(CGROUP_ROOT, thres);
+       memcg_set_leave_threshold(CGROUP_ROOT, thres_mb);
 }
 
 static void lowmem_dbus_oom_trigger(GVariant *params)
@@ -94,23 +94,22 @@ static void lowmem_dbus_set_memlimit(GVariant *params)
 {
        int result;
        pid_t pid = 0;
-       unsigned int limit = 0;
+       unsigned long limit_bytes = 0;
        const char *const gtype = "(iu)";
        struct proc_app_info *pai;
 
        ret_if_gvariant_type_mismatch(params, gtype);
-       g_variant_get(params, gtype, &pid, &limit);
+       g_variant_get(params, gtype, &pid, &limit_bytes);
        ret_unless(pid > 0);
-       ret_unless(limit > 0);
+       ret_unless(limit_bytes > 0);
 
        pai = find_app_info(pid);
 
        if (pai) {
-               _I("[MEMORY-LIMIT] name: %s, limit: %u", pai->appid, limit);
                if (pai->memory.memlimit_update_exclude)
                        return;
 
-               lowmem_limit_set_app(limit, pai, PROC_ACTION_KILL);
+               lowmem_limit_set_app(limit_bytes, pai, PROC_ACTION_KILL);
        }
        else {
                char appname[PROC_NAME_MAX];
@@ -119,7 +118,7 @@ static void lowmem_dbus_set_memlimit(GVariant *params)
                        _E("Failed to get cmdline basename of pid(%d)", pid);
                        return;
                }
-               lowmem_limit_set_system_service(pid, limit, appname, PROC_ACTION_KILL);
+               lowmem_limit_set_system_service(pid, limit_bytes, appname, PROC_ACTION_KILL);
        }
 }