Fix build warnings
[platform/core/api/recorder.git] / src / recorder.c
index 575cfa7..e240071 100644 (file)
@@ -17,6 +17,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <inttypes.h>
 #include <camera_internal.h>
 #include <recorder.h>
 #include <sound_manager.h>
@@ -35,7 +36,8 @@
 #ifdef LOG_TAG
 #undef LOG_TAG
 #endif
-#define LOG_TAG "TIZEN_N_RECORDER"
+#define LOG_TAG         "TIZEN_N_RECORDER"
+#define MODULE_NAME     "recorder"
 
 /* for device changed callback */
 static GMutex g_rec_dev_state_changed_cb_lock;
@@ -43,6 +45,7 @@ static GList *g_rec_dev_state_changed_cb_list;
 static int g_rec_dev_state_changed_cb_id;
 static GDBusConnection *g_rec_dev_state_changed_cb_conn;
 static guint g_rec_dev_state_changed_cb_subscribe_id;
+static GMutex g_rec_idle_event_lock;
 
 
 
@@ -115,20 +118,20 @@ _DONE:
 }
 
 
-static int _recorder_import_tbm_key(tbm_bufmgr bufmgr, unsigned int tbm_key, tbm_bo *bo, tbm_bo_handle *bo_handle)
+static int _recorder_import_tbm_fd(tbm_bufmgr bufmgr, int fd, tbm_bo *bo, tbm_bo_handle *bo_handle)
 {
        tbm_bo tmp_bo = NULL;
        tbm_bo_handle tmp_bo_handle = {NULL, };
 
-       if (bufmgr == NULL || bo == NULL || bo_handle == NULL || tbm_key == 0) {
-               LOGE("invalid parameter - bufmgr %p, bo %p, bo_handle %p, key %d",
-                    bufmgr, bo, bo_handle, tbm_key);
+       if (bufmgr == NULL || bo == NULL || bo_handle == NULL || fd < 0) {
+               LOGE("invalid parameter - bufmgr %p, bo %p, bo_handle %p, fd %d",
+                    bufmgr, bo, bo_handle, fd);
                return false;
        }
 
-       tmp_bo = tbm_bo_import(bufmgr, tbm_key);
+       tmp_bo = tbm_bo_import_fd(bufmgr, (tbm_fd)fd);
        if (tmp_bo == NULL) {
-               LOGE("bo import failed - bufmgr %p, key %d", bufmgr, tbm_key);
+               LOGE("bo import failed - bufmgr %p, fd %d", bufmgr, fd);
                return false;
        }
 
@@ -161,7 +164,7 @@ static void _recorder_release_imported_bo(tbm_bo *bo)
        return;
 }
 
-static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *recv_msg, muse_recorder_event_e event)
+static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *recv_msg, muse_recorder_event_e event, int tfd)
 {
        if (recv_msg == NULL || event >= MUSE_RECORDER_EVENT_TYPE_NUM) {
                LOGE("invalid parameter - recorder msg %p, event %d", recv_msg, event);
@@ -215,8 +218,8 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                        int64_t cb_elapsed_time = 0;
                        int64_t cb_file_size = 0;
 
-                       muse_recorder_msg_get(cb_elapsed_time, recv_msg);
-                       muse_recorder_msg_get(cb_file_size, recv_msg);
+                       muse_recorder_msg_get_int64(cb_elapsed_time, recv_msg);
+                       muse_recorder_msg_get_int64(cb_file_size, recv_msg);
 
                        ((recorder_recording_status_cb)cb_info->user_cb[event])((unsigned long long)cb_elapsed_time,
                                (unsigned long long)cb_file_size,
@@ -257,7 +260,7 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                break;
        case MUSE_RECORDER_EVENT_TYPE_AUDIO_STREAM:
                {
-                       int tbm_key = 0;
+                       int audio_fd = -1;
                        int size = 0;
                        int format = 0;
                        int channel = 0;
@@ -266,43 +269,58 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                        tbm_bo_handle bo_handle = {.ptr = NULL};
                        char *send_msg = NULL;
 
-                       muse_recorder_msg_get(tbm_key, recv_msg);
-                       if (tbm_key == 0) {
-                               LOGE("invalid key");
+                       if (tfd < 0) {
+                               LOGE("invalid fd %d", tfd);
                                break;
                        }
 
+                       muse_recorder_msg_get(audio_fd, recv_msg);
+
                        if (cb_info->user_cb[event]) {
-                               if (_recorder_import_tbm_key(cb_info->bufmgr, tbm_key, &bo, &bo_handle)) {
+                               if (_recorder_import_tbm_fd(cb_info->bufmgr, tfd, &bo, &bo_handle)) {
                                        muse_recorder_msg_get(size, recv_msg);
                                        muse_recorder_msg_get(format, recv_msg);
                                        muse_recorder_msg_get(channel, recv_msg);
                                        muse_recorder_msg_get(timestamp, recv_msg);
 
+                                       LOGD("%p, size %d, format %d, channel %d, timestamp %d",
+                                               bo_handle.ptr, size, format, channel, timestamp);
+
                                        ((recorder_audio_stream_cb)cb_info->user_cb[event])((void *)bo_handle.ptr,
                                                size, (audio_sample_type_e)format, channel,
                                                (unsigned int)timestamp, cb_info->user_data[event]);
 
+                                       LOGD("returned");
+
                                        /* release imported bo */
                                        _recorder_release_imported_bo(&bo);
                                } else {
-                                       LOGE("tbm key %d import failed", tbm_key);
+                                       LOGE("tbm fd %d import failed", tfd);
                                }
                        }
 
                        /* return buffer */
                        send_msg = muse_core_msg_new(MUSE_RECORDER_API_RETURN_BUFFER,
-                               MUSE_TYPE_INT, "tbm_key", tbm_key, NULL);
+                               MUSE_TYPE_INT, "ret_fd", audio_fd, NULL);
 
-                       if (muse_core_msg_send(cb_info->fd, send_msg) <= 0)
-                               LOGE("sending message failed");
+                       if (send_msg) {
+                               if (muse_core_msg_send(cb_info->fd, send_msg) <= 0)
+                                       LOGE("sending message failed");
 
-                       muse_core_msg_free(send_msg);
+                               muse_core_msg_free(send_msg);
+                               send_msg = NULL;
+                       } else {
+                               LOGE("failed to create send msg for fd %d", audio_fd);
+                       }
+
+                       /* close imported fd */
+                       close(tfd);
+                       tfd = -1;
                        break;
                }
        case MUSE_RECORDER_EVENT_TYPE_MUXED_STREAM:
                {
-                       int tbm_key = 0;
+                       int muxed_fd = -1;
                        int size = 0;
                        int64_t offset = 0;
 
@@ -310,30 +328,35 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                        tbm_bo_handle bo_handle = {.ptr = NULL};
                        char *send_msg = NULL;
 
-                       muse_recorder_msg_get(tbm_key, recv_msg);
-                       if (tbm_key == 0) {
-                               LOGE("invalid key");
+                       if (tfd < 0) {
+                               LOGE("invalid fd %d", tfd);
                                break;
                        }
 
+                       muse_recorder_msg_get(muxed_fd, recv_msg);
+
                        if (cb_info->user_cb[event]) {
-                               if (_recorder_import_tbm_key(cb_info->bufmgr, tbm_key, &bo, &bo_handle)) {
+                               if (_recorder_import_tbm_fd(cb_info->bufmgr, tfd, &bo, &bo_handle)) {
                                        muse_recorder_msg_get(size, recv_msg);
-                                       muse_recorder_msg_get(offset, recv_msg);
+                                       muse_recorder_msg_get_int64(offset, recv_msg);
+
+                                       LOGD("%p, size %d, offset %"PRId64, bo_handle.ptr, size, offset);
 
                                        ((recorder_muxed_stream_cb)cb_info->user_cb[event])((void *)bo_handle.ptr,
                                                size, (unsigned long long)offset, cb_info->user_data[event]);
 
+                                       LOGD("returned");
+
                                        /* release imported bo */
                                        _recorder_release_imported_bo(&bo);
                                } else {
-                                       LOGE("tbm key %d import failed", tbm_key);
+                                       LOGE("tbm fd %d import failed", tfd);
                                }
                        }
 
                        /* return buffer */
                        send_msg = muse_core_msg_new(MUSE_RECORDER_API_RETURN_BUFFER,
-                               MUSE_TYPE_INT, "tbm_key", tbm_key, NULL);
+                               MUSE_TYPE_INT, "ret_fd", muxed_fd, NULL);
                        if (send_msg) {
                                if (muse_core_msg_send(cb_info->fd, send_msg) <= 0)
                                        LOGE("sending message failed");
@@ -341,10 +364,15 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                                muse_core_msg_free(send_msg);
                                send_msg = NULL;
                        } else {
-                               LOGE("failed to create send msg for key %d", tbm_key);
+                               LOGE("failed to create send msg for fd %d", tfd);
                        }
+
+                       /* close imported fd */
+                       close(tfd);
+                       tfd = -1;
                        break;
                }
+//LCOV_EXCL_START
        case MUSE_RECORDER_EVENT_TYPE_ERROR:
                {
                        int error = 0;
@@ -358,6 +386,7 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
                                cb_info->user_data[event]);
                        break;
                }
+//LCOV_EXCL_STOP
        case MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_AUDIO_ENCODER:
                {
                        int codec = 0;
@@ -420,49 +449,41 @@ static void _recorder_client_user_callback(recorder_cb_info_s *cb_info, char *re
 }
 
 
-static bool _recorder_idle_event_callback(void *data)
+static gboolean _recorder_idle_event_callback(gpointer data)
 {
        recorder_cb_info_s *cb_info = NULL;
        recorder_idle_event_s *rec_idle_event = (recorder_idle_event_s *)data;
 
        if (rec_idle_event == NULL) {
                LOGE("rec_idle_event is NULL");
-               return false;
+               return FALSE;
        }
 
        /* lock event */
-       g_mutex_lock(&rec_idle_event->event_mutex);
+       g_mutex_lock(&g_rec_idle_event_lock);
 
        cb_info = rec_idle_event->cb_info;
        if (cb_info == NULL) {
                LOGW("recorder cb_info is NULL. event %p %d", rec_idle_event, rec_idle_event->event);
+               g_mutex_unlock(&g_rec_idle_event_lock);
                goto IDLE_EVENT_CALLBACK_DONE;
        }
 
        /* remove event from list */
-       g_mutex_lock(&cb_info->idle_event_mutex);
-
        if (cb_info->idle_event_list)
                cb_info->idle_event_list = g_list_remove(cb_info->idle_event_list, (gpointer)rec_idle_event);
 
-       /*LOGD("remove recorder idle event %p, %p", rec_idle_event, cb_info->idle_event_list);*/
-       g_mutex_unlock(&cb_info->idle_event_mutex);
+       g_mutex_unlock(&g_rec_idle_event_lock);
 
        /* user callback */
-       _recorder_client_user_callback(cb_info, rec_idle_event->recv_msg, rec_idle_event->event);
-
-       /* send signal for waiting thread */
-       g_cond_signal(&cb_info->idle_event_cond);
+       _recorder_client_user_callback(cb_info, rec_idle_event->recv_msg, rec_idle_event->event, -1);
 
 IDLE_EVENT_CALLBACK_DONE:
-       /* unlock and release event */
-       g_mutex_unlock(&rec_idle_event->event_mutex);
-       g_mutex_clear(&rec_idle_event->event_mutex);
-
+       /* release event */
        g_free(rec_idle_event);
        rec_idle_event = NULL;
 
-       return false;
+       return FALSE;
 }
 
 
@@ -470,14 +491,13 @@ static void _recorder_deactivate_idle_event_all(recorder_cb_info_s *cb_info)
 {
        recorder_idle_event_s *rec_idle_event = NULL;
        GList *list = NULL;
-       gint64 end_time = 0;
 
        if (cb_info == NULL) {
                LOGE("cb_info is NULL");
                return;
        }
 
-       g_mutex_lock(&cb_info->idle_event_mutex);
+       g_mutex_lock(&g_rec_idle_event_lock);
 
        if (cb_info->idle_event_list == NULL) {
                LOGD("No event");
@@ -498,49 +518,31 @@ static void _recorder_deactivate_idle_event_all(recorder_cb_info_s *cb_info)
 
                                cb_info->idle_event_list = g_list_remove(cb_info->idle_event_list, (gpointer)rec_idle_event);
 
-                               g_mutex_clear(&rec_idle_event->event_mutex);
                                g_free(rec_idle_event);
                                rec_idle_event = NULL;
 
                                continue;
                        }
 
-                       LOGW("remove idle event %p failed", rec_idle_event);
-
-                       if (!g_mutex_trylock(&rec_idle_event->event_mutex)) {
-                               LOGW("lock failed, %p event is calling now", rec_idle_event);
-
-                               end_time = g_get_monotonic_time() + G_TIME_SPAN_MILLISECOND * 100;
-
-                               if (g_cond_wait_until(&cb_info->idle_event_cond, &cb_info->idle_event_mutex, end_time))
-                                       LOGW("signal received");
-                               else
-                                       LOGW("timeout");
-
-                               continue;
-                       }
-
                        LOGW("set NULL cb_info for event %p %d, it will be freed on idle callback",
                                rec_idle_event, rec_idle_event->event);
 
                        rec_idle_event->cb_info = NULL;
 
                        cb_info->idle_event_list = g_list_remove(cb_info->idle_event_list, (gpointer)rec_idle_event);
-
-                       g_mutex_unlock(&rec_idle_event->event_mutex);
                }
 
                g_list_free(cb_info->idle_event_list);
                cb_info->idle_event_list = NULL;
        }
 
-       g_mutex_unlock(&cb_info->idle_event_mutex);
+       g_mutex_unlock(&g_rec_idle_event_lock);
 
        return;
 }
 
 
-static void __recorder_add_msg_to_queue(recorder_cb_info_s *cb_info, int api, int event, int event_class, char *msg)
+static void __recorder_add_msg_to_queue(recorder_cb_info_s *cb_info, int api, int event, int event_class, char *msg, int tfd)
 {
        recorder_message_s *rec_msg = NULL;
        recorder_msg_handler_info_s *msg_handler_info = NULL;
@@ -559,6 +561,7 @@ static void __recorder_add_msg_to_queue(recorder_cb_info_s *cb_info, int api, in
        rec_msg->api = api;
        rec_msg->event = event;
        rec_msg->event_class = event_class;
+       rec_msg->tfd = tfd;
 
        strncpy(rec_msg->recv_msg, msg, sizeof(rec_msg->recv_msg) - 1);
 
@@ -717,7 +720,7 @@ static void __recorder_get_api_operation(int api, recorder_cb_info_s *cb_info, c
 }
 
 
-static void __recorder_process_msg(recorder_cb_info_s *cb_info, char *msg)
+static void __recorder_process_msg(recorder_cb_info_s *cb_info, char *msg, int tfd)
 {
        int ret = RECORDER_ERROR_NONE;
        int api = -1;
@@ -788,7 +791,7 @@ static void __recorder_process_msg(recorder_cb_info_s *cb_info, char *msg)
 
                if (cb_info->api_waiting[api] > 0) {
                        cb_info->api_ret[api] = ret;
-                       cb_info->api_activating[api] = 1;
+                       cb_info->api_activating[api] = TRUE;
 
                        g_cond_signal(&cb_info->api_cond[api]);
                } else {
@@ -797,7 +800,7 @@ static void __recorder_process_msg(recorder_cb_info_s *cb_info, char *msg)
 
                g_mutex_unlock(&cb_info->api_mutex[api]);
        } else if (api_class == MUSE_RECORDER_API_CLASS_THREAD_SUB || api == MUSE_RECORDER_CB_EVENT) {
-               __recorder_add_msg_to_queue(cb_info, api, event, event_class, msg);
+               __recorder_add_msg_to_queue(cb_info, api, event, event_class, msg, tfd);
        } else {
                LOGW("unknown recorder api %d and api_class %d", api, api_class);
        }
@@ -857,9 +860,9 @@ static void *_recorder_msg_handler_func(gpointer data)
                        if (muse_recorder_msg_get(ret, rec_msg->recv_msg)) {
                                if (cb_info->api_waiting[api] > 0) {
                                        cb_info->api_ret[api] = ret;
-                                       cb_info->api_activating[api] = 1;
+                                       cb_info->api_activating[api] = TRUE;
 
-                                       /*LOGD("recorder api %d - return 0x%x", ret);*/
+                                       /*LOGD("recorder api %d - return 0x%x", api, ret);*/
 
                                        g_cond_signal(&cb_info->api_cond[api]);
                                } else {
@@ -873,7 +876,7 @@ static void *_recorder_msg_handler_func(gpointer data)
                } else if (api == MUSE_RECORDER_CB_EVENT) {
                        switch (rec_msg->event_class) {
                        case MUSE_RECORDER_EVENT_CLASS_THREAD_SUB:
-                               _recorder_client_user_callback(cb_info, rec_msg->recv_msg, rec_msg->event);
+                               _recorder_client_user_callback(cb_info, rec_msg->recv_msg, rec_msg->event, rec_msg->tfd);
                                break;
                        case MUSE_RECORDER_EVENT_CLASS_THREAD_MAIN:
                                rec_idle_event = g_new0(recorder_idle_event_s, 1);
@@ -884,14 +887,14 @@ static void *_recorder_msg_handler_func(gpointer data)
 
                                rec_idle_event->event = rec_msg->event;
                                rec_idle_event->cb_info = cb_info;
-                               g_mutex_init(&rec_idle_event->event_mutex);
-                               strncpy(rec_idle_event->recv_msg, rec_msg->recv_msg, sizeof(rec_idle_event->recv_msg) - 1);
+
+                               strncpy(rec_idle_event->recv_msg, rec_msg->recv_msg, sizeof(rec_idle_event->recv_msg));
 
                                /*LOGD("add recorder event[%d, %p] to IDLE", rec_msg->event, rec_idle_event);*/
 
-                               g_mutex_lock(&cb_info->idle_event_mutex);
+                               g_mutex_lock(&g_rec_idle_event_lock);
                                cb_info->idle_event_list = g_list_append(cb_info->idle_event_list, (gpointer)rec_idle_event);
-                               g_mutex_unlock(&cb_info->idle_event_mutex);
+                               g_mutex_unlock(&g_rec_idle_event_lock);
 
                                g_idle_add_full(G_PRIORITY_DEFAULT,
                                        (GSourceFunc)_recorder_idle_event_callback,
@@ -935,14 +938,8 @@ static void *_recorder_msg_handler_func(gpointer data)
 static void *_recorder_msg_recv_func(gpointer data)
 {
        int recv_length = 0;
-       int single_length = 0;
-       int remained_length = 0;
+       int tfd[MUSE_NUM_FD] = {-1, -1, -1, -1};
        char *recv_msg = NULL;
-       char *single_msg = NULL;
-       char *remained_msg = NULL;
-       int num_msg = 0;
-       int cur_pos = 0;
-       int prev_pos = 0;
        recorder_cb_info_s *cb_info = (recorder_cb_info_s *)data;
 
        if (cb_info == NULL) {
@@ -952,98 +949,32 @@ static void *_recorder_msg_recv_func(gpointer data)
 
        LOGD("start");
 
-       single_msg = (char *)malloc(sizeof(char) * MUSE_RECORDER_MSG_MAX_LENGTH);
-       if (single_msg == NULL) {
-               LOGE("single_msg malloc failed");
-               goto CB_HANDLER_EXIT;
-       }
-
        recv_msg = cb_info->recv_msg;
 
        while (g_atomic_int_get(&cb_info->msg_recv_running)) {
-               recv_length = muse_core_msg_recv(cb_info->fd, recv_msg);
+               /* tfd[0] is only used. */
+               tfd[0] = -1;
+
+               recv_length = muse_core_msg_recv_fd(cb_info->fd, recv_msg, MUSE_MSG_MAX_LENGTH, tfd);
                if (recv_length <= 0) {
+//LCOV_EXCL_START
                        cb_info->is_server_connected = FALSE;
                        LOGE("receive msg failed - server disconnected");
                        break;
+//LCOV_EXCL_STOP
                }
 
                recv_msg[recv_length] = '\0';
 
-               cur_pos = 0;
-               prev_pos = 0;
-               num_msg = 0;
-
                /*LOGD("recv msg : %s, length : %d", recv_msg, recv_length);*/
 
-               /* Need to split the combined entering msgs */
-               for (cur_pos = 0; cur_pos < recv_length; cur_pos++) {
-                       if (recv_msg[cur_pos] == '}') {
-                               single_length = cur_pos - prev_pos + 1;
-
-                               if (single_length < MUSE_RECORDER_MSG_MAX_LENGTH) {
-                                       /* check remained msg */
-                                       if (remained_length > 0) {
-                                               if (remained_msg) {
-                                                       strncpy(single_msg, remained_msg, remained_length);
-                                                       strncpy(single_msg + remained_length, recv_msg + prev_pos, single_length);
-                                                       single_msg[remained_length + single_length] = '\0';
-
-                                                       free(remained_msg);
-                                                       remained_msg = NULL;
-                                               } else {
-                                                       strncpy(single_msg, recv_msg + prev_pos, single_length);
-                                                       single_msg[single_length] = '\0';
-                                                       LOGE("lost msg [%s], skip...", single_msg);
-                                               }
-
-                                               remained_length = 0;
-                                       } else {
-                                               strncpy(single_msg, recv_msg + prev_pos, single_length);
-                                               single_msg[single_length] = '\0';
-                                       }
-
-                                       if (single_msg[0] == '{') {
-                                               num_msg++;
-                                               /*LOGD("splitted msg : [%s], Index : %d", single_msg, num_msg);*/
-                                               __recorder_process_msg(cb_info, single_msg);
-                                       } else {
-                                               LOGE("invalid msg [%s]", single_msg);
-                                       }
-                               } else {
-                                       LOGE("too long message [len %d] skip...", single_length);
-                               }
-
-                               prev_pos = cur_pos + 1;
-                       }
-               }
-
-               /* check incompleted message */
-               if (recv_msg[recv_length - 1] != '}') {
-                       remained_length = recv_length - prev_pos;
-
-                       LOGW("incompleted message [len %d]", remained_length);
-
-                       if (remained_msg) {
-                               free(remained_msg);
-                               remained_msg = NULL;
-                       }
-
-                       remained_msg = (char *)malloc(remained_length + 1);
-                       if (remained_msg) {
-                               strncpy(remained_msg, recv_msg + prev_pos, remained_length);
-                               remained_msg[remained_length] = '\0';
-                       } else {
-                               LOGE("failed to alloc for remained msg");
-                       }
-               } else {
-                       remained_length = 0;
-               }
+               __recorder_process_msg(cb_info, recv_msg, tfd[0]);
        }
 
        LOGD("client cb exit - server connected %d", cb_info->is_server_connected);
 
        if (!cb_info->is_server_connected) {
+//LCOV_EXCL_START
                /* send error msg for server disconnection */
                char *error_msg = muse_core_msg_new(MUSE_RECORDER_CB_EVENT,
                        MUSE_TYPE_INT, "error", RECORDER_ERROR_SERVICE_DISCONNECTED,
@@ -1061,25 +992,17 @@ static void *_recorder_msg_recv_func(gpointer data)
                        MUSE_RECORDER_CB_EVENT,
                        MUSE_RECORDER_EVENT_TYPE_ERROR,
                        MUSE_RECORDER_EVENT_CLASS_THREAD_MAIN,
-                       error_msg);
+                       error_msg,
+                       -1);
 
                muse_core_msg_free(error_msg);
                error_msg = NULL;
 
                LOGE("add error msg for service disconnection done");
+//LCOV_EXCL_STOP
        }
 
 CB_HANDLER_EXIT:
-       if (single_msg) {
-               free(single_msg);
-               single_msg = NULL;
-       }
-
-       if (remained_msg) {
-               free(remained_msg);
-               remained_msg = NULL;
-       }
-
        return NULL;
 }
 
@@ -1111,6 +1034,7 @@ static bool __create_msg_handler_thread(recorder_msg_handler_info_s *handler_inf
        handler_info->thread = g_thread_try_new(thread_name,
                _recorder_msg_handler_func, (gpointer)handler_info, NULL);
        if (handler_info->thread == NULL) {
+//LCOV_EXCL_START
                LOGE("t:%d thread failed", type);
 
                g_mutex_clear(&handler_info->mutex);
@@ -1119,6 +1043,7 @@ static bool __create_msg_handler_thread(recorder_msg_handler_info_s *handler_inf
                handler_info->queue = NULL;
 
                return false;
+//LCOV_EXCL_STOP
        }
 
        LOGD("t:%d done", type);
@@ -1184,9 +1109,6 @@ static recorder_cb_info_s *_recorder_client_callback_new(gint sockfd)
                g_cond_init(&cb_info->api_cond[i]);
        }
 
-       g_mutex_init(&cb_info->idle_event_mutex);
-       g_cond_init(&cb_info->idle_event_cond);
-
        for (i = 0 ; i < MUSE_RECORDER_EVENT_TYPE_NUM ; i++)
                g_mutex_init(&cb_info->user_cb_mutex[i]);
 
@@ -1225,7 +1147,7 @@ static recorder_cb_info_s *_recorder_client_callback_new(gint sockfd)
        cb_info->is_server_connected = TRUE;
 
        return cb_info;
-
+//LCOV_EXCL_START
 ErrorExit:
        if (cb_info) {
                __destroy_msg_handler_thread(&cb_info->msg_handler_info);
@@ -1235,9 +1157,6 @@ ErrorExit:
                for (i = 0 ; i < MUSE_RECORDER_EVENT_TYPE_NUM ; i++)
                        g_mutex_clear(&cb_info->user_cb_mutex[i]);
 
-               g_mutex_clear(&cb_info->idle_event_mutex);
-               g_cond_clear(&cb_info->idle_event_cond);
-
                for (i = 0 ; i < MUSE_RECORDER_API_MAX ; i++) {
                        g_mutex_clear(&cb_info->api_mutex[i]);
                        g_cond_clear(&cb_info->api_cond[i]);
@@ -1248,6 +1167,7 @@ ErrorExit:
        }
 
        return NULL;
+//LCOV_EXCL_STOP
 }
 
 static int _recorder_client_wait_for_cb_return(muse_recorder_api_e api, recorder_cb_info_s *cb_info, int time_out)
@@ -1264,36 +1184,33 @@ static int _recorder_client_wait_for_cb_return(muse_recorder_api_e api, recorder
 
        g_mutex_lock(&(cb_info->api_mutex[api]));
 
-       if (cb_info->api_activating[api] == 0) {
+       LOGD("api [%d], timeout [%d sec]", api, time_out);
+
+       end_time = g_get_monotonic_time() + time_out * G_TIME_SPAN_SECOND;
+
+       while (!cb_info->api_activating[api]) {
                if (time_out == RECORDER_CB_NO_TIMEOUT) {
-                       LOGW("wait for api %d", api);
                        g_cond_wait(&(cb_info->api_cond[api]), &(cb_info->api_mutex[api]));
-                       ret = cb_info->api_ret[api];
-                       cb_info->api_activating[api] = 0;
-                       LOGW("api %d returned 0x%x", api, ret);
-               } else {
-                       end_time = g_get_monotonic_time() + time_out * G_TIME_SPAN_SECOND;
-                       if (g_cond_wait_until(&(cb_info->api_cond[api]), &(cb_info->api_mutex[api]), end_time)) {
-                               ret = cb_info->api_ret[api];
-                               cb_info->api_activating[api] = 0;
-                               /*LOGD("return value : 0x%x", ret);*/
-                       } else {
-                               ret = RECORDER_ERROR_INVALID_OPERATION;
-                               LOGE("api %d was TIMED OUT!", api);
-                       }
+                       LOGW("api %d returned 0x%x", api, cb_info->api_ret[api]);
+               } else if (!g_cond_wait_until(&(cb_info->api_cond[api]), &(cb_info->api_mutex[api]), end_time)) {
+                       LOGE("api %d was TIMED OUT!", api);
+                       ret = RECORDER_ERROR_INVALID_OPERATION;
+                       goto _CB_RETURN_END;
                }
-       } else {
-               ret = cb_info->api_ret[api];
-               cb_info->api_activating[api] = 0;
 
-               /*LOGD("condition is already checked for the api[%d], return[0x%x]", api, ret);*/
+               if (!cb_info->api_activating[api])
+                       LOGW("invalid signal received, wait again...");
        }
 
-       if (ret != RECORDER_ERROR_NONE)
-               LOGE("ERROR : api %d - ret 0x%x", api, ret);
+       ret = cb_info->api_ret[api];
+       cb_info->api_activating[api] = FALSE;
 
+_CB_RETURN_END:
        g_mutex_unlock(&(cb_info->api_mutex[api]));
 
+       if (ret != RECORDER_ERROR_NONE)
+               LOGE("ERROR : api %d - ret 0x%x", api, ret);
+
        return ret;
 }
 
@@ -1412,9 +1329,6 @@ static void _recorder_client_callback_destroy(recorder_cb_info_s *cb_info)
        for (i = 0 ; i < MUSE_RECORDER_EVENT_TYPE_NUM ; i++)
                g_mutex_clear(&cb_info->user_cb_mutex[i]);
 
-       g_mutex_clear(&cb_info->idle_event_mutex);
-       g_cond_clear(&cb_info->idle_event_cond);
-
        for (i = 0 ; i < MUSE_RECORDER_API_MAX ; i++) {
                g_mutex_clear(&cb_info->api_mutex[i]);
                g_cond_clear(&cb_info->api_cond[i]);
@@ -1441,7 +1355,7 @@ static void _recorder_client_callback_destroy(recorder_cb_info_s *cb_info)
 }
 
 
-static int _recorder_storage_device_supported_cb(int storage_id, storage_type_e type, storage_state_e state, const char *path, void *user_data)
+static bool _recorder_storage_device_supported_cb(int storage_id, storage_type_e type, storage_state_e state, const char *path, void *user_data)
 {
        char **root_directory = (char **)user_data;
 
@@ -1494,6 +1408,7 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
        int ret = RECORDER_ERROR_NONE;
        int destroy_ret = RECORDER_ERROR_NONE;
        int sock_fd = -1;
+       int module_index = -1;
        int send_ret = 0;
        char *send_msg = NULL;
        char *root_directory = NULL;
@@ -1529,14 +1444,22 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
 
        sock_fd = muse_client_new();
        if (sock_fd < 0) {
+//LCOV_EXCL_START
                LOGE("muse_client_new failed - returned fd %d", sock_fd);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _ERR_RECORDER_EXIT;
+//LCOV_EXCL_STOP
+       }
+
+       if (muse_client_get_module_index(MODULE_NAME, &module_index) != MM_ERROR_NONE) {
+               LOGE("muse client get module index failed");
+               ret = RECORDER_ERROR_INVALID_OPERATION;
+               goto _ERR_RECORDER_EXIT;
        }
 
        if (type == MUSE_RECORDER_TYPE_AUDIO) {
                send_msg = muse_core_msg_new(MUSE_RECORDER_API_CREATE,
-                       MUSE_TYPE_INT, "module", MUSE_RECORDER,
+                       MUSE_TYPE_INT, "module", module_index,
                        MUSE_TYPE_INT, PARAM_RECORDER_TYPE, MUSE_RECORDER_TYPE_AUDIO,
                        MUSE_TYPE_INT, "pid", getpid(),
                        NULL);
@@ -1544,7 +1467,7 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
                pc->camera = camera;
                camera_handle = (intptr_t)((camera_cli_s *)camera)->remote_handle;
                send_msg = muse_core_msg_new(MUSE_RECORDER_API_CREATE,
-                       MUSE_TYPE_INT, "module", MUSE_RECORDER,
+                       MUSE_TYPE_INT, "module", module_index,
                        MUSE_TYPE_INT, PARAM_RECORDER_TYPE, MUSE_RECORDER_TYPE_VIDEO,
                        MUSE_TYPE_INT, "pid", getpid(),
                        MUSE_TYPE_POINTER, "camera_handle", camera_handle,
@@ -1552,9 +1475,11 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
        }
 
        if (!send_msg) {
+//LCOV_EXCL_START
                LOGE("NULL msg");
                ret = RECORDER_ERROR_OUT_OF_MEMORY;
                goto _ERR_RECORDER_EXIT;
+//LCOV_EXCL_STOP
        }
 
        LOGD("sock_fd : %d, msg : %s", sock_fd, send_msg);
@@ -1565,9 +1490,11 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
        send_msg = NULL;
 
        if (send_ret < 0) {
+//LCOV_EXCL_START
                LOGE("send msg failed %d", errno);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _ERR_RECORDER_EXIT;
+//LCOV_EXCL_STOP
        }
 
        pc->cb_info = _recorder_client_callback_new(sock_fd);
@@ -1589,15 +1516,19 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
 
        muse_recorder_msg_get_pointer(handle, pc->cb_info->recv_msg);
        if (handle == 0) {
+//LCOV_EXCL_START
                LOGE("Receiving Handle Failed!!");
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _ERR_RECORDER_AFTER_CREATE;
+//LCOV_EXCL_STOP
        }
 
        if (!_recorder_client_get_root_directory(&root_directory) || root_directory == NULL) {
+//LCOV_EXCL_START
                LOGE("failed to get root directory of internal storage");
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _ERR_RECORDER_AFTER_CREATE;
+//LCOV_EXCL_STOP
        }
 
        LOGD("root directory [%s]", root_directory);
@@ -1618,7 +1549,7 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
        pc->remote_handle = handle;
        pc->cb_info->bufmgr = bufmgr;
 
-       LOGD("recorder[type %d] %p create success : remote handle 0x%x",
+       LOGD("recorder[type %d] %p create success : remote handle 0x%td",
                type, pc, pc->remote_handle);
 
        *recorder = (recorder_h)pc;
@@ -1626,7 +1557,7 @@ static int _recorder_create_common(recorder_h *recorder, muse_recorder_type_e ty
        LOGD("done");
 
        return RECORDER_ERROR_NONE;
-
+//LCOV_EXCL_START
 _ERR_RECORDER_AFTER_CREATE:
        _recorder_msg_send(MUSE_RECORDER_API_DESTROY, pc->cb_info, &destroy_ret, RECORDER_CB_TIMEOUT);
        LOGE("destroy return 0x%x", destroy_ret);
@@ -1655,6 +1586,7 @@ _ERR_RECORDER_EXIT:
        }
 
        return ret;
+//LCOV_EXCL_STOP
 }
 
 
@@ -1686,7 +1618,7 @@ int recorder_get_state(recorder_h recorder, recorder_state_e *state)
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, remote_handle : %x", pc->remote_handle);
+       LOGD("Enter, remote_handle : %td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -1769,6 +1701,7 @@ int recorder_unprepare(recorder_h recorder)
        LOGD("ENTER");
 
        if (pc->camera) {
+//LCOV_EXCL_START
                ret = camera_get_state(pc->camera, &camera_state);
                if (ret != CAMERA_ERROR_NONE) {
                        LOGE("failed to get camera state 0x%x", ret);
@@ -1782,6 +1715,7 @@ int recorder_unprepare(recorder_h recorder)
                                return RECORDER_ERROR_INVALID_OPERATION;
                        }
                }
+//LCOV_EXCL_STOP
        }
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
@@ -1807,6 +1741,7 @@ int recorder_start(recorder_h recorder)
        LOGD("ENTER");
 
        if (pc->camera) {
+//LCOV_EXCL_START
                ret = recorder_get_state(recorder, &current_state);
                if (ret != RECORDER_ERROR_NONE) {
                        LOGE("failed to get current state 0x%x", ret);
@@ -1820,6 +1755,7 @@ int recorder_start(recorder_h recorder)
                                return RECORDER_ERROR_INVALID_OPERATION;
                        }
                }
+//LCOV_EXCL_STOP
        }
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_NO_TIMEOUT);
@@ -1869,6 +1805,7 @@ int recorder_commit(recorder_h recorder)
        LOGD("ENTER");
 
        if (pc->camera) {
+//LCOV_EXCL_START
                ret = recorder_get_state(recorder, &current_state);
                if (ret != RECORDER_ERROR_NONE) {
                        LOGE("failed to get current state 0x%x", ret);
@@ -1882,6 +1819,7 @@ int recorder_commit(recorder_h recorder)
                                return RECORDER_ERROR_INVALID_OPERATION;
                        }
                }
+//LCOV_EXCL_STOP
        }
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
@@ -2026,7 +1964,7 @@ int recorder_foreach_supported_video_resolution(recorder_h recorder,
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        pc->cb_info->user_cb[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_VIDEO_RESOLUTION] = foreach_cb;
        pc->cb_info->user_data[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_VIDEO_RESOLUTION] = user_data;
@@ -2087,7 +2025,7 @@ int recorder_set_filename(recorder_h recorder, const char *filename)
        length = strlen(filename);
 
        if (length >= RECORDER_FILENAME_MAX - 1) {
-               LOGE("too long file name [%d]", length);
+               LOGE("too long file name [%zu]", length);
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
@@ -2285,7 +2223,7 @@ int recorder_set_state_changed_cb(recorder_h recorder, recorder_state_changed_cb
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2345,7 +2283,7 @@ int recorder_set_interrupted_cb(recorder_h recorder, recorder_interrupted_cb cal
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2405,7 +2343,7 @@ int recorder_set_interrupt_started_cb(recorder_h recorder, recorder_interrupt_st
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2465,7 +2403,7 @@ int recorder_set_audio_stream_cb(recorder_h recorder, recorder_audio_stream_cb c
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2525,7 +2463,7 @@ int recorder_set_muxed_stream_cb(recorder_h recorder, recorder_muxed_stream_cb c
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2585,7 +2523,7 @@ int recorder_set_error_cb(recorder_h recorder, recorder_error_cb callback, void
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2645,7 +2583,7 @@ int recorder_set_recording_status_cb(recorder_h recorder, recorder_recording_sta
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        _recorder_msg_send(api, pc->cb_info, &ret, RECORDER_CB_TIMEOUT);
 
@@ -2763,7 +2701,7 @@ int recorder_foreach_supported_file_format(recorder_h recorder, recorder_support
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        pc->cb_info->user_cb[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_FILE_FORMAT] = foreach_cb;
        pc->cb_info->user_data[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_FILE_FORMAT] = user_data;
@@ -3214,7 +3152,7 @@ int recorder_foreach_supported_audio_encoder(recorder_h recorder, recorder_suppo
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        pc->cb_info->user_cb[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_AUDIO_ENCODER] = foreach_cb;
        pc->cb_info->user_data[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_AUDIO_ENCODER] = user_data;
@@ -3238,7 +3176,7 @@ int recorder_foreach_supported_video_encoder(recorder_h recorder, recorder_suppo
                return RECORDER_ERROR_INVALID_PARAMETER;
        }
 
-       LOGD("Enter, handle :%x", pc->remote_handle);
+       LOGD("Enter, handle :%td", pc->remote_handle);
 
        pc->cb_info->user_cb[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_VIDEO_ENCODER] = foreach_cb;
        pc->cb_info->user_data[MUSE_RECORDER_EVENT_TYPE_FOREACH_SUPPORTED_VIDEO_ENCODER] = user_data;
@@ -3463,6 +3401,7 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta
 {
        int ret = RECORDER_ERROR_NONE;
        int sock_fd = -1;
+       int module_index = -1;
        int get_device_state = 0;
        char *send_msg = NULL;
        char recv_msg[MUSE_RECORDER_MSG_MAX_LENGTH] = {'\0',};
@@ -3476,19 +3415,29 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta
 
        sock_fd = muse_client_new();
        if (sock_fd < 0) {
+//LCOV_EXCL_START
                LOGE("muse_client_new failed - returned fd %d", sock_fd);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _GET_DEVICE_STATE_EXIT;
+//LCOV_EXCL_STOP
+       }
+
+       if (muse_client_get_module_index(MODULE_NAME, &module_index) != MM_ERROR_NONE) {
+               LOGE("muse client get module index failed");
+               ret = RECORDER_ERROR_INVALID_OPERATION;
+               goto _GET_DEVICE_STATE_EXIT;
        }
 
        send_msg = muse_core_msg_new(MUSE_RECORDER_API_GET_DEVICE_STATE,
-               MUSE_TYPE_INT, "module", MUSE_RECORDER,
+               MUSE_TYPE_INT, "module", module_index,
                MUSE_TYPE_INT, PARAM_RECORDER_TYPE, type,
                NULL);
        if (!send_msg) {
+//LCOV_EXCL_START
                LOGE("NULL msg");
                ret = RECORDER_ERROR_OUT_OF_MEMORY;
                goto _GET_DEVICE_STATE_EXIT;
+//LCOV_EXCL_STOP
        }
 
        LOGD("sock_fd : %d, msg : %s", sock_fd, send_msg);
@@ -3499,22 +3448,28 @@ int recorder_get_device_state(recorder_type_e type, recorder_device_state_e *sta
        send_msg = NULL;
 
        if (ret < 0) {
+//LCOV_EXCL_START
                LOGE("send msg failed %d", errno);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _GET_DEVICE_STATE_EXIT;
+//LCOV_EXCL_STOP
        }
 
-       ret = muse_core_msg_recv(sock_fd, recv_msg);
+       ret = muse_core_msg_recv(sock_fd, recv_msg, MUSE_RECORDER_MSG_MAX_LENGTH);
        if (ret <= 0) {
+//LCOV_EXCL_START
                LOGE("recv msg failed %d", errno);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _GET_DEVICE_STATE_EXIT;
+//LCOV_EXCL_STOP
        }
 
        if (!muse_recorder_msg_get(ret, recv_msg)) {
+//LCOV_EXCL_START
                LOGE("failed to get return value from msg [%s]", recv_msg);
                ret = RECORDER_ERROR_INVALID_OPERATION;
                goto _GET_DEVICE_STATE_EXIT;
+//LCOV_EXCL_STOP
        }
 
        if (ret == RECORDER_ERROR_NONE) {
@@ -3605,6 +3560,7 @@ int recorder_add_device_state_changed_cb(recorder_device_state_changed_cb callba
 
 _DONE:
        if (ret != RECORDER_ERROR_NONE) {
+//LCOV_EXCL_START
                if (info) {
                        g_free(info);
                        info = NULL;
@@ -3614,6 +3570,7 @@ _DONE:
                        g_object_unref(g_rec_dev_state_changed_cb_conn);
                        g_rec_dev_state_changed_cb_conn = NULL;
                }
+//LCOV_EXCL_STOP
        }
 
        g_mutex_unlock(&g_rec_dev_state_changed_cb_lock);