#include "policy.h"
#include "poolvendor.h"
#include "poolarch.h"
+#include "cplxdeps.h"
/*-----------------------------------------------------------------*/
}
-/*
- * prune to recommended/suggested packages.
- * does not prune installed packages (they are also somewhat recommended).
- */
+#ifdef ENABLE_COMPLEX_DEPS
static void
-prune_to_recommended(Solver *solv, Queue *plist)
+check_complex_dep(Solver *solv, Id dep, Map *m, Queue **cqp)
{
Pool *pool = solv->pool;
- int i, j, k, ninst;
- Solvable *s;
- Id p, pp, rec, *recp, sug, *sugp;
-
- ninst = 0;
- if (pool->installed)
+ Queue q;
+ queue_init(&q);
+ Id p;
+ int i, qcnt;
+
+#if 0
+ printf("check_complex_dep %s\n", pool_dep2str(pool, dep));
+#endif
+ i = pool_normalize_complex_dep(pool, dep, &q, CPLXDEPS_EXPAND);
+ if (i == 0 || i == 1)
{
- for (i = 0; i < plist->count; i++)
+ queue_free(&q);
+ return;
+ }
+ qcnt = q.count;
+ for (i = 0; i < qcnt; i++)
+ {
+ for (; (p = q.elements[i]) != 0; i++)
{
- p = plist->elements[i];
- s = pool->solvables + p;
- if (pool->installed && s->repo == pool->installed)
- ninst++;
+ if (p < 0)
+ {
+ if (solv->decisionmap[-p] > 0)
+ continue;
+ if (solv->decisionmap[-p] < 0)
+ break;
+ queue_push(&q, -p);
+ }
+ if (p > 0 && qcnt == q.count)
+ MAPSET(m, p);
+ }
+ if (q.elements[i])
+ {
+#if 0
+ printf("complex dep block cannot be true\n");
+#endif
+ while (q.elements[i])
+ i++;
+ if (qcnt != q.count)
+ queue_truncate(&q, qcnt);
+ }
+ else if (qcnt != q.count)
+ {
+ int j, k;
+ Queue *cq = *cqp;
+#if 0
+ printf("add new complex dep block\n");
+ for (j = qcnt; j < q.count; j++)
+ printf(" - %s\n", pool_solvid2str(pool, q.elements[j]));
+#endif
+ if (!cq)
+ {
+ cq = solv_calloc(1, sizeof(Queue));
+ queue_init(cq);
+ *cqp = cq;
+ queue_insertn(cq, 0, 256, 0);
+ }
+ for (j = qcnt; j < q.count; j++)
+ {
+ p = q.elements[j];
+ for (k = 256; k < cq->count; k += 2)
+ if (cq->elements[k + 1] == dep && cq->elements[k] == p)
+ break;
+ if (k == cq->count)
+ {
+ queue_push2(cq, p, dep);
+ cq->elements[p & 255] |= (1 << (p >> 8 & 31));
+ }
+ }
+ queue_truncate(&q, qcnt);
}
}
- if (plist->count - ninst < 2)
- return;
+ queue_free(&q);
+}
+
+static void
+recheck_complex_dep(Solver *solv, Id p, Map *m, Queue **cqp)
+{
+ Queue *cq = *cqp;
+ int i;
+#if 0
+ printf("recheck_complex_dep for package %s\n", pool_solvid2str(solv->pool, p));
+#endif
+ for (i = 256; i < cq->count; i += 2)
+ if (cq->elements[i] == p)
+ break;
+ if (i == cq->count)
+ return; /* false alert */
+ if (solv->decisionmap[p] <= 0)
+ return; /* just in case... */
+ memset(cq->elements, 0, sizeof(Id) * 256);
+ for (i = 256; i < cq->count; i += 2)
+ if (cq->elements[i] == p)
+ {
+ Id dep = cq->elements[i + 1];
+ queue_deleten(cq, i, 2);
+ i -= 2;
+ check_complex_dep(solv, dep, m, &cq);
+ }
+ else
+ {
+ Id pp = cq->elements[i];
+ cq->elements[pp & 255] |= (1 << (pp >> 8 & 31));
+ }
+}
+
+#endif
+
+
+void
+policy_update_recommendsmap(Solver *solv)
+{
+ Pool *pool = solv->pool;
+ Solvable *s;
+ Id p, pp, rec, *recp, sug, *sugp;
- /* update our recommendsmap/suggestsmap */
if (solv->recommends_index < 0)
{
MAPZERO(&solv->recommendsmap);
MAPZERO(&solv->suggestsmap);
+#ifdef ENABLE_COMPLEX_DEPS
+ if (solv->recommendscplxq)
+ {
+ queue_free(solv->recommendscplxq);
+ solv->recommendscplxq = solv_free(solv->recommendscplxq);
+ }
+ if (solv->suggestscplxq)
+ {
+ queue_free(solv->suggestscplxq);
+ solv->suggestscplxq = solv_free(solv->suggestscplxq);
+ }
+#endif
solv->recommends_index = 0;
}
while (solv->recommends_index < solv->decisionq.count)
if (p < 0)
continue;
s = pool->solvables + p;
+#ifdef ENABLE_COMPLEX_DEPS
+ if (solv->recommendscplxq && solv->recommendscplxq->elements[p & 255])
+ if (solv->recommendscplxq->elements[p & 255] & (1 << (p >> 8 & 31)))
+ recheck_complex_dep(solv, p, &solv->recommendsmap, &solv->recommendscplxq);
+ if (solv->suggestscplxq && solv->suggestscplxq->elements[p & 255])
+ if (solv->suggestscplxq->elements[p & 255] & (1 << (p >> 8 & 31)))
+ recheck_complex_dep(solv, p, &solv->suggestsmap, &solv->suggestscplxq);
+#endif
if (s->recommends)
{
recp = s->repo->idarraydata + s->recommends;
while ((rec = *recp++) != 0)
- FOR_PROVIDES(p, pp, rec)
- MAPSET(&solv->recommendsmap, p);
+ {
+#ifdef ENABLE_COMPLEX_DEPS
+ if (pool_is_complex_dep(pool, rec))
+ {
+ check_complex_dep(solv, rec, &solv->recommendsmap, &solv->recommendscplxq);
+ continue;
+ }
+#endif
+ FOR_PROVIDES(p, pp, rec)
+ MAPSET(&solv->recommendsmap, p);
+ }
}
if (s->suggests)
{
sugp = s->repo->idarraydata + s->suggests;
while ((sug = *sugp++) != 0)
- FOR_PROVIDES(p, pp, sug)
- MAPSET(&solv->suggestsmap, p);
+ {
+#ifdef ENABLE_COMPLEX_DEPS
+ if (pool_is_complex_dep(pool, sug))
+ {
+ check_complex_dep(solv, sug, &solv->suggestsmap, &solv->suggestscplxq);
+ continue;
+ }
+#endif
+ FOR_PROVIDES(p, pp, sug)
+ MAPSET(&solv->suggestsmap, p);
+ }
+ }
+ }
+}
+
+/* bring suggested/enhanced packages to front
+ * installed packages count as suggested */
+static void
+prefer_suggested(Solver *solv, Queue *plist)
+{
+ Pool *pool = solv->pool;
+ int i, count;
+
+ /* update our recommendsmap/suggestsmap */
+ if (solv->recommends_index < solv->decisionq.count)
+ policy_update_recommendsmap(solv);
+
+ for (i = 0, count = plist->count; i < count; i++)
+ {
+ Id p = plist->elements[i];
+ Solvable *s = pool->solvables + p;
+ if ((pool->installed && s->repo == pool->installed) ||
+ MAPTST(&solv->suggestsmap, p) ||
+ solver_is_enhancing(solv, s))
+ continue; /* good package */
+ /* bring to back */
+ if (i < plist->count - 1)
+ {
+ memmove(plist->elements + i, plist->elements + i + 1, (plist->count - 1 - i) * sizeof(Id));
+ plist->elements[plist->count - 1] = p;
+ }
+ i--;
+ count--;
+ }
+}
+
+/*
+ * prune to recommended/suggested packages.
+ * does not prune installed packages (they are also somewhat recommended).
+ */
+static void
+prune_to_recommended(Solver *solv, Queue *plist)
+{
+ Pool *pool = solv->pool;
+ int i, j, k, ninst;
+ Solvable *s;
+ Id p;
+
+ ninst = 0;
+ if (pool->installed)
+ {
+ for (i = 0; i < plist->count; i++)
+ {
+ p = plist->elements[i];
+ s = pool->solvables + p;
+ if (pool->installed && s->repo == pool->installed)
+ ninst++;
}
}
+ if (plist->count - ninst < 2)
+ return;
+
+ /* update our recommendsmap/suggestsmap */
+ if (solv->recommends_index < solv->decisionq.count)
+ policy_update_recommendsmap(solv);
/* prune to recommended/supplemented */
ninst = 0;
if (j)
plist->count = j;
+#if 0
/* anything left to prune? */
if (plist->count - ninst < 2)
return;
}
if (j)
plist->count = j;
+#endif
}
static void
trj->nstack = stackstart; /* empty stack */
}
}
-
+
/*
* remove entries from plist that are obsoleted by other entries
* with different name.
struct trj_data trj;
int i, j;
Solvable *s;
-
+
if (plist->count <= 16)
{
memset(data_buf, 0, sizeof(data_buf));
* sort list of packages (given through plist) by name and evr
* return result through plist
*/
-static void
+void
prune_to_best_version(Pool *pool, Queue *plist)
{
int i, j;
}
+static int
+sort_by_name_evr_sortcmp(const void *ap, const void *bp, void *dp)
+{
+ Pool *pool = dp;
+ Id a, *aa = (Id *)ap;
+ Id b, *bb = (Id *)bp;
+ Id r = aa[1] - bb[1];
+ if (r)
+ return r < 0 ? -1 : 1;
+ a = aa[2] < 0 ? -aa[2] : aa[2];
+ b = bb[2] < 0 ? -bb[2] : bb[2];
+ if (pool->disttype != DISTTYPE_DEB)
+ {
+ /* treat release-less versions different */
+ const char *as = pool_id2str(pool, a);
+ const char *bs = pool_id2str(pool, b);
+ if (strchr(as, '-'))
+ {
+ if (!strchr(bs, '-'))
+ return -2;
+ }
+ else
+ {
+ if (strchr(bs, '-'))
+ return 2;
+ }
+ }
+ r = pool_evrcmp(pool, b, a, EVRCMP_COMPARE);
+ if (!r && (aa[2] < 0 || bb[2] < 0))
+ {
+ if (bb[2] >= 0)
+ return 1;
+ if (aa[2] >= 0)
+ return -1;
+ }
+ if (r)
+ return r < 0 ? -1 : 1;
+ return 0;
+}
+
+/* common end of sort_by_srcversion and sort_by_common_dep */
+static void
+sort_by_name_evr_array(Pool *pool, Queue *plist, int count, int ent)
+{
+ Id lastname;
+ int i, j, bad, havebad;
+ Id *pp, *elements = plist->elements;
+
+ if (ent < 2)
+ {
+ queue_truncate(plist, count);
+ return;
+ }
+ solv_sort(elements + count * 2, ent, sizeof(Id) * 3, sort_by_name_evr_sortcmp, pool);
+ lastname = 0;
+ bad = havebad = 0;
+ for (i = 0, pp = elements + count * 2; i < ent; i++, pp += 3)
+ {
+ if (lastname && pp[1] == lastname)
+ {
+ if (pp[0] != pp[-3] && sort_by_name_evr_sortcmp(pp - 3, pp, pool) == -1)
+ {
+#if 0
+ printf("%s - %s: bad %s %s - %s\n", pool_solvid2str(pool, elements[pp[-3]]), pool_solvid2str(pool, elements[pp[0]]), pool_dep2str(pool, lastname), pool_id2str(pool, pp[-1] < 0 ? -pp[-1] : pp[-1]), pool_id2str(pool, pp[2] < 0 ? -pp[2] : pp[2]));
+#endif
+ bad++;
+ havebad = 1;
+ }
+ }
+ else
+ {
+ bad = 0;
+ lastname = pp[1];
+ }
+ elements[count + pp[0]] += bad;
+ }
+
+#if 0
+for (i = 0; i < count; i++)
+ printf("%s badness %d\n", pool_solvid2str(pool, elements[i]), elements[count + i]);
+#endif
+
+ if (havebad)
+ {
+ /* simple stable insertion sort */
+ if (pool->installed)
+ for (i = 0; i < count; i++)
+ if (pool->solvables[elements[i]].repo == pool->installed)
+ elements[i + count] = 0;
+ for (i = 1; i < count; i++)
+ for (j = i, pp = elements + count + j; j > 0; j--, pp--)
+ if (pp[-1] > pp[0])
+ {
+ Id *pp2 = pp - count;
+ Id p = pp[-1];
+ pp[-1] = pp[0];
+ pp[0] = p;
+ p = pp2[-1];
+ pp2[-1] = pp2[0];
+ pp2[0] = p;
+ }
+ else
+ break;
+ }
+ queue_truncate(plist, count);
+}
+
+#if 0
+static void
+sort_by_srcversion(Pool *pool, Queue *plist)
+{
+ int i, count = plist->count, ent = 0;
+ queue_insertn(plist, count, count, 0);
+ for (i = 0; i < count; i++)
+ {
+ Id name, evr, p = plist->elements[i];
+ Solvable *s = pool->solvables + p;
+ if (solvable_lookup_void(s, SOLVABLE_SOURCENAME))
+ name = s->name;
+ else
+ name = solvable_lookup_id(s, SOLVABLE_SOURCENAME);
+ if (solvable_lookup_void(s, SOLVABLE_SOURCEEVR))
+ evr = s->evr;
+ else
+ evr = solvable_lookup_id(s, SOLVABLE_SOURCEEVR);
+ if (!name || !evr || ISRELDEP(evr))
+ continue;
+ queue_push(plist, i);
+ queue_push2(plist, name, evr);
+ ent++;
+ }
+ sort_by_name_evr_array(pool, plist, count, ent);
+}
+#endif
+
+static void
+sort_by_common_dep(Pool *pool, Queue *plist)
+{
+ int i, count = plist->count, ent = 0;
+ Id id, *dp;
+ queue_insertn(plist, count, count, 0);
+ for (i = 0; i < count; i++)
+ {
+ Id p = plist->elements[i];
+ Solvable *s = pool->solvables + p;
+ if (!s->provides)
+ continue;
+ for (dp = s->repo->idarraydata + s->provides; (id = *dp++) != 0; )
+ {
+ Reldep *rd;
+ if (!ISRELDEP(id))
+ continue;
+ rd = GETRELDEP(pool, id);
+ if ((rd->flags == REL_EQ || rd->flags == (REL_EQ | REL_LT) || rd->flags == REL_LT) && !ISRELDEP(rd->evr))
+ {
+ if (rd->flags == REL_EQ)
+ {
+ /* ignore hashes */
+ const char *s = pool_id2str(pool, rd->evr);
+ if (strlen(s) >= 4)
+ {
+ while ((*s >= 'a' && *s <= 'f') || (*s >= '0' && *s <= '9'))
+ s++;
+ if (!*s)
+ continue;
+ }
+ }
+ queue_push(plist, i);
+ queue_push2(plist, rd->name, rd->flags == REL_LT ? -rd->evr : rd->evr);
+ ent++;
+ }
+ }
+ }
+ sort_by_name_evr_array(pool, plist, count, ent);
+}
+
+/* check if we have an update candidate */
+static void
+dislike_old_versions(Pool *pool, Queue *plist)
+{
+ int i, count = plist->count;
+ Id *elements = plist->elements;
+ int bad = 0;
+
+ for (i = 0; i < count; i++)
+ {
+ Id p = elements[i];
+ Solvable *s = pool->solvables + p;
+ Repo *repo = s->repo;
+ Id q, qq;
+
+ if (!repo || repo == pool->installed)
+ continue;
+ FOR_PROVIDES(q, qq, s->name)
+ {
+ Solvable *qs = pool->solvables + q;
+ if (q == p)
+ continue;
+ if (s->name != qs->name || s->arch != qs->arch)
+ continue;
+ if (repo->priority != qs->repo->priority)
+ {
+ if (repo->priority > qs->repo->priority)
+ continue;
+ elements[i] = -p;
+ bad = 1;
+ break;
+ }
+ if (pool_evrcmp(pool, qs->evr, s->evr, EVRCMP_COMPARE) > 0)
+ {
+ elements[i] = -p;
+ bad = 1;
+ break;
+ }
+ }
+ }
+ if (!bad)
+ return;
+ /* now move negative elements to the back */
+ for (i = 0; i < count; i++)
+ {
+ Id p = elements[i];
+ if (p >= 0)
+ continue;
+ if (i < plist->count - 1)
+ {
+ memmove(elements + i, elements + i + 1, (plist->count - 1 - i) * sizeof(Id));
+ elements[plist->count - 1] = -p;
+ }
+ i--;
+ count--;
+ }
+}
+
/*
* POLICY_MODE_CHOOSE: default, do all pruning steps
* POLICY_MODE_RECOMMEND: leave out prune_to_recommended
if (plist->count > 1)
prune_to_best_version(pool, plist);
if (plist->count > 1 && mode == POLICY_MODE_CHOOSE)
- prune_to_recommended(solv, plist);
+ {
+ prune_to_recommended(solv, plist);
+ if (plist->count > 1)
+ {
+ /* do some fancy reordering */
+#if 0
+ sort_by_srcversion(pool, plist);
+#endif
+ dislike_old_versions(pool, plist);
+ sort_by_common_dep(pool, plist);
+ prefer_suggested(solv, plist);
+ }
+ }
}
}
/*-------------------------------------------------------------------
- *
+ *
* create reverse obsoletes map for installed solvables
*
* For each installed solvable find which packages with *different* names
/*
* find update candidates
- *
+ *
* s: installed solvable to be updated
* qs: [out] queue to hold Ids of candidates
* allow_all: 0 = dont allow downgrades, 1 = allow all candidates
* 2 = dup mode
- *
+ *
*/
void
policy_findupdatepackages(Solver *solv, Solvable *s, Queue *qs, int allow_all)
ps = pool->solvables + p;
if (s->name == ps->name) /* name match */
{
- /* XXX: check implicitobsoleteusescolors? */
+ if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, ps))
+ continue;
if (!allowdowngrade && pool_evrcmp(pool, s->evr, ps->evr, EVRCMP_COMPARE) > 0)
continue;
}
continue;
else if (!solv->noupdateprovide && ps->obsoletes) /* provides/obsoletes combination ? */
{
+ /* check if package ps obsoletes installed package s */
+ /* implicitobsoleteusescolors is somewhat wrong here, but we nevertheless
+ * use it to limit our update candidates */
+ if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s, ps))
+ continue;
obsp = ps->repo->idarraydata + ps->obsoletes;
while ((obs = *obsp++) != 0) /* for all obsoletes */
{
Solvable *ps2 = pool->solvables + p2;
if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps2, obs))
continue;
- if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps2))
- continue;
if (p2 == n) /* match ! */
break;
}
continue;
if (!allowvendorchange && s->vendor != ps->vendor && policy_illegal_vendorchange(solv, s, ps))
continue;
+ /* implicitobsoleteusescolors is somewhat wrong here, but we nevertheless
+ * use it to limit our update candidates */
+ if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, ps))
+ continue;
queue_push(qs, p);
}
}
projects / platform / upstream / libsolv.git / blobdiff