}
idx = 1;
- sqlite3_bind_text(stmt, idx++, pkgid, -1, SQLITE_STATIC);
+ ret = sqlite3_bind_text(stmt, idx++, pkgid, -1, SQLITE_STATIC);
+ if (ret != SQLITE_OK) {
+ _LOGE("bind failed: %s", sqlite3_errmsg(db));
+ sqlite3_finalize(stmt);
+ return PMINFO_R_ERROR;
+ }
+
for (i = 0; i < MAX_CERT_TYPE; i++) {
if (sqlite3_bind_text(stmt, idx++, cert_info[i], -1,
SQLITE_STATIC)) {
_LOGE("prepare error: %s", sqlite3_errmsg(db));
return PMINFO_R_ERROR;
}
- sqlite3_bind_text(stmt, 1, pkgid, -1, SQLITE_STATIC);
+
+ if (sqlite3_bind_text(stmt, 1, pkgid, -1, SQLITE_STATIC)) {
+ _LOGE("bind error: %s", sqlite3_errmsg(db));
+ sqlite3_finalize(stmt);
+ return PMINFO_R_ERROR;
+ }
+
ret = sqlite3_step(stmt);
sqlite3_finalize(stmt);
}
return PMINFO_R_EINVAL;
}
+ _check_create_cert_db();
+
/* open unified global cert db */
dbpath = getUserPkgCertDBPathUID(GLOBAL_USER);
if (dbpath == NULL)
return PMINFO_R_ERROR;
}
- _check_create_cert_db(db);
-
if (_pkginfo_save_cert_index_info(db, info->cert_info)) {
_LOGE("failed to save cert index info, rollback now");
- sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+ sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
sqlite3_close_v2(db);
return PMINFO_R_ERROR;
}
if (_pkginfo_save_cert_info(db, pkgid, info->cert_info)) {
_LOGE("failed to save cert info, rollback now");
- sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+ sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
sqlite3_close_v2(db);
return PMINFO_R_ERROR;
}
ret = sqlite3_exec(db, "COMMIT", NULL, NULL, NULL);
if (ret != SQLITE_OK) {
_LOGE("failed to commit transaction, rollback now");
- sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+ sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
sqlite3_close_v2(db);
return PMINFO_R_ERROR;
}
if (dbpath == NULL)
return PMINFO_R_ERROR;
- ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE, NULL);
+ ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE);
if (ret != SQLITE_OK) {
_LOGE("failed to open db: %d", ret);
free(dbpath);
if (_pkginfo_delete_certinfo(db, pkgid)) {
_LOGE("failed to delete certinfo of %s, rollback now", pkgid);
- sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+ sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
sqlite3_close_v2(db);
return PMINFO_R_ERROR;
}
ret = sqlite3_exec(db, "COMMIT", NULL, NULL, NULL);
if (ret != SQLITE_OK) {
_LOGE("failed to commit transaction, rollback now");
- sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL);
+ sqlite3_exec(db, "ROLLBACK", NULL, NULL, NULL);
sqlite3_close_v2(db);
return PMINFO_R_ERROR;
}