Fix build warnings

[platform/core/appfw/pkgmgr-info.git] / src / pkgmgrinfo_archiveinfo.c

diff --git a/src/pkgmgrinfo_archiveinfo.c b/src/pkgmgrinfo_archiveinfo.c
index 0a8c2b8..b61a24a 100644 (file)
--- a/src/pkgmgrinfo_archiveinfo.c
+++ b/src/pkgmgrinfo_archiveinfo.c
@@ -91,7 +91,7 @@ API int pkgmgrinfo_archiveinfo_get_pkgid(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->pkgid)) {
+       if (info == NULL || strlen(info->pkgid) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -107,7 +107,7 @@ API int pkgmgrinfo_archiveinfo_get_type(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->pkg_type)) {
+       if (info == NULL || strlen(info->pkg_type) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -123,7 +123,7 @@ API int pkgmgrinfo_archiveinfo_get_version(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->version)) {
+       if (info == NULL || strlen(info->version) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -139,7 +139,7 @@ API int pkgmgrinfo_archiveinfo_get_api_version(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->api_version)) {
+       if (info == NULL || strlen(info->api_version) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -220,7 +220,7 @@ API int pkgmgrinfo_archiveinfo_get_icon(pkgmgrinfo_archiveinfo_h handle,
        if (info->icon_buf == NULL)
                return PMINFO_R_ENOENT;
 
-       *icon = info->icon_buf;
+       *icon = (unsigned char *)info->icon_buf;
        *size = info->icon_size;
 
        return PMINFO_R_OK;