Add double quote at argument to parsing properly

[platform/core/appfw/pkgmgr-server.git] / src / pkgmgr-server.c

diff --git a/src/pkgmgr-server.c b/src/pkgmgr-server.c
index dc8e153..4dd532e 100644 (file)
--- a/src/pkgmgr-server.c
+++ b/src/pkgmgr-server.c
@@ -695,7 +695,7 @@ static int __process_install(struct backend_job *job)
        if (backend_cmd == NULL)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -k %s -i %s -u %d %s", backend_cmd,
+       snprintf(args, sizeof(args), "%s -k \"%s\" -i \"%s\" -u %d %s", backend_cmd,
                        job->req_id, job->pkgid, (int)job->target_uid, job->args);
 
        argv = __generate_argv(args);
@@ -717,7 +717,7 @@ static int __process_mount_install(struct backend_job *job)
        if (backend_cmd == NULL)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -k %s -w %s -u %d %s", backend_cmd,
+       snprintf(args, sizeof(args), "%s -k \"%s\" -w \"%s\" -u %d %s", backend_cmd,
                        job->req_id, job->pkgid, (int)job->target_uid, job->args);
 
        argv = __generate_argv(args);
@@ -739,7 +739,7 @@ static int __process_reinstall(struct backend_job *job)
        if (backend_cmd == NULL)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -k %s -r %s -u %d", backend_cmd,
+       snprintf(args, sizeof(args), "%s -k \"%s\" -r \"%s\" -u %d", backend_cmd,
                        job->req_id, job->pkgid, (int)job->target_uid);
        argv = __generate_argv(args);
 
@@ -1007,7 +1007,7 @@ static int __process_enable_global_app_for_uid(struct backend_job *job)
        if (ret != PMINFO_R_OK || strlen(job->appid) == 0) {
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_START_KEY_STR,
-                               PKGMGR_INSTALLER_GLOBAL_APP_ENABLE_FOR_UID,
+                               PKGMGR_INSTALLER_APP_ENABLE_EVENT_STR,
                                job->req_type);
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_END_KEY_STR,
@@ -1018,7 +1018,7 @@ static int __process_enable_global_app_for_uid(struct backend_job *job)
 
        _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->appid,
                        PKGMGR_INSTALLER_START_KEY_STR,
-                       PKGMGR_INSTALLER_GLOBAL_APP_ENABLE_FOR_UID,
+                       PKGMGR_INSTALLER_APP_ENABLE_EVENT_STR,
                        job->req_type);
 
        ret = pkgmgr_parser_update_global_app_disable_for_uid_info_in_db(
@@ -1050,7 +1050,7 @@ static int __process_disable_global_app_for_uid(struct backend_job *job)
                _send_app_signal(job->target_uid, job->req_id,
                                job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_START_KEY_STR,
-                               PKGMGR_INSTALLER_GLOBAL_APP_DISABLE_FOR_UID,
+                               PKGMGR_INSTALLER_APP_DISABLE_EVENT_STR,
                                job->req_type);
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_END_KEY_STR,
@@ -1062,7 +1062,7 @@ static int __process_disable_global_app_for_uid(struct backend_job *job)
        _send_app_signal(job->target_uid, job->req_id,
                        job->pkgid, job->appid,
                        PKGMGR_INSTALLER_START_KEY_STR,
-                       PKGMGR_INSTALLER_GLOBAL_APP_DISABLE_FOR_UID,
+                       PKGMGR_INSTALLER_APP_DISABLE_EVENT_STR,
                        job->req_type);
 
        ret = __kill_app(job->appid, job->target_uid);
@@ -1164,9 +1164,10 @@ static int __process_cleardata(struct backend_job *job)
        if ((int)job->target_uid < REGULAR_USER)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -d %s", backend_cmd, job->pkgid);
+       snprintf(args, sizeof(args), "%s -d -n %s -u %d",
+                       backend_cmd, job->pkgid, job->target_uid);
        argv = __generate_argv(args);
-       pid = __fork_and_exec_with_args(argv, job->target_uid);
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
 
        g_strfreev(argv);
        return pid;
@@ -1182,9 +1183,10 @@ static int __process_clearcache(struct backend_job *job)
        if ((int)job->target_uid < REGULAR_USER)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -c %s", backend_cmd, job->pkgid);
+       snprintf(args, sizeof(args), "%s -c -n %s -u %d",
+                       backend_cmd, job->pkgid, job->target_uid);
        argv = __generate_argv(args);
-       pid = __fork_and_exec_with_args(argv, job->target_uid);
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
 
        g_strfreev(argv);
        return pid;
@@ -1447,6 +1449,29 @@ static int __process_set_app_label(struct backend_job *job)
        return ret;
 }
 
+static int __process_migrate_external_image(struct backend_job *job)
+{
+       char *backend_cmd;
+       char **argv;
+       char args[MAX_PKG_ARGS_LEN];
+       int pid;
+
+       backend_cmd = job->backend_path;
+       if (backend_cmd == NULL)
+               return -1;
+
+       snprintf(args, sizeof(args), "%s -k %s --migrate-extimg %s -u %d %s",
+                       backend_cmd, job->req_id, job->pkgid,
+                       (int)job->target_uid, job->args);
+
+       argv = __generate_argv(args);
+
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
+       g_strfreev(argv);
+
+       return pid;
+}
+
 static int __post_process(int ret, int x, struct backend_job *job)
 {
        if (ret < 0) {
@@ -1477,7 +1502,7 @@ gboolean queue_job(void *data)
 
        /* all backend messages queue are empty or busy */
        if (x == num_of_backends || job == NULL) {
-               DBG("no job left");
+               DBG("no job available");
                return FALSE;
        }
 
@@ -1493,7 +1518,7 @@ gboolean queue_job(void *data)
                        ret = -1;
                        _send_fail_signal(job);
                        _free_backend_job(job);
-                       return FALSE;
+                       return TRUE;
                }
        }
 #endif
@@ -1620,12 +1645,17 @@ gboolean queue_job(void *data)
                ret = __process_set_app_label(job);
                _free_backend_job(job);
                break;
+       case REQUEST_TYPE_MIGRATE_EXTERNAL_IMAGE:
+               __set_backend_busy(x);
+               ret = __process_migrate_external_image(job);
+               __post_process(ret, x, job);
+               break;
        default:
                ret = -1;
                break;
        }
 
-       return FALSE;
+       return TRUE;
 }
 
 int main(int argc, char *argv[])