Use signalfd to handle SIGCHLD
[platform/core/appfw/pkgmgr-server.git] / src / pkgmgr-server.c
index dc8e153..38334d9 100644 (file)
@@ -30,6 +30,7 @@
 #include <sys/wait.h>
 #include <sys/stat.h>
 #include <sys/types.h>
+#include <sys/signalfd.h>
 #include <signal.h>
 #include <grp.h>
 #include <fcntl.h>
@@ -82,14 +83,8 @@ is dynamically determined.
 static char backend_busy = 0;
 extern int num_of_backends;
 
-struct signal_info_t {
-       pid_t pid;
-       int status;
-};
-
-static int pipe_sig[2];
-static GIOChannel *pipe_io;
-static guint pipe_wid;
+static GIOChannel *sio;
+static guint swid;
 static GHashTable *backend_info_table;
 static GMainLoop *mainloop;
 
@@ -98,7 +93,6 @@ static int __check_queue_status_for_exit(void);
 static int __is_backend_busy(int position);
 static void __set_backend_busy(int position);
 static void __set_backend_free(int position);
-static void sighandler(int signo);
 
 gboolean exit_server(void *data);
 
@@ -179,39 +173,42 @@ static int __setup_size_info_io(struct backend_job *job)
        return 0;
 }
 
-static gboolean pipe_io_handler(GIOChannel *io, GIOCondition cond,
+static gboolean __signal_handler(GIOChannel *io, GIOCondition cond,
                gpointer data)
 {
        GError *err = NULL;
        GIOStatus s;
        gsize len;
-       struct signal_info_t info;
+       struct signalfd_siginfo fdsi;
        struct backend_job *job;
+       pid_t pid;
+       int status;
 
-       s = g_io_channel_read_chars(io, (gchar *)&info,
-                       sizeof(struct signal_info_t), &len, &err);
-       if (s != G_IO_STATUS_NORMAL) {
-               ERR("Signal pipe read failed: %s", err->message);
+       s = g_io_channel_read_chars(io, (gchar *)&fdsi,
+                       sizeof(struct signalfd_siginfo), &len, &err);
+       if (s != G_IO_STATUS_NORMAL || len != sizeof(struct signalfd_siginfo)) {
+               ERR("Signal read failed");
                g_error_free(err);
                return TRUE;
        }
 
+       pid = waitpid(-1, &status, WNOHANG);
        job = (struct backend_job *)g_hash_table_lookup(backend_info_table,
-                       (gconstpointer)info.pid);
+                       (gconstpointer)pid);
        if (job == NULL) {
                ERR("Unknown child exit");
                return -1;
        }
 
        __set_backend_free(job->backend_slot);
-       if (WIFSIGNALED(info.status)) {
+       if (WIFSIGNALED(status)) {
                _send_fail_signal(job);
-               DBG("backend[%s] exit with signal[%d]", job->backend_type,
-                               WTERMSIG(info.status));
-       } else if (WEXITSTATUS(info.status)) {
-               DBG("backend[%s] exit with error", job->backend_type);
+               DBG("backend[%s][%d] exit with signal[%d]", job->backend_type,
+                               pid, WTERMSIG(status));
+       } else if (WEXITSTATUS(status)) {
+               DBG("backend[%s][%d] exit with error", job->backend_type, pid);
        } else {
-               DBG("backend[%s] exit", job->backend_type);
+               DBG("backend[%s][%d] exit", job->backend_type, pid);
        }
 
        if (job->extra) {
@@ -222,7 +219,7 @@ static gboolean pipe_io_handler(GIOChannel *io, GIOCondition cond,
                }
        }
 
-       g_hash_table_remove(backend_info_table, (gconstpointer)info.pid);
+       g_hash_table_remove(backend_info_table, (gconstpointer)pid);
        g_idle_add(queue_job, NULL);
 
        return TRUE;
@@ -234,60 +231,42 @@ static int __init_backend_info(void)
                        g_direct_equal, NULL,
                        (GDestroyNotify)_free_backend_job);
 
-       if (pipe(pipe_sig)) {
-               ERR("create pipe failed");
-               return -1;
-       }
-
-       pipe_io = g_io_channel_unix_new(pipe_sig[0]);
-       g_io_channel_set_encoding(pipe_io, NULL, NULL);
-       g_io_channel_set_buffered(pipe_io, FALSE);
-       pipe_wid = g_io_add_watch(pipe_io, G_IO_IN, pipe_io_handler, NULL);
-
        return 0;
 }
 
 static void __fini_backend_info(void)
 {
-       g_source_remove(pipe_wid);
-       g_io_channel_unref(pipe_io);
-       close(pipe_sig[0]);
-       close(pipe_sig[1]);
-
        /*Free backend info */
        g_hash_table_destroy(backend_info_table);
 }
 
-static void sighandler(int signo)
-{
-       struct signal_info_t info;
-       char buf[1024] = {0, };
-
-       info.pid = waitpid(-1, &info.status, WNOHANG);
-       if (write(pipe_sig[1], &info, sizeof(struct signal_info_t)) < 0)
-               ERR("failed to write result: %s",
-                               strerror_r(errno, buf, sizeof(buf)));
-}
-
 static int __register_signal_handler(void)
 {
-       static int sig_reg = 0;
-       struct sigaction act;
+       sigset_t mask;
+       int sfd;
 
-       if (sig_reg)
-               return 0;
+       sigemptyset(&mask);
+       sigaddset(&mask, SIGCHLD);
 
-       act.sa_handler = sighandler;
-       sigemptyset(&act.sa_mask);
-       act.sa_flags = SA_NOCLDSTOP;
-       if (sigaction(SIGCHLD, &act, NULL) < 0) {
-               ERR("signal: SIGCHLD failed");
+       if (sigprocmask(SIG_BLOCK, &mask, NULL) == -1) {
+               ERR("sigprocmask failed");
                return -1;
        }
 
+       sfd = signalfd(-1, &mask, SFD_NONBLOCK);
+       if (sfd == -1) {
+               ERR("signalfd failed");
+               return -1;
+       }
+
+       sio = g_io_channel_unix_new(sfd);
+       g_io_channel_set_close_on_unref(sio, TRUE);
+       g_io_channel_set_encoding(sio, NULL, NULL);
+       g_io_channel_set_buffered(sio, FALSE);
+       swid = g_io_add_watch(sio, G_IO_IN, __signal_handler, NULL);
+
        g_timeout_add_seconds(2, exit_server, NULL);
 
-       sig_reg = 1;
        return 0;
 }
 
@@ -689,19 +668,28 @@ static int __process_install(struct backend_job *job)
        char *backend_cmd;
        char **argv;
        char args[MAX_PKG_ARGS_LEN];
+       gchar *req_id;
+       gchar *pkgid;
        int pid;
 
        backend_cmd = job->backend_path;
        if (backend_cmd == NULL)
                return -1;
 
+       req_id = g_shell_quote(job->req_id);
+       pkgid = g_shell_quote(job->pkgid);
+       if (!req_id || !pkgid)
+               return -1;
+
        snprintf(args, sizeof(args), "%s -k %s -i %s -u %d %s", backend_cmd,
-                       job->req_id, job->pkgid, (int)job->target_uid, job->args);
+                       req_id, pkgid, (int)job->target_uid, job->args);
 
        argv = __generate_argv(args);
 
        pid = __fork_and_exec_with_args(argv, APPFW_UID);
        g_strfreev(argv);
+       g_free(req_id);
+       g_free(pkgid);
 
        return pid;
 }
@@ -711,19 +699,28 @@ static int __process_mount_install(struct backend_job *job)
        char *backend_cmd;
        char **argv;
        char args[MAX_PKG_ARGS_LEN];
+       gchar *req_id;
+       gchar *pkgid;
        int pid;
 
        backend_cmd = job->backend_path;
        if (backend_cmd == NULL)
                return -1;
 
+       req_id = g_shell_quote(job->req_id);
+       pkgid = g_shell_quote(job->pkgid);
+       if (!req_id || !pkgid)
+               return -1;
+
        snprintf(args, sizeof(args), "%s -k %s -w %s -u %d %s", backend_cmd,
-                       job->req_id, job->pkgid, (int)job->target_uid, job->args);
+                       req_id, pkgid, (int)job->target_uid, job->args);
 
        argv = __generate_argv(args);
 
        pid = __fork_and_exec_with_args(argv, APPFW_UID);
        g_strfreev(argv);
+       g_free(req_id);
+       g_free(pkgid);
 
        return pid;
 }
@@ -733,19 +730,28 @@ static int __process_reinstall(struct backend_job *job)
        char *backend_cmd;
        char **argv;
        char args[MAX_PKG_ARGS_LEN];
+       gchar *req_id;
+       gchar *pkgid;
        int pid;
 
        backend_cmd = job->backend_path;
        if (backend_cmd == NULL)
                return -1;
 
+       req_id = g_shell_quote(job->req_id);
+       pkgid = g_shell_quote(job->pkgid);
+       if (!req_id || !pkgid)
+               return -1;
+
        snprintf(args, sizeof(args), "%s -k %s -r %s -u %d", backend_cmd,
-                       job->req_id, job->pkgid, (int)job->target_uid);
+                       req_id, pkgid, (int)job->target_uid);
        argv = __generate_argv(args);
 
        pid = __fork_and_exec_with_args(argv, APPFW_UID);
 
        g_strfreev(argv);
+       g_free(req_id);
+       g_free(pkgid);
 
        return pid;
 }
@@ -1007,7 +1013,7 @@ static int __process_enable_global_app_for_uid(struct backend_job *job)
        if (ret != PMINFO_R_OK || strlen(job->appid) == 0) {
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_START_KEY_STR,
-                               PKGMGR_INSTALLER_GLOBAL_APP_ENABLE_FOR_UID,
+                               PKGMGR_INSTALLER_APP_ENABLE_EVENT_STR,
                                job->req_type);
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_END_KEY_STR,
@@ -1018,7 +1024,7 @@ static int __process_enable_global_app_for_uid(struct backend_job *job)
 
        _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->appid,
                        PKGMGR_INSTALLER_START_KEY_STR,
-                       PKGMGR_INSTALLER_GLOBAL_APP_ENABLE_FOR_UID,
+                       PKGMGR_INSTALLER_APP_ENABLE_EVENT_STR,
                        job->req_type);
 
        ret = pkgmgr_parser_update_global_app_disable_for_uid_info_in_db(
@@ -1050,7 +1056,7 @@ static int __process_disable_global_app_for_uid(struct backend_job *job)
                _send_app_signal(job->target_uid, job->req_id,
                                job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_START_KEY_STR,
-                               PKGMGR_INSTALLER_GLOBAL_APP_DISABLE_FOR_UID,
+                               PKGMGR_INSTALLER_APP_DISABLE_EVENT_STR,
                                job->req_type);
                _send_app_signal(job->target_uid, job->req_id, job->pkgid, job->pkgid,
                                PKGMGR_INSTALLER_END_KEY_STR,
@@ -1062,7 +1068,7 @@ static int __process_disable_global_app_for_uid(struct backend_job *job)
        _send_app_signal(job->target_uid, job->req_id,
                        job->pkgid, job->appid,
                        PKGMGR_INSTALLER_START_KEY_STR,
-                       PKGMGR_INSTALLER_GLOBAL_APP_DISABLE_FOR_UID,
+                       PKGMGR_INSTALLER_APP_DISABLE_EVENT_STR,
                        job->req_type);
 
        ret = __kill_app(job->appid, job->target_uid);
@@ -1164,9 +1170,10 @@ static int __process_cleardata(struct backend_job *job)
        if ((int)job->target_uid < REGULAR_USER)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -d %s", backend_cmd, job->pkgid);
+       snprintf(args, sizeof(args), "%s -d -n %s -u %d",
+                       backend_cmd, job->pkgid, job->target_uid);
        argv = __generate_argv(args);
-       pid = __fork_and_exec_with_args(argv, job->target_uid);
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
 
        g_strfreev(argv);
        return pid;
@@ -1182,9 +1189,10 @@ static int __process_clearcache(struct backend_job *job)
        if ((int)job->target_uid < REGULAR_USER)
                return -1;
 
-       snprintf(args, sizeof(args), "%s -c %s", backend_cmd, job->pkgid);
+       snprintf(args, sizeof(args), "%s -c -n %s -u %d",
+                       backend_cmd, job->pkgid, job->target_uid);
        argv = __generate_argv(args);
-       pid = __fork_and_exec_with_args(argv, job->target_uid);
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
 
        g_strfreev(argv);
        return pid;
@@ -1447,6 +1455,29 @@ static int __process_set_app_label(struct backend_job *job)
        return ret;
 }
 
+static int __process_migrate_external_image(struct backend_job *job)
+{
+       char *backend_cmd;
+       char **argv;
+       char args[MAX_PKG_ARGS_LEN];
+       int pid;
+
+       backend_cmd = job->backend_path;
+       if (backend_cmd == NULL)
+               return -1;
+
+       snprintf(args, sizeof(args), "%s -k %s --migrate-extimg %s -u %d %s",
+                       backend_cmd, job->req_id, job->pkgid,
+                       (int)job->target_uid, job->args);
+
+       argv = __generate_argv(args);
+
+       pid = __fork_and_exec_with_args(argv, APPFW_UID);
+       g_strfreev(argv);
+
+       return pid;
+}
+
 static int __post_process(int ret, int x, struct backend_job *job)
 {
        if (ret < 0) {
@@ -1477,7 +1508,7 @@ gboolean queue_job(void *data)
 
        /* all backend messages queue are empty or busy */
        if (x == num_of_backends || job == NULL) {
-               DBG("no job left");
+               DBG("no job available");
                return FALSE;
        }
 
@@ -1493,7 +1524,7 @@ gboolean queue_job(void *data)
                        ret = -1;
                        _send_fail_signal(job);
                        _free_backend_job(job);
-                       return FALSE;
+                       return TRUE;
                }
        }
 #endif
@@ -1620,12 +1651,17 @@ gboolean queue_job(void *data)
                ret = __process_set_app_label(job);
                _free_backend_job(job);
                break;
+       case REQUEST_TYPE_MIGRATE_EXTERNAL_IMAGE:
+               __set_backend_busy(x);
+               ret = __process_migrate_external_image(job);
+               __post_process(ret, x, job);
+               break;
        default:
                ret = -1;
                break;
        }
 
-       return FALSE;
+       return TRUE;
 }
 
 int main(int argc, char *argv[])
@@ -1634,6 +1670,11 @@ int main(int argc, char *argv[])
 
        DBG("server start");
 
+       if (__register_signal_handler()) {
+               ERR("failed to register signal handler");
+               return -1;
+       }
+
        r = _init_backend_queue();
        if (r) {
                DBG("Queue Initialization Failed");
@@ -1652,11 +1693,6 @@ int main(int argc, char *argv[])
                return -1;
        }
 
-       if (__register_signal_handler()) {
-               ERR("failed to register signal handler");
-               return -1;
-       }
-
 #if !GLIB_CHECK_VERSION(2, 35, 0)
        g_type_init();
 #endif
@@ -1675,6 +1711,9 @@ int main(int argc, char *argv[])
        __fini_backend_info();
        _fini_backend_queue();
 
+       g_source_remove(swid);
+       g_io_channel_unref(sio);
+
        DBG("package manager server terminated.");
 
        return 0;