Use GMutex for portability
[platform/core/api/package-manager.git] / src / package_manager.c
index 5e9a954..dec09cd 100644 (file)
 
 #include <package-manager.h>
 #include <pkgmgr_installer.h>
+#include <pkgmgr_installer_error.h>
 #include <pkgmgr-info.h>
 #include <tzplatform_config.h>
 
 #include "package_manager.h"
 #include "package_manager_internal.h"
 
-static GHashTable *__cb_table = NULL;
-
 #define GLOBAL_USER tzplatform_getuid(TZ_SYS_GLOBALAPP_USER)
 typedef struct _request_event_info {
        int req_id;
@@ -40,6 +39,7 @@ typedef struct _request_event_info {
 struct package_manager_event_info {
        char *pkg_name;
        package_manager_event_type_e event_type;
+       package_manager_event_state_e event_state;
 };
 
 struct package_manager_s {
@@ -50,6 +50,7 @@ struct package_manager_s {
        GHashTable *event_info_table;
        package_manager_event_cb event_cb;
        void *user_data;
+       GMutex mutex;
 };
 
 struct package_manager_request_s {
@@ -117,7 +118,8 @@ static void __clean_all_event_info(request_event_info *head)
 }
 
 static int __insert_event_info(package_manager_h manager, const char *pkg_name,
-                       package_manager_event_type_e event_type)
+                       package_manager_event_type_e event_type,
+                       package_manager_event_state_e event_state)
 {
        struct package_manager_event_info *info;
 
@@ -126,6 +128,7 @@ static int __insert_event_info(package_manager_h manager, const char *pkg_name,
                return -1;
        info->pkg_name = strdup(pkg_name);
        info->event_type = event_type;
+       info->event_state = event_state;
        g_hash_table_insert(manager->event_info_table, info->pkg_name, info);
 
        return 0;
@@ -271,6 +274,10 @@ API int package_manager_request_set_event_cb(package_manager_request_h request,
 {
        int ret;
 
+       if (package_manager_client_validate_handle(request))
+               return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER,
+                               __FUNCTION__, NULL);
+
        ret = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (ret != PACKAGE_MANAGER_ERROR_NONE)
                return ret;
@@ -299,6 +306,8 @@ API int package_manager_request_set_type(package_manager_request_h request,
                     NULL);
        }
 
+       if (request->pkg_type)
+               free(request->pkg_type);
        request->pkg_type = strdup(pkg_type);
 
        return PACKAGE_MANAGER_ERROR_NONE;
@@ -364,6 +373,50 @@ static int package_manager_get_event_type(const char *key,
        return PACKAGE_MANAGER_ERROR_NONE;
 }
 
+static package_manager_error_e __convert_to_error(const char *val)
+{
+       int errcode = atoi(val);
+
+       switch (errcode) {
+       case PKGMGR_INSTALLER_ERRCODE_UNDEFINED_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_GLOBALSYMLINK_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_GRANT_PERMISSION_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_IMAGE_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_PARSE_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_RECOVERY_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_DELTA_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_APP_DIR_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_CONFIG_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_ICON_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_MANIFEST_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_OUT_OF_SPACE:
+       case PKGMGR_INSTALLER_ERRCODE_ERROR:
+               return PACKAGE_MANAGER_ERROR_SYSTEM_ERROR;
+       case PKGMGR_INSTALLER_ERRCODE_UNZIP_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_SECURITY_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_REGISTER_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_PRIVILEGE_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_SIGNATURE_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_SIGNATURE_INVALID:
+       case PKGMGR_INSTALLER_ERRCODE_CERT_ERROR:
+       case PKGMGR_INSTALLER_ERRCODE_AUTHOR_CERT_NOT_MATCH:
+       case PKGMGR_INSTALLER_ERRCODE_AUTHOR_CERT_NOT_FOUND:
+       case PKGMGR_INSTALLER_ERRCODE_ICON_NOT_FOUND:
+       case PKGMGR_INSTALLER_ERRCODE_MANIFEST_NOT_FOUND:
+               return PACKAGE_MANAGER_ERROR_IO_ERROR;
+       case PKGMGR_INSTALLER_ERRCODE_PACKAGE_NOT_FOUND:
+               return PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE;
+       case PKGMGR_INSTALLER_ERRCODE_OPERATION_NOT_ALLOWED:
+               return PACKAGE_MANAGER_ERROR_PERMISSION_DENIED;
+       case PKGMGR_INSTALLER_ERRCODE_INVALID_VALUE:
+               return PACKAGE_MANAGER_ERROR_INVALID_PARAMETER;
+       case PKGMGR_INSTALLER_ERRCODE_OK:
+               return PACKAGE_MANAGER_ERROR_NONE;
+       default:
+               return PACKAGE_MANAGER_ERROR_SYSTEM_ERROR;
+       }
+}
+
 static int __add_event_info(request_event_info **head, int req_id,
                            package_manager_event_type_e event_type,
                            package_manager_event_state_e event_state)
@@ -379,6 +432,7 @@ static int __add_event_info(request_event_info **head, int req_id,
        }
        evt_info->req_id = req_id;
        evt_info->event_type = event_type;
+       evt_info->event_state = event_state;
        evt_info->next = NULL;
 
        if (*head == NULL)
@@ -412,6 +466,7 @@ static int __find_event_info(request_event_info **head, int req_id,
        while (tmp) {
                if (tmp->req_id == req_id) {
                        *event_type = tmp->event_type;
+                       *event_state = tmp->event_state;
                        return 0;
                }
                tmp = tmp->next;
@@ -440,6 +495,7 @@ static int __update_event_info(request_event_info **head, int req_id,
                while (tmp) {
                        if (tmp->req_id == req_id) {
                                tmp->event_type = event_type;
+                               tmp->event_state = event_state;
                                return 0;
                        }
                        tmp = tmp->next;
@@ -491,24 +547,22 @@ static int request_event_handler(uid_t target_uid, int req_id, const char *pkg_t
                }
 
        } else if (strcasecmp(key, "error") == 0) {
-               if (strcasecmp(key, "0") != 0) {
-                       if (__find_event_info
-                           (&(request->head), req_id, &event_type,
-                            &event_state) == 0) {
-                               __update_event_info(&(request->head), req_id,
-                                                   event_type,
-                                                   PACKAGE_MANAGER_EVENT_STATE_FAILED);
-                       }
+               if (__find_event_info
+                   (&(request->head), req_id, &event_type,
+                    &event_state) == 0) {
+                       __update_event_info(&(request->head), req_id,
+                                           event_type,
+                                           PACKAGE_MANAGER_EVENT_STATE_FAILED);
+               }
 
-                       if (request->event_cb)
-                               request->event_cb(req_id, pkg_type,
-                                                 pkg_name, event_type,
-                                                 PACKAGE_MANAGER_EVENT_STATE_FAILED,
-                                                 0,
-                                                 PACKAGE_MANAGER_ERROR_NONE,
-                                                 request->user_data);
+               if (request->event_cb)
+                       request->event_cb(req_id, pkg_type,
+                                         pkg_name, event_type,
+                                         PACKAGE_MANAGER_EVENT_STATE_FAILED,
+                                         0,
+                                         __convert_to_error(val),
+                                         request->user_data);
 
-               }
        } else if (strcasecmp(key, "end") == 0) {
                if (__find_event_info
                    (&(request->head), req_id, &event_type,
@@ -529,7 +583,7 @@ static int request_event_handler(uid_t target_uid, int req_id, const char *pkg_t
                                                          pkg_name, event_type,
                                                          PACKAGE_MANAGER_EVENT_STATE_FAILED,
                                                          0,
-                                                         PACKAGE_MANAGER_ERROR_NONE,
+                                                         PACKAGE_MANAGER_ERROR_SYSTEM_ERROR,
                                                          request->user_data);
                }
        }
@@ -606,7 +660,7 @@ static int internal_request_callback(uid_t target_uid, int req_id, const char *p
                                pkg_name, event_type,
                                PACKAGE_MANAGER_EVENT_STATE_FAILED,
                                0,
-                               PACKAGE_MANAGER_ERROR_NONE,
+                               __convert_to_error(val),
                                user_data);
                }
        } else if (strcasecmp(key, "end") == 0) {
@@ -630,7 +684,7 @@ static int internal_request_callback(uid_t target_uid, int req_id, const char *p
                                                pkg_name, event_type,
                                                PACKAGE_MANAGER_EVENT_STATE_FAILED,
                                                0,
-                                               PACKAGE_MANAGER_ERROR_NONE,
+                                               PACKAGE_MANAGER_ERROR_SYSTEM_ERROR,
                                                user_data);
                                }
                        }
@@ -755,6 +809,44 @@ static int __request_move(package_manager_request_h request,
        return PACKAGE_MANAGER_ERROR_NONE;
 }
 
+static int __request_mount_install(package_manager_request_h request,
+               const char *path, pkgmgr_handler event_cb, int *id)
+{
+       int retval;
+       retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
+       if (retval != PACKAGE_MANAGER_ERROR_NONE)
+               return retval;
+
+       if (package_manager_client_validate_handle(request))
+               return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
+
+       if (path == NULL)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
+
+       int request_id = 0;
+       request_id = pkgmgr_client_mount_install(request->pc, request->pkg_type, NULL,
+                       path, NULL, request->mode, event_cb ? event_cb : request_event_handler, request);
+
+       if (request_id == PKGMGR_R_EINVAL)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
+       else if (request_id == PKGMGR_R_ENOPKG)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE, __FUNCTION__, NULL);
+       else if (request_id == PKGMGR_R_ENOMEM)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_OUT_OF_MEMORY, __FUNCTION__, NULL);
+       else if (request_id == PKGMGR_R_EIO)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_IO_ERROR, __FUNCTION__, NULL);
+       else if (request_id == PKGMGR_R_EPRIV)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_PERMISSION_DENIED, __FUNCTION__, NULL);
+       else if (request_id == PKGMGR_R_ESYSTEM || request_id == PKGMGR_R_ECOMM || request_id == PKGMGR_R_ERROR)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_SYSTEM_ERROR, __FUNCTION__, NULL);
+
+       if (id)
+               *id = request_id;
+
+       return PACKAGE_MANAGER_ERROR_NONE;
+}
+
+
 API int package_manager_request_install(package_manager_request_h request,
                                const char *path, int *id)
 {
@@ -845,6 +937,36 @@ API int package_manager_request_move_with_cb(package_manager_request_h request,
        return ret;
 }
 
+API int package_manager_request_mount_install(package_manager_request_h request,
+                               const char *path, int *id)
+{
+       return __request_mount_install(request, path, NULL, id);
+}
+
+API int package_manager_request_mount_install_with_cb(package_manager_request_h request,
+                       const char *path, package_manager_request_event_cb callback,
+                       void *user_data, int *id)
+{
+       int ret;
+       int req_id = 0;
+
+       if (request->request_cb_table == NULL)
+               __initialize_request_cb_table(request);
+
+       ret = __request_mount_install(request, path, internal_request_callback, &req_id);
+
+       if (req_id > 0) {
+               ret = __insert_request_cb_info(request, req_id, callback, user_data);
+               if (ret < 0)
+                       return package_manager_error(PACKAGE_MANAGER_ERROR_OUT_OF_MEMORY,
+                                       __FUNCTION__, "failed to create request cb info");
+               if (id)
+                       *id = req_id;
+       }
+
+       return ret;
+}
+
 API int package_manager_create(package_manager_h *manager)
 {
        int retval;
@@ -880,6 +1002,7 @@ API int package_manager_create(package_manager_h *manager)
        }
 
        package_manager->handle_id = package_manager_new_id();
+       g_mutex_init(&package_manager->mutex);
 
        *manager = package_manager;
 
@@ -903,6 +1026,7 @@ API int package_manager_destroy(package_manager_h manager)
                     NULL);
        }
 
+       g_mutex_clear(&manager->mutex);
        pkgmgr_client_free(manager->pc);
        g_hash_table_destroy(manager->event_info_table);
        free(manager);
@@ -941,7 +1065,6 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
 {
        int ret = -1;
        package_manager_event_type_e event_type = -1;
-       package_manager_event_state_e event_state = -1;
        struct package_manager_event_info *info = NULL;
        package_manager_h manager = data;
        uid_t uid = target_uid;
@@ -956,6 +1079,7 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
                return PACKAGE_MANAGER_ERROR_NONE;
 
        if (manager && manager->event_info_table) {
+               g_mutex_lock(&manager->mutex);
                info = g_hash_table_lookup(manager->event_info_table, pkg_name);
        } else {
                _LOGE("invalid handle");
@@ -965,17 +1089,21 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
        if (!info) {
                if (strcasecmp(key, "start") != 0) {
                        _LOGD("unexpected signal or no info(removed)");
+                       g_mutex_unlock(&manager->mutex);
                        return PACKAGE_MANAGER_ERROR_NONE;
                }
        }
 
        if (strcasecmp(key, "start") == 0) {
                ret = package_manager_get_event_type(val, &event_type);
-               if (ret != PACKAGE_MANAGER_ERROR_NONE)
+               if (ret != PACKAGE_MANAGER_ERROR_NONE) {
+                       g_mutex_unlock(&manager->mutex);
                        return PACKAGE_MANAGER_ERROR_INVALID_PARAMETER;
+               }
 
                if (!info) {
-                       __insert_event_info(manager, pkg_name, event_type);
+                       __insert_event_info(manager, pkg_name, event_type,
+                                       PACKAGE_MANAGER_EVENT_STATE_STARTED);
 
                        if (manager->event_cb && getuid() == uid)
                                manager->event_cb(pkg_type, pkg_name,
@@ -989,23 +1117,25 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
                }
        } else if (strcasecmp(key, "install_percent") == 0
                   || strcasecmp(key, "progress_percent") == 0) {
+               info->event_state = PACKAGE_MANAGER_EVENT_STATE_PROCESSING;
                if (manager->event_cb && getuid() == uid)
                        manager->event_cb(pkg_type, pkg_name,
                                        info->event_type,
-                                       PACKAGE_MANAGER_EVENT_STATE_PROCESSING,
+                                       info->event_state,
                                        atoi(val),
                                        PACKAGE_MANAGER_ERROR_NONE,
                                        manager->user_data);
        } else if (strcasecmp(key, "error") == 0) {
+               info->event_state = PACKAGE_MANAGER_EVENT_STATE_FAILED;
                if (manager->event_cb && getuid() == uid)
                        manager->event_cb(pkg_type, pkg_name,
                                        info->event_type,
-                                       PACKAGE_MANAGER_EVENT_STATE_FAILED,
+                                       info->event_state,
                                        0,
-                                       PACKAGE_MANAGER_ERROR_NONE,
+                                       __convert_to_error(val),
                                        manager->user_data);
        } else if (strcasecmp(key, "end") == 0) {
-               if (event_state != PACKAGE_MANAGER_EVENT_STATE_FAILED) {
+               if (info->event_state != PACKAGE_MANAGER_EVENT_STATE_FAILED) {
                        if (manager->event_cb && getuid() == uid) {
                                if (strcasecmp(val, "ok") == 0) {
                                        manager->event_cb(pkg_type, pkg_name,
@@ -1019,7 +1149,7 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
                                                info->event_type,
                                                PACKAGE_MANAGER_EVENT_STATE_FAILED,
                                                0,
-                                               PACKAGE_MANAGER_ERROR_NONE,
+                                               PACKAGE_MANAGER_ERROR_SYSTEM_ERROR,
                                                manager->user_data);
                                }
                        }
@@ -1027,6 +1157,8 @@ static int internal_callback(uid_t target_uid, int req_id, const char *pkg_type,
                g_hash_table_remove(manager->event_info_table, info->pkg_name);
        }
 
+       g_mutex_unlock(&manager->mutex);
+
        return PACKAGE_MANAGER_ERROR_NONE;
 }
 
@@ -1086,7 +1218,6 @@ API int package_manager_set_event_cb(package_manager_h manager,
                                 package_manager_event_cb callback,
                                 void *user_data)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1131,7 +1262,9 @@ API int package_manager_unset_event_cb(package_manager_h manager)
        manager->event_cb = NULL;
        manager->user_data = NULL;
 
+       g_mutex_lock(&manager->mutex);
        g_hash_table_remove_all(manager->event_info_table);
+       g_mutex_unlock(&manager->mutex);
 
        retval = pkgmgr_client_remove_listen_status(manager->pc);
        if (retval == PKGMGR_R_EINVAL)
@@ -1165,8 +1298,10 @@ API int package_manager_get_package_id_by_app_id(const char *app_id, char **pack
        if (pkgmgrinfo_appinfo_get_appinfo(app_id, &pkgmgrinfo_appinfo) != PMINFO_R_OK)
                return package_manager_error(PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE, __FUNCTION__, NULL);
        retval = pkgmgrinfo_appinfo_get_pkgname(pkgmgrinfo_appinfo, &pkg_id);
-       if (retval != PMINFO_R_OK)
+       if (retval != PMINFO_R_OK) {
+               pkgmgrinfo_appinfo_destroy_appinfo(pkgmgrinfo_appinfo);
                return package_manager_error(PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE, __FUNCTION__, NULL);
+       }
 
        pkg_id_dup = strdup(pkg_id);
        if (pkg_id_dup == NULL) {
@@ -1199,7 +1334,6 @@ API int package_manager_get_package_info(const char *package_id, package_info_h
 API int package_manager_foreach_package_info(package_manager_package_info_cb callback,
                                        void *user_data)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1242,7 +1376,6 @@ API int package_manager_compare_app_cert_info(const char *lhs_app_id, const char
 
 API int package_manager_is_preload_package_by_app_id(const char *app_id, bool *preload)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1285,7 +1418,6 @@ API int package_manager_is_preload_package_by_app_id(const char *app_id, bool *p
 
 API int package_manager_get_permission_type(const char *app_id, package_manager_permission_type_e *permission_type)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1296,8 +1428,10 @@ API int package_manager_get_permission_type(const char *app_id, package_manager_
        if (pkgmgrinfo_appinfo_get_appinfo(app_id, &pkgmgrinfo_appinfo) != PMINFO_R_OK)
                return package_manager_error(PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE, __FUNCTION__, NULL);
        retval = pkgmgrinfo_appinfo_get_permission_type(pkgmgrinfo_appinfo, &permission);
-       if (retval != PMINFO_R_OK)
+       if (retval != PMINFO_R_OK) {
+               pkgmgrinfo_appinfo_destroy_appinfo(pkgmgrinfo_appinfo);
                return package_manager_error(PACKAGE_MANAGER_ERROR_NO_SUCH_PACKAGE, __FUNCTION__, NULL);
+       }
 
        if (permission == PMINFO_PERMISSION_NORMAL)
                *permission_type = PACKAGE_MANAGER_PERMISSION_NORMAL;
@@ -1314,7 +1448,6 @@ API int package_manager_get_permission_type(const char *app_id, package_manager_
 
 API int package_manager_clear_cache_dir(const char *package_id)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_CACHE);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1400,7 +1533,6 @@ API int package_manager_clear_data_dir(const char *package_id)
 
 API int package_manager_clear_all_cache_dir(void)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1409,23 +1541,25 @@ API int package_manager_clear_all_cache_dir(void)
        return package_manager_clear_cache_dir(PKG_CLEAR_ALL_CACHE);
 }
 
-static void __free_client(gpointer data)
-{
-       pkgmgr_client *pc = (pkgmgr_client *)data;
-       pkgmgr_client_free(pc);
-}
+struct getsize_cbdata {
+       pkgmgr_client *pc;
+       void *cb;
+       void *user_data;
+};
 
-static void __initialize_cb_table(void)
+static void __free_getsize_cbdata(struct getsize_cbdata *cbdata)
 {
-       __cb_table = g_hash_table_new_full(g_direct_hash, g_direct_equal, __free_client, NULL);
+       pkgmgr_client_free(cbdata->pc);
+       free(cbdata);
 }
 
 static void __result_cb(pkgmgr_client *pc, const char *pkgid, const pkg_size_info_t *result, void *user_data)
 {
-       package_manager_size_info_receive_cb callback = g_hash_table_lookup(__cb_table, pc);
+       struct getsize_cbdata *cbdata = (struct getsize_cbdata *)user_data;
+       package_manager_size_info_receive_cb callback = cbdata->cb;
        if (callback == NULL) {
                _LOGE("callback is null.");
-               g_hash_table_remove(__cb_table, pc);
+               __free_getsize_cbdata(cbdata);
                return;
        }
 
@@ -1439,15 +1573,16 @@ static void __result_cb(pkgmgr_client *pc, const char *pkgid, const pkg_size_inf
 
        callback(pkgid, (package_size_info_h)&size_info, user_data);
 
-       g_hash_table_remove(__cb_table, pc);
+       __free_getsize_cbdata(cbdata);
 }
 
 static void __total_result_cb(pkgmgr_client *pc, const pkg_size_info_t *result, void *user_data)
 {
-       package_manager_total_size_info_receive_cb callback = g_hash_table_lookup(__cb_table, pc);
+       struct getsize_cbdata *cbdata = (struct getsize_cbdata *)user_data;
+       package_manager_total_size_info_receive_cb callback = cbdata->cb;
        if (callback == NULL) {
                _LOGE("callback is null.");
-               g_hash_table_remove(__cb_table, pc);
+               __free_getsize_cbdata(cbdata);
                return;
        }
 
@@ -1461,26 +1596,35 @@ static void __total_result_cb(pkgmgr_client *pc, const pkg_size_info_t *result,
 
        callback((package_size_info_h)&size_info, user_data);
 
-       g_hash_table_remove(__cb_table, pc);
+       __free_getsize_cbdata(cbdata);
 }
 
 static int _get_pkg_size_info(const char *package_id, void *callback, void *user_data)
 {
+       struct getsize_cbdata *cbdata;
+
        if (package_id == NULL || callback == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
 
-       if (__cb_table == NULL)
-               __initialize_cb_table();
+       cbdata = malloc(sizeof(struct getsize_cbdata));
+       if (cbdata == NULL)
+               return package_manager_error(PACKAGE_MANAGER_ERROR_OUT_OF_MEMORY, __FUNCTION__, NULL);
 
        pkgmgr_client *pc = pkgmgr_client_new(PC_REQUEST);
-       if (pc == NULL)
+       if (pc == NULL) {
+               free(cbdata);
                return package_manager_error(PACKAGE_MANAGER_ERROR_SYSTEM_ERROR, __FUNCTION__, NULL);
+       }
+
+       cbdata->pc = pc;
+       cbdata->cb = callback;
+       cbdata->user_data = user_data;
 
        int res = 0;
        if (strcmp(package_id, PKG_SIZE_INFO_TOTAL) != 0)
-               res = pkgmgr_client_get_package_size_info(pc, package_id, __result_cb, user_data);
+               res = pkgmgr_client_get_package_size_info(pc, package_id, __result_cb, cbdata);
        else
-               res = pkgmgr_client_get_total_package_size_info(pc, __total_result_cb, user_data);
+               res = pkgmgr_client_get_total_package_size_info(pc, __total_result_cb, cbdata);
 
        if (res == PKGMGR_R_EINVAL) {
                pkgmgr_client_free(pc);
@@ -1502,12 +1646,10 @@ static int _get_pkg_size_info(const char *package_id, void *callback, void *user
                return package_manager_error(PACKAGE_MANAGER_ERROR_SYSTEM_ERROR, __FUNCTION__, NULL);
        } else if (res != PKGMGR_R_OK) {
                _LOGE("Unexpected error");
-               pkgmgr_client_free(pc);
+               __free_getsize_cbdata(cbdata);
                return package_manager_error(PACKAGE_MANAGER_ERROR_SYSTEM_ERROR, __FUNCTION__, NULL);
        }
 
-       g_hash_table_insert(__cb_table, pc, callback);
-
        return PACKAGE_MANAGER_ERROR_NONE;
 }
 
@@ -1585,7 +1727,6 @@ API int package_manager_filter_add_bool(package_manager_filter_h handle,
 
 API int package_manager_filter_count(package_manager_filter_h handle, int *count)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1604,7 +1745,6 @@ API int package_manager_filter_count(package_manager_filter_h handle, int *count
 API int package_manager_filter_foreach_package_info(package_manager_filter_h handle,
                package_manager_package_info_cb callback, void *user_data)
 {
-
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
@@ -1684,7 +1824,7 @@ API int package_manager_updateinfo_set_pkgid(package_updateinfo_request_h pkg_up
 {
        struct package_updateinfo_request_s *request;
 
-       if (pkg_updateinfo_req == NULL || pkg_updateinfo_req->updateinfo_handle == NULL)
+       if (pkg_updateinfo_req == NULL || pkg_updateinfo_req->updateinfo_handle == NULL || pkgid == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
 
        request = (struct package_updateinfo_request_s *)pkg_updateinfo_req;
@@ -1701,14 +1841,14 @@ API int package_manager_updateinfo_set_version(package_updateinfo_request_h pkg_
 {
        struct package_updateinfo_request_s *request;
 
-       if (pkg_updateinfo_req == NULL || pkg_updateinfo_req->updateinfo_handle == NULL)
+       if (pkg_updateinfo_req == NULL || pkg_updateinfo_req->updateinfo_handle == NULL || version == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
 
        request = (struct package_updateinfo_request_s *)pkg_updateinfo_req;
        if (request->updateinfo_handle->version)
                free(request->updateinfo_handle->version);
        request->updateinfo_handle->version = strdup(version);
-       if (request->updateinfo_handle->pkgid == NULL)
+       if (request->updateinfo_handle->version == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_OUT_OF_MEMORY, __FUNCTION__, NULL);
 
        return PACKAGE_MANAGER_ERROR_NONE;