[0.6.231] Fix typo error
[platform/core/multimedia/libmm-player.git] / src / mm_player_capture.c
index 64fae89..0297b6e 100644 (file)
@@ -30,6 +30,7 @@
 #include "mm_player_capture.h"
 #include "mm_player_priv.h"
 
+#include <mm_util_image.h>
 #include <mm_util_imgp.h>
 #include <gst/video/video-info.h>
 
 |    LOCAL FUNCTION PROTOTYPES:                                                                                                |
 ---------------------------------------------------------------------------*/
 static GstPadProbeReturn __mmplayer_video_capture_probe(GstPad *pad, GstPadProbeInfo *info, gpointer u_data);
-static int  __mmplayer_get_video_frame_from_buffer(mm_player_t *player, GstPad *pad, GstBuffer *buffer);
+static int  __mmplayer_get_video_frame_from_buffer(mmplayer_t *player, GstPad *pad, GstBuffer *buffer);
 static gpointer __mmplayer_capture_thread(gpointer data);
-static void __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src, int yuv420_width, int yuv420_height, int left, int top, int right, int buttom);
+static void __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src, int yuv420_width, int yuv420_height, int left, int top, int right, int bottom);
 static int __tile_4x2_read(int x_size, int y_size, int x_pos, int y_pos);
-static int __mm_player_convert_colorspace(mm_player_t *player, unsigned char *src_data, mm_util_color_format_e src_fmt, unsigned int src_w, unsigned int src_h, mm_util_color_format_e dst_fmt);
-static int __mm_player_convert_NV12_tiled(mm_player_t *player);
-static int __mm_player_convert_NV12(mm_player_t *player);
-static int __mm_player_convert_I420(mm_player_t *player);
-static int __mm_player_convert_BGRx(mm_player_t *player);
+static int __mm_player_convert_colorspace(mmplayer_t *player, unsigned char *src_data, size_t src_size, mm_util_color_format_e src_fmt, unsigned int src_w, unsigned int src_h, mm_util_color_format_e dst_fmt);
+static int __mm_player_convert_NV12_tiled(mmplayer_t *player);
+static int __mm_player_convert_NV12(mmplayer_t *player);
+static int __mm_player_convert_I420(mmplayer_t *player);
+static int __mm_player_convert_BGRx(mmplayer_t *player);
 #ifdef CAPTURE_OUTPUT_DUMP
-static void capture_output_dump(mm_player_t *player);
+static void capture_output_dump(mmplayer_t *player);
 #endif
 
 /*===========================================================================================
@@ -61,7 +62,7 @@ static void capture_output_dump(mm_player_t *player);
 |                                                                                                                                                                                      |
 ========================================================================================== */
 int
-_mmplayer_initialize_video_capture(mm_player_t *player)
+_mmplayer_initialize_video_capture(mmplayer_t *player)
 {
        int ret = MM_ERROR_NONE;
        MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED);
@@ -92,7 +93,7 @@ ERROR:
 }
 
 int
-_mmplayer_release_video_capture(mm_player_t *player)
+_mmplayer_release_video_capture(mmplayer_t *player)
 {
        MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED);
        /* release capture thread */
@@ -101,7 +102,7 @@ _mmplayer_release_video_capture(mm_player_t *player)
        MMPLAYER_CAPTURE_THREAD_SIGNAL(player);
        MMPLAYER_CAPTURE_THREAD_UNLOCK(player);
 
-       LOGD("waitting for capture thread exit");
+       LOGD("waiting for capture thread exit");
        g_thread_join(player->capture_thread);
        g_mutex_clear(&player->capture_thread_mutex);
        g_cond_clear(&player->capture_thread_cond);
@@ -113,7 +114,7 @@ _mmplayer_release_video_capture(mm_player_t *player)
 int
 _mmplayer_do_video_capture(MMHandleType hplayer)
 {
-       mm_player_t *player = (mm_player_t *)hplayer;
+       mmplayer_t *player = (mmplayer_t *)hplayer;
        int ret = MM_ERROR_NONE;
        GstPad *pad = NULL;
 
@@ -138,38 +139,32 @@ _mmplayer_do_video_capture(MMHandleType hplayer)
 
        pad = gst_element_get_static_pad(player->pipeline->videobin[MMPLAYER_V_SINK].gst, "sink");
 
-       if (player->state != MM_PLAYER_STATE_PLAYING) {
-               if (player->state == MM_PLAYER_STATE_PAUSED) {
-                       // get last buffer from video sink
-                       GstSample *sample = NULL;
-
-                       gst_element_get_state(player->pipeline->mainbin[MMPLAYER_M_PIPE].gst, NULL, NULL, 5 * GST_SECOND); //5 seconds
-                       g_object_get(player->pipeline->videobin[MMPLAYER_V_SINK].gst, "last-sample", &sample, NULL);
-
-                       if (sample) {
-                               GstBuffer *buf = NULL;
-                               buf = gst_sample_get_buffer(sample);
-                               if (buf) {
-                                       if (__mmplayer_get_video_frame_from_buffer(player, pad, buf) != MM_ERROR_NONE)
-                                               ret = MM_ERROR_PLAYER_INTERNAL;
-                               } else {
-                                       LOGW("failed to get video frame");
-                               }
-                               gst_sample_unref(sample);
+       if (player->state == MM_PLAYER_STATE_PLAYING) {
+               /* register probe */
+               player->video_capture_cb_probe_id = gst_pad_add_probe(pad, GST_PAD_PROBE_TYPE_BUFFER,
+                       __mmplayer_video_capture_probe, player, NULL);
+       } else if (player->state == MM_PLAYER_STATE_PAUSED) {
+               // get last buffer from video sink
+               GstSample *sample = NULL;
+
+               gst_element_get_state(player->pipeline->mainbin[MMPLAYER_M_PIPE].gst, NULL, NULL, 5 * GST_SECOND);
+               g_object_get(player->pipeline->videobin[MMPLAYER_V_SINK].gst, "last-sample", &sample, NULL);
+
+               if (sample) {
+                       GstBuffer *buf = gst_sample_get_buffer(sample);
+                       if (buf) {
+                               if (__mmplayer_get_video_frame_from_buffer(player, pad, buf) != MM_ERROR_NONE)
+                                       ret = MM_ERROR_PLAYER_INTERNAL;
+                       } else {
+                               LOGW("failed to get video frame");
                        }
-                       return ret;
-               } else {
-                       LOGW("invalid state(%d) to capture", player->state);
-                       gst_object_unref(GST_OBJECT(pad));
-                       pad = NULL;
-                       return MM_ERROR_PLAYER_INVALID_STATE;
+                       gst_sample_unref(sample);
                }
+       } else {
+               LOGW("invalid state(%d) to capture", player->state);
+               ret = MM_ERROR_PLAYER_INVALID_STATE;
        }
 
-       /* register probe */
-       player->video_capture_cb_probe_id = gst_pad_add_probe(pad, GST_PAD_PROBE_TYPE_BUFFER,
-               __mmplayer_video_capture_probe, player, NULL);
-
        gst_object_unref(GST_OBJECT(pad));
        pad = NULL;
 
@@ -179,36 +174,24 @@ _mmplayer_do_video_capture(MMHandleType hplayer)
 }
 
 int
-__mmplayer_handle_orientation(mm_player_t *player, int orientation, int format)
+__mmplayer_handle_orientation(mmplayer_t *player, int orientation, int format)
 {
        unsigned char *src_buffer = NULL;
        int ret = MM_ERROR_NONE;
-       unsigned char *dst_frame = NULL;
-       unsigned int dst_width = 0;
-       unsigned int dst_height = 0;
+       mm_util_image_h src_image = NULL;
+       mm_util_image_h dst_image = NULL;
        size_t dst_size = 0;
-       mm_util_img_rotate_type rot_enum = MM_UTIL_ROTATE_NUM;
+       mm_util_rotate_type_e rot_enum = MM_UTIL_ROTATE_NUM;
 
        player->capture.orientation = orientation;
 
-       if (orientation == 90 || orientation == 270) {
-               dst_width = player->captured.height[0];
-               dst_height = player->captured.width[0];
-               LOGD("interchange width & height");
-       } else if (orientation == 180) {
-               dst_width = player->captured.width[0];
-               dst_height = player->captured.height[0];
-       } else if (orientation == 0) {
+       if (orientation == 0) {
                LOGE("no need handle orientation : %d", orientation);
                player->capture.width = player->captured.width[0];
                player->capture.height = player->captured.height[0];
                return MM_ERROR_NONE;
-       } else {
-               LOGE("wrong orientation value...");
        }
 
-       /* height & width will be interchanged for 90 and 270 orientation */
-       LOGD("before rotation : dst_width = %d and dst_height = %d", dst_width, dst_height);
        src_buffer = (unsigned char *)player->capture.data;
 
        /* convert orientation degree into enum here */
@@ -229,27 +212,35 @@ __mmplayer_handle_orientation(mm_player_t *player, int orientation, int format)
 
        LOGD("source buffer for rotation = %p and rotation = %d", src_buffer, rot_enum);
 
-       ret = mm_util_rotate_image(src_buffer,
-                       player->captured.width[0], player->captured.height[0], format, rot_enum,
-                       &dst_frame, &dst_width, &dst_height, &dst_size);
-       if (ret != MM_ERROR_NONE || !dst_frame) {
-               LOGE("failed to do rotate image");
-               free(dst_frame);
+       ret = mm_image_create_image(player->captured.width[0], player->captured.height[0], format, src_buffer, (size_t)player->capture.size, &src_image);
+       if (ret != MM_ERROR_NONE) {
+               LOGE("failed to create image");
                return ret;
        }
 
-       LOGD("after rotation same stride: dst_width = %d and dst_height = %d, dst_size = %zu", dst_width, dst_height, dst_size);
+       ret = mm_util_rotate_image(src_image, rot_enum, &dst_image);
+       mm_image_destroy_image(src_image);
+       if (ret != MM_ERROR_NONE) {
+               LOGE("failed to rotate image");
+               return ret;
+       }
+
+       mm_image_debug_image(dst_image, NULL);
+
+       ret = mm_image_get_image(dst_image, &player->capture.width, &player->capture.height, NULL, &player->capture.data, &dst_size);
+       mm_image_destroy_image(dst_image);
+       if (ret != MM_ERROR_NONE) {
+               LOGE("failed to get image");
+               return ret;
+       }
 
        free(src_buffer);
 
-       player->capture.data = dst_frame;
        player->capture.size = (int)dst_size;
        player->capture.orientation = orientation;
-       player->capture.width = dst_width;
-       player->capture.height = dst_height;
 
-       player->captured.width[0] = player->captured.stride_width[0] = dst_width;
-       player->captured.height[0] = player->captured.stride_height[0] = dst_height;
+       player->captured.width[0] = player->captured.stride_width[0] = player->capture.width;
+       player->captured.height[0] = player->captured.stride_height[0] = player->capture.height;
 
        return ret;
 }
@@ -257,7 +248,7 @@ __mmplayer_handle_orientation(mm_player_t *player, int orientation, int format)
 static gpointer
 __mmplayer_capture_thread(gpointer data)
 {
-       mm_player_t *player = (mm_player_t *)data;
+       mmplayer_t *player = (mmplayer_t *)data;
        MMMessageParamType msg = {0, };
        int orientation = 0;
        int display_angle = 0;
@@ -315,7 +306,7 @@ __mmplayer_capture_thread(gpointer data)
                        goto ERROR;
                }
 
-               ret = __mmplayer_get_video_angle((MMHandleType)player, &display_angle, &orientation);
+               ret = _mmplayer_get_video_angle((MMHandleType)player, &display_angle, &orientation);
                if (ret != MM_ERROR_NONE) {
                        LOGE("failed to get rotation angle");
                        goto ERROR;
@@ -357,7 +348,7 @@ EXIT:
   * The output is fixed as RGB888
   */
 static int
-__mmplayer_get_video_frame_from_buffer(mm_player_t *player, GstPad *pad, GstBuffer *buffer)
+__mmplayer_get_video_frame_from_buffer(mmplayer_t *player, GstPad *pad, GstBuffer *buffer)
 {
        gint i = 0;
        guint plane_size = 0;
@@ -379,7 +370,7 @@ __mmplayer_get_video_frame_from_buffer(mm_player_t *player, GstPad *pad, GstBuff
        MMPLAYER_LOG_GST_CAPS_TYPE(caps);
 
        /* init capture image buffer */
-       memset(&player->capture, 0x00, sizeof(MMPlayerVideoCapture));
+       memset(&player->capture, 0x00, sizeof(mmplayer_video_capture_t));
 
        gst_video_info_from_caps(&vinfo, caps);
 
@@ -429,6 +420,7 @@ __mmplayer_get_video_frame_from_buffer(mm_player_t *player, GstPad *pad, GstBuff
                        plane_size = player->captured.stride_width[i] * player->captured.stride_height[i];
                        if (!plane_size) {
                                LOGE("invalid plane size");
+                               gst_video_frame_unmap(&vframe);
                                return MM_ERROR_PLAYER_INTERNAL;
                        }
                        pixels = GST_VIDEO_FRAME_PLANE_DATA(&vframe, i);
@@ -447,7 +439,7 @@ __mmplayer_get_video_frame_from_buffer(mm_player_t *player, GstPad *pad, GstBuff
 static GstPadProbeReturn
 __mmplayer_video_capture_probe(GstPad *pad, GstPadProbeInfo *info, gpointer u_data)
 {
-       mm_player_t *player = (mm_player_t *)u_data;
+       mmplayer_t *player = (mmplayer_t *)u_data;
        GstBuffer *buffer = NULL;
        int ret = MM_ERROR_NONE;
 
@@ -473,27 +465,38 @@ __mmplayer_video_capture_probe(GstPad *pad, GstPadProbeInfo *info, gpointer u_da
 }
 
 static int
-__mm_player_convert_colorspace(mm_player_t *player, unsigned char *src_data, mm_util_color_format_e src_fmt, unsigned int src_w, unsigned int src_h, mm_util_color_format_e dst_fmt)
+__mm_player_convert_colorspace(mmplayer_t *player, unsigned char *src_data, size_t src_size, mm_util_color_format_e src_fmt, unsigned int src_w, unsigned int src_h, mm_util_color_format_e dst_fmt)
 {
-       unsigned char *dst_data = NULL;
-       unsigned int dst_width = 0;
-       unsigned int dst_height = 0;
-       size_t dst_size = 0;
        int ret = MM_ERROR_NONE;
+       mm_util_image_h src_image = NULL;
+       mm_util_image_h dst_image = NULL;
+       size_t size = 0;
 
        MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_INTERNAL);
        SECURE_LOGD("src size info. width: %d, height: %d", src_w, src_h);
 
-       ret = mm_util_convert_colorspace(src_data, src_w, src_h, src_fmt, dst_fmt, &dst_data, &dst_width, &dst_height, &dst_size);
-       if (ret != MM_ERROR_NONE || !dst_data) {
+       ret = mm_image_create_image(src_w, src_h, src_fmt, src_data, src_size, &src_image);
+       if (ret != MM_ERROR_NONE) {
+               LOGE("failed to create image for capture, %d", ret);
+               return MM_ERROR_PLAYER_INTERNAL;
+       }
+
+       ret = mm_util_convert_colorspace(src_image, dst_fmt, &dst_image);
+       mm_image_destroy_image(src_image);
+       if (ret != MM_ERROR_NONE) {
                LOGE("failed to convert for capture, %d", ret);
-               free(dst_data);
                return MM_ERROR_PLAYER_INTERNAL;
        }
-       SECURE_LOGD("dst size info. width: %d, height: %d, size: %zu", dst_width, dst_height, dst_size);
+       mm_image_debug_image(dst_image, NULL);
 
-       player->capture.size = (int)dst_size;
-       player->capture.data = dst_data;
+       ret = mm_image_get_image(dst_image, NULL, NULL, NULL, &player->capture.data, &size);
+       mm_image_destroy_image(dst_image);
+       if (ret != MM_ERROR_NONE) {
+               LOGE("failed to get image for capture, %d", ret);
+               return MM_ERROR_PLAYER_INTERNAL;
+       }
+
+       player->capture.size = (int)size;
 
        return MM_ERROR_NONE;
 }
@@ -508,10 +511,10 @@ __mm_player_convert_colorspace(mm_player_t *player, unsigned char *src_data, mm_
  *   height of tiled[in]
  *
  * @param x_pos
- *   x position of tield[in]
+ *   x position of tiled[in]
  *
  * @param src_size
- *   y position of tield[in]
+ *   y position of tiled[in]
  *
  * @return
  *   address of tiled data
@@ -559,7 +562,7 @@ __tile_4x2_read(int x_size, int y_size, int x_pos, int y_pos)
 
 /*
  * Converts tiled data to linear
- * Crops left, top, right, buttom
+ * Crops left, top, right, bottom
  * 1. Y of NV12T to Y of YUV420P
  * 2. Y of NV12T to Y of YUV420S
  * 3. UV of NV12T to UV of YUV420S
@@ -585,12 +588,12 @@ __tile_4x2_read(int x_size, int y_size, int x_pos, int y_pos)
  * @param right
  *   Crop size of right
  *
- * @param buttom
- *   Crop size of buttom
+ * @param bottom
+ *   Crop size of bottom
  */
 static void
 __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src, int yuv420_width, int yuv420_height,
-                                                       int left, int top, int right, int buttom)
+                                                       int left, int top, int right, int bottom)
 {
        int i, j;
        int tiled_offset = 0, tiled_offset1 = 0;
@@ -601,13 +604,13 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
        temp1 = temp3-left;
        /* real width is greater than or equal 256 */
        if (temp1 >= 256) {
-               for (i = top; i < yuv420_height-buttom; i = i+1) {
+               for (i = top; i < yuv420_height-bottom; i = i+1) {
                        j = left;
                        temp3 = (j >> 8) << 8;
                        temp3 = temp3 >> 6;
                        temp4 = i >> 5;
                        if (temp4 & 0x1) {
-                               /* odd fomula: 2 + x + (x >> 2) << 2 + x_block_num * (y - 1) */
+                               /* odd formula: 2 + x + (x >> 2) << 2 + x_block_num * (y - 1) */
                                tiled_offset = temp4 - 1;
                                temp1 = ((yuv420_width + 127) >> 7) << 7;
                                tiled_offset = tiled_offset * (temp1 >> 6);
@@ -621,7 +624,7 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
                        } else {
                                temp2 = ((yuv420_height+31) >> 5) << 5;
                                if ((i + 32) < temp2) {
-                                       /* even1 fomula: x + ((x + 2) >> 2) << 2 + x_block_num * y */
+                                       /* even1 formula: x + ((x + 2) >> 2) << 2 + x_block_num * y */
                                        temp1 = temp3 + 2;
                                        temp1 = (temp1 >> 2) << 2;
                                        tiled_offset = temp3 + temp1;
@@ -631,7 +634,7 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
                                        tiled_offset1 = tiled_offset + 2048 * 6;
                                        temp4 = 8;
                                } else {
-                                       /* even2 fomula: x + x_block_num * y */
+                                       /* even2 formula: x + x_block_num * y */
                                        temp1 = ((yuv420_width + 127) >> 7) << 7;
                                        tiled_offset = temp4 * (temp1 >> 6);
                                        tiled_offset = tiled_offset + temp3;
@@ -702,7 +705,7 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
                        }
                }
        } else if (temp1 >= 64) {
-               for (i = top; i < (yuv420_height - buttom); i++) {
+               for (i = top; i < (yuv420_height - bottom); i++) {
                        j = left;
                        tiled_offset = __tile_4x2_read(yuv420_width, yuv420_height, j, i);
                        temp2 = ((j + 64) >> 6) << 6;
@@ -732,7 +735,7 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
                        }
                }
        } else {
-               for (i = top; i < (yuv420_height - buttom); i++) {
+               for (i = top; i < (yuv420_height - bottom); i++) {
                        linear_offset = temp1 * (i - top);
                        for (j = left; j < (yuv420_width - right); j += 2) {
                                tiled_offset = __tile_4x2_read(yuv420_width, yuv420_height, j, i);
@@ -747,7 +750,7 @@ __csc_tiled_to_linear_crop(unsigned char *yuv420_dest, unsigned char *nv12t_src,
 
 #ifdef CAPTURE_OUTPUT_DUMP /* for capture output dump */
 static void
-capture_output_dump(mm_player_t *player)
+capture_output_dump(mmplayer_t *player)
 {
        unsigned char *temp = NULL;
        char file[100] = { 0, };
@@ -780,7 +783,7 @@ capture_output_dump(mm_player_t *player)
 #endif
 
 static int
-__mm_player_convert_NV12_tiled(mm_player_t *player)
+__mm_player_convert_NV12_tiled(mmplayer_t *player)
 {
        /* Colorspace conversion : NV12T-> NV12-> RGB888 */
        int i;
@@ -815,8 +818,8 @@ __mm_player_convert_NV12_tiled(mm_player_t *player)
        memcpy(src_buffer + linear_y_plane_size, linear_uv_plane, linear_uv_plane_size);
 
        /* NV12 linear to RGB888 */
-       ret = __mm_player_convert_colorspace(player, src_buffer, MM_UTIL_COLOR_NV12,
-               width, height, MM_UTIL_COLOR_RGB24);
+       ret = __mm_player_convert_colorspace(player, src_buffer, (size_t)(linear_y_plane_size + linear_uv_plane_size),
+               MM_UTIL_COLOR_NV12, width, height, MM_UTIL_COLOR_RGB24);
 
        MMPLAYER_FREEIF(src_buffer);
        MMPLAYER_FREEIF(linear_y_plane);
@@ -829,7 +832,7 @@ __mm_player_convert_NV12_tiled(mm_player_t *player)
 }
 
 static int
-__mm_player_convert_NV12(mm_player_t *player)
+__mm_player_convert_NV12(mmplayer_t *player)
 {
        unsigned char *src_buffer = NULL;
        unsigned char *p_buf = NULL;
@@ -838,7 +841,7 @@ __mm_player_convert_NV12(mm_player_t *player)
        int ret = MM_ERROR_NONE;
        int i, j;
 
-       /* using original width otherwises, app can't know aligned to resize */
+       /* using original width otherwise, app can't know aligned to resize */
        planes[0] =  player->captured.stride_width[0] * player->captured.stride_height[0];
        planes[1] = player->captured.stride_width[1] * player->captured.stride_height[1];
        guint src_buffer_size = planes[0] + planes[1];
@@ -870,7 +873,7 @@ __mm_player_convert_NV12(mm_player_t *player)
        }
 
        /* NV12 -> RGB888 */
-       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer,
+       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer, (size_t)src_buffer_size,
                        MM_UTIL_COLOR_NV12, player->captured.width[0],
                        player->captured.height[0], MM_UTIL_COLOR_RGB24);
 
@@ -886,7 +889,7 @@ __mm_player_convert_NV12(mm_player_t *player)
 }
 
 static int
-__mm_player_convert_I420(mm_player_t *player)
+__mm_player_convert_I420(mmplayer_t *player)
 {
        unsigned char *src_buffer = NULL;
        unsigned char *p_buf = NULL;
@@ -895,7 +898,7 @@ __mm_player_convert_I420(mm_player_t *player)
        int ret = MM_ERROR_NONE;
        int i;
 
-       /* using original width otherwises, app can't know aligned to resize */
+       /* using original width otherwise, app can't know aligned to resize */
        planes[0] = player->captured.stride_width[0] * player->captured.stride_height[0];
        planes[1] = planes[2] = (player->captured.stride_width[0] >> 1)
                                                                * (player->captured.stride_height[0] >> 1);
@@ -936,8 +939,8 @@ __mm_player_convert_I420(mm_player_t *player)
        }
 
        /* I420 -> RGB888 */
-       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer, MM_UTIL_COLOR_I420,
-                       player->captured.width[0], player->captured.height[0], MM_UTIL_COLOR_RGB24);
+       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer, (size_t)(planes[0] + planes[1] + planes[2]),
+                       MM_UTIL_COLOR_I420, player->captured.width[0], player->captured.height[0], MM_UTIL_COLOR_RGB24);
 
 #ifdef CAPTURE_OUTPUT_DUMP
        capture_output_dump(player);
@@ -951,7 +954,7 @@ __mm_player_convert_I420(mm_player_t *player)
 }
 
 static int
-__mm_player_convert_BGRx(mm_player_t *player)
+__mm_player_convert_BGRx(mmplayer_t *player)
 {
        int i;
        guint size;
@@ -968,7 +971,7 @@ __mm_player_convert_BGRx(mm_player_t *player)
        memcpy(src_buffer, player->captured.data[0], size);
 
        /* BGRx -> RGB888 */
-       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer, MM_UTIL_COLOR_BGRX,
+       ret = __mm_player_convert_colorspace(player, (unsigned char *)src_buffer, (size_t)size, MM_UTIL_COLOR_BGRX,
                        player->captured.width[0], player->captured.height[0], MM_UTIL_COLOR_RGB24);
 
 #ifdef CAPTURE_OUTPUT_DUMP