Enable -Wshadow and fix warnings
[platform/core/security/key-manager.git] / src / manager / service / ckm-logic.cpp
index a5b158e..f57f920 100644 (file)
@@ -81,7 +81,7 @@ int toBinaryData(const Crypto::Data &input, Crypto::Data &output)
        if (input.type.isKey()) {
                KeyShPtr output_key;
 
-               if (input.type.isSKey())
+               if (input.type.isSymmetricKey())
                        output_key = CKM::Key::createAES(input.data);
                else
                        output_key = CKM::Key::create(input.data);
@@ -823,13 +823,13 @@ RawBuffer CKMLogic::getData(
 
        int retCode = tryRet([&] {
                Crypto::GObjUPtr obj;
-               int retCode = readDataHelper(true, cred, dataType, name, owner,
-                                                                        password, obj, objDataType);
+               int retCode2 = readDataHelper(true, cred, dataType, name, owner,
+                                                                         password, obj, objDataType);
 
-               if (retCode == CKM_API_SUCCESS)
+               if (retCode2 == CKM_API_SUCCESS)
                        rowData = obj->getBinary();
 
-               return retCode;
+               return retCode2;
        });
 
        if (CKM_API_SUCCESS != retCode)
@@ -879,36 +879,36 @@ RawBuffer CKMLogic::getPKCS12(
 
                // read private key (mandatory)
                Crypto::GObjUPtr keyObj;
-               int retCode = readDataHelper(true, cred, DataType::DB_KEY_FIRST, name, owner,
-                                                                        keyPassword, keyObj);
+               int retCode2 = readDataHelper(true, cred, DataType::DB_KEY_FIRST, name, owner,
+                                                                         keyPassword, keyObj);
 
-               if (retCode != CKM_API_SUCCESS) {
-                       if (retCode != CKM_API_ERROR_NOT_EXPORTABLE)
-                               return retCode;
+               if (retCode2 != CKM_API_SUCCESS) {
+                       if (retCode2 != CKM_API_ERROR_NOT_EXPORTABLE)
+                               return retCode2;
                } else {
                        privKey = CKM::Key::create(keyObj->getBinary());
                }
 
                // read certificate (mandatory)
                Crypto::GObjUPtr certObj;
-               retCode = readDataHelper(true, cred, DataType::CERTIFICATE, name, owner,
-                                                                certPassword, certObj);
+               retCode2 = readDataHelper(true, cred, DataType::CERTIFICATE, name, owner,
+                                                                 certPassword, certObj);
 
-               if (retCode != CKM_API_SUCCESS) {
-                       if (retCode != CKM_API_ERROR_NOT_EXPORTABLE)
-                               return retCode;
+               if (retCode2 != CKM_API_SUCCESS) {
+                       if (retCode2 != CKM_API_ERROR_NOT_EXPORTABLE)
+                               return retCode2;
                } else {
                        cert = CKM::Certificate::create(certObj->getBinary(), DataFormat::FORM_DER);
                }
 
                // read CA cert chain (optional)
                Crypto::GObjUPtrVector caChainObjs;
-               retCode = readDataHelper(true, cred, DataType::DB_CHAIN_FIRST, name, owner,
-                                                                certPassword, caChainObjs);
+               retCode2 = readDataHelper(true, cred, DataType::DB_CHAIN_FIRST, name, owner,
+                                                                 certPassword, caChainObjs);
 
-               if (retCode != CKM_API_SUCCESS && retCode != CKM_API_ERROR_DB_ALIAS_UNKNOWN) {
-                       if (retCode != CKM_API_ERROR_NOT_EXPORTABLE)
-                               return retCode;
+               if (retCode2 != CKM_API_SUCCESS && retCode2 != CKM_API_ERROR_DB_ALIAS_UNKNOWN) {
+                       if (retCode2 != CKM_API_ERROR_NOT_EXPORTABLE)
+                               return retCode2;
                } else {
                        for (auto &caCertObj : caChainObjs)
                                caChain.push_back(CKM::Certificate::create(caCertObj->getBinary(),
@@ -917,11 +917,11 @@ RawBuffer CKMLogic::getPKCS12(
 
                // if anything found, return it
                if (privKey || cert || caChain.size() > 0)
-                       retCode = CKM_API_SUCCESS;
+                       retCode2 = CKM_API_SUCCESS;
 
                // prepare response
-               if (retCode != CKM_API_SUCCESS)
-                       return retCode;
+               if (retCode2 != CKM_API_SUCCESS)
+                       return retCode2;
 
                output = PKCS12Serializable(std::move(privKey), std::move(cert), std::move(caChain));
                return CKM_API_SUCCESS;
@@ -930,9 +930,9 @@ RawBuffer CKMLogic::getPKCS12(
        return SerializeMessage(msgId, retCode, output);
 }
 
-int CKMLogic::getDataListHelper(const Credentials &cred,
-                                                               const DataType dataType,
-                                                               OwnerNameVector &ownerNameVector)
+int CKMLogic::getAliasInfoListHelper(const Credentials &cred,
+                                                                        const DataType dataType,
+                                                                        AliasInfoVector &aliasInfoVector)
 {
        int retCode = CKM_API_ERROR_DB_LOCKED;
 
@@ -940,23 +940,20 @@ int CKMLogic::getDataListHelper(const Credentials &cred,
                auto &database = m_userDataMap[cred.clientUid].database;
 
                retCode = tryRet<CKM_API_ERROR_DB_ERROR>([&] {
-                       OwnerNameVector tmpVector;
+                       AliasInfoVector tmpVector;
 
                        if (dataType.isKey()) {
                                // list all key types
-                               database.listNames(cred.client,
+                               database.listInfos(cred.client,
                                                                   tmpVector,
                                                                   DataType::DB_KEY_FIRST,
                                                                   DataType::DB_KEY_LAST);
                        } else {
                                // list anything else
-                               database.listNames(cred.client,
-                                                                  tmpVector,
-                                                                  dataType);
+                               database.listInfos(cred.client, tmpVector, dataType);
                        }
 
-                       ownerNameVector.insert(ownerNameVector.end(), tmpVector.begin(),
-                                                                  tmpVector.end());
+                       aliasInfoVector.insert(aliasInfoVector.end(), tmpVector.begin(), tmpVector.end());
                        return CKM_API_SUCCESS;
                });
        }
@@ -969,9 +966,9 @@ RawBuffer CKMLogic::getDataList(
        int msgId,
        DataType dataType)
 {
-       OwnerNameVector systemVector;
-       OwnerNameVector userVector;
-       OwnerNameVector ownerNameVector;
+       AliasInfoVector systemVector;
+       AliasInfoVector userVector;
+       AliasInfoVector aliasInfoVector;
 
        int retCode = unlockSystemDB();
 
@@ -979,32 +976,32 @@ RawBuffer CKMLogic::getDataList(
                // system database
                if (m_accessControl.isSystemService(cred)) {
                        // lookup system DB
-                       retCode = getDataListHelper(Credentials(SYSTEM_DB_UID, CLIENT_ID_SYSTEM),
-                                                                               dataType,
-                                                                               systemVector);
+                       retCode = getAliasInfoListHelper(Credentials(SYSTEM_DB_UID, CLIENT_ID_SYSTEM),
+                                                                                        dataType,
+                                                                                        systemVector);
                } else {
                        // user - lookup system, then client DB
-                       retCode = getDataListHelper(Credentials(SYSTEM_DB_UID, cred.client),
-                                                                               dataType,
-                                                                               systemVector);
+                       retCode = getAliasInfoListHelper(Credentials(SYSTEM_DB_UID, cred.client),
+                                                                                        dataType,
+                                                                                        systemVector);
 
                        // private database
                        if (retCode == CKM_API_SUCCESS) {
-                               retCode = getDataListHelper(cred,
-                                                                                       dataType,
-                                                                                       userVector);
+                               retCode = getAliasInfoListHelper(cred,
+                                                                                                dataType,
+                                                                                                userVector);
                        }
                }
        }
 
        if (retCode == CKM_API_SUCCESS) {
-               ownerNameVector.insert(ownerNameVector.end(), systemVector.begin(),
+               aliasInfoVector.insert(aliasInfoVector.end(), systemVector.begin(),
                                                           systemVector.end());
-               ownerNameVector.insert(ownerNameVector.end(), userVector.begin(),
+               aliasInfoVector.insert(aliasInfoVector.end(), userVector.begin(),
                                                           userVector.end());
        }
 
-       return SerializeMessage(msgId, retCode, dataType, ownerNameVector);
+       return SerializeMessage(msgId, retCode, dataType, AliasInfoSerializableVector(aliasInfoVector));
 }
 
 int CKMLogic::importInitialData(
@@ -1203,9 +1200,9 @@ RawBuffer CKMLogic::createKeyAES(
 
        try {
                retCode = tryRet([&] {
-                       auto [dbOp, digest, retCode] = beginSaveAndGetHash(cred, name, owner);
-                       if (retCode != CKM_API_SUCCESS)
-                               return retCode;
+                       auto [dbOp, digest, retCode2] = beginSaveAndGetHash(cred, name, owner);
+                       if (retCode2 != CKM_API_SUCCESS)
+                               return retCode2;
 
                        // create key in store
                        CryptoAlgorithm keyGenAlgorithm;
@@ -1436,13 +1433,13 @@ RawBuffer CKMLogic::createSignature(
        try {
                retCode = tryRet([&] {
                        Crypto::GObjUPtr obj;
-                       int retCode = readDataHelper(false, cred, DataType::DB_KEY_FIRST, privateKeyName,
-                                                                                owner, password, obj);
+                       int retCode2 = readDataHelper(false, cred, DataType::DB_KEY_FIRST, privateKeyName,
+                                                                                 owner, password, obj);
 
-                       if (retCode == CKM_API_SUCCESS)
+                       if (retCode2 == CKM_API_SUCCESS)
                                signature = obj->sign(cryptoAlg, message);
 
-                       return retCode;
+                       return retCode2;
                });
        } catch (const std::exception &e) {
                LogError("STD exception " << e.what());
@@ -1631,22 +1628,47 @@ RawBuffer CKMLogic::exportWrappedKey(
        RawBuffer wrappedKey;
 
        auto retCode = tryRet([&] {
-               auto retCode = readDataHelper(false, cred, DataType::DB_KEY_FIRST, wrappingKeyName,
-                                                                         wrappingKeyOwner, wrappingKeyPassword, wrappingKey);
-               if (retCode != CKM_API_SUCCESS)
-                       return retCode;
+               auto retCode2 = readDataHelper(false, cred, DataType::DB_KEY_FIRST, wrappingKeyName,
+                                                                          wrappingKeyOwner, wrappingKeyPassword, wrappingKey);
+               if (retCode2 != CKM_API_SUCCESS)
+                       return retCode2;
 
-               retCode = readRowHelper(false, cred, DataType::DB_KEY_FIRST, keyName,
-                                                               keyOwner, keyPassword, wrappedKeyRow, wrappedKeyType);
-               if (retCode != CKM_API_SUCCESS)
-                       return retCode;
+               retCode2 = readRowHelper(false, cred, DataType::DB_KEY_FIRST, keyName,
+                                                                keyOwner, keyPassword, wrappedKeyRow, wrappedKeyType);
+               if (retCode2 != CKM_API_SUCCESS)
+                       return retCode2;
 
                wrappedKey = wrappingKey->wrap(params, wrappedKeyRow, keyPassword);
 
-               return retCode;
+               return retCode2;
        });
 
        return SerializeMessage(msgID, retCode, wrappedKeyType, wrappedKey);
 }
 
+RawBuffer CKMLogic::getBackendInfo(const int msgID, BackendId backend)
+{
+       BackendInfo info;
+       auto retCode = tryRet([&] {
+               CryptoBackend cryptoBackend;
+               if (backend == BackendId::SW)
+                       cryptoBackend = CryptoBackend::OpenSSL;
+               else if (backend == BackendId::TZ)
+                       cryptoBackend = CryptoBackend::TrustZone;
+               else
+                       return CKM_API_ERROR_INPUT_PARAM;
+
+               auto store = m_decider.getStore(cryptoBackend);
+               if (store == nullptr) {
+                       LogError("Required backend is unavailable");
+                       return CKM_API_ERROR_INPUT_PARAM;
+               }
+
+               info.maxChunkSize = store->maxChunkSize();
+               return CKM_API_SUCCESS;
+       });
+
+       return SerializeMessage(msgID, retCode, BackendInfoSerializable(info));
+}
+
 } // namespace CKM