Merge upstream r66310
[framework/uifw/elementary.git] / src / lib / elm_gesture_layer.c
index 2150d6b..a37bba1 100644 (file)
@@ -7,6 +7,7 @@
 /* ELM_GESTURE_NEGATIVE_ANGLE - magic number says we didn't compute this yet */
 #define ELM_GESTURE_NEGATIVE_ANGLE (-1.0) /* Magic number */
 #define ELM_GESTURE_MOMENTUM_TIMEOUT 50
+#define ELM_GESTURE_MULTI_TIMEOUT 50
 
 /* Some Trigo values */
 #define RAD_90DEG  M_PI_2
@@ -145,9 +146,9 @@ typedef struct _Pointer_Event Pointer_Event;
 struct _Taps_Type
 {
    Elm_Gesture_Taps_Info info;
-   unsigned int count_ups;
    unsigned int sum_x;
    unsigned int sum_y;
+   unsigned int n_taps_needed;
    unsigned int n_taps;
    Eina_List *l;
 };
@@ -156,9 +157,9 @@ typedef struct _Taps_Type Taps_Type;
 struct _Long_Tap_Type
 {
    Elm_Gesture_Taps_Info info;
-   unsigned int center_x;
-   unsigned int center_y;
-   unsigned int n_taps;
+   Evas_Coord center_x;
+   Evas_Coord center_y;
+   unsigned int max_touched;
    Ecore_Timer *timeout; /* When this expires, long tap STARTed */
    Eina_List *touched;
 };
@@ -172,6 +173,7 @@ struct _Momentum_Type
    unsigned int t_st_x;  /* Time start on X */
    unsigned int t_st_y;  /* Time start on Y */
    unsigned int t_end;   /* Time end        */
+   unsigned int t_up; /* Recent up event time */
    int xdir, ydir;
 };
 typedef struct _Momentum_Type Momentum_Type;
@@ -248,7 +250,6 @@ struct _Widget_Data
    Ecore_Timer *dbl_timeout; /* When this expires, dbl click/taps ABORTed  */
    Eina_List *pending; /* List of devices need to refeed *UP event */
    Eina_List *touched;  /* Information  of touched devices   */
-   Eina_List *recent_device_event;  /* Information  of recent pe event of each device */
 
    Eina_Bool repeat_events : 1;
 };
@@ -296,11 +297,13 @@ compare_device(const void *data1, const void *data2)
 static Eina_List *
 _remove_touched_device(Eina_List *list, Pointer_Event *pe)
 {
+   Eina_List *lst = NULL;
    Pointer_Event *p = eina_list_search_unsorted(list, compare_device, pe);
    if (p)
      {
+        lst = eina_list_remove(list, p);
         free(p);
-        return eina_list_remove(list, p);
+        return lst;
      }
 
    return list;
@@ -333,64 +336,6 @@ _add_touched_device(Eina_List *list, Pointer_Event *pe)
 }
 /* END   - Functions to manage touched-device list */
 
-/* START - Functions to manage recent device event list */
-/* This list holds the recent-event for each device     */
-/* it will hold a single recent-event for each device   */
-/* We are using those PE events of this list to         */
-/* send them later to test funcs to restart gestures    */
-/* We only keep DOWN, MOVE events in this list.         */
-/* So when no touch this list is empty.                 */
-/**
- * @internal
- *
- * Recoed Pointer Event in touched device list
- * Note: This fuction allocates memory for PE event
- * This memory is released here when device untouched
- * or in cleanup.
- * @param list Pointer to touched device list.
- * @param Pointer_Event Pointer to PE.
- *
- * @ingroup Elm_Gesture_Layer
- */
-static Eina_List *
-_add_recent_device_event(Eina_List *list, Pointer_Event *pe)
-{
-   void *data = eina_list_search_sorted(list, compare_device, pe);
-   Eina_List *l = list;
-   Pointer_Event *p = NULL;
-   if(data)   /* First remove recent event for this device */
-     l = eina_list_remove(list, data);
-
-
-   switch(pe->event_type)
-     {
-      case EVAS_CALLBACK_MOUSE_DOWN:
-      case EVAS_CALLBACK_MOUSE_MOVE:
-      case EVAS_CALLBACK_MULTI_DOWN:
-      case EVAS_CALLBACK_MULTI_MOVE:
-         p = malloc(sizeof(Pointer_Event));
-         memcpy(p, pe, sizeof(Pointer_Event)); /* Freed in here or on cleanup */
-         l =  eina_list_sorted_insert(l, compare_device, p);
-         break;
-
-      /* Kept those cases for referance */
-      case EVAS_CALLBACK_MOUSE_IN:
-      case EVAS_CALLBACK_MOUSE_OUT:
-      case EVAS_CALLBACK_MOUSE_WHEEL:
-      case EVAS_CALLBACK_MOUSE_UP:
-      case EVAS_CALLBACK_MULTI_UP:
-      case EVAS_CALLBACK_KEY_DOWN:
-      case EVAS_CALLBACK_KEY_UP:
-         break;
-
-      default:
-         return l;
-     }
-
-   return l;
-}
-/* END   - Functions to manage recent device event list */
-
 /**
  * @internal
  *
@@ -606,7 +551,7 @@ _clear_if_finished(Evas_Object *obj)
 
    /* Clear history if all we have aborted gestures */
    Eina_Bool reset_s = EINA_TRUE, all_undefined = EINA_TRUE;
-   for (i = ELM_GESTURE_FIRST ; i < ELM_GESTURE_LAST; i++)
+   for (i = ELM_GESTURE_FIRST; i < ELM_GESTURE_LAST; i++)
      {  /* If no gesture started and all we have aborted gestures, reset all */
         Gesture_Info *p = wd->gesture[i];
         if ((p) && (p->state != ELM_GESTURE_STATE_UNDEFINED))
@@ -619,8 +564,6 @@ _clear_if_finished(Evas_Object *obj)
           }
      }
 
-//   if ((!wd->touched) || (reset_s && !all_undefined))
-   /* (!wd->touched && reset_s) - don't stop zoom with mouse-wheel */
    if (reset_s && (!all_undefined))
      return _event_history_clear(obj);
 
@@ -651,13 +594,12 @@ _inside(Evas_Coord x1, Evas_Coord y1, Evas_Coord x2, Evas_Coord y2)
  * This happens when we need to reset our tests.
  * for example when gesture is detected or all ABORTed. */
 static void
-_dbl_click_test_reset(Gesture_Info *gesture)
+_tap_gestures_test_reset(Gesture_Info *gesture)
 {
    if (!gesture)
      return;
 
    Widget_Data *wd = elm_widget_data_get(gesture->obj);
-   if (wd->dbl_timeout) ecore_timer_del(wd->dbl_timeout);
    wd->dbl_timeout = NULL;
    Eina_List *data;
    Pointer_Event *pe;
@@ -686,13 +628,13 @@ _n_long_tap_test_reset(Gesture_Info *gesture)
      return;
 
    Long_Tap_Type *st = gesture->data;
-   if (st->timeout) ecore_timer_del(st->timeout);
    Eina_List *l;
    Pointer_Event *p;
    EINA_LIST_FOREACH(st->touched, l, p)
       free(p);
 
    eina_list_free(st->touched);
+   if (st->timeout) ecore_timer_del(st->timeout);
    memset(gesture->data, 0, sizeof(Long_Tap_Type));
 }
 
@@ -973,11 +915,25 @@ _event_history_clear(Evas_Object *obj)
 
    _reset_states(wd); /* we are ready to start testing for gestures again */
 
-   /* Clear all gestures intermediate date */
-   _n_long_tap_test_reset(wd->gesture[ELM_GESTURE_N_LONG_TAPS]);
-   _dbl_click_test_reset(wd->gesture[ELM_GESTURE_N_TAPS]);
-   _dbl_click_test_reset(wd->gesture[ELM_GESTURE_N_DOUBLE_TAPS]);
-   _dbl_click_test_reset(wd->gesture[ELM_GESTURE_N_TRIPLE_TAPS]);
+   /* Clear all gestures intermediate data */
+   if (IS_TESTED(ELM_GESTURE_N_LONG_TAPS))
+     {  /* We do not clear a long-tap gesture if fingers still on surface */
+        /* and gesture timer still pending to test gesture state          */
+        Long_Tap_Type *st = wd->gesture[ELM_GESTURE_N_LONG_TAPS]->data;
+        if ((st) &&  /* st not allocated if clear occurs before 1st input */
+              ((!eina_list_count(st->touched)) || (!st->timeout)))
+          _n_long_tap_test_reset(wd->gesture[ELM_GESTURE_N_LONG_TAPS]);
+     }
+
+   if (wd->dbl_timeout)
+     {
+        ecore_timer_del(wd->dbl_timeout);
+        wd->dbl_timeout = NULL;
+     }
+
+   _tap_gestures_test_reset(wd->gesture[ELM_GESTURE_N_TAPS]);
+   _tap_gestures_test_reset(wd->gesture[ELM_GESTURE_N_DOUBLE_TAPS]);
+   _tap_gestures_test_reset(wd->gesture[ELM_GESTURE_N_TRIPLE_TAPS]);
    _momentum_test_reset(wd->gesture[ELM_GESTURE_MOMENTUM]);
    _line_test_reset(wd->gesture[ELM_GESTURE_N_LINES]);
    _line_test_reset(wd->gesture[ELM_GESTURE_N_FLICKS]);
@@ -1002,16 +958,14 @@ _event_history_clear(Evas_Object *obj)
 
              if (pending)
                {
-               wd->pending = eina_list_remove_list(wd->pending, pending);
-               int device = ELM_MOUSE_DEVICE;
-               if (wd->event_history_list->event_type == EVAS_CALLBACK_MULTI_UP)
-                 device = ((Evas_Event_Multi_Up *)
-                       (wd->event_history_list->event))->device;
+                  wd->pending = eina_list_remove_list(wd->pending, pending);
                }
              else
-               wd->pending = _add_device_pending(wd->pending,
-                     wd->event_history_list->event,
-                     wd->event_history_list->event_type);
+               {
+                  wd->pending = _add_device_pending(wd->pending,
+                        wd->event_history_list->event,
+                        wd->event_history_list->event_type);
+               }
           }
 
         free(wd->event_history_list->event);
@@ -1103,9 +1057,6 @@ _del_hook(Evas_Object *obj)
    EINA_LIST_FREE(wd->touched, data)
       free(data);
 
-   EINA_LIST_FREE(wd->recent_device_event, data)
-      free(data);
-
    if (!elm_widget_disabled_get(obj))
      _unregister_callbacks(obj);
 
@@ -1193,7 +1144,41 @@ _record_pointer_event(Taps_Type *st, Eina_List *pe_list, Pointer_Event *pe,
 /**
  * @internal
  *
- * when this timer expires we ABORT double click gesture.
+ * This function sets state a tap-gesture to END or ABORT
+ *
+ * @param data gesture info pointer
+ *
+ * @ingroup Elm_Gesture_Layer
+ */
+static void
+_tap_gesture_finish(void *data)
+{  /* This function will test each tap gesture when timer expires */
+   Gesture_Info *gesture = data;
+   Elm_Gesture_State s = ELM_GESTURE_STATE_END;
+   /* Here we check if taps-gesture was completed successfuly */
+   /* Count how many taps were recieved on each device then   */
+   /* determine if it matches n_taps_needed defined on START  */
+   Taps_Type *st = gesture->data;
+   Eina_List *l;
+   Eina_List *pe_list;
+   EINA_LIST_FOREACH(st->l, l, pe_list)
+     {
+        if (eina_list_count(pe_list) != st->n_taps_needed)
+          {  /* No match taps number on device, ABORT */
+             s = ELM_GESTURE_STATE_ABORT;
+             break;
+          }
+     }
+
+   st->info.n = eina_list_count(st->l);
+   _set_state(gesture, s, gesture->info, EINA_FALSE);
+   _tap_gestures_test_reset(gesture);
+}
+
+/**
+ * @internal
+ *
+ * when this timer expires we finish tap gestures.
  *
  * @param data The gesture-layer object.
  * @return cancles callback for this timer.
@@ -1201,17 +1186,22 @@ _record_pointer_event(Taps_Type *st, Eina_List *pe_list, Pointer_Event *pe,
  * @ingroup Elm_Gesture_Layer
  */
 static Eina_Bool
-_dbl_click_timeout(void *data)
+_multi_tap_timeout(void *data)
 {
-   Gesture_Info *gesture = data;
-   Widget_Data *wd = elm_widget_data_get(gesture->obj);
+   Widget_Data *wd = elm_widget_data_get(data);
+   if (!wd) return EINA_FALSE;
 
-   wd->dbl_timeout = NULL;
-   _set_state(gesture, ELM_GESTURE_STATE_ABORT,
-         gesture->info, EINA_FALSE);
+   if (IS_TESTED(ELM_GESTURE_N_TAPS))
+     _tap_gesture_finish(wd->gesture[ELM_GESTURE_N_TAPS]);
+
+   if (IS_TESTED(ELM_GESTURE_N_DOUBLE_TAPS))
+   _tap_gesture_finish(wd->gesture[ELM_GESTURE_N_DOUBLE_TAPS]);
 
-   _dbl_click_test_reset(gesture);
-   _clear_if_finished(gesture->obj);
+   if (IS_TESTED(ELM_GESTURE_N_TRIPLE_TAPS))
+   _tap_gesture_finish(wd->gesture[ELM_GESTURE_N_TRIPLE_TAPS]);
+
+   _clear_if_finished(data);
+   wd->dbl_timeout = NULL;
    return ECORE_CALLBACK_CANCEL;
 }
 
@@ -1238,40 +1228,34 @@ _long_tap_timeout(void *data)
    return ECORE_CALLBACK_CANCEL;
 }
 
+
 /**
  * @internal
  *
- * This function checks all click/tap and double/triple taps
+ * This function checks if a tap gesture should start
  *
- * @param obj The gesture-layer object.
+ * @param wd Gesture Layer Widget Data.
  * @param pe The recent input event as stored in pe struct.
  * @param event_info Original input event pointer.
  * @param event_type Type of original input event.
- * @param g_type what Gesture we are testing.
- * @param taps How many click/taps we test for.
+ * @param gesture what gesture is tested
+ * @param how many taps for this gesture (1, 2 or 3)
+ *
+ * @return Flag to determine if we need to set a timer for finish
  *
  * @ingroup Elm_Gesture_Layer
  */
-static void
-_dbl_click_test(Evas_Object *obj, Pointer_Event *pe,
+static Eina_Bool
+_tap_gesture_start(Widget_Data *wd, Pointer_Event *pe,
       void *event_info, Evas_Callback_Type event_type,
-      Elm_Gesture_Types g_type, int taps)
-{  /* Here we fill Recent_Taps struct and fire-up click/tap timers */
-   Widget_Data *wd = elm_widget_data_get(obj);
-   if (!wd) return;
-
-   if (!pe)   /* this happens when unhandled event arrived */
-     return; /* see _make_pointer_event function */
-
-   Gesture_Info *gesture = wd->gesture[g_type];
-   if (!gesture ) return;
-
+      Gesture_Info *gesture, int taps)
+{  /* Here we fill Tap struct */
    Taps_Type *st = gesture->data;
    if (!st)
      {  /* Allocated once on first time */
         st = calloc(1, sizeof(Taps_Type));
         gesture->data = st;
-        _dbl_click_test_reset(gesture);
+        _tap_gestures_test_reset(gesture);
      }
 
    Eina_List *pe_list = NULL;
@@ -1289,52 +1273,20 @@ _dbl_click_test(Evas_Object *obj, Pointer_Event *pe,
                     &st->info, EINA_FALSE);
               consume_event(wd, event_info, event_type, ev_flag);
 
-              /* To test dbl_click/dbl_tap */
-              /* When this timer expires, gesture ABORTed if not completed */
-              if (!wd->dbl_timeout && (taps > 1))
-                wd->dbl_timeout = ecore_timer_add(0.4, _dbl_click_timeout,
-                      gesture);
+              st->n_taps_needed = taps * 2; /* count DOWN and UP */
 
-              return;
+              return EINA_TRUE;
            }
 
          break;
+
       case EVAS_CALLBACK_MULTI_UP:
       case EVAS_CALLBACK_MOUSE_UP:
          pe_list = eina_list_search_unsorted(st->l, compare_pe_device, pe);
          if (!pe_list)
-           return;  /* Got only first mouse_down and mouse_up */
+           return EINA_FALSE;
 
          pe_list = _record_pointer_event(st, pe_list, pe, wd, event_info, event_type);
-
-         if (eina_list_count(pe_list) <= (unsigned int) ((taps - 1) * 2))
-           return;  /* Got only first mouse_down and mouse_up */
-
-         /* Get first event in first list, this has to be Mouse Down event */
-         pe_down = eina_list_data_get(pe_list);
-
-         if (_inside(pe_down->x, pe_down->y, pe->x, pe->y))
-           {
-              st->count_ups++;
-           }
-         else
-           {
-              ev_flag = _set_state(gesture, ELM_GESTURE_STATE_ABORT,
-                    &st->info, EINA_FALSE);
-              consume_event(wd, event_info, event_type, ev_flag);
-              break;
-           }
-
-         if (st->count_ups == eina_list_count(st->l))
-           {
-              st->info.n = st->count_ups;
-              ev_flag =_set_state(gesture, ELM_GESTURE_STATE_END,
-                    &st->info, EINA_FALSE);
-              consume_event(wd, event_info, event_type, ev_flag);
-
-              return;
-           }
-
          break;
 
       case EVAS_CALLBACK_MULTI_MOVE:
@@ -1347,15 +1299,60 @@ _dbl_click_test(Evas_Object *obj, Pointer_Event *pe,
               pe_down = eina_list_data_get(pe_list);
               if (!_inside(pe_down->x, pe_down->y, pe->x, pe->y))
                 {
-                ev_flag = _set_state(gesture, ELM_GESTURE_STATE_ABORT,
-                      &st->info, EINA_FALSE);
-                consume_event(wd, event_info, event_type, ev_flag);
+                   ev_flag = _set_state(gesture, ELM_GESTURE_STATE_ABORT,
+                         &st->info, EINA_FALSE);
+                   consume_event(wd, event_info, event_type, ev_flag);
                 }
            }
          break;
 
       default:
-         return;
+         return EINA_FALSE;
+     }
+
+   return EINA_FALSE;
+}
+
+
+/**
+ * @internal
+ *
+ * This function checks all click/tap and double/triple taps
+ *
+ * @param obj The gesture-layer object.
+ * @param pe The recent input event as stored in pe struct.
+ * @param event_info Original input event pointer.
+ * @param event_type Type of original input event.
+ *
+ * @ingroup Elm_Gesture_Layer
+ */
+static void
+_tap_gestures_test(Evas_Object *obj, Pointer_Event *pe,
+      void *event_info, Evas_Callback_Type event_type)
+{  /* Here we fill Recent_Taps struct and fire-up click/tap timers */
+   Eina_Bool need_timer = EINA_FALSE;
+   Widget_Data *wd = elm_widget_data_get(obj);
+   if (!wd) return;
+
+   if (!pe)   /* this happens when unhandled event arrived */
+     return;  /* see _make_pointer_event function */
+
+   if (IS_TESTED(ELM_GESTURE_N_TAPS))
+     need_timer |= _tap_gesture_start(wd, pe, event_info, event_type,
+           wd->gesture[ELM_GESTURE_N_TAPS], 1);
+
+   if (IS_TESTED(ELM_GESTURE_N_DOUBLE_TAPS))
+     need_timer |= _tap_gesture_start(wd, pe, event_info, event_type,
+           wd->gesture[ELM_GESTURE_N_DOUBLE_TAPS], 2);
+
+   if (IS_TESTED(ELM_GESTURE_N_TRIPLE_TAPS))
+     need_timer |= _tap_gesture_start(wd, pe, event_info, event_type,
+           wd->gesture[ELM_GESTURE_N_TRIPLE_TAPS], 3);
+
+   if ((need_timer) && (!wd->dbl_timeout))
+     {  /* Set a timer to finish these gestures */
+        wd->dbl_timeout = ecore_timer_add(0.4, _multi_tap_timeout,
+              obj);
      }
 }
 
@@ -1370,7 +1367,8 @@ _dbl_click_test(Evas_Object *obj, Pointer_Event *pe,
  * @ingroup Elm_Gesture_Layer
  */
 static void
-_compute_taps_center(Long_Tap_Type *st, Pointer_Event *pe)
+_compute_taps_center(Long_Tap_Type *st,
+      Evas_Coord *x_out, Evas_Coord *y_out, Pointer_Event *pe)
 {
    if(!eina_list_count(st->touched))
      return;
@@ -1392,8 +1390,8 @@ _compute_taps_center(Long_Tap_Type *st, Pointer_Event *pe)
           }
      }
 
-   st->info.x = x / eina_list_count(st->touched);
-   st->info.y = y / eina_list_count(st->touched);
+   *x_out = x / eina_list_count(st->touched);
+   *y_out = y / eina_list_count(st->touched);
 }
 
 /**
@@ -1412,17 +1410,16 @@ _compute_taps_center(Long_Tap_Type *st, Pointer_Event *pe)
  */
 static void
 _n_long_tap_test(Evas_Object *obj, Pointer_Event *pe,
-      void *event_info, Evas_Callback_Type event_type,
-      Elm_Gesture_Types g_type)
+                 void *event_info, Evas_Callback_Type event_type,
+                 Elm_Gesture_Types g_type)
 {  /* Here we fill Recent_Taps struct and fire-up click/tap timers */
    Widget_Data *wd = elm_widget_data_get(obj);
    if (!wd) return;
 
    if (!pe)   /* this happens when unhandled event arrived */
-     return; /* see _make_pointer_event function */
-
+     return;  /* see _make_pointer_event function */
    Gesture_Info *gesture = wd->gesture[g_type];
-   if (!gesture ) return;
+   if (!gesture) return;
 
    Long_Tap_Type *st = gesture->data;
    if (!st)
@@ -1437,63 +1434,91 @@ _n_long_tap_test(Evas_Object *obj, Pointer_Event *pe,
      {
       case EVAS_CALLBACK_MULTI_DOWN:
       case EVAS_CALLBACK_MOUSE_DOWN:
-         if (st->info.n > eina_list_count(st->touched))
-           {  /* ABORT: user lifts finger then back before completing gesgure */
-              if (st->timeout) ecore_timer_del(st->timeout);
-              st->timeout = NULL;
-              ev_flag =_set_state(gesture, ELM_GESTURE_STATE_ABORT,
-                    &st->info, EINA_FALSE);
-           }
+        st->touched = _add_touched_device(st->touched, pe);
+        st->info.n = eina_list_count(st->touched);
+        if (st->info.n > st->max_touched)
+          st->max_touched = st->info.n;
+        else
+          {  /* User removed finger from touch, then put back - ABORT */
+             if ((gesture->state == ELM_GESTURE_STATE_START) ||
+                 (gesture->state == ELM_GESTURE_STATE_MOVE))
+               {
+                  ev_flag =_set_state(gesture, ELM_GESTURE_STATE_ABORT,
+                                      &st->info, EINA_FALSE);
+                  consume_event(wd, event_info, event_type, ev_flag);
+               }
+          }
 
-         st->touched = _add_touched_device(st->touched, pe);
-         st->info.n = eina_list_count(st->touched);
-         if ((pe->device == 0) && (eina_list_count(st->touched) == 1))
-           {  /* This is the first mouse down we got */
-              st->info.timestamp = pe->timestamp;
+        if ((pe->device == 0) && (eina_list_count(st->touched) == 1))
+          {  /* This is the first mouse down we got */
+             st->info.timestamp = pe->timestamp;
 
-              /* To test long tap */
-              /* When this timer expires, gesture STARTED */
-              if (!st->timeout)
-                st->timeout = ecore_timer_add(wd->long_tap_start_timeout, _long_tap_timeout,
-                      gesture);
-           }
+             /* To test long tap */
+             /* When this timer expires, gesture STARTED */
+             if (!st->timeout)
+               st->timeout = ecore_timer_add(wd->long_tap_start_timeout,
+                                             _long_tap_timeout, gesture);
+          }
 
-         consume_event(wd, event_info, event_type, ev_flag);
-         _compute_taps_center(st, pe);
-         break;
+        consume_event(wd, event_info, event_type, ev_flag);
+        _compute_taps_center(st, &st->info.x, &st->info.y, pe);
+        st->center_x = st->info.x;
+        st->center_y = st->info.y;
+        break;
 
       case EVAS_CALLBACK_MULTI_UP:
       case EVAS_CALLBACK_MOUSE_UP:
-         st->touched = _remove_touched_device(st->touched, pe);
-         if (st->info.n &&
-               ((gesture->state == ELM_GESTURE_STATE_START) ||
+        st->touched = _remove_touched_device(st->touched, pe);
+        _compute_taps_center(st, &st->center_x, &st->center_y, pe);
+        if (st->info.n &&
+            ((gesture->state == ELM_GESTURE_STATE_START) ||
                 (gesture->state == ELM_GESTURE_STATE_MOVE)))
-           {  /* Report END only for gesture that STARTed */
-              if (eina_list_count(st->touched) == 0)
-                {  /* Report END only at last release event */
-                   ev_flag =_set_state(gesture, ELM_GESTURE_STATE_END,
-                         &st->info, EINA_FALSE);
-                   consume_event(wd, event_info, event_type, ev_flag);
-                }
-           }
-         break;
+          {  /* Report END only for gesture that STARTed */
+             if (eina_list_count(st->touched) == 0)
+               {  /* Report END only at last release event */
+                  ev_flag =_set_state(gesture, ELM_GESTURE_STATE_END,
+                                      &st->info, EINA_FALSE);
+                  consume_event(wd, event_info, event_type, ev_flag);
+               }
+          }
+        else
+          {  /* Stop test, user lifts finger before long-start */
+             if (st->timeout) ecore_timer_del(st->timeout);
+             st->timeout = NULL;
+             ev_flag =_set_state(gesture, ELM_GESTURE_STATE_ABORT,
+                                 &st->info, EINA_FALSE);
+             consume_event(wd, event_info, event_type, ev_flag);
+          }
+
+        break;
 
       case EVAS_CALLBACK_MULTI_MOVE:
       case EVAS_CALLBACK_MOUSE_MOVE:
-         if(st->info.n &&
-               ((gesture->state == ELM_GESTURE_STATE_START) ||
-                (gesture->state == ELM_GESTURE_STATE_MOVE)))
-           {  /* Report MOVE only if STARTED */
-              _compute_taps_center(st, pe);
-              /* Report MOVE if gesture started */
-              ev_flag = _set_state(gesture, ELM_GESTURE_STATE_MOVE,
-                    &st->info, EINA_TRUE);
-              consume_event(wd, event_info, event_type, ev_flag);
-           }
-         break;
+        if(st->info.n &&
+           ((gesture->state == ELM_GESTURE_STATE_START) ||
+               (gesture->state == ELM_GESTURE_STATE_MOVE)))
+          {  /* Report MOVE only if STARTED */
+             Evas_Coord x = 0;
+             Evas_Coord y = 0;
+             Elm_Gesture_State state_to_report = ELM_GESTURE_STATE_MOVE;
+
+             _compute_taps_center(st, &x, &y, pe);
+             /* ABORT if user moved fingers out of tap area */
+#if defined(DEBUG_GESTURE_LAYER)
+             printf("%s x,y=(%d,%d) st->info.x,st->info.y=(%d,%d)\n",__func__,x,y,st->info.x,st->info.y);
+#endif
+             if (!_inside(x, y, st->center_x, st->center_y))
+               state_to_report = ELM_GESTURE_STATE_ABORT;
+
+             /* Report MOVE if gesture started */
+             ev_flag = _set_state(gesture, state_to_report,
+                                  &st->info, EINA_TRUE);
+             consume_event(wd, event_info, event_type, ev_flag);
+          }
+        break;
 
       default:
-         return;
+        return;
      }
 }
 
@@ -1675,7 +1700,7 @@ _momentum_test(Evas_Object *obj, Pointer_Event *pe,
    if (!gesture ) return;
 
    Momentum_Type *st = gesture->data;
-   Elm_Gesture_State state_to_report;
+   Elm_Gesture_State state_to_report = ELM_GESTURE_STATE_MOVE;
    if (!st)
      {  /* Allocated once on first time */
         st = calloc(1, sizeof(Momentum_Type));
@@ -1686,38 +1711,70 @@ _momentum_test(Evas_Object *obj, Pointer_Event *pe,
    if (!pe)
      return;
 
+   /* First make avarage of all touched devices to determine center point */
+   Eina_List *l;
+   Pointer_Event *p;
+   Pointer_Event pe_local = *pe;           /* Copy pe event info to local */
+   unsigned int cnt = 1;    /* We start counter counting current pe event */
+   EINA_LIST_FOREACH(wd->touched, l, p)
+      if (p->device != pe_local.device)
+        {
+           pe_local.x += p->x;
+           pe_local.y += p->y;
+           cnt++;
+        }
+
+
+   /* Compute avarage to get center point */
+   pe_local.x /= cnt;
+   pe_local.y /= cnt;
+
+   /* If user added finger - reset gesture */
+   if ((st->info.n) && (st->info.n < cnt))
+     state_to_report = ELM_GESTURE_STATE_ABORT;
+
+   if (st->info.n < cnt)
+     st->info.n = cnt;
+
    Evas_Event_Flags ev_flag = EVAS_EVENT_FLAG_NONE;
    switch (event_type)
      {
       case EVAS_CALLBACK_MOUSE_DOWN:
+      case EVAS_CALLBACK_MULTI_DOWN:
       case EVAS_CALLBACK_MOUSE_MOVE:
+      case EVAS_CALLBACK_MULTI_MOVE:
          if (!st->t_st_x)
            {
               if ((event_type == EVAS_CALLBACK_MOUSE_DOWN) ||
+                    (event_type == EVAS_CALLBACK_MULTI_DOWN) ||
                     (wd->glayer_continues_enable)) /* start also on MOVE */
                 {  /* We start on MOVE when cont-enabled only */
-                   st->line_st.x = st->line_end.x = pe->x;
-                   st->line_st.y = st->line_end.y = pe->y;
-                   st->t_st_x = st->t_st_y = st->t_end = pe->timestamp;
+                   st->line_st.x = st->line_end.x = pe_local.x;
+                   st->line_st.y = st->line_end.y = pe_local.y;
+                   st->t_st_x = st->t_st_y = st->t_end = pe_local.timestamp;
                    st->xdir = st->ydir = 0;
-                   st->info.x2 = st->info.x1 = pe->x;
-                   st->info.y2 = st->info.y1 = pe->y;
-                   st->info.tx = st->info.ty = pe->timestamp;
+                   st->info.x2 = st->info.x1 = pe_local.x;
+                   st->info.y2 = st->info.y1 = pe_local.y;
+                   st->info.tx = st->info.ty = pe_local.timestamp;
                    ev_flag = _set_state(gesture, ELM_GESTURE_STATE_START,
                          &st->info, EINA_FALSE);
                    consume_event(wd, event_info, event_type, ev_flag);
-
                 }
 
               return;
            }
 
-         state_to_report = ELM_GESTURE_STATE_MOVE;
-         if ((pe->timestamp - ELM_GESTURE_MOMENTUM_TIMEOUT) > st->t_end)
+
+         /* ABORT gesture if got DOWN or MOVE event after UP+timeout */
+         if ((st->t_up) &&
+         ((st->t_up + ELM_GESTURE_MULTI_TIMEOUT) < pe_local.timestamp))
+           state_to_report = ELM_GESTURE_STATE_ABORT;
+
+         if ((pe_local.timestamp - ELM_GESTURE_MOMENTUM_TIMEOUT) > st->t_end)
            {  /*  Too long of a wait, reset all values */
-              st->line_st.x = pe->x;
-              st->line_st.y = pe->y;
-              st->t_st_y = st->t_st_x = pe->timestamp;
+              st->line_st.x = pe_local.x;
+              st->line_st.y = pe_local.y;
+              st->t_st_y = st->t_st_x = pe_local.timestamp;
               st->info.tx = st->t_st_x;
               st->info.ty = st->t_st_y;
               st->xdir = st->ydir = 0;
@@ -1725,8 +1782,8 @@ _momentum_test(Evas_Object *obj, Pointer_Event *pe,
          else
            {
               int xdir, ydir;
-              xdir = _get_direction(st->line_st.x, pe->x);
-              ydir = _get_direction(st->line_st.y, pe->y);
+              xdir = _get_direction(st->line_st.x, pe_local.x);
+              ydir = _get_direction(st->line_st.y, pe_local.y);
               if (!xdir || (xdir == (-st->xdir)))
                 {
                    st->line_st.x = st->line_end.x;
@@ -1742,11 +1799,11 @@ _momentum_test(Evas_Object *obj, Pointer_Event *pe,
                 }
            }
 
-         st->info.x2 = st->line_end.x = pe->x;
-         st->info.y2 = st->line_end.y = pe->y;
-         st->t_end = pe->timestamp;
-         _set_momentum(&st->info, st->line_st.x, st->line_st.y, pe->x, pe->y,
-               st->t_st_x, st->t_st_y, pe->timestamp);
+         st->info.x2 = st->line_end.x = pe_local.x;
+         st->info.y2 = st->line_end.y = pe_local.y;
+         st->t_end = pe_local.timestamp;
+         _set_momentum(&st->info, st->line_st.x, st->line_st.y, pe_local.x, pe_local.y,
+               st->t_st_x, st->t_st_y, pe_local.timestamp);
          ev_flag = _set_state(gesture, state_to_report, &st->info,
                EINA_TRUE);
          consume_event(wd, event_info, event_type, ev_flag);
@@ -1754,36 +1811,30 @@ _momentum_test(Evas_Object *obj, Pointer_Event *pe,
 
 
       case EVAS_CALLBACK_MOUSE_UP:
-         /* IGNORE if line info was cleared, like long press, move */
-         if (!st->t_st_x)
+      case EVAS_CALLBACK_MULTI_UP:
+         st->t_up = pe_local.timestamp;       /* Record recent up event time */
+         if ((cnt > 1) ||     /* Ignore if more fingers touch surface        */
+               (!st->t_st_x)) /* IGNORE if info was cleared, long press,move */
            return;
-         state_to_report = ELM_GESTURE_STATE_END;
 
-         if ((pe->timestamp - ELM_GESTURE_MOMENTUM_TIMEOUT) > st->t_end)
+         if ((pe_local.timestamp - ELM_GESTURE_MOMENTUM_TIMEOUT) > st->t_end)
            {  /* Too long of a wait, reset all values */
-              st->line_st.x = pe->x;
-              st->line_st.y = pe->y;
-              st->t_st_y = st->t_st_x = pe->timestamp;
+              st->line_st.x = pe_local.x;
+              st->line_st.y = pe_local.y;
+              st->t_st_y = st->t_st_x = pe_local.timestamp;
               st->xdir = st->ydir = 0;
            }
 
-         st->info.x2 = pe->x;
-         st->info.y2 = pe->y;
-         st->line_end.x = pe->x;
-         st->line_end.y = pe->y;
-         st->t_end = pe->timestamp;
-
-         _set_momentum(&st->info, st->line_st.x, st->line_st.y, pe->x, pe->y,
-               st->t_st_x, st->t_st_y, pe->timestamp);
-
-         ev_flag = _set_state(gesture, state_to_report, &st->info,
-               EINA_FALSE);
-         consume_event(wd, event_info, event_type, ev_flag);
+         st->info.x2 = pe_local.x;
+         st->info.y2 = pe_local.y;
+         st->line_end.x = pe_local.x;
+         st->line_end.y = pe_local.y;
+         st->t_end = pe_local.timestamp;
 
-         return;
+         _set_momentum(&st->info, st->line_st.x, st->line_st.y, pe_local.x, pe_local.y,
+               st->t_st_x, st->t_st_y, pe_local.timestamp);
 
-      case EVAS_CALLBACK_MULTI_UP:
-         ev_flag = _set_state(gesture, ELM_GESTURE_STATE_ABORT, &st->info,
+         ev_flag = _set_state(gesture, ELM_GESTURE_STATE_END, &st->info,
                EINA_FALSE);
          consume_event(wd, event_info, event_type, ev_flag);
          return;
@@ -2040,7 +2091,7 @@ _n_line_test(Evas_Object *obj, Pointer_Event *pe, void *event_info,
           }
      }
 
-   st->info.n = started;
+   st->info.momentum.n = started;
 
 
    if (ended &&
@@ -2663,7 +2714,7 @@ _rotate_test(Evas_Object *obj, Pointer_Event *pe, void *event_info,
    if (!wd->gesture[g_type]) return;
 
    Gesture_Info *gesture = wd->gesture[g_type];
-   Rotate_Type *st = gesture->data;
+   Rotate_Type *st;
    if (gesture)
    {
       st = gesture->data;
@@ -2820,6 +2871,7 @@ _make_pointer_event(void *data, void *event_info,
    Widget_Data *wd = elm_widget_data_get(data);
    if (!wd) return EINA_FALSE;
 
+   memset(pe, '\0', sizeof(*pe));
    switch (event_type)
      {
       case EVAS_CALLBACK_MOUSE_DOWN:
@@ -2897,18 +2949,18 @@ void continues_gestures_restart(void *data, Eina_Bool states_reset)
 
    /* Run through events to restart gestures */
    Gesture_Info *g;
-   Eina_Bool n_lines, n_flicks, zoom, rotate;
-#if defined(DEBUG_GESTURE_LAYER)
-   int i;
-   printf("Gesture | State | is tested\n");
-   for(i = ELM_GESTURE_N_TAPS; i < ELM_GESTURE_LAST; i++)
+   Eina_Bool n_momentum, n_lines, n_flicks, zoom, rotate;
+   /* We turn-on flag for finished, aborted, not-started gestures */
+   g = wd->gesture[ELM_GESTURE_MOMENTUM];
+   n_momentum = (g) ? ((states_reset) | ((g->state != ELM_GESTURE_STATE_START)
+         && (g->state != ELM_GESTURE_STATE_MOVE))) : EINA_FALSE;
+   if (n_momentum)
      {
-        g = wd->gesture[i];
-        if(g)
-          printf("   %d       %d       %d\n", i, g->state, g->test);
+        _momentum_test_reset(wd->gesture[ELM_GESTURE_MOMENTUM]);
+        _set_state(g, ELM_GESTURE_STATE_UNDEFINED, NULL, EINA_FALSE);
+        SET_TEST_BIT(g);
      }
-#endif
-   /* We turn-on flag for finished, aborted, not-started gestures */
+
    g = wd->gesture[ELM_GESTURE_N_LINES];
    n_lines = (g) ? ((states_reset) | ((g->state != ELM_GESTURE_STATE_START)
          && (g->state != ELM_GESTURE_STATE_MOVE))) : EINA_FALSE;
@@ -2982,25 +3034,30 @@ _event_process(void *data, Evas_Object *obj __UNUSED__,
    Widget_Data *wd = elm_widget_data_get(data);
    if (!wd) return;
 
+#if defined(DEBUG_GESTURE_LAYER)
+   int i;
+   Gesture_Info *g;
+   printf("Gesture | State | is tested\n");
+   for(i = ELM_GESTURE_N_TAPS; i < ELM_GESTURE_LAST; i++)
+     {
+        g = wd->gesture[i];
+        if(g)
+          printf("   %d       %d       %d\n", i, g->state, g->test);
+     }
+#endif
+
    /* Start testing candidate gesture from here */
    if (_make_pointer_event(data, event_info, event_type, &_pe))
      pe = &_pe;
 
+   if (!pe) return;
+
    if (IS_TESTED(ELM_GESTURE_N_LONG_TAPS))
      _n_long_tap_test(data, pe, event_info, event_type,
            ELM_GESTURE_N_LONG_TAPS);
 
-   if (IS_TESTED(ELM_GESTURE_N_TAPS))
-     _dbl_click_test(data, pe, event_info, event_type,
-           ELM_GESTURE_N_TAPS, 1);
-
-   if (IS_TESTED(ELM_GESTURE_N_DOUBLE_TAPS))
-     _dbl_click_test(data, pe, event_info, event_type,
-           ELM_GESTURE_N_DOUBLE_TAPS, 2);
-
-   if (IS_TESTED(ELM_GESTURE_N_TRIPLE_TAPS))
-     _dbl_click_test(data, pe, event_info, event_type,
-           ELM_GESTURE_N_TRIPLE_TAPS, 3);
+   /* This takes care of single, double and tripple tap */
+   _tap_gestures_test(data, pe, event_info, event_type);
 
    if (IS_TESTED(ELM_GESTURE_MOMENTUM))
      _momentum_test(data, pe, event_info, event_type,
@@ -3012,7 +3069,7 @@ _event_process(void *data, Evas_Object *obj __UNUSED__,
    if (IS_TESTED(ELM_GESTURE_N_FLICKS))
      _n_line_test(data, pe, event_info, event_type, ELM_GESTURE_N_FLICKS);
 
-   if (IS_TESTED(ELM_GESTURE_ZOOM))
+   if (_elm_config->glayer_zoom_finger_enable && IS_TESTED(ELM_GESTURE_ZOOM))
      _zoom_test(data, pe, event_info, event_type, ELM_GESTURE_ZOOM);
 
    if (IS_TESTED(ELM_GESTURE_ZOOM))
@@ -3034,9 +3091,6 @@ _event_process(void *data, Evas_Object *obj __UNUSED__,
           }
      }
 
-   /* Log event to restart gestures */
-   wd->recent_device_event = _add_recent_device_event(wd->recent_device_event, &_pe);
-
    /* we maintain list of touched devices              */
    /* We also use move to track current device x.y pos */
    if ((event_type == EVAS_CALLBACK_MOUSE_DOWN) ||
@@ -3261,12 +3315,8 @@ elm_gesture_layer_add(Evas_Object *parent)
    Evas *e;
    Widget_Data *wd;
 
-   EINA_SAFETY_ON_NULL_RETURN_VAL(parent, NULL);
+   ELM_WIDGET_STANDARD_SETUP(wd, Widget_Data, parent, e, obj, NULL);
 
-   wd = ELM_NEW(Widget_Data);
-   e = evas_object_evas_get(parent);
-   if (!e) return NULL;
-   obj = elm_widget_add(e);
    ELM_SET_WIDTYPE(widtype, "gesture_layer");
    elm_widget_type_set(obj, "gesture_layer");
    elm_widget_sub_object_add(parent, obj);