iptables: Refactoring how jumps are handled
[framework/connectivity/connman.git] / src / iptables.c
index 6860fdd..48d7214 100644 (file)
@@ -242,38 +242,16 @@ static GList *find_chain_head(struct connman_iptables *table,
 static GList *find_chain_tail(struct connman_iptables *table,
                                char *chain_name)
 {
+       struct connman_iptables_entry *tail;
        GList *chain_head, *list;
-       struct connman_iptables_entry *head, *tail;
-       struct ipt_entry *entry;
-       struct xt_entry_target *target;
-       int builtin;
-
-       /* First we look for the head */
-       for (list = table->entries; list; list = list->next) {
-               head = list->data;
-               entry = head->entry;
-
-               /* Buit-in chain */
-               builtin = head->builtin;
-               if (builtin >= 0 && !strcmp(hooknames[builtin], chain_name))
-                       break;
 
-               /* User defined chain */
-               target = ipt_get_target(entry);
-               if (!strcmp(target->u.user.name, IPT_ERROR_TARGET) &&
-                   !strcmp((char *)target->data, chain_name))
-                       break;
-       }
-
-       if (list == NULL)
+       chain_head = find_chain_head(table, chain_name);
+       if (chain_head == NULL)
                return NULL;
 
-       chain_head = list;
-
        /* Then we look for the next chain */
        for (list = chain_head->next; list; list = list->next) {
                tail = list->data;
-               entry = tail->entry;
 
                if (is_chain(table, tail))
                        return list;
@@ -337,10 +315,10 @@ static int iptables_add_entry(struct connman_iptables *table,
        entry_before = before->data;
 
        /*
-        * We've just insterted a new entry. All references before it
+        * We've just appended/insterted a new entry. All references
         * should be bumped accordingly.
         */
-       for (list = table->entries; list != before; list = list->next) {
+       for (list = table->entries; list; list = list->next) {
                tmp = list->data;
 
                if (!is_jump(tmp))
@@ -348,7 +326,7 @@ static int iptables_add_entry(struct connman_iptables *table,
 
                t = (struct xt_standard_target *)ipt_get_target(tmp->entry);
 
-               if (t->verdict >= entry_before->offset)
+               if (t->verdict > entry_before->offset)
                        t->verdict += entry->next_offset;
        }
 
@@ -357,6 +335,22 @@ static int iptables_add_entry(struct connman_iptables *table,
        return 0;
 }
 
+static int remove_table_entry(struct connman_iptables *table,
+                               struct connman_iptables_entry *entry)
+{
+       int removed = 0;
+
+       table->num_entries--;
+       table->size -= entry->entry->next_offset;
+       removed = entry->entry->next_offset;
+
+       g_free(entry->entry);
+
+       table->entries = g_list_remove(table->entries, entry);
+
+       return removed;
+}
+
 static int iptables_flush_chain(struct connman_iptables *table,
                                                char *name)
 {
@@ -387,13 +381,7 @@ static int iptables_flush_chain(struct connman_iptables *table,
                entry = list->data;
                next = g_list_next(list);
 
-               table->num_entries--;
-               table->size -= entry->entry->next_offset;
-               removed += entry->entry->next_offset;
-
-               g_free(entry->entry);
-
-               table->entries = g_list_remove(table->entries, list->data);
+               removed += remove_table_entry(table, entry);
 
                list = next;
        }
@@ -450,7 +438,7 @@ static int iptables_add_chain(struct connman_iptables *table,
                                sizeof(struct error_target);
        entry_head = g_try_malloc0(entry_head_size);
        if (entry_head == NULL)
-               goto err;
+               goto err_head;
 
        memset(entry_head, 0, entry_head_size);
 
@@ -463,7 +451,7 @@ static int iptables_add_chain(struct connman_iptables *table,
        strcpy(error->error, name);
 
        if (iptables_add_entry(table, entry_head, last, -1) < 0)
-               goto err;
+               goto err_head;
 
        /* tail entry */
        entry_return_size = sizeof(struct ipt_entry) +
@@ -488,20 +476,53 @@ static int iptables_add_chain(struct connman_iptables *table,
        return 0;
 
 err:
-       g_free(entry_head);
        g_free(entry_return);
+err_head:
+       g_free(entry_head);
 
        return -ENOMEM;
 }
 
+static int iptables_delete_chain(struct connman_iptables *table, char *name)
+{
+       struct connman_iptables_entry *entry;
+       GList *chain_head, *chain_tail;
+
+       chain_head = find_chain_head(table, name);
+       if (chain_head == NULL)
+               return -EINVAL;
+
+       entry = chain_head->data;
+
+       /* We cannot remove builtin chain */
+       if (entry->builtin >= 0)
+               return -EINVAL;
+
+       chain_tail = find_chain_tail(table, name);
+       if (chain_tail == NULL)
+               return -EINVAL;
+
+       /* Chain must be flushed */
+       if (chain_head->next != chain_tail->prev)
+               return -EINVAL;
+
+       remove_table_entry(table, entry);
+
+       entry = chain_tail->prev->data;
+       remove_table_entry(table, entry);
+
+       update_offsets(table);
+
+       return 0;
+}
+
 static struct ipt_entry *
-new_rule(struct connman_iptables *table, struct ipt_ip *ip,
-               char *target_name, struct xtables_target *xt_t,
+new_rule(struct ipt_ip *ip, char *target_name,
+               struct xtables_target *xt_t,
                char *match_name, struct xtables_match *xt_m)
 {
        struct ipt_entry *new_entry;
        size_t match_size, target_size;
-       int is_builtin = is_builtin_target(target_name);
 
        if (xt_m)
                match_size = xt_m->m->u.match_size;
@@ -533,40 +554,8 @@ new_rule(struct connman_iptables *table, struct ipt_ip *ip,
        if (xt_t) {
                struct xt_entry_target *entry_target;
 
-               if (is_builtin) {
-                       struct xt_standard_target *target;
-
-                       target = (struct xt_standard_target *)(xt_t->t);
-                       strcpy(target->target.u.user.name, IPT_STANDARD_TARGET);
-                       target->verdict = target_to_verdict(target_name);
-               }
-
                entry_target = ipt_get_target(new_entry);
                memcpy(entry_target, xt_t->t, target_size);
-       } else {
-               struct connman_iptables_entry *target_rule;
-               struct xt_standard_target *target;
-               GList *chain_head;
-
-               /*
-                * This is a user defined target, i.e. a chain jump.
-                * We search for the chain head, and the target verdict
-                * is the first rule's offset on this chain.
-                * The offset is from the beginning of the table.
-                */
-
-               chain_head = find_chain_head(table, target_name);
-               if (chain_head == NULL || chain_head->next == NULL) {
-                       g_free(new_entry);
-                       return NULL;
-               }
-
-               target_rule = chain_head->next->data;
-
-               target = (struct xt_standard_target *)ipt_get_target(new_entry);
-               strcpy(target->target.u.user.name, IPT_STANDARD_TARGET);
-               target->target.u.user.target_size = target_size;
-               target->verdict = target_rule->offset;
        }
 
        return new_entry;
@@ -602,32 +591,27 @@ static void update_hooks(struct connman_iptables *table, GList *chain_head,
        }
 }
 
-static int
-iptables_add_rule(struct connman_iptables *table,
+static struct ipt_entry *prepare_rule_inclusion(struct connman_iptables *table,
                                struct ipt_ip *ip, char *chain_name,
                                char *target_name, struct xtables_target *xt_t,
-                               char *match_name, struct xtables_match *xt_m)
+                               char *match_name, struct xtables_match *xt_m,
+                               int *builtin)
 {
        GList *chain_tail, *chain_head;
        struct ipt_entry *new_entry;
        struct connman_iptables_entry *head;
-       int builtin = -1;
-
-       DBG("");
 
        chain_head = find_chain_head(table, chain_name);
        if (chain_head == NULL)
-               return -EINVAL;
+               return NULL;
 
        chain_tail = find_chain_tail(table, chain_name);
        if (chain_tail == NULL)
-               return -EINVAL;
+               return NULL;
 
-       new_entry = new_rule(table, ip,
-                               target_name, xt_t,
-                               match_name, xt_m);
+       new_entry = new_rule(ip, target_name, xt_t, match_name, xt_m);
        if (new_entry == NULL)
-               return -EINVAL;
+               return NULL;
 
        update_hooks(table, chain_head, new_entry);
 
@@ -638,13 +622,65 @@ iptables_add_rule(struct connman_iptables *table,
         */
        head = chain_head->data;
        if (head->builtin < 0)
-               builtin = -1;
+               *builtin = -1;
        else if (chain_head == chain_tail->prev) {
-               builtin = head->builtin;
+               *builtin = head->builtin;
                head->builtin = -1;
        }
 
-       return iptables_add_entry(table, new_entry, chain_tail->prev, builtin);
+       return new_entry;
+}
+
+static int iptables_append_rule(struct connman_iptables *table,
+                               struct ipt_ip *ip, char *chain_name,
+                               char *target_name, struct xtables_target *xt_t,
+                               char *match_name, struct xtables_match *xt_m)
+{
+       GList *chain_tail;
+       struct ipt_entry *new_entry;
+       int builtin = -1, ret;
+
+       DBG("");
+
+       chain_tail = find_chain_tail(table, chain_name);
+       if (chain_tail == NULL)
+               return -EINVAL;
+
+       new_entry = prepare_rule_inclusion(table, ip, chain_name,
+                       target_name, xt_t, match_name, xt_m, &builtin);
+       if (new_entry == NULL)
+               return -EINVAL;
+
+       ret = iptables_add_entry(table, new_entry, chain_tail->prev, builtin);
+       if (ret < 0)
+               g_free(new_entry);
+
+       return ret;
+}
+
+static int iptables_insert_rule(struct connman_iptables *table,
+                               struct ipt_ip *ip, char *chain_name,
+                               char *target_name, struct xtables_target *xt_t,
+                               char *match_name, struct xtables_match *xt_m)
+{
+       struct ipt_entry *new_entry;
+       int builtin = -1, ret;
+       GList *chain_head;
+
+       chain_head = find_chain_head(table, chain_name);
+       if (chain_head == NULL)
+               return -EINVAL;
+
+       new_entry = prepare_rule_inclusion(table, ip, chain_name,
+                       target_name, xt_t, match_name, xt_m, &builtin);
+       if (new_entry == NULL)
+               return -EINVAL;
+
+       ret = iptables_add_entry(table, new_entry, chain_head->next, builtin);
+       if (ret < 0)
+               g_free(new_entry);
+
+       return ret;
 }
 
 static struct ipt_replace *
@@ -902,6 +938,7 @@ static void table_cleanup(struct connman_iptables *table)
                entry = list->data;
 
                g_free(entry->entry);
+               g_free(entry);
        }
 
        g_list_free(table->entries);
@@ -974,11 +1011,78 @@ err:
        return NULL;
 }
 
+static struct xtables_target *prepare_target(struct connman_iptables *table,
+                                                       char *target_name)
+{
+       struct xtables_target *xt_t = NULL;
+       gboolean is_builtin, is_user_defined;
+       GList *chain_head = NULL;
+       size_t target_size;
+
+       is_builtin = FALSE;
+       is_user_defined = FALSE;
+
+       if (is_builtin_target(target_name))
+               is_builtin = TRUE;
+       else {
+               chain_head = find_chain_head(table, target_name);
+               if (chain_head != NULL && chain_head->next != NULL)
+                       is_user_defined = TRUE;
+       }
+
+       if (is_builtin || is_user_defined)
+               xt_t = xtables_find_target(IPT_STANDARD_TARGET,
+                                               XTF_LOAD_MUST_SUCCEED);
+       else
+               xt_t = xtables_find_target(target_name, XTF_TRY_LOAD);
+
+       if (xt_t == NULL)
+               return NULL;
+
+       target_size = ALIGN(sizeof(struct ipt_entry_target)) + xt_t->size;
+
+       xt_t->t = g_try_malloc0(target_size);
+       if (xt_t->t == NULL)
+               return NULL;
+
+       xt_t->t->u.target_size = target_size;
+
+       if (is_builtin || is_user_defined) {
+               struct xt_standard_target *target;
+
+               target = (struct xt_standard_target *)(xt_t->t);
+               strcpy(target->target.u.user.name, IPT_STANDARD_TARGET);
+
+               if (is_builtin == TRUE)
+                       target->verdict = target_to_verdict(target_name);
+               else if (is_user_defined == TRUE) {
+                       struct connman_iptables_entry *target_rule;
+
+                       if (chain_head == NULL) {
+                               g_free(xt_t->t);
+                               return NULL;
+                       }
+
+                       target_rule = chain_head->next->data;
+                       target->verdict = target_rule->offset;
+               }
+       } else {
+               strcpy(xt_t->t->u.user.name, target_name);
+               xt_t->t->u.user.revision = xt_t->revision;
+               if (xt_t->init != NULL)
+                       xt_t->init(xt_t->t);
+       }
+
+       return xt_t;
+}
+
 static struct option iptables_opts[] = {
        {.name = "append",        .has_arg = 1, .val = 'A'},
        {.name = "flush-chain",   .has_arg = 1, .val = 'F'},
+       {.name = "insert",        .has_arg = 1, .val = 'I'},
        {.name = "list",          .has_arg = 2, .val = 'L'},
        {.name = "new-chain",     .has_arg = 1, .val = 'N'},
+       {.name = "delete-chain",  .has_arg = 1, .val = 'X'},
        {.name = "destination",   .has_arg = 1, .val = 'd'},
        {.name = "in-interface",  .has_arg = 1, .val = 'i'},
        {.name = "jump",          .has_arg = 1, .val = 'j'},
@@ -1002,10 +1106,10 @@ static int iptables_command(int argc, char *argv[])
        struct xtables_target *xt_t;
        struct ipt_ip ip;
        char *table_name, *chain, *new_chain, *match_name, *target_name;
-       char *flush_chain;
+       char *flush_chain, *delete_chain;
        int c, ret, in_len, out_len;
        size_t size;
-       gboolean dump, invert;
+       gboolean dump, invert, insert;
        struct in_addr src, dst;
 
        if (argc == 0)
@@ -1013,8 +1117,9 @@ static int iptables_command(int argc, char *argv[])
 
        dump = FALSE;
        invert = FALSE;
+       insert = FALSE;
        table_name = chain = new_chain = match_name = target_name = NULL;
-       flush_chain = NULL;
+       flush_chain = delete_chain = NULL;
        memset(&ip, 0, sizeof(struct ipt_ip));
        table = NULL;
        xt_m = NULL;
@@ -1023,10 +1128,14 @@ static int iptables_command(int argc, char *argv[])
 
        optind = 0;
 
-       while ((c = getopt_long(argc, argv,
-          "-A:F:L::N:d:j:i:m:o:s:t:", iptables_globals.opts, NULL)) != -1) {
+       while ((c = getopt_long(argc, argv, "-A:F:I:L::N:X:d:j:i:m:o:s:t:",
+                                       iptables_globals.opts, NULL)) != -1) {
                switch (c) {
                case 'A':
+                       /* It is either -A, -D or -I at once */
+                       if (chain)
+                               goto out;
+
                        chain = optarg;
                        break;
 
@@ -1034,6 +1143,15 @@ static int iptables_command(int argc, char *argv[])
                        flush_chain = optarg;
                        break;
 
+               case 'I':
+                       /* It is either -A, -D or -I at once */
+                       if (chain)
+                               goto out;
+
+                       chain = optarg;
+                       insert = TRUE;
+                       break;
+
                case 'L':
                        dump = TRUE;
                        break;
@@ -1042,6 +1160,10 @@ static int iptables_command(int argc, char *argv[])
                        new_chain = optarg;
                        break;
 
+               case 'X':
+                       delete_chain = optarg;
+                       break;
+
                case 'd':
                        if (!inet_pton(AF_INET, optarg, &dst))
                                break;
@@ -1070,29 +1192,6 @@ static int iptables_command(int argc, char *argv[])
 
                case 'j':
                        target_name = optarg;
-                       xt_t = xtables_find_target(target_name, XTF_TRY_LOAD);
-
-                       if (xt_t == NULL)
-                               break;
-
-                       size = ALIGN(sizeof(struct ipt_entry_target)) +
-                                                               xt_t->size;
-
-                       xt_t->t = g_try_malloc0(size);
-                       if (xt_t->t == NULL)
-                               goto out;
-                       xt_t->t->u.target_size = size;
-                       strcpy(xt_t->t->u.user.name, target_name);
-                       xt_t->t->u.user.revision = xt_t->revision;
-                       if (xt_t->init != NULL)
-                               xt_t->init(xt_t->t);
-                       iptables_globals.opts =
-                               xtables_merge_options(iptables_globals.opts,
-                                                    xt_t->extra_opts,
-                                                    &xt_t->option_offset);
-                       if (iptables_globals.opts == NULL)
-                               goto out;
-
                        break;
 
                case 'm':
@@ -1111,7 +1210,11 @@ static int iptables_command(int argc, char *argv[])
                                xt_m->init(xt_m->m);
                        if (xt_m != xt_m->next) {
                                iptables_globals.opts =
-                               xtables_merge_options(iptables_globals.opts,
+                               xtables_merge_options(
+#if XTABLES_VERSION_CODE > 5
+                                               iptables_globals.orig_opts,
+#endif
+                                               iptables_globals.opts,
                                                xt_m->extra_opts,
                                                &xt_m->option_offset);
                                if (iptables_globals.opts == NULL)
@@ -1188,6 +1291,14 @@ static int iptables_command(int argc, char *argv[])
                goto out;
        }
 
+       if (delete_chain != NULL) {
+               printf("Delete chain %s\n", delete_chain);
+
+               iptables_delete_chain(table, delete_chain);
+
+               goto out;
+       }
+
        if (dump) {
                iptables_dump(table);
 
@@ -1216,16 +1327,38 @@ static int iptables_command(int argc, char *argv[])
        }
 
        if (chain) {
-               if (target_name == NULL)
-                       return -1;
+               xt_t = prepare_target(table, target_name);
+               if (xt_t == NULL)
+                       goto out;
 
-               DBG("Adding %s to %s (match %s)",
-                               target_name, chain, match_name);
+               iptables_globals.opts =
+                       xtables_merge_options(
+#if XTABLES_VERSION_CODE > 5
+                                       iptables_globals.orig_opts,
+#endif
+                                       iptables_globals.opts,
+                                       xt_t->extra_opts,
+                                       &xt_t->option_offset);
+               if (iptables_globals.opts == NULL)
+                       goto out;
 
-               ret = iptables_add_rule(table, &ip, chain, target_name, xt_t,
-                                       match_name, xt_m);
+               if (insert == TRUE) {
+                       DBG("Inserting %s to %s (match %s)",
+                                       target_name, chain, match_name);
 
-               goto out;
+                       ret = iptables_insert_rule(table, &ip, chain,
+                                       target_name, xt_t, match_name, xt_m);
+
+                       goto out;
+               } else {
+                       DBG("Adding %s to %s (match %s)",
+                                       target_name, chain, match_name);
+
+                       ret = iptables_append_rule(table, &ip, chain,
+                                       target_name, xt_t, match_name, xt_m);
+
+                       goto out;
+               }
        }
 
 out:
@@ -1300,6 +1433,7 @@ int __connman_iptables_commit(const char *table_name)
 
        err = iptables_replace(table, repl);
 
+       g_free(repl->counters);
        g_free(repl);
 
        if (err < 0)
@@ -1332,6 +1466,8 @@ int __connman_iptables_init(void)
 
 void __connman_iptables_cleanup(void)
 {
+       DBG("");
+
        g_hash_table_destroy(table_hash);
 
        xtables_free_opts(1);