Fix regression when removing watches
[framework/connectivity/connman.git] / src / device.c
index 53a6bd6..0d41863 100644 (file)
@@ -2,7 +2,7 @@
  *
  *  Connection Manager
  *
- *  Copyright (C) 2007-2009  Intel Corporation. All rights reserved.
+ *  Copyright (C) 2007-2010  Intel Corporation. All rights reserved.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License version 2 as
@@ -36,11 +36,14 @@ struct connman_device {
        struct connman_element element;
        enum connman_device_type type;
        enum connman_device_mode mode;
-       connman_bool_t secondary;
+       connman_bool_t offlinemode;
+       connman_bool_t blocked;
        connman_bool_t powered;
-       connman_bool_t carrier;
+       connman_bool_t powered_pending;
+       connman_bool_t powered_persistent;
        connman_bool_t scanning;
        connman_bool_t disconnected;
+       connman_bool_t reconnect;
        connman_uint16_t scan_interval;
        char *name;
        char *node;
@@ -48,9 +51,9 @@ struct connman_device {
        char *interface;
        char *control;
        char *ident;
+       int phyindex;
        unsigned int connections;
        guint scan_timeout;
-       struct connman_ipconfig *ipconfig;
 
        struct connman_device_driver *driver;
        void *driver_data;
@@ -82,12 +85,17 @@ static gboolean device_scan_trigger(gpointer user_data)
        return TRUE;
 }
 
-static void reset_scan_trigger(struct connman_device *device)
+static void clear_scan_trigger(struct connman_device *device)
 {
        if (device->scan_timeout > 0) {
                g_source_remove(device->scan_timeout);
                device->scan_timeout = 0;
        }
+}
+
+static void reset_scan_trigger(struct connman_device *device)
+{
+       clear_scan_trigger(device);
 
        if (device->scan_interval > 0) {
                guint interval = device->scan_interval;
@@ -96,6 +104,19 @@ static void reset_scan_trigger(struct connman_device *device)
        }
 }
 
+static void force_scan_trigger(struct connman_device *device)
+{
+       clear_scan_trigger(device);
+
+       device->scan_timeout = g_timeout_add_seconds(5,
+                                       device_scan_trigger, device);
+}
+
+void connman_device_schedule_scan(struct connman_device *device)
+{
+       reset_scan_trigger(device);
+}
+
 static const char *type2description(enum connman_device_type type)
 {
        switch (type) {
@@ -112,11 +133,9 @@ static const char *type2description(enum connman_device_type type)
                return "Bluetooth";
        case CONNMAN_DEVICE_TYPE_GPS:
                return "GPS";
+       case CONNMAN_DEVICE_TYPE_CELLULAR:
        case CONNMAN_DEVICE_TYPE_MBM:
        case CONNMAN_DEVICE_TYPE_HSO:
-       case CONNMAN_DEVICE_TYPE_NOZOMI:
-       case CONNMAN_DEVICE_TYPE_HUAWEI:
-       case CONNMAN_DEVICE_TYPE_NOVATEL:
                return "Cellular";
        }
 
@@ -139,11 +158,9 @@ static const char *type2string(enum connman_device_type type)
                return "bluetooth";
        case CONNMAN_DEVICE_TYPE_GPS:
                return "gps";
+       case CONNMAN_DEVICE_TYPE_CELLULAR:
        case CONNMAN_DEVICE_TYPE_MBM:
        case CONNMAN_DEVICE_TYPE_HSO:
-       case CONNMAN_DEVICE_TYPE_HUAWEI:
-       case CONNMAN_DEVICE_TYPE_NOZOMI:
-       case CONNMAN_DEVICE_TYPE_NOVATEL:
                return "cellular";
        }
 
@@ -158,9 +175,6 @@ enum connman_service_type __connman_device_get_service_type(struct connman_devic
        case CONNMAN_DEVICE_TYPE_UNKNOWN:
        case CONNMAN_DEVICE_TYPE_VENDOR:
        case CONNMAN_DEVICE_TYPE_GPS:
-       case CONNMAN_DEVICE_TYPE_NOZOMI:
-       case CONNMAN_DEVICE_TYPE_HUAWEI:
-       case CONNMAN_DEVICE_TYPE_NOVATEL:
                break;
        case CONNMAN_DEVICE_TYPE_ETHERNET:
                return CONNMAN_SERVICE_TYPE_ETHERNET;
@@ -170,6 +184,7 @@ enum connman_service_type __connman_device_get_service_type(struct connman_devic
                return CONNMAN_SERVICE_TYPE_WIMAX;
        case CONNMAN_DEVICE_TYPE_BLUETOOTH:
                return CONNMAN_SERVICE_TYPE_BLUETOOTH;
+       case CONNMAN_DEVICE_TYPE_CELLULAR:
        case CONNMAN_DEVICE_TYPE_MBM:
        case CONNMAN_DEVICE_TYPE_HSO:
                return CONNMAN_SERVICE_TYPE_CELLULAR;
@@ -178,110 +193,11 @@ enum connman_service_type __connman_device_get_service_type(struct connman_devic
        return CONNMAN_SERVICE_TYPE_UNKNOWN;
 }
 
-static int set_connected(struct connman_device *device,
-                                               connman_bool_t connected)
-{
-       if (connected == TRUE) {
-               enum connman_element_type type = CONNMAN_ELEMENT_TYPE_UNKNOWN;
-               struct connman_element *element;
-
-               device->disconnected = TRUE;
-
-               switch (device->element.ipv4.method) {
-               case CONNMAN_IPCONFIG_METHOD_UNKNOWN:
-               case CONNMAN_IPCONFIG_METHOD_OFF:
-                       return 0;
-               case CONNMAN_IPCONFIG_METHOD_STATIC:
-                       type = CONNMAN_ELEMENT_TYPE_IPV4;
-                       break;
-               case CONNMAN_IPCONFIG_METHOD_DHCP:
-                       type = CONNMAN_ELEMENT_TYPE_DHCP;
-                       break;
-               }
-
-               element = connman_element_create(NULL);
-               if (element != NULL) {
-                       struct connman_service *service;
-
-                       element->type  = type;
-                       element->index = device->element.index;
-
-                       if (connman_element_register(element,
-                                                       &device->element) < 0)
-                               connman_element_unref(element);
-
-                       device->disconnected = FALSE;
-
-                       service = __connman_service_lookup_from_device(device);
-                       __connman_service_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_CONFIGURATION);
-               }
-       } else {
-               struct connman_service *service;
-
-               connman_element_unregister_children(&device->element);
-
-               device->disconnected = TRUE;
-
-               service = __connman_service_lookup_from_device(device);
-               __connman_service_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_IDLE);
-       }
-
-       if (connected == TRUE) {
-               enum connman_service_type type;
-
-               type = __connman_device_get_service_type(device);
-               __connman_notifier_connect(type);
-       } else {
-               enum connman_service_type type;
-
-               type = __connman_device_get_service_type(device);
-               __connman_notifier_disconnect(type);
-       }
-
-       return 0;
-}
-
-static int set_carrier(struct connman_device *device, connman_bool_t carrier)
-{
-       struct connman_service *service;
-
-       if (carrier == TRUE)
-               __connman_profile_add_device(device);
-       else
-               __connman_profile_remove_device(device);
-
-       service = __connman_service_lookup_from_device(device);
-       __connman_service_set_carrier(service, carrier);
-
-       return set_connected(device, carrier);
-}
-
-static int powered_changed(struct connman_device *device)
+static void powered_changed(struct connman_device *device)
 {
-       DBusMessage *signal;
-       DBusMessageIter entry, value;
-       const char *key = "Powered";
-
-       signal = dbus_message_new_signal(device->element.path,
-                               CONNMAN_DEVICE_INTERFACE, "PropertyChanged");
-       if (signal == NULL)
-               return -ENOMEM;
-
-       dbus_message_iter_init_append(signal, &entry);
-
-       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key);
-
-       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
-                                       DBUS_TYPE_BOOLEAN_AS_STRING, &value);
-       dbus_message_iter_append_basic(&value, DBUS_TYPE_BOOLEAN,
-                                                       &device->powered);
-       dbus_message_iter_close_container(&entry, &value);
-
-       g_dbus_send_message(connection, signal);
-
-       return 0;
+       connman_dbus_property_changed_basic(device->element.path,
+                               CONNMAN_DEVICE_INTERFACE, "Powered",
+                                       DBUS_TYPE_BOOLEAN, &device->powered);
 }
 
 static int set_powered(struct connman_device *device, connman_bool_t powered)
@@ -292,7 +208,7 @@ static int set_powered(struct connman_device *device, connman_bool_t powered)
 
        DBG("device %p powered %d", device, powered);
 
-       if (device->powered == powered)
+       if (device->powered_pending == powered)
                return -EALREADY;
 
        if (!driver)
@@ -302,15 +218,21 @@ static int set_powered(struct connman_device *device, connman_bool_t powered)
 
        if (powered == TRUE) {
                if (driver->enable) {
+                       device->powered_pending = powered;
+
                        err = driver->enable(device);
                        if (err == 0)
                                __connman_notifier_enable(type);
                } else
                        err = -EINVAL;
        } else {
-               g_hash_table_remove_all(device->networks);
+               device->powered_pending = powered;
+
+               device->reconnect = FALSE;
 
-               set_carrier(device, FALSE);
+               clear_scan_trigger(device);
+
+               g_hash_table_remove_all(device->networks);
 
                if (driver->disable) {
                        err = driver->disable(device);
@@ -322,12 +244,19 @@ static int set_powered(struct connman_device *device, connman_bool_t powered)
 
        if (err == 0) {
                device->powered = powered;
-               powered_changed(device);
+
+               if (device->registered == TRUE)
+                       powered_changed(device);
        }
 
        return err;
 }
 
+void __connman_device_list(DBusMessageIter *iter, void *user_data)
+{
+       __connman_element_list(NULL, CONNMAN_ELEMENT_TYPE_DEVICE, iter);
+}
+
 static void append_path(gpointer key, gpointer value, gpointer user_data)
 {
        struct connman_element *element = value;
@@ -337,24 +266,11 @@ static void append_path(gpointer key, gpointer value, gpointer user_data)
                                                        &element->path);
 }
 
-static void append_networks(struct connman_device *device,
-                                               DBusMessageIter *entry)
+static void append_networks(DBusMessageIter *iter, void *user_data)
 {
-       DBusMessageIter value, iter;
-       const char *key = "Networks";
-
-       dbus_message_iter_append_basic(entry, DBUS_TYPE_STRING, &key);
-
-       dbus_message_iter_open_container(entry, DBUS_TYPE_VARIANT,
-               DBUS_TYPE_ARRAY_AS_STRING DBUS_TYPE_OBJECT_PATH_AS_STRING,
-                                                               &value);
-
-       dbus_message_iter_open_container(&value, DBUS_TYPE_ARRAY,
-                               DBUS_TYPE_OBJECT_PATH_AS_STRING, &iter);
-       g_hash_table_foreach(device->networks, append_path, &iter);
-       dbus_message_iter_close_container(&value, &iter);
+       struct connman_device *device = user_data;
 
-       dbus_message_iter_close_container(entry, &value);
+       g_hash_table_foreach(device->networks, append_path, iter);
 }
 
 static DBusMessage *get_properties(DBusConnection *conn,
@@ -362,7 +278,7 @@ static DBusMessage *get_properties(DBusConnection *conn,
 {
        struct connman_device *device = data;
        DBusMessage *reply;
-       DBusMessageIter array, dict, entry;
+       DBusMessageIter array, dict;
        const char *str;
 
        DBG("conn %p", conn);
@@ -377,55 +293,47 @@ static DBusMessage *get_properties(DBusConnection *conn,
 
        dbus_message_iter_init_append(reply, &array);
 
-       dbus_message_iter_open_container(&array, DBUS_TYPE_ARRAY,
-                       DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING
-                       DBUS_TYPE_STRING_AS_STRING DBUS_TYPE_VARIANT_AS_STRING
-                       DBUS_DICT_ENTRY_END_CHAR_AS_STRING, &dict);
+       connman_dbus_dict_open(&array, &dict);
 
        if (device->name != NULL)
-               connman_dbus_dict_append_variant(&dict, "Name",
+               connman_dbus_dict_append_basic(&dict, "Name",
                                        DBUS_TYPE_STRING, &device->name);
 
        str = type2string(device->type);
        if (str != NULL)
-               connman_dbus_dict_append_variant(&dict, "Type",
+               connman_dbus_dict_append_basic(&dict, "Type",
                                                DBUS_TYPE_STRING, &str);
 
        if (device->address != NULL)
-               connman_dbus_dict_append_variant(&dict, "Address",
+               connman_dbus_dict_append_basic(&dict, "Address",
                                        DBUS_TYPE_STRING, &device->address);
 
        if (device->interface != NULL)
-               connman_dbus_dict_append_variant(&dict, "Interface",
+               connman_dbus_dict_append_basic(&dict, "Interface",
                                        DBUS_TYPE_STRING, &device->interface);
 
-       connman_dbus_dict_append_variant(&dict, "Powered",
+       connman_dbus_dict_append_basic(&dict, "Powered",
                                        DBUS_TYPE_BOOLEAN, &device->powered);
 
        if (device->driver && device->driver->scan)
-               connman_dbus_dict_append_variant(&dict, "Scanning",
+               connman_dbus_dict_append_basic(&dict, "Scanning",
                                        DBUS_TYPE_BOOLEAN, &device->scanning);
 
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
                break;
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               __connman_element_append_ipv4(&device->element, &dict);
-               break;
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
                if (device->scan_interval > 0)
-                       connman_dbus_dict_append_variant(&dict, "ScanInterval",
+                       connman_dbus_dict_append_basic(&dict, "ScanInterval",
                                DBUS_TYPE_UINT16, &device->scan_interval);
 
-               dbus_message_iter_open_container(&dict, DBUS_TYPE_DICT_ENTRY,
-                                                               NULL, &entry);
-               append_networks(device, &entry);
-               dbus_message_iter_close_container(&dict, &entry);
+               connman_dbus_dict_append_array(&dict, "Networks",
+                               DBUS_TYPE_OBJECT_PATH, append_networks, device);
                break;
        }
 
-       dbus_message_iter_close_container(&array, &dict);
+       connman_dbus_dict_close(&array, &dict);
 
        return reply;
 }
@@ -484,6 +392,10 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                dbus_message_iter_get_basic(&value, &powered);
 
+               device->powered_persistent = powered;
+
+               __connman_storage_save_device(device);
+
                if (device->powered == powered)
                        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 
@@ -507,8 +419,6 @@ static DBusMessage *set_property(DBusConnection *conn,
 
                switch (device->mode) {
                case CONNMAN_DEVICE_MODE_UNKNOWN:
-               case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-                       return __connman_error_invalid_arguments(msg);
                case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
                case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
                        break;
@@ -522,29 +432,13 @@ static DBusMessage *set_property(DBusConnection *conn,
                if (device->scan_interval != interval) {
                        device->scan_interval = interval;
 
-                       reset_scan_trigger(device);
-               }
-       } else if (g_str_has_prefix(name, "IPv4.") == TRUE) {
-               int err;
+                       __connman_storage_save_device(device);
 
-               switch (device->mode) {
-               case CONNMAN_DEVICE_MODE_UNKNOWN:
-               case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
-               case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
-                       return __connman_error_invalid_arguments(msg);
-               case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-                       break;
+                       reset_scan_trigger(device);
                }
-
-               err = __connman_ipconfig_set_ipv4(device->ipconfig,
-                                                       name + 5, &value);
-               if (err < 0)
-                       return __connman_error_failed(msg, -err);
        } else
                return __connman_error_invalid_property(msg);
 
-       __connman_storage_save_device(device);
-
        return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
 }
 
@@ -558,7 +452,6 @@ static DBusMessage *propose_scan(DBusConnection *conn,
 
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
                return __connman_error_not_supported(msg);
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
@@ -585,40 +478,11 @@ static GDBusSignalTable device_signals[] = {
        { },
 };
 
-static void append_devices(DBusMessageIter *entry)
-{
-       DBusMessageIter value, iter;
-       const char *key = "Devices";
-
-       dbus_message_iter_append_basic(entry, DBUS_TYPE_STRING, &key);
-
-       dbus_message_iter_open_container(entry, DBUS_TYPE_VARIANT,
-               DBUS_TYPE_ARRAY_AS_STRING DBUS_TYPE_OBJECT_PATH_AS_STRING,
-                                                               &value);
-
-       dbus_message_iter_open_container(&value, DBUS_TYPE_ARRAY,
-                               DBUS_TYPE_OBJECT_PATH_AS_STRING, &iter);
-       __connman_element_list(NULL, CONNMAN_ELEMENT_TYPE_DEVICE, &iter);
-       dbus_message_iter_close_container(&value, &iter);
-
-       dbus_message_iter_close_container(entry, &value);
-}
-
 static void emit_devices_signal(void)
 {
-       DBusMessage *signal;
-       DBusMessageIter entry;
-
-       signal = dbus_message_new_signal(CONNMAN_MANAGER_PATH,
-                               CONNMAN_MANAGER_INTERFACE, "PropertyChanged");
-       if (signal == NULL)
-               return;
-
-       dbus_message_iter_init_append(signal, &entry);
-
-       append_devices(&entry);
-
-       g_dbus_send_message(connection, signal);
+       connman_dbus_property_changed_array(CONNMAN_MANAGER_PATH,
+                       CONNMAN_MANAGER_INTERFACE, "Devices",
+                       DBUS_TYPE_OBJECT_PATH, __connman_device_list, NULL);
 }
 
 static int register_interface(struct connman_element *element)
@@ -656,48 +520,9 @@ static void unregister_interface(struct connman_element *element)
                                                CONNMAN_DEVICE_INTERFACE);
 }
 
-static void device_enable(struct connman_device *device)
-{
-       DBG("device %p", device);
-
-       if (device->powered == TRUE)
-               return;
-
-       if (device->driver->enable) {
-               if (device->driver->enable(device) == 0) {
-                       enum connman_service_type type;
-
-                       device->powered = TRUE;
-
-                       type = __connman_device_get_service_type(device);
-                       __connman_notifier_enable(type);
-               }
-       }
-}
-
-static void device_disable(struct connman_device *device)
-{
-       DBG("device %p", device);
-
-       if (device->powered == FALSE)
-               return;
-
-       g_hash_table_remove_all(device->networks);
-
-       if (device->driver->disable) {
-               if (device->driver->disable(device) == 0) {
-                       enum connman_service_type type;
-
-                       device->powered = FALSE;
-
-                       type = __connman_device_get_service_type(device);
-                       __connman_notifier_disable(type);
-               }
-       }
-}
-
 static int setup_device(struct connman_device *device)
 {
+       enum connman_service_type type;
        int err;
 
        DBG("device %p", device);
@@ -710,18 +535,19 @@ static int setup_device(struct connman_device *device)
                return err;
        }
 
+       type = __connman_device_get_service_type(device);
+       __connman_notifier_register(type);
+
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
                break;
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               if (device->carrier == TRUE && device->secondary == FALSE)
-                       __connman_profile_add_device(device);
-               break;
        }
 
-       device_enable(device);
+       if (device->offlinemode == FALSE &&
+                               device->powered_persistent == TRUE)
+               __connman_device_enable(device);
 
        return 0;
 }
@@ -751,21 +577,22 @@ static void probe_driver(struct connman_element *element, gpointer user_data)
 
 static void remove_device(struct connman_device *device)
 {
+       enum connman_service_type type;
+
        DBG("device %p", device);
 
-       device_disable(device);
+       __connman_device_disable(device);
 
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
                break;
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               if (device->secondary == FALSE)
-                       __connman_profile_remove_device(device);
-               break;
        }
 
+       type = __connman_device_get_service_type(device);
+       __connman_notifier_unregister(type);
+
        unregister_interface(&device->element);
 
        if (device->driver->remove)
@@ -864,6 +691,8 @@ static void device_destruct(struct connman_element *element)
                device->timeout = 0;
        }
 
+       clear_scan_trigger(device);
+
        if (device->pending != NULL) {
                dbus_message_unref(device->pending);
                device->pending = NULL;
@@ -876,8 +705,6 @@ static void device_destruct(struct connman_element *element)
        g_free(device->control);
        g_free(device->interface);
 
-       connman_ipconfig_unref(device->ipconfig);
-
        g_free(device->last_network);
 
        g_hash_table_destroy(device->networks);
@@ -922,10 +749,13 @@ struct connman_device *connman_device_create(const char *node,
 
        device->element.ipv4.method = CONNMAN_IPCONFIG_METHOD_DHCP;
 
-       device->type      = type;
-       device->name      = g_strdup(type2description(device->type));
-       device->mode      = CONNMAN_DEVICE_MODE_UNKNOWN;
-       device->secondary = FALSE;
+       device->type = type;
+       device->name = g_strdup(type2description(device->type));
+       device->mode = CONNMAN_DEVICE_MODE_UNKNOWN;
+
+       device->powered_persistent = TRUE;
+
+       device->phyindex = -1;
 
        switch (type) {
        case CONNMAN_DEVICE_TYPE_UNKNOWN:
@@ -945,21 +775,13 @@ struct connman_device *connman_device_create(const char *node,
        case CONNMAN_DEVICE_TYPE_GPS:
                device->scan_interval = 0;
                break;
+       case CONNMAN_DEVICE_TYPE_CELLULAR:
        case CONNMAN_DEVICE_TYPE_MBM:
        case CONNMAN_DEVICE_TYPE_HSO:
-       case CONNMAN_DEVICE_TYPE_NOZOMI:
-       case CONNMAN_DEVICE_TYPE_HUAWEI:
-       case CONNMAN_DEVICE_TYPE_NOVATEL:
                device->scan_interval = 0;
                break;
        }
 
-       device->ipconfig = connman_ipconfig_create();
-       if (device->ipconfig == NULL) {
-               connman_device_unref(device);
-               return NULL;
-       }
-
        device->networks = g_hash_table_new_full(g_str_hash, g_str_equal,
                                                g_free, unregister_network);
 
@@ -1052,6 +874,17 @@ int connman_device_get_index(struct connman_device *device)
        return device->element.index;
 }
 
+int __connman_device_get_phyindex(struct connman_device *device)
+{
+       return device->phyindex;
+}
+
+void __connman_device_set_phyindex(struct connman_device *device,
+                                                       int phyindex)
+{
+       device->phyindex = phyindex;
+}
+
 /**
  * connman_device_set_interface:
  * @device: device structure
@@ -1129,30 +962,6 @@ enum connman_device_mode connman_device_get_mode(struct connman_device *device)
 }
 
 /**
- * connman_device_set_secondary:
- * @device: device structure
- * @secondary: secondary value
- *
- * Change secondary value of device
- */
-void connman_device_set_secondary(struct connman_device *device,
-                                               connman_bool_t secondary)
-{
-       device->secondary = secondary;
-}
-
-/**
- * connman_device_get_secondary:
- * @device: device structure
- *
- * Get secondary value of device
- */
-connman_bool_t connman_device_get_secondary(struct connman_device *device)
-{
-       return device->secondary;
-}
-
-/**
  * connman_device_set_powered:
  * @device: device structure
  * @powered: powered state
@@ -1183,6 +992,7 @@ int connman_device_set_powered(struct connman_device *device,
                return -EALREADY;
 
        device->powered = powered;
+       device->powered_pending = powered;
 
        type = __connman_device_get_service_type(device);
 
@@ -1207,33 +1017,26 @@ int connman_device_set_powered(struct connman_device *device,
        return 0;
 }
 
-/**
- * connman_device_set_carrier:
- * @device: device structure
- * @carrier: carrier state
- *
- * Change carrier state of device (only for device without scanning)
- */
-int connman_device_set_carrier(struct connman_device *device,
-                                               connman_bool_t carrier)
+int __connman_device_set_blocked(struct connman_device *device,
+                                               connman_bool_t blocked)
 {
-       DBG("device %p carrier %d", device, carrier);
+       connman_bool_t powered;
 
-       switch (device->mode) {
-       case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
-       case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
-               return -EINVAL;
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               break;
-       }
+       DBG("device %p blocked %d", device, blocked);
 
-       if (device->carrier == carrier)
-               return -EALREADY;
+       device->blocked = blocked;
 
-       device->carrier = carrier;
+       if (device->offlinemode == TRUE)
+               return 0;
+
+       connman_info("%s {rfkill} blocked %d", device->interface, blocked);
 
-       return set_carrier(device, device->carrier);
+       if (blocked == FALSE)
+               powered = device->powered_persistent;
+       else
+               powered = FALSE;
+
+       return set_powered(device, powered);
 }
 
 int __connman_device_scan(struct connman_device *device)
@@ -1244,46 +1047,94 @@ int __connman_device_scan(struct connman_device *device)
        if (device->powered == FALSE)
                return -ENOLINK;
 
+       reset_scan_trigger(device);
+
        return device->driver->scan(device);
 }
 
 int __connman_device_enable(struct connman_device *device)
 {
+       enum connman_service_type type;
+       int err;
+
+       DBG("device %p", device);
+
        if (!device->driver || !device->driver->enable)
                return -EOPNOTSUPP;
 
-       if (device->powered == TRUE)
+       if (device->powered_pending == TRUE)
                return -EALREADY;
 
-       device_enable(device);
+       device->powered_pending = TRUE;
+
+       err = device->driver->enable(device);
+       if (err < 0)
+               return err;
+
+       device->powered = TRUE;
+
+       type = __connman_device_get_service_type(device);
+       __connman_notifier_enable(type);
 
        return 0;
 }
 
+int __connman_device_enable_persistent(struct connman_device *device)
+{
+       DBG("device %p", device);
+
+       device->powered_persistent = TRUE;
+
+       __connman_storage_save_device(device);
+
+       return __connman_device_enable(device);
+}
+
 int __connman_device_disable(struct connman_device *device)
 {
+       enum connman_service_type type;
+       int err;
+
+       DBG("device %p", device);
+
        if (!device->driver || !device->driver->disable)
                return -EOPNOTSUPP;
 
        if (device->powered == FALSE)
                return -ENOLINK;
 
-       device_disable(device);
+       if (device->powered_pending == FALSE)
+               return -EALREADY;
+
+       device->powered_pending = FALSE;
+
+       device->reconnect = FALSE;
+
+       clear_scan_trigger(device);
+
+       g_hash_table_remove_all(device->networks);
+
+       err = device->driver->disable(device);
+       if (err < 0)
+               return err;
+
+       device->powered = FALSE;
+
+       type = __connman_device_get_service_type(device);
+       __connman_notifier_disable(type);
 
        return 0;
 }
 
-int __connman_device_connect(struct connman_device *device)
+int __connman_device_disable_persistent(struct connman_device *device)
 {
        DBG("device %p", device);
 
-       if (device->disconnected == FALSE)
-               return -EINVAL;
+       device->powered_persistent = FALSE;
 
-       if (device->driver && device->driver->connect)
-               device->driver->connect(device);
+       __connman_storage_save_device(device);
 
-       return 0;
+       return __connman_device_disable(device);
 }
 
 int __connman_device_disconnect(struct connman_device *device)
@@ -1300,12 +1151,25 @@ int __connman_device_disconnect(struct connman_device *device)
        while (g_hash_table_iter_next(&iter, &key, &value) == TRUE) {
                struct connman_network *network = value;
 
+               if (__connman_network_get_connecting(network) == TRUE) {
+                       /*
+                        * Skip network in the process of connecting.
+                        * This is a workaround for WiFi networks serviced
+                        * by the supplicant plugin that hold a reference
+                        * to the network.  If we disconnect the network
+                        * here then the referenced object will not be
+                        * registered and usage (like launching DHCP client)
+                        * will fail.  There is nothing to be gained by
+                        * removing the network here anyway.
+                        */
+                       connman_warn("Skipping disconnect of %s",
+                               connman_network_get_identifier(network));
+                       continue;
+               }
+
                __connman_network_disconnect(network);
        }
 
-       if (device->driver && device->driver->disconnect)
-               device->driver->disconnect(device);
-
        return 0;
 }
 
@@ -1340,6 +1204,31 @@ void __connman_device_cleanup_networks(struct connman_device *device)
                                        remove_unavailable_network, NULL);
 }
 
+static void scanning_changed(struct connman_device *device)
+{
+       connman_dbus_property_changed_basic(device->element.path,
+                               CONNMAN_DEVICE_INTERFACE, "Scanning",
+                                       DBUS_TYPE_BOOLEAN, &device->scanning);
+}
+
+static void mark_network_available(gpointer key, gpointer value,
+                                               gpointer user_data)
+{
+       struct connman_network *network = value;
+
+       connman_network_set_available(network, TRUE);
+}
+
+void connman_device_cleanup_scanning(struct connman_device *device)
+{
+       device->scanning = FALSE;
+
+       scanning_changed(device);
+
+       g_hash_table_foreach(device->networks,
+                               mark_network_available, NULL);
+}
+
 /**
  * connman_device_set_scanning:
  * @device: device structure
@@ -1350,10 +1239,6 @@ void __connman_device_cleanup_networks(struct connman_device *device)
 int connman_device_set_scanning(struct connman_device *device,
                                                connman_bool_t scanning)
 {
-       DBusMessage *signal;
-       DBusMessageIter entry, value;
-       const char *key = "Scanning";
-
        DBG("device %p scanning %d", device, scanning);
 
        if (!device->driver || !device->driver->scan)
@@ -1364,21 +1249,7 @@ int connman_device_set_scanning(struct connman_device *device,
 
        device->scanning = scanning;
 
-       signal = dbus_message_new_signal(device->element.path,
-                               CONNMAN_DEVICE_INTERFACE, "PropertyChanged");
-       if (signal == NULL)
-               return 0;
-
-       dbus_message_iter_init_append(signal, &entry);
-
-       dbus_message_iter_append_basic(&entry, DBUS_TYPE_STRING, &key);
-
-       dbus_message_iter_open_container(&entry, DBUS_TYPE_VARIANT,
-                                       DBUS_TYPE_BOOLEAN_AS_STRING, &value);
-       dbus_message_iter_append_basic(&value, DBUS_TYPE_BOOLEAN, &scanning);
-       dbus_message_iter_close_container(&entry, &value);
-
-       g_dbus_send_message(connection, signal);
+       scanning_changed(device);
 
        if (scanning == TRUE) {
                reset_scan_trigger(device);
@@ -1416,7 +1287,6 @@ int connman_device_set_disconnected(struct connman_device *device,
 
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
                return -EINVAL;
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
@@ -1428,6 +1298,9 @@ int connman_device_set_disconnected(struct connman_device *device,
 
        device->disconnected = disconnected;
 
+       if (disconnected == TRUE)
+               force_scan_trigger(device);
+
        return 0;
 }
 
@@ -1443,33 +1316,6 @@ connman_bool_t connman_device_get_disconnected(struct connman_device *device)
 }
 
 /**
- * connman_device_set_connected:
- * @device: device structure
- * @connected: connected state
- *
- * Change connected state of device (for Ethernet like devices)
- */
-int connman_device_set_connected(struct connman_device *device,
-                                               connman_bool_t connected)
-{
-       DBG("device %p connected %d", device, connected);
-
-       switch (device->mode) {
-       case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
-       case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
-               return -EINVAL;
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               break;
-       }
-
-       if (device->carrier == FALSE)
-               return -ENOTCONN;
-
-       return set_connected(device, connected);
-}
-
-/**
  * connman_device_set_string:
  * @device: device structure
  * @key: unique identifier
@@ -1529,11 +1375,16 @@ static void set_offlinemode(struct connman_element *element, gpointer user_data)
        if (device == NULL)
                return;
 
+       device->offlinemode = offlinemode;
+
        powered = (offlinemode == TRUE) ? FALSE : TRUE;
 
        if (device->powered == powered)
                return;
 
+       if (device->powered_persistent == FALSE)
+               powered = FALSE;
+
        set_powered(device, powered);
 }
 
@@ -1544,29 +1395,19 @@ int __connman_device_set_offlinemode(connman_bool_t offlinemode)
        __connman_element_foreach(NULL, CONNMAN_ELEMENT_TYPE_DEVICE,
                        set_offlinemode, GUINT_TO_POINTER(offlinemode));
 
-       __connman_notifier_offline_mode(offlinemode);
+       __connman_notifier_offlinemode(offlinemode);
 
        return 0;
 }
 
 void __connman_device_increase_connections(struct connman_device *device)
 {
-       enum connman_service_type type;
-
        device->connections++;
-
-       type = __connman_device_get_service_type(device);
-       __connman_notifier_connect(type);
 }
 
 void __connman_device_decrease_connections(struct connman_device *device)
 {
-       enum connman_service_type type;
-
        device->connections--;
-
-       type = __connman_device_get_service_type(device);
-       __connman_notifier_disconnect(type);
 }
 
 /**
@@ -1584,9 +1425,11 @@ int connman_device_add_network(struct connman_device *device,
 
        DBG("device %p network %p", device, network);
 
+       if (identifier == NULL)
+               return -EINVAL;
+
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
                return -EINVAL;
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
@@ -1595,8 +1438,6 @@ int connman_device_add_network(struct connman_device *device,
 
        __connman_network_set_device(network, device);
 
-       __connman_storage_load_network(network);
-
        err = connman_element_register((struct connman_element *) network,
                                                        &device->element);
        if (err < 0) {
@@ -1642,6 +1483,11 @@ int connman_device_remove_network(struct connman_device *device,
        return 0;
 }
 
+void connman_device_remove_all_networks(struct connman_device *device)
+{
+       g_hash_table_remove_all(device->networks);
+}
+
 void __connman_device_set_network(struct connman_device *device,
                                        struct connman_network *network)
 {
@@ -1668,6 +1514,18 @@ void __connman_device_set_network(struct connman_device *device,
        }
 }
 
+void __connman_device_set_reconnect(struct connman_device *device,
+                                               connman_bool_t reconnect)
+{
+       device->reconnect = reconnect;
+}
+
+connman_bool_t  __connman_device_get_reconnect(
+                               struct connman_device *device)
+{
+       return device->reconnect;
+}
+
 /**
  * connman_device_register:
  * @device: device structure
@@ -1676,22 +1534,9 @@ void __connman_device_set_network(struct connman_device *device,
  */
 int connman_device_register(struct connman_device *device)
 {
-       enum connman_service_type type;
-
        __connman_storage_load_device(device);
 
-       switch (device->mode) {
-       case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
-               break;
-       case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
-       case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
-               __connman_storage_init_network(device);
-               break;
-       }
-
-       type = __connman_device_get_service_type(device);
-       __connman_notifier_register(type);
+       device->offlinemode = __connman_profile_get_offlinemode();
 
        return connman_element_register(&device->element, NULL);
 }
@@ -1704,13 +1549,8 @@ int connman_device_register(struct connman_device *device)
  */
 void connman_device_unregister(struct connman_device *device)
 {
-       enum connman_service_type type;
-
        __connman_storage_save_device(device);
 
-       type = __connman_device_get_service_type(device);
-       __connman_notifier_unregister(type);
-
        connman_element_unregister(&device->element);
 }
 
@@ -1805,94 +1645,71 @@ static struct connman_driver device_driver = {
 
 static int device_load(struct connman_device *device)
 {
+       const char *ident = __connman_profile_active_ident();
        GKeyFile *keyfile;
-       gchar *pathname, *identifier, *data = NULL;
-       gsize length;
+       GError *error = NULL;
+       gchar *identifier;
+       connman_bool_t powered;
        int val;
 
        DBG("device %p", device);
 
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR,
-                                       __connman_profile_active_ident());
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE) {
-               g_free(pathname);
-               return -ENOENT;
-       }
-
-       g_free(pathname);
-
-       if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE) {
-               g_free(data);
-               return -EILSEQ;
-       }
-
-       g_free(data);
+       keyfile = __connman_storage_open_profile(ident);
+       if (keyfile == NULL)
+               return 0;
 
        identifier = g_strdup_printf("device_%s", device->element.name);
        if (identifier == NULL)
                goto done;
 
+       powered = g_key_file_get_boolean(keyfile, identifier,
+                                               "Powered", &error);
+       if (error == NULL)
+               device->powered_persistent = powered;
+       g_clear_error(&error);
+
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
                break;
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
                val = g_key_file_get_integer(keyfile, identifier,
-                                                       "ScanInterval", NULL);
-               if (val > 0)
+                                               "ScanInterval", &error);
+               if (error == NULL && val > 0)
                        device->scan_interval = val;
+               g_clear_error(&error);
                break;
        }
 
 done:
-       g_key_file_free(keyfile);
-
        g_free(identifier);
 
+       __connman_storage_close_profile(ident, keyfile, FALSE);
+
        return 0;
 }
 
 static int device_save(struct connman_device *device)
 {
+       const char *ident = __connman_profile_active_ident();
        GKeyFile *keyfile;
-       gchar *pathname, *identifier = NULL, *data = NULL;
-       gsize length;
+       gchar *identifier;
 
        DBG("device %p", device);
 
-       pathname = g_strdup_printf("%s/%s.conf", STORAGEDIR,
-                                       __connman_profile_active_ident());
-       if (pathname == NULL)
-               return -ENOMEM;
-
-       keyfile = g_key_file_new();
-
-       if (g_file_get_contents(pathname, &data, &length, NULL) == FALSE)
-               goto update;
-
-       if (length > 0) {
-               if (g_key_file_load_from_data(keyfile, data, length,
-                                                       0, NULL) == FALSE)
-                       goto done;
-       }
-
-       g_free(data);
+       keyfile = __connman_storage_open_profile(ident);
+       if (keyfile == NULL)
+               return 0;
 
-update:
        identifier = g_strdup_printf("device_%s", device->element.name);
        if (identifier == NULL)
                goto done;
 
+       g_key_file_set_boolean(keyfile, identifier,
+                                       "Powered", device->powered_persistent);
+
        switch (device->mode) {
        case CONNMAN_DEVICE_MODE_UNKNOWN:
-       case CONNMAN_DEVICE_MODE_TRANSPORT_IP:
                break;
        case CONNMAN_DEVICE_MODE_NETWORK_SINGLE:
        case CONNMAN_DEVICE_MODE_NETWORK_MULTIPLE:
@@ -1902,18 +1719,10 @@ update:
                break;
        }
 
-       data = g_key_file_to_data(keyfile, &length, NULL);
-
-       if (g_file_set_contents(pathname, data, length, NULL) == FALSE)
-               connman_error("Failed to store device information");
-
 done:
-       g_free(data);
-
-       g_key_file_free(keyfile);
-
        g_free(identifier);
-       g_free(pathname);
+
+       __connman_storage_close_profile(ident, keyfile, TRUE);
 
        return 0;
 }