*
* Copyright (C) 2004, Christophe Saout <christophe@saout.de>
* Copyright (C) 2004-2007, Clemens Fruhwirth <clemens@endorphin.org>
- * Copyright (C) 2009-2011, Red Hat, Inc. All rights reserved.
+ * Copyright (C) 2009-2012, Red Hat, Inc. All rights reserved.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <string.h>
#include <inttypes.h>
#include <errno.h>
#include <unistd.h>
+#include <ctype.h>
+#include <sys/stat.h>
#include <fcntl.h>
#include <assert.h>
-#include <libcryptsetup.h>
+#include <limits.h>
#include <popt.h>
#include "cryptsetup.h"
static int opt_verbose = 0;
static int opt_debug = 0;
-static char *opt_cipher = NULL;
-static char *opt_hash = NULL;
+static const char *opt_cipher = NULL;
+static const char *opt_hash = NULL;
static int opt_verify_passphrase = 0;
-static char *opt_key_file = NULL;
-static char *opt_master_key_file = NULL;
-static char *opt_header_backup_file = NULL;
-static char *opt_uuid = NULL;
+static const char *opt_key_file = NULL;
+static const char *opt_master_key_file = NULL;
+static const char *opt_header_backup_file = NULL;
+static const char *opt_uuid = NULL;
+static const char *opt_header_device = NULL;
static int opt_key_size = 0;
static long opt_keyfile_size = 0;
static long opt_new_keyfile_size = 0;
+static long opt_keyfile_offset = 0;
+static long opt_new_keyfile_offset = 0;
static int opt_key_slot = CRYPT_ANY_SLOT;
static uint64_t opt_size = 0;
static uint64_t opt_offset = 0;
static int opt_random = 0;
static int opt_urandom = 0;
static int opt_dump_master_key = 0;
+static int opt_shared = 0;
+static int opt_allow_discards = 0;
static const char **action_argv;
static int action_argc;
static int action_luksBackup(int arg);
static int action_luksRestore(int arg);
static int action_loopaesOpen(int arg);
+static int action_luksRepair(int arg);
static struct action_type {
const char *type;
{ "remove", action_remove, 0, 1, 1, N_("<name>"), N_("remove device") },
{ "resize", action_resize, 0, 1, 1, N_("<name>"), N_("resize active device") },
{ "status", action_status, 0, 1, 0, N_("<name>"), N_("show device status") },
+ { "repair", action_luksRepair, 0, 1, 1, N_("<device>"), N_("try to repair on-disk metadata") },
{ "luksFormat", action_luksFormat, 0, 1, 1, N_("<device> [<new key file>]"), N_("formats a LUKS device") },
{ "luksOpen", action_luksOpen, 0, 2, 1, N_("<device> <name> "), N_("open LUKS device as mapping <name>") },
{ "luksAddKey", action_luksAddKey, 0, 1, 1, N_("<device> [<new key file>]"), N_("add key to LUKS device") },
{ NULL, NULL, 0, 0, 0, NULL, NULL }
};
+__attribute__((format(printf, 5, 6)))
static void clogger(struct crypt_device *cd, int level, const char *file,
int line, const char *format, ...)
{
free(target);
}
-static int _yesDialog(const char *msg, void *usrptr)
+static int _yesDialog(const char *msg, void *usrptr __attribute__((unused)))
{
char *answer = NULL;
size_t size = 0;
int r = 1;
- if(isatty(0) && !opt_batch_mode) {
+ if(isatty(STDIN_FILENO) && !opt_batch_mode) {
log_std("\nWARNING!\n========\n");
log_std("%s\n\nAre you sure? (Type uppercase yes): ", msg);
if(getline(&answer, &size, stdin) == -1) {
return r;
}
-static void _log(int level, const char *msg, void *usrptr)
+static void _log(int level, const char *msg, void *usrptr __attribute__((unused)))
{
switch(level) {
}
}
+static void _quiet_log(int level, const char *msg, void *usrptr)
+{
+ if (!opt_verbose && (level == CRYPT_LOG_ERROR || level == CRYPT_LOG_NORMAL))
+ level = CRYPT_LOG_VERBOSE;
+ _log(level, msg, usrptr);
+}
+
+static int _verify_passphrase(int def)
+{
+ /* Batch mode switch off verify - if not overrided by -y */
+ if (opt_verify_passphrase)
+ def = 1;
+ else if (opt_batch_mode)
+ def = 0;
+
+ /* Non-tty input doesn't allow verify */
+ if (def && !isatty(STDIN_FILENO)) {
+ if (opt_verify_passphrase)
+ log_err(_("Can't do passphrase verification on non-tty inputs.\n"));
+ def = 0;
+ }
+
+ return def;
+}
+
static void show_status(int errcode)
{
char error[256], *error_;
log_err(".\n");
}
-static int action_create(int arg)
+static const char *uuid_or_device(const char *spec)
+{
+ static char device[PATH_MAX];
+ char s, *ptr;
+ int i = 0, uuid_len = 5;
+
+ /* Check if it is correct UUID=<LUKS_UUID> format */
+ if (spec && !strncmp(spec, "UUID=", uuid_len)) {
+ strcpy(device, "/dev/disk/by-uuid/");
+ ptr = &device[strlen(device)];
+ i = uuid_len;
+ while ((s = spec[i++]) && i < PATH_MAX) {
+ if (!isxdigit(s) && s != '-')
+ return spec; /* Bail it out */
+ if (isalpha(s))
+ s = tolower(s);
+ *ptr++ = s;
+ }
+ *ptr = '\0';
+ return device;
+ }
+
+ return spec;
+}
+
+static int action_create(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
char cipher[MAX_CIPHER_LEN], cipher_mode[MAX_CIPHER_LEN];
.hash = opt_hash ?: DEFAULT_PLAIN_HASH,
.skip = opt_skip,
.offset = opt_offset,
+ .size = opt_size,
};
char *password = NULL;
size_t passwordLen;
size_t key_size = (opt_key_size ?: DEFAULT_PLAIN_KEYBITS) / 8;
+ uint32_t activate_flags = 0;
int r;
if (params.hash && !strcmp(params.hash, "plain"))
if (opt_key_file && strcmp(opt_key_file, "-"))
params.hash = NULL;
- if (opt_keyfile_size && opt_key_file)
- log_std(("Ignoring keyfile size option, keyfile read size "
- "is always the same as encryption key size.\n"));
+ if ((opt_keyfile_offset || opt_keyfile_size) && opt_key_file)
+ log_std(("Ignoring keyfile offset and size options, keyfile read "
+ "size is always the same as encryption key size.\n"));
r = crypt_parse_name_and_mode(opt_cipher ?: DEFAULT_CIPHER(PLAIN),
cipher, NULL, cipher_mode);
if (r < 0)
goto out;
+ if (opt_readonly)
+ activate_flags |= CRYPT_ACTIVATE_READONLY;
+
+ if (opt_shared)
+ activate_flags |= CRYPT_ACTIVATE_SHARED;
+
+ if (opt_allow_discards)
+ activate_flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS;
+
if (opt_key_file)
- r = crypt_activate_by_keyfile(cd, action_argv[0],
- CRYPT_ANY_SLOT, opt_key_file, key_size,
- opt_readonly ? CRYPT_ACTIVATE_READONLY : 0);
+ /* With hashing, read the whole keyfile */
+ r = crypt_activate_by_keyfile_offset(cd, action_argv[0],
+ CRYPT_ANY_SLOT, opt_key_file,
+ params.hash ? 0 : key_size, 0,
+ activate_flags);
else {
r = crypt_get_key(_("Enter passphrase: "),
- &password, &passwordLen, opt_keyfile_size,
+ &password, &passwordLen,
+ opt_keyfile_offset, opt_keyfile_size,
NULL, opt_timeout,
- opt_batch_mode ? 0 : opt_verify_passphrase,
+ _verify_passphrase(0),
cd);
if (r < 0)
goto out;
r = crypt_activate_by_passphrase(cd, action_argv[0],
- CRYPT_ANY_SLOT, password, passwordLen,
- opt_readonly ? CRYPT_ACTIVATE_READONLY : 0);
+ CRYPT_ANY_SLOT, password, passwordLen, activate_flags);
}
out:
crypt_free(cd);
return r;
}
-static int action_loopaesOpen(int arg)
+static int action_loopaesOpen(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
struct crypt_params_loopaes params = {
.skip = opt_skip_valid ? opt_skip : opt_offset,
};
unsigned int key_size = (opt_key_size ?: DEFAULT_LOOPAES_KEYBITS) / 8;
+ uint32_t activate_flags = 0;
int r;
if (!opt_key_file) {
return -EINVAL;
}
+ if (opt_readonly)
+ activate_flags |= CRYPT_ACTIVATE_READONLY;
+
+ if (opt_allow_discards)
+ activate_flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS;
+
if ((r = crypt_init(&cd, action_argv[0])))
goto out;
if (r < 0)
goto out;
- r = crypt_activate_by_keyfile(cd, action_argv[1],
- CRYPT_ANY_SLOT, opt_key_file, opt_keyfile_size,
- opt_readonly ? CRYPT_ACTIVATE_READONLY : 0);
+ r = crypt_activate_by_keyfile_offset(cd, action_argv[1], CRYPT_ANY_SLOT,
+ opt_key_file, opt_keyfile_size,
+ opt_keyfile_size, activate_flags);
out:
crypt_free(cd);
return r;
}
-static int action_remove(int arg)
+static int action_remove(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
return r;
}
-static int action_resize(int arg)
+static int action_resize(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
- r = crypt_init_by_name(&cd, action_argv[0]);
+ r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device);
if (r == 0)
r = crypt_resize(cd, action_argv[0], opt_size);
return r;
}
-static int action_status(int arg)
+static int action_status(int arg __attribute__((unused)))
{
crypt_status_info ci;
struct crypt_active_device cad;
struct crypt_device *cd = NULL;
+ struct stat st;
char *backing_file;
const char *device;
- int r = 0;
+ int path = 0, r = 0;
+
+ /* perhaps a path, not a dm device name */
+ if (strchr(action_argv[0], '/') && !stat(action_argv[0], &st))
+ path = 1;
ci = crypt_status(NULL, action_argv[0]);
switch (ci) {
case CRYPT_INVALID:
- r = -ENODEV;
+ r = -EINVAL;
break;
case CRYPT_INACTIVE:
- log_std("%s/%s is inactive.\n", crypt_get_dir(), action_argv[0]);
+ if (path)
+ log_std("%s is inactive.\n", action_argv[0]);
+ else
+ log_std("%s/%s is inactive.\n", crypt_get_dir(), action_argv[0]);
+ r = -ENODEV;
break;
case CRYPT_ACTIVE:
case CRYPT_BUSY:
- log_std("%s/%s is active%s.\n", crypt_get_dir(), action_argv[0],
- ci == CRYPT_BUSY ? " and is in use" : "");
- r = crypt_init_by_name(&cd, action_argv[0]);
+ if (path)
+ log_std("%s is active%s.\n", action_argv[0],
+ ci == CRYPT_BUSY ? " and is in use" : "");
+ else
+ log_std("%s/%s is active%s.\n", crypt_get_dir(), action_argv[0],
+ ci == CRYPT_BUSY ? " and is in use" : "");
+
+ r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device);
if (r < 0 || !crypt_get_type(cd))
goto out;
log_std(" skipped: %" PRIu64 " sectors\n", cad.iv_offset);
log_std(" mode: %s\n", cad.flags & CRYPT_ACTIVATE_READONLY ?
"readonly" : "read/write");
+ if (cad.flags & CRYPT_ACTIVATE_ALLOW_DISCARDS)
+ log_std(" flags: discards\n");
}
out:
crypt_free(cd);
+ if (r == -ENOTSUP)
+ r = 0;
return r;
}
return -EINVAL;
}
-static int action_luksFormat(int arg)
+static int action_luksRepair(int arg __attribute__((unused)))
+{
+ struct crypt_device *cd = NULL;
+ int r;
+
+ if ((r = crypt_init(&cd, action_argv[0])))
+ goto out;
+
+ /* Currently only LUKS1 allows repair */
+ crypt_set_log_callback(cd, _quiet_log, NULL);
+ r = crypt_load(cd, CRYPT_LUKS1, NULL);
+ crypt_set_log_callback(cd, _log, NULL);
+ if (r == 0) {
+ log_verbose( _("No known problems detected for LUKS header.\n"));
+ goto out;
+ }
+
+ r = _yesDialog(_("Really try to repair LUKS device header?"),
+ NULL) ? 0 : -EINVAL;
+ if (r == 0)
+ r = crypt_repair(cd, CRYPT_LUKS1, NULL);
+out:
+ crypt_free(cd);
+ return r;
+}
+
+static int action_luksFormat(int arg __attribute__((unused)))
{
int r = -EINVAL, keysize;
+ const char *header_device;
char *msg = NULL, *key = NULL, cipher [MAX_CIPHER_LEN], cipher_mode[MAX_CIPHER_LEN];
char *password = NULL;
size_t passwordLen;
struct crypt_params_luks1 params = {
.hash = opt_hash ?: DEFAULT_LUKS1_HASH,
.data_alignment = opt_align_payload,
+ .data_device = opt_header_device ? action_argv[0] : NULL,
};
- if(asprintf(&msg, _("This will overwrite data on %s irrevocably."), action_argv[0]) == -1) {
+ header_device = opt_header_device ?: action_argv[0];
+
+ if(asprintf(&msg, _("This will overwrite data on %s irrevocably."),
+ header_device) == -1) {
log_err(_("memory allocation error in action_luksFormat"));
r = -ENOMEM;
goto out;
r = crypt_parse_name_and_mode(opt_cipher ?: DEFAULT_CIPHER(LUKS1),
cipher, NULL, cipher_mode);
if (r < 0) {
- log_err("No known cipher specification pattern detected.\n");
+ log_err(_("No known cipher specification pattern detected.\n"));
goto out;
}
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, header_device))) {
+ if (opt_header_device)
+ log_err(_("Cannot use %s as on-disk header.\n"), header_device);
goto out;
+ }
keysize = (opt_key_size ?: DEFAULT_LUKS1_KEYBITS) / 8;
- crypt_set_password_verify(cd, 1);
crypt_set_timeout(cd, opt_timeout);
if (opt_iteration_time)
- crypt_set_iterarion_time(cd, opt_iteration_time);
+ crypt_set_iteration_time(cd, opt_iteration_time);
if (opt_random)
crypt_set_rng_type(cd, CRYPT_RNG_RANDOM);
crypt_set_rng_type(cd, CRYPT_RNG_URANDOM);
r = crypt_get_key(_("Enter LUKS passphrase: "), &password, &passwordLen,
- opt_keyfile_size, opt_key_file, opt_timeout,
- opt_batch_mode ? 0 : 1 /* always verify */, cd);
+ opt_keyfile_offset, opt_keyfile_size, opt_key_file,
+ opt_timeout, _verify_passphrase(1), cd);
if (r < 0)
goto out;
return r;
}
-static int action_luksOpen(int arg)
+static int action_luksOpen(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
+ const char *data_device, *header_device;
+ char *key = NULL;
uint32_t flags = 0;
- int r;
+ int r, keysize;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if (opt_header_device) {
+ header_device = uuid_or_device(opt_header_device);
+ data_device = action_argv[0];
+ } else {
+ header_device = uuid_or_device(action_argv[0]);
+ data_device = NULL;
+ }
+
+ if ((r = crypt_init(&cd, header_device)))
goto out;
if ((r = crypt_load(cd, CRYPT_LUKS1, NULL)))
goto out;
+ if (data_device &&
+ (r = crypt_set_data_device(cd, data_device)))
+ goto out;
+
+ if (!data_device && (crypt_get_data_offset(cd) < 8)) {
+ log_err(_("Reduced data offset is allowed only for detached LUKS header.\n"));
+ r = -EINVAL;
+ goto out;
+ }
+
crypt_set_timeout(cd, opt_timeout);
crypt_set_password_retry(cd, opt_tries);
+ crypt_set_password_verify(cd, _verify_passphrase(0));
if (opt_iteration_time)
- crypt_set_iterarion_time(cd, opt_iteration_time);
+ crypt_set_iteration_time(cd, opt_iteration_time);
+
if (opt_readonly)
flags |= CRYPT_ACTIVATE_READONLY;
- if (opt_key_file) {
+ if (opt_allow_discards)
+ flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS;
+
+ if (opt_master_key_file) {
+ keysize = crypt_get_volume_key_size(cd);
+ r = _read_mk(opt_master_key_file, &key, keysize);
+ if (r < 0)
+ goto out;
+ r = crypt_activate_by_volume_key(cd, action_argv[1],
+ key, keysize, flags);
+ } else if (opt_key_file) {
crypt_set_password_retry(cd, 1);
- r = crypt_activate_by_keyfile(cd, action_argv[1],
- CRYPT_ANY_SLOT, opt_key_file, opt_keyfile_size,
- flags);
+ r = crypt_activate_by_keyfile_offset(cd, action_argv[1],
+ opt_key_slot, opt_key_file, opt_keyfile_size,
+ opt_keyfile_offset, flags);
} else
r = crypt_activate_by_passphrase(cd, action_argv[1],
- CRYPT_ANY_SLOT, NULL, 0, flags);
+ opt_key_slot, NULL, 0, flags);
out:
+ crypt_safe_free(key);
crypt_free(cd);
return r;
}
static int verify_keyslot(struct crypt_device *cd, int key_slot,
char *msg_last, char *msg_pass,
- const char *key_file, int keyfile_size)
+ const char *key_file, int keyfile_offset,
+ int keyfile_size)
{
crypt_keyslot_info ki;
char *password = NULL;
return -EPERM;
r = crypt_get_key(msg_pass, &password, &passwordLen,
- keyfile_size, key_file, opt_timeout,
- opt_batch_mode ? 0 : opt_verify_passphrase, cd);
+ keyfile_offset, keyfile_size, key_file, opt_timeout,
+ _verify_passphrase(0), cd);
if(r < 0)
goto out;
return r;
}
-static int action_luksKillSlot(int arg)
+static int action_luksKillSlot(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
crypt_set_confirm_callback(cd, _yesDialog, NULL);
case CRYPT_SLOT_INACTIVE:
log_err(_("Key %d not active. Can't wipe.\n"), opt_key_slot);
case CRYPT_SLOT_INVALID:
+ r = -EINVAL;
goto out;
}
r = verify_keyslot(cd, opt_key_slot,
_("This is the last keyslot. Device will become unusable after purging this key."),
_("Enter any remaining LUKS passphrase: "),
- opt_key_file, opt_keyfile_size);
+ opt_key_file, opt_keyfile_offset, opt_keyfile_size);
if (r < 0)
goto out;
}
return r;
}
-static int action_luksRemoveKey(int arg)
+static int action_luksRemoveKey(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
char *password = NULL;
size_t passwordLen;
int r;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
crypt_set_confirm_callback(cd, _yesDialog, NULL);
r = crypt_get_key(_("Enter LUKS passphrase to be deleted: "),
&password, &passwordLen,
- opt_keyfile_size, opt_key_file,
+ opt_keyfile_offset, opt_keyfile_size, opt_key_file,
opt_timeout,
- opt_batch_mode ? 0 : opt_verify_passphrase,
+ _verify_passphrase(0),
cd);
if(r < 0)
goto out;
return r;
}
-static int action_luksAddKey(int arg)
+static int action_luksAddKey(int arg __attribute__((unused)))
{
int r = -EINVAL, keysize = 0;
char *key = NULL;
const char *opt_new_key_file = (action_argc > 1 ? action_argv[1] : NULL);
struct crypt_device *cd = NULL;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
crypt_set_confirm_callback(cd, _yesDialog, NULL);
goto out;
keysize = crypt_get_volume_key_size(cd);
- crypt_set_password_verify(cd, opt_verify_passphrase ? 1 : 0);
+ /* FIXME: lib cannot properly set verification for new/old passphrase */
+ crypt_set_password_verify(cd, _verify_passphrase(0));
crypt_set_timeout(cd, opt_timeout);
if (opt_iteration_time)
- crypt_set_iterarion_time(cd, opt_iteration_time);
+ crypt_set_iteration_time(cd, opt_iteration_time);
if (opt_master_key_file) {
r = _read_mk(opt_master_key_file, &key, keysize);
r = crypt_keyslot_add_by_volume_key(cd, opt_key_slot,
key, keysize, NULL, 0);
} else if (opt_key_file || opt_new_key_file) {
- r = crypt_keyslot_add_by_keyfile(cd, opt_key_slot,
- opt_key_file, opt_keyfile_size,
- opt_new_key_file, opt_new_keyfile_size);
+ r = crypt_keyslot_add_by_keyfile_offset(cd, opt_key_slot,
+ opt_key_file, opt_keyfile_size, opt_keyfile_offset,
+ opt_new_key_file, opt_new_keyfile_size, opt_new_keyfile_offset);
} else {
r = crypt_keyslot_add_by_passphrase(cd, opt_key_slot,
NULL, 0, NULL, 0);
return 1;
}
-static int action_luksChangeKey(int arg)
+static int action_luksChangeKey(int arg __attribute__((unused)))
{
const char *opt_new_key_file = (action_argc > 1 ? action_argv[1] : NULL);
struct crypt_device *cd = NULL;
size_t vk_size;
int new_key_slot, old_key_slot, r;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
if ((r = crypt_load(cd, CRYPT_LUKS1, NULL)))
goto out;
if (opt_iteration_time)
- crypt_set_iterarion_time(cd, opt_iteration_time);
+ crypt_set_iteration_time(cd, opt_iteration_time);
r = crypt_get_key(_("Enter LUKS passphrase to be changed: "),
&password, &passwordLen,
- opt_keyfile_size, opt_key_file, opt_timeout,
- opt_batch_mode ? 0 : opt_verify_passphrase, cd);
+ opt_keyfile_offset, opt_keyfile_size, opt_key_file,
+ opt_timeout, _verify_passphrase(0), cd);
if (r < 0)
goto out;
passwordLen = 0;
r = crypt_get_key(_("Enter new LUKS passphrase: "),
&password, &passwordLen,
- opt_new_keyfile_size, opt_new_key_file,
- opt_timeout, opt_batch_mode ? 0 : 1, cd);
+ opt_new_keyfile_offset, opt_new_keyfile_size,
+ opt_new_key_file,
+ opt_timeout, _verify_passphrase(0), cd);
if (r < 0)
goto out;
return r;
}
-static int action_isLuks(int arg)
+static int action_isLuks(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
if ((r = crypt_init(&cd, action_argv[0])))
goto out;
+ crypt_set_log_callback(cd, _quiet_log, NULL);
r = crypt_load(cd, CRYPT_LUKS1, NULL);
out:
crypt_free(cd);
return r;
}
-static int action_luksUUID(int arg)
+static int action_luksUUID(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
const char *existing_uuid = NULL;
char *vk = NULL, *password = NULL;
size_t passwordLen = 0;
size_t vk_size;
- int i, r;
+ unsigned i;
+ int r;
crypt_set_confirm_callback(cd, _yesDialog, NULL);
if (!_yesDialog(
return -ENOMEM;
r = crypt_get_key(_("Enter LUKS passphrase: "), &password, &passwordLen,
- opt_keyfile_size, opt_key_file, opt_timeout, 0, cd);
+ opt_keyfile_offset, opt_keyfile_size, opt_key_file,
+ opt_timeout, 0, cd);
if (r < 0)
goto out;
log_std("LUKS header information for %s\n", crypt_get_device_name(cd));
log_std("Cipher name: \t%s\n", crypt_get_cipher(cd));
log_std("Cipher mode: \t%s\n", crypt_get_cipher_mode(cd));
- log_std("Payload offset:\t%d\n", crypt_get_data_offset(cd));
+ log_std("Payload offset:\t%d\n", (int)crypt_get_data_offset(cd));
log_std("UUID: \t%s\n", crypt_get_uuid(cd));
- log_std("MK bits: \t%d\n", vk_size * 8);
+ log_std("MK bits: \t%d\n", (int)vk_size * 8);
log_std("MK dump:\t");
for(i = 0; i < vk_size; i++) {
return r;
}
-static int action_luksDump(int arg)
+static int action_luksDump(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
if ((r = crypt_load(cd, CRYPT_LUKS1, NULL)))
return r;
}
-static int action_luksSuspend(int arg)
+static int action_luksSuspend(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
- r = crypt_init_by_name(&cd, action_argv[0]);
+ r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device);
if (!r)
r = crypt_suspend(cd, action_argv[0]);
return r;
}
-static int action_luksResume(int arg)
+static int action_luksResume(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
- if ((r = crypt_init_by_name(&cd, action_argv[0])))
+ if ((r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device)))
goto out;
- if ((r = crypt_load(cd, CRYPT_LUKS1, NULL)))
- goto out;
+ crypt_set_timeout(cd, opt_timeout);
+ crypt_set_password_retry(cd, opt_tries);
+ crypt_set_password_verify(cd, _verify_passphrase(0));
if (opt_key_file)
- r = crypt_resume_by_keyfile(cd, action_argv[0], CRYPT_ANY_SLOT,
- opt_key_file, opt_keyfile_size);
+ r = crypt_resume_by_keyfile_offset(cd, action_argv[0], CRYPT_ANY_SLOT,
+ opt_key_file, opt_keyfile_size, opt_keyfile_offset);
else
r = crypt_resume_by_passphrase(cd, action_argv[0], CRYPT_ANY_SLOT,
NULL, 0);
return r;
}
-static int action_luksBackup(int arg)
+static int action_luksBackup(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r;
return -EINVAL;
}
- if ((r = crypt_init(&cd, action_argv[0])))
+ if ((r = crypt_init(&cd, uuid_or_device(action_argv[0]))))
goto out;
crypt_set_confirm_callback(cd, _yesDialog, NULL);
return r;
}
-static int action_luksRestore(int arg)
+static int action_luksRestore(int arg __attribute__((unused)))
{
struct crypt_device *cd = NULL;
int r = 0;
poptPrintUsage(popt_context, stderr, 0);
if (error)
log_err("%s: %s\n", more, error);
+ poptFreeContext(popt_context);
exit(exitcode);
}
-static void help(poptContext popt_context, enum poptCallbackReason reason,
- struct poptOption *key, const char * arg, void *data)
+static void help(poptContext popt_context,
+ enum poptCallbackReason reason __attribute__((unused)),
+ struct poptOption *key,
+ const char *arg __attribute__((unused)),
+ void *data __attribute__((unused)))
{
if (key->shortName == '?') {
struct action_type *action;
usage(popt_context, EXIT_SUCCESS, NULL, NULL);
}
-static void _dbg_version_and_cmd(int argc, char **argv)
+static void _dbg_version_and_cmd(int argc, const char **argv)
{
int i;
for (i = 0; i < argc; i++) {
if (i)
log_std(" ");
- log_std(argv[i]);
+ log_std("%s", argv[i]);
}
log_std("\"\n");
}
return r;
}
-int main(int argc, char **argv)
+int main(int argc, const char **argv)
{
static char *popt_tmp;
static struct poptOption popt_help_options[] = {
{ "dump-master-key", '\0', POPT_ARG_NONE, &opt_dump_master_key, 0, N_("Dump volume (master) key instead of keyslots info."), NULL },
{ "key-size", 's', POPT_ARG_INT, &opt_key_size, 0, N_("The size of the encryption key"), N_("BITS") },
{ "keyfile-size", 'l', POPT_ARG_LONG, &opt_keyfile_size, 0, N_("Limits the read from keyfile"), N_("bytes") },
+ { "keyfile-offset", '\0', POPT_ARG_LONG, &opt_keyfile_offset, 0, N_("Number of bytes to skip in keyfile"), N_("bytes") },
{ "new-keyfile-size", '\0', POPT_ARG_LONG, &opt_new_keyfile_size, 0, N_("Limits the read from newly added keyfile"), N_("bytes") },
+ { "new-keyfile-offset",'\0', POPT_ARG_LONG, &opt_new_keyfile_offset, 0, N_("Number of bytes to skip in newly added keyfile"), N_("bytes") },
{ "key-slot", 'S', POPT_ARG_INT, &opt_key_slot, 0, N_("Slot number for new key (default is first free)"), NULL },
{ "size", 'b', POPT_ARG_STRING, &popt_tmp, 1, N_("The size of the device"), N_("SECTORS") },
{ "offset", 'o', POPT_ARG_STRING, &popt_tmp, 2, N_("The start offset in the backend device"), N_("SECTORS") },
{ "header-backup-file",'\0', POPT_ARG_STRING, &opt_header_backup_file, 0, N_("File with LUKS header and keyslots backup."), NULL },
{ "use-random", '\0', POPT_ARG_NONE, &opt_random, 0, N_("Use /dev/random for generating volume key."), NULL },
{ "use-urandom", '\0', POPT_ARG_NONE, &opt_urandom, 0, N_("Use /dev/urandom for generating volume key."), NULL },
- { "uuid", '\0', POPT_ARG_STRING, &opt_uuid, 0, N_("UUID for device to use."), NULL },
+ { "shared", '\0', POPT_ARG_NONE, &opt_shared, 0, N_("Share device with another non-overlapping crypt segment."), NULL },
+ { "uuid", '\0', POPT_ARG_STRING, &opt_uuid, 0, N_("UUID for device to use."), NULL },
+ { "allow-discards", '\0', POPT_ARG_NONE, &opt_allow_discards, 0, N_("Allow discards (aka TRIM) requests for device."), NULL },
+ { "header", '\0', POPT_ARG_STRING, &opt_header_device, 0, N_("Device or file with separated LUKS header."), NULL },
POPT_TABLEEND
};
poptContext popt_context;
struct action_type *action;
- char *aname;
+ const char *aname;
int r;
const char *null_action_argv[] = {NULL};
bindtextdomain(PACKAGE, LOCALEDIR);
textdomain(PACKAGE);
- popt_context = poptGetContext(PACKAGE, argc, (const char **)argv,
- popt_options, 0);
+ crypt_fips_self_check(NULL);
+
+ popt_context = poptGetContext(PACKAGE, argc, argv, popt_options, 0);
poptSetOtherOptionHelp(popt_context,
- N_("[OPTION...] <action> <action-specific>]"));
+ N_("[OPTION...] <action> <action-specific>"));
while((r = poptGetNextOpt(popt_context)) > 0) {
unsigned long long ull_value;
char *endp;
+ errno = 0;
ull_value = strtoull(popt_tmp, &endp, 0);
- if (*endp || !*popt_tmp)
+ if (*endp || !*popt_tmp ||
+ (errno == ERANGE && ull_value == ULLONG_MAX) ||
+ (errno != 0 && ull_value == 0))
r = POPT_ERROR_BADNUMBER;
switch(r) {
poptBadOption(popt_context, POPT_BADOPTION_NOALIAS));
if (opt_version_mode) {
log_std("%s %s\n", PACKAGE_NAME, PACKAGE_VERSION);
+ poptFreeContext(popt_context);
exit(EXIT_SUCCESS);
}
- if (!(aname = (char *)poptGetArg(popt_context)))
+ if (!(aname = poptGetArg(popt_context)))
usage(popt_context, EXIT_FAILURE, _("Argument <action> missing."),
poptGetInvocationName(popt_context));
for(action = action_types; action->type; action++)
/* FIXME: rewrite this from scratch */
+ if (opt_shared && strcmp(aname, "create")) {
+ usage(popt_context, EXIT_FAILURE,
+ _("Option --shared is allowed only for create operation.\n"),
+ poptGetInvocationName(popt_context));
+ }
+
+ if (opt_allow_discards &&
+ strcmp(aname, "luksOpen") &&
+ strcmp(aname, "create") &&
+ strcmp(aname, "loopaesOpen")) {
+ usage(popt_context, EXIT_FAILURE,
+ _("Option --allow-discards is allowed only for luksOpen, loopaesOpen and create operation.\n"),
+ poptGetInvocationName(popt_context));
+ }
+
if (opt_key_size &&
strcmp(aname, "luksFormat") &&
strcmp(aname, "create") &&
if (!strcmp(aname, "luksKillSlot") && action_argc > 1)
opt_key_slot = atoi(action_argv[1]);
if (opt_key_slot != CRYPT_ANY_SLOT &&
- (opt_key_slot < 0 || opt_key_slot > crypt_keyslot_max(CRYPT_LUKS1)))
+ (opt_key_slot < 0 || opt_key_slot >= crypt_keyslot_max(CRYPT_LUKS1)))
usage(popt_context, EXIT_FAILURE, _("Key slot is invalid."),
poptGetInvocationName(popt_context));
if (opt_key_file)
log_err(_("Option --key-file takes precedence over specified key file argument.\n"));
else
- opt_key_file = (char*)action_argv[1];
+ opt_key_file = action_argv[1];
}
- if (opt_keyfile_size < 0 || opt_new_keyfile_size < 0 || opt_key_size < 0) {
+ if (opt_keyfile_size < 0 || opt_new_keyfile_size < 0 || opt_key_size < 0 ||
+ opt_keyfile_offset < 0 || opt_new_keyfile_offset < 0) {
usage(popt_context, EXIT_FAILURE,
_("Negative number for option not permitted."),
poptGetInvocationName(popt_context));
if (opt_random && opt_urandom)
usage(popt_context, EXIT_FAILURE, _("Only one of --use-[u]random options is allowed."),
poptGetInvocationName(popt_context));
+
if ((opt_random || opt_urandom) && strcmp(aname, "luksFormat"))
usage(popt_context, EXIT_FAILURE, _("Option --use-[u]random is allowed only for luksFormat."),
poptGetInvocationName(popt_context));
usage(popt_context, EXIT_FAILURE, _("Option --uuid is allowed only for luksFormat and luksUUID."),
poptGetInvocationName(popt_context));
+ if (opt_align_payload && strcmp(aname, "luksFormat"))
+ usage(popt_context, EXIT_FAILURE, _("Option --align-payload is allowed only for luksFormat."),
+ poptGetInvocationName(popt_context));
+
if (opt_skip && strcmp(aname, "create") && strcmp(aname, "loopaesOpen"))
usage(popt_context, EXIT_FAILURE,
_("Option --skip is supported only for create and loopaesOpen commands.\n"),
_dbg_version_and_cmd(argc, argv);
}
- return run_action(action);
+ r = run_action(action);
+ poptFreeContext(popt_context);
+ return r;
}