Revise cpp codes

[platform/core/api/audio-io.git] / src / cpp / CAudioInput.cpp

diff --git a/src/cpp/CAudioInput.cpp b/src/cpp/CAudioInput.cpp
index 0be4dda..7c4863c 100644 (file)
--- a/src/cpp/CAudioInput.cpp
+++ b/src/cpp/CAudioInput.cpp
@@ -37,22 +37,6 @@ CAudioInput::CAudioInput(CAudioInfo& info) :
     mDirection = CAudioInfo::EAudioDirection::AUDIO_DIRECTION_IN;
 }
 
-//LCOV_EXCL_START
-CAudioInput::CAudioInput(
-        unsigned int            sampleRate,
-        CAudioInfo::EChannel    channel,
-        CAudioInfo::ESampleType type,
-        CAudioInfo::EAudioType  audioType) :
-    __mIsUsedSyncRead(true),
-    __mIsInit(false) {
-    mDirection = CAudioInfo::EAudioDirection::AUDIO_DIRECTION_IN;
-    mAudioInfo = CAudioInfo(sampleRate, channel, type, audioType, -1);
-}
-//LCOV_EXCL_STOP
-
-CAudioInput::~CAudioInput() {
-}
-
 void CAudioInput::onStream(CPulseAudioClient* pClient, size_t length) {
     assert(pClient);
 
@@ -60,7 +44,7 @@ void CAudioInput::onStream(CPulseAudioClient* pClient, size_t length) {
      * Does not call CAudioIO::onStream() for synchronization
      * if a user is using read()
      */
-    if (__mIsUsedSyncRead == true) {
+    if (__mIsUsedSyncRead) {
 #ifdef _AUDIO_IO_DEBUG_TIMING_
         AUDIO_IO_LOGD("Sync Read Mode! - pClient:[%p], length:[%zu]", pClient, length);
 #endif
@@ -76,23 +60,23 @@ void CAudioInput::onStream(CPulseAudioClient* pClient, size_t length) {
     CAudioIO::onStream(pClient, length);
 }
 
-void CAudioInput::__setInit(bool flag) {
+void CAudioInput::__setInit(bool flag) noexcept {
     __mIsInit = flag;
 }
 
-bool CAudioInput::__IsInit() {
-    return (CAudioIO::isInit() == true && __mIsInit == true);
+bool CAudioInput::__IsInit() noexcept {
+    return (CAudioIO::isInit() && __mIsInit);
 }
 
-bool CAudioInput::__IsReady() {
+bool CAudioInput::__IsReady() noexcept {
     return CAudioIO::IsReady();
 }
 
 void CAudioInput::initialize() {
-    if (__IsInit() == true)
+    if (__IsInit())
         return;
 
-    if (cpp_audio_in_has_record_privilege() == false)
+    if (!cpp_audio_in_has_record_privilege())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_PERMISSION_DENIED, "No privilege for record");
 
     try {
@@ -107,7 +91,7 @@ void CAudioInput::initialize() {
 }
 
 void CAudioInput::finalize() {
-    if (__IsInit() == false) {
+    if (!__IsInit()) {
         AUDIO_IO_LOGD("Did not initialize");
         return;
     }
@@ -118,10 +102,10 @@ void CAudioInput::finalize() {
 }
 
 void CAudioInput::prepare() {
-    if (__IsInit() == false)
+    if (!__IsInit())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CAudioInput");
 
-    if (__IsReady() == true) {
+    if (__IsReady()) {
         AUDIO_IO_LOGD("Already prepared CAudioInput");
         CAudioIO::prepare();
         return;
@@ -168,11 +152,11 @@ void CAudioInput::prepare() {
 }
 
 void CAudioInput::unprepare() {
-    if (__IsInit() == false)
+    if (!__IsInit())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize CAudioInput");
 
-    if (__IsReady() == false) {
+    if (!__IsReady()) {
         AUDIO_IO_LOGD("Already unprepared");
         return;
     }
@@ -195,7 +179,7 @@ void CAudioInput::unprepare() {
 }
 
 void CAudioInput::pause() {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
@@ -203,7 +187,7 @@ void CAudioInput::pause() {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
                         "Can't pause if not in Running state");
 
-    if (mpPulseAudioClient->isInThread() == true)
+    if (mpPulseAudioClient->isInThread())
         THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't pause in thread");
 
     CAudioIO::pause();
@@ -211,7 +195,7 @@ void CAudioInput::pause() {
 }
 
 void CAudioInput::resume() {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
@@ -219,7 +203,7 @@ void CAudioInput::resume() {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
                         "Can't resume if not in Paused state");
 
-    if (mpPulseAudioClient->isInThread() == true)
+    if (mpPulseAudioClient->isInThread())
         THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't resume in thread");
 
     CAudioIO::resume();
@@ -227,7 +211,7 @@ void CAudioInput::resume() {
 }
 
 void CAudioInput::flush() {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
@@ -235,7 +219,7 @@ void CAudioInput::flush() {
 }
 
 int CAudioInput::getBufferSize() {
-    if (__IsInit() == false)
+    if (!__IsInit())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CAudioInput");
 
     /* FIXME : return calculated size here to satisfy backward compatibility */
@@ -243,24 +227,22 @@ int CAudioInput::getBufferSize() {
 }
 
 void CAudioInput::setStreamCallback(SStreamCallback callback) {
-    if (__IsInit() == false)
+    if (!__IsInit())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CAudioInput");
 
-    if (callback.onStream == NULL)
-        __mIsUsedSyncRead = true;
-    else
-        __mIsUsedSyncRead = false;
+    __mIsUsedSyncRead = (callback.onStream == nullptr);
+
     AUDIO_IO_LOGD("__mIsUsedSyncRead = %d", __mIsUsedSyncRead);
 
     CAudioIO::setStreamCallback(callback);
 }
 
 size_t CAudioInput::read(void* buffer, size_t length) {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
-    if (buffer == NULL)
+    if (!buffer)
         THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT,
                                "Parameters are NULL buffer:%p", buffer);
 
@@ -269,7 +251,7 @@ size_t CAudioInput::read(void* buffer, size_t length) {
                         "Can't read if not in Running state");
 
     /* Checks synchronous flag */
-    if (__mIsUsedSyncRead == false)
+    if (!__mIsUsedSyncRead)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_OPERATION,
                         "Invalid operation of read() if receive stream callback");
 
@@ -279,7 +261,7 @@ size_t CAudioInput::read(void* buffer, size_t length) {
         internalLock();
 
         // If another thread did call unprepare, do not read
-        if (mpPulseAudioClient == NULL)
+        if (!mpPulseAudioClient)
             THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                             "Did not initialize CPulseAudioClient");
 
@@ -297,16 +279,16 @@ size_t CAudioInput::read(void* buffer, size_t length) {
 }
 
 int CAudioInput::peek(const void** buffer, size_t* length) {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
-    if (buffer == NULL || length == NULL)
+    if (buffer == nullptr || length == nullptr)
         THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT,
                                "Parameters are NULL buffer:%p, length:%p", buffer, length);
 
     /* Checks synchronous flag */
-    if (__mIsUsedSyncRead == true)
+    if (__mIsUsedSyncRead)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_OPERATION,
                         "Invalid operation of peek() if does not receive a stream callback");
 
@@ -314,12 +296,12 @@ int CAudioInput::peek(const void** buffer, size_t* length) {
 }
 
 int CAudioInput::drop() {
-    if (__IsInit() == false || __IsReady() == false)
+    if (!__IsInit() || !__IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED,
                         "Did not initialize or prepare CAudioInput");
 
     /* Checks synchronous flag */
-    if (__mIsUsedSyncRead == true)
+    if (__mIsUsedSyncRead)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_OPERATION,
                         "Invalid operation of drop() if does not receive a stream callback");