Revise cpp codes

[platform/core/api/audio-io.git] / src / cpp / CAudioIO.cpp

diff --git a/src/cpp/CAudioIO.cpp b/src/cpp/CAudioIO.cpp
index 2e236ef..55d4d87 100644 (file)
--- a/src/cpp/CAudioIO.cpp
+++ b/src/cpp/CAudioIO.cpp
@@ -29,7 +29,7 @@ using namespace tizen_media_audio;
  */
 //LCOV_EXCL_START
 CAudioIO::CAudioIO() :
-    mpPulseAudioClient(NULL),
+    mpPulseAudioClient(nullptr),
     __mMutex(PTHREAD_MUTEX_INITIALIZER),
     __mCondMutex(PTHREAD_MUTEX_INITIALIZER),
     __mCond(PTHREAD_COND_INITIALIZER),
@@ -42,7 +42,7 @@ CAudioIO::CAudioIO() :
 //LCOV_EXCL_STOP
 
 CAudioIO::CAudioIO(CAudioInfo& audioInfo) :
-    mpPulseAudioClient(NULL),
+    mpPulseAudioClient(nullptr),
     __mMutex(PTHREAD_MUTEX_INITIALIZER),
     __mCondMutex(PTHREAD_MUTEX_INITIALIZER),
     __mCond(PTHREAD_COND_INITIALIZER),
@@ -54,9 +54,6 @@ CAudioIO::CAudioIO(CAudioInfo& audioInfo) :
     mByPolicy = false;
 }
 
-CAudioIO::~CAudioIO() {
-}
-
 void CAudioIO::setInit(bool flag) {
     __mIsInit = flag;
 }
@@ -67,11 +64,11 @@ bool CAudioIO::isInit() {
 
 bool CAudioIO::IsReady() {
     return ((mState == CAudioInfo::EAudioIOState::AUDIO_IO_STATE_RUNNING ||
-             mState == CAudioInfo::EAudioIOState::AUDIO_IO_STATE_PAUSED)? true : false);
+             mState == CAudioInfo::EAudioIOState::AUDIO_IO_STATE_PAUSED));
 }
 
 void CAudioIO::internalLock() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     if (pthread_mutex_lock(&__mMutex) != 0)
@@ -83,7 +80,7 @@ void CAudioIO::internalLock() {
 }
 
 void CAudioIO::internalUnlock() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     if (pthread_mutex_unlock(&__mMutex) != 0)
@@ -95,7 +92,7 @@ void CAudioIO::internalUnlock() {
 }
 
 void CAudioIO::internalWait() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
 #ifdef _AUDIO_IO_DEBUG_TIMING_
@@ -108,7 +105,7 @@ void CAudioIO::internalWait() {
 }
 
 void CAudioIO::internalSignal() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
 #ifdef _AUDIO_IO_DEBUG_TIMING_
@@ -121,7 +118,7 @@ void CAudioIO::internalSignal() {
 }
 
 void CAudioIO::initialize() {
-    if (__mIsInit == true)
+    if (__mIsInit)
         return;
 
     AUDIO_IO_LOGD("initialize");
@@ -138,7 +135,7 @@ void CAudioIO::initialize() {
 }
 
 void CAudioIO::finalize() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         return;
 
     AUDIO_IO_LOGD("finalize");
@@ -175,20 +172,20 @@ void CAudioIO::finalize() {
 }
 
 void CAudioIO::onStream(CPulseAudioClient* pClient, size_t length) {
-    assert(__mIsInit == true);
-    assert(pClient != NULL);
+    assert(__mIsInit);
+    assert(pClient);
     assert(length > 0);
 
 #ifdef _AUDIO_IO_DEBUG_TIMING_
     AUDIO_IO_LOGD("mStreamCallback.onStream(%p), pClient(%p), length(%zu)", mStreamCallback.onStream, pClient, length);
 #endif
 
-    if (mStreamCallback.onStream != NULL)
+    if (mStreamCallback.onStream)
         mStreamCallback.onStream(length, mStreamCallback.mUserData);
 }
 
 void CAudioIO::onStateChanged(CAudioInfo::EAudioIOState state, bool byPolicy) {
-    assert(__mIsInit == true);
+    assert(__mIsInit);
     assert(state >= CAudioInfo::EAudioIOState::AUDIO_IO_STATE_NONE && state < CAudioInfo::EAudioIOState::AUDIO_IO_STATE_MAX);
 
     mStatePrev = mState;
@@ -198,7 +195,7 @@ void CAudioIO::onStateChanged(CAudioInfo::EAudioIOState state, bool byPolicy) {
     if (mState == mStatePrev)
         return;
 
-    const char* state_string[] = { "NONE", "IDLE", "RUNNING", "PAUSED" };
+    static const char* state_string[] = { "NONE", "IDLE", "RUNNING", "PAUSED" };
 
     AUDIO_IO_LOGD("previous(%s,%d) ===> current(%s,%d), by_policy(%d)",
                   state_string[static_cast<int>(mStatePrev)],
@@ -207,7 +204,7 @@ void CAudioIO::onStateChanged(CAudioInfo::EAudioIOState state, bool byPolicy) {
                   static_cast<int>(mState),
                   mByPolicy);
 
-    if (mStateChangedCallback.onStateChanged != NULL)
+    if (mStateChangedCallback.onStateChanged)
         mStateChangedCallback.onStateChanged(mState, mStatePrev, mByPolicy, mStateChangedCallback.mUserData);
 }
 
@@ -215,22 +212,22 @@ void CAudioIO::onStateChanged(CAudioInfo::EAudioIOState state) {
     onStateChanged(state, false);
 }
 
-CAudioInfo::EAudioIOState CAudioIO::getState() {
+CAudioInfo::EAudioIOState CAudioIO::getState() noexcept {
     return mState;
 }
 
 void CAudioIO::prepare() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 }
 
 void CAudioIO::unprepare() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 }
 
 void CAudioIO::pause() {
-    if (__mIsInit == false || IsReady() == false)
+    if (!__mIsInit || !IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioIO");
 
     try {
@@ -245,7 +242,7 @@ void CAudioIO::pause() {
 }
 
 void CAudioIO::resume() {
-    if (__mIsInit == false || IsReady() == false)
+    if (!__mIsInit || !IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioIO");
 
     try {
@@ -260,7 +257,7 @@ void CAudioIO::resume() {
 }
 
 void CAudioIO::drain() {
-    if (__mIsInit == false || IsReady() == false)
+    if (!__mIsInit || !IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioIO");
 
     try {
@@ -279,7 +276,7 @@ void CAudioIO::drain() {
 }
 
 void CAudioIO::flush() {
-    if (__mIsInit == false || IsReady() == false)
+    if (!__mIsInit || !IsReady())
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioIO");
 
     try {
@@ -298,75 +295,70 @@ void CAudioIO::flush() {
 }
 
 CAudioInfo& CAudioIO::getAudioInfo() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     return mAudioInfo;
 }
 
 void CAudioIO::setStreamCallback(SStreamCallback callback) {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     mStreamCallback = callback;
 }
 
 CAudioIO::SStreamCallback CAudioIO::getStreamCallback() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     return mStreamCallback;
 }
 
 void CAudioIO::setStateChangedCallback(SStateChangedCallback callback) {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     mStateChangedCallback = callback;
 }
 
 CAudioIO::SStateChangedCallback CAudioIO::getStateChangedCallback() {
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
     return mStateChangedCallback;
 }
 
 void CAudioIO::setStreamInfo(sound_stream_info_h stream_info) {
-    if (stream_info == NULL)
+    if (!stream_info)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_ARGUMENT, "stream_info is NULL");
 
-    if (__mIsInit == false)
+    if (!__mIsInit)
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Doesn't initialize CAudioIO");
 
-    try {
-        if (mState != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_IDLE)
-            THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE, "it is not permitted while started");
-
-        int errorCode = SOUND_MANAGER_ERROR_NONE;
-        CAudioInfo::EAudioType audioType = CAudioInfo::EAudioType::AUDIO_IN_TYPE_MEDIA;
-        char *type = NULL;
-        int index = -1;
-        bool avail = false;
-
-        if ((errorCode = sound_manager_is_available_stream_information(stream_info, NATIVE_API_AUDIO_IO, &avail)) != SOUND_MANAGER_ERROR_NONE)
-            THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info is invalid [ret:%d]", errorCode);
-        if (!avail)
-            THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_SUPPORTED_TYPE, "Input stream is not supported");
-
-        if ((errorCode = sound_manager_get_type_from_stream_information(stream_info, &type)) != SOUND_MANAGER_ERROR_NONE)
-            THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info->stream_type is invalid [ret:%d]", errorCode); //LCOV_EXCL_LINE
-        if (mDirection == CAudioInfo::EAudioDirection::AUDIO_DIRECTION_IN)
-            getAudioInfo().convertInputStreamType2AudioType(type, &audioType);
-        else
-            getAudioInfo().convertOutputStreamType2AudioType(type, &audioType);
-        getAudioInfo().setAudioType(audioType);
-
-        if ((errorCode = sound_manager_get_index_from_stream_information(stream_info, &index)) != SOUND_MANAGER_ERROR_NONE)
-            THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info->index is invalid [ret:%d]", errorCode); //LCOV_EXCL_LINE
-        getAudioInfo().setAudioIndex(index);
-
-    } catch (CAudioError& e) {
-        throw;
-    }
+    if (mState != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_IDLE)
+        THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE, "it is not permitted while started");
+
+    int errorCode = SOUND_MANAGER_ERROR_NONE;
+    CAudioInfo::EAudioType audioType = CAudioInfo::EAudioType::AUDIO_IN_TYPE_MEDIA;
+    char *type = nullptr;
+    int index = -1;
+    bool avail = false;
+
+    if ((errorCode = sound_manager_is_available_stream_information(stream_info, NATIVE_API_AUDIO_IO, &avail)) != SOUND_MANAGER_ERROR_NONE)
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info is invalid [ret:%d]", errorCode);
+    if (!avail)
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_SUPPORTED_TYPE, "Input stream is not supported");
+
+    if ((errorCode = sound_manager_get_type_from_stream_information(stream_info, &type)) != SOUND_MANAGER_ERROR_NONE)
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info->stream_type is invalid [ret:%d]", errorCode);
+    if (mDirection == CAudioInfo::EAudioDirection::AUDIO_DIRECTION_IN)
+        getAudioInfo().convertInputStreamType2AudioType(type, &audioType);
+    else
+        getAudioInfo().convertOutputStreamType2AudioType(type, &audioType);
+    getAudioInfo().setAudioType(audioType);
+
+    if ((errorCode = sound_manager_get_index_from_stream_information(stream_info, &index)) != SOUND_MANAGER_ERROR_NONE)
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Parameter stream_info->index is invalid [ret:%d]", errorCode);
+    getAudioInfo().setAudioIndex(index);
 }