*
* Connection Manager
*
- * Copyright (C) 2007-2010 Intel Corporation. All rights reserved.
+ * Copyright (C) 2007-2012 Intel Corporation. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
#include <config.h>
#endif
+#include <errno.h>
#include <stdio.h>
#include <unistd.h>
#include <string.h>
char *private_key_passphrase_type;
char *phase2;
char *passphrase;
- connman_bool_t from_fs;
};
struct connman_config {
static GIOChannel *inotify_channel = NULL;
static uint inotify_watch = 0;
-#define NONFS_CONFIG_NAME "internal"
+#define INTERNAL_CONFIG_PREFIX "__internal"
/* Definition of possible strings in the .config files */
#define CONFIG_KEY_NAME "Name"
if (s->ssid == NULL || service->ssid == NULL)
continue;
+ if (s->ssid_len != service->ssid_len)
+ continue;
+
if (g_strcmp0(service->type, "wifi") == 0 &&
strncmp(s->ssid, service->ssid, s->ssid_len) == 0) {
return TRUE;
const char *ident;
char *str, *hex_ssid;
gboolean service_created = FALSE;
+ int err;
/* Strip off "service_" prefix */
ident = group + 8;
ssid = g_try_malloc0(hex_ssid_len / 2);
if (ssid == NULL) {
+ err = -ENOMEM;
g_free(hex_ssid);
- return -ENOMEM;
+ goto err;
}
for (i = 0; i < hex_ssid_len; i += 2) {
- sscanf(hex_ssid + i, "%02x", &hex);
+ if (sscanf(hex_ssid + i, "%02x", &hex) <= 0) {
+ connman_warn("Invalid SSID %s", hex_ssid);
+ g_free(ssid);
+ g_free(hex_ssid);
+ err = -EILSEQ;
+ goto err;
+ }
ssid[j++] = hex;
}
ssid_len = strlen(service->name);
ssid = g_try_malloc0(ssid_len);
- if (ssid == NULL)
- return -ENOMEM;
+ if (ssid == NULL) {
+ err = -ENOMEM;
+ goto err;
+ }
memcpy(ssid, service->name, ssid_len);
g_free(service->ssid);
if (is_protected_service(service) == TRUE) {
connman_error("Trying to provision a protected service");
-
- g_free(service->ident);
- g_free(service->type);
- g_free(service->name);
- g_free(service->ssid);
- g_free(service);
-
- return -EACCES;
+ err = -EACCES;
+ goto err;
}
str = g_key_file_get_string(keyfile, group, SERVICE_KEY_EAP, NULL);
service->passphrase = str;
}
- if (g_strcmp0(config->ident, NONFS_CONFIG_NAME) != 0)
- service->from_fs = TRUE;
- else
- service->from_fs = FALSE;
-
if (service_created)
g_hash_table_insert(config->service_table, service->ident,
service);
connman_info("Adding service configuration %s", service->ident);
return 0;
+
+err:
+ if (service_created == TRUE) {
+ g_free(service->ident);
+ g_free(service->type);
+ g_free(service->name);
+ g_free(service->ssid);
+ g_free(service);
+ }
+
+ return err;
}
static int load_config(struct connman_config *config)
{
GKeyFile *keyfile;
+ GError *error = NULL;
gsize length;
char **groups;
char *str;
- gboolean protected;
+ gboolean protected, found = FALSE;
int i;
DBG("config %p", config);
- keyfile = __connman_storage_open_config(config->ident);
+ keyfile = __connman_storage_load_config(config->ident);
if (keyfile == NULL)
return -EIO;
}
protected = g_key_file_get_boolean(keyfile, "global",
- CONFIG_KEY_PROT, NULL);
- config->protected = protected;
+ CONFIG_KEY_PROT, &error);
+ if (error == NULL)
+ config->protected = protected;
+ else
+ config->protected = TRUE;
groups = g_key_file_get_groups(keyfile, &length);
for (i = 0; groups[i] != NULL; i++) {
- if (g_str_has_prefix(groups[i], "service_") == TRUE)
- load_service(keyfile, groups[i], config);
+ if (g_str_has_prefix(groups[i], "service_") == TRUE) {
+ if (load_service(keyfile, groups[i], config) == 0)
+ found = TRUE;
+ }
}
+ if (found == FALSE)
+ connman_warn("Config file %s/%s.config does not contain any "
+ "configuration that can be provisioned!",
+ STORAGEDIR, config->ident);
+
g_strfreev(groups);
- __connman_storage_close_config(config->ident, keyfile, FALSE);
+ g_key_file_free(keyfile);
return 0;
}
return config;
}
-int __connman_config_load_service(GKeyFile *keyfile, const char *group)
+static connman_bool_t validate_ident(const char *ident)
{
- struct connman_config *config = g_hash_table_lookup(config_table,
- NONFS_CONFIG_NAME);
+ unsigned int i;
- if (config == NULL) {
- config = create_config(NONFS_CONFIG_NAME);
- if (config == NULL)
- return -ENOMEM;
- }
+ if (ident == NULL)
+ return FALSE;
- return load_service(keyfile, group, config);
+ for (i = 0; i < strlen(ident); i++)
+ if (g_ascii_isprint(ident[i]) == FALSE)
+ return FALSE;
+
+ return TRUE;
}
static int read_configs(void)
if (ident == NULL)
continue;
- if (g_str_equal(ident, NONFS_CONFIG_NAME) == TRUE)
- continue;
-
str = g_string_new_len(file, ident - file);
if (str == NULL)
continue;
ident = g_string_free(str, FALSE);
- if (connman_dbus_validate_ident(ident) == TRUE) {
+ if (validate_ident(ident) == TRUE) {
struct connman_config *config;
config = create_config(ident);
if (config != NULL)
load_config(config);
+ } else {
+ connman_error("Invalid config ident %s", ident);
}
g_free(ident);
}
*ext = '\0';
- if (g_str_equal(ident, NONFS_CONFIG_NAME) == TRUE)
- continue;
-
- if (connman_dbus_validate_ident(ident) == FALSE)
+ if (validate_ident(ident) == FALSE) {
+ connman_error("Invalid config ident %s", ident);
continue;
+ }
if (event->mask & IN_CREATE)
create_config(ident);
if (config != NULL) {
g_hash_table_remove_all(config->service_table);
load_config(config);
+ __connman_service_provision_changed(ident);
}
}
if (memcmp(config->ssid, ssid, ssid_len) != 0)
return;
- /* do not provision immutable services with non-fs originated configs */
- if (config->from_fs == FALSE &&
- __connman_service_get_immutable(service) == TRUE)
- return;
-
- /* only lock services with a config originated from the filesystem */
- if (config->from_fs == TRUE)
- __connman_service_set_immutable(service, TRUE);
+ __connman_service_set_immutable(service, TRUE);
__connman_service_set_favorite(service, TRUE);
return 0;
}
+
+int __connman_config_provision_service_ident(struct connman_service *service,
+ const char *ident)
+{
+ enum connman_service_type type;
+ struct connman_config *config;
+
+ DBG("service %p", service);
+
+ /* For now only WiFi services are supported */
+ type = connman_service_get_type(service);
+ if (type != CONNMAN_SERVICE_TYPE_WIFI)
+ return -ENOSYS;
+
+ config = g_hash_table_lookup(config_table, ident);
+ if(config != NULL)
+ g_hash_table_foreach(config->service_table,
+ provision_service, service);
+
+ return 0;
+}