Fix static analysis issues
[platform/core/appfw/app-installers.git] / src / common / step / configuration / step_parse_manifest.cc
index 7651e22..186b548 100644 (file)
@@ -9,13 +9,14 @@
 #include <pkgmgr/pkgmgr_parser.h>
 #include <pkgmgr-info.h>
 
-#include <tpk_manifest_handlers/account_handler.h>
-#include <tpk_manifest_handlers/common/appdefined_privilege_handler.h>
+#include <tpk_manifest_handlers/appdefined_privilege_handler.h>
 #include <tpk_manifest_handlers/application_manifest_constants.h>
 #include <tpk_manifest_handlers/author_handler.h>
+#include <tpk_manifest_handlers/component_based_application_handler.h>
 #include <tpk_manifest_handlers/dependencies_handler.h>
 #include <tpk_manifest_handlers/description_handler.h>
 #include <tpk_manifest_handlers/feature_handler.h>
+#include <tpk_manifest_handlers/light_user_handler.h>
 #include <tpk_manifest_handlers/package_handler.h>
 #include <tpk_manifest_handlers/privileges_handler.h>
 #include <tpk_manifest_handlers/profile_handler.h>
 #include <string>
 #include <vector>
 
-#include "common/app2ext_dynamic_service.h"
-#include "common/app_installer.h"
 #include "common/feature_validator.h"
 #include "common/installer_context.h"
-#include "common/paths.h"
+#include "common/utils/paths.h"
 #include "common/privileges.h"
 #include "common/pkgmgr_registration.h"
-#include "common/pkgmgr_query.h"
+#include "common/utils/pkgmgr_query.h"
 #include "common/step/step.h"
 #include "common/utils/glist_range.h"
 
@@ -114,12 +113,16 @@ bool StepParseManifest::LocateConfigFile() {
                       context_->is_readonly_package.get()))
               / bf::path(context_->pkgid.get());
       install_path += ".xml";
-      if (bf::exists(backup_path))
+      bf::path backup_install_path =
+          common_installer::GetBackupPathForManifestFile(install_path);
+      if (bf::exists(backup_install_path))
+        manifest = backup_install_path;
+      else if (bf::exists(backup_path))
         manifest = backup_path;
-      else if (bf::exists(in_package_path))
-        manifest = in_package_path;
       else if (bf::exists(install_path))
         manifest = install_path;
+      else if (bf::exists(in_package_path))
+        manifest = in_package_path;
       break;
     }
     case ManifestLocation::INSTALLED: {
@@ -200,27 +203,6 @@ bool StepParseManifest::FillPackageInfo(manifest_x* manifest) {
     return false;
   }
 
-  auto ui_application_list =
-      std::static_pointer_cast<const tpk::parse::UIApplicationInfoList>(
-          parser_->GetManifestData(app_keys::kUIApplicationKey));
-  auto service_application_list =
-      std::static_pointer_cast<const tpk::parse::ServiceApplicationInfoList>(
-          parser_->GetManifestData(app_keys::kServiceApplicationKey));
-  auto widget_application_list =
-      std::static_pointer_cast<const tpk::parse::WidgetApplicationInfoList>(
-          parser_->GetManifestData(app_keys::kWidgetApplicationKey));
-  auto watch_application_list =
-      std::static_pointer_cast<const tpk::parse::WatchApplicationInfoList>(
-          parser_->GetManifestData(app_keys::kWatchApplicationKey));
-
-  // mandatory check
-  if (!ui_application_list && !service_application_list &&
-      !widget_application_list && !watch_application_list) {
-    LOG(ERROR) << "UI Application or Service Application or Widget Application "
-                  "or Watch Application are mandatory and has not been found.";
-    return false;
-  }
-
   int support_mode_val = GetSupportModeVal(pkg_info->support_mode());
 
   manifest->ns = strdup(pkg_info->xmlns().c_str());
@@ -248,21 +230,6 @@ bool StepParseManifest::FillPackageInfo(manifest_x* manifest) {
     manifest->type = strdup(pkg_info->type().c_str());
   }
 
-  // Set external path if the package is installed at external storage.
-  if (req_type == RequestType::ManifestDirectInstall ||
-      req_type == RequestType::ManifestDirectUpdate ||
-      req_type == RequestType::ManifestPartialInstall ||
-      req_type == RequestType::ManifestPartialUpdate ||
-      req_type == RequestType::RecoverDB) {
-    App2ExtDynamicService service;
-    std::string image_path = service.GetExternalImagePath(
-        context_->pkgid.get().c_str(), context_->uid.get());
-    if (!image_path.empty()) {
-      manifest->external_path = strdup(image_path.c_str());
-      manifest->installed_storage = strdup(kInstalledExternally);
-    }
-  }
-
   for (auto& pair : pkg_info->labels()) {
     label_x* label = reinterpret_cast<label_x*>(calloc(1, sizeof(label_x)));
     if (!label) {
@@ -290,10 +257,10 @@ bool StepParseManifest::FillPackageInfo(manifest_x* manifest) {
   // set installed_storage if package is installed
   // this is internal field in package manager but after reading configuration
   // we must know it
+  PkgQueryInterface pkg_query(manifest->package, context_->uid.get());
   if (!manifest->installed_storage) {
     if (manifest_location_ == ManifestLocation::INSTALLED ||
         manifest_location_ == ManifestLocation::RECOVERY) {
-      PkgQueryInterface pkg_query(manifest->package, context_->uid.get());
       std::string storage = pkg_query.StorageForPkgId();
       if (storage.empty()) {
         // Failed to query installation storage, assign internal
@@ -306,6 +273,27 @@ bool StepParseManifest::FillPackageInfo(manifest_x* manifest) {
     }
   }
 
+  // retrieve and set plugin execution info if exists
+  if (manifest_location_ == ManifestLocation::INSTALLED ||
+      manifest_location_ == ManifestLocation::RECOVERY) {
+    std::vector<PkgQueryInterface::PluginInfo> plugin_list;
+    pkg_query.PluginExecutionInfo(&plugin_list);
+
+    for (const auto& plugin_info : plugin_list) {
+      plugin_x* plugin =
+          reinterpret_cast<plugin_x*>(calloc(1, sizeof(plugin_x)));
+      if (!plugin) {
+        LOG(ERROR) << "Out of memory";
+        return false;
+      }
+
+      plugin->pkgid = strdup(manifest->package);
+      plugin->appid = strdup(std::get<1>(plugin_info).c_str());
+      plugin->plugin_type = strdup(std::get<2>(plugin_info).c_str());
+      plugin->plugin_name = strdup(std::get<3>(plugin_info).c_str());
+      manifest->plugin = g_list_append(manifest->plugin, plugin);
+    }
+  }
   return true;
 }
 
@@ -485,7 +473,11 @@ bool StepParseManifest::FillWidgetApplication(manifest_x* manifest) {
     widget_app->package = strdup(manifest->package);
     widget_app->support_disable = strdup(manifest->support_disable);
     widget_app->launch_mode = strdup("single");
-    widget_app->api_version = strdup(manifest->api_version);
+    if (!application.app_info.api_version().empty())
+      widget_app->api_version =
+          strdup(application.app_info.api_version().c_str());
+    else
+      widget_app->api_version = strdup(manifest->api_version);
     manifest->application = g_list_append(manifest->application, widget_app);
     if (bf::path(application.app_info.exec().c_str()).is_absolute())
       widget_app->exec = strdup(application.app_info.exec().c_str());
@@ -504,6 +496,8 @@ bool StepParseManifest::FillWidgetApplication(manifest_x* manifest) {
       return false;
     if (!FillMetadata(widget_app, application.meta_data))
       return false;
+    if (!FillResControl(widget_app, application.res_controls))
+      return false;
   }
   return true;
 }
@@ -538,8 +532,6 @@ bool StepParseManifest::FillServiceApplication(manifest_x* manifest) {
       service_app->type = strdup(application.app_info.type().c_str());
     else
       service_app->type = strdup("capp");
-    service_app->process_pool =
-        strdup(application.app_info.process_pool().c_str());
     service_app->component_type = strdup("svcapp");
     service_app->mainapp = strdup(application.app_info.mainapp().c_str());
     service_app->nodisplay = strdup("true");
@@ -557,7 +549,11 @@ bool StepParseManifest::FillServiceApplication(manifest_x* manifest) {
     service_app->package = strdup(manifest->package);
     service_app->support_disable = strdup(manifest->support_disable);
     service_app->launch_mode = strdup("single");
-    service_app->api_version = strdup(manifest->api_version);
+    if (!application.app_info.api_version().empty())
+      service_app->api_version =
+          strdup(application.app_info.api_version().c_str());
+    else
+      service_app->api_version = strdup(manifest->api_version);
     manifest->application = g_list_append(manifest->application, service_app);
     if (bf::path(application.app_info.exec().c_str()).is_absolute())
       service_app->exec = strdup(application.app_info.exec().c_str());
@@ -581,6 +577,8 @@ bool StepParseManifest::FillServiceApplication(manifest_x* manifest) {
     if (!FillBackgroundCategoryInfo(service_app,
         application.background_category))
       return false;
+    if (!FillResControl(service_app, application.res_controls))
+      return false;
   }
   return true;
 }
@@ -655,7 +653,10 @@ bool StepParseManifest::FillUIApplication(manifest_x* manifest) {
     ui_app->support_disable = strdup(manifest->support_disable);
     ui_app->splash_screen_display =
         strdup(application.app_info.splash_screen_display().c_str());
-    ui_app->api_version = strdup(manifest->api_version);
+    if (!application.app_info.api_version().empty())
+      ui_app->api_version = strdup(application.app_info.api_version().c_str());
+    else
+      ui_app->api_version = strdup(manifest->api_version);
     manifest->application = g_list_append(manifest->application, ui_app);
     if (bf::path(application.app_info.exec().c_str()).is_absolute())
       ui_app->exec = strdup(application.app_info.exec().c_str());
@@ -683,6 +684,8 @@ bool StepParseManifest::FillUIApplication(manifest_x* manifest) {
       return false;
     if (!FillSplashScreen(ui_app, application.app_splashscreens))
       return false;
+    if (!FillResControl(ui_app, application.res_controls))
+      return false;
   }
   return true;
 }
@@ -740,13 +743,18 @@ bool StepParseManifest::FillWatchApplication(manifest_x* manifest) {
         strdup((std::to_string(app_support_mode_val)).c_str());
     watch_app->ui_gadget = strdup("false");
     watch_app->launch_mode = strdup("single");
-    watch_app->api_version = strdup(manifest->api_version);
+    if (!watch_application.app_info.api_version().empty())
+      watch_app->api_version =
+          strdup(watch_application.app_info.api_version().c_str());
+    else
+      watch_app->api_version = strdup(manifest->api_version);
     watch_app->support_ambient =
         strdup(watch_application.app_info.ambient_support().c_str());
     watch_app->package = strdup(manifest->package);
     if (!watch_application.app_info.setup_appid().empty())
       watch_app->setup_appid =
           strdup(watch_application.app_info.setup_appid().c_str());
+    manifest->application = g_list_append(manifest->application, watch_app);
 
     if (!FillLabel(watch_app, watch_application.label))
       return false;
@@ -759,7 +767,8 @@ bool StepParseManifest::FillWatchApplication(manifest_x* manifest) {
     if (!FillBackgroundCategoryInfo(watch_app,
         watch_application.background_category))
       return false;
-    manifest->application = g_list_append(manifest->application, watch_app);
+    if (!FillResControl(watch_app, watch_application.res_controls))
+      return false;
   }
   return true;
 }
@@ -806,6 +815,26 @@ bool StepParseManifest::FillDependencyInfo(manifest_x* manifest) {
   return true;
 }
 
+bool StepParseManifest::FillLightUserInfo(manifest_x* manifest) {
+  std::shared_ptr<const tpk::parse::LightUserInfo> light_user_info =
+      std::static_pointer_cast<const tpk::parse::LightUserInfo>(
+          parser_->GetManifestData(tpk::parse::LightUserInfo::Key()));
+  if (!light_user_info) {
+    manifest->light_user_switch_mode = strdup("default");
+    return true;
+  }
+
+  if (light_user_info->switch_mode().empty()) {
+    LOG(ERROR) << "Invalid switch mode";
+    return false;
+  }
+
+  manifest->light_user_switch_mode =
+      strdup(light_user_info->switch_mode().c_str());
+
+  return true;
+}
+
 bool StepParseManifest::CheckFeatures() {
   auto feature_info =
         std::static_pointer_cast<const tpk::parse::FeatureInfo>(
@@ -1035,6 +1064,33 @@ bool StepParseManifest::FillSplashScreen(application_x* app,
   return true;
 }
 
+template <typename T>
+bool StepParseManifest::FillResControl(application_x* app,
+    const T& res_control_list) {
+  for (auto& res_control : res_control_list) {
+    if (res_control.resource_type().empty())
+      continue;
+
+    res_control_x* rc =
+        static_cast<res_control_x*>(calloc(1, sizeof(res_control_x)));
+    if (!rc) {
+      LOG(ERROR) << "Out of memory";
+      return false;
+    }
+
+    rc->res_type = strdup(res_control.resource_type().c_str());
+    if (!res_control.min_res_version().empty())
+      rc->min_res_version = strdup(res_control.min_res_version().c_str());
+    if (!res_control.max_res_version().empty())
+      rc->max_res_version = strdup(res_control.max_res_version().c_str());
+    if (!res_control.auto_close().empty())
+      rc->auto_close = strdup(res_control.auto_close().c_str());
+
+    app->res_control = g_list_prepend(app->res_control, rc);
+  }
+  return true;
+}
+
 void StepParseManifest::GetLegacySplashScreenFromMetadata(application_x* app,
     const std::string& key, const std::string& val) {
   std::string operation;
@@ -1124,6 +1180,9 @@ bool StepParseManifest::FillExtraInfo(manifest_x* manifest) {
       manifest->zip_mount_file = strdup(zip_mount_file.c_str());
   }
 
+  if (manifest->application == nullptr)
+    return true;
+
   // in case of hybrid package, main app is already set by wgt-backend
   application_x* mainapp = nullptr;
   if (!context_->cross_app_rules.get()) {
@@ -1152,6 +1211,94 @@ bool StepParseManifest::FillExtraInfo(manifest_x* manifest) {
   return true;
 }
 
+bool StepParseManifest::FillComponentBasedApplicationInfo(
+    manifest_x* manifest) {
+  std::shared_ptr<const tpk::parse::ComponentBasedApplicationInfoList>
+      component_based_application_list = std::static_pointer_cast<
+          const tpk::parse::ComponentBasedApplicationInfoList>(
+              parser_->GetManifestData(
+                  app_keys::kComponentBasedApplicationKey));
+  if (!component_based_application_list)
+    return true;
+
+  for (const auto& application : component_based_application_list->items) {
+    int package_support_mode_val = atoi(manifest->support_mode);
+    int app_support_mode_val = package_support_mode_val |
+        GetSupportModeVal(application.app_info.support_mode());
+
+    application_x* app =
+        static_cast<application_x*>(calloc(1, sizeof(application_x)));
+    if (!app) {
+      LOG(ERROR) << "Out of memory";
+      return false;
+    }
+
+    app->appid = strdup(application.app_info.appid().c_str());
+    app->launch_mode = strdup(application.app_info.launch_mode().c_str());
+    app->multiple = strdup(application.app_info.multiple().c_str());
+    app->nodisplay = strdup(application.app_info.nodisplay().c_str());
+    app->support_mode = strdup((std::to_string(app_support_mode_val)).c_str());
+    app->taskmanage = strdup(application.app_info.taskmanage().c_str());
+    if (!application.app_info.type().empty())
+      app->type = strdup(application.app_info.type().c_str());
+    else
+      app->type = strdup("c++app");
+    app->indicatordisplay =
+        strdup(application.app_info.indicator_display().c_str());
+    app->component_type = strdup("componentbasedapp");
+    app->hwacceleration = strdup(application.app_info.hwacceleration().c_str());
+    app->onboot = strdup("false");
+    app->autorestart = strdup("false");
+    app->mainapp = strdup(application.app_info.mainapp().c_str());
+    app->screenreader = strdup("use-system-setting");
+    app->recentimage = strdup("false");
+    app->launchcondition = strdup("false");
+    app->guestmode_visibility = strdup("true");
+    app->permission_type = strdup("normal");
+    app->support_ambient = strdup("false");
+    app->effectimage_type = strdup("image");
+    app->submode = strdup("false");
+    app->process_pool = strdup("false");
+    app->package = strdup(manifest->package);
+    app->support_disable = strdup(manifest->support_disable);
+    app->launch_mode = strdup("single");
+    if (!application.app_info.api_version().empty())
+      app->api_version = strdup(application.app_info.api_version().c_str());
+    else
+      app->api_version = strdup(manifest->api_version);
+    app->splash_screen_display =
+        strdup(application.app_info.splash_screen_display().c_str());
+    manifest->application = g_list_append(manifest->application, app);
+    if (bf::path(application.app_info.exec().c_str()).is_absolute()) {
+      app->exec = strdup(application.app_info.exec().c_str());
+    } else {
+      app->exec = strdup((context_->root_application_path.get()
+                          / manifest->package / "bin"
+                          / application.app_info.exec()).c_str());
+    }
+    if (!FillLabel(app, application.label))
+      return false;
+    if (!FillImage(app, application.app_images))
+      return false;
+    if (!FillBackgroundCategoryInfo(app, application.background_category))
+      return false;
+    if (!FillAppControl(app, application.app_control))
+      return false;
+    if (!FillDataControl(app, application.data_control))
+      return false;
+    if (!FillMetadata(app, application.meta_data))
+      return false;
+    if (!FillCategories(app, application.categories))
+      return false;
+    if (!FillSplashScreen(app, application.app_splashscreens))
+      return false;
+    if (!FillResControl(app, application.res_controls))
+      return false;
+  }
+
+  return true;
+}
+
 bool StepParseManifest::FillManifestX(manifest_x* manifest) {
   if (!FillPackageInfo(manifest))
     return false;
@@ -1165,6 +1312,8 @@ bool StepParseManifest::FillManifestX(manifest_x* manifest) {
     return false;
   if (!FillWatchApplication(manifest))
     return false;
+  if (!FillComponentBasedApplicationInfo(manifest))
+    return false;
   if (!FillPrivileges(manifest))
     return false;
   if (!FillProvidesAppDefinedPrivileges(manifest))
@@ -1179,6 +1328,8 @@ bool StepParseManifest::FillManifestX(manifest_x* manifest) {
     return false;
   if (!FillDependencyInfo(manifest))
     return false;
+  if (!FillLightUserInfo(manifest))
+    return false;
   return true;
 }
 
@@ -1232,7 +1383,7 @@ Step::Status StepParseManifest::process() {
     context_->recovery_info.get().recovery_file->WriteAndCommitFileContent();
   }
 
-  LOG(DEBUG) << "Parsed package id: " << info->package();
+  LOG(INFO) << "Parsed package id: " << info->package();
 
   switch (store_location_) {
     case StoreLocation::NORMAL: