projects / platform / core / appfw / app-installers.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | inline | side by side
Block different type installation with same pkgid
[platform/core/appfw/app-installers.git] / src / common / step / configuration / step_configure.cc
diff --git a/src/common/step/configuration/step_configure.cc b/src/common/step/configuration/step_configure.cc
index e0b675d..6608e03 100644 (file)
--- a/src/common/step/configuration/step_configure.cc
+++ b/src/common/step/configuration/step_configure.cc
@@ -16,10 +16,10 @@
 #include <string>
 #include <utility>
 
-#include "common/pkgmgr_query.h"
-#include "common/request.h"
+#include "common/utils/pkgmgr_query.h"
 #include "common/utils/file_util.h"
 #include "common/utils/user_util.h"
+#include "common/utils/request.h"
 
 namespace bf = boost::filesystem;
 
@@ -28,6 +28,8 @@ namespace configuration {
 
 const char kStrEmpty[] = "";
 const char kAppFWUser[] = "app_fw";
+const char kRpmPkgType[] = "rpm";
+const char kRpmInstaller[] = "tpk";
 
 StepConfigure::StepConfigure(InstallerContext* context, PkgMgrPtr pkgmgr)
     : Step(context),
@@ -40,63 +42,73 @@ Step::Status StepConfigure::process() {
   SetupFileCreationMask();
   SetupDebugMode();
   SetupSkipCheckReference();
+  SetupSkipOptimization();
 
   if (!SetupRootAppDirectory())
     return Status::CONFIG_ERROR;
 
-  RequestType requestType = context_->request_type.get();
-  switch (requestType) {
+  RequestType request_type = context_->request_type.get();
+  switch (request_type) {
     case RequestType::Install:
-    case RequestType::Update:
-      context_->file_path.set(pkgmgr_->GetRequestInfo());
+    case RequestType::Update: {
+      context_->file_path.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       if (!pkgmgr_->GetTepPath().empty()) {
         context_->tep_path.set(pkgmgr_->GetTepPath());
         context_->is_tep_move.set(pkgmgr_->GetIsTepMove());
       }
+      context_->pkgid.set(GetPkgIdFromFile());
       break;
+    }
     case RequestType::PartialUninstall:
-      SetupIsPartialRW();
     case RequestType::Uninstall:
-      if (context_->is_preload_rw_package.get())
-        SetupIsKeepRWData();
+      if (request_type == RequestType::PartialUninstall)
+        SetupIsPartialRW();
+      SetupIsKeepRWData();
       SetupIsForceRemoval();
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       context_->file_path.set(kStrEmpty);
       break;
     case RequestType::Reinstall:
       context_->unpacked_dir_path.set(
           bf::path(tzplatform_getenv(TZ_SDK_TOOLS)) / "tmp" /
-          pkgmgr_->GetRequestInfo());
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+          pkgmgr_->GetRequestInfo(context_->index.get()));
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       context_->file_path.set(kStrEmpty);
       break;
     case RequestType::Delta:
       context_->unpacked_dir_path.set(kStrEmpty);
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
-      context_->file_path.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
+      context_->file_path.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       break;
     case RequestType::Move:
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       context_->is_move_to_external.set(pkgmgr_->GetIsMoveToExternal());
       SetupMoveType();
       break;
     case RequestType::Recovery:
-      context_->file_path.set(pkgmgr_->GetRequestInfo());
+      context_->file_path.set(pkgmgr_->GetRequestInfo(context_->index.get()));
+      context_->recovery_info.set(
+          RecoveryInfo(context_->file_path.get(),
+              pkgmgr_->GetRecoveryCleanup()));
       break;
     case RequestType::MountInstall:
-    case RequestType::MountUpdate:
-      context_->file_path.set(pkgmgr_->GetRequestInfo());
+    case RequestType::MountUpdate: {
+      context_->file_path.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       if (!pkgmgr_->GetTepPath().empty()) {
         context_->tep_path.set(pkgmgr_->GetTepPath());
         context_->is_tep_move.set(pkgmgr_->GetIsTepMove());
       }
+      context_->pkgid.set(GetPkgIdFromFile());
       break;
+    }
     case RequestType::ManifestPartialInstall:
     case RequestType::ManifestPartialUpdate:
-      SetupIsPartialRW();
     case RequestType::ManifestDirectInstall:
     case RequestType::ManifestDirectUpdate: {
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      if (request_type == RequestType::ManifestPartialInstall ||
+          request_type == RequestType::ManifestPartialUpdate)
+        SetupIsPartialRW();
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       bf::path xml_path =
           bf::path(getUserManifestPath(context_->uid.get(),
               context_->is_readonly_package.get()))
@@ -106,61 +118,45 @@ Step::Status StepConfigure::process() {
       context_->xml_path.set(xml_path);
       break;
     }
-    case RequestType::ReadonlyUpdateInstall:
-      context_->file_path.set(pkgmgr_->GetRequestInfo());
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+    case RequestType::ReadonlyUpdateInstall: {
+      context_->file_path.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       if (!pkgmgr_->GetTepPath().empty()) {
         context_->tep_path.set(pkgmgr_->GetTepPath());
         context_->is_tep_move.set(pkgmgr_->GetIsTepMove());
       }
+      context_->pkgid.set(GetPkgIdFromFile());
       break;
+    }
     case RequestType::ReadonlyUpdateUninstall: {
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       bf::path original_path =
           bf::path(tzplatform_getenv(TZ_SYS_RO_APP)) / context_->pkgid.get();
       context_->unpacked_dir_path.set(original_path);
       context_->file_path.set(kStrEmpty);
+      SetupIsKeepRWData();
       break;
     }
     case RequestType::DisablePkg:
     case RequestType::EnablePkg:
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       break;
     case RequestType::MigrateExtImg: {
-      context_->pkgid.set(pkgmgr_->GetRequestInfo());
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
+      break;
+    }
+    case RequestType::RecoverDB: {
+      context_->pkgid.set(pkgmgr_->GetRequestInfo(context_->index.get()));
       break;
     }
     default:
-      LOG(ERROR) <<
-          "Only installation, update and uninstallation is now supported";
+      LOG(ERROR) << "Unknown request type";
       return Status::CONFIG_ERROR;
-      break;
   }
 
-  // Record recovery file
-  if (requestType == RequestType::Install ||
-      requestType == RequestType::Update ||
-      requestType == RequestType::Delta ||
-      requestType == RequestType::MountInstall ||
-      requestType == RequestType::MountUpdate) {
-    std::unique_ptr<recovery::RecoveryFile> recovery_file =
-        recovery::RecoveryFile::CreateRecoveryFile(
-            GenerateTemporaryPath(
-                context_->root_application_path.get() /
-                (context_->pkg_type.get() + "-recovery")),
-            requestType);
-    if (!recovery_file) {
-      LOG(ERROR) << "Failed to create recovery file";
-      return Status::CONFIG_ERROR;
-    }
-    recovery_file->set_type(requestType);
+  if (!CheckInvalidBackendUsage())
+    return Status::OPERATION_NOT_ALLOWED;
 
-    if (!recovery_file->WriteAndCommitFileContent()) {
-      LOG(ERROR) << "Failed to write recovery file";
-      return Status::CONFIG_ERROR;
-    }
-    context_->recovery_info.set(RecoveryInfo(std::move(recovery_file)));
-  }
+  LOG(INFO) << "Request Type: " << GetRequestTypeString(request_type);
 
   return Status::OK;
 }
@@ -196,13 +192,6 @@ Step::Status StepConfigure::precheck() {
   return Status::OK;
 }
 
-Step::Status StepConfigure::clean() {
-  // Clean up operations should not be covered by recovery
-  // as backup information is being lost during clean up
-  context_->recovery_info.get().recovery_file.reset();
-  return Status::OK;
-}
-
 bool StepConfigure::SetupRootAppDirectory() {
   if (context_->root_application_path.get().empty()) {
     std::string root_app_path =
@@ -232,7 +221,7 @@ void StepConfigure::SetupRequestMode(uid_t uid) {
 }
 
 void StepConfigure::SetupRequestType() {
-  context_->request_type.set(pkgmgr_->GetRequestType());
+  context_->request_type.set(pkgmgr_->GetRequestType(context_->index.get()));
 }
 
 void StepConfigure::SetupFileCreationMask() {
@@ -286,6 +275,10 @@ void StepConfigure::SetupSkipCheckReference() {
   context_->skip_check_reference.set(pkgmgr_->GetIsSkipCheckReference());
 }
 
+void StepConfigure::SetupSkipOptimization() {
+  context_->skip_optimization.set(pkgmgr_->GetSkipOptimization());
+}
+
 void StepConfigure::SetupMoveType() {
   int move_type = pkgmgr_->GetMoveType();
   switch (move_type) {
@@ -304,5 +297,40 @@ void StepConfigure::SetupMoveType() {
   }
 }
 
+std::string StepConfigure::GetPkgIdFromFile() {
+  auto app_query_interface = pkgmgr_->GetAppQueryInterface();
+  if (!app_query_interface)
+    return "";
+
+  return app_query_interface->GetPkgId(
+      pkgmgr_->GetRequestInfo(context_->index.get()));
+}
+
+bool StepConfigure::CheckInvalidBackendUsage() {
+  if (context_->pkgid.get().empty())
+    return true;
+
+  PkgQueryInterface pkg_query(context_->pkgid.get().c_str(),
+      context_->uid.get());
+  if (!pkg_query.IsValid()) {
+    LOG(INFO) << "pkg[" << context_->pkgid.get()
+        << "] is not installed, skip checking backend with installed pkg";
+    return true;
+  }
+
+  const std::string& backend_type = context_->pkg_type.get();
+  std::string installed_pkg_type = pkg_query.Type();
+  if (installed_pkg_type == kRpmPkgType)
+    installed_pkg_type = kRpmInstaller;
+
+  if (installed_pkg_type != backend_type) {
+    LOG(ERROR) << "Wrong use of backend : package's type [" << pkg_query.Type()
+        << "] mismatched backend [" << backend_type << "]";
+    return false;
+  }
+
+  return true;
+}
+
 }  // namespace configuration
 }  // namespace common_installer
Domain: App Framework / Application Installer;