#include "chrome/browser/extensions/extension_install_ui.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_uninstall_dialog.h"
+#include "chrome/browser/extensions/webstore_data_fetcher.h"
+#include "chrome/browser/extensions/webstore_data_fetcher_delegate.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/global_error/global_error_service.h"
#include "chrome/browser/ui/global_error/global_error_service_factory.h"
#include "chrome/browser/ui/host_desktop.h"
-#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_source.h"
+#include "extensions/common/extension.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
class ExternalInstallGlobalError;
-// TODO(mpcomplete): Get rid of the refcounting on this class, or document
-// why it's necessary. Will do after refactoring to merge back with
-// ExtensionDisabledDialogDelegate.
+// This class is refcounted to stay alive while we try and pull webstore data.
class ExternalInstallDialogDelegate
: public ExtensionInstallPrompt::Delegate,
+ public WebstoreDataFetcherDelegate,
public base::RefCountedThreadSafe<ExternalInstallDialogDelegate> {
public:
ExternalInstallDialogDelegate(Browser* browser,
virtual void InstallUIProceed() OVERRIDE;
virtual void InstallUIAbort(bool user_initiated) OVERRIDE;
+ // WebstoreDataFetcherDelegate:
+ virtual void OnWebstoreRequestFailure() OVERRIDE;
+ virtual void OnWebstoreResponseParseSuccess(
+ scoped_ptr<base::DictionaryValue> webstore_data) OVERRIDE;
+ virtual void OnWebstoreResponseParseFailure(
+ const std::string& error) OVERRIDE;
+
+ // Show the install dialog to the user.
+ void ShowInstallUI();
+
// The UI for showing the install dialog when enabling.
scoped_ptr<ExtensionInstallPrompt> install_ui_;
+ scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;
Browser* browser_;
base::WeakPtr<ExtensionService> service_weak_;
- const std::string extension_id_;
+ scoped_ptr<WebstoreDataFetcher> webstore_data_fetcher_;
+ std::string extension_id_;
+ bool use_global_error_;
+
+ DISALLOW_COPY_AND_ASSIGN(ExternalInstallDialogDelegate);
};
// Only shows a menu item, no bubble. Clicking the menu item shows
const Extension* extension);
virtual ~ExternalInstallMenuAlert();
- const Extension* extension() const { return extension_; }
-
// GlobalError implementation.
virtual Severity GetSeverity() OVERRIDE;
virtual bool HasMenuItem() OVERRIDE;
virtual int MenuItemCommandID() OVERRIDE;
- virtual string16 MenuItemLabel() OVERRIDE;
+ virtual base::string16 MenuItemLabel() OVERRIDE;
virtual void ExecuteMenuItem(Browser* browser) OVERRIDE;
virtual bool HasBubbleView() OVERRIDE;
- virtual string16 GetBubbleViewTitle() OVERRIDE;
- virtual std::vector<string16> GetBubbleViewMessages() OVERRIDE;
- virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
- virtual string16 GetBubbleViewCancelButtonLabel() OVERRIDE;
+ virtual base::string16 GetBubbleViewTitle() OVERRIDE;
+ virtual std::vector<base::string16> GetBubbleViewMessages() OVERRIDE;
+ virtual base::string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
+ virtual base::string16 GetBubbleViewCancelButtonLabel() OVERRIDE;
virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE;
virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;
virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;
ExtensionService* service_;
const Extension* extension_;
content::NotificationRegistrar registrar_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ExternalInstallMenuAlert);
};
// Shows a menu item and a global error bubble, replacing the install dialog.
virtual void ExecuteMenuItem(Browser* browser) OVERRIDE;
virtual bool HasBubbleView() OVERRIDE;
virtual gfx::Image GetBubbleViewIcon() OVERRIDE;
- virtual string16 GetBubbleViewTitle() OVERRIDE;
- virtual std::vector<string16> GetBubbleViewMessages() OVERRIDE;
- virtual string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
- virtual string16 GetBubbleViewCancelButtonLabel() OVERRIDE;
+ virtual base::string16 GetBubbleViewTitle() OVERRIDE;
+ virtual std::vector<base::string16> GetBubbleViewMessages() OVERRIDE;
+ virtual base::string16 GetBubbleViewAcceptButtonLabel() OVERRIDE;
+ virtual base::string16 GetBubbleViewCancelButtonLabel() OVERRIDE;
virtual void OnBubbleViewDidClose(Browser* browser) OVERRIDE;
virtual void BubbleViewAcceptButtonPressed(Browser* browser) OVERRIDE;
virtual void BubbleViewCancelButtonPressed(Browser* browser) OVERRIDE;
// manually).
ExternalInstallDialogDelegate* delegate_;
const ExtensionInstallPrompt::Prompt* prompt_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(ExternalInstallGlobalError);
};
static void CreateExternalInstallGlobalError(
bool use_global_error)
: browser_(browser),
service_weak_(service->AsWeakPtr()),
- extension_id_(extension->id()) {
+ extension_id_(extension->id()),
+ use_global_error_(use_global_error) {
AddRef(); // Balanced in Proceed or Abort.
+ prompt_.reset(new ExtensionInstallPrompt::Prompt(
+ ExtensionInstallPrompt::EXTERNAL_INSTALL_PROMPT));
+
+ // If we don't have a browser, we can't go to the webstore to fetch data.
+ // This should only happen in tests.
+ if (!browser) {
+ ShowInstallUI();
+ return;
+ }
+
+ webstore_data_fetcher_.reset(new WebstoreDataFetcher(
+ this,
+ browser->profile()->GetRequestContext(),
+ GURL::EmptyGURL(),
+ extension->id()));
+ webstore_data_fetcher_->Start();
+}
+
+void ExternalInstallDialogDelegate::OnWebstoreRequestFailure() {
+ ShowInstallUI();
+}
+
+void ExternalInstallDialogDelegate::OnWebstoreResponseParseSuccess(
+ scoped_ptr<base::DictionaryValue> webstore_data) {
+ std::string localized_user_count;
+ double average_rating;
+ int rating_count;
+ if (!webstore_data->GetString(kUsersKey, &localized_user_count) ||
+ !webstore_data->GetDouble(kAverageRatingKey, &average_rating) ||
+ !webstore_data->GetInteger(kRatingCountKey, &rating_count)) {
+ // If we don't get a valid webstore response, short circuit, and continue
+ // to show a prompt without webstore data.
+ ShowInstallUI();
+ return;
+ }
+
+ bool show_user_count = true;
+ webstore_data->GetBoolean(kShowUserCountKey, &show_user_count);
+
+ prompt_->SetWebstoreData(localized_user_count,
+ show_user_count,
+ average_rating,
+ rating_count);
+
+ ShowInstallUI();
+}
+
+void ExternalInstallDialogDelegate::OnWebstoreResponseParseFailure(
+ const std::string& error) {
+ ShowInstallUI();
+}
+
+void ExternalInstallDialogDelegate::ShowInstallUI() {
+ const Extension* extension = NULL;
+ if (!service_weak_.get() ||
+ !(extension = service_weak_->GetInstalledExtension(extension_id_))) {
+ return;
+ }
install_ui_.reset(
- ExtensionInstallUI::CreateInstallPromptWithBrowser(browser));
+ ExtensionInstallUI::CreateInstallPromptWithBrowser(browser_));
const ExtensionInstallPrompt::ShowDialogCallback callback =
- use_global_error ?
- base::Bind(&CreateExternalInstallGlobalError,
- service_weak_, extension_id_) :
- ExtensionInstallPrompt::GetDefaultShowDialogCallback();
- install_ui_->ConfirmExternalInstall(this, extension, callback);
+ use_global_error_ ?
+ base::Bind(&CreateExternalInstallGlobalError,
+ service_weak_,
+ extension_id_) :
+ ExtensionInstallPrompt::GetDefaultShowDialogCallback();
+
+ install_ui_->ConfirmExternalInstall(this, extension, callback, *prompt_);
}
ExternalInstallDialogDelegate::~ExternalInstallDialogDelegate() {
}
void ExternalInstallDialogDelegate::InstallUIProceed() {
- if (!service_weak_.get())
- return;
- const Extension* extension =
- service_weak_->GetInstalledExtension(extension_id_);
- if (!extension)
+ const Extension* extension = NULL;
+ if (!service_weak_.get() ||
+ !(extension = service_weak_->GetInstalledExtension(extension_id_))) {
return;
+ }
service_weak_->GrantPermissionsAndEnableExtension(extension);
Release();
}
void ExternalInstallDialogDelegate::InstallUIAbort(bool user_initiated) {
- if (!service_weak_.get())
- return;
- const Extension* extension =
- service_weak_->GetInstalledExtension(extension_id_);
- if (!extension)
+ const Extension* extension = NULL;
+ if (!service_weak_.get() ||
+ !(extension = service_weak_->GetInstalledExtension(extension_id_))) {
return;
+ }
service_weak_->UninstallExtension(extension_id_, false, NULL);
Release();
}
return kMenuCommandId;
}
-string16 ExternalInstallMenuAlert::MenuItemLabel() {
+base::string16 ExternalInstallMenuAlert::MenuItemLabel() {
int id = -1;
if (extension_->is_app())
id = IDS_EXTENSION_EXTERNAL_INSTALL_ALERT_APP;
id = IDS_EXTENSION_EXTERNAL_INSTALL_ALERT_THEME;
else
id = IDS_EXTENSION_EXTERNAL_INSTALL_ALERT_EXTENSION;
- return l10n_util::GetStringFUTF16(id, UTF8ToUTF16(extension_->name()));
+ return l10n_util::GetStringFUTF16(id, base::UTF8ToUTF16(extension_->name()));
}
void ExternalInstallMenuAlert::ExecuteMenuItem(Browser* browser) {
bool ExternalInstallMenuAlert::HasBubbleView() {
return false;
}
-string16 ExternalInstallMenuAlert::GetBubbleViewTitle() {
- return string16();
+base::string16 ExternalInstallMenuAlert::GetBubbleViewTitle() {
+ return base::string16();
}
-std::vector<string16> ExternalInstallMenuAlert::GetBubbleViewMessages() {
- return std::vector<string16>();
+std::vector<base::string16> ExternalInstallMenuAlert::GetBubbleViewMessages() {
+ return std::vector<base::string16>();
}
-string16 ExternalInstallMenuAlert::GetBubbleViewAcceptButtonLabel() {
- return string16();
+base::string16 ExternalInstallMenuAlert::GetBubbleViewAcceptButtonLabel() {
+ return base::string16();
}
-string16 ExternalInstallMenuAlert::GetBubbleViewCancelButtonLabel() {
- return string16();
+base::string16 ExternalInstallMenuAlert::GetBubbleViewCancelButtonLabel() {
+ return base::string16();
}
void ExternalInstallMenuAlert::OnBubbleViewDidClose(Browser* browser) {
extension_misc::EXTENSION_ICON_SMALL)));
}
-string16 ExternalInstallGlobalError::GetBubbleViewTitle() {
+base::string16 ExternalInstallGlobalError::GetBubbleViewTitle() {
return prompt_->GetDialogTitle();
}
-std::vector<string16> ExternalInstallGlobalError::GetBubbleViewMessages() {
- std::vector<string16> messages;
+std::vector<base::string16>
+ExternalInstallGlobalError::GetBubbleViewMessages() {
+ std::vector<base::string16> messages;
messages.push_back(prompt_->GetHeading());
if (prompt_->GetPermissionCount()) {
messages.push_back(prompt_->GetPermissionsHeading());
return messages;
}
-string16 ExternalInstallGlobalError::GetBubbleViewAcceptButtonLabel() {
+base::string16 ExternalInstallGlobalError::GetBubbleViewAcceptButtonLabel() {
return prompt_->GetAcceptButtonLabel();
}
-string16 ExternalInstallGlobalError::GetBubbleViewCancelButtonLabel() {
+base::string16 ExternalInstallGlobalError::GetBubbleViewCancelButtonLabel() {
return prompt_->GetAbortButtonLabel();
}
projects / platform / framework / web / crosswalk.git / blobdiff