#include "base/files/file_path.h"
#include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/api/file_system/file_system_api.h"
#include "testing/gtest/include/gtest/gtest.h"
}
}
-AcceptOption* BuildAcceptOption(std::string description,
- std::string mime_types,
- std::string extensions) {
+AcceptOption* BuildAcceptOption(const std::string& description,
+ const std::string& mime_types,
+ const std::string& extensions) {
AcceptOption* option = new AcceptOption();
if (!description.empty())
}
#if defined(OS_WIN)
-#define ToStringType UTF8ToWide
+#define ToStringType base::UTF8ToWide
#else
#define ToStringType
#endif
file_type_info = ui::SelectFileDialog::FileTypeInfo();
std::vector<linked_ptr<AcceptOption> > options;
options.push_back(linked_ptr<AcceptOption>(BuildAcceptOption(
- std::string(), "application/x-chrome-extension", "jso")));
+ base::EmptyString(), "application/x-chrome-extension", "jso")));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
base::FilePath::StringType(), &options, &acceptsAllTypes);
// Test that not satisfying the extension will force all types.
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
- options.push_back(linked_ptr<AcceptOption>(
- BuildAcceptOption(std::string(), std::string(), "unrelated")));
+ options.push_back(linked_ptr<AcceptOption>(BuildAcceptOption(
+ base::EmptyString(), base::EmptyString(), "unrelated")));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
ToStringType(".jso"), &options, &acceptsAllTypes);
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(linked_ptr<AcceptOption>(
- BuildAcceptOption(std::string(), std::string(), "jso,js")));
+ BuildAcceptOption(base::EmptyString(), base::EmptyString(), "jso,js")));
options.push_back(linked_ptr<AcceptOption>(
- BuildAcceptOption(std::string(), std::string(), "cpp,cc")));
+ BuildAcceptOption(base::EmptyString(), base::EmptyString(), "cpp,cc")));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
base::FilePath::StringType(), &options, &acceptsAllTypes);
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(linked_ptr<AcceptOption>(
- BuildAcceptOption(std::string(), "image/*", "html")));
+ BuildAcceptOption(base::EmptyString(), "image/*", "html")));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
base::FilePath::StringType(), &options, &acceptsAllTypes);
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(linked_ptr<AcceptOption>(BuildAcceptOption(
- std::string(), "image/*,audio/*,video/*", std::string())));
+ base::EmptyString(), "image/*,audio/*,video/*", base::EmptyString())));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
base::FilePath::StringType(), &options, &acceptsAllTypes);
file_type_info = ui::SelectFileDialog::FileTypeInfo();
options.clear();
options.push_back(linked_ptr<AcceptOption>(
- BuildAcceptOption("File Types 101", "image/jpeg", std::string())));
+ BuildAcceptOption("File Types 101", "image/jpeg", base::EmptyString())));
acceptsAllTypes = false;
FileSystemChooseEntryFunction::BuildFileTypeInfo(&file_type_info,
base::FilePath::StringType(), &options, &acceptsAllTypes);
EXPECT_EQ(file_type_info.extension_description_overrides[0],
- UTF8ToUTF16("File Types 101"));
+ base::UTF8ToUTF16("File Types 101"));
}
TEST_F(FileSystemApiUnitTest, FileSystemChooseEntryFunctionSuggestionTest) {