Upstream version 9.38.198.0

[platform/framework/web/crosswalk.git] / src / cc / PRESUBMIT.py

diff --git a/src/cc/PRESUBMIT.py b/src/cc/PRESUBMIT.py
index 6a7f921..f9a0acb 100644 (file)
--- a/src/cc/PRESUBMIT.py
+++ b/src/cc/PRESUBMIT.py
@@ -149,6 +149,19 @@ def FindUnquotedQuote(contents, pos):
   match = re.search(r"(?<!\\)(?P<quote>\")", contents[pos:])
   return -1 if not match else match.start("quote") + pos
 
+def FindUselessIfdefs(input_api, output_api):
+  errors = []
+  source_file_filter = lambda x: x
+  for f in input_api.AffectedSourceFiles(source_file_filter):
+    contents = input_api.ReadFile(f, 'rb')
+    if re.search(r'#if\s*0\s', contents):
+      errors.append(f.LocalPath())
+  if errors:
+    return [output_api.PresubmitError(
+      'Don\'t use #if '+'0; just delete the code.',
+      items=errors)]
+  return []
+
 def FindNamespaceInBlock(pos, namespace, contents, whitelist=[]):
   open_brace = -1
   close_brace = -1
@@ -274,12 +287,13 @@ def CheckChangeOnUpload(input_api, output_api):
   results += CheckTodos(input_api, output_api)
   results += CheckNamespace(input_api, output_api)
   results += CheckForUseOfWrongClock(input_api, output_api)
+  results += FindUselessIfdefs(input_api, output_api)
   results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
   return results
 
 def GetPreferredTryMasters(project, change):
   return {
-    'tryserver.chromium': {
+    'tryserver.blink': {
       'linux_blink_rel': set(['defaulttests']),
     },
     'tryserver.chromium.gpu': {