Merge "Fix crash caused by decryption response delay" into tizen
[platform/upstream/connman.git] / src / agent-connman.c
old mode 100644 (file)
new mode 100755 (executable)
index ab538f3..e4850a8
@@ -56,7 +56,12 @@ static bool check_reply_has_dict(DBusMessage *reply)
 
 struct request_input_reply {
        struct connman_service *service;
-       authentication_cb_t callback;
+       struct connman_peer *peer;
+       union {
+               authentication_cb_t service_callback;
+               peer_wps_cb_t peer_callback;
+       };
+       bool wps_requested;
        void *user_data;
 };
 
@@ -74,8 +79,10 @@ static void request_input_passphrase_reply(DBusMessage *reply, void *user_data)
        int name_len = 0;
        DBusMessageIter iter, dict;
 
-       if (!reply)
-               goto out;
+       if (!reply) {
+               error = CONNMAN_ERROR_INTERFACE ".OperationAborted";
+               goto done;
+       }
 
        if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
                error = dbus_message_get_error_name(reply);
@@ -93,71 +100,112 @@ static void request_input_passphrase_reply(DBusMessage *reply, void *user_data)
                DBusMessageIter entry, value;
 
                dbus_message_iter_recurse(&dict, &entry);
-               if (dbus_message_iter_get_arg_type(&entry) != DBUS_TYPE_STRING)
+               if (dbus_message_iter_get_arg_type(&entry) != DBUS_TYPE_STRING) {
+                       error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                        break;
+               }
 
                dbus_message_iter_get_basic(&entry, &key);
 
                if (g_str_equal(key, "Identity")) {
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
                        dbus_message_iter_get_basic(&value, &identity);
 
                } else if (g_str_equal(key, "Passphrase")) {
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
                        dbus_message_iter_get_basic(&value, &passphrase);
 
                } else if (g_str_equal(key, "WPS")) {
-                       wps = true;
 
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
+                       wps = true;
                        dbus_message_iter_get_basic(&value, &wpspin);
                        break;
                } else if (g_str_equal(key, "Name")) {
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
                        dbus_message_iter_get_basic(&value, &name);
                        name_len = strlen(name);
                } else if (g_str_equal(key, "SSID")) {
+                       DBusMessageIter array_iter;
+
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
                        dbus_message_iter_recurse(&entry, &value);
                        if (dbus_message_iter_get_arg_type(&value)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_ARRAY) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
-                       if (dbus_message_iter_get_element_type(&value)
-                                                       != DBUS_TYPE_VARIANT)
+                       }
+                       dbus_message_iter_recurse(&value, &array_iter);
+                       if (dbus_message_iter_get_arg_type(&array_iter)
+                                                       != DBUS_TYPE_BYTE) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
-                       dbus_message_iter_get_fixed_array(&value, &name,
+                       }
+                       dbus_message_iter_get_fixed_array(&array_iter, &name,
                                                        &name_len);
                }
                dbus_message_iter_next(&dict);
        }
 
 done:
-       passphrase_reply->callback(passphrase_reply->service, values_received,
-                               name, name_len,
-                               identity, passphrase,
-                               wps, wpspin, error,
-                               passphrase_reply->user_data);
+       passphrase_reply->service_callback(passphrase_reply->service,
+                                       values_received, name, name_len,
+                                       identity, passphrase, wps, wpspin,
+                                       error, passphrase_reply->user_data);
 
-out:
        g_free(passphrase_reply);
 }
 
@@ -205,6 +253,9 @@ static void request_input_append_passphrase(DBusMessageIter *iter,
                value = "wep";
                break;
        case CONNMAN_SERVICE_SECURITY_PSK:
+#if defined TIZEN_EXT
+       case CONNMAN_SERVICE_SECURITY_RSN:
+#endif
                value = "psk";
                break;
        case CONNMAN_SERVICE_SECURITY_8021X:
@@ -236,13 +287,21 @@ static void request_input_append_passphrase(DBusMessageIter *iter,
        }
 }
 
+struct request_wps_data {
+       bool peer;
+};
+
 static void request_input_append_wps(DBusMessageIter *iter, void *user_data)
 {
+       struct request_wps_data *wps = user_data;
        const char *str = "wpspin";
 
        connman_dbus_dict_append_basic(iter, "Type",
                                DBUS_TYPE_STRING, &str);
-       str = "alternate";
+       if (wps && wps->peer)
+               str = "mandatory";
+       else
+               str = "alternate";
        connman_dbus_dict_append_basic(iter, "Requirement",
                                DBUS_TYPE_STRING, &str);
 }
@@ -330,6 +389,9 @@ static void previous_passphrase_handler(DBusMessageIter *iter,
                        data.type = "wep";
                        break;
                case CONNMAN_SERVICE_SECURITY_PSK:
+#if defined TIZEN_EXT
+               case CONNMAN_SERVICE_SECURITY_RSN:
+#endif
                        data.type  = "psk";
                        break;
                /*
@@ -354,8 +416,10 @@ static void request_input_login_reply(DBusMessage *reply, void *user_data)
        char *key;
        DBusMessageIter iter, dict;
 
-       if (!reply)
-               goto out;
+       if (!reply) {
+               error = CONNMAN_ERROR_INTERFACE ".OperationAborted";
+               goto done;
+       }
 
        if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
                error = dbus_message_get_error_name(reply);
@@ -381,17 +445,33 @@ static void request_input_login_reply(DBusMessage *reply, void *user_data)
                if (g_str_equal(key, "Username")) {
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry)
-                                                       != DBUS_TYPE_VARIANT)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
                        dbus_message_iter_get_basic(&value, &username);
 
                } else if (g_str_equal(key, "Password")) {
                        dbus_message_iter_next(&entry);
                        if (dbus_message_iter_get_arg_type(&entry) !=
-                                                       DBUS_TYPE_VARIANT)
+                                                       DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
                                break;
+                       }
+
                        dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
                        dbus_message_iter_get_basic(&value, &password);
                }
 
@@ -399,13 +479,11 @@ static void request_input_login_reply(DBusMessage *reply, void *user_data)
        }
 
 done:
-       username_password_reply->callback(username_password_reply->service,
-                                       values_received, NULL, 0,
-                                       username, password,
-                                       FALSE, NULL, error,
-                                       username_password_reply->user_data);
+       username_password_reply->service_callback(
+                       username_password_reply->service, values_received,
+                       NULL, 0, username, password, FALSE, NULL, error,
+                       username_password_reply->user_data);
 
-out:
        g_free(username_password_reply);
 }
 
@@ -477,7 +555,7 @@ int __connman_agent_request_passphrase_input(struct connman_service *service,
        }
 
        passphrase_reply->service = service;
-       passphrase_reply->callback = callback;
+       passphrase_reply->service_callback = callback;
        passphrase_reply->user_data = user_data;
 
        err = connman_agent_queue_message(service, message,
@@ -542,7 +620,7 @@ int __connman_agent_request_login_input(struct connman_service *service,
        }
 
        username_password_reply->service = service;
-       username_password_reply->callback = callback;
+       username_password_reply->service_callback = callback;
        username_password_reply->user_data = user_data;
 
        err = connman_agent_queue_message(service, message,
@@ -573,6 +651,11 @@ static void request_browser_reply(DBusMessage *reply, void *user_data)
        bool result = false;
        const char *error = NULL;
 
+       if (!reply) {
+               error = CONNMAN_ERROR_INTERFACE ".OperationAborted";
+               goto done;
+       }
+
        if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
                error = dbus_message_get_error_name(reply);
                goto done;
@@ -644,3 +727,147 @@ int __connman_agent_request_browser(struct connman_service *service,
 
        return -EINPROGRESS;
 }
+
+int __connman_agent_report_peer_error(struct connman_peer *peer,
+                                       const char *path, const char *error,
+                                       report_error_cb_t callback,
+                                       const char *dbus_sender,
+                                       void *user_data)
+{
+       return connman_agent_report_error_full(peer, path, "ReportPeerError",
+                               error, callback, dbus_sender, user_data);
+}
+
+static void request_peer_authorization_reply(DBusMessage *reply,
+                                                       void *user_data)
+{
+       struct request_input_reply *auth_reply = user_data;
+       DBusMessageIter iter, dict;
+       const char *error = NULL;
+       bool choice_done = false;
+       char *wpspin = NULL;
+       char *key;
+
+       if (!reply) {
+               error = CONNMAN_ERROR_INTERFACE ".OperationAborted";
+               goto done;
+       }
+
+       if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) {
+               error = dbus_message_get_error_name(reply);
+               goto done;
+       }
+
+       if (!check_reply_has_dict(reply))
+               goto done;
+
+       dbus_message_iter_init(reply, &iter);
+       dbus_message_iter_recurse(&iter, &dict);
+       while (dbus_message_iter_get_arg_type(&dict) == DBUS_TYPE_DICT_ENTRY) {
+               DBusMessageIter entry, value;
+
+               dbus_message_iter_recurse(&dict, &entry);
+               if (dbus_message_iter_get_arg_type(&entry) != DBUS_TYPE_STRING) {
+                       error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                       break;
+               }
+
+               dbus_message_iter_get_basic(&entry, &key);
+
+               if (g_str_equal(key, "WPS")) {
+                       choice_done = true;
+
+                       dbus_message_iter_next(&entry);
+                       if (dbus_message_iter_get_arg_type(&entry)
+                                                       != DBUS_TYPE_VARIANT) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
+                       dbus_message_iter_recurse(&entry, &value);
+                       if (dbus_message_iter_get_arg_type(&value) != DBUS_TYPE_STRING) {
+                               error = CONNMAN_ERROR_INTERFACE ".InvalidArguments";
+                               break;
+                       }
+
+                       dbus_message_iter_get_basic(&value, &wpspin);
+                       break;
+               }
+               dbus_message_iter_next(&dict);
+       }
+
+       if (!auth_reply->wps_requested)
+               choice_done = true;
+
+done:
+       auth_reply->peer_callback(auth_reply->peer, choice_done, wpspin,
+                                               error, auth_reply->user_data);
+
+       g_free(auth_reply);
+}
+
+int __connman_agent_request_peer_authorization(struct connman_peer *peer,
+                                               peer_wps_cb_t callback,
+                                               bool wps_requested,
+                                               const char *dbus_sender,
+                                               void *user_data)
+{
+       struct request_wps_data wps = { .peer = true };
+       const char *path, *agent_sender, *agent_path;
+       struct request_input_reply *auth_reply;
+       DBusMessageIter dict, iter;
+       DBusMessage *message;
+       void *agent;
+       int err;
+
+       agent = connman_agent_get_info(dbus_sender, &agent_sender,
+                                                       &agent_path);
+       DBG("agent %p peer %p path %s", agent, peer, agent_path);
+
+       if (!peer || !agent || !agent_path || !callback)
+               return -ESRCH;
+
+       message = dbus_message_new_method_call(agent_sender, agent_path,
+                       CONNMAN_AGENT_INTERFACE, "RequestPeerAuthorization");
+       if (!message)
+               return -ENOMEM;
+
+       dbus_message_iter_init_append(message, &iter);
+
+       path = __connman_peer_get_path(peer);
+       dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH, &path);
+
+       connman_dbus_dict_open(&iter, &dict);
+
+       if (wps_requested)
+               connman_dbus_dict_append_dict(&dict, "WPS",
+                                       request_input_append_wps, &wps);
+
+       connman_dbus_dict_close(&iter, &dict);
+
+       auth_reply = g_try_new0(struct request_input_reply, 1);
+       if (!auth_reply) {
+               dbus_message_unref(message);
+               return -ENOMEM;
+       }
+
+       auth_reply->peer = peer;
+       auth_reply->peer_callback = callback;
+       auth_reply->wps_requested = wps_requested;
+       auth_reply->user_data = user_data;
+
+       err = connman_agent_queue_message(peer, message,
+                                       connman_timeout_input_request(),
+                                       request_peer_authorization_reply,
+                                       auth_reply, agent);
+       if (err < 0 && err != -EBUSY) {
+               DBG("error %d sending agent message", err);
+               dbus_message_unref(message);
+               g_free(auth_reply);
+               return err;
+       }
+
+       dbus_message_unref(message);
+
+       return -EINPROGRESS;
+}