#include "system.h"
const char *__progname;
-#define _AUTOHELP
-
-#include <sys/wait.h>
-#if HAVE_MCHECK_H
-#include <mcheck.h>
-#endif
+#include <errno.h>
+#include <libgen.h>
+#include <ctype.h>
#include <rpm/rpmcli.h>
#include <rpm/rpmlib.h> /* RPMSIGTAG, rpmReadPackageFile .. */
#include <rpm/rpmps.h>
#include <rpm/rpmts.h>
#include "lib/signature.h"
-#include "build.h"
+#include "cliutils.h"
#include "debug.h"
+static struct rpmBuildArguments_s rpmBTArgs;
+
+#define POPT_NOLANG -1012
+#define POPT_RMSOURCE -1013
+#define POPT_RMBUILD -1014
+#define POPT_BUILDROOT -1015
+#define POPT_TARGETPLATFORM -1016
+#define POPT_NOBUILD -1017
+#define POPT_RMSPEC -1019
+#define POPT_NODIRTOKENS -1020
+
+#define POPT_REBUILD 0x4220
+#define POPT_RECOMPILE 0x4320
+#define POPT_BA 0x6261
+#define POPT_BB 0x6262
+#define POPT_BC 0x6263
+#define POPT_BI 0x6269
+#define POPT_BL 0x626c
+#define POPT_BP 0x6270
+#define POPT_BS 0x6273
+#define POPT_TA 0x7461
+#define POPT_TB 0x7462
+#define POPT_TC 0x7463
+#define POPT_TI 0x7469
+#define POPT_TL 0x746c
+#define POPT_TP 0x7470
+#define POPT_TS 0x7473
+
+extern int _fsm_debug;
+
+static rpmSpecFlags spec_flags = 0; /*!< Bit(s) to control spec parsing. */
+static int noDeps = 0; /*!< from --nodeps */
+static int shortCircuit = 0; /*!< from --short-circuit */
+static char buildMode = 0; /*!< Build mode (one of "btBC") */
+static char buildChar = 0; /*!< Build stage (one of "abcilps ") */
+static rpmBuildFlags nobuildAmount = 0; /*!< Build stage disablers */
+static ARGV_t build_targets = NULL; /*!< Target platform(s) */
+
+static void buildArgCallback( poptContext con,
+ enum poptCallbackReason reason,
+ const struct poptOption * opt, const char * arg,
+ const void * data)
+{
+ BTA_t rba = &rpmBTArgs;
+
+ switch (opt->val) {
+ case POPT_REBUILD:
+ case POPT_RECOMPILE:
+ case POPT_BA:
+ case POPT_BB:
+ case POPT_BC:
+ case POPT_BI:
+ case POPT_BL:
+ case POPT_BP:
+ case POPT_BS:
+ case POPT_TA:
+ case POPT_TB:
+ case POPT_TC:
+ case POPT_TI:
+ case POPT_TL:
+ case POPT_TP:
+ case POPT_TS:
+ if (opt->val == POPT_BS || opt->val == POPT_TS)
+ noDeps = 1;
+ if (buildMode == '\0' && buildChar == '\0') {
+ buildMode = (((unsigned)opt->val) >> 8) & 0xff;
+ buildChar = (opt->val ) & 0xff;
+ }
+ break;
+
+ case POPT_NODIRTOKENS: rba->pkgFlags |= RPMBUILD_PKG_NODIRTOKENS; break;
+ case POPT_NOBUILD: rba->buildAmount |= RPMBUILD_NOBUILD; break;
+ case POPT_NOLANG: spec_flags |= RPMSPEC_NOLANG; break;
+ case POPT_RMSOURCE: rba->buildAmount |= RPMBUILD_RMSOURCE; break;
+ case POPT_RMSPEC: rba->buildAmount |= RPMBUILD_RMSPEC; break;
+ case POPT_RMBUILD: rba->buildAmount |= RPMBUILD_RMBUILD; break;
+ case POPT_BUILDROOT:
+ if (rba->buildRootOverride) {
+ rpmlog(RPMLOG_ERR, _("buildroot already specified, ignoring %s\n"), arg);
+ break;
+ }
+ rba->buildRootOverride = xstrdup(arg);
+ break;
+ case POPT_TARGETPLATFORM:
+ argvSplit(&build_targets, arg, ",");
+ break;
+
+ case RPMCLI_POPT_FORCE:
+ spec_flags |= RPMSPEC_FORCE;
+ break;
+
+ }
+}
+
+static struct poptOption rpmBuildPoptTable[] = {
+ { NULL, '\0', POPT_ARG_CALLBACK | POPT_CBFLAG_INC_DATA | POPT_CBFLAG_CONTINUE,
+ buildArgCallback, 0, NULL, NULL },
+
+ { "bp", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BP,
+ N_("build through %prep (unpack sources and apply patches) from <specfile>"),
+ N_("<specfile>") },
+ { "bc", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BC,
+ N_("build through %build (%prep, then compile) from <specfile>"),
+ N_("<specfile>") },
+ { "bi", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BI,
+ N_("build through %install (%prep, %build, then install) from <specfile>"),
+ N_("<specfile>") },
+ { "bl", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BL,
+ N_("verify %files section from <specfile>"),
+ N_("<specfile>") },
+ { "ba", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BA,
+ N_("build source and binary packages from <specfile>"),
+ N_("<specfile>") },
+ { "bb", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BB,
+ N_("build binary package only from <specfile>"),
+ N_("<specfile>") },
+ { "bs", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_BS,
+ N_("build source package only from <specfile>"),
+ N_("<specfile>") },
+
+ { "tp", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TP,
+ N_("build through %prep (unpack sources and apply patches) from <tarball>"),
+ N_("<tarball>") },
+ { "tc", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TC,
+ N_("build through %build (%prep, then compile) from <tarball>"),
+ N_("<tarball>") },
+ { "ti", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TI,
+ N_("build through %install (%prep, %build, then install) from <tarball>"),
+ N_("<tarball>") },
+ { "tl", 0, POPT_ARGFLAG_ONEDASH|POPT_ARGFLAG_DOC_HIDDEN, 0, POPT_TL,
+ N_("verify %files section from <tarball>"),
+ N_("<tarball>") },
+ { "ta", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TA,
+ N_("build source and binary packages from <tarball>"),
+ N_("<tarball>") },
+ { "tb", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TB,
+ N_("build binary package only from <tarball>"),
+ N_("<tarball>") },
+ { "ts", 0, POPT_ARGFLAG_ONEDASH, 0, POPT_TS,
+ N_("build source package only from <tarball>"),
+ N_("<tarball>") },
+
+ { "rebuild", '\0', 0, 0, POPT_REBUILD,
+ N_("build binary package from <source package>"),
+ N_("<source package>") },
+ { "recompile", '\0', 0, 0, POPT_RECOMPILE,
+ N_("build through %install (%prep, %build, then install) from <source package>"),
+ N_("<source package>") },
+
+ { "buildroot", '\0', POPT_ARG_STRING, 0, POPT_BUILDROOT,
+ N_("override build root"), "DIRECTORY" },
+ { "clean", '\0', 0, 0, POPT_RMBUILD,
+ N_("remove build tree when done"), NULL},
+ { "force", '\0', POPT_ARGFLAG_DOC_HIDDEN, 0, RPMCLI_POPT_FORCE,
+ N_("ignore ExcludeArch: directives from spec file"), NULL},
+ { "fsmdebug", '\0', (POPT_ARG_VAL|POPT_ARGFLAG_DOC_HIDDEN), &_fsm_debug, -1,
+ N_("debug file state machine"), NULL},
+ { "nobuild", '\0', 0, 0, POPT_NOBUILD,
+ N_("do not execute any stages of the build"), NULL },
+ { "nodeps", '\0', POPT_ARG_VAL, &noDeps, 1,
+ N_("do not verify build dependencies"), NULL },
+ { "nodirtokens", '\0', 0, 0, POPT_NODIRTOKENS,
+ N_("generate package header(s) compatible with (legacy) rpm v3 packaging"),
+ NULL},
+
+ { "noclean", '\0', POPT_BIT_SET, &nobuildAmount, RPMBUILD_CLEAN,
+ N_("do not execute %clean stage of the build"), NULL },
+ { "nocheck", '\0', POPT_BIT_SET, &nobuildAmount, RPMBUILD_CHECK,
+ N_("do not execute %check stage of the build"), NULL },
+
+ { "nolang", '\0', POPT_ARGFLAG_DOC_HIDDEN, 0, POPT_NOLANG,
+ N_("do not accept i18N msgstr's from specfile"), NULL},
+ { "rmsource", '\0', 0, 0, POPT_RMSOURCE,
+ N_("remove sources when done"), NULL},
+ { "rmspec", '\0', 0, 0, POPT_RMSPEC,
+ N_("remove specfile when done"), NULL},
+ { "short-circuit", '\0', POPT_ARG_VAL, &shortCircuit, 1,
+ N_("skip straight to specified stage (only for c,i)"), NULL },
+ { "target", '\0', POPT_ARG_STRING, 0, POPT_TARGETPLATFORM,
+ N_("override target platform"), "CPU-VENDOR-OS" },
+ POPT_TABLEEND
+};
+
enum modes {
MODE_BUILD = (1 << 4),
MODE_REBUILD = (1 << 5),
N_("Build options with [ <specfile> | <tarball> | <source package> ]:"),
NULL },
- { "quiet", '\0', 0, &quiet, 0, NULL, NULL},
+ { "quiet", '\0', POPT_ARGFLAG_DOC_HIDDEN, &quiet, 0, NULL, NULL},
{ NULL, '\0', POPT_ARG_INCLUDE_TABLE, rpmcliAllPoptTable, 0,
N_("Common options for all rpm modes and executables:"),
POPT_TABLEEND
};
-#ifdef __MINT__
-/* MiNT cannot dynamically increase the stack. */
-long _stksize = 64 * 1024L;
-#endif
-
-RPM_GNUC_NORETURN
-static void argerror(const char * desc)
+static int checkSpec(rpmts ts, rpmSpec spec)
{
- fprintf(stderr, _("%s: %s\n"), __progname, desc);
- exit(EXIT_FAILURE);
-}
+ int rc;
+ rpmps ps = rpmSpecCheckDeps(ts, spec);
-static void printVersion(FILE * fp)
-{
- fprintf(fp, _("RPM version %s\n"), rpmEVR);
+ if (ps) {
+ rpmlog(RPMLOG_ERR, _("Failed build dependencies:\n"));
+ rpmpsPrint(NULL, ps);
+ }
+ rc = (ps != NULL);
+ rpmpsFree(ps);
+ return rc;
}
-static void printBanner(FILE * fp)
+static int isSpecFile(const char * specfile)
{
- fprintf(fp, _("Copyright (C) 1998-2002 - Red Hat, Inc.\n"));
- fprintf(fp, _("This program may be freely redistributed under the terms of the GNU GPL\n"));
+ char buf[256];
+ const char * s;
+ FILE * f;
+ int count;
+ int checking;
+
+ f = fopen(specfile, "r");
+ if (f == NULL) {
+ rpmlog(RPMLOG_ERR, _("Unable to open spec file %s: %s\n"),
+ specfile, strerror(errno));
+ return 0;
+ }
+ count = fread(buf, sizeof(buf[0]), sizeof(buf), f);
+ (void) fclose(f);
+
+ if (count == 0)
+ return 0;
+
+ checking = 1;
+ for (s = buf; count--; s++) {
+ switch (*s) {
+ case '\r':
+ case '\n':
+ checking = 1;
+ break;
+ case ':':
+ checking = 0;
+ break;
+ default:
+#if 0
+ if (checking && !(isprint(*s) || isspace(*s))) return 0;
+ break;
+#else
+ if (checking && !(isprint(*s) || isspace(*s)) && *(unsigned char *)s < 32) return 0;
+ break;
+#endif
+ }
+ }
+ return 1;
}
-static void printUsage(poptContext con, FILE * fp, int flags)
+/*
+ * Try to find a spec from a tarball pointed to by arg.
+ * Return absolute path to spec name on success, otherwise NULL.
+ */
+static char * getTarSpec(const char *arg)
{
- printVersion(fp);
- printBanner(fp);
- fprintf(fp, "\n");
-
- if (rpmIsVerbose())
- poptPrintHelp(con, fp, flags);
- else
- poptPrintUsage(con, fp, flags);
+ char *specFile = NULL;
+ char *specDir;
+ char *specBase;
+ char *tmpSpecFile;
+ const char **spec;
+ char tarbuf[BUFSIZ];
+ int gotspec = 0, res;
+ static const char *tryspec[] = { "Specfile", "\\*.spec", NULL };
+
+ specDir = rpmGetPath("%{_specdir}", NULL);
+ tmpSpecFile = rpmGetPath("%{_specdir}/", "rpm-spec.XXXXXX", NULL);
+
+ (void) close(mkstemp(tmpSpecFile));
+
+ for (spec = tryspec; *spec != NULL; spec++) {
+ FILE *fp;
+ char *cmd;
+
+ cmd = rpmExpand("%{uncompress: ", arg, "} | ",
+ "%{__tar} xOvf - --wildcards ", *spec,
+ " 2>&1 > ", tmpSpecFile, NULL);
+
+ if (!(fp = popen(cmd, "r"))) {
+ rpmlog(RPMLOG_ERR, _("Failed to open tar pipe: %m\n"));
+ } else {
+ char *fok;
+ for (;;) {
+ fok = fgets(tarbuf, sizeof(tarbuf) - 1, fp);
+ /* tar sometimes prints "tar: Record size = 16" messages */
+ if (!fok || strncmp(fok, "tar: ", 5) != 0)
+ break;
+ }
+ pclose(fp);
+ gotspec = (fok != NULL) && isSpecFile(tmpSpecFile);
+ }
+
+ if (!gotspec)
+ unlink(tmpSpecFile);
+ free(cmd);
+ }
+
+ if (!gotspec) {
+ rpmlog(RPMLOG_ERR, _("Failed to read spec file from %s\n"), arg);
+ goto exit;
+ }
+
+ specBase = basename(tarbuf);
+ /* remove trailing \n */
+ specBase[strlen(specBase)-1] = '\0';
+
+ rasprintf(&specFile, "%s/%s", specDir, specBase);
+ res = rename(tmpSpecFile, specFile);
+
+ if (res) {
+ rpmlog(RPMLOG_ERR, _("Failed to rename %s to %s: %m\n"),
+ tmpSpecFile, specFile);
+ free(specFile);
+ specFile = NULL;
+ } else {
+ /* mkstemp() can give unnecessarily strict permissions, fixup */
+ mode_t mask;
+ umask(mask = umask(0));
+ (void) chmod(specFile, 0666 & ~mask);
+ }
+
+exit:
+ (void) unlink(tmpSpecFile);
+ free(tmpSpecFile);
+ free(specDir);
+ return specFile;
}
-int main(int argc, char *argv[])
+static int buildForTarget(rpmts ts, const char * arg, BTA_t ba)
{
- rpmts ts = NULL;
- enum modes bigMode = MODE_BUILD;
- BTA_t ba = &rpmBTArgs;
- char * passPhrase = "";
+ int buildAmount = ba->buildAmount;
+ char * buildRootURL = NULL;
+ char * specFile = NULL;
+ rpmSpec spec = NULL;
+ int rc = 1; /* assume failure */
+ int justRm = ((buildAmount & ~(RPMBUILD_RMSOURCE|RPMBUILD_RMSPEC)) == 0);
+ rpmSpecFlags specFlags = spec_flags;
+
+ if (ba->buildRootOverride)
+ buildRootURL = rpmGenPath(NULL, ba->buildRootOverride, NULL);
+
+ /* Create build tree if necessary */
+ const char * buildtree = "%{_topdir}:%{_specdir}:%{_sourcedir}:%{_builddir}:%{_rpmdir}:%{_srcrpmdir}:%{_buildrootdir}";
+ const char * rootdir = rpmtsRootDir(ts);
+ if (rpmMkdirs(!rstreq(rootdir, "/") ? rootdir : NULL , buildtree)) {
+ goto exit;
+ }
- int arg;
- const char *optArg;
- const char *poptCtx = "rpmbuild";
- const char *pkg = NULL;
- pid_t pipeChild = 0;
- poptContext optCon;
- int ec = 0;
- int status;
- int p[2];
-
-#if HAVE_MCHECK_H && HAVE_MTRACE
- mtrace(); /* Trace malloc only if MALLOC_TRACE=mtrace-output-file. */
-#endif
- setprogname(argv[0]); /* Retrofit glibc __progname */
+ if (buildMode == 't') {
+ char *srcdir = NULL, *dir;
- /* XXX glibc churn sanity */
- if (__progname == NULL) {
- if ((__progname = strrchr(argv[0], '/')) != NULL) __progname++;
- else __progname = argv[0];
+ specFile = getTarSpec(arg);
+ if (!specFile)
+ goto exit;
+
+ /* Make the directory of the tarball %_sourcedir for this run */
+ /* dirname() may modify contents so extra hoops needed. */
+ if (*arg != '/') {
+ dir = rpmGetCwd();
+ rstrscat(&dir, "/", arg, NULL);
+ } else {
+ dir = xstrdup(arg);
+ }
+ srcdir = dirname(dir);
+ addMacro(NULL, "_sourcedir", NULL, srcdir, RMIL_TARBALL);
+ free(dir);
+ } else {
+ specFile = xstrdup(arg);
}
-#if defined(ENABLE_NLS)
- /* set up the correct locale */
- (void) setlocale(LC_ALL, "" );
+ if (*specFile != '/') {
+ char *cwd = rpmGetCwd();
+ char *s = NULL;
+ rasprintf(&s, "%s/%s", cwd, specFile);
+ free(cwd);
+ free(specFile);
+ specFile = s;
+ }
- bindtextdomain(PACKAGE, LOCALEDIR);
- textdomain(PACKAGE);
-#endif
+ struct stat st;
+ if (stat(specFile, &st) < 0) {
+ rpmlog(RPMLOG_ERR, _("failed to stat %s: %m\n"), specFile);
+ goto exit;
+ }
+ if (! S_ISREG(st.st_mode)) {
+ rpmlog(RPMLOG_ERR, _("File %s is not a regular file.\n"), specFile);
+ goto exit;
+ }
- rpmSetVerbosity(RPMLOG_NOTICE); /* XXX silly use by showrc */
+ /* Try to verify that the file is actually a specfile */
+ if (!isSpecFile(specFile)) {
+ rpmlog(RPMLOG_ERR,
+ _("File %s does not appear to be a specfile.\n"), specFile);
+ goto exit;
+ }
+
+ /* Don't parse spec if only its removal is requested */
+ if (ba->buildAmount == RPMBUILD_RMSPEC) {
+ rc = unlink(specFile);
+ goto exit;
+ }
- /* Make a first pass through the arguments, looking for --rcfile */
- /* We need to handle that before dealing with the rest of the arguments. */
- /* XXX popt argv definition should be fixed instead of casting... */
- optCon = poptGetContext(poptCtx, argc, (const char **)argv, optionsTable, 0);
- {
- char *poptfile = rpmGenPath(rpmConfigDir(), LIBRPMALIAS_FILENAME, NULL);
- (void) poptReadConfigFile(optCon, poptfile);
- free(poptfile);
+ /* Parse the spec file */
+#define _anyarch(_f) \
+(((_f)&(RPMBUILD_PREP|RPMBUILD_BUILD|RPMBUILD_INSTALL|RPMBUILD_PACKAGEBINARY)) == 0)
+ if (_anyarch(buildAmount))
+ specFlags |= RPMSPEC_ANYARCH;
+#undef _anyarch
+
+ spec = rpmSpecParse(specFile, specFlags, buildRootURL);
+ if (spec == NULL) {
+ goto exit;
}
- (void) poptReadDefaultConfig(optCon, 1);
- poptSetExecPath(optCon, rpmConfigDir(), 1);
- while ((arg = poptGetNextOpt(optCon)) > 0) {
- optArg = poptGetOptArg(optCon);
+ /* Check build prerequisites if necessary, unless disabled */
+ if (!justRm && !noDeps && checkSpec(ts, spec)) {
+ goto exit;
+ }
- switch (arg) {
- default:
- fprintf(stderr, _("Internal error in argument processing (%d) :-(\n"), arg);
- exit(EXIT_FAILURE);
- }
+ if (rpmSpecBuild(spec, ba)) {
+ goto exit;
}
+
+ if (buildMode == 't')
+ (void) unlink(specFile);
+ rc = 0;
- if (arg < -1) {
- fprintf(stderr, "%s: %s\n",
- poptBadOption(optCon, POPT_BADOPTION_NOALIAS),
- poptStrerror(arg));
- exit(EXIT_FAILURE);
+exit:
+ free(specFile);
+ rpmSpecFree(spec);
+ free(buildRootURL);
+ return rc;
+}
+
+static int build(rpmts ts, const char * arg, BTA_t ba, const char * rcfile)
+{
+ int rc = 0;
+ char * targets = argvJoin(build_targets, ",");
+#define buildCleanMask (RPMBUILD_RMSOURCE|RPMBUILD_RMSPEC)
+ int cleanFlags = ba->buildAmount & buildCleanMask;
+ rpmVSFlags vsflags, ovsflags;
+
+ vsflags = rpmExpandNumeric("%{_vsflags_build}");
+ if (rpmcliQueryFlags & VERIFY_DIGEST)
+ vsflags |= _RPMVSF_NODIGESTS;
+ if (rpmcliQueryFlags & VERIFY_SIGNATURE)
+ vsflags |= _RPMVSF_NOSIGNATURES;
+ if (rpmcliQueryFlags & VERIFY_HDRCHK)
+ vsflags |= RPMVSF_NOHDRCHK;
+ ovsflags = rpmtsSetVSFlags(ts, vsflags);
+
+ if (build_targets == NULL) {
+ rc = buildForTarget(ts, arg, ba);
+ goto exit;
}
+ /* parse up the build operators */
+
+ printf(_("Building target platforms: %s\n"), targets);
+
+ ba->buildAmount &= ~buildCleanMask;
+ for (ARGV_const_t target = build_targets; target && *target; target++) {
+ /* Perform clean-up after last target build. */
+ if (*(target + 1) == NULL)
+ ba->buildAmount |= cleanFlags;
+
+ printf(_("Building for target %s\n"), *target);
+
+ /* Read in configuration for target. */
+ rpmFreeMacros(NULL);
+ rpmFreeRpmrc();
+ (void) rpmReadConfigFiles(rcfile, *target);
+ rc = buildForTarget(ts, arg, ba);
+ if (rc)
+ break;
+ }
+
+exit:
+ rpmtsSetVSFlags(ts, ovsflags);
+ /* Restore original configuration. */
+ rpmFreeMacros(NULL);
+ rpmFreeRpmrc();
+ (void) rpmReadConfigFiles(rcfile, NULL);
+ free(targets);
+
+ return rc;
+}
+
+int main(int argc, char *argv[])
+{
+ rpmts ts = NULL;
+ enum modes bigMode = MODE_BUILD;
+ BTA_t ba = &rpmBTArgs;
+
+ const char *pkg = NULL;
+ int ec = 0;
+ poptContext optCon = rpmcliInit(argc, argv, optionsTable);
+
if (argc <= 1 || poptPeekArg(optCon) == NULL) {
printUsage(optCon, stderr, 0);
exit(EXIT_FAILURE);
}
- rpmcliConfigured();
-
- switch (ba->buildMode) {
+ switch (buildMode) {
case 'b': bigMode = MODE_BUILD; break;
case 't': bigMode = MODE_TARBUILD; break;
case 'B': bigMode = MODE_REBUILD; break;
argerror(_("arguments to --root (-r) must begin with a /"));
}
- if (ba->sign) {
- int sigTag = rpmLookupSignatureType(RPMLOOKUPSIG_QUERY);
- switch (sigTag) {
- case 0:
- break;
- case RPMSIGTAG_PGP:
- case RPMSIGTAG_GPG:
- case RPMSIGTAG_DSA:
- case RPMSIGTAG_RSA:
- passPhrase = rpmGetPassPhrase(_("Enter pass phrase: "), sigTag);
- if (passPhrase == NULL) {
- fprintf(stderr, _("Pass phrase check failed\n"));
- ec = EXIT_FAILURE;
- goto exit;
- }
- fprintf(stderr, _("Pass phrase is good.\n"));
- passPhrase = xstrdup(passPhrase);
- break;
- default:
- fprintf(stderr, _("Invalid %%_signature spec in macro file.\n"));
- ec = EXIT_FAILURE;
- goto exit;
- break;
- }
- } else {
- /* Make rpmLookupSignatureType() return 0 ("none") from now on */
- (void) rpmLookupSignatureType(RPMLOOKUPSIG_DISABLE);
- }
-
/* rpmbuild is rather chatty by default */
rpmSetVerbosity(quiet ? RPMLOG_WARNING : RPMLOG_INFO);
- if (rpmcliPipeOutput) {
- if (pipe(p) < 0) {
- fprintf(stderr, _("creating a pipe for --pipe failed: %m\n"));
- goto exit;
- }
-
- if (!(pipeChild = fork())) {
- (void) signal(SIGPIPE, SIG_DFL);
- (void) close(p[1]);
- (void) dup2(p[0], STDIN_FILENO);
- (void) close(p[0]);
- (void) execl("/bin/sh", "/bin/sh", "-c", rpmcliPipeOutput, NULL);
- fprintf(stderr, _("exec failed\n"));
- }
-
- (void) close(p[0]);
- (void) dup2(p[1], STDOUT_FILENO);
- (void) close(p[1]);
- }
+ if (rpmcliPipeOutput && initPipe())
+ exit(EXIT_FAILURE);
ts = rpmtsCreate();
(void) rpmtsSetRootDir(ts, rpmcliRootDir);
ba->buildAmount |= RPMBUILD_CLEAN;
ba->buildAmount |= RPMBUILD_RMBUILD;
}
+ ba->buildAmount &= ~(nobuildAmount);
while ((pkg = poptGetArg(optCon))) {
char * specFile = NULL;
ec = rpmInstallSource(ts, pkg, &specFile, &ba->cookie);
if (ec == 0) {
ba->rootdir = rpmcliRootDir;
- ba->passPhrase = passPhrase;
ec = build(ts, specFile, ba, rpmcliRcfile);
}
ba->cookie = _free(ba->cookie);
break;
case MODE_BUILD:
case MODE_TARBUILD:
- switch (ba->buildChar) {
+ switch (buildChar) {
case 'a':
ba->buildAmount |= RPMBUILD_PACKAGESOURCE;
case 'b':
ba->buildAmount |= RPMBUILD_PACKAGEBINARY;
ba->buildAmount |= RPMBUILD_CLEAN;
- if ((ba->buildChar == 'b') && ba->shortCircuit)
+ if ((buildChar == 'b') && shortCircuit)
break;
case 'i':
ba->buildAmount |= RPMBUILD_INSTALL;
ba->buildAmount |= RPMBUILD_CHECK;
- if ((ba->buildChar == 'i') && ba->shortCircuit)
+ if ((buildChar == 'i') && shortCircuit)
break;
case 'c':
ba->buildAmount |= RPMBUILD_BUILD;
- if ((ba->buildChar == 'c') && ba->shortCircuit)
+ if ((buildChar == 'c') && shortCircuit)
break;
case 'p':
ba->buildAmount |= RPMBUILD_PREP;
ba->buildAmount |= RPMBUILD_PACKAGESOURCE;
break;
}
+ ba->buildAmount &= ~(nobuildAmount);
while ((pkg = poptGetArg(optCon))) {
ba->rootdir = rpmcliRootDir;
- ba->passPhrase = passPhrase;
ba->cookie = NULL;
ec = build(ts, pkg, ba, rpmcliRcfile);
if (ec)
break;
}
-exit:
-
- ts = rpmtsFree(ts);
-
- optCon = poptFreeContext(optCon);
- rpmFreeMacros(NULL);
- rpmFreeMacros(rpmCLIMacroContext);
- rpmFreeRpmrc();
-
- if (pipeChild) {
- (void) fclose(stdout);
- (void) waitpid(pipeChild, &status, 0);
- }
-
- /* keeps memory leak checkers quiet */
- rpmlogClose();
-
- freeNames();
- ba->buildRootOverride = _free(ba->buildRootOverride);
- ba->targets = _free(ba->targets);
-
-#if HAVE_MCHECK_H && HAVE_MTRACE
- muntrace(); /* Trace malloc only if MALLOC_TRACE=mtrace-output-file. */
-#endif
+ rpmtsFree(ts);
+ if (finishPipe())
+ ec = EXIT_FAILURE;
+ free(ba->buildRootOverride);
+ argvFree(build_targets);
- /* XXX Avoid exit status overflow. Status 255 is special to xargs(1) */
- if (ec > 254) ec = 254;
+ rpmcliFini(optCon);
- return ec;
+ return RETVAL(ec);
}