#include "OCPlatform.h"
#include "OCResource.h"
+#include "ocpayload.h"
#include <OCSerialization.h>
using namespace std;
if(m_cfg.mode == ModeType::Client)
{
- OCStackResult result = OCInit(m_cfg.ipAddress.c_str(), m_cfg.port, OC_CLIENT);
+ OCTransportFlags serverFlags =
+ static_cast<OCTransportFlags>(m_cfg.serverConnectivity & CT_MASK_FLAGS);
+ OCTransportFlags clientFlags =
+ static_cast<OCTransportFlags>(m_cfg.clientConnectivity & CT_MASK_FLAGS);
+ OCStackResult result = OCInit1(OC_CLIENT, serverFlags, clientFlags);
if(OC_STACK_OK != result)
{
OCRepresentation parseGetSetCallback(OCClientResponse* clientResponse)
{
- if(clientResponse->resJSONPayload == nullptr || clientResponse->resJSONPayload[0] == '\0')
+ if(clientResponse->payload == nullptr ||
+ (
+ clientResponse->payload->type != PAYLOAD_TYPE_DEVICE &&
+ clientResponse->payload->type != PAYLOAD_TYPE_PLATFORM &&
+ clientResponse->payload->type != PAYLOAD_TYPE_REPRESENTATION
+ )
+ )
{
- throw OCException(OC::Exception::STR_NULL_RESPONSE, OC_STACK_ERROR);
+ //OCPayloadDestroy(clientResponse->payload);
+ return OCRepresentation();
}
MessageContainer oc;
- oc.setJSONRepresentation(clientResponse->resJSONPayload);
+ oc.setPayload(clientResponse->payload);
+ //OCPayloadDestroy(clientResponse->payload);
std::vector<OCRepresentation>::const_iterator it = oc.representations().begin();
if(it == oc.representations().end())
{
- throw OCException(OC::Exception::INVALID_REPRESENTATION, OC_STACK_ERROR);
+ return OCRepresentation();
}
// first one is considered the root, everything else is considered a child of this one.
OCRepresentation root = *it;
+ root.setDevAddr(clientResponse->devAddr);
+ root.setUri(clientResponse->resourceUri);
++it;
std::for_each(it, oc.representations().end(),
}
- OCStackApplicationResult listenCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult listenCallback(void* ctx, OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::ListenContext* context =
return OC_STACK_KEEP_TRANSACTION;
}
+ if(!clientResponse->payload || clientResponse->payload->type != PAYLOAD_TYPE_DISCOVERY)
+ {
+ oclog() << "listenCallback(): clientResponse payload was null or the wrong type"
+ << std::flush;
+ return OC_STACK_KEEP_TRANSACTION;
+ }
+
auto clientWrapper = context->clientWrapper.lock();
if(!clientWrapper)
return OC_STACK_KEEP_TRANSACTION;
}
- std::stringstream requestStream;
- requestStream << clientResponse->resJSONPayload;
-
- try
- {
- ListenOCContainer container(clientWrapper, *clientResponse->addr,
- requestStream);
-
+ try{
+ ListenOCContainer container(clientWrapper, clientResponse->devAddr,
+ reinterpret_cast<OCDiscoveryPayload*>(clientResponse->payload));
// loop to ensure valid construction of all resources
for(auto resource : container.Resources())
{
std::thread exec(context->callback, resource);
exec.detach();
}
-
}
- catch(const std::exception& e)
- {
- oclog() << "listenCallback failed to parse a malformed message: "
- << e.what()
- << std::endl <<std::endl
- << clientResponse->result
- << std::flush;
- return OC_STACK_KEEP_TRANSACTION;
+ catch (std::exception &e){
+ oclog() << "Exception in listCallback, ignoring response: "
+ << e.what() << std::flush;
}
+
return OC_STACK_KEEP_TRANSACTION;
}
- OCStackResult InProcClientWrapper::ListenForResource(const std::string& serviceUrl,
- const std::string& resourceType, FindCallback& callback, QualityOfService QoS)
+ OCStackResult InProcClientWrapper::ListenForResource(
+ const std::string& serviceUrl,
+ const std::string& resourceType,
+ OCConnectivityType connectivityType,
+ FindCallback& callback, QualityOfService QoS)
{
- OCStackResult result;
-
- OCCallbackData cbdata = {0};
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
- ClientCallbackContext::ListenContext* context = new ClientCallbackContext::ListenContext();
- context->callback = callback;
- context->clientWrapper = shared_from_this();
+ OCStackResult result;
+ ostringstream resourceUri;
+ resourceUri << serviceUrl << resourceType;
- cbdata.context = static_cast<void*>(context);
- cbdata.cb = listenCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::ListenContext*>(c);};
+ ClientCallbackContext::ListenContext* context =
+ new ClientCallbackContext::ListenContext(callback, shared_from_this());
+ OCCallbackData cbdata(
+ static_cast<void*>(context),
+ listenCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::ListenContext*>(c);}
+ );
auto cLock = m_csdkLock.lock();
if(cLock)
{
std::lock_guard<std::recursive_mutex> lock(*cLock);
- OCDoHandle handle;
- result = OCDoResource(&handle, OC_REST_GET,
- resourceType.c_str(),
- nullptr, nullptr,
+ result = OCDoResource(nullptr, OC_REST_DISCOVER,
+ resourceUri.str().c_str(),
+ nullptr, nullptr, connectivityType,
static_cast<OCQualityOfService>(QoS),
&cbdata,
- NULL, 0);
+ nullptr, 0);
}
else
{
return result;
}
- OCStackApplicationResult listenDeviceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult listenDeviceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::DeviceListenContext* context =
static_cast<ClientCallbackContext::DeviceListenContext*>(ctx);
- OCRepresentation rep = parseGetSetCallback(clientResponse);
- std::thread exec(context->callback, rep);
- exec.detach();
+ try
+ {
+ OCRepresentation rep = parseGetSetCallback(clientResponse);
+ std::thread exec(context->callback, rep);
+ exec.detach();
+ }
+ catch(OC::OCException& e)
+ {
+ oclog() <<"Exception in listenDeviceCallback, ignoring response: "
+ <<e.what() <<std::flush;
+ }
return OC_STACK_KEEP_TRANSACTION;
}
- OCStackResult InProcClientWrapper::ListenForDevice(const std::string& serviceUrl,
- const std::string& deviceURI, FindDeviceCallback& callback, QualityOfService QoS)
+ OCStackResult InProcClientWrapper::ListenForDevice(
+ const std::string& serviceUrl,
+ const std::string& deviceURI,
+ OCConnectivityType connectivityType,
+ FindDeviceCallback& callback,
+ QualityOfService QoS)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
-
- OCCallbackData cbdata = {0};
+ ostringstream deviceUri;
+ deviceUri << serviceUrl << deviceURI;
ClientCallbackContext::DeviceListenContext* context =
- new ClientCallbackContext::DeviceListenContext();
- context->callback = callback;
- context->clientWrapper = shared_from_this();
-
- cbdata.context = static_cast<void*>(context);
- cbdata.cb = listenDeviceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::DeviceListenContext*>(c);};
+ new ClientCallbackContext::DeviceListenContext(callback, shared_from_this());
+ OCCallbackData cbdata(
+ static_cast<void*>(context),
+ listenDeviceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::DeviceListenContext*>(c);}
+ );
auto cLock = m_csdkLock.lock();
if(cLock)
{
std::lock_guard<std::recursive_mutex> lock(*cLock);
- OCDoHandle handle;
- result = OCDoResource(&handle, OC_REST_GET,
- deviceURI.c_str(),
- nullptr, nullptr,
+ result = OCDoResource(nullptr, OC_REST_DISCOVER,
+ deviceUri.str().c_str(),
+ nullptr, nullptr, connectivityType,
static_cast<OCQualityOfService>(QoS),
&cbdata,
- NULL, 0);
+ nullptr, 0);
}
else
{
+ delete context;
result = OC_STACK_ERROR;
}
return result;
}
}
- OCStackApplicationResult getResourceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult getResourceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::GetContext* context =
OCRepresentation rep;
HeaderOptions serverHeaderOptions;
- if(clientResponse->result == OC_STACK_OK)
+ OCStackResult result = clientResponse->result;
+ if(result == OC_STACK_OK)
{
parseServerHeaderOptions(clientResponse, serverHeaderOptions);
- rep = parseGetSetCallback(clientResponse);
+ try
+ {
+ rep = parseGetSetCallback(clientResponse);
+ }
+ catch(OC::OCException& e)
+ {
+ result = e.code();
+ }
}
- std::thread exec(context->callback, serverHeaderOptions, rep, clientResponse->result);
+ std::thread exec(context->callback, serverHeaderOptions, rep, result);
exec.detach();
return OC_STACK_DELETE_TRANSACTION;
}
- OCStackResult InProcClientWrapper::GetResourceRepresentation(const std::string& host,
- const std::string& uri, const QueryParamsMap& queryParams,
- const HeaderOptions& headerOptions, GetCallback& callback,
- QualityOfService QoS)
+ OCStackResult InProcClientWrapper::GetResourceRepresentation(
+ const OCDevAddr& devAddr,
+ const std::string& resourceUri,
+ const QueryParamsMap& queryParams, const HeaderOptions& headerOptions,
+ GetCallback& callback, QualityOfService QoS)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
- OCCallbackData cbdata = {0};
+ ClientCallbackContext::GetContext* ctx =
+ new ClientCallbackContext::GetContext(callback);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ getResourceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::GetContext*>(c);}
+ );
- ClientCallbackContext::GetContext* ctx = new ClientCallbackContext::GetContext();
- ctx->callback = callback;
- cbdata.context = static_cast<void*>(ctx);
- cbdata.cb = &getResourceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::GetContext*>(c);};
+ std::string uri = assembleSetResourceUri(resourceUri, queryParams);
auto cLock = m_csdkLock.lock();
if(cLock)
{
- std::ostringstream os;
- os << host << assembleSetResourceUri(uri, queryParams).c_str();
-
std::lock_guard<std::recursive_mutex> lock(*cLock);
- OCDoHandle handle;
OCHeaderOption options[MAX_HEADER_OPTIONS];
- assembleHeaderOptions(options, headerOptions);
- result = OCDoResource(&handle, OC_REST_GET, os.str().c_str(),
- nullptr, nullptr,
+ result = OCDoResource(
+ nullptr, OC_REST_GET,
+ uri.c_str(),
+ &devAddr, nullptr,
+ CT_DEFAULT,
static_cast<OCQualityOfService>(QoS),
&cbdata,
- options, headerOptions.size());
+ assembleHeaderOptions(options, headerOptions),
+ headerOptions.size());
}
else
{
}
- OCStackApplicationResult setResourceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult setResourceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::SetContext* context =
OCRepresentation attrs;
HeaderOptions serverHeaderOptions;
- if (OC_STACK_OK == clientResponse->result ||
- OC_STACK_RESOURCE_CREATED == clientResponse->result ||
- OC_STACK_RESOURCE_DELETED == clientResponse->result)
+ OCStackResult result = clientResponse->result;
+ if (OC_STACK_OK == result ||
+ OC_STACK_RESOURCE_CREATED == result ||
+ OC_STACK_RESOURCE_DELETED == result)
{
parseServerHeaderOptions(clientResponse, serverHeaderOptions);
- attrs = parseGetSetCallback(clientResponse);
+ try
+ {
+ attrs = parseGetSetCallback(clientResponse);
+ }
+ catch(OC::OCException& e)
+ {
+ result = e.code();
+ }
}
- std::thread exec(context->callback, serverHeaderOptions, attrs, clientResponse->result);
+ std::thread exec(context->callback, serverHeaderOptions, attrs, result);
exec.detach();
return OC_STACK_DELETE_TRANSACTION;
}
for(auto& param : queryParams)
{
- paramsList << param.first <<'='<<param.second<<'&';
+ paramsList << param.first <<'='<<param.second<<';';
}
std::string queryString = paramsList.str();
- if(queryString.back() == '&')
+ if(queryString.back() == ';')
{
queryString.resize(queryString.size() - 1);
}
return ret;
}
- std::string InProcClientWrapper::assembleSetResourcePayload(const OCRepresentation& rep)
+ OCPayload* InProcClientWrapper::assembleSetResourcePayload(const OCRepresentation& rep)
{
MessageContainer ocInfo;
ocInfo.addRepresentation(rep);
- return ocInfo.getJSONRepresentation(OCInfoFormat::IncludeOC);
+ for(const OCRepresentation& r : rep.getChildren())
+ {
+ ocInfo.addRepresentation(r);
+ }
+
+ return reinterpret_cast<OCPayload*>(ocInfo.getPayload());
}
- OCStackResult InProcClientWrapper::PostResourceRepresentation(const std::string& host,
- const std::string& uri, const OCRepresentation& rep,
+ OCStackResult InProcClientWrapper::PostResourceRepresentation(
+ const OCDevAddr& devAddr,
+ const std::string& uri,
+ const OCRepresentation& rep,
const QueryParamsMap& queryParams, const HeaderOptions& headerOptions,
PostCallback& callback, QualityOfService QoS)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
- OCCallbackData cbdata = {0};
+ ClientCallbackContext::SetContext* ctx = new ClientCallbackContext::SetContext(callback);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ setResourceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::SetContext*>(c);}
+ );
- ClientCallbackContext::SetContext* ctx = new ClientCallbackContext::SetContext();
- ctx->callback = callback;
- cbdata.cb = &setResourceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::SetContext*>(c);};
- cbdata.context = static_cast<void*>(ctx);
-
- // TODO: in the future the cstack should be combining these two strings!
- ostringstream os;
- os << host << assembleSetResourceUri(uri, queryParams).c_str();
- // TODO: end of above
+ std::string url = assembleSetResourceUri(uri, queryParams);
auto cLock = m_csdkLock.lock();
{
std::lock_guard<std::recursive_mutex> lock(*cLock);
OCHeaderOption options[MAX_HEADER_OPTIONS];
- OCDoHandle handle;
- assembleHeaderOptions(options, headerOptions);
- result = OCDoResource(&handle, OC_REST_POST,
- os.str().c_str(), nullptr,
- assembleSetResourcePayload(rep).c_str(),
+ result = OCDoResource(nullptr, OC_REST_POST,
+ url.c_str(), &devAddr,
+ assembleSetResourcePayload(rep),
+ CT_DEFAULT,
static_cast<OCQualityOfService>(QoS),
- &cbdata, options, headerOptions.size());
+ &cbdata,
+ assembleHeaderOptions(options, headerOptions),
+ headerOptions.size());
}
else
{
return result;
}
-
- OCStackResult InProcClientWrapper::PutResourceRepresentation(const std::string& host,
- const std::string& uri, const OCRepresentation& rep,
+ OCStackResult InProcClientWrapper::PutResourceRepresentation(
+ const OCDevAddr& devAddr,
+ const std::string& uri,
+ const OCRepresentation& rep,
const QueryParamsMap& queryParams, const HeaderOptions& headerOptions,
PutCallback& callback, QualityOfService QoS)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
- OCCallbackData cbdata = {0};
+ ClientCallbackContext::SetContext* ctx = new ClientCallbackContext::SetContext(callback);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ setResourceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::SetContext*>(c);}
+ );
- ClientCallbackContext::SetContext* ctx = new ClientCallbackContext::SetContext();
- ctx->callback = callback;
- cbdata.cb = &setResourceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::SetContext*>(c);};
- cbdata.context = static_cast<void*>(ctx);
-
- // TODO: in the future the cstack should be combining these two strings!
- ostringstream os;
- os << host << assembleSetResourceUri(uri, queryParams).c_str();
- // TODO: end of above
+ std::string url = assembleSetResourceUri(uri, queryParams).c_str();
auto cLock = m_csdkLock.lock();
OCDoHandle handle;
OCHeaderOption options[MAX_HEADER_OPTIONS];
- assembleHeaderOptions(options, headerOptions);
result = OCDoResource(&handle, OC_REST_PUT,
- os.str().c_str(), nullptr,
- assembleSetResourcePayload(rep).c_str(),
+ url.c_str(), &devAddr,
+ assembleSetResourcePayload(rep),
+ CT_DEFAULT,
static_cast<OCQualityOfService>(QoS),
&cbdata,
- options, headerOptions.size());
+ assembleHeaderOptions(options, headerOptions),
+ headerOptions.size());
}
else
{
return result;
}
- OCStackApplicationResult deleteResourceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult deleteResourceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::DeleteContext* context =
return OC_STACK_DELETE_TRANSACTION;
}
- OCStackResult InProcClientWrapper::DeleteResource(const std::string& host,
- const std::string& uri, const HeaderOptions& headerOptions,
- DeleteCallback& callback, QualityOfService QoS)
+ OCStackResult InProcClientWrapper::DeleteResource(
+ const OCDevAddr& devAddr,
+ const std::string& uri,
+ const HeaderOptions& headerOptions,
+ DeleteCallback& callback,
+ QualityOfService /*QoS*/)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
- OCCallbackData cbdata = {0};
-
- ClientCallbackContext::DeleteContext* ctx = new ClientCallbackContext::DeleteContext();
- ctx->callback = callback;
- cbdata.cb = &deleteResourceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::DeleteContext*>(c);};
- cbdata.context = static_cast<void*>(ctx);
-
- ostringstream os;
- os << host << uri;
+ ClientCallbackContext::DeleteContext* ctx =
+ new ClientCallbackContext::DeleteContext(callback);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ deleteResourceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::DeleteContext*>(c);}
+ );
auto cLock = m_csdkLock.lock();
if(cLock)
{
OCHeaderOption options[MAX_HEADER_OPTIONS];
- OCDoHandle handle;
-
- assembleHeaderOptions(options, headerOptions);
std::lock_guard<std::recursive_mutex> lock(*cLock);
- result = OCDoResource(&handle, OC_REST_DELETE,
- os.str().c_str(), nullptr,
- nullptr, static_cast<OCQualityOfService>(m_cfg.QoS),
- &cbdata, options, headerOptions.size());
+ result = OCDoResource(nullptr, OC_REST_DELETE,
+ uri.c_str(), &devAddr,
+ nullptr,
+ CT_DEFAULT,
+ static_cast<OCQualityOfService>(m_cfg.QoS),
+ &cbdata,
+ assembleHeaderOptions(options, headerOptions),
+ headerOptions.size());
}
else
{
return result;
}
- OCStackApplicationResult observeResourceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult observeResourceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
ClientCallbackContext::ObserveContext* context =
OCRepresentation attrs;
HeaderOptions serverHeaderOptions;
uint32_t sequenceNumber = clientResponse->sequenceNumber;
-
+ OCStackResult result = clientResponse->result;
if(clientResponse->result == OC_STACK_OK)
{
parseServerHeaderOptions(clientResponse, serverHeaderOptions);
- attrs = parseGetSetCallback(clientResponse);
+ try
+ {
+ attrs = parseGetSetCallback(clientResponse);
+ }
+ catch(OC::OCException& e)
+ {
+ result = e.code();
+ }
}
std::thread exec(context->callback, serverHeaderOptions, attrs,
- clientResponse->result, sequenceNumber);
+ result, sequenceNumber);
exec.detach();
+ if(sequenceNumber == OC_OBSERVE_DEREGISTER)
+ {
+ return OC_STACK_DELETE_TRANSACTION;
+ }
return OC_STACK_KEEP_TRANSACTION;
}
OCStackResult InProcClientWrapper::ObserveResource(ObserveType observeType, OCDoHandle* handle,
- const std::string& host, const std::string& uri, const QueryParamsMap& queryParams,
- const HeaderOptions& headerOptions, ObserveCallback& callback, QualityOfService QoS)
+ const OCDevAddr& devAddr,
+ const std::string& uri,
+ const QueryParamsMap& queryParams, const HeaderOptions& headerOptions,
+ ObserveCallback& callback, QualityOfService QoS)
{
+ if(!callback)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
OCStackResult result;
- OCCallbackData cbdata = {0};
- ClientCallbackContext::ObserveContext* ctx = new ClientCallbackContext::ObserveContext();
- ctx->callback = callback;
- cbdata.context = static_cast<void*>(ctx);
- cbdata.cb = &observeResourceCallback;
- cbdata.cd = [](void* c){delete static_cast<ClientCallbackContext::ObserveContext*>(c);};
+ ClientCallbackContext::ObserveContext* ctx =
+ new ClientCallbackContext::ObserveContext(callback);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ observeResourceCallback,
+ [](void* c){delete static_cast<ClientCallbackContext::ObserveContext*>(c);}
+ );
OCMethod method;
if (observeType == ObserveType::Observe)
method = OC_REST_OBSERVE_ALL;
}
+ std::string url = assembleSetResourceUri(uri, queryParams).c_str();
+
auto cLock = m_csdkLock.lock();
if(cLock)
{
- std::ostringstream os;
- os << host << assembleSetResourceUri(uri, queryParams).c_str();
-
std::lock_guard<std::recursive_mutex> lock(*cLock);
OCHeaderOption options[MAX_HEADER_OPTIONS];
- assembleHeaderOptions(options, headerOptions);
result = OCDoResource(handle, method,
- os.str().c_str(), nullptr,
+ url.c_str(), &devAddr,
nullptr,
+ CT_DEFAULT,
static_cast<OCQualityOfService>(QoS),
&cbdata,
- options, headerOptions.size());
+ assembleHeaderOptions(options, headerOptions),
+ headerOptions.size());
}
else
{
return result;
}
- OCStackResult InProcClientWrapper::CancelObserveResource(OCDoHandle handle,
- const std::string& host, const std::string& uri, const HeaderOptions& headerOptions,
- QualityOfService QoS)
+ OCStackResult InProcClientWrapper::CancelObserveResource(
+ OCDoHandle handle,
+ const std::string& /*host*/,
+ const std::string& /*uri*/,
+ const HeaderOptions& headerOptions,
+ QualityOfService QoS)
{
OCStackResult result;
auto cLock = m_csdkLock.lock();
std::lock_guard<std::recursive_mutex> lock(*cLock);
OCHeaderOption options[MAX_HEADER_OPTIONS];
- assembleHeaderOptions(options, headerOptions);
- result = OCCancel(handle, static_cast<OCQualityOfService>(QoS), options,
+ result = OCCancel(handle,
+ static_cast<OCQualityOfService>(QoS),
+ assembleHeaderOptions(options, headerOptions),
headerOptions.size());
}
else
return result;
}
- OCStackApplicationResult subscribePresenceCallback(void* ctx, OCDoHandle handle,
+ OCStackApplicationResult subscribePresenceCallback(void* ctx,
+ OCDoHandle /*handle*/,
OCClientResponse* clientResponse)
{
- char stringAddress[DEV_ADDR_SIZE_MAX];
- ostringstream os;
- uint16_t port;
+ ClientCallbackContext::SubscribePresenceContext* context =
+ static_cast<ClientCallbackContext::SubscribePresenceContext*>(ctx);
- if(OCDevAddrToString(clientResponse->addr, stringAddress) == 0 &&
- OCDevAddrToPort(clientResponse->addr, &port) == 0)
- {
- os<<stringAddress<<":"<<port;
+ /*
+ * This a hack while we rethink presence subscription.
+ */
+ std::string url = clientResponse->devAddr.addr;
- ClientCallbackContext::SubscribePresenceContext* context =
- static_cast<ClientCallbackContext::SubscribePresenceContext*>(ctx);
+ std::thread exec(context->callback, clientResponse->result,
+ clientResponse->sequenceNumber, url);
- std::thread exec(context->callback, clientResponse->result,
- clientResponse->sequenceNumber, os.str());
+ exec.detach();
- exec.detach();
- }
- else
- {
- oclog() << "subscribePresenceCallback(): OCDevAddrToString() or OCDevAddrToPort() "
- <<"failed"<< std::flush;
- }
return OC_STACK_KEEP_TRANSACTION;
}
OCStackResult InProcClientWrapper::SubscribePresence(OCDoHandle* handle,
const std::string& host, const std::string& resourceType,
- SubscribeCallback& presenceHandler)
+ OCConnectivityType connectivityType, SubscribeCallback& presenceHandler)
{
- OCCallbackData cbdata = {0};
+ if(!presenceHandler)
+ {
+ return OC_STACK_INVALID_PARAM;
+ }
ClientCallbackContext::SubscribePresenceContext* ctx =
- new ClientCallbackContext::SubscribePresenceContext();
- ctx->callback = presenceHandler;
- cbdata.cb = &subscribePresenceCallback;
- cbdata.context = static_cast<void*>(ctx);
- cbdata.cd = [](void* c)
- {delete static_cast<ClientCallbackContext::SubscribePresenceContext*>(c);};
+ new ClientCallbackContext::SubscribePresenceContext(presenceHandler);
+ OCCallbackData cbdata(
+ static_cast<void*>(ctx),
+ subscribePresenceCallback,
+ [](void* c)
+ {delete static_cast<ClientCallbackContext::SubscribePresenceContext*>(c);}
+ );
+
auto cLock = m_csdkLock.lock();
std::ostringstream os;
- os << host << "/oc/presence";
+ os << host << OC_RSRVD_PRESENCE_URI;
if(!resourceType.empty())
{
return OC_STACK_ERROR;
}
- return OCDoResource(handle, OC_REST_PRESENCE, os.str().c_str(), nullptr, nullptr,
+ return OCDoResource(handle, OC_REST_PRESENCE,
+ os.str().c_str(), nullptr,
+ nullptr, connectivityType,
OC_LOW_QOS, &cbdata, NULL, 0);
}
return OC_STACK_OK;
}
- void InProcClientWrapper::assembleHeaderOptions(OCHeaderOption options[],
+ OCHeaderOption* InProcClientWrapper::assembleHeaderOptions(OCHeaderOption options[],
const HeaderOptions& headerOptions)
{
int i = 0;
+ if( headerOptions.size() == 0)
+ {
+ return nullptr;
+ }
+
for (auto it=headerOptions.begin(); it != headerOptions.end(); ++it)
{
- options[i].protocolID = OC_COAP_ID;
- options[i].optionID = static_cast<uint16_t>(it->getOptionID());
- options[i].optionLength = (it->getOptionData()).length() + 1;
- memcpy(options[i].optionData, (it->getOptionData()).c_str(),
- (it->getOptionData()).length() + 1);
+ options[i] = OCHeaderOption(OC_COAP_ID,
+ it->getOptionID(),
+ it->getOptionData().length() + 1,
+ reinterpret_cast<const uint8_t*>(it->getOptionData().c_str()));
i++;
}
+
+ return options;
}
}