Add collection payload to include each resource information separately
[platform/upstream/iotivity.git] / resource / csdk / stack / src / ocpayloadconvert.c
index 02a5b0f..a2035cf 100644 (file)
 #include "platform_features.h"
 #include <stdlib.h>
 #include "oic_malloc.h"
+#include "oic_string.h"
 #include "logger.h"
 #include "ocpayload.h"
 #include "ocrandom.h"
 #include "ocresourcehandler.h"
 #include "cbor.h"
+#include "rdpayload.h"
 
-#define TAG PCF("OCPayloadConvert")
+#define TAG "OCPayloadConvert"
 // Arbitrarily chosen size that seems to contain the majority of packages
 #define INIT_SIZE (255)
 
+// CBOR Array Length
+#define DISCOVERY_CBOR_ARRAY_LEN 1
+// CBOR Res Map Length
+#define DISCOVERY_CBOR_RES_MAP_LEN 2
+// CBOR Links Map Length
+#define DISCOVERY_CBOR_LINKS_MAP_LEN 4
+
 // Functions all return either a CborError, or a negative version of the OC_STACK return values
 static int64_t OCConvertPayloadHelper(OCPayload* payload, uint8_t* outPayload, size_t* size);
 static int64_t OCConvertDiscoveryPayload(OCDiscoveryPayload* payload, uint8_t* outPayload,
@@ -41,6 +50,7 @@ static int64_t OCConvertDevicePayload(OCDevicePayload* payload, uint8_t* outPayl
 static int64_t OCConvertPlatformPayload(OCPlatformPayload* payload, uint8_t* outPayload,
         size_t* size);
 static int64_t OCConvertRepPayload(OCRepPayload* payload, uint8_t* outPayload, size_t* size);
+static int64_t OCConvertRepMap(CborEncoder *map, const OCRepPayload* payload);
 static int64_t OCConvertPresencePayload(OCPresencePayload* payload, uint8_t* outPayload,
         size_t* size);
 static int64_t OCConvertSecurityPayload(OCSecurityPayload* payload, uint8_t* outPayload,
@@ -54,9 +64,6 @@ static int64_t AddTextStringToMap(CborEncoder* map, const char* key, size_t keyl
 static int64_t ConditionalAddTextStringToMap(CborEncoder* map, const char* key, size_t keylen,
         const char* value);
 
-#define STRINGIFY(s) XSTRINGIFY(s)
-#define XSTRINGIFY(s) #s
-
 OCStackResult OCConvertPayload(OCPayload* payload, uint8_t** outPayload, size_t* size)
 {
     // TinyCbor Version 47a78569c0 or better on master is required for the re-allocation
@@ -67,13 +74,13 @@ OCStackResult OCConvertPayload(OCPayload* payload, uint8_t** outPayload, size_t*
     #undef CborNeedsUpdating
     if (!payload)
     {
-        OC_LOG(ERROR, TAG, PCF("Payload parameter NULL"));
+        OC_LOG(ERROR, TAG, "Payload parameter NULL");
         return OC_STACK_INVALID_PARAM;
     }
 
     if (!outPayload || !size)
     {
-        OC_LOG(ERROR, TAG, PCF("Out parameter/s parameter NULL"));
+        OC_LOG(ERROR, TAG, "Out parameter/s parameter NULL");
         return OC_STACK_INVALID_PARAM;
     }
 
@@ -143,6 +150,8 @@ static int64_t OCConvertPayloadHelper(OCPayload* payload, uint8_t* outPayload, s
             return OCConvertPresencePayload((OCPresencePayload*)payload, outPayload, size);
         case PAYLOAD_TYPE_SECURITY:
             return OCConvertSecurityPayload((OCSecurityPayload*)payload, outPayload, size);
+        case PAYLOAD_TYPE_RD:
+            return OCRDPayloadToCbor((OCRDPayload*)payload, outPayload, size);
         default:
             OC_LOG_V(INFO,TAG, "ConvertPayload default %d", payload->type);
             return OC_STACK_NOTIMPL;
@@ -175,141 +184,242 @@ static int64_t OCConvertSecurityPayload(OCSecurityPayload* payload, uint8_t* out
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
 
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 2);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_SECURITY);
-
     CborEncoder map;
 
-    err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
+    err = err | cbor_encoder_create_map(&encoder, &map, CborIndefiniteLength);
 
     if(payload->securityData)
     {
-        err = err | AddTextStringToMap(&map, OC_RSRVD_REPRESENTATION,
-                sizeof(OC_RSRVD_REPRESENTATION) - 1,
-                payload->securityData);
+        err = err | cbor_encode_text_string(&map, payload->securityData,
+                                            strlen(payload->securityData));
     }
 
-    err = err | cbor_encoder_close_container(&rootArray, &map);
-
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &map);
     return checkError(err, &encoder, outPayload, size);
 
 }
 
+static char* OCStringLLJoin(OCStringLL* val)
+{
+    OCStringLL* temp = val;
+    size_t size = strlen(temp->value);
+
+    while (temp->next)
+    {
+        ++size;
+        temp = temp->next;
+        size += strlen(temp->value);
+    }
+
+    char* joinedStr = (char*)OICCalloc(sizeof(char), size + 1);
+
+    if (!joinedStr)
+    {
+        return NULL;
+    }
+
+    OICStrcat(joinedStr, size + 1, val->value);
+    while (val->next)
+    {
+        val = val->next;
+        OICStrcat(joinedStr, size + 1, " ");
+        OICStrcat(joinedStr, size + 1, val->value);
+    }
+    return joinedStr;
+}
+
 static int64_t OCConvertDiscoveryPayload(OCDiscoveryPayload* payload, uint8_t* outPayload,
         size_t* size)
 {
     CborEncoder encoder = {0};
+    CborEncoder rootArray = {0};
     int64_t err = 0;
-    size_t resourceCount =  OCDiscoveryPayloadGetResourceCount(payload);
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
 
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 1 + resourceCount);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_DISCOVERY);
-
-    for(size_t i = 0; i < resourceCount; ++i)
+    if (payload->collectionResources)
     {
-        CborEncoder map;
-        OCResourcePayload* resource = OCDiscoveryPayloadGetResource(payload, i);
+        CborError cborEncoderResult;
+        cborEncoderResult = cbor_encoder_create_array(&encoder, &rootArray, DISCOVERY_CBOR_ARRAY_LEN);
+        if (CborNoError != cborEncoderResult)
+        {
+            OC_LOG(ERROR, TAG, "Failed creating root array.");
+            goto cbor_error;
+        }
 
-        if(!resource)
+        CborEncoder colArray;
+        cborEncoderResult = cbor_encoder_create_array(&rootArray, &colArray, CborIndefiniteLength);
+        if (CborNoError != cborEncoderResult)
         {
-            return OC_STACK_INVALID_PARAM;
+            OC_LOG(ERROR, TAG, "Failed creating collection array.");
+            goto cbor_error;
         }
 
-        err = err | cbor_encoder_create_map(&rootArray, &map, 3);
-        // Uri
-        err = err | AddTextStringToMap(&map, OC_RSRVD_HREF,
-                sizeof(OC_RSRVD_HREF) - 1,
-                resource->uri);
-
-        // Server ID
-        err = err | cbor_encode_text_string(&map, OC_RSRVD_SERVER_INSTANCE_ID,
-                sizeof(OC_RSRVD_SERVER_INSTANCE_ID) - 1);
-        err = err | cbor_encode_byte_string(&map, resource->sid, UUID_SIZE);
-        // Prop Tag
+        OCResourceCollectionPayload *colResources = payload->collectionResources;
+        while (colResources)
         {
-            CborEncoder propMap;
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_PROPERTY,
-                    sizeof(OC_RSRVD_PROPERTY) -1 );
-            err = err | cbor_encoder_create_map(&map, &propMap, 3);
+            if (OC_STACK_OK != OCTagsPayloadToCbor(colResources->tags, &colArray))
+            {
+                goto cbor_error;
+            }
+            if (OC_STACK_OK != OCLinksPayloadToCbor(colResources->setLinks, &colArray))
+            {
+                goto cbor_error;
+            }
+            colResources = colResources->next;
+        }
+        cborEncoderResult = cbor_encoder_close_container(&rootArray, &colArray);
+        if (CborNoError != cborEncoderResult)
+        {
+            OC_LOG(ERROR, TAG, "Failed closing collection array.");
+            goto cbor_error;
+        }
+        cborEncoderResult = cbor_encoder_close_container(&encoder, &rootArray);
+        if (CborNoError != cborEncoderResult)
+        {
+            OC_LOG(ERROR, TAG, "Failed closing root array.");
+            goto cbor_error;
+        }
+    }
+    else if (payload->resources)
+    {
+        /*
+        The format for the payload is "modelled" as JSON.
+
+        [                                                       // rootArray
+            {                                                   // rootMap
+                "di" : UUID,                                    // device ID
+                links :[                                        // linksArray contains maps of resources
+                            {
+                                href, rt, if, policy            // Resource 1
+                            },
+                            {
+                                href, rt, if, policy            // Resource 2
+                            },
+                            .
+                            .
+                            .
+                        ]
+            }
+        ]
+        */
+        CborEncoder rootMap = {};
+        size_t resourceCount =  OCDiscoveryPayloadGetResourceCount(payload);
 
-            // Resource Type
+        // Open the main root array
+        err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
+
+        // Open the root map in the root array
+        err = err | cbor_encoder_create_map(&rootArray, &rootMap, DISCOVERY_CBOR_RES_MAP_LEN);
+
+        // Insert Device ID into the root map
+        err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_DEVICE_ID,
+                sizeof(OC_RSRVD_DEVICE_ID) - 1);
+        err = err | cbor_encode_byte_string(&rootMap, payload->sid, UUID_SIZE);
+
+
+        // Insert Links into the root map.
+        CborEncoder linkArray = {};
+        err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_LINKS,
+                    sizeof(OC_RSRVD_LINKS) - 1);
+        err = err | cbor_encoder_create_array(&rootMap, &linkArray, resourceCount);
+
+        for(size_t i = 0; i < resourceCount; ++i)
+        {
+            CborEncoder resourceMapElement = {};
+            OCResourcePayload* resource = OCDiscoveryPayloadGetResource(payload, i);
+            if(!resource)
             {
-                CborEncoder rtArray;
-                err = err | cbor_encode_text_string(&propMap, OC_RSRVD_RESOURCE_TYPE,
-                    sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
-                err = err | cbor_encoder_create_array(&propMap, &rtArray, CborIndefiniteLength);
+                OICFree(outPayload);
+                return OC_STACK_INVALID_PARAM;
+            }
 
-                OCStringLL* rtPtr = resource->types;
-                while(rtPtr)
+            // resource map inside the links array.
+            err = err | cbor_encoder_create_map(&linkArray, &resourceMapElement,
+                DISCOVERY_CBOR_LINKS_MAP_LEN);
+
+            // Below are insertions of the resource properties into the map.
+            // Uri
+            err = err | AddTextStringToMap(&resourceMapElement, OC_RSRVD_HREF,
+                        sizeof(OC_RSRVD_HREF) - 1,
+                        resource->uri);
+            // Resource Type
+            if (resource->types)
+            {
+                char* joinedTypes = OCStringLLJoin(resource->types);
+                if (joinedTypes)
                 {
-                    err = err | cbor_encode_text_string(&rtArray, rtPtr->value,
-                            strlen(rtPtr->value));
-                    rtPtr = rtPtr->next;
+                    err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_RESOURCE_TYPE,
+                            sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
+                    err = err | cbor_encode_text_string(&resourceMapElement, joinedTypes,
+                            strlen(joinedTypes));
+                    OICFree(joinedTypes);
+                }
+                else
+                {
+                    return OC_STACK_NO_MEMORY;
                 }
-
-                err = err | cbor_encoder_close_container(&propMap, &rtArray);
             }
-
             // Interface Types
+            if (resource->interfaces)
             {
-                CborEncoder ifArray;
-                err = err | cbor_encode_text_string(&propMap, OC_RSRVD_INTERFACE,
-                        sizeof(OC_RSRVD_INTERFACE) - 1);
-                err = err | cbor_encoder_create_array(&propMap, &ifArray, CborIndefiniteLength);
-                OCStringLL* ifPtr = resource->interfaces;
-
-                while(ifPtr)
+                char* joinedInterfaces = OCStringLLJoin(resource->interfaces);
+                if (joinedInterfaces)
                 {
-                    err = err | cbor_encode_text_string(&ifArray, ifPtr->value,
-                        strlen(ifPtr->value));
-                    ifPtr= ifPtr->next;
+                    err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_INTERFACE,
+                            sizeof(OC_RSRVD_INTERFACE) - 1);
+                    err = err | cbor_encode_text_string(&resourceMapElement, joinedInterfaces,
+                            strlen(joinedInterfaces));
+                    OICFree(joinedInterfaces);
+                }
+                else
+                {
+                    return OC_STACK_NO_MEMORY;
                 }
-
-                err = err | cbor_encoder_close_container(&propMap, &ifArray);
             }
+
             // Policy
-            {
-                CborEncoder policyMap;
-                err = err | cbor_encode_text_string(&propMap, OC_RSRVD_POLICY,
-                        sizeof(OC_RSRVD_POLICY) - 1);
-                err = err | cbor_encoder_create_map(&propMap, &policyMap, CborIndefiniteLength);
+            CborEncoder policyMap;
+            err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_POLICY,
+                    sizeof(OC_RSRVD_POLICY) - 1);
+            err = err | cbor_encoder_create_map(&resourceMapElement, &policyMap, CborIndefiniteLength);
 
-                // Bitmap
-                err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_BITMAP,
-                        sizeof(OC_RSRVD_BITMAP) - 1);
-                err = err | cbor_encode_uint(&policyMap, resource->bitmap);
+            // Bitmap
+            err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_BITMAP,
+                    sizeof(OC_RSRVD_BITMAP) - 1);
+            err = err | cbor_encode_uint(&policyMap, resource->bitmap);
 
-                if(resource->secure)
-                {
-                    err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_SECURE,
-                            sizeof(OC_RSRVD_SECURE) - 1);
-                    err = err | cbor_encode_boolean(&policyMap, OC_RESOURCE_SECURE);
+            if(resource->secure)
+            {
+                err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_SECURE,
+                        sizeof(OC_RSRVD_SECURE) - 1);
+                err = err | cbor_encode_boolean(&policyMap, OC_RESOURCE_SECURE);
 
-                    if(resource->port != 0)
-                    {
-                        err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_HOSTING_PORT,
-                                sizeof(OC_RSRVD_HOSTING_PORT) - 1);
-                        err = err | cbor_encode_uint(&policyMap, resource->port);
-                    }
+                if(resource->port != 0)
+                {
+                    err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_HOSTING_PORT,
+                            sizeof(OC_RSRVD_HOSTING_PORT) - 1);
+                    err = err | cbor_encode_uint(&policyMap, resource->port);
                 }
-
-                err = err | cbor_encoder_close_container(&propMap, &policyMap);
             }
-            // Close
-            err = err | cbor_encoder_close_container(&map, &propMap);
+
+            err = err | cbor_encoder_close_container(&resourceMapElement, &policyMap);
+
+            // Finsihed encoding a resource, close the map.
+            err = err | cbor_encoder_close_container(&linkArray, &resourceMapElement);
         }
-        // Close Item
-        err = err | cbor_encoder_close_container(&rootArray, &map);
+        // Close links array inside the root map.
+        err = err | cbor_encoder_close_container(&rootMap, &linkArray);
+        // close root map inside the root array.
+        err = err | cbor_encoder_close_container(&rootArray, &rootMap);
+        // Close the final root array.
+        err = err | cbor_encoder_close_container(&encoder, &rootArray);
     }
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
 
     return checkError(err, &encoder, outPayload, size);
+cbor_error:
+    OICFree(outPayload);
+    return OC_STACK_ERROR;
 }
 
 static int64_t OCConvertDevicePayload(OCDevicePayload* payload, uint8_t* outPayload,
@@ -319,54 +429,30 @@ static int64_t OCConvertDevicePayload(OCDevicePayload* payload, uint8_t* outPayl
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 2);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_DEVICE);
+    CborEncoder repMap;
+    err = err | cbor_encoder_create_map(&encoder, &repMap, CborIndefiniteLength);
 
-    {
-        CborEncoder map;
-        err = err | cbor_encoder_create_map(&rootArray, &map, 2);
+    // Device ID
+    err = err | cbor_encode_text_string(&repMap, OC_RSRVD_DEVICE_ID,
+            sizeof(OC_RSRVD_DEVICE_ID) - 1);
+    err = err | cbor_encode_byte_string(&repMap, payload->sid, UUID_SIZE);
 
-        // uri
-        err = err | AddTextStringToMap(&map, OC_RSRVD_HREF, sizeof(OC_RSRVD_HREF) - 1,
-                payload->uri);
+    // Device Name
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DEVICE_NAME,
+            sizeof(OC_RSRVD_DEVICE_NAME) - 1,
+            payload->deviceName);
 
-        // Rep Map
-        {
-            CborEncoder repMap;
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_REPRESENTATION,
-                    sizeof(OC_RSRVD_REPRESENTATION) - 1);
-            err = err | cbor_encoder_create_map(&map, &repMap, 4);
-
-            // Device ID
-            err = err | cbor_encode_text_string(&repMap, OC_RSRVD_DEVICE_ID,
-                    sizeof(OC_RSRVD_DEVICE_ID) - 1);
-            err = err | cbor_encode_byte_string(&repMap, payload->sid, UUID_SIZE);
-
-            // Device Name
-            err = err | AddTextStringToMap(&repMap, OC_RSRVD_DEVICE_NAME,
-                    sizeof(OC_RSRVD_DEVICE_NAME) - 1,
-                    payload->deviceName);
-
-            // Device Spec Version
-            err = err | AddTextStringToMap(&repMap, OC_RSRVD_SPEC_VERSION,
-                    sizeof(OC_RSRVD_SPEC_VERSION) - 1,
-                    payload->specVersion);
-
-            // Device data Model Version
-            err = err | AddTextStringToMap(&repMap, OC_RSRVD_DATA_MODEL_VERSION,
-                    sizeof(OC_RSRVD_DATA_MODEL_VERSION) - 1,
-                    payload->dataModelVersion);
-
-            err = err | cbor_encoder_close_container(&map, &repMap);
-        }
+    // Device Spec Version
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SPEC_VERSION,
+            sizeof(OC_RSRVD_SPEC_VERSION) - 1,
+            payload->specVersion);
 
-        // Close Map
-        err = err | cbor_encoder_close_container(&rootArray, &map);
-    }
+    // Device data Model Version
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DATA_MODEL_VERSION,
+            sizeof(OC_RSRVD_DATA_MODEL_VERSION) - 1,
+            payload->dataModelVersion);
 
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &repMap);
 
     return checkError(err, &encoder, outPayload, size);
 }
@@ -378,270 +464,317 @@ static int64_t OCConvertPlatformPayload(OCPlatformPayload* payload, uint8_t* out
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 2);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_PLATFORM);
     {
-        CborEncoder map;
-        err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
-
-        // uri
-        err = err | AddTextStringToMap(&map, OC_RSRVD_HREF, sizeof(OC_RSRVD_HREF) - 1,
-                payload->uri);
-
-        // Rep Map
-        {
-            CborEncoder repMap;
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_REPRESENTATION,
-                    sizeof(OC_RSRVD_REPRESENTATION) - 1);
-            err = err | cbor_encoder_create_map(&map, &repMap, CborIndefiniteLength);
-
-            // Platform ID
-            err = err | AddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_ID,
-                    sizeof(OC_RSRVD_PLATFORM_ID) - 1,
-                    payload->info.platformID);
-
-            // MFG Name
-            err = err | AddTextStringToMap(&repMap, OC_RSRVD_MFG_NAME,
-                    sizeof(OC_RSRVD_MFG_NAME) - 1,
-                    payload->info.manufacturerName);
-
-            // MFG Url
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_URL,
-                    sizeof(OC_RSRVD_MFG_URL) - 1,
-                    payload->info.manufacturerUrl);
-
-            // Model Num
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MODEL_NUM,
-                    sizeof(OC_RSRVD_MODEL_NUM) - 1,
-                    payload->info.modelNumber);
-
-            // Date of Mfg
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_DATE,
-                    sizeof(OC_RSRVD_MFG_DATE) - 1,
-                    payload->info.dateOfManufacture);
-
-            // Platform Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_VERSION,
-                    sizeof(OC_RSRVD_PLATFORM_VERSION) - 1,
-                    payload->info.platformVersion);
-
-            // OS Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_OS_VERSION,
-                    sizeof(OC_RSRVD_OS_VERSION) - 1,
-                    payload->info.operatingSystemVersion);
-
-            // Hardware Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_HARDWARE_VERSION,
-                    sizeof(OC_RSRVD_HARDWARE_VERSION) - 1,
-                    payload->info.hardwareVersion);
-
-            // Firmware Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_FIRMWARE_VERSION,
-                    sizeof(OC_RSRVD_FIRMWARE_VERSION) - 1,
-                    payload->info.firmwareVersion);
-
-            // Support URL
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SUPPORT_URL,
-                    sizeof(OC_RSRVD_SUPPORT_URL) - 1,
-                    payload->info.supportUrl);
-
-            // System Time
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SYSTEM_TIME,
-                    sizeof(OC_RSRVD_SYSTEM_TIME) - 1,
-                    payload->info.systemTime);
-            err = err | cbor_encoder_close_container(&map, &repMap);
-        }
+        CborEncoder repMap;
+        err = err | cbor_encoder_create_map(&encoder, &repMap, CborIndefiniteLength);
+
+        // Platform ID
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_ID,
+                sizeof(OC_RSRVD_PLATFORM_ID) - 1,
+                payload->info.platformID);
+
+        // MFG Name
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_NAME,
+                sizeof(OC_RSRVD_MFG_NAME) - 1,
+                payload->info.manufacturerName);
+
+        // MFG Url
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_URL,
+                sizeof(OC_RSRVD_MFG_URL) - 1,
+                payload->info.manufacturerUrl);
+
+        // Model Num
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MODEL_NUM,
+                sizeof(OC_RSRVD_MODEL_NUM) - 1,
+                payload->info.modelNumber);
+
+        // Date of Mfg
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_DATE,
+                sizeof(OC_RSRVD_MFG_DATE) - 1,
+                payload->info.dateOfManufacture);
+
+        // Platform Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_VERSION,
+                sizeof(OC_RSRVD_PLATFORM_VERSION) - 1,
+                payload->info.platformVersion);
+
+        // OS Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_OS_VERSION,
+                sizeof(OC_RSRVD_OS_VERSION) - 1,
+                payload->info.operatingSystemVersion);
+
+        // Hardware Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_HARDWARE_VERSION,
+                sizeof(OC_RSRVD_HARDWARE_VERSION) - 1,
+                payload->info.hardwareVersion);
+
+        // Firmware Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_FIRMWARE_VERSION,
+                sizeof(OC_RSRVD_FIRMWARE_VERSION) - 1,
+                payload->info.firmwareVersion);
+
+        // Support URL
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SUPPORT_URL,
+                sizeof(OC_RSRVD_SUPPORT_URL) - 1,
+                payload->info.supportUrl);
+
+        // System Time
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SYSTEM_TIME,
+                sizeof(OC_RSRVD_SYSTEM_TIME) - 1,
+                payload->info.systemTime);
 
         // Close Map
-        err = err | cbor_encoder_close_container(&rootArray, &map);
+        err = err | cbor_encoder_close_container(&encoder, &repMap);
     }
 
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
-
     return checkError(err, &encoder, outPayload, size);
 }
 
+static int64_t OCConvertArrayItem(CborEncoder* array, const OCRepPayloadValueArray* valArray,
+        size_t index)
+{
+    int64_t err = 0;
+    switch (valArray->type)
+    {
+        case OCREP_PROP_NULL:
+            OC_LOG(ERROR, TAG, "ConvertArray Invalid NULL");
+            err = CborUnknownError;
+            break;
+        case OCREP_PROP_INT:
+            err = err | cbor_encode_int(array, valArray->iArray[index]);
+            break;
+        case OCREP_PROP_DOUBLE:
+            err = err | cbor_encode_double(array, valArray->dArray[index]);
+            break;
+        case OCREP_PROP_BOOL:
+            err = err | cbor_encode_boolean(array, valArray->bArray[index]);
+            break;
+        case OCREP_PROP_STRING:
+            if (!valArray->strArray[index])
+            {
+                err = err | cbor_encode_null(array);
+            }
+            else
+            {
+                err = err | cbor_encode_text_string(array, valArray->strArray[index],
+                        strlen(valArray->strArray[index]));
+            }
+            break;
+        case OCREP_PROP_BYTE_STRING:
+            if (!valArray->strArray[index])
+            {
+                err = err | cbor_encode_null(array);
+            }
+            else
+            {
+                err = err | cbor_encode_byte_string(array, valArray->ocByteStrArray[index].bytes,
+                        valArray->ocByteStrArray[index].len);
+            }
+            break;
+        case OCREP_PROP_OBJECT:
+            if (!valArray->objArray[index])
+            {
+                err = err | cbor_encode_null(array);
+            }
+            else
+            {
+                err = OCConvertRepMap(array, valArray->objArray[index]);
+            }
+            break;
+        case OCREP_PROP_ARRAY:
+            OC_LOG(ERROR, TAG, "ConvertArray Invalid child array");
+            err = CborUnknownError;
+            break;
+    }
+
+    return err;
+}
 static int64_t OCConvertArray(CborEncoder* parent, const OCRepPayloadValueArray* valArray)
 {
     CborEncoder array;
     int64_t err = 0;
 
-    err = err | cbor_encoder_create_array(parent, &array, CborIndefiniteLength);
-    err = err | cbor_encode_uint(&array, valArray->type);
-    for(int i = 0; i < MAX_REP_ARRAY_DEPTH; ++i)
+    err = err | cbor_encoder_create_array(parent, &array, valArray->dimensions[0]);
+
+    for (size_t i = 0; i < valArray->dimensions[0];++i)
     {
-        err = err | cbor_encode_uint(&array, valArray->dimensions[i]);
+        if (valArray->dimensions[1] != 0)
+        {
+            CborEncoder array2;
+            err = err | cbor_encoder_create_array(&array, &array2, valArray->dimensions[1]);
+
+            for (size_t j = 0; j < valArray->dimensions[1]; ++j)
+            {
+                if (valArray->dimensions[2] != 0)
+                {
+                    CborEncoder array3;
+                    err = err | cbor_encoder_create_array(&array2, &array3,
+                            valArray->dimensions[2]);
+
+                    for(size_t k = 0; k < valArray->dimensions[2]; ++k)
+                    {
+                        OCConvertArrayItem(&array3, valArray,
+                            j * valArray->dimensions[2] +
+                            i * valArray->dimensions[2] * valArray->dimensions[1] +
+                            k);
+                    }
+                    err = err | cbor_encoder_close_container(&array2, &array3);
+                }
+                else
+                {
+                    OCConvertArrayItem(&array2, valArray,
+                            i * valArray->dimensions[1] + j);
+                }
+            }
+            err = err | cbor_encoder_close_container(&array, &array2);
+        }
+        else
+        {
+            OCConvertArrayItem(&array, valArray, i);
+        }
     }
+    err = err | cbor_encoder_close_container(parent, &array);
+    return err;
+}
 
-    size_t dimTotal = calcDimTotal(valArray->dimensions);
+static int64_t OCConvertRepMap(CborEncoder *map, const OCRepPayload* payload)
+{
+    int64_t err = 0;
+    CborEncoder repMap;
+    err = err | cbor_encoder_create_map(map, &repMap, CborIndefiniteLength);
+    err = err | OCConvertSingleRepPayload(&repMap, payload);
+    err = err | cbor_encoder_close_container(map, &repMap);
+    return err;
+}
 
-    for(size_t i = 0; i < dimTotal; ++i)
+static int64_t OCConvertSingleRepPayload(CborEncoder* repMap, const OCRepPayload* payload)
+{
+    int64_t err = 0;
+    OCRepPayloadValue* value = payload->values;
+    while(value)
     {
-        switch(valArray->type)
+        err = err | cbor_encode_text_string(repMap,
+                value->name,
+                strlen(value->name));
+        switch(value->type)
         {
             case OCREP_PROP_NULL:
-                OC_LOG(ERROR, TAG, PCF("ConvertArray Invalid NULL"));
-                err = CborUnknownError;
+                err = err | cbor_encode_null(repMap);
                 break;
             case OCREP_PROP_INT:
-                err = err | cbor_encode_int(&array, valArray->iArray[i]);
+                err = err | cbor_encode_int(repMap,
+                        value->i);
                 break;
             case OCREP_PROP_DOUBLE:
-                err = err | cbor_encode_double(&array, valArray->dArray[i]);
+                err = err | cbor_encode_double(repMap,
+                        value->d);
                 break;
             case OCREP_PROP_BOOL:
-                err = err | cbor_encode_boolean(&array, valArray->bArray[i]);
+                err = err | cbor_encode_boolean(repMap,
+                        value->b);
                 break;
             case OCREP_PROP_STRING:
-                err = err | cbor_encode_text_string(&array, valArray->strArray[i],
-                        strlen(valArray->strArray[i]));
+                err = err | cbor_encode_text_string(repMap,
+                        value->str, strlen(value->str));
+                break;
+            case OCREP_PROP_BYTE_STRING:
+                err = err | cbor_encode_byte_string(repMap,
+                        value->ocByteStr.bytes, value->ocByteStr.len);
                 break;
             case OCREP_PROP_OBJECT:
-                err = OCConvertSingleRepPayload(&array, valArray->objArray[i]);
+                err = err | OCConvertRepMap(repMap, value->obj);
                 break;
             case OCREP_PROP_ARRAY:
-                OC_LOG(ERROR, TAG, PCF("ConvertArray Invalid child array"));
-                err = CborUnknownError;
+                err = err | OCConvertArray(repMap, &value->arr);
+                break;
+            default:
+                OC_LOG_V(ERROR, TAG, "Invalid Prop type: %d",
+                        value->type);
                 break;
         }
+        value = value->next;
     }
 
-    err = err | cbor_encoder_close_container(parent, &array);
     return err;
 }
 
-static int64_t OCConvertSingleRepPayload(CborEncoder* parent, const OCRepPayload* payload)
+static int64_t OCConvertRepPayload(OCRepPayload* payload, uint8_t* outPayload, size_t* size)
 {
+    CborEncoder encoder = {0};
     int64_t err = 0;
-    CborEncoder map;
-    err = err | cbor_encoder_create_map(parent, &map, CborIndefiniteLength);
 
-    // Uri
-    err = err | ConditionalAddTextStringToMap(&map, OC_RSRVD_HREF,
-            sizeof(OC_RSRVD_HREF) - 1,
-            payload->uri);
+    cbor_encoder_init(&encoder, outPayload, *size, 0);
+    CborEncoder rootMap ;
 
-    // Prop Map
-    // resource types, interfaces
-    if(payload->types || payload->interfaces)
+    size_t arrayCount = 0;
+    for (OCRepPayload *temp = payload; temp; temp = temp->next)
+    {
+        arrayCount++;
+    }
+    CborEncoder rootArray;
+    if (arrayCount > 1)
     {
-        OC_LOG_V(INFO, TAG, "Payload has types or interfaces");
-        err = err | cbor_encode_text_string(&map,
-                OC_RSRVD_PROPERTY,
-                sizeof(OC_RSRVD_PROPERTY) - 1);
-        CborEncoder propMap;
-        err = err | cbor_encoder_create_map(&map, &propMap, 2);
-
-        CborEncoder curArray;
-        if(payload->types)
+        err = err | cbor_encoder_create_array(&encoder, &rootArray, arrayCount);
+    }
+
+    while (payload != NULL && (err == CborNoError))
+    {
+        err = err | cbor_encoder_create_map(((arrayCount == 1)? &encoder: &rootArray),
+                                            &rootMap, CborIndefiniteLength);
+        // Only in case of collection href is included.
+        if (arrayCount > 1 && payload->uri && strlen(payload->uri) > 0)
         {
-            err = err | cbor_encode_text_string(&propMap,
-                    OC_RSRVD_RESOURCE_TYPE,
-                    sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
-            err = err | cbor_encoder_create_array(&propMap, &curArray, CborIndefiniteLength);
-            OCStringLL* val = payload->types;
-            while(val)
-            {
-                err = err | cbor_encode_text_string(&curArray, val->value, strlen(val->value));
-                val = val->next;
-            }
-            err = err | cbor_encoder_close_container(&propMap, &curArray);
+            OC_LOG(INFO, TAG, "Payload has uri");
+            err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_HREF,
+                    strlen(OC_RSRVD_HREF));
+            err = err | cbor_encode_text_string(&rootMap, payload->uri,
+                    strlen(payload->uri));
         }
-        if(payload->interfaces)
+        if (payload->types)
         {
-            err = err | cbor_encode_text_string(&propMap,
-                    OC_RSRVD_INTERFACE,
-                    sizeof(OC_RSRVD_INTERFACE) - 1);
-            err = err | cbor_encoder_create_array(&propMap, &curArray, CborIndefiniteLength);
-            OCStringLL* val = payload->interfaces;
-            while(val)
+            OC_LOG(INFO, TAG, "Payload has types");
+            char* joinedTypes = OCStringLLJoin(payload->types);
+            if (joinedTypes)
             {
-                err = err | cbor_encode_text_string(&curArray, val->value, strlen(val->value));
-                val = val->next;
+                err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_RESOURCE_TYPE,
+                        strlen(OC_RSRVD_RESOURCE_TYPE));
+                err = err | cbor_encode_text_string(&rootMap, joinedTypes,
+                        strlen(joinedTypes));
+                OICFree(joinedTypes);
+            }
+            else
+            {
+                return OC_STACK_NO_MEMORY;
             }
-            err = err | cbor_encoder_close_container(&propMap, &curArray);
         }
-        err = err | cbor_encoder_close_container(&map, &propMap);
-    }
-
-    // Rep Map
-    {
-        CborEncoder repMap;
-        err = err | cbor_encode_text_string(&map,
-                OC_RSRVD_REPRESENTATION,
-                sizeof(OC_RSRVD_REPRESENTATION) - 1);
-        err = err | cbor_encoder_create_map(&map, &repMap, CborIndefiniteLength);
-        OCRepPayloadValue* value = payload->values;
-        while(value)
+        if (payload->interfaces)
         {
-            err = err | cbor_encode_text_string(&repMap,
-                    value->name,
-                    strlen(value->name));
-            switch(value->type)
+            OC_LOG(INFO, TAG, "Payload has interfaces");
+            char* joinedInterfaces = OCStringLLJoin(payload->interfaces);
+            if (joinedInterfaces)
             {
-                case OCREP_PROP_NULL:
-                    err = err | cbor_encode_null(&repMap);
-                    break;
-                case OCREP_PROP_INT:
-                    err = err | cbor_encode_int(&repMap,
-                            value->i);
-                    break;
-                case OCREP_PROP_DOUBLE:
-                    err = err | cbor_encode_double(&repMap,
-                            value->d);
-                    break;
-                case OCREP_PROP_BOOL:
-                    err = err | cbor_encode_boolean(&repMap,
-                            value->b);
-                    break;
-                case OCREP_PROP_STRING:
-                    err = err | cbor_encode_text_string(&repMap,
-                            value->str, strlen(value->str));
-                    break;
-                case OCREP_PROP_OBJECT:
-                    err = err | OCConvertSingleRepPayload(&repMap, value->obj);
-                    break;
-                case OCREP_PROP_ARRAY:
-                    err = err | OCConvertArray(&repMap, &value->arr);
-                    break;
-                default:
-                    OC_LOG_V(ERROR, TAG, "Invalid Prop type: %d",
-                            value->type);
-                    break;
+                err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_INTERFACE,
+                        strlen(OC_RSRVD_INTERFACE));
+                err = err | cbor_encode_text_string(&rootMap, joinedInterfaces,
+                        strlen(joinedInterfaces));
+                OICFree(joinedInterfaces);
+            }
+            else
+            {
+                return OC_STACK_NO_MEMORY;
             }
-            value = value->next;
         }
 
-        err = err | cbor_encoder_close_container(&map, &repMap);
+        err = err | OCConvertSingleRepPayload(&rootMap, payload);
+        err = err | cbor_encoder_close_container(((arrayCount == 1) ? &encoder: &rootArray),
+                                                &rootMap);
+        payload = payload->next;
     }
-
-    // Close Map
-    err = err | cbor_encoder_close_container(parent, &map);
-
-    return err;
-}
-
-static int64_t OCConvertRepPayload(OCRepPayload* payload, uint8_t* outPayload, size_t* size)
-{
-    CborEncoder encoder = {0};
-    int64_t err = 0;
-
-    cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, CborIndefiniteLength);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_REPRESENTATION);
-
-    while(payload != NULL && (err == 0 || err == CborErrorOutOfMemory))
+    if (arrayCount > 1)
     {
-        err = err | OCConvertSingleRepPayload(&rootArray, payload);
-        payload = payload->next;
+        err = err | cbor_encoder_close_container(&encoder, &rootArray);
     }
 
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
-
     return checkError(err, &encoder, outPayload, size);
 }
 
@@ -652,14 +785,8 @@ static int64_t OCConvertPresencePayload(OCPresencePayload* payload,
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 2);
-    err = err | cbor_encode_uint(&rootArray, PAYLOAD_TYPE_PRESENCE);
-
-
     CborEncoder map;
-    err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
+    err = err | cbor_encoder_create_map(&encoder, &map, CborIndefiniteLength);
 
     // Sequence Number
     err = err | cbor_encode_text_string(&map,
@@ -686,8 +813,7 @@ static int64_t OCConvertPresencePayload(OCPresencePayload* payload,
     }
 
     // Close Map
-    err = err | cbor_encoder_close_container(&rootArray, &map);
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &map);
 
     return checkError(err, &encoder, outPayload, size);
 }