Imported Upstream version 1.0.1
[platform/upstream/iotivity.git] / resource / csdk / stack / src / ocpayloadconvert.c
index 588dd55..7b46b36 100644 (file)
@@ -50,6 +50,7 @@ static int64_t OCConvertDevicePayload(OCDevicePayload* payload, uint8_t* outPayl
 static int64_t OCConvertPlatformPayload(OCPlatformPayload* payload, uint8_t* outPayload,
         size_t* size);
 static int64_t OCConvertRepPayload(OCRepPayload* payload, uint8_t* outPayload, size_t* size);
+static int64_t OCConvertRepMap(CborEncoder *map, const OCRepPayload* payload);
 static int64_t OCConvertPresencePayload(OCPresencePayload* payload, uint8_t* outPayload,
         size_t* size);
 static int64_t OCConvertSecurityPayload(OCSecurityPayload* payload, uint8_t* outPayload,
@@ -183,22 +184,17 @@ static int64_t OCConvertSecurityPayload(OCSecurityPayload* payload, uint8_t* out
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
 
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
     CborEncoder map;
 
-    err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
+    err = err | cbor_encoder_create_map(&encoder, &map, CborIndefiniteLength);
 
     if(payload->securityData)
     {
-        err = err | AddTextStringToMap(&map, OC_RSRVD_REPRESENTATION,
-                sizeof(OC_RSRVD_REPRESENTATION) - 1,
-                payload->securityData);
+        err = err | cbor_encode_text_string(&map, payload->securityData,
+                                            strlen(payload->securityData));
     }
 
-    err = err | cbor_encoder_close_container(&rootArray, &map);
-
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &map);
     return checkError(err, &encoder, outPayload, size);
 
 }
@@ -287,12 +283,50 @@ static int64_t OCConvertDiscoveryPayload(OCDiscoveryPayload* payload, uint8_t* o
     }
     else if (payload->resources)
     {
+        /*
+        The format for the payload is "modelled" as JSON.
+
+        [                                                       // rootArray
+            {                                                   // rootMap
+                "di" : UUID,                                    // device ID
+                links :[                                        // linksArray contains maps of resources
+                            {
+                                href, rt, if, policy            // Resource 1
+                            },
+                            {
+                                href, rt, if, policy            // Resource 2
+                            },
+                            .
+                            .
+                            .
+                        ]
+            }
+        ]
+        */
+        CborEncoder rootMap = {};
         size_t resourceCount =  OCDiscoveryPayloadGetResourceCount(payload);
-        err = err | cbor_encoder_create_array(&encoder, &rootArray, resourceCount);
+
+        // Open the main root array
+        err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
+
+        // Open the root map in the root array
+        err = err | cbor_encoder_create_map(&rootArray, &rootMap, DISCOVERY_CBOR_RES_MAP_LEN);
+
+        // Insert Device ID into the root map
+        err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_DEVICE_ID,
+                sizeof(OC_RSRVD_DEVICE_ID) - 1);
+        err = err | cbor_encode_byte_string(&rootMap, payload->sid, UUID_SIZE);
+
+
+        // Insert Links into the root map.
+        CborEncoder linkArray = {};
+        err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_LINKS,
+                    sizeof(OC_RSRVD_LINKS) - 1);
+        err = err | cbor_encoder_create_array(&rootMap, &linkArray, resourceCount);
 
         for(size_t i = 0; i < resourceCount; ++i)
         {
-            CborEncoder map;
+            CborEncoder resourceMapElement = {};
             OCResourcePayload* resource = OCDiscoveryPayloadGetResource(payload, i);
             if(!resource)
             {
@@ -300,97 +334,85 @@ static int64_t OCConvertDiscoveryPayload(OCDiscoveryPayload* payload, uint8_t* o
                 return OC_STACK_INVALID_PARAM;
             }
 
-            err = err | cbor_encoder_create_map(&rootArray, &map, DISCOVERY_CBOR_RES_MAP_LEN);
+            // resource map inside the links array.
+            err = err | cbor_encoder_create_map(&linkArray, &resourceMapElement,
+                DISCOVERY_CBOR_LINKS_MAP_LEN);
+
+            // Below are insertions of the resource properties into the map.
+            // Uri
+            err = err | AddTextStringToMap(&resourceMapElement, OC_RSRVD_HREF,
+                        sizeof(OC_RSRVD_HREF) - 1,
+                        resource->uri);
+            // Resource Type
+            if (resource->types)
+            {
+                char* joinedTypes = OCStringLLJoin(resource->types);
+                if (joinedTypes)
+                {
+                    err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_RESOURCE_TYPE,
+                            sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
+                    err = err | cbor_encode_text_string(&resourceMapElement, joinedTypes,
+                            strlen(joinedTypes));
+                    OICFree(joinedTypes);
+                }
+                else
+                {
+                    return OC_STACK_NO_MEMORY;
+                }
+            }
+            // Interface Types
+            if (resource->interfaces)
+            {
+                char* joinedInterfaces = OCStringLLJoin(resource->interfaces);
+                if (joinedInterfaces)
+                {
+                    err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_INTERFACE,
+                            sizeof(OC_RSRVD_INTERFACE) - 1);
+                    err = err | cbor_encode_text_string(&resourceMapElement, joinedInterfaces,
+                            strlen(joinedInterfaces));
+                    OICFree(joinedInterfaces);
+                }
+                else
+                {
+                    return OC_STACK_NO_MEMORY;
+                }
+            }
+
+            // Policy
+            CborEncoder policyMap;
+            err = err | cbor_encode_text_string(&resourceMapElement, OC_RSRVD_POLICY,
+                    sizeof(OC_RSRVD_POLICY) - 1);
+            err = err | cbor_encoder_create_map(&resourceMapElement, &policyMap, CborIndefiniteLength);
 
-            // Device ID
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_DEVICE_ID,
-                    sizeof(OC_RSRVD_DEVICE_ID) - 1);
-            err = err | cbor_encode_byte_string(&map, resource->sid, UUID_SIZE);
+            // Bitmap
+            err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_BITMAP,
+                    sizeof(OC_RSRVD_BITMAP) - 1);
+            err = err | cbor_encode_uint(&policyMap, resource->bitmap);
 
+            if(resource->secure)
             {
-                CborEncoder linkArray;
-                err = err | cbor_encode_text_string(&map, OC_RSRVD_LINKS, sizeof(OC_RSRVD_LINKS) -1);
-                err = err | cbor_encoder_create_array(&map, &linkArray, CborIndefiniteLength);
+                err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_SECURE,
+                        sizeof(OC_RSRVD_SECURE) - 1);
+                err = err | cbor_encode_boolean(&policyMap, OC_RESOURCE_SECURE);
 
-                // Link Map
+                if(resource->port != 0)
                 {
-                    CborEncoder linkMap;
-                    err = err | cbor_encoder_create_map(&linkArray, &linkMap, DISCOVERY_CBOR_LINKS_MAP_LEN);
-
-                    // Uri
-                    err = err | AddTextStringToMap(&linkMap, OC_RSRVD_HREF,
-                            sizeof(OC_RSRVD_HREF) - 1,
-                            resource->uri);
-                    // Resource Type
-                    if (resource->types)
-                    {
-                        char* joinedTypes = OCStringLLJoin(resource->types);
-                        if (joinedTypes)
-                        {
-                            err = err | cbor_encode_text_string(&linkMap, OC_RSRVD_RESOURCE_TYPE,
-                                    sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
-                            err = err | cbor_encode_text_string(&linkMap, joinedTypes,
-                                    strlen(joinedTypes));
-                            OICFree(joinedTypes);
-                        }
-                        else
-                        {
-                            return OC_STACK_NO_MEMORY;
-                        }
-                    }
-                    // Interface Types
-                    if (resource->interfaces)
-                    {
-                        char* joinedInterfaces = OCStringLLJoin(resource->interfaces);
-                        if (joinedInterfaces)
-                        {
-                            err = err | cbor_encode_text_string(&linkMap, OC_RSRVD_INTERFACE,
-                                    sizeof(OC_RSRVD_INTERFACE) - 1);
-                            err = err | cbor_encode_text_string(&linkMap, joinedInterfaces,
-                                    strlen(joinedInterfaces));
-                            OICFree(joinedInterfaces);
-                        }
-                        else
-                        {
-                            return OC_STACK_NO_MEMORY;
-                        }
-                    }
-                    // Policy
-                    {
-                        CborEncoder policyMap;
-                        err = err | cbor_encode_text_string(&linkMap, OC_RSRVD_POLICY,
-                                sizeof(OC_RSRVD_POLICY) - 1);
-                        err = err | cbor_encoder_create_map(&linkMap, &policyMap, CborIndefiniteLength);
-
-                        // Bitmap
-                        err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_BITMAP,
-                                sizeof(OC_RSRVD_BITMAP) - 1);
-                        err = err | cbor_encode_uint(&policyMap, resource->bitmap);
-
-                        if(resource->secure)
-                        {
-                            err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_SECURE,
-                                    sizeof(OC_RSRVD_SECURE) - 1);
-                            err = err | cbor_encode_boolean(&policyMap, OC_RESOURCE_SECURE);
-
-                            if(resource->port != 0)
-                            {
-                                err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_HOSTING_PORT,
-                                        sizeof(OC_RSRVD_HOSTING_PORT) - 1);
-                                err = err | cbor_encode_uint(&policyMap, resource->port);
-                            }
-                        }
-
-                        err = err | cbor_encoder_close_container(&linkMap, &policyMap);
-                    }
-                    // Close
-                    err = err | cbor_encoder_close_container(&linkArray, &linkMap);
+                    err = err | cbor_encode_text_string(&policyMap, OC_RSRVD_HOSTING_PORT,
+                            sizeof(OC_RSRVD_HOSTING_PORT) - 1);
+                    err = err | cbor_encode_uint(&policyMap, resource->port);
                 }
-                err = err | cbor_encoder_close_container(&map, &linkArray);
             }
-            err = err | cbor_encoder_close_container(&rootArray, &map);
+
+            err = err | cbor_encoder_close_container(&resourceMapElement, &policyMap);
+
+            // Finsihed encoding a resource, close the map.
+            err = err | cbor_encoder_close_container(&linkArray, &resourceMapElement);
         }
-        // Close main array
+        // Close links array inside the root map.
+        err = err | cbor_encoder_close_container(&rootMap, &linkArray);
+        // close root map inside the root array.
+        err = err | cbor_encoder_close_container(&rootArray, &rootMap);
+        // Close the final root array.
         err = err | cbor_encoder_close_container(&encoder, &rootArray);
     }
 
@@ -407,53 +429,30 @@ static int64_t OCConvertDevicePayload(OCDevicePayload* payload, uint8_t* outPayl
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
+    CborEncoder repMap;
+    err = err | cbor_encoder_create_map(&encoder, &repMap, CborIndefiniteLength);
 
-    {
-        CborEncoder map;
-        err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
+    // Device ID
+    err = err | cbor_encode_text_string(&repMap, OC_RSRVD_DEVICE_ID,
+            sizeof(OC_RSRVD_DEVICE_ID) - 1);
+    err = err | cbor_encode_byte_string(&repMap, payload->sid, UUID_SIZE);
 
-        // uri
-        err = err | ConditionalAddTextStringToMap(&map, OC_RSRVD_HREF, sizeof(OC_RSRVD_HREF) - 1,
-                payload->uri);
+    // Device Name
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DEVICE_NAME,
+            sizeof(OC_RSRVD_DEVICE_NAME) - 1,
+            payload->deviceName);
 
-        // Rep Map
-        {
-            CborEncoder repMap;
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_REPRESENTATION,
-                    sizeof(OC_RSRVD_REPRESENTATION) - 1);
-            err = err | cbor_encoder_create_map(&map, &repMap, CborIndefiniteLength);
-
-            // Device ID
-            err = err | cbor_encode_text_string(&repMap, OC_RSRVD_DEVICE_ID,
-                    sizeof(OC_RSRVD_DEVICE_ID) - 1);
-            err = err | cbor_encode_byte_string(&repMap, payload->sid, UUID_SIZE);
-
-            // Device Name
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DEVICE_NAME,
-                    sizeof(OC_RSRVD_DEVICE_NAME) - 1,
-                    payload->deviceName);
-
-            // Device Spec Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SPEC_VERSION,
-                    sizeof(OC_RSRVD_SPEC_VERSION) - 1,
-                    payload->specVersion);
-
-            // Device data Model Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DATA_MODEL_VERSION,
-                    sizeof(OC_RSRVD_DATA_MODEL_VERSION) - 1,
-                    payload->dataModelVersion);
-
-            err = err | cbor_encoder_close_container(&map, &repMap);
-        }
+    // Device Spec Version
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SPEC_VERSION,
+            sizeof(OC_RSRVD_SPEC_VERSION) - 1,
+            payload->specVersion);
 
-        // Close Map
-        err = err | cbor_encoder_close_container(&rootArray, &map);
-    }
+    // Device data Model Version
+    err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_DATA_MODEL_VERSION,
+            sizeof(OC_RSRVD_DATA_MODEL_VERSION) - 1,
+            payload->dataModelVersion);
 
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &repMap);
 
     return checkError(err, &encoder, outPayload, size);
 }
@@ -465,87 +464,69 @@ static int64_t OCConvertPlatformPayload(OCPlatformPayload* payload, uint8_t* out
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
     {
-        CborEncoder map;
-        err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
-
-        // uri
-        err = err | ConditionalAddTextStringToMap(&map, OC_RSRVD_HREF, sizeof(OC_RSRVD_HREF) - 1,
-                payload->uri);
-
-        // Rep Map
-        {
-            CborEncoder repMap;
-            err = err | cbor_encode_text_string(&map, OC_RSRVD_REPRESENTATION,
-                    sizeof(OC_RSRVD_REPRESENTATION) - 1);
-            err = err | cbor_encoder_create_map(&map, &repMap, CborIndefiniteLength);
-
-            // Platform ID
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_ID,
-                    sizeof(OC_RSRVD_PLATFORM_ID) - 1,
-                    payload->info.platformID);
-
-            // MFG Name
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_NAME,
-                    sizeof(OC_RSRVD_MFG_NAME) - 1,
-                    payload->info.manufacturerName);
-
-            // MFG Url
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_URL,
-                    sizeof(OC_RSRVD_MFG_URL) - 1,
-                    payload->info.manufacturerUrl);
-
-            // Model Num
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MODEL_NUM,
-                    sizeof(OC_RSRVD_MODEL_NUM) - 1,
-                    payload->info.modelNumber);
-
-            // Date of Mfg
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_DATE,
-                    sizeof(OC_RSRVD_MFG_DATE) - 1,
-                    payload->info.dateOfManufacture);
-
-            // Platform Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_VERSION,
-                    sizeof(OC_RSRVD_PLATFORM_VERSION) - 1,
-                    payload->info.platformVersion);
-
-            // OS Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_OS_VERSION,
-                    sizeof(OC_RSRVD_OS_VERSION) - 1,
-                    payload->info.operatingSystemVersion);
-
-            // Hardware Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_HARDWARE_VERSION,
-                    sizeof(OC_RSRVD_HARDWARE_VERSION) - 1,
-                    payload->info.hardwareVersion);
-
-            // Firmware Version
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_FIRMWARE_VERSION,
-                    sizeof(OC_RSRVD_FIRMWARE_VERSION) - 1,
-                    payload->info.firmwareVersion);
-
-            // Support URL
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SUPPORT_URL,
-                    sizeof(OC_RSRVD_SUPPORT_URL) - 1,
-                    payload->info.supportUrl);
-
-            // System Time
-            err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SYSTEM_TIME,
-                    sizeof(OC_RSRVD_SYSTEM_TIME) - 1,
-                    payload->info.systemTime);
-            err = err | cbor_encoder_close_container(&map, &repMap);
-        }
+        CborEncoder repMap;
+        err = err | cbor_encoder_create_map(&encoder, &repMap, CborIndefiniteLength);
+
+        // Platform ID
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_ID,
+                sizeof(OC_RSRVD_PLATFORM_ID) - 1,
+                payload->info.platformID);
+
+        // MFG Name
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_NAME,
+                sizeof(OC_RSRVD_MFG_NAME) - 1,
+                payload->info.manufacturerName);
+
+        // MFG Url
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_URL,
+                sizeof(OC_RSRVD_MFG_URL) - 1,
+                payload->info.manufacturerUrl);
+
+        // Model Num
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MODEL_NUM,
+                sizeof(OC_RSRVD_MODEL_NUM) - 1,
+                payload->info.modelNumber);
+
+        // Date of Mfg
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_MFG_DATE,
+                sizeof(OC_RSRVD_MFG_DATE) - 1,
+                payload->info.dateOfManufacture);
+
+        // Platform Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_PLATFORM_VERSION,
+                sizeof(OC_RSRVD_PLATFORM_VERSION) - 1,
+                payload->info.platformVersion);
+
+        // OS Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_OS_VERSION,
+                sizeof(OC_RSRVD_OS_VERSION) - 1,
+                payload->info.operatingSystemVersion);
+
+        // Hardware Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_HARDWARE_VERSION,
+                sizeof(OC_RSRVD_HARDWARE_VERSION) - 1,
+                payload->info.hardwareVersion);
+
+        // Firmware Version
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_FIRMWARE_VERSION,
+                sizeof(OC_RSRVD_FIRMWARE_VERSION) - 1,
+                payload->info.firmwareVersion);
+
+        // Support URL
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SUPPORT_URL,
+                sizeof(OC_RSRVD_SUPPORT_URL) - 1,
+                payload->info.supportUrl);
+
+        // System Time
+        err = err | ConditionalAddTextStringToMap(&repMap, OC_RSRVD_SYSTEM_TIME,
+                sizeof(OC_RSRVD_SYSTEM_TIME) - 1,
+                payload->info.systemTime);
 
         // Close Map
-        err = err | cbor_encoder_close_container(&rootArray, &map);
+        err = err | cbor_encoder_close_container(&encoder, &repMap);
     }
 
-    // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
-
     return checkError(err, &encoder, outPayload, size);
 }
 
@@ -586,7 +567,7 @@ static int64_t OCConvertArrayItem(CborEncoder* array, const OCRepPayloadValueArr
             }
             else
             {
-                err = OCConvertSingleRepPayload(array, valArray->objArray[index]);
+                err = OCConvertRepMap(array, valArray->objArray[index]);
             }
             break;
         case OCREP_PROP_ARRAY:
@@ -645,117 +626,64 @@ static int64_t OCConvertArray(CborEncoder* parent, const OCRepPayloadValueArray*
     return err;
 }
 
-static int64_t OCConvertSingleRepPayload(CborEncoder* parent, const OCRepPayload* payload)
+static int64_t OCConvertRepMap(CborEncoder *map, const OCRepPayload* payload)
 {
     int64_t err = 0;
-    CborEncoder map;
-    err = err | cbor_encoder_create_map(parent, &map, CborIndefiniteLength);
-
-    // Uri
-    err = err | ConditionalAddTextStringToMap(&map, OC_RSRVD_HREF,
-            sizeof(OC_RSRVD_HREF) - 1,
-            payload->uri);
-
-    // Prop Map
-    // resource types, interfaces
-    if(payload->types || payload->interfaces)
-    {
-        OC_LOG(INFO, TAG, "Payload has types or interfaces");
-        err = err | cbor_encode_text_string(&map,
-                OC_RSRVD_PROPERTY,
-                sizeof(OC_RSRVD_PROPERTY) - 1);
-        CborEncoder propMap;
-        err = err | cbor_encoder_create_map(&map, &propMap, 2);
-
-        if (payload->types)
-        {
-            char* joinedTypes = OCStringLLJoin(payload->types);
-            if (joinedTypes)
-            {
-                err = err | cbor_encode_text_string(&propMap, OC_RSRVD_RESOURCE_TYPE,
-                        sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
-                err = err | cbor_encode_text_string(&propMap, joinedTypes,
-                        strlen(joinedTypes));
-                OICFree(joinedTypes);
-            }
-            else
-            {
-                return OC_STACK_NO_MEMORY;
-            }
-        }
-        if (payload->interfaces)
-        {
-            char* joinedInterfaces = OCStringLLJoin(payload->interfaces);
-            if (joinedInterfaces)
-            {
-                err = err | cbor_encode_text_string(&propMap, OC_RSRVD_INTERFACE,
-                        sizeof(OC_RSRVD_INTERFACE) - 1);
-                err = err | cbor_encode_text_string(&propMap, joinedInterfaces,
-                        strlen(joinedInterfaces));
-                OICFree(joinedInterfaces);
-            }
-            else
-            {
-                return OC_STACK_NO_MEMORY;
-            }
-        }
-        err = err | cbor_encoder_close_container(&map, &propMap);
-    }
+    CborEncoder repMap;
+    err = err | cbor_encoder_create_map(map, &repMap, CborIndefiniteLength);
+    err = err | OCConvertSingleRepPayload(&repMap, payload);
+    err = err | cbor_encoder_close_container(map, &repMap);
+    return err;
+}
 
-    // Rep Map
+static int64_t OCConvertSingleRepPayload(CborEncoder* repMap, const OCRepPayload* payload)
+{
+    int64_t err = 0;
+    OCRepPayloadValue* value = payload->values;
+    while(value)
     {
-        CborEncoder repMap;
-        err = err | cbor_encode_text_string(&map,
-                OC_RSRVD_REPRESENTATION,
-                sizeof(OC_RSRVD_REPRESENTATION) - 1);
-        err = err | cbor_encoder_create_map(&map, &repMap, CborIndefiniteLength);
-        OCRepPayloadValue* value = payload->values;
-        while(value)
+        err = err | cbor_encode_text_string(repMap,
+                value->name,
+                strlen(value->name));
+        switch(value->type)
         {
-            err = err | cbor_encode_text_string(&repMap,
-                    value->name,
-                    strlen(value->name));
-            switch(value->type)
-            {
-                case OCREP_PROP_NULL:
-                    err = err | cbor_encode_null(&repMap);
-                    break;
-                case OCREP_PROP_INT:
-                    err = err | cbor_encode_int(&repMap,
-                            value->i);
-                    break;
-                case OCREP_PROP_DOUBLE:
-                    err = err | cbor_encode_double(&repMap,
-                            value->d);
-                    break;
-                case OCREP_PROP_BOOL:
-                    err = err | cbor_encode_boolean(&repMap,
-                            value->b);
-                    break;
-                case OCREP_PROP_STRING:
-                    err = err | cbor_encode_text_string(&repMap,
-                            value->str, strlen(value->str));
-                    break;
-                case OCREP_PROP_OBJECT:
-                    err = err | OCConvertSingleRepPayload(&repMap, value->obj);
-                    break;
-                case OCREP_PROP_ARRAY:
-                    err = err | OCConvertArray(&repMap, &value->arr);
-                    break;
-                default:
-                    OC_LOG_V(ERROR, TAG, "Invalid Prop type: %d",
-                            value->type);
-                    break;
-            }
-            value = value->next;
+            case OCREP_PROP_NULL:
+                err = err | cbor_encode_null(repMap);
+                break;
+            case OCREP_PROP_INT:
+                err = err | cbor_encode_int(repMap,
+                        value->i);
+                break;
+            case OCREP_PROP_DOUBLE:
+                err = err | cbor_encode_double(repMap,
+                        value->d);
+                break;
+            case OCREP_PROP_BOOL:
+                err = err | cbor_encode_boolean(repMap,
+                        value->b);
+                break;
+            case OCREP_PROP_STRING:
+                err = err | cbor_encode_text_string(repMap,
+                        value->str, strlen(value->str));
+                break;
+            case OCREP_PROP_BYTE_STRING:
+                err = err | cbor_encode_byte_string(repMap,
+                        value->ocByteStr.bytes, value->ocByteStr.len);
+                break;
+            case OCREP_PROP_OBJECT:
+                err = err | OCConvertRepMap(repMap, value->obj);
+                break;
+            case OCREP_PROP_ARRAY:
+                err = err | OCConvertArray(repMap, &value->arr);
+                break;
+            default:
+                OC_LOG_V(ERROR, TAG, "Invalid Prop type: %d",
+                        value->type);
+                break;
         }
-
-        err = err | cbor_encoder_close_container(&map, &repMap);
+        value = value->next;
     }
 
-    // Close Map
-    err = err | cbor_encoder_close_container(parent, &map);
-
     return err;
 }
 
@@ -765,17 +693,51 @@ static int64_t OCConvertRepPayload(OCRepPayload* payload, uint8_t* outPayload, s
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, CborIndefiniteLength);
+    CborEncoder rootMap;
+    err = err | cbor_encoder_create_map(&encoder, &rootMap, CborIndefiniteLength);
+
+    if (payload->types)
+    {
+        OC_LOG(INFO, TAG, "Payload has types or interfaces");
+        char* joinedTypes = OCStringLLJoin(payload->types);
+        if (joinedTypes)
+        {
+            err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_RESOURCE_TYPE,
+                    sizeof(OC_RSRVD_RESOURCE_TYPE) - 1);
+            err = err | cbor_encode_text_string(&rootMap, joinedTypes,
+                    strlen(joinedTypes));
+            OICFree(joinedTypes);
+        }
+        else
+        {
+            return OC_STACK_NO_MEMORY;
+        }
+    }
+    if (payload->interfaces)
+    {
+        char* joinedInterfaces = OCStringLLJoin(payload->interfaces);
+        if (joinedInterfaces)
+        {
+            err = err | cbor_encode_text_string(&rootMap, OC_RSRVD_INTERFACE,
+                    sizeof(OC_RSRVD_INTERFACE) - 1);
+            err = err | cbor_encode_text_string(&rootMap, joinedInterfaces,
+                    strlen(joinedInterfaces));
+            OICFree(joinedInterfaces);
+        }
+        else
+        {
+            return OC_STACK_NO_MEMORY;
+        }
+    }
 
     while(payload != NULL && (err == 0 || err == CborErrorOutOfMemory))
     {
-        err = err | OCConvertSingleRepPayload(&rootArray, payload);
+        err = err | OCConvertSingleRepPayload(&rootMap, payload);
         payload = payload->next;
     }
 
     // Close main array
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &rootMap);
 
     return checkError(err, &encoder, outPayload, size);
 }
@@ -787,12 +749,8 @@ static int64_t OCConvertPresencePayload(OCPresencePayload* payload,
     int64_t err = 0;
 
     cbor_encoder_init(&encoder, outPayload, *size, 0);
-    CborEncoder rootArray;
-
-    err = err | cbor_encoder_create_array(&encoder, &rootArray, 1);
-
     CborEncoder map;
-    err = err | cbor_encoder_create_map(&rootArray, &map, CborIndefiniteLength);
+    err = err | cbor_encoder_create_map(&encoder, &map, CborIndefiniteLength);
 
     // Sequence Number
     err = err | cbor_encode_text_string(&map,
@@ -819,8 +777,7 @@ static int64_t OCConvertPresencePayload(OCPresencePayload* payload,
     }
 
     // Close Map
-    err = err | cbor_encoder_close_container(&rootArray, &map);
-    err = err | cbor_encoder_close_container(&encoder, &rootArray);
+    err = err | cbor_encoder_close_container(&encoder, &map);
 
     return checkError(err, &encoder, outPayload, size);
 }