Modify eu-strip option to perform strip in post script of rpm package & add option...
[platform/upstream/rpm.git] / python / rpmfi-py.c
index 5da2798..458e721 100644 (file)
-/** \ingroup python
- * \file python/rpmfi-py.c
- */
+#include "rpmsystem-py.h"
 
-#include "system.h"
-
-#include "Python.h"
-#ifdef __LCLINT__
-#undef  PyObject_HEAD
-#define PyObject_HEAD   int _PyObjectHead;
-#endif
-
-#include <rpmlib.h>
+#include <rpm/rpmtypes.h>
+#include <rpm/rpmpgp.h>
 
 #include "header-py.h"
 #include "rpmfi-py.h"
 
-#include "debug.h"
-
-/*@access rpmfi @*/
-
-static PyObject *
-rpmfi_Debug(/*@unused@*/ rpmfiObject * s, PyObject * args)
-       /*@globals _Py_NoneStruct @*/
-       /*@modifies _Py_NoneStruct @*/
-{
-    if (!PyArg_ParseTuple(args, "i", &_rpmfi_debug)) return NULL;
-    Py_INCREF(Py_None);
-    return Py_None;
-}
+struct rpmfiObject_s {
+    PyObject_HEAD
+    PyObject *md_dict;         /*!< to look like PyModuleObject */
+    int active;
+    rpmfi fi;
+};
 
 static PyObject *
-rpmfi_FC(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FC(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FC")) return NULL;
     return Py_BuildValue("i", rpmfiFC(s->fi));
 }
 
 static PyObject *
-rpmfi_FX(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FX(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FX")) return NULL;
     return Py_BuildValue("i", rpmfiFX(s->fi));
 }
 
 static PyObject *
-rpmfi_DC(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_DC(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":DC")) return NULL;
     return Py_BuildValue("i", rpmfiDC(s->fi));
 }
 
 static PyObject *
-rpmfi_DX(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_DX(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":DX")) return NULL;
     return Py_BuildValue("i", rpmfiDX(s->fi));
 }
 
 static PyObject *
-rpmfi_BN(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_BN(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":BN")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiBN(s->fi)));
+    return Py_BuildValue("s", rpmfiBN(s->fi));
 }
 
 static PyObject *
-rpmfi_DN(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_DN(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":DN")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiDN(s->fi)));
+    return Py_BuildValue("s", rpmfiDN(s->fi));
 }
 
 static PyObject *
-rpmfi_FN(rpmfiObject * s, PyObject * args)
-       /*@modifies s @*/
+rpmfi_FN(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FN")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiFN(s->fi)));
+    return Py_BuildValue("s", rpmfiFN(s->fi));
 }
 
 static PyObject *
-rpmfi_FFlags(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FFlags(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FFlags")) return NULL;
     return Py_BuildValue("i", rpmfiFFlags(s->fi));
 }
 
 static PyObject *
-rpmfi_VFlags(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_VFlags(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":VFlags")) return NULL;
     return Py_BuildValue("i", rpmfiVFlags(s->fi));
 }
 
 static PyObject *
-rpmfi_FMode(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FMode(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FMode")) return NULL;
     return Py_BuildValue("i", rpmfiFMode(s->fi));
 }
 
 static PyObject *
-rpmfi_FState(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FState(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FState")) return NULL;
     return Py_BuildValue("i", rpmfiFState(s->fi));
 }
 
-/* XXX rpmfiMD5 */
+/* XXX rpmfiFDigest */
 static PyObject *
-rpmfi_MD5(rpmfiObject * s, PyObject * args)
-       /*@*/
-{
-    const unsigned char * MD5;
-    char fmd5[33];
-    char * t;
-    int i;
-    
-    if (!PyArg_ParseTuple(args, ":MD5")) return NULL;
-    MD5 = rpmfiMD5(s->fi);
-    for (i = 0, t = fmd5; i < 16; i++, t += 2)
-       sprintf(t, "%02x", MD5[i]);
-    *t = '\0';
-    return Py_BuildValue("s", xstrdup(fmd5));
+rpmfi_Digest(rpmfiObject * s, PyObject * unused)
+{
+    char *digest = rpmfiFDigestHex(s->fi, NULL);
+    if (digest) {
+       PyObject *dig = Py_BuildValue("s", digest);
+       free(digest);
+       return dig;
+    } else {
+       Py_RETURN_NONE;
+    }
 }
 
 static PyObject *
-rpmfi_FLink(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FLink(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FLink")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiFLink(s->fi)));
+    return Py_BuildValue("s", rpmfiFLink(s->fi));
 }
 
 static PyObject *
-rpmfi_FSize(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FSize(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FSize")) return NULL;
-    return Py_BuildValue("i", rpmfiFSize(s->fi));
+    return Py_BuildValue("L", rpmfiFSize(s->fi));
 }
 
 static PyObject *
-rpmfi_FRdev(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FRdev(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FRdev")) return NULL;
     return Py_BuildValue("i", rpmfiFRdev(s->fi));
 }
 
 static PyObject *
-rpmfi_FMtime(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FMtime(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FMtime")) return NULL;
     return Py_BuildValue("i", rpmfiFMtime(s->fi));
 }
 
 static PyObject *
-rpmfi_FUser(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FUser(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FUser")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiFUser(s->fi)));
+    return Py_BuildValue("s", rpmfiFUser(s->fi));
 }
 
 static PyObject *
-rpmfi_FGroup(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FGroup(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FGroup")) return NULL;
-    return Py_BuildValue("s", xstrdup(rpmfiFGroup(s->fi)));
+    return Py_BuildValue("s", rpmfiFGroup(s->fi));
 }
 
 static PyObject *
-rpmfi_FColor(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FColor(rpmfiObject * s, PyObject * unused)
 {
-    if (!PyArg_ParseTuple(args, ":FColor")) return NULL;
     return Py_BuildValue("i", rpmfiFColor(s->fi));
 }
 
 static PyObject *
-rpmfi_FClass(rpmfiObject * s, PyObject * args)
-       /*@*/
+rpmfi_FClass(rpmfiObject * s, PyObject * unused)
 {
     const char * FClass;
 
-    if (!PyArg_ParseTuple(args, ":FClass")) return NULL;
     if ((FClass = rpmfiFClass(s->fi)) == NULL)
        FClass = "";
-    return Py_BuildValue("s", xstrdup(FClass));
-}
-
-#if Py_TPFLAGS_HAVE_ITER
-static PyObject *
-rpmfi_iter(rpmfiObject * s, /*@unused@*/ PyObject * args)
-       /*@*/
-{
-    Py_INCREF(s);
-    return (PyObject *)s;
+    return Py_BuildValue("s", FClass);
 }
-#endif
 
 static PyObject *
 rpmfi_iternext(rpmfiObject * s)
-       /*@globals _Py_NoneStruct @*/
-       /*@modifies s, _Py_NoneStruct @*/
 {
     PyObject * result = NULL;
 
     /* Reset loop indices on 1st entry. */
     if (!s->active) {
-       rpmfiInit(s->fi, 0);
+       s->fi = rpmfiInit(s->fi, 0);
        s->active = 1;
     }
 
     /* If more to do, return the file tuple. */
     if (rpmfiNext(s->fi) >= 0) {
        const char * FN = rpmfiFN(s->fi);
-       int FSize = rpmfiFSize(s->fi);
+       rpm_loff_t FSize = rpmfiFSize(s->fi);
        int FMode = rpmfiFMode(s->fi);
        int FMtime = rpmfiFMtime(s->fi);
        int FFlags = rpmfiFFlags(s->fi);
@@ -240,21 +170,6 @@ rpmfi_iternext(rpmfiObject * s)
        int VFlags = rpmfiVFlags(s->fi);
        const char * FUser = rpmfiFUser(s->fi);
        const char * FGroup = rpmfiFGroup(s->fi);
-/*@-shadow@*/
-       const unsigned char * MD5 = rpmfiMD5(s->fi), *s = MD5;
-/*@=shadow@*/
-       char FMD5[2*16+1], *t = FMD5;
-       static const char hex[] = "0123456789abcdef";
-       int gotMD5, i;
-
-       gotMD5 = 0;
-       if (s)
-       for (i = 0; i < 16; i++) {
-           gotMD5 |= *s;
-           *t++ = hex[ (*s >> 4) & 0xf ];
-           *t++ = hex[ (*s++   ) & 0xf ];
-       }
-       *t = '\0';
 
        result = PyTuple_New(13);
        if (FN == NULL) {
@@ -262,7 +177,7 @@ rpmfi_iternext(rpmfiObject * s)
            PyTuple_SET_ITEM(result, 0, Py_None);
        } else
            PyTuple_SET_ITEM(result,  0, Py_BuildValue("s", FN));
-       PyTuple_SET_ITEM(result,  1, PyInt_FromLong(FSize));
+       PyTuple_SET_ITEM(result,  1, PyLong_FromLongLong(FSize));
        PyTuple_SET_ITEM(result,  2, PyInt_FromLong(FMode));
        PyTuple_SET_ITEM(result,  3, PyInt_FromLong(FMtime));
        PyTuple_SET_ITEM(result,  4, PyInt_FromLong(FFlags));
@@ -281,11 +196,7 @@ rpmfi_iternext(rpmfiObject * s)
            PyTuple_SET_ITEM(result, 11, Py_None);
        } else
            PyTuple_SET_ITEM(result, 11, Py_BuildValue("s", FGroup));
-       if (!gotMD5) {
-           Py_INCREF(Py_None);
-           PyTuple_SET_ITEM(result, 12, Py_None);
-       } else
-           PyTuple_SET_ITEM(result, 12, Py_BuildValue("s", FMD5));
+       PyTuple_SET_ITEM(result, 12, rpmfi_Digest(s, NULL));
 
     } else
        s->active = 0;
@@ -293,146 +204,69 @@ rpmfi_iternext(rpmfiObject * s)
     return result;
 }
 
-static PyObject *
-rpmfi_Next(rpmfiObject * s, /*@unused@*/ PyObject * args)
-       /*@globals _Py_NoneStruct @*/
-       /*@modifies s, _Py_NoneStruct @*/
-{
-    PyObject * result = NULL;
-
-    result = rpmfi_iternext(s);
-
-    if (result == NULL) {
-       Py_INCREF(Py_None);
-       return Py_None;
-    }
-
-    return result;
-}
-
-#ifdef NOTYET
-static PyObject *
-rpmfi_NextD(rpmfiObject * s, PyObject * args)
-       /*@*/
-{
-       if (!PyArg_ParseTuple(args, ":NextD"))
-               return NULL;
-       Py_INCREF(Py_None);
-       return Py_None;
-}
-
-static PyObject *
-rpmfi_InitD(rpmfiObject * s, PyObject * args)
-       /*@*/
-{
-       if (!PyArg_ParseTuple(args, ":InitD"))
-               return NULL;
-       Py_INCREF(Py_None);
-       return Py_None;
-}
-#endif
-
-/*@-fullinitblock@*/
-/*@unchecked@*/ /*@observer@*/
 static struct PyMethodDef rpmfi_methods[] = {
- {"Debug",     (PyCFunction)rpmfi_Debug,       METH_VARARGS,
-       NULL},
- {"FC",                (PyCFunction)rpmfi_FC,          METH_VARARGS,
+ {"FC",                (PyCFunction)rpmfi_FC,          METH_NOARGS,
        NULL},
- {"FX",                (PyCFunction)rpmfi_FX,          METH_VARARGS,
+ {"FX",                (PyCFunction)rpmfi_FX,          METH_NOARGS,
        NULL},
- {"DC",                (PyCFunction)rpmfi_DC,          METH_VARARGS,
+ {"DC",                (PyCFunction)rpmfi_DC,          METH_NOARGS,
        NULL},
- {"DX",                (PyCFunction)rpmfi_DX,          METH_VARARGS,
+ {"DX",                (PyCFunction)rpmfi_DX,          METH_NOARGS,
        NULL},
- {"BN",                (PyCFunction)rpmfi_BN,          METH_VARARGS,
+ {"BN",                (PyCFunction)rpmfi_BN,          METH_NOARGS,
        NULL},
- {"DN",                (PyCFunction)rpmfi_DN,          METH_VARARGS,
+ {"DN",                (PyCFunction)rpmfi_DN,          METH_NOARGS,
        NULL},
- {"FN",                (PyCFunction)rpmfi_FN,          METH_VARARGS,
+ {"FN",                (PyCFunction)rpmfi_FN,          METH_NOARGS,
        NULL},
- {"FFlags",    (PyCFunction)rpmfi_FFlags,      METH_VARARGS,
+ {"FFlags",    (PyCFunction)rpmfi_FFlags,      METH_NOARGS,
        NULL},
- {"VFlags",    (PyCFunction)rpmfi_VFlags,      METH_VARARGS,
+ {"VFlags",    (PyCFunction)rpmfi_VFlags,      METH_NOARGS,
        NULL},
- {"FMode",     (PyCFunction)rpmfi_FMode,       METH_VARARGS,
+ {"FMode",     (PyCFunction)rpmfi_FMode,       METH_NOARGS,
        NULL},
- {"FState",    (PyCFunction)rpmfi_FState,      METH_VARARGS,
+ {"FState",    (PyCFunction)rpmfi_FState,      METH_NOARGS,
        NULL},
- {"MD5",       (PyCFunction)rpmfi_MD5,         METH_VARARGS,
+ {"MD5",       (PyCFunction)rpmfi_Digest,      METH_NOARGS,
        NULL},
- {"FLink",     (PyCFunction)rpmfi_FLink,       METH_VARARGS,
+ {"Digest",    (PyCFunction)rpmfi_Digest,      METH_NOARGS,
        NULL},
- {"FSize",     (PyCFunction)rpmfi_FSize,       METH_VARARGS,
+ {"FLink",     (PyCFunction)rpmfi_FLink,       METH_NOARGS,
        NULL},
- {"FRdev",     (PyCFunction)rpmfi_FRdev,       METH_VARARGS,
+ {"FSize",     (PyCFunction)rpmfi_FSize,       METH_NOARGS,
        NULL},
- {"FMtime",    (PyCFunction)rpmfi_FMtime,      METH_VARARGS,
+ {"FRdev",     (PyCFunction)rpmfi_FRdev,       METH_NOARGS,
        NULL},
- {"FUser",     (PyCFunction)rpmfi_FUser,       METH_VARARGS,
+ {"FMtime",    (PyCFunction)rpmfi_FMtime,      METH_NOARGS,
        NULL},
- {"FGroup",    (PyCFunction)rpmfi_FGroup,      METH_VARARGS,
+ {"FUser",     (PyCFunction)rpmfi_FUser,       METH_NOARGS,
        NULL},
- {"FColor",    (PyCFunction)rpmfi_FColor,      METH_VARARGS,
+ {"FGroup",    (PyCFunction)rpmfi_FGroup,      METH_NOARGS,
        NULL},
- {"FClass",    (PyCFunction)rpmfi_FClass,      METH_VARARGS,
+ {"FColor",    (PyCFunction)rpmfi_FColor,      METH_NOARGS,
        NULL},
- {"next",      (PyCFunction)rpmfi_Next,        METH_VARARGS,
-"fi.next() -> (FN, FSize, FMode, FMtime, FFlags, FRdev, FInode, FNlink, FState, VFlags, FUser, FGroup, FMD5))\n\
-- Retrieve next file info tuple.\n" },
-#ifdef NOTYET
- {"NextD",     (PyCFunction)rpmfi_NextD,       METH_VARARGS,
+ {"FClass",    (PyCFunction)rpmfi_FClass,      METH_NOARGS,
        NULL},
- {"InitD",     (PyCFunction)rpmfi_InitD,       METH_VARARGS,
-       NULL},
-#endif
  {NULL,                NULL}           /* sentinel */
 };
-/*@=fullinitblock@*/
 
 /* ---------- */
 
 static void
-rpmfi_dealloc(/*@only@*/ /*@null@*/ rpmfiObject * s)
-       /*@modifies s @*/
+rpmfi_dealloc(rpmfiObject * s)
 {
-    if (s) {
-       s->fi = rpmfiFree(s->fi);
-       PyObject_Del(s);
-    }
-}
-
-static int
-rpmfi_print(rpmfiObject * s, FILE * fp, /*@unused@*/ int flags)
-       /*@globals fileSystem @*/
-       /*@modifies s, fp, fileSystem @*/
-{
-    if (!(s && s->fi))
-       return -1;
-
-    rpmfiInit(s->fi, 0);
-    while (rpmfiNext(s->fi) >= 0)
-       fprintf(fp, "%s\n", rpmfiFN(s->fi));
-    return 0;
-}
-
-static PyObject *
-rpmfi_getattr(rpmfiObject * s, char * name)
-       /*@*/
-{
-    return Py_FindMethod(rpmfi_methods, (PyObject *)s, name);
+    s->fi = rpmfiFree(s->fi);
+    Py_TYPE(s)->tp_free((PyObject *)s);
 }
 
 static int
 rpmfi_length(rpmfiObject * s)
-       /*@*/
 {
     return rpmfiFC(s->fi);
 }
 
 static PyObject *
 rpmfi_subscript(rpmfiObject * s, PyObject * key)
-       /*@modifies s @*/
 {
     int ix;
 
@@ -443,35 +277,58 @@ rpmfi_subscript(rpmfiObject * s, PyObject * key)
 
     ix = (int) PyInt_AsLong(key);
     rpmfiSetFX(s->fi, ix);
-    return Py_BuildValue("s", xstrdup(rpmfiFN(s->fi)));
+    return Py_BuildValue("s", rpmfiFN(s->fi));
 }
 
-/*@unchecked@*/ /*@observer@*/
 static PyMappingMethods rpmfi_as_mapping = {
-        (inquiry) rpmfi_length,                /* mp_length */
+        (lenfunc) rpmfi_length,                /* mp_length */
         (binaryfunc) rpmfi_subscript,  /* mp_subscript */
         (objobjargproc)0,              /* mp_ass_subscript */
 };
 
-/**
- */
-/*@unchecked@*/ /*@observer@*/
+static int rpmfi_init(rpmfiObject * s, PyObject *args, PyObject *kwds)
+{
+    s->active = 0;
+    return 0;
+}
+
+static PyObject * rpmfi_new(PyTypeObject * subtype, PyObject *args, PyObject *kwds)
+{
+    PyObject * to = NULL;
+    Header h = NULL;
+    rpmfi fi = NULL;
+    rpmTagVal tagN = RPMTAG_BASENAMES;
+    int flags = 0;
+    char * kwlist[] = {"header", "tag", "flags", NULL};
+
+    if (!PyArg_ParseTupleAndKeywords(args, kwds, "O&|Oi:rpmfi_init", kwlist,
+                               hdrFromPyObject, &h, &to, &flags))
+       return NULL;
+
+    fi = rpmfiNew(NULL, h, tagN, flags);
+
+    if (fi == NULL) {
+       PyErr_SetString(PyExc_ValueError, "invalid file data in header");
+       return NULL;
+    }
+
+    return rpmfi_Wrap(subtype, fi);
+}
+
 static char rpmfi_doc[] =
 "";
 
-/*@-fullinitblock@*/
 PyTypeObject rpmfi_Type = {
-       PyObject_HEAD_INIT(&PyType_Type)
-       0,                              /* ob_size */
+       PyVarObject_HEAD_INIT(&PyType_Type, 0)
        "rpm.fi",                       /* tp_name */
        sizeof(rpmfiObject),            /* tp_basicsize */
        0,                              /* tp_itemsize */
        /* methods */
        (destructor) rpmfi_dealloc,     /* tp_dealloc */
-       (printfunc) rpmfi_print,        /* tp_print */
-       (getattrfunc) rpmfi_getattr,    /* tp_getattr */
+       0,                              /* tp_print */
+       (getattrfunc)0,                 /* tp_getattr */
        (setattrfunc)0,                 /* tp_setattr */
-       (cmpfunc)0,                     /* tp_compare */
+       0,                              /* tp_compare */
        (reprfunc)0,                    /* tp_repr */
        0,                              /* tp_as_number */
        0,                              /* tp_as_sequence */
@@ -479,17 +336,16 @@ PyTypeObject rpmfi_Type = {
        (hashfunc)0,                    /* tp_hash */
        (ternaryfunc)0,                 /* tp_call */
        (reprfunc)0,                    /* tp_str */
-       0,                              /* tp_getattro */
-       0,                              /* tp_setattro */
+       PyObject_GenericGetAttr,        /* tp_getattro */
+       PyObject_GenericSetAttr,        /* tp_setattro */
        0,                              /* tp_as_buffer */
-       Py_TPFLAGS_DEFAULT,             /* tp_flags */
+       Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE, /* tp_flags */
        rpmfi_doc,                      /* tp_doc */
-#if Py_TPFLAGS_HAVE_ITER
        0,                              /* tp_traverse */
        0,                              /* tp_clear */
        0,                              /* tp_richcompare */
        0,                              /* tp_weaklistoffset */
-       (getiterfunc) rpmfi_iter,       /* tp_iter */
+       PyObject_SelfIter,              /* tp_iter */
        (iternextfunc) rpmfi_iternext,  /* tp_iternext */
        rpmfi_methods,                  /* tp_methods */
        0,                              /* tp_members */
@@ -499,14 +355,12 @@ PyTypeObject rpmfi_Type = {
        0,                              /* tp_descr_get */
        0,                              /* tp_descr_set */
        0,                              /* tp_dictoffset */
-       0,                              /* tp_init */
+       (initproc) rpmfi_init,          /* tp_init */
        0,                              /* tp_alloc */
-       0,                              /* tp_new */
+       (newfunc) rpmfi_new,            /* tp_new */
        0,                              /* tp_free */
        0,                              /* tp_is_gc */
-#endif
 };
-/*@=fullinitblock@*/
 
 /* ---------- */
 
@@ -515,35 +369,13 @@ rpmfi fiFromFi(rpmfiObject * s)
     return s->fi;
 }
 
-rpmfiObject *
-rpmfi_Wrap(rpmfi fi)
+PyObject * rpmfi_Wrap(PyTypeObject *subtype, rpmfi fi)
 {
-    rpmfiObject *s = PyObject_New(rpmfiObject, &rpmfi_Type);
+    rpmfiObject *s = (rpmfiObject *)subtype->tp_alloc(subtype, 0);
+    if (s == NULL) return NULL;
 
-    if (s == NULL)
-       return NULL;
     s->fi = fi;
     s->active = 0;
-    return s;
+    return (PyObject *) s;
 }
 
-rpmfiObject *
-hdr_fiFromHeader(PyObject * s, PyObject * args)
-{
-    hdrObject * ho = (hdrObject *)s;
-    PyObject * to = NULL;
-    rpmts ts = NULL;   /* XXX FIXME: fiFromHeader should be a ts method. */
-    rpmTag tagN = RPMTAG_BASENAMES;
-    int scareMem = 0;
-
-    if (!PyArg_ParseTuple(args, "|O:fiFromHeader", &to))
-       return NULL;
-    if (to != NULL) {
-       tagN = tagNumFromPyObject(to);
-       if (tagN == -1) {
-           PyErr_SetString(PyExc_KeyError, "unknown header tag");
-           return NULL;
-       }
-    }
-    return rpmfi_Wrap( rpmfiNew(ts, hdrGetHeader(ho), tagN, scareMem) );
-}