[Fix] Dereference after free in sta_remove_callback()
[platform/upstream/connman.git] / plugins / wifi.c
index 4204c92..322cfa0 100644 (file)
@@ -30,9 +30,8 @@
 #include <string.h>
 #include <sys/ioctl.h>
 #include <sys/socket.h>
-#include <linux/if_arp.h>
-#include <linux/wireless.h>
 #include <net/ethernet.h>
+#include <linux/wireless.h>
 
 #ifndef IFF_LOWER_UP
 #define IFF_LOWER_UP   0x10000
@@ -56,6 +55,7 @@
 #include <connman/provision.h>
 #include <connman/utsname.h>
 #include <connman/machine.h>
+#include <connman/tethering.h>
 
 #include <gsupplicant/gsupplicant.h>
 
@@ -64,7 +64,8 @@
 #define FAVORITE_MAXIMUM_RETRIES 2
 
 #define BGSCAN_DEFAULT "simple:30:-45:300"
-#define AUTOSCAN_DEFAULT "exponential:3:300"
+#define AUTOSCAN_EXPONENTIAL "exponential:3:300"
+#define AUTOSCAN_SINGLE "single:3"
 
 #define P2P_FIND_TIMEOUT 30
 #define P2P_CONNECTION_TIMEOUT 100
@@ -91,6 +92,12 @@ enum wifi_ap_capability{
        WIFI_AP_NOT_SUPPORTED   = 2,
 };
 
+enum wifi_scanning_type {
+       WIFI_SCANNING_UNKNOWN   = 0,
+       WIFI_SCANNING_PASSIVE   = 1,
+       WIFI_SCANNING_ACTIVE    = 2,
+};
+
 struct hidden_params {
        char ssid[32];
        unsigned int ssid_len;
@@ -151,7 +158,7 @@ struct wifi_data {
         * autoscan "emulation".
         */
        struct autoscan_params *autoscan;
-
+       enum wifi_scanning_type scanning_type;
        GSupplicantScanParams *scan_params;
        unsigned int p2p_find_timeout;
        unsigned int p2p_connection_timeout;
@@ -193,10 +200,9 @@ static GList *iface_list = NULL;
 
 static GList *pending_wifi_device = NULL;
 static GList *p2p_iface_list = NULL;
-bool wfd_service_registered = false;
+static bool wfd_service_registered = false;
 
 static void start_autoscan(struct connman_device *device);
-
 static int tech_set_tethering(struct connman_technology *technology,
                                const char *identifier, const char *passphrase,
                                const char *bridge, bool enabled);
@@ -1252,10 +1258,8 @@ static int peer_register_service(const unsigned char *specification,
                params = fill_in_peer_service_params(specification,
                                                specification_length, query,
                                                query_length, version);
-               if (!params) {
-                       ret = -ENOMEM;
+               if (!params)
                        continue;
-               }
 
                if (!found) {
                        ret_f = g_supplicant_interface_p2p_add_service(iface,
@@ -1340,10 +1344,8 @@ static int peer_unregister_service(const unsigned char *specification,
                params = fill_in_peer_service_params(specification,
                                                specification_length, query,
                                                query_length, version);
-               if (!params) {
-                       ret = -ENOMEM;
+               if (!params)
                        continue;
-               }
 
                ret = g_supplicant_interface_p2p_del_service(iface, params);
                if (ret != 0 && ret != -EINPROGRESS)
@@ -1487,13 +1489,13 @@ static void reset_autoscan(struct connman_device *device)
 
        autoscan = wifi->autoscan;
 
-       if (autoscan->timeout == 0 && autoscan->interval == 0)
+       autoscan->interval = 0;
+
+       if (autoscan->timeout == 0)
                return;
 
        g_source_remove(autoscan->timeout);
-
        autoscan->timeout = 0;
-       autoscan->interval = 0;
 
        connman_device_unref(device);
 }
@@ -1529,6 +1531,35 @@ static void check_p2p_technology(void)
        }
 }
 
+struct last_connected {
+       GTimeVal modified;
+       gchar *ssid;
+       int freq;
+};
+
+static gint sort_entry(gconstpointer a, gconstpointer b, gpointer user_data)
+{
+       GTimeVal *aval = (GTimeVal *)a;
+       GTimeVal *bval = (GTimeVal *)b;
+
+       /* Note that the sort order is descending */
+       if (aval->tv_sec < bval->tv_sec)
+               return 1;
+
+       if (aval->tv_sec > bval->tv_sec)
+               return -1;
+
+       return 0;
+}
+
+static void free_entry(gpointer data)
+{
+       struct last_connected *entry = data;
+
+       g_free(entry->ssid);
+       g_free(entry);
+}
+
 static void wifi_remove(struct connman_device *device)
 {
        struct wifi_data *wifi = connman_device_get_data(device);
@@ -1552,7 +1583,7 @@ static void wifi_remove(struct connman_device *device)
 
        remove_pending_wifi_device(wifi);
 
-       if (wifi->p2p_find_timeout) {
+       if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_P2P)) {
                g_source_remove(wifi->p2p_find_timeout);
                connman_device_unref(wifi->device);
        }
@@ -1716,12 +1747,25 @@ static int get_hidden_connections(GSupplicantScanParams *scan_data)
 {
        struct connman_config_entry **entries;
        GKeyFile *keyfile;
+#if defined TIZEN_EXT
+       gchar **services = NULL;
+#else
        gchar **services;
+#endif /* defined TIZEN_EXT */
        char *ssid, *name;
        int i, ret;
        bool value;
        int num_ssids = 0, add_param_failed = 0;
+#if defined TIZEN_EXT
+       GSequenceIter *iter;
+       GSequence *latest_list;
+       struct last_connected *entry;
+       GTimeVal modified;
 
+       latest_list = g_sequence_new(free_entry);
+       if (!latest_list)
+               goto out;
+#endif
        services = connman_storage_get_services();
        for (i = 0; services && services[i]; i++) {
                if (strncmp(services[i], "wifi_", 5) != 0)
@@ -1752,6 +1796,15 @@ static int get_hidden_connections(GSupplicantScanParams *scan_data)
                        g_key_file_free(keyfile);
                        continue;
                }
+
+               gchar *str = g_key_file_get_string(keyfile,
+                                       services[i], "Modified", NULL);
+               if (!str) {
+                       g_key_file_free(keyfile);
+                       continue;
+               }
+               g_time_val_from_iso8601(str, &modified);
+               g_free(str);
 #endif
 
                ssid = g_key_file_get_string(keyfile,
@@ -1760,6 +1813,22 @@ static int get_hidden_connections(GSupplicantScanParams *scan_data)
                name = g_key_file_get_string(keyfile, services[i], "Name",
                                                                NULL);
 
+#if defined TIZEN_EXT
+               entry = g_try_new(struct last_connected, 1);
+               if (!entry) {
+                       g_sequence_free(latest_list);
+                       g_free(ssid);
+                       g_free(name);
+                       g_key_file_free(keyfile);
+                       goto out;
+               }
+
+               entry->modified = modified;
+               entry->ssid = ssid;
+
+               g_sequence_insert_sorted(latest_list, entry,
+                               sort_entry, NULL);
+#else
                ret = add_scan_param(ssid, NULL, 0, 0, scan_data, 0, name);
                if (ret < 0)
                        add_param_failed++;
@@ -1767,10 +1836,30 @@ static int get_hidden_connections(GSupplicantScanParams *scan_data)
                        num_ssids++;
 
                g_free(ssid);
+#endif
                g_free(name);
                g_key_file_free(keyfile);
        }
 
+#if defined TIZEN_EXT
+       gint length = g_sequence_get_length(latest_list);
+       iter = g_sequence_get_begin_iter(latest_list);
+
+       for (i = 0; i < length; i++) {
+               entry = g_sequence_get(iter);
+
+               ret = add_scan_param(entry->ssid, NULL, 0, 0, scan_data, 0, entry->ssid);
+               if (ret < 0)
+                       add_param_failed++;
+               else if (ret > 0)
+                       num_ssids++;
+
+               iter = g_sequence_iter_next(iter);
+       }
+
+       g_sequence_free(latest_list);
+out:
+#endif
        /*
         * Check if there are any hidden AP that needs to be provisioned.
         */
@@ -1919,10 +2008,12 @@ static int throw_wifi_scan(struct connman_device *device,
 
        if (wifi->tethering)
                return -EBUSY;
+
 #if defined TIZEN_EXT
-       if (connman_device_get_scanning(device) && !wifi->allow_full_scan)
+       if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_WIFI)
+           && !wifi->allow_full_scan)
 #else
-       if (connman_device_get_scanning(device))
+       if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_WIFI))
 #endif
                return -EALREADY;
 
@@ -1989,6 +2080,9 @@ static void service_state_changed(struct connman_service *service,
                break;
        }
 }
+
+static void scan_callback_hidden(int result,
+                       GSupplicantInterface *interface, void *user_data);
 #endif
 
 static void scan_callback(int result, GSupplicantInterface *interface,
@@ -2050,7 +2144,7 @@ static void scan_callback(int result, GSupplicantInterface *interface,
                wifi->allow_full_scan = FALSE;
 
                ret = g_supplicant_interface_scan(wifi->interface, NULL,
-                                                       scan_callback, device);
+                                                       scan_callback_hidden, device);
                if (ret == 0)
                        return;
 
@@ -2059,10 +2153,12 @@ static void scan_callback(int result, GSupplicantInterface *interface,
        }
 #endif
 
-       scanning = connman_device_get_scanning(device);
-       if (scanning)
+       scanning = connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_WIFI);
+
+       if (scanning) {
                connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_WIFI, false);
+       }
 
        if (result != -ENOLINK)
 #if defined TIZEN_EXT
@@ -2128,7 +2224,6 @@ static void scan_callback_hidden(int result,
                                                        scan_callback_hidden,
 #endif
                                                        device);
-
                if (ret == 0)
                        return;
        }
@@ -2166,6 +2261,21 @@ static gboolean autoscan_timeout(gpointer data)
 
        throw_wifi_scan(wifi->device, scan_callback_hidden);
 
+       /*
+        * In case BackgroundScanning is disabled, interval will reach the
+        * limit exactly after the very first passive scanning. It allows
+        * to ensure at most one passive scan is performed in such cases.
+        */
+       if (!connman_setting_get_bool("BackgroundScanning") &&
+                                       interval == autoscan->limit) {
+               g_source_remove(autoscan->timeout);
+               autoscan->timeout = 0;
+
+               connman_device_unref(device);
+
+               return FALSE;
+       }
+
 set_interval:
        DBG("interval %d", interval);
 
@@ -2212,19 +2322,25 @@ static struct autoscan_params *parse_autoscan_params(const char *params)
        int limit;
        int base;
 
-       DBG("Emulating autoscan");
+       DBG("");
 
        list_params = g_strsplit(params, ":", 0);
        if (list_params == 0)
                return NULL;
 
-       if (g_strv_length(list_params) < 3) {
+       if (!g_strcmp0(list_params[0], "exponential") &&
+                               g_strv_length(list_params) == 3) {
+               base = atoi(list_params[1]);
+               limit = atoi(list_params[2]);
+       } else if (!g_strcmp0(list_params[0], "single") &&
+                               g_strv_length(list_params) == 2)
+               base = limit = atoi(list_params[1]);
+       else {
                g_strfreev(list_params);
                return NULL;
        }
 
-       base = atoi(list_params[1]);
-       limit = atoi(list_params[2]);
+       DBG("Setup %s autoscanning", list_params[0]);
 
        g_strfreev(list_params);
 
@@ -2243,10 +2359,37 @@ static struct autoscan_params *parse_autoscan_params(const char *params)
 
 static void setup_autoscan(struct wifi_data *wifi)
 {
-       if (!wifi->autoscan)
-               wifi->autoscan = parse_autoscan_params(AUTOSCAN_DEFAULT);
+       /*
+        * If BackgroundScanning is enabled, setup exponential
+        * autoscanning if it has not been previously done.
+        */
+       if (connman_setting_get_bool("BackgroundScanning")) {
+               wifi->autoscan = parse_autoscan_params(AUTOSCAN_EXPONENTIAL);
+               return;
+       }
 
-       start_autoscan(wifi->device);
+       /*
+        * On the contrary, if BackgroundScanning is disabled, update autoscan
+        * parameters based on the type of scanning that is being performed.
+        */
+       if (wifi->autoscan) {
+               g_free(wifi->autoscan);
+               wifi->autoscan = NULL;
+       }
+
+       switch (wifi->scanning_type) {
+       case WIFI_SCANNING_PASSIVE:
+               /* Do not setup autoscan. */
+               break;
+       case WIFI_SCANNING_ACTIVE:
+               /* Setup one single passive scan after active. */
+               wifi->autoscan = parse_autoscan_params(AUTOSCAN_SINGLE);
+               break;
+       case WIFI_SCANNING_UNKNOWN:
+               /* Setup autoscan in this case but we should never fall here. */
+               wifi->autoscan = parse_autoscan_params(AUTOSCAN_SINGLE);
+               break;
+       }
 }
 
 static void finalize_interface_creation(struct wifi_data *wifi)
@@ -2260,13 +2403,13 @@ static void finalize_interface_creation(struct wifi_data *wifi)
 
        connman_device_set_powered(wifi->device, true);
 
-       if (!connman_setting_get_bool("BackgroundScanning"))
-               return;
-
        if (wifi->p2p_device)
                return;
 
-       setup_autoscan(wifi);
+       if (!wifi->autoscan)
+               setup_autoscan(wifi);
+
+       start_autoscan(wifi->device);
 }
 
 static void interface_create_callback(int result,
@@ -2336,9 +2479,11 @@ static int wifi_disable(struct connman_device *device)
        if (wifi->pending_network)
                wifi->pending_network = NULL;
 
+#if !defined TIZEN_EXT
        stop_autoscan(device);
+#endif
 
-       if (wifi->p2p_find_timeout) {
+       if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_P2P)) {
                g_source_remove(wifi->p2p_find_timeout);
                wifi->p2p_find_timeout = 0;
                connman_device_set_scanning(device, CONNMAN_SERVICE_TYPE_P2P, false);
@@ -2353,12 +2498,16 @@ static int wifi_disable(struct connman_device *device)
 #endif
 
        /* In case of a user scan, device is still referenced */
-       if (connman_device_get_scanning(device)) {
+       if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_WIFI)) {
                connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_WIFI, false);
                connman_device_unref(wifi->device);
        }
 
+#if defined TIZEN_EXT
+       stop_autoscan(device);
+#endif
+
        remove_networks(device, wifi);
        remove_peers(wifi);
 
@@ -2378,35 +2527,6 @@ static int wifi_disable(struct connman_device *device)
        return -EINPROGRESS;
 }
 
-struct last_connected {
-       GTimeVal modified;
-       gchar *ssid;
-       int freq;
-};
-
-static gint sort_entry(gconstpointer a, gconstpointer b, gpointer user_data)
-{
-       GTimeVal *aval = (GTimeVal *)a;
-       GTimeVal *bval = (GTimeVal *)b;
-
-       /* Note that the sort order is descending */
-       if (aval->tv_sec < bval->tv_sec)
-               return 1;
-
-       if (aval->tv_sec > bval->tv_sec)
-               return -1;
-
-       return 0;
-}
-
-static void free_entry(gpointer data)
-{
-       struct last_connected *entry = data;
-
-       g_free(entry->ssid);
-       g_free(entry);
-}
-
 static int get_latest_connections(int max_ssids,
                                GSupplicantScanParams *scan_data)
 {
@@ -2510,10 +2630,29 @@ static int get_latest_connections(int max_ssids,
        return num_ssids;
 }
 
+static void wifi_update_scanner_type(struct wifi_data *wifi,
+                                       enum wifi_scanning_type new_type)
+{
+       DBG("");
+
+       if (!wifi || wifi->scanning_type == new_type)
+               return;
+
+       wifi->scanning_type = new_type;
+
+       setup_autoscan(wifi);
+}
+
 static int wifi_scan_simple(struct connman_device *device)
 {
+       struct wifi_data *wifi = connman_device_get_data(device);
+
        reset_autoscan(device);
 
+       /* Distinguish between devices performing passive and active scanning */
+       if (wifi)
+               wifi_update_scanner_type(wifi, WIFI_SCANNING_PASSIVE);
+
        return throw_wifi_scan(device, scan_callback_hidden);
 }
 
@@ -2533,7 +2672,7 @@ static gboolean p2p_find_stop(gpointer data)
        connman_device_set_scanning(device, CONNMAN_SERVICE_TYPE_P2P, false);
 
        connman_device_unref(device);
-       reset_autoscan(device);
+       start_autoscan(device);
 
        return FALSE;
 }
@@ -2613,7 +2752,8 @@ static void specific_scan_callback(int result, GSupplicantInterface *interface,
                wifi->scan_params = NULL;
        }
 
-       scanning = connman_device_get_scanning(device);
+       scanning = connman_device_get_scanning(device,
+                                              CONNMAN_SERVICE_TYPE_WIFI);
        if (scanning) {
                connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_WIFI, false);
@@ -2647,7 +2787,9 @@ static int wifi_specific_scan(enum connman_service_type type,
        if (wifi->tethering)
                return 0;
 
-       scanning = connman_device_get_scanning(device);
+       scanning =
+               connman_device_get_scanning(device,
+                                           CONNMAN_SERVICE_TYPE_WIFI);
        if (scanning)
                return -EALREADY;
 
@@ -2784,7 +2926,8 @@ static void mesh_scan_callback(int result, GSupplicantInterface *interface,
 
        DBG("result %d wifi %p", result, wifi);
 
-       scanning = connman_device_get_scanning(device);
+       scanning = connman_device_get_scanning(device,
+                                              CONNMAN_SERVICE_TYPE_MESH);
        if (scanning)
                connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_MESH, false);
@@ -2848,7 +2991,8 @@ static int mesh_abort_scan(enum connman_service_type type,
 
        mesh_info = wifi->mesh_info;
 
-       scanning = connman_device_get_scanning(device);
+       scanning = connman_device_get_scanning(device,
+                                              CONNMAN_SERVICE_TYPE_MESH);
        if (!scanning)
                return -EEXIST;
 
@@ -2880,7 +3024,8 @@ static int mesh_specific_scan(enum connman_service_type type,
 
        mesh_info = wifi->mesh_info;
 
-       scanning = connman_device_get_scanning(device);
+       scanning = connman_device_get_scanning(device,
+                                              CONNMAN_SERVICE_TYPE_MESH);
        if (scanning)
                return -EALREADY;
 
@@ -2931,11 +3076,8 @@ static int mesh_specific_scan(enum connman_service_type type,
  * Note that the hidden scan is only used when connecting to this specific
  * hidden AP first time. It is not used when system autoconnects to hidden AP.
  */
-static int wifi_scan(enum connman_service_type type,
-                       struct connman_device *device,
-                       const char *ssid, unsigned int ssid_len,
-                       const char *identity, const char* passphrase,
-                       const char *security, void *user_data)
+static int wifi_scan(struct connman_device *device,
+                       struct connman_device_scan_params *params)
 {
        struct wifi_data *wifi = connman_device_get_data(device);
        GSupplicantScanParams *scan_params = NULL;
@@ -2955,19 +3097,20 @@ static int wifi_scan(enum connman_service_type type,
        if (wifi->tethering)
                return -EBUSY;
 
-       if (type == CONNMAN_SERVICE_TYPE_P2P)
+       if (params->type == CONNMAN_SERVICE_TYPE_P2P)
                return p2p_find(device);
 
 #if defined TIZEN_EXT_WIFI_MESH
-       if (type == CONNMAN_SERVICE_TYPE_MESH)
+       if (params->type == CONNMAN_SERVICE_TYPE_MESH)
                return mesh_scan(device);
 #endif
 
-       DBG("device %p wifi %p hidden ssid %s", device, wifi->interface, ssid);
+       DBG("device %p wifi %p hidden ssid %s", device, wifi->interface,
+               params->ssid);
 
-       scanning = connman_device_get_scanning(device);
+       scanning = connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_WIFI);
 
-       if (!ssid || ssid_len == 0 || ssid_len > 32) {
+       if (!params->ssid || params->ssid_len == 0 || params->ssid_len > 32) {
                if (scanning)
                        return -EALREADY;
 
@@ -2996,8 +3139,8 @@ static int wifi_scan(enum connman_service_type type,
                        return -ENOMEM;
                }
 
-               memcpy(scan_ssid->ssid, ssid, ssid_len);
-               scan_ssid->ssid_len = ssid_len;
+               memcpy(scan_ssid->ssid, params->ssid, params->ssid_len);
+               scan_ssid->ssid_len = params->ssid_len;
                scan_params->ssids = g_slist_prepend(scan_params->ssids,
                                                                scan_ssid);
                scan_params->num_ssids = 1;
@@ -3013,12 +3156,12 @@ static int wifi_scan(enum connman_service_type type,
                        wifi->hidden = NULL;
                }
 
-               memcpy(hidden->ssid, ssid, ssid_len);
-               hidden->ssid_len = ssid_len;
-               hidden->identity = g_strdup(identity);
-               hidden->passphrase = g_strdup(passphrase);
-               hidden->security = g_strdup(security);
-               hidden->user_data = user_data;
+               memcpy(hidden->ssid, params->ssid, params->ssid_len);
+               hidden->ssid_len = params->ssid_len;
+               hidden->identity = g_strdup(params->identity);
+               hidden->passphrase = g_strdup(params->passphrase);
+               hidden->security = g_strdup(params->security);
+               hidden->user_data = params->user_data;
                wifi->hidden = hidden;
 
                if (scanning) {
@@ -3032,7 +3175,7 @@ static int wifi_scan(enum connman_service_type type,
        } else if (wifi->connected) {
                g_supplicant_free_scan_params(scan_params);
                return wifi_scan_simple(device);
-       } else {
+       } else if (!params->force_full_scan) {
                ret = get_latest_connections(driver_max_ssids, scan_params);
                if (ret <= 0) {
                        g_supplicant_free_scan_params(scan_params);
@@ -3040,13 +3183,15 @@ static int wifi_scan(enum connman_service_type type,
                }
        }
 
+       /* Distinguish between devices performing passive and active scanning */
+       wifi_update_scanner_type(wifi, WIFI_SCANNING_ACTIVE);
+
        connman_device_ref(device);
 
        reset_autoscan(device);
 
        ret = g_supplicant_interface_scan(wifi->interface, scan_params,
                                                scan_callback, device);
-
        if (ret == 0) {
                connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_WIFI, true);
@@ -3071,6 +3216,24 @@ static int wifi_scan(enum connman_service_type type,
        return ret;
 }
 
+static void wifi_stop_scan(enum connman_service_type type,
+                       struct connman_device *device)
+{
+       struct wifi_data *wifi = connman_device_get_data(device);
+
+       DBG("device %p wifi %p", device, wifi);
+
+       if (!wifi)
+               return;
+
+       if (type == CONNMAN_SERVICE_TYPE_P2P) {
+               if (connman_device_get_scanning(device, CONNMAN_SERVICE_TYPE_P2P)) {
+                       g_source_remove(wifi->p2p_find_timeout);
+                       p2p_find_stop(device);
+               }
+       }
+}
+
 static void wifi_regdom_callback(int result,
                                        const char *alpha2,
                                                void *user_data)
@@ -3110,6 +3273,7 @@ static struct connman_device_driver wifi_ng_driver = {
        .enable         = wifi_enable,
        .disable        = wifi_disable,
        .scan           = wifi_scan,
+       .stop_scan      = wifi_stop_scan,
        .set_regdom     = wifi_set_regdom,
 #if defined TIZEN_EXT
        .specific_scan  = wifi_specific_scan,
@@ -3229,6 +3393,8 @@ static GSupplicantSecurity network_security(const char *security)
                return G_SUPPLICANT_SECURITY_SAE;
        else if (g_str_equal(security, "owe"))
                return G_SUPPLICANT_SECURITY_OWE;
+       else if (g_str_equal(security, "dpp"))
+               return G_SUPPLICANT_SECURITY_DPP;
 #endif
 
        return G_SUPPLICANT_SECURITY_UNKNOWN;
@@ -3279,6 +3445,7 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network)
 #endif
        ssid->passphrase = connman_network_get_string(network,
                                                "WiFi.Passphrase");
+
        ssid->eap = connman_network_get_string(network, "WiFi.EAP");
 
        /*
@@ -3321,6 +3488,14 @@ static void ssid_init(GSupplicantSSID *ssid, struct connman_network *network)
 
        ssid->use_wps = connman_network_get_bool(network, "WiFi.UseWPS");
        ssid->pin_wps = connman_network_get_string(network, "WiFi.PinWPS");
+#if defined TIZEN_EXT
+       ssid->connector = connman_network_get_string(network,
+                                                       "WiFi.Connector");
+       ssid->c_sign_key = connman_network_get_string(network,
+                                                       "WiFi.CSignKey");
+       ssid->net_access_key = connman_network_get_string(network,
+                                               "WiFi.NetAccessKey");
+#endif
 
 #if defined TIZEN_EXT
        if (set_connman_bssid(CHECK_BSSID, NULL) == 6) {
@@ -3472,10 +3647,9 @@ found:
                return;
        }
 
-       if (wifi->network) {
+       if (wifi->network != wifi->pending_network)
                connman_network_set_connected(wifi->network, false);
-               wifi->network = NULL;
-       }
+       wifi->network = NULL;
 
        wifi->disconnecting = false;
        wifi->connected = false;
@@ -3975,17 +4149,20 @@ static void interface_state(GSupplicantInterface *interface)
        if (!wifi)
                return;
 
+       device = wifi->device;
+       if (!device)
+               return;
+
        if (state == G_SUPPLICANT_STATE_COMPLETED) {
                if (wifi->tethering_param) {
                        g_free(wifi->tethering_param->ssid);
                        g_free(wifi->tethering_param);
                        wifi->tethering_param = NULL;
                }
-       }
 
-       device = wifi->device;
-       if (!device)
-               return;
+               if (wifi->tethering)
+                       stop_autoscan(device);
+       }
 
        if (g_supplicant_interface_get_ready(interface) &&
                                        !wifi->interface_ready) {
@@ -4027,7 +4204,8 @@ static void interface_state(GSupplicantInterface *interface)
                wifi->scan_pending_network = NULL;
 
                /* should be cleared scanning flag */
-               bool scanning = connman_device_get_scanning(device);
+               bool scanning = connman_device_get_scanning(device,
+                                              CONNMAN_SERVICE_TYPE_WIFI);
                if (scanning){
                        connman_device_set_scanning(device,
                                CONNMAN_SERVICE_TYPE_WIFI, false);
@@ -4143,8 +4321,10 @@ static void interface_state(GSupplicantInterface *interface)
                }
 #endif
 
-               connman_network_set_connected(network, false);
-               connman_network_set_associating(network, false);
+               if (network != wifi->pending_network) {
+                       connman_network_set_connected(network, false);
+                       connman_network_set_associating(network, false);
+               }
                wifi->disconnecting = false;
 
                start_autoscan(device);
@@ -4370,8 +4550,6 @@ static void ap_create_fail(GSupplicantInterface *interface)
                g_free(wifi->tethering_param);
                wifi->tethering_param = NULL;
        }
-
-       return;
 }
 
 static unsigned char calculate_strength(GSupplicantNetwork *supplicant_network)
@@ -4379,11 +4557,11 @@ static unsigned char calculate_strength(GSupplicantNetwork *supplicant_network)
        unsigned char strength;
 
        strength = 120 + g_supplicant_network_get_signal(supplicant_network);
-
 #if !defined TIZEN_EXT
        if (strength > 100)
                strength = 100;
 #endif
+
        return strength;
 }
 
@@ -4566,22 +4744,24 @@ static void network_added(GSupplicantNetwork *supplicant_network)
        connman_network_set_strength(network,
                                calculate_strength(supplicant_network));
        connman_network_set_bool(network, "WiFi.WPS", wps);
+       connman_network_set_bool(network, "WiFi.WPSAdvertising",
+                               wps_advertizing);
 
        if (wps) {
                /* Is AP advertizing for WPS association?
                 * If so, we decide to use WPS by default */
                if (wps_ready && wps_pbc &&
-                                               wps_advertizing) {
+                                               wps_advertizing)
 #if !defined TIZEN_EXT
                        connman_network_set_bool(network, "WiFi.UseWPS", true);
 #else
                        DBG("wps is activating by ap but ignore it.");
 #endif
-               }
        }
 
        connman_network_set_frequency(network,
                        g_supplicant_network_get_frequency(supplicant_network));
+
 #if defined TIZEN_EXT
        connman_network_set_bssid(network,
                        g_supplicant_network_get_bssid(supplicant_network));
@@ -4687,6 +4867,7 @@ static void network_changed(GSupplicantNetwork *network, const char *property)
        struct wifi_data *wifi;
        const char *name, *identifier;
        struct connman_network *connman_network;
+       bool update_needed;
 
 #if defined TIZEN_EXT
        const unsigned char *bssid;
@@ -4712,11 +4893,42 @@ static void network_changed(GSupplicantNetwork *network, const char *property)
        if (!connman_network)
                return;
 
-       if (g_str_equal(property, "Signal")) {
-              connman_network_set_strength(connman_network,
+       if (g_str_equal(property, "WPSCapabilities")) {
+               bool wps;
+               bool wps_pbc;
+               bool wps_ready;
+               bool wps_advertizing;
+
+               wps = g_supplicant_network_get_wps(network);
+               wps_pbc = g_supplicant_network_is_wps_pbc(network);
+               wps_ready = g_supplicant_network_is_wps_active(network);
+               wps_advertizing =
+                       g_supplicant_network_is_wps_advertizing(network);
+
+               connman_network_set_bool(connman_network, "WiFi.WPS", wps);
+               connman_network_set_bool(connman_network,
+                               "WiFi.WPSAdvertising", wps_advertizing);
+
+               if (wps) {
+                       /*
+                        * Is AP advertizing for WPS association?
+                        * If so, we decide to use WPS by default
+                        */
+                       if (wps_ready && wps_pbc && wps_advertizing)
+                               connman_network_set_bool(connman_network,
+                                                       "WiFi.UseWPS", true);
+               }
+
+               update_needed = true;
+       } else if (g_str_equal(property, "Signal")) {
+               connman_network_set_strength(connman_network,
                                        calculate_strength(network));
-              connman_network_update(connman_network);
-       }
+               update_needed = true;
+       } else
+               update_needed = false;
+
+       if (update_needed)
+               connman_network_update(connman_network);
 
 #if defined TIZEN_EXT
        bssid = g_supplicant_network_get_bssid(network);
@@ -4758,6 +4970,10 @@ static void network_associated(GSupplicantNetwork *network)
        if (!wifi)
                return;
 
+       /* P2P networks must not be treated as WiFi networks */
+       if (wifi->p2p_connecting || wifi->p2p_device)
+               return;
+
        identifier = g_supplicant_network_get_identifier(network);
 
        connman_network = connman_device_get_network(wifi->device, identifier);
@@ -4792,6 +5008,32 @@ static void network_associated(GSupplicantNetwork *network)
        interface_state(interface);
 }
 
+static void sta_authorized(GSupplicantInterface *interface,
+                                       const char *addr)
+{
+       struct wifi_data *wifi = g_supplicant_interface_get_data(interface);
+
+       DBG("wifi %p station %s authorized", wifi, addr);
+
+       if (!wifi || !wifi->tethering)
+               return;
+
+       __connman_tethering_client_register(addr);
+}
+
+static void sta_deauthorized(GSupplicantInterface *interface,
+                                       const char *addr)
+{
+       struct wifi_data *wifi = g_supplicant_interface_get_data(interface);
+
+       DBG("wifi %p station %s deauthorized", wifi, addr);
+
+       if (!wifi || !wifi->tethering)
+               return;
+
+       __connman_tethering_client_unregister(addr);
+}
+
 static void apply_peer_services(GSupplicantPeer *peer,
                                struct connman_peer *connman_peer)
 {
@@ -4809,17 +5051,6 @@ static void apply_peer_services(GSupplicantPeer *peer,
        }
 }
 
-static void add_station(const char *mac)
-{
-       connman_technology_tethering_add_station(CONNMAN_SERVICE_TYPE_WIFI,
-                                                mac);
-}
-
-static void remove_station(const char *mac)
-{
-       connman_technology_tethering_remove_station(mac);
-}
-
 static void peer_found(GSupplicantPeer *peer)
 {
        GSupplicantInterface *iface = g_supplicant_peer_get_interface(peer);
@@ -4827,6 +5058,7 @@ static void peer_found(GSupplicantPeer *peer)
        struct connman_peer *connman_peer;
        const char *identifier, *name;
        int ret;
+
 #if defined TIZEN_EXT
        if (!wifi)
                return;
@@ -5125,8 +5357,8 @@ static const GSupplicantCallbacks callbacks = {
        .network_removed        = network_removed,
        .network_changed        = network_changed,
        .network_associated     = network_associated,
-       .add_station            = add_station,
-       .remove_station         = remove_station,
+       .sta_authorized         = sta_authorized,
+       .sta_deauthorized       = sta_deauthorized,
        .peer_found             = peer_found,
        .peer_lost              = peer_lost,
        .peer_changed           = peer_changed,
@@ -5161,8 +5393,7 @@ static void tech_remove(struct connman_technology *technology)
        wifi_technology = NULL;
 }
 
-static GSupplicantSSID *ssid_ap_init(const char *ssid,
-               const char *passphrase)
+static GSupplicantSSID *ssid_ap_init(const char *ssid, const char *passphrase)
 {
        GSupplicantSSID *ap;
 
@@ -5264,19 +5495,27 @@ static void sta_remove_callback(int result,
 
        DBG("ifname %s result %d ", info->ifname, result);
 
-       if (result < 0 || (info->wifi->ap_supported != WIFI_AP_SUPPORTED)) {
+       if ((result < 0) || (info->wifi->ap_supported != WIFI_AP_SUPPORTED)) {
                info->wifi->tethering = false;
                connman_technology_tethering_notify(info->technology, false);
+#if !defined TIZEN_EXT
 
                g_free(info->ifname);
                g_free(info->ssid);
                g_free(info);
+#endif /* !defined TIZEN_EXT */
 
                if (info->wifi->ap_supported == WIFI_AP_SUPPORTED) {
                        g_free(info->wifi->tethering_param->ssid);
                        g_free(info->wifi->tethering_param);
                        info->wifi->tethering_param = NULL;
                }
+#if defined TIZEN_EXT
+
+               g_free(info->ifname);
+               g_free(info->ssid);
+               g_free(info);
+#endif /* defined TIZEN_EXT */
                return;
        }
 
@@ -5310,10 +5549,9 @@ static int enable_wifi_tethering(struct connman_technology *technology,
                if (!interface)
                        continue;
 
-               if (wifi->ap_supported == WIFI_AP_NOT_SUPPORTED)
-                       continue;
-
                ifname = g_supplicant_interface_get_ifname(wifi->interface);
+               if (!ifname)
+                       continue;
 
                if (wifi->ap_supported == WIFI_AP_NOT_SUPPORTED) {
                        DBG("%s does not support AP mode (detected)", ifname);
@@ -5348,8 +5586,6 @@ static int enable_wifi_tethering(struct connman_technology *technology,
                        goto failed;
 
                info->ifname = g_strdup(ifname);
-               if (!info->ifname)
-                       goto failed;
 
                wifi->tethering_param->technology = technology;
                wifi->tethering_param->ssid = ssid_ap_init(identifier, passphrase);